Re: [PATCH v13 net-next 05/15] net: mvpp2: add PPv23 version definition - Russell King

From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: stefanc@marvell.com
Cc: netdev@vger.kernel.org, thomas.petazzoni@bootlin.com,
	davem@davemloft.net, nadavh@marvell.com, ymarkman@marvell.com,
	linux-kernel@vger.kernel.org, kuba@kernel.org, mw@semihalf.com,
	andrew@lunn.ch, atenart@kernel.org, devicetree@vger.kernel.org,
	robh+dt@kernel.org, sebastian.hesselbarth@gmail.com,
	gregory.clement@bootlin.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v13 net-next 05/15] net: mvpp2: add PPv23 version definition
Date: Thu, 11 Feb 2021 11:42:38 +0000	[thread overview]
Message-ID: <20210211114238.GD1463@shell.armlinux.org.uk> (raw)
In-Reply-To: <1613040542-16500-6-git-send-email-stefanc@marvell.com>

On Thu, Feb 11, 2021 at 12:48:52PM +0200, stefanc@marvell.com wrote:
> From: Stefan Chulski <stefanc@marvell.com>
> 
> This patch add PPv23 version definition.
> PPv23 is new packet processor in CP115.
> Everything that supported by PPv22, also supported by PPv23.
> No functional changes in this stage.
> 
> Signed-off-by: Stefan Chulski <stefanc@marvell.com>
> Acked-by: Marcin Wojtas <mw@semihalf.com>

Reviewed-by: Russell King <rmk+kernel@armlinux.org.uk>

> @@ -7049,6 +7049,11 @@ static int mvpp2_probe(struct platform_device *pdev)
>  			priv->port_map |= BIT(i);
>  	}
>  
> +	if (priv->hw_version != MVPP21) {
> +		if (mvpp2_read(priv, MVPP2_VER_ID_REG) == MVPP2_VER_PP23)
> +			priv->hw_version = MVPP23;
> +	}
> +

The only minor comment I have on this is... the formatting of the
above. Wouldn't:

	if (priv->hw_version >= MVPP22 &&
	    mvpp2_read(priv, MVPP2_VER_ID_REG) == MVPP2_VER_PP23)
		priv->hw_version = MVPP23;

read better?

Do we need to even check priv->hw_version here? Isn't this register
implemented in PPv2.1 where it contains the value zero?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!