* [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types
@ 2022-06-15 22:14 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-06-15 22:14 UTC (permalink / raw)
To: devicetree, linux-media, dri-devel
Cc: linux-arm-kernel, Rob Herring, Sakari Ailus, Jacopo Mondi,
Eugen Hristev, Hugues Fruchet, Maxime Coquelin, Alexandre Torgue,
Lad Prabhakar, Fabio Estevam, Shawn Guo
Hello,
This small patch series is the result of me getting a bus-type numerical
value wrong in a device tree file and spending too long debugging the
issue. Hopefully there's nothing controversial here.
Compared to v2, the PARALLEL bus type came back to replace BT601, as it
turned out that BT601 doesn't actually describe what is usually referred
to as the parallel bus type. Patch 3/3 has been split in per-vendor
patches at the request of Alexandre Torgue.
Laurent Pinchart (6):
dt-bindings: media: Add macros for video interface bus types
dt-bindings: Use new video interface bus type macros in examples
ARM: dts: freescale: Use new media bus type macros
ARM: dts: omap: Use new media bus type macros
ARM: dts: renesas: Use new media bus type macros
ARM: dts: stm32: Use new media bus type macros
.../display/bridge/analogix,anx7625.yaml | 1 +
.../devicetree/bindings/media/i2c/mipi-ccs.yaml | 3 ++-
.../bindings/media/i2c/ovti,ov772x.yaml | 3 ++-
.../bindings/media/marvell,mmp2-ccic.yaml | 3 ++-
.../bindings/media/microchip,xisc.yaml | 3 ++-
.../devicetree/bindings/media/st,stm32-dcmi.yaml | 4 +++-
arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 4 +++-
arch/arm/boot/dts/omap3-n900.dts | 5 +++--
arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++----
.../r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++-
.../r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++-
arch/arm/boot/dts/stm32429i-eval.dts | 3 ++-
arch/arm/boot/dts/stm32mp157c-ev1.dts | 3 ++-
include/dt-bindings/media/video-interfaces.h | 16 ++++++++++++++++
14 files changed, 51 insertions(+), 16 deletions(-)
create mode 100644 include/dt-bindings/media/video-interfaces.h
base-commit: b13baccc3850ca8b8cccbf8ed9912dbaa0fdf7f3
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 102+ messages in thread
* [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types
@ 2022-06-15 22:14 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-06-15 22:14 UTC (permalink / raw)
To: devicetree, linux-media, dri-devel
Cc: Jacopo Mondi, Maxime Coquelin, Hugues Fruchet, Alexandre Torgue,
Shawn Guo, Lad Prabhakar, Rob Herring, Sakari Ailus,
Eugen Hristev, linux-arm-kernel
Hello,
This small patch series is the result of me getting a bus-type numerical
value wrong in a device tree file and spending too long debugging the
issue. Hopefully there's nothing controversial here.
Compared to v2, the PARALLEL bus type came back to replace BT601, as it
turned out that BT601 doesn't actually describe what is usually referred
to as the parallel bus type. Patch 3/3 has been split in per-vendor
patches at the request of Alexandre Torgue.
Laurent Pinchart (6):
dt-bindings: media: Add macros for video interface bus types
dt-bindings: Use new video interface bus type macros in examples
ARM: dts: freescale: Use new media bus type macros
ARM: dts: omap: Use new media bus type macros
ARM: dts: renesas: Use new media bus type macros
ARM: dts: stm32: Use new media bus type macros
.../display/bridge/analogix,anx7625.yaml | 1 +
.../devicetree/bindings/media/i2c/mipi-ccs.yaml | 3 ++-
.../bindings/media/i2c/ovti,ov772x.yaml | 3 ++-
.../bindings/media/marvell,mmp2-ccic.yaml | 3 ++-
.../bindings/media/microchip,xisc.yaml | 3 ++-
.../devicetree/bindings/media/st,stm32-dcmi.yaml | 4 +++-
arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 4 +++-
arch/arm/boot/dts/omap3-n900.dts | 5 +++--
arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++----
.../r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++-
.../r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++-
arch/arm/boot/dts/stm32429i-eval.dts | 3 ++-
arch/arm/boot/dts/stm32mp157c-ev1.dts | 3 ++-
include/dt-bindings/media/video-interfaces.h | 16 ++++++++++++++++
14 files changed, 51 insertions(+), 16 deletions(-)
create mode 100644 include/dt-bindings/media/video-interfaces.h
base-commit: b13baccc3850ca8b8cccbf8ed9912dbaa0fdf7f3
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 102+ messages in thread
* [PATCH v3 1/6] dt-bindings: media: Add macros for video interface bus types
2022-06-15 22:14 ` Laurent Pinchart
(?)
@ 2022-06-15 22:14 ` Laurent Pinchart
-1 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-06-15 22:14 UTC (permalink / raw)
To: devicetree, linux-media, dri-devel
Cc: linux-arm-kernel, Rob Herring, Sakari Ailus, Jacopo Mondi,
Eugen Hristev, Hugues Fruchet, Maxime Coquelin, Alexandre Torgue,
Lad Prabhakar, Fabio Estevam, Shawn Guo
Add a new dt-bindings/media/video-interfaces.h header that defines
macros corresponding to the bus types from media/video-interfaces.yaml.
This allows avoiding hardcoded constants in device tree sources.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
Changes since v2:
- Go back to PARALLEL
Changes since v1:
- Dual-license under GPL-2.0-only or MIT
- Rename PARALLEL TO BT601
---
include/dt-bindings/media/video-interfaces.h | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 include/dt-bindings/media/video-interfaces.h
diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h
new file mode 100644
index 000000000000..68ac4e05e37f
--- /dev/null
+++ b/include/dt-bindings/media/video-interfaces.h
@@ -0,0 +1,16 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
+/*
+ * Copyright (C) 2022 Laurent Pinchart <laurent.pinchart@ideasonboard.com>
+ */
+
+#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__
+#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__
+
+#define MEDIA_BUS_TYPE_CSI2_CPHY 1
+#define MEDIA_BUS_TYPE_CSI1 2
+#define MEDIA_BUS_TYPE_CCP2 3
+#define MEDIA_BUS_TYPE_CSI2_DPHY 4
+#define MEDIA_BUS_TYPE_PARALLEL 5
+#define MEDIA_BUS_TYPE_BT656 6
+
+#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ */
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 102+ messages in thread
* [PATCH v3 1/6] dt-bindings: media: Add macros for video interface bus types
@ 2022-06-15 22:14 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-06-15 22:14 UTC (permalink / raw)
To: devicetree, linux-media, dri-devel
Cc: linux-arm-kernel, Rob Herring, Sakari Ailus, Jacopo Mondi,
Eugen Hristev, Hugues Fruchet, Maxime Coquelin, Alexandre Torgue,
Lad Prabhakar, Fabio Estevam, Shawn Guo
Add a new dt-bindings/media/video-interfaces.h header that defines
macros corresponding to the bus types from media/video-interfaces.yaml.
This allows avoiding hardcoded constants in device tree sources.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
Changes since v2:
- Go back to PARALLEL
Changes since v1:
- Dual-license under GPL-2.0-only or MIT
- Rename PARALLEL TO BT601
---
include/dt-bindings/media/video-interfaces.h | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 include/dt-bindings/media/video-interfaces.h
diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h
new file mode 100644
index 000000000000..68ac4e05e37f
--- /dev/null
+++ b/include/dt-bindings/media/video-interfaces.h
@@ -0,0 +1,16 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
+/*
+ * Copyright (C) 2022 Laurent Pinchart <laurent.pinchart@ideasonboard.com>
+ */
+
+#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__
+#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__
+
+#define MEDIA_BUS_TYPE_CSI2_CPHY 1
+#define MEDIA_BUS_TYPE_CSI1 2
+#define MEDIA_BUS_TYPE_CCP2 3
+#define MEDIA_BUS_TYPE_CSI2_DPHY 4
+#define MEDIA_BUS_TYPE_PARALLEL 5
+#define MEDIA_BUS_TYPE_BT656 6
+
+#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ */
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 102+ messages in thread
* [PATCH v3 1/6] dt-bindings: media: Add macros for video interface bus types
@ 2022-06-15 22:14 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-06-15 22:14 UTC (permalink / raw)
To: devicetree, linux-media, dri-devel
Cc: Jacopo Mondi, Maxime Coquelin, Hugues Fruchet, Alexandre Torgue,
Shawn Guo, Lad Prabhakar, Rob Herring, Sakari Ailus,
Eugen Hristev, linux-arm-kernel
Add a new dt-bindings/media/video-interfaces.h header that defines
macros corresponding to the bus types from media/video-interfaces.yaml.
This allows avoiding hardcoded constants in device tree sources.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
Changes since v2:
- Go back to PARALLEL
Changes since v1:
- Dual-license under GPL-2.0-only or MIT
- Rename PARALLEL TO BT601
---
include/dt-bindings/media/video-interfaces.h | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 include/dt-bindings/media/video-interfaces.h
diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h
new file mode 100644
index 000000000000..68ac4e05e37f
--- /dev/null
+++ b/include/dt-bindings/media/video-interfaces.h
@@ -0,0 +1,16 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
+/*
+ * Copyright (C) 2022 Laurent Pinchart <laurent.pinchart@ideasonboard.com>
+ */
+
+#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__
+#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__
+
+#define MEDIA_BUS_TYPE_CSI2_CPHY 1
+#define MEDIA_BUS_TYPE_CSI1 2
+#define MEDIA_BUS_TYPE_CCP2 3
+#define MEDIA_BUS_TYPE_CSI2_DPHY 4
+#define MEDIA_BUS_TYPE_PARALLEL 5
+#define MEDIA_BUS_TYPE_BT656 6
+
+#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ */
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 102+ messages in thread
* Re: [PATCH v3 1/6] dt-bindings: media: Add macros for video interface bus types
2022-06-15 22:14 ` Laurent Pinchart
(?)
@ 2022-06-27 22:14 ` Rob Herring
-1 siblings, 0 replies; 102+ messages in thread
From: Rob Herring @ 2022-06-27 22:14 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Lad Prabhakar, Hugues Fruchet, Eugen Hristev, Shawn Guo,
Rob Herring, Sakari Ailus, Maxime Coquelin, linux-arm-kernel,
Jacopo Mondi, linux-media, Alexandre Torgue, devicetree,
Fabio Estevam, dri-devel
On Thu, 16 Jun 2022 01:14:05 +0300, Laurent Pinchart wrote:
> Add a new dt-bindings/media/video-interfaces.h header that defines
> macros corresponding to the bus types from media/video-interfaces.yaml.
> This allows avoiding hardcoded constants in device tree sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes since v2:
>
> - Go back to PARALLEL
>
> Changes since v1:
>
> - Dual-license under GPL-2.0-only or MIT
> - Rename PARALLEL TO BT601
> ---
> include/dt-bindings/media/video-interfaces.h | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
> create mode 100644 include/dt-bindings/media/video-interfaces.h
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 1/6] dt-bindings: media: Add macros for video interface bus types
@ 2022-06-27 22:14 ` Rob Herring
0 siblings, 0 replies; 102+ messages in thread
From: Rob Herring @ 2022-06-27 22:14 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Lad Prabhakar, Hugues Fruchet, Eugen Hristev, Shawn Guo,
Rob Herring, Sakari Ailus, Maxime Coquelin, linux-arm-kernel,
Jacopo Mondi, linux-media, Alexandre Torgue, devicetree,
Fabio Estevam, dri-devel
On Thu, 16 Jun 2022 01:14:05 +0300, Laurent Pinchart wrote:
> Add a new dt-bindings/media/video-interfaces.h header that defines
> macros corresponding to the bus types from media/video-interfaces.yaml.
> This allows avoiding hardcoded constants in device tree sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes since v2:
>
> - Go back to PARALLEL
>
> Changes since v1:
>
> - Dual-license under GPL-2.0-only or MIT
> - Rename PARALLEL TO BT601
> ---
> include/dt-bindings/media/video-interfaces.h | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
> create mode 100644 include/dt-bindings/media/video-interfaces.h
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 1/6] dt-bindings: media: Add macros for video interface bus types
@ 2022-06-27 22:14 ` Rob Herring
0 siblings, 0 replies; 102+ messages in thread
From: Rob Herring @ 2022-06-27 22:14 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, Jacopo Mondi, Maxime Coquelin, Hugues Fruchet,
Lad Prabhakar, dri-devel, Alexandre Torgue, Rob Herring,
Sakari Ailus, Eugen Hristev, Shawn Guo, linux-arm-kernel,
linux-media
On Thu, 16 Jun 2022 01:14:05 +0300, Laurent Pinchart wrote:
> Add a new dt-bindings/media/video-interfaces.h header that defines
> macros corresponding to the bus types from media/video-interfaces.yaml.
> This allows avoiding hardcoded constants in device tree sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes since v2:
>
> - Go back to PARALLEL
>
> Changes since v1:
>
> - Dual-license under GPL-2.0-only or MIT
> - Rename PARALLEL TO BT601
> ---
> include/dt-bindings/media/video-interfaces.h | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
> create mode 100644 include/dt-bindings/media/video-interfaces.h
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 1/6] dt-bindings: media: Add macros for video interface bus types
2022-06-15 22:14 ` Laurent Pinchart
(?)
@ 2022-06-28 10:46 ` Jacopo Mondi
-1 siblings, 0 replies; 102+ messages in thread
From: Jacopo Mondi @ 2022-06-28 10:46 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Eugen Hristev, Hugues Fruchet,
Maxime Coquelin, Alexandre Torgue, Lad Prabhakar, Fabio Estevam,
Shawn Guo
Hi Laurent
On Thu, Jun 16, 2022 at 01:14:05AM +0300, Laurent Pinchart wrote:
> Add a new dt-bindings/media/video-interfaces.h header that defines
> macros corresponding to the bus types from media/video-interfaces.yaml.
> This allows avoiding hardcoded constants in device tree sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Just putting a tag here as we have more flags to add here (in example
the device orientation)
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
> ---
> Changes since v2:
>
> - Go back to PARALLEL
>
> Changes since v1:
>
> - Dual-license under GPL-2.0-only or MIT
> - Rename PARALLEL TO BT601
> ---
> include/dt-bindings/media/video-interfaces.h | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
> create mode 100644 include/dt-bindings/media/video-interfaces.h
>
> diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h
> new file mode 100644
> index 000000000000..68ac4e05e37f
> --- /dev/null
> +++ b/include/dt-bindings/media/video-interfaces.h
> @@ -0,0 +1,16 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
> +/*
> + * Copyright (C) 2022 Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> + */
> +
> +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__
> +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__
> +
> +#define MEDIA_BUS_TYPE_CSI2_CPHY 1
> +#define MEDIA_BUS_TYPE_CSI1 2
> +#define MEDIA_BUS_TYPE_CCP2 3
> +#define MEDIA_BUS_TYPE_CSI2_DPHY 4
> +#define MEDIA_BUS_TYPE_PARALLEL 5
> +#define MEDIA_BUS_TYPE_BT656 6
> +
> +#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ */
> --
> Regards,
>
> Laurent Pinchart
>
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 1/6] dt-bindings: media: Add macros for video interface bus types
@ 2022-06-28 10:46 ` Jacopo Mondi
0 siblings, 0 replies; 102+ messages in thread
From: Jacopo Mondi @ 2022-06-28 10:46 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, Maxime Coquelin, Hugues Fruchet, Alexandre Torgue,
dri-devel, Lad Prabhakar, Rob Herring, Sakari Ailus,
Eugen Hristev, Shawn Guo, linux-arm-kernel, linux-media
Hi Laurent
On Thu, Jun 16, 2022 at 01:14:05AM +0300, Laurent Pinchart wrote:
> Add a new dt-bindings/media/video-interfaces.h header that defines
> macros corresponding to the bus types from media/video-interfaces.yaml.
> This allows avoiding hardcoded constants in device tree sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Just putting a tag here as we have more flags to add here (in example
the device orientation)
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
> ---
> Changes since v2:
>
> - Go back to PARALLEL
>
> Changes since v1:
>
> - Dual-license under GPL-2.0-only or MIT
> - Rename PARALLEL TO BT601
> ---
> include/dt-bindings/media/video-interfaces.h | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
> create mode 100644 include/dt-bindings/media/video-interfaces.h
>
> diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h
> new file mode 100644
> index 000000000000..68ac4e05e37f
> --- /dev/null
> +++ b/include/dt-bindings/media/video-interfaces.h
> @@ -0,0 +1,16 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
> +/*
> + * Copyright (C) 2022 Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> + */
> +
> +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__
> +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__
> +
> +#define MEDIA_BUS_TYPE_CSI2_CPHY 1
> +#define MEDIA_BUS_TYPE_CSI1 2
> +#define MEDIA_BUS_TYPE_CCP2 3
> +#define MEDIA_BUS_TYPE_CSI2_DPHY 4
> +#define MEDIA_BUS_TYPE_PARALLEL 5
> +#define MEDIA_BUS_TYPE_BT656 6
> +
> +#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ */
> --
> Regards,
>
> Laurent Pinchart
>
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 1/6] dt-bindings: media: Add macros for video interface bus types
@ 2022-06-28 10:46 ` Jacopo Mondi
0 siblings, 0 replies; 102+ messages in thread
From: Jacopo Mondi @ 2022-06-28 10:46 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Eugen Hristev, Hugues Fruchet,
Maxime Coquelin, Alexandre Torgue, Lad Prabhakar, Fabio Estevam,
Shawn Guo
Hi Laurent
On Thu, Jun 16, 2022 at 01:14:05AM +0300, Laurent Pinchart wrote:
> Add a new dt-bindings/media/video-interfaces.h header that defines
> macros corresponding to the bus types from media/video-interfaces.yaml.
> This allows avoiding hardcoded constants in device tree sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Just putting a tag here as we have more flags to add here (in example
the device orientation)
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
> ---
> Changes since v2:
>
> - Go back to PARALLEL
>
> Changes since v1:
>
> - Dual-license under GPL-2.0-only or MIT
> - Rename PARALLEL TO BT601
> ---
> include/dt-bindings/media/video-interfaces.h | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
> create mode 100644 include/dt-bindings/media/video-interfaces.h
>
> diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h
> new file mode 100644
> index 000000000000..68ac4e05e37f
> --- /dev/null
> +++ b/include/dt-bindings/media/video-interfaces.h
> @@ -0,0 +1,16 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
> +/*
> + * Copyright (C) 2022 Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> + */
> +
> +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__
> +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__
> +
> +#define MEDIA_BUS_TYPE_CSI2_CPHY 1
> +#define MEDIA_BUS_TYPE_CSI1 2
> +#define MEDIA_BUS_TYPE_CCP2 3
> +#define MEDIA_BUS_TYPE_CSI2_DPHY 4
> +#define MEDIA_BUS_TYPE_PARALLEL 5
> +#define MEDIA_BUS_TYPE_BT656 6
> +
> +#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ */
> --
> Regards,
>
> Laurent Pinchart
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 1/6] dt-bindings: media: Add macros for video interface bus types
2022-06-15 22:14 ` Laurent Pinchart
(?)
@ 2022-11-17 10:02 ` Paul Elder
-1 siblings, 0 replies; 102+ messages in thread
From: Paul Elder @ 2022-11-17 10:02 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo
On Thu, Jun 16, 2022 at 01:14:05AM +0300, Laurent Pinchart wrote:
> Add a new dt-bindings/media/video-interfaces.h header that defines
> macros corresponding to the bus types from media/video-interfaces.yaml.
> This allows avoiding hardcoded constants in device tree sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
> ---
> Changes since v2:
>
> - Go back to PARALLEL
>
> Changes since v1:
>
> - Dual-license under GPL-2.0-only or MIT
> - Rename PARALLEL TO BT601
> ---
> include/dt-bindings/media/video-interfaces.h | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
> create mode 100644 include/dt-bindings/media/video-interfaces.h
>
> diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h
> new file mode 100644
> index 000000000000..68ac4e05e37f
> --- /dev/null
> +++ b/include/dt-bindings/media/video-interfaces.h
> @@ -0,0 +1,16 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
> +/*
> + * Copyright (C) 2022 Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> + */
> +
> +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__
> +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__
> +
> +#define MEDIA_BUS_TYPE_CSI2_CPHY 1
> +#define MEDIA_BUS_TYPE_CSI1 2
> +#define MEDIA_BUS_TYPE_CCP2 3
> +#define MEDIA_BUS_TYPE_CSI2_DPHY 4
> +#define MEDIA_BUS_TYPE_PARALLEL 5
> +#define MEDIA_BUS_TYPE_BT656 6
> +
> +#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ */
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 1/6] dt-bindings: media: Add macros for video interface bus types
@ 2022-11-17 10:02 ` Paul Elder
0 siblings, 0 replies; 102+ messages in thread
From: Paul Elder @ 2022-11-17 10:02 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, Jacopo Mondi, Maxime Coquelin, Hugues Fruchet,
Alexandre Torgue, dri-devel, Lad Prabhakar, Rob Herring,
Sakari Ailus, Eugen Hristev, Shawn Guo, linux-arm-kernel,
linux-media
On Thu, Jun 16, 2022 at 01:14:05AM +0300, Laurent Pinchart wrote:
> Add a new dt-bindings/media/video-interfaces.h header that defines
> macros corresponding to the bus types from media/video-interfaces.yaml.
> This allows avoiding hardcoded constants in device tree sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
> ---
> Changes since v2:
>
> - Go back to PARALLEL
>
> Changes since v1:
>
> - Dual-license under GPL-2.0-only or MIT
> - Rename PARALLEL TO BT601
> ---
> include/dt-bindings/media/video-interfaces.h | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
> create mode 100644 include/dt-bindings/media/video-interfaces.h
>
> diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h
> new file mode 100644
> index 000000000000..68ac4e05e37f
> --- /dev/null
> +++ b/include/dt-bindings/media/video-interfaces.h
> @@ -0,0 +1,16 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
> +/*
> + * Copyright (C) 2022 Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> + */
> +
> +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__
> +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__
> +
> +#define MEDIA_BUS_TYPE_CSI2_CPHY 1
> +#define MEDIA_BUS_TYPE_CSI1 2
> +#define MEDIA_BUS_TYPE_CCP2 3
> +#define MEDIA_BUS_TYPE_CSI2_DPHY 4
> +#define MEDIA_BUS_TYPE_PARALLEL 5
> +#define MEDIA_BUS_TYPE_BT656 6
> +
> +#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ */
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 1/6] dt-bindings: media: Add macros for video interface bus types
@ 2022-11-17 10:02 ` Paul Elder
0 siblings, 0 replies; 102+ messages in thread
From: Paul Elder @ 2022-11-17 10:02 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo
On Thu, Jun 16, 2022 at 01:14:05AM +0300, Laurent Pinchart wrote:
> Add a new dt-bindings/media/video-interfaces.h header that defines
> macros corresponding to the bus types from media/video-interfaces.yaml.
> This allows avoiding hardcoded constants in device tree sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
> ---
> Changes since v2:
>
> - Go back to PARALLEL
>
> Changes since v1:
>
> - Dual-license under GPL-2.0-only or MIT
> - Rename PARALLEL TO BT601
> ---
> include/dt-bindings/media/video-interfaces.h | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
> create mode 100644 include/dt-bindings/media/video-interfaces.h
>
> diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h
> new file mode 100644
> index 000000000000..68ac4e05e37f
> --- /dev/null
> +++ b/include/dt-bindings/media/video-interfaces.h
> @@ -0,0 +1,16 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
> +/*
> + * Copyright (C) 2022 Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> + */
> +
> +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__
> +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__
> +
> +#define MEDIA_BUS_TYPE_CSI2_CPHY 1
> +#define MEDIA_BUS_TYPE_CSI1 2
> +#define MEDIA_BUS_TYPE_CCP2 3
> +#define MEDIA_BUS_TYPE_CSI2_DPHY 4
> +#define MEDIA_BUS_TYPE_PARALLEL 5
> +#define MEDIA_BUS_TYPE_BT656 6
> +
> +#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ */
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 102+ messages in thread
* [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples
2022-06-15 22:14 ` Laurent Pinchart
(?)
@ 2022-06-15 22:14 ` Laurent Pinchart
-1 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-06-15 22:14 UTC (permalink / raw)
To: devicetree, linux-media, dri-devel
Cc: linux-arm-kernel, Rob Herring, Sakari Ailus, Jacopo Mondi,
Eugen Hristev, Hugues Fruchet, Maxime Coquelin, Alexandre Torgue,
Lad Prabhakar, Fabio Estevam, Shawn Guo
Now that a header exists with macros for the media interface bus-type
values, replace hardcoding numerical constants with the corresponding
macros in the DT binding examples.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
Changes since v2:
- Go back to PARALLEL
Changes since v1:
- Rename PARALLEL to BT601
---
.../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 1 +
Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 3 ++-
Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml | 3 ++-
.../devicetree/bindings/media/marvell,mmp2-ccic.yaml | 3 ++-
Documentation/devicetree/bindings/media/microchip,xisc.yaml | 3 ++-
Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 4 +++-
6 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
index 35a48515836e..b0e5585f93e2 100644
--- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
@@ -118,6 +118,7 @@ additionalProperties: false
examples:
- |
#include <dt-bindings/gpio/gpio.h>
+ #include <dt-bindings/media/video-interfaces.h>
i2c0 {
#address-cells = <1>;
diff --git a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
index 39395ea8c318..edde4201116f 100644
--- a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
@@ -104,6 +104,7 @@ additionalProperties: false
examples:
- |
#include <dt-bindings/gpio/gpio.h>
+ #include <dt-bindings/media/video-interfaces.h>
i2c2 {
#address-cells = <1>;
@@ -124,7 +125,7 @@ examples:
remote-endpoint = <&csi2a_ep>;
link-frequencies = /bits/ 64 <199200000 210000000
499200000>;
- bus-type = <4>;
+ bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
};
};
};
diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
index 44529425ce3a..161e6d598e1c 100644
--- a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
@@ -105,6 +105,7 @@ additionalProperties: false
examples:
- |
#include <dt-bindings/gpio/gpio.h>
+ #include <dt-bindings/media/video-interfaces.h>
i2c0 {
#address-cells = <1>;
@@ -118,7 +119,7 @@ examples:
port {
ov772x_0: endpoint {
- bus-type = <5>;
+ bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
vsync-active = <0>;
hsync-active = <0>;
pclk-sample = <0>;
diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
index b39b84c5f012..0e3478551e13 100644
--- a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
+++ b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
@@ -68,6 +68,7 @@ additionalProperties: false
examples:
- |
#include <dt-bindings/clock/marvell,mmp2.h>
+ #include <dt-bindings/media/video-interfaces.h>
#include <dt-bindings/power/marvell,mmp2.h>
camera@d420a000 {
@@ -83,7 +84,7 @@ examples:
port {
camera0_0: endpoint {
remote-endpoint = <&ov7670_0>;
- bus-type = <5>; /* Parallel */
+ bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
hsync-active = <1>; /* Active high */
vsync-active = <1>; /* Active high */
pclk-sample = <0>; /* Falling */
diff --git a/Documentation/devicetree/bindings/media/microchip,xisc.yaml b/Documentation/devicetree/bindings/media/microchip,xisc.yaml
index 8b37fccab5e2..25f5f79d40ce 100644
--- a/Documentation/devicetree/bindings/media/microchip,xisc.yaml
+++ b/Documentation/devicetree/bindings/media/microchip,xisc.yaml
@@ -106,6 +106,7 @@ examples:
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/clock/at91.h>
#include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/media/video-interfaces.h>
xisc: xisc@e1408000 {
compatible = "microchip,sama7g5-isc";
@@ -118,7 +119,7 @@ examples:
port {
xisc_in: endpoint {
- bus-type = <5>; /* Parallel */
+ bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
remote-endpoint = <&csi2dc_out>;
hsync-active = <1>;
vsync-active = <1>;
diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
index 9c1262a276b5..285c6075950a 100644
--- a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
+++ b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
@@ -90,7 +90,9 @@ examples:
- |
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/clock/stm32mp1-clks.h>
+ #include <dt-bindings/media/video-interfaces.h>
#include <dt-bindings/reset/stm32mp1-resets.h>
+ #
dcmi: dcmi@4c006000 {
compatible = "st,stm32-dcmi";
reg = <0x4c006000 0x400>;
@@ -104,7 +106,7 @@ examples:
port {
dcmi_0: endpoint {
remote-endpoint = <&ov5640_0>;
- bus-type = <5>;
+ bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
bus-width = <8>;
hsync-active = <0>;
vsync-active = <0>;
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 102+ messages in thread* [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples
@ 2022-06-15 22:14 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-06-15 22:14 UTC (permalink / raw)
To: devicetree, linux-media, dri-devel
Cc: linux-arm-kernel, Rob Herring, Sakari Ailus, Jacopo Mondi,
Eugen Hristev, Hugues Fruchet, Maxime Coquelin, Alexandre Torgue,
Lad Prabhakar, Fabio Estevam, Shawn Guo
Now that a header exists with macros for the media interface bus-type
values, replace hardcoding numerical constants with the corresponding
macros in the DT binding examples.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
Changes since v2:
- Go back to PARALLEL
Changes since v1:
- Rename PARALLEL to BT601
---
.../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 1 +
Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 3 ++-
Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml | 3 ++-
.../devicetree/bindings/media/marvell,mmp2-ccic.yaml | 3 ++-
Documentation/devicetree/bindings/media/microchip,xisc.yaml | 3 ++-
Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 4 +++-
6 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
index 35a48515836e..b0e5585f93e2 100644
--- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
@@ -118,6 +118,7 @@ additionalProperties: false
examples:
- |
#include <dt-bindings/gpio/gpio.h>
+ #include <dt-bindings/media/video-interfaces.h>
i2c0 {
#address-cells = <1>;
diff --git a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
index 39395ea8c318..edde4201116f 100644
--- a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
@@ -104,6 +104,7 @@ additionalProperties: false
examples:
- |
#include <dt-bindings/gpio/gpio.h>
+ #include <dt-bindings/media/video-interfaces.h>
i2c2 {
#address-cells = <1>;
@@ -124,7 +125,7 @@ examples:
remote-endpoint = <&csi2a_ep>;
link-frequencies = /bits/ 64 <199200000 210000000
499200000>;
- bus-type = <4>;
+ bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
};
};
};
diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
index 44529425ce3a..161e6d598e1c 100644
--- a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
@@ -105,6 +105,7 @@ additionalProperties: false
examples:
- |
#include <dt-bindings/gpio/gpio.h>
+ #include <dt-bindings/media/video-interfaces.h>
i2c0 {
#address-cells = <1>;
@@ -118,7 +119,7 @@ examples:
port {
ov772x_0: endpoint {
- bus-type = <5>;
+ bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
vsync-active = <0>;
hsync-active = <0>;
pclk-sample = <0>;
diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
index b39b84c5f012..0e3478551e13 100644
--- a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
+++ b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
@@ -68,6 +68,7 @@ additionalProperties: false
examples:
- |
#include <dt-bindings/clock/marvell,mmp2.h>
+ #include <dt-bindings/media/video-interfaces.h>
#include <dt-bindings/power/marvell,mmp2.h>
camera@d420a000 {
@@ -83,7 +84,7 @@ examples:
port {
camera0_0: endpoint {
remote-endpoint = <&ov7670_0>;
- bus-type = <5>; /* Parallel */
+ bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
hsync-active = <1>; /* Active high */
vsync-active = <1>; /* Active high */
pclk-sample = <0>; /* Falling */
diff --git a/Documentation/devicetree/bindings/media/microchip,xisc.yaml b/Documentation/devicetree/bindings/media/microchip,xisc.yaml
index 8b37fccab5e2..25f5f79d40ce 100644
--- a/Documentation/devicetree/bindings/media/microchip,xisc.yaml
+++ b/Documentation/devicetree/bindings/media/microchip,xisc.yaml
@@ -106,6 +106,7 @@ examples:
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/clock/at91.h>
#include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/media/video-interfaces.h>
xisc: xisc@e1408000 {
compatible = "microchip,sama7g5-isc";
@@ -118,7 +119,7 @@ examples:
port {
xisc_in: endpoint {
- bus-type = <5>; /* Parallel */
+ bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
remote-endpoint = <&csi2dc_out>;
hsync-active = <1>;
vsync-active = <1>;
diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
index 9c1262a276b5..285c6075950a 100644
--- a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
+++ b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
@@ -90,7 +90,9 @@ examples:
- |
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/clock/stm32mp1-clks.h>
+ #include <dt-bindings/media/video-interfaces.h>
#include <dt-bindings/reset/stm32mp1-resets.h>
+ #
dcmi: dcmi@4c006000 {
compatible = "st,stm32-dcmi";
reg = <0x4c006000 0x400>;
@@ -104,7 +106,7 @@ examples:
port {
dcmi_0: endpoint {
remote-endpoint = <&ov5640_0>;
- bus-type = <5>;
+ bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
bus-width = <8>;
hsync-active = <0>;
vsync-active = <0>;
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 102+ messages in thread* [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples
@ 2022-06-15 22:14 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-06-15 22:14 UTC (permalink / raw)
To: devicetree, linux-media, dri-devel
Cc: Jacopo Mondi, Maxime Coquelin, Hugues Fruchet, Alexandre Torgue,
Shawn Guo, Lad Prabhakar, Rob Herring, Sakari Ailus,
Eugen Hristev, linux-arm-kernel
Now that a header exists with macros for the media interface bus-type
values, replace hardcoding numerical constants with the corresponding
macros in the DT binding examples.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
Changes since v2:
- Go back to PARALLEL
Changes since v1:
- Rename PARALLEL to BT601
---
.../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 1 +
Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 3 ++-
Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml | 3 ++-
.../devicetree/bindings/media/marvell,mmp2-ccic.yaml | 3 ++-
Documentation/devicetree/bindings/media/microchip,xisc.yaml | 3 ++-
Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 4 +++-
6 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
index 35a48515836e..b0e5585f93e2 100644
--- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
@@ -118,6 +118,7 @@ additionalProperties: false
examples:
- |
#include <dt-bindings/gpio/gpio.h>
+ #include <dt-bindings/media/video-interfaces.h>
i2c0 {
#address-cells = <1>;
diff --git a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
index 39395ea8c318..edde4201116f 100644
--- a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
@@ -104,6 +104,7 @@ additionalProperties: false
examples:
- |
#include <dt-bindings/gpio/gpio.h>
+ #include <dt-bindings/media/video-interfaces.h>
i2c2 {
#address-cells = <1>;
@@ -124,7 +125,7 @@ examples:
remote-endpoint = <&csi2a_ep>;
link-frequencies = /bits/ 64 <199200000 210000000
499200000>;
- bus-type = <4>;
+ bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
};
};
};
diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
index 44529425ce3a..161e6d598e1c 100644
--- a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
@@ -105,6 +105,7 @@ additionalProperties: false
examples:
- |
#include <dt-bindings/gpio/gpio.h>
+ #include <dt-bindings/media/video-interfaces.h>
i2c0 {
#address-cells = <1>;
@@ -118,7 +119,7 @@ examples:
port {
ov772x_0: endpoint {
- bus-type = <5>;
+ bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
vsync-active = <0>;
hsync-active = <0>;
pclk-sample = <0>;
diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
index b39b84c5f012..0e3478551e13 100644
--- a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
+++ b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
@@ -68,6 +68,7 @@ additionalProperties: false
examples:
- |
#include <dt-bindings/clock/marvell,mmp2.h>
+ #include <dt-bindings/media/video-interfaces.h>
#include <dt-bindings/power/marvell,mmp2.h>
camera@d420a000 {
@@ -83,7 +84,7 @@ examples:
port {
camera0_0: endpoint {
remote-endpoint = <&ov7670_0>;
- bus-type = <5>; /* Parallel */
+ bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
hsync-active = <1>; /* Active high */
vsync-active = <1>; /* Active high */
pclk-sample = <0>; /* Falling */
diff --git a/Documentation/devicetree/bindings/media/microchip,xisc.yaml b/Documentation/devicetree/bindings/media/microchip,xisc.yaml
index 8b37fccab5e2..25f5f79d40ce 100644
--- a/Documentation/devicetree/bindings/media/microchip,xisc.yaml
+++ b/Documentation/devicetree/bindings/media/microchip,xisc.yaml
@@ -106,6 +106,7 @@ examples:
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/clock/at91.h>
#include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/media/video-interfaces.h>
xisc: xisc@e1408000 {
compatible = "microchip,sama7g5-isc";
@@ -118,7 +119,7 @@ examples:
port {
xisc_in: endpoint {
- bus-type = <5>; /* Parallel */
+ bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
remote-endpoint = <&csi2dc_out>;
hsync-active = <1>;
vsync-active = <1>;
diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
index 9c1262a276b5..285c6075950a 100644
--- a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
+++ b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
@@ -90,7 +90,9 @@ examples:
- |
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/clock/stm32mp1-clks.h>
+ #include <dt-bindings/media/video-interfaces.h>
#include <dt-bindings/reset/stm32mp1-resets.h>
+ #
dcmi: dcmi@4c006000 {
compatible = "st,stm32-dcmi";
reg = <0x4c006000 0x400>;
@@ -104,7 +106,7 @@ examples:
port {
dcmi_0: endpoint {
remote-endpoint = <&ov5640_0>;
- bus-type = <5>;
+ bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
bus-width = <8>;
hsync-active = <0>;
vsync-active = <0>;
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 102+ messages in thread* Re: [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples
2022-06-15 22:14 ` Laurent Pinchart
(?)
@ 2022-06-27 22:16 ` Rob Herring
-1 siblings, 0 replies; 102+ messages in thread
From: Rob Herring @ 2022-06-27 22:16 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Sakari Ailus, Jacopo Mondi, Eugen Hristev, Hugues Fruchet,
Maxime Coquelin, Alexandre Torgue, Lad Prabhakar, Fabio Estevam,
Shawn Guo
On Thu, Jun 16, 2022 at 01:14:06AM +0300, Laurent Pinchart wrote:
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT binding examples.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes since v2:
>
> - Go back to PARALLEL
>
> Changes since v1:
>
> - Rename PARALLEL to BT601
> ---
> .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 1 +
> Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 3 ++-
> Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml | 3 ++-
> .../devicetree/bindings/media/marvell,mmp2-ccic.yaml | 3 ++-
> Documentation/devicetree/bindings/media/microchip,xisc.yaml | 3 ++-
> Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 4 +++-
> 6 files changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> index 35a48515836e..b0e5585f93e2 100644
> --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> @@ -118,6 +118,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/media/video-interfaces.h>
>
> i2c0 {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
> index 39395ea8c318..edde4201116f 100644
> --- a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
> @@ -104,6 +104,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/media/video-interfaces.h>
>
> i2c2 {
> #address-cells = <1>;
> @@ -124,7 +125,7 @@ examples:
> remote-endpoint = <&csi2a_ep>;
> link-frequencies = /bits/ 64 <199200000 210000000
> 499200000>;
> - bus-type = <4>;
> + bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
> };
> };
> };
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
> index 44529425ce3a..161e6d598e1c 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
> @@ -105,6 +105,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/media/video-interfaces.h>
>
> i2c0 {
> #address-cells = <1>;
> @@ -118,7 +119,7 @@ examples:
>
> port {
> ov772x_0: endpoint {
> - bus-type = <5>;
> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> vsync-active = <0>;
> hsync-active = <0>;
> pclk-sample = <0>;
> diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> index b39b84c5f012..0e3478551e13 100644
> --- a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> +++ b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> @@ -68,6 +68,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/clock/marvell,mmp2.h>
> + #include <dt-bindings/media/video-interfaces.h>
> #include <dt-bindings/power/marvell,mmp2.h>
>
> camera@d420a000 {
> @@ -83,7 +84,7 @@ examples:
> port {
> camera0_0: endpoint {
> remote-endpoint = <&ov7670_0>;
> - bus-type = <5>; /* Parallel */
> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> hsync-active = <1>; /* Active high */
> vsync-active = <1>; /* Active high */
> pclk-sample = <0>; /* Falling */
> diff --git a/Documentation/devicetree/bindings/media/microchip,xisc.yaml b/Documentation/devicetree/bindings/media/microchip,xisc.yaml
> index 8b37fccab5e2..25f5f79d40ce 100644
> --- a/Documentation/devicetree/bindings/media/microchip,xisc.yaml
> +++ b/Documentation/devicetree/bindings/media/microchip,xisc.yaml
> @@ -106,6 +106,7 @@ examples:
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/clock/at91.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/media/video-interfaces.h>
>
> xisc: xisc@e1408000 {
> compatible = "microchip,sama7g5-isc";
> @@ -118,7 +119,7 @@ examples:
>
> port {
> xisc_in: endpoint {
> - bus-type = <5>; /* Parallel */
> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> remote-endpoint = <&csi2dc_out>;
> hsync-active = <1>;
> vsync-active = <1>;
> diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
> index 9c1262a276b5..285c6075950a 100644
> --- a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
> +++ b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
> @@ -90,7 +90,9 @@ examples:
> - |
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/clock/stm32mp1-clks.h>
> + #include <dt-bindings/media/video-interfaces.h>
> #include <dt-bindings/reset/stm32mp1-resets.h>
> + #
?
In any case,
Reviewed-by: Rob Herring <robh@kernel.org>
> dcmi: dcmi@4c006000 {
> compatible = "st,stm32-dcmi";
> reg = <0x4c006000 0x400>;
> @@ -104,7 +106,7 @@ examples:
> port {
> dcmi_0: endpoint {
> remote-endpoint = <&ov5640_0>;
> - bus-type = <5>;
> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> bus-width = <8>;
> hsync-active = <0>;
> vsync-active = <0>;
> --
> Regards,
>
> Laurent Pinchart
>
>
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples
@ 2022-06-27 22:16 ` Rob Herring
0 siblings, 0 replies; 102+ messages in thread
From: Rob Herring @ 2022-06-27 22:16 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Sakari Ailus, Jacopo Mondi, Eugen Hristev, Hugues Fruchet,
Maxime Coquelin, Alexandre Torgue, Lad Prabhakar, Fabio Estevam,
Shawn Guo
On Thu, Jun 16, 2022 at 01:14:06AM +0300, Laurent Pinchart wrote:
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT binding examples.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes since v2:
>
> - Go back to PARALLEL
>
> Changes since v1:
>
> - Rename PARALLEL to BT601
> ---
> .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 1 +
> Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 3 ++-
> Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml | 3 ++-
> .../devicetree/bindings/media/marvell,mmp2-ccic.yaml | 3 ++-
> Documentation/devicetree/bindings/media/microchip,xisc.yaml | 3 ++-
> Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 4 +++-
> 6 files changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> index 35a48515836e..b0e5585f93e2 100644
> --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> @@ -118,6 +118,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/media/video-interfaces.h>
>
> i2c0 {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
> index 39395ea8c318..edde4201116f 100644
> --- a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
> @@ -104,6 +104,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/media/video-interfaces.h>
>
> i2c2 {
> #address-cells = <1>;
> @@ -124,7 +125,7 @@ examples:
> remote-endpoint = <&csi2a_ep>;
> link-frequencies = /bits/ 64 <199200000 210000000
> 499200000>;
> - bus-type = <4>;
> + bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
> };
> };
> };
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
> index 44529425ce3a..161e6d598e1c 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
> @@ -105,6 +105,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/media/video-interfaces.h>
>
> i2c0 {
> #address-cells = <1>;
> @@ -118,7 +119,7 @@ examples:
>
> port {
> ov772x_0: endpoint {
> - bus-type = <5>;
> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> vsync-active = <0>;
> hsync-active = <0>;
> pclk-sample = <0>;
> diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> index b39b84c5f012..0e3478551e13 100644
> --- a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> +++ b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> @@ -68,6 +68,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/clock/marvell,mmp2.h>
> + #include <dt-bindings/media/video-interfaces.h>
> #include <dt-bindings/power/marvell,mmp2.h>
>
> camera@d420a000 {
> @@ -83,7 +84,7 @@ examples:
> port {
> camera0_0: endpoint {
> remote-endpoint = <&ov7670_0>;
> - bus-type = <5>; /* Parallel */
> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> hsync-active = <1>; /* Active high */
> vsync-active = <1>; /* Active high */
> pclk-sample = <0>; /* Falling */
> diff --git a/Documentation/devicetree/bindings/media/microchip,xisc.yaml b/Documentation/devicetree/bindings/media/microchip,xisc.yaml
> index 8b37fccab5e2..25f5f79d40ce 100644
> --- a/Documentation/devicetree/bindings/media/microchip,xisc.yaml
> +++ b/Documentation/devicetree/bindings/media/microchip,xisc.yaml
> @@ -106,6 +106,7 @@ examples:
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/clock/at91.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/media/video-interfaces.h>
>
> xisc: xisc@e1408000 {
> compatible = "microchip,sama7g5-isc";
> @@ -118,7 +119,7 @@ examples:
>
> port {
> xisc_in: endpoint {
> - bus-type = <5>; /* Parallel */
> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> remote-endpoint = <&csi2dc_out>;
> hsync-active = <1>;
> vsync-active = <1>;
> diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
> index 9c1262a276b5..285c6075950a 100644
> --- a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
> +++ b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
> @@ -90,7 +90,9 @@ examples:
> - |
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/clock/stm32mp1-clks.h>
> + #include <dt-bindings/media/video-interfaces.h>
> #include <dt-bindings/reset/stm32mp1-resets.h>
> + #
?
In any case,
Reviewed-by: Rob Herring <robh@kernel.org>
> dcmi: dcmi@4c006000 {
> compatible = "st,stm32-dcmi";
> reg = <0x4c006000 0x400>;
> @@ -104,7 +106,7 @@ examples:
> port {
> dcmi_0: endpoint {
> remote-endpoint = <&ov5640_0>;
> - bus-type = <5>;
> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> bus-width = <8>;
> hsync-active = <0>;
> vsync-active = <0>;
> --
> Regards,
>
> Laurent Pinchart
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples
@ 2022-06-27 22:16 ` Rob Herring
0 siblings, 0 replies; 102+ messages in thread
From: Rob Herring @ 2022-06-27 22:16 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, Jacopo Mondi, Maxime Coquelin, Hugues Fruchet,
Alexandre Torgue, dri-devel, Lad Prabhakar, Sakari Ailus,
Eugen Hristev, Shawn Guo, linux-arm-kernel, linux-media
On Thu, Jun 16, 2022 at 01:14:06AM +0300, Laurent Pinchart wrote:
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT binding examples.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes since v2:
>
> - Go back to PARALLEL
>
> Changes since v1:
>
> - Rename PARALLEL to BT601
> ---
> .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 1 +
> Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 3 ++-
> Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml | 3 ++-
> .../devicetree/bindings/media/marvell,mmp2-ccic.yaml | 3 ++-
> Documentation/devicetree/bindings/media/microchip,xisc.yaml | 3 ++-
> Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 4 +++-
> 6 files changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> index 35a48515836e..b0e5585f93e2 100644
> --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> @@ -118,6 +118,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/media/video-interfaces.h>
>
> i2c0 {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
> index 39395ea8c318..edde4201116f 100644
> --- a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
> @@ -104,6 +104,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/media/video-interfaces.h>
>
> i2c2 {
> #address-cells = <1>;
> @@ -124,7 +125,7 @@ examples:
> remote-endpoint = <&csi2a_ep>;
> link-frequencies = /bits/ 64 <199200000 210000000
> 499200000>;
> - bus-type = <4>;
> + bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
> };
> };
> };
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
> index 44529425ce3a..161e6d598e1c 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
> @@ -105,6 +105,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/media/video-interfaces.h>
>
> i2c0 {
> #address-cells = <1>;
> @@ -118,7 +119,7 @@ examples:
>
> port {
> ov772x_0: endpoint {
> - bus-type = <5>;
> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> vsync-active = <0>;
> hsync-active = <0>;
> pclk-sample = <0>;
> diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> index b39b84c5f012..0e3478551e13 100644
> --- a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> +++ b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> @@ -68,6 +68,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/clock/marvell,mmp2.h>
> + #include <dt-bindings/media/video-interfaces.h>
> #include <dt-bindings/power/marvell,mmp2.h>
>
> camera@d420a000 {
> @@ -83,7 +84,7 @@ examples:
> port {
> camera0_0: endpoint {
> remote-endpoint = <&ov7670_0>;
> - bus-type = <5>; /* Parallel */
> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> hsync-active = <1>; /* Active high */
> vsync-active = <1>; /* Active high */
> pclk-sample = <0>; /* Falling */
> diff --git a/Documentation/devicetree/bindings/media/microchip,xisc.yaml b/Documentation/devicetree/bindings/media/microchip,xisc.yaml
> index 8b37fccab5e2..25f5f79d40ce 100644
> --- a/Documentation/devicetree/bindings/media/microchip,xisc.yaml
> +++ b/Documentation/devicetree/bindings/media/microchip,xisc.yaml
> @@ -106,6 +106,7 @@ examples:
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/clock/at91.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/media/video-interfaces.h>
>
> xisc: xisc@e1408000 {
> compatible = "microchip,sama7g5-isc";
> @@ -118,7 +119,7 @@ examples:
>
> port {
> xisc_in: endpoint {
> - bus-type = <5>; /* Parallel */
> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> remote-endpoint = <&csi2dc_out>;
> hsync-active = <1>;
> vsync-active = <1>;
> diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
> index 9c1262a276b5..285c6075950a 100644
> --- a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
> +++ b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
> @@ -90,7 +90,9 @@ examples:
> - |
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/clock/stm32mp1-clks.h>
> + #include <dt-bindings/media/video-interfaces.h>
> #include <dt-bindings/reset/stm32mp1-resets.h>
> + #
?
In any case,
Reviewed-by: Rob Herring <robh@kernel.org>
> dcmi: dcmi@4c006000 {
> compatible = "st,stm32-dcmi";
> reg = <0x4c006000 0x400>;
> @@ -104,7 +106,7 @@ examples:
> port {
> dcmi_0: endpoint {
> remote-endpoint = <&ov5640_0>;
> - bus-type = <5>;
> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> bus-width = <8>;
> hsync-active = <0>;
> vsync-active = <0>;
> --
> Regards,
>
> Laurent Pinchart
>
>
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples
2022-06-27 22:16 ` Rob Herring
(?)
@ 2022-06-27 23:40 ` Laurent Pinchart
-1 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-06-27 23:40 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Sakari Ailus, Jacopo Mondi, Eugen Hristev, Hugues Fruchet,
Maxime Coquelin, Alexandre Torgue, Lad Prabhakar, Fabio Estevam,
Shawn Guo
Hi Rob,
On Mon, Jun 27, 2022 at 04:16:08PM -0600, Rob Herring wrote:
> On Thu, Jun 16, 2022 at 01:14:06AM +0300, Laurent Pinchart wrote:
> > Now that a header exists with macros for the media interface bus-type
> > values, replace hardcoding numerical constants with the corresponding
> > macros in the DT binding examples.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > Changes since v2:
> >
> > - Go back to PARALLEL
> >
> > Changes since v1:
> >
> > - Rename PARALLEL to BT601
> > ---
> > .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 1 +
> > Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 3 ++-
> > Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml | 3 ++-
> > .../devicetree/bindings/media/marvell,mmp2-ccic.yaml | 3 ++-
> > Documentation/devicetree/bindings/media/microchip,xisc.yaml | 3 ++-
> > Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 4 +++-
> > 6 files changed, 12 insertions(+), 5 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > index 35a48515836e..b0e5585f93e2 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > @@ -118,6 +118,7 @@ additionalProperties: false
> > examples:
> > - |
> > #include <dt-bindings/gpio/gpio.h>
> > + #include <dt-bindings/media/video-interfaces.h>
> >
> > i2c0 {
> > #address-cells = <1>;
> > diff --git a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
> > index 39395ea8c318..edde4201116f 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
> > @@ -104,6 +104,7 @@ additionalProperties: false
> > examples:
> > - |
> > #include <dt-bindings/gpio/gpio.h>
> > + #include <dt-bindings/media/video-interfaces.h>
> >
> > i2c2 {
> > #address-cells = <1>;
> > @@ -124,7 +125,7 @@ examples:
> > remote-endpoint = <&csi2a_ep>;
> > link-frequencies = /bits/ 64 <199200000 210000000
> > 499200000>;
> > - bus-type = <4>;
> > + bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
> > };
> > };
> > };
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
> > index 44529425ce3a..161e6d598e1c 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
> > @@ -105,6 +105,7 @@ additionalProperties: false
> > examples:
> > - |
> > #include <dt-bindings/gpio/gpio.h>
> > + #include <dt-bindings/media/video-interfaces.h>
> >
> > i2c0 {
> > #address-cells = <1>;
> > @@ -118,7 +119,7 @@ examples:
> >
> > port {
> > ov772x_0: endpoint {
> > - bus-type = <5>;
> > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> > vsync-active = <0>;
> > hsync-active = <0>;
> > pclk-sample = <0>;
> > diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> > index b39b84c5f012..0e3478551e13 100644
> > --- a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> > +++ b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> > @@ -68,6 +68,7 @@ additionalProperties: false
> > examples:
> > - |
> > #include <dt-bindings/clock/marvell,mmp2.h>
> > + #include <dt-bindings/media/video-interfaces.h>
> > #include <dt-bindings/power/marvell,mmp2.h>
> >
> > camera@d420a000 {
> > @@ -83,7 +84,7 @@ examples:
> > port {
> > camera0_0: endpoint {
> > remote-endpoint = <&ov7670_0>;
> > - bus-type = <5>; /* Parallel */
> > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> > hsync-active = <1>; /* Active high */
> > vsync-active = <1>; /* Active high */
> > pclk-sample = <0>; /* Falling */
> > diff --git a/Documentation/devicetree/bindings/media/microchip,xisc.yaml b/Documentation/devicetree/bindings/media/microchip,xisc.yaml
> > index 8b37fccab5e2..25f5f79d40ce 100644
> > --- a/Documentation/devicetree/bindings/media/microchip,xisc.yaml
> > +++ b/Documentation/devicetree/bindings/media/microchip,xisc.yaml
> > @@ -106,6 +106,7 @@ examples:
> > #include <dt-bindings/interrupt-controller/arm-gic.h>
> > #include <dt-bindings/clock/at91.h>
> > #include <dt-bindings/interrupt-controller/irq.h>
> > + #include <dt-bindings/media/video-interfaces.h>
> >
> > xisc: xisc@e1408000 {
> > compatible = "microchip,sama7g5-isc";
> > @@ -118,7 +119,7 @@ examples:
> >
> > port {
> > xisc_in: endpoint {
> > - bus-type = <5>; /* Parallel */
> > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> > remote-endpoint = <&csi2dc_out>;
> > hsync-active = <1>;
> > vsync-active = <1>;
> > diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
> > index 9c1262a276b5..285c6075950a 100644
> > --- a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
> > +++ b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
> > @@ -90,7 +90,9 @@ examples:
> > - |
> > #include <dt-bindings/interrupt-controller/arm-gic.h>
> > #include <dt-bindings/clock/stm32mp1-clks.h>
> > + #include <dt-bindings/media/video-interfaces.h>
> > #include <dt-bindings/reset/stm32mp1-resets.h>
> > + #
>
> ?
Oops. I'll blame vim :-) I wonder why I didn't catch that when running
validation. I'll fix it in any case.
> In any case,
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
> > dcmi: dcmi@4c006000 {
> > compatible = "st,stm32-dcmi";
> > reg = <0x4c006000 0x400>;
> > @@ -104,7 +106,7 @@ examples:
> > port {
> > dcmi_0: endpoint {
> > remote-endpoint = <&ov5640_0>;
> > - bus-type = <5>;
> > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> > bus-width = <8>;
> > hsync-active = <0>;
> > vsync-active = <0>;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples
@ 2022-06-27 23:40 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-06-27 23:40 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Sakari Ailus, Jacopo Mondi, Eugen Hristev, Hugues Fruchet,
Maxime Coquelin, Alexandre Torgue, Lad Prabhakar, Fabio Estevam,
Shawn Guo
Hi Rob,
On Mon, Jun 27, 2022 at 04:16:08PM -0600, Rob Herring wrote:
> On Thu, Jun 16, 2022 at 01:14:06AM +0300, Laurent Pinchart wrote:
> > Now that a header exists with macros for the media interface bus-type
> > values, replace hardcoding numerical constants with the corresponding
> > macros in the DT binding examples.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > Changes since v2:
> >
> > - Go back to PARALLEL
> >
> > Changes since v1:
> >
> > - Rename PARALLEL to BT601
> > ---
> > .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 1 +
> > Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 3 ++-
> > Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml | 3 ++-
> > .../devicetree/bindings/media/marvell,mmp2-ccic.yaml | 3 ++-
> > Documentation/devicetree/bindings/media/microchip,xisc.yaml | 3 ++-
> > Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 4 +++-
> > 6 files changed, 12 insertions(+), 5 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > index 35a48515836e..b0e5585f93e2 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > @@ -118,6 +118,7 @@ additionalProperties: false
> > examples:
> > - |
> > #include <dt-bindings/gpio/gpio.h>
> > + #include <dt-bindings/media/video-interfaces.h>
> >
> > i2c0 {
> > #address-cells = <1>;
> > diff --git a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
> > index 39395ea8c318..edde4201116f 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
> > @@ -104,6 +104,7 @@ additionalProperties: false
> > examples:
> > - |
> > #include <dt-bindings/gpio/gpio.h>
> > + #include <dt-bindings/media/video-interfaces.h>
> >
> > i2c2 {
> > #address-cells = <1>;
> > @@ -124,7 +125,7 @@ examples:
> > remote-endpoint = <&csi2a_ep>;
> > link-frequencies = /bits/ 64 <199200000 210000000
> > 499200000>;
> > - bus-type = <4>;
> > + bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
> > };
> > };
> > };
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
> > index 44529425ce3a..161e6d598e1c 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
> > @@ -105,6 +105,7 @@ additionalProperties: false
> > examples:
> > - |
> > #include <dt-bindings/gpio/gpio.h>
> > + #include <dt-bindings/media/video-interfaces.h>
> >
> > i2c0 {
> > #address-cells = <1>;
> > @@ -118,7 +119,7 @@ examples:
> >
> > port {
> > ov772x_0: endpoint {
> > - bus-type = <5>;
> > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> > vsync-active = <0>;
> > hsync-active = <0>;
> > pclk-sample = <0>;
> > diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> > index b39b84c5f012..0e3478551e13 100644
> > --- a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> > +++ b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> > @@ -68,6 +68,7 @@ additionalProperties: false
> > examples:
> > - |
> > #include <dt-bindings/clock/marvell,mmp2.h>
> > + #include <dt-bindings/media/video-interfaces.h>
> > #include <dt-bindings/power/marvell,mmp2.h>
> >
> > camera@d420a000 {
> > @@ -83,7 +84,7 @@ examples:
> > port {
> > camera0_0: endpoint {
> > remote-endpoint = <&ov7670_0>;
> > - bus-type = <5>; /* Parallel */
> > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> > hsync-active = <1>; /* Active high */
> > vsync-active = <1>; /* Active high */
> > pclk-sample = <0>; /* Falling */
> > diff --git a/Documentation/devicetree/bindings/media/microchip,xisc.yaml b/Documentation/devicetree/bindings/media/microchip,xisc.yaml
> > index 8b37fccab5e2..25f5f79d40ce 100644
> > --- a/Documentation/devicetree/bindings/media/microchip,xisc.yaml
> > +++ b/Documentation/devicetree/bindings/media/microchip,xisc.yaml
> > @@ -106,6 +106,7 @@ examples:
> > #include <dt-bindings/interrupt-controller/arm-gic.h>
> > #include <dt-bindings/clock/at91.h>
> > #include <dt-bindings/interrupt-controller/irq.h>
> > + #include <dt-bindings/media/video-interfaces.h>
> >
> > xisc: xisc@e1408000 {
> > compatible = "microchip,sama7g5-isc";
> > @@ -118,7 +119,7 @@ examples:
> >
> > port {
> > xisc_in: endpoint {
> > - bus-type = <5>; /* Parallel */
> > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> > remote-endpoint = <&csi2dc_out>;
> > hsync-active = <1>;
> > vsync-active = <1>;
> > diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
> > index 9c1262a276b5..285c6075950a 100644
> > --- a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
> > +++ b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
> > @@ -90,7 +90,9 @@ examples:
> > - |
> > #include <dt-bindings/interrupt-controller/arm-gic.h>
> > #include <dt-bindings/clock/stm32mp1-clks.h>
> > + #include <dt-bindings/media/video-interfaces.h>
> > #include <dt-bindings/reset/stm32mp1-resets.h>
> > + #
>
> ?
Oops. I'll blame vim :-) I wonder why I didn't catch that when running
validation. I'll fix it in any case.
> In any case,
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
> > dcmi: dcmi@4c006000 {
> > compatible = "st,stm32-dcmi";
> > reg = <0x4c006000 0x400>;
> > @@ -104,7 +106,7 @@ examples:
> > port {
> > dcmi_0: endpoint {
> > remote-endpoint = <&ov5640_0>;
> > - bus-type = <5>;
> > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> > bus-width = <8>;
> > hsync-active = <0>;
> > vsync-active = <0>;
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples
@ 2022-06-27 23:40 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-06-27 23:40 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Jacopo Mondi, Maxime Coquelin, Hugues Fruchet,
Alexandre Torgue, dri-devel, Lad Prabhakar, Sakari Ailus,
Eugen Hristev, Shawn Guo, linux-arm-kernel, linux-media
Hi Rob,
On Mon, Jun 27, 2022 at 04:16:08PM -0600, Rob Herring wrote:
> On Thu, Jun 16, 2022 at 01:14:06AM +0300, Laurent Pinchart wrote:
> > Now that a header exists with macros for the media interface bus-type
> > values, replace hardcoding numerical constants with the corresponding
> > macros in the DT binding examples.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > Changes since v2:
> >
> > - Go back to PARALLEL
> >
> > Changes since v1:
> >
> > - Rename PARALLEL to BT601
> > ---
> > .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 1 +
> > Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 3 ++-
> > Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml | 3 ++-
> > .../devicetree/bindings/media/marvell,mmp2-ccic.yaml | 3 ++-
> > Documentation/devicetree/bindings/media/microchip,xisc.yaml | 3 ++-
> > Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 4 +++-
> > 6 files changed, 12 insertions(+), 5 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > index 35a48515836e..b0e5585f93e2 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > @@ -118,6 +118,7 @@ additionalProperties: false
> > examples:
> > - |
> > #include <dt-bindings/gpio/gpio.h>
> > + #include <dt-bindings/media/video-interfaces.h>
> >
> > i2c0 {
> > #address-cells = <1>;
> > diff --git a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
> > index 39395ea8c318..edde4201116f 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
> > @@ -104,6 +104,7 @@ additionalProperties: false
> > examples:
> > - |
> > #include <dt-bindings/gpio/gpio.h>
> > + #include <dt-bindings/media/video-interfaces.h>
> >
> > i2c2 {
> > #address-cells = <1>;
> > @@ -124,7 +125,7 @@ examples:
> > remote-endpoint = <&csi2a_ep>;
> > link-frequencies = /bits/ 64 <199200000 210000000
> > 499200000>;
> > - bus-type = <4>;
> > + bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
> > };
> > };
> > };
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
> > index 44529425ce3a..161e6d598e1c 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
> > @@ -105,6 +105,7 @@ additionalProperties: false
> > examples:
> > - |
> > #include <dt-bindings/gpio/gpio.h>
> > + #include <dt-bindings/media/video-interfaces.h>
> >
> > i2c0 {
> > #address-cells = <1>;
> > @@ -118,7 +119,7 @@ examples:
> >
> > port {
> > ov772x_0: endpoint {
> > - bus-type = <5>;
> > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> > vsync-active = <0>;
> > hsync-active = <0>;
> > pclk-sample = <0>;
> > diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> > index b39b84c5f012..0e3478551e13 100644
> > --- a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> > +++ b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> > @@ -68,6 +68,7 @@ additionalProperties: false
> > examples:
> > - |
> > #include <dt-bindings/clock/marvell,mmp2.h>
> > + #include <dt-bindings/media/video-interfaces.h>
> > #include <dt-bindings/power/marvell,mmp2.h>
> >
> > camera@d420a000 {
> > @@ -83,7 +84,7 @@ examples:
> > port {
> > camera0_0: endpoint {
> > remote-endpoint = <&ov7670_0>;
> > - bus-type = <5>; /* Parallel */
> > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> > hsync-active = <1>; /* Active high */
> > vsync-active = <1>; /* Active high */
> > pclk-sample = <0>; /* Falling */
> > diff --git a/Documentation/devicetree/bindings/media/microchip,xisc.yaml b/Documentation/devicetree/bindings/media/microchip,xisc.yaml
> > index 8b37fccab5e2..25f5f79d40ce 100644
> > --- a/Documentation/devicetree/bindings/media/microchip,xisc.yaml
> > +++ b/Documentation/devicetree/bindings/media/microchip,xisc.yaml
> > @@ -106,6 +106,7 @@ examples:
> > #include <dt-bindings/interrupt-controller/arm-gic.h>
> > #include <dt-bindings/clock/at91.h>
> > #include <dt-bindings/interrupt-controller/irq.h>
> > + #include <dt-bindings/media/video-interfaces.h>
> >
> > xisc: xisc@e1408000 {
> > compatible = "microchip,sama7g5-isc";
> > @@ -118,7 +119,7 @@ examples:
> >
> > port {
> > xisc_in: endpoint {
> > - bus-type = <5>; /* Parallel */
> > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> > remote-endpoint = <&csi2dc_out>;
> > hsync-active = <1>;
> > vsync-active = <1>;
> > diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
> > index 9c1262a276b5..285c6075950a 100644
> > --- a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
> > +++ b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
> > @@ -90,7 +90,9 @@ examples:
> > - |
> > #include <dt-bindings/interrupt-controller/arm-gic.h>
> > #include <dt-bindings/clock/stm32mp1-clks.h>
> > + #include <dt-bindings/media/video-interfaces.h>
> > #include <dt-bindings/reset/stm32mp1-resets.h>
> > + #
>
> ?
Oops. I'll blame vim :-) I wonder why I didn't catch that when running
validation. I'll fix it in any case.
> In any case,
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
> > dcmi: dcmi@4c006000 {
> > compatible = "st,stm32-dcmi";
> > reg = <0x4c006000 0x400>;
> > @@ -104,7 +106,7 @@ examples:
> > port {
> > dcmi_0: endpoint {
> > remote-endpoint = <&ov5640_0>;
> > - bus-type = <5>;
> > + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> > bus-width = <8>;
> > hsync-active = <0>;
> > vsync-active = <0>;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples
2022-06-15 22:14 ` Laurent Pinchart
(?)
@ 2022-07-16 9:28 ` Sakari Ailus
-1 siblings, 0 replies; 102+ messages in thread
From: Sakari Ailus @ 2022-07-16 9:28 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo
Hi Laurent,
On Thu, Jun 16, 2022 at 01:14:06AM +0300, Laurent Pinchart wrote:
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT binding examples.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes since v2:
>
> - Go back to PARALLEL
>
> Changes since v1:
>
> - Rename PARALLEL to BT601
> ---
> .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 1 +
> Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 3 ++-
> Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml | 3 ++-
> .../devicetree/bindings/media/marvell,mmp2-ccic.yaml | 3 ++-
> Documentation/devicetree/bindings/media/microchip,xisc.yaml | 3 ++-
> Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 4 +++-
> 6 files changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> index 35a48515836e..b0e5585f93e2 100644
> --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> @@ -118,6 +118,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/media/video-interfaces.h>
>
> i2c0 {
> #address-cells = <1>;
The definition doesn't seem to be used here. Is there a need to include
this?
I could drop this chunk while applying. There's just one trivial change
elsewhere in this patch to make.
--
Kind regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples
@ 2022-07-16 9:28 ` Sakari Ailus
0 siblings, 0 replies; 102+ messages in thread
From: Sakari Ailus @ 2022-07-16 9:28 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, Jacopo Mondi, Maxime Coquelin, Hugues Fruchet,
Alexandre Torgue, dri-devel, Lad Prabhakar, Rob Herring,
Sakari Ailus, Eugen Hristev, Shawn Guo, linux-arm-kernel,
linux-media
Hi Laurent,
On Thu, Jun 16, 2022 at 01:14:06AM +0300, Laurent Pinchart wrote:
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT binding examples.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes since v2:
>
> - Go back to PARALLEL
>
> Changes since v1:
>
> - Rename PARALLEL to BT601
> ---
> .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 1 +
> Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 3 ++-
> Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml | 3 ++-
> .../devicetree/bindings/media/marvell,mmp2-ccic.yaml | 3 ++-
> Documentation/devicetree/bindings/media/microchip,xisc.yaml | 3 ++-
> Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 4 +++-
> 6 files changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> index 35a48515836e..b0e5585f93e2 100644
> --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> @@ -118,6 +118,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/media/video-interfaces.h>
>
> i2c0 {
> #address-cells = <1>;
The definition doesn't seem to be used here. Is there a need to include
this?
I could drop this chunk while applying. There's just one trivial change
elsewhere in this patch to make.
--
Kind regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples
@ 2022-07-16 9:28 ` Sakari Ailus
0 siblings, 0 replies; 102+ messages in thread
From: Sakari Ailus @ 2022-07-16 9:28 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo
Hi Laurent,
On Thu, Jun 16, 2022 at 01:14:06AM +0300, Laurent Pinchart wrote:
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT binding examples.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes since v2:
>
> - Go back to PARALLEL
>
> Changes since v1:
>
> - Rename PARALLEL to BT601
> ---
> .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 1 +
> Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 3 ++-
> Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml | 3 ++-
> .../devicetree/bindings/media/marvell,mmp2-ccic.yaml | 3 ++-
> Documentation/devicetree/bindings/media/microchip,xisc.yaml | 3 ++-
> Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 4 +++-
> 6 files changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> index 35a48515836e..b0e5585f93e2 100644
> --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> @@ -118,6 +118,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/media/video-interfaces.h>
>
> i2c0 {
> #address-cells = <1>;
The definition doesn't seem to be used here. Is there a need to include
this?
I could drop this chunk while applying. There's just one trivial change
elsewhere in this patch to make.
--
Kind regards,
Sakari Ailus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples
2022-07-16 9:28 ` Sakari Ailus
(?)
@ 2022-07-16 15:12 ` Laurent Pinchart
-1 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-07-16 15:12 UTC (permalink / raw)
To: Sakari Ailus
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo
Hi Sakari,
On Sat, Jul 16, 2022 at 12:28:45PM +0300, Sakari Ailus wrote:
> On Thu, Jun 16, 2022 at 01:14:06AM +0300, Laurent Pinchart wrote:
> > Now that a header exists with macros for the media interface bus-type
> > values, replace hardcoding numerical constants with the corresponding
> > macros in the DT binding examples.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > Changes since v2:
> >
> > - Go back to PARALLEL
> >
> > Changes since v1:
> >
> > - Rename PARALLEL to BT601
> > ---
> > .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 1 +
> > Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 3 ++-
> > Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml | 3 ++-
> > .../devicetree/bindings/media/marvell,mmp2-ccic.yaml | 3 ++-
> > Documentation/devicetree/bindings/media/microchip,xisc.yaml | 3 ++-
> > Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 4 +++-
> > 6 files changed, 12 insertions(+), 5 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > index 35a48515836e..b0e5585f93e2 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > @@ -118,6 +118,7 @@ additionalProperties: false
> > examples:
> > - |
> > #include <dt-bindings/gpio/gpio.h>
> > + #include <dt-bindings/media/video-interfaces.h>
> >
> > i2c0 {
> > #address-cells = <1>;
>
> The definition doesn't seem to be used here. Is there a need to include
> this?
There was, but the change that added bus-type to this binding got
reverted in commit 979452fbc430 ("dt-bindings: drm/bridge: anx7625:
Revert DPI support") and I forgot to drop the header when rebasing.
> I could drop this chunk while applying. There's just one trivial change
> elsewhere in this patch to make.
Please do :-)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples
@ 2022-07-16 15:12 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-07-16 15:12 UTC (permalink / raw)
To: Sakari Ailus
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo
Hi Sakari,
On Sat, Jul 16, 2022 at 12:28:45PM +0300, Sakari Ailus wrote:
> On Thu, Jun 16, 2022 at 01:14:06AM +0300, Laurent Pinchart wrote:
> > Now that a header exists with macros for the media interface bus-type
> > values, replace hardcoding numerical constants with the corresponding
> > macros in the DT binding examples.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > Changes since v2:
> >
> > - Go back to PARALLEL
> >
> > Changes since v1:
> >
> > - Rename PARALLEL to BT601
> > ---
> > .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 1 +
> > Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 3 ++-
> > Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml | 3 ++-
> > .../devicetree/bindings/media/marvell,mmp2-ccic.yaml | 3 ++-
> > Documentation/devicetree/bindings/media/microchip,xisc.yaml | 3 ++-
> > Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 4 +++-
> > 6 files changed, 12 insertions(+), 5 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > index 35a48515836e..b0e5585f93e2 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > @@ -118,6 +118,7 @@ additionalProperties: false
> > examples:
> > - |
> > #include <dt-bindings/gpio/gpio.h>
> > + #include <dt-bindings/media/video-interfaces.h>
> >
> > i2c0 {
> > #address-cells = <1>;
>
> The definition doesn't seem to be used here. Is there a need to include
> this?
There was, but the change that added bus-type to this binding got
reverted in commit 979452fbc430 ("dt-bindings: drm/bridge: anx7625:
Revert DPI support") and I forgot to drop the header when rebasing.
> I could drop this chunk while applying. There's just one trivial change
> elsewhere in this patch to make.
Please do :-)
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples
@ 2022-07-16 15:12 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-07-16 15:12 UTC (permalink / raw)
To: Sakari Ailus
Cc: devicetree, Jacopo Mondi, Maxime Coquelin, Hugues Fruchet,
Alexandre Torgue, dri-devel, Lad Prabhakar, Rob Herring,
Sakari Ailus, Eugen Hristev, Shawn Guo, linux-arm-kernel,
linux-media
Hi Sakari,
On Sat, Jul 16, 2022 at 12:28:45PM +0300, Sakari Ailus wrote:
> On Thu, Jun 16, 2022 at 01:14:06AM +0300, Laurent Pinchart wrote:
> > Now that a header exists with macros for the media interface bus-type
> > values, replace hardcoding numerical constants with the corresponding
> > macros in the DT binding examples.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > Changes since v2:
> >
> > - Go back to PARALLEL
> >
> > Changes since v1:
> >
> > - Rename PARALLEL to BT601
> > ---
> > .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 1 +
> > Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 3 ++-
> > Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml | 3 ++-
> > .../devicetree/bindings/media/marvell,mmp2-ccic.yaml | 3 ++-
> > Documentation/devicetree/bindings/media/microchip,xisc.yaml | 3 ++-
> > Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 4 +++-
> > 6 files changed, 12 insertions(+), 5 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > index 35a48515836e..b0e5585f93e2 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > @@ -118,6 +118,7 @@ additionalProperties: false
> > examples:
> > - |
> > #include <dt-bindings/gpio/gpio.h>
> > + #include <dt-bindings/media/video-interfaces.h>
> >
> > i2c0 {
> > #address-cells = <1>;
>
> The definition doesn't seem to be used here. Is there a need to include
> this?
There was, but the change that added bus-type to this binding got
reverted in commit 979452fbc430 ("dt-bindings: drm/bridge: anx7625:
Revert DPI support") and I forgot to drop the header when rebasing.
> I could drop this chunk while applying. There's just one trivial change
> elsewhere in this patch to make.
Please do :-)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples
2022-07-16 15:12 ` Laurent Pinchart
(?)
@ 2022-11-21 21:10 ` Sakari Ailus
-1 siblings, 0 replies; 102+ messages in thread
From: Sakari Ailus @ 2022-11-21 21:10 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Sakari Ailus, devicetree, linux-media, dri-devel,
linux-arm-kernel, Rob Herring, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo
Hi Laurent,
On Sat, Jul 16, 2022 at 06:12:05PM +0300, Laurent Pinchart wrote:
> Hi Sakari,
>
> On Sat, Jul 16, 2022 at 12:28:45PM +0300, Sakari Ailus wrote:
> > On Thu, Jun 16, 2022 at 01:14:06AM +0300, Laurent Pinchart wrote:
> > > Now that a header exists with macros for the media interface bus-type
> > > values, replace hardcoding numerical constants with the corresponding
> > > macros in the DT binding examples.
> > >
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > ---
> > > Changes since v2:
> > >
> > > - Go back to PARALLEL
> > >
> > > Changes since v1:
> > >
> > > - Rename PARALLEL to BT601
> > > ---
> > > .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 1 +
> > > Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 3 ++-
> > > Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml | 3 ++-
> > > .../devicetree/bindings/media/marvell,mmp2-ccic.yaml | 3 ++-
> > > Documentation/devicetree/bindings/media/microchip,xisc.yaml | 3 ++-
> > > Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 4 +++-
> > > 6 files changed, 12 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > > index 35a48515836e..b0e5585f93e2 100644
> > > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > > @@ -118,6 +118,7 @@ additionalProperties: false
> > > examples:
> > > - |
> > > #include <dt-bindings/gpio/gpio.h>
> > > + #include <dt-bindings/media/video-interfaces.h>
> > >
> > > i2c0 {
> > > #address-cells = <1>;
> >
> > The definition doesn't seem to be used here. Is there a need to include
> > this?
>
> There was, but the change that added bus-type to this binding got
> reverted in commit 979452fbc430 ("dt-bindings: drm/bridge: anx7625:
> Revert DPI support") and I forgot to drop the header when rebasing.
>
> > I could drop this chunk while applying. There's just one trivial change
> > elsewhere in this patch to make.
>
> Please do :-)
Applied with the following diff:
diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
index 7fa7a667c764a..4590186c4a0b8 100644
--- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
@@ -133,7 +133,6 @@ additionalProperties: false
examples:
- |
#include <dt-bindings/gpio/gpio.h>
- #include <dt-bindings/media/video-interfaces.h>
i2c0 {
#address-cells = <1>;
diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
index 285c6075950ad..e80fcdf280f0b 100644
--- a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
+++ b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
@@ -92,7 +92,7 @@ examples:
#include <dt-bindings/clock/stm32mp1-clks.h>
#include <dt-bindings/media/video-interfaces.h>
#include <dt-bindings/reset/stm32mp1-resets.h>
- #
+
dcmi: dcmi@4c006000 {
compatible = "st,stm32-dcmi";
reg = <0x4c006000 0x400>;
It seems that there's also bus-type 7 that corresponds to MIPI DPI. Could
you add a macro for this one as well? :-) In particular it's used by
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml .
--
Kind regards,
Sakari Ailus
^ permalink raw reply related [flat|nested] 102+ messages in thread* Re: [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples
@ 2022-11-21 21:10 ` Sakari Ailus
0 siblings, 0 replies; 102+ messages in thread
From: Sakari Ailus @ 2022-11-21 21:10 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Sakari Ailus, devicetree, linux-media, dri-devel,
linux-arm-kernel, Rob Herring, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo
Hi Laurent,
On Sat, Jul 16, 2022 at 06:12:05PM +0300, Laurent Pinchart wrote:
> Hi Sakari,
>
> On Sat, Jul 16, 2022 at 12:28:45PM +0300, Sakari Ailus wrote:
> > On Thu, Jun 16, 2022 at 01:14:06AM +0300, Laurent Pinchart wrote:
> > > Now that a header exists with macros for the media interface bus-type
> > > values, replace hardcoding numerical constants with the corresponding
> > > macros in the DT binding examples.
> > >
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > ---
> > > Changes since v2:
> > >
> > > - Go back to PARALLEL
> > >
> > > Changes since v1:
> > >
> > > - Rename PARALLEL to BT601
> > > ---
> > > .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 1 +
> > > Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 3 ++-
> > > Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml | 3 ++-
> > > .../devicetree/bindings/media/marvell,mmp2-ccic.yaml | 3 ++-
> > > Documentation/devicetree/bindings/media/microchip,xisc.yaml | 3 ++-
> > > Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 4 +++-
> > > 6 files changed, 12 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > > index 35a48515836e..b0e5585f93e2 100644
> > > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > > @@ -118,6 +118,7 @@ additionalProperties: false
> > > examples:
> > > - |
> > > #include <dt-bindings/gpio/gpio.h>
> > > + #include <dt-bindings/media/video-interfaces.h>
> > >
> > > i2c0 {
> > > #address-cells = <1>;
> >
> > The definition doesn't seem to be used here. Is there a need to include
> > this?
>
> There was, but the change that added bus-type to this binding got
> reverted in commit 979452fbc430 ("dt-bindings: drm/bridge: anx7625:
> Revert DPI support") and I forgot to drop the header when rebasing.
>
> > I could drop this chunk while applying. There's just one trivial change
> > elsewhere in this patch to make.
>
> Please do :-)
Applied with the following diff:
diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
index 7fa7a667c764a..4590186c4a0b8 100644
--- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
@@ -133,7 +133,6 @@ additionalProperties: false
examples:
- |
#include <dt-bindings/gpio/gpio.h>
- #include <dt-bindings/media/video-interfaces.h>
i2c0 {
#address-cells = <1>;
diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
index 285c6075950ad..e80fcdf280f0b 100644
--- a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
+++ b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
@@ -92,7 +92,7 @@ examples:
#include <dt-bindings/clock/stm32mp1-clks.h>
#include <dt-bindings/media/video-interfaces.h>
#include <dt-bindings/reset/stm32mp1-resets.h>
- #
+
dcmi: dcmi@4c006000 {
compatible = "st,stm32-dcmi";
reg = <0x4c006000 0x400>;
It seems that there's also bus-type 7 that corresponds to MIPI DPI. Could
you add a macro for this one as well? :-) In particular it's used by
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml .
--
Kind regards,
Sakari Ailus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 102+ messages in thread* Re: [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples
@ 2022-11-21 21:10 ` Sakari Ailus
0 siblings, 0 replies; 102+ messages in thread
From: Sakari Ailus @ 2022-11-21 21:10 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, Jacopo Mondi, Hugues Fruchet, Alexandre Torgue,
dri-devel, Lad Prabhakar, Rob Herring, Sakari Ailus,
Maxime Coquelin, Eugen Hristev, Shawn Guo, linux-arm-kernel,
linux-media
Hi Laurent,
On Sat, Jul 16, 2022 at 06:12:05PM +0300, Laurent Pinchart wrote:
> Hi Sakari,
>
> On Sat, Jul 16, 2022 at 12:28:45PM +0300, Sakari Ailus wrote:
> > On Thu, Jun 16, 2022 at 01:14:06AM +0300, Laurent Pinchart wrote:
> > > Now that a header exists with macros for the media interface bus-type
> > > values, replace hardcoding numerical constants with the corresponding
> > > macros in the DT binding examples.
> > >
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > ---
> > > Changes since v2:
> > >
> > > - Go back to PARALLEL
> > >
> > > Changes since v1:
> > >
> > > - Rename PARALLEL to BT601
> > > ---
> > > .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 1 +
> > > Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 3 ++-
> > > Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml | 3 ++-
> > > .../devicetree/bindings/media/marvell,mmp2-ccic.yaml | 3 ++-
> > > Documentation/devicetree/bindings/media/microchip,xisc.yaml | 3 ++-
> > > Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 4 +++-
> > > 6 files changed, 12 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > > index 35a48515836e..b0e5585f93e2 100644
> > > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > > @@ -118,6 +118,7 @@ additionalProperties: false
> > > examples:
> > > - |
> > > #include <dt-bindings/gpio/gpio.h>
> > > + #include <dt-bindings/media/video-interfaces.h>
> > >
> > > i2c0 {
> > > #address-cells = <1>;
> >
> > The definition doesn't seem to be used here. Is there a need to include
> > this?
>
> There was, but the change that added bus-type to this binding got
> reverted in commit 979452fbc430 ("dt-bindings: drm/bridge: anx7625:
> Revert DPI support") and I forgot to drop the header when rebasing.
>
> > I could drop this chunk while applying. There's just one trivial change
> > elsewhere in this patch to make.
>
> Please do :-)
Applied with the following diff:
diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
index 7fa7a667c764a..4590186c4a0b8 100644
--- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
@@ -133,7 +133,6 @@ additionalProperties: false
examples:
- |
#include <dt-bindings/gpio/gpio.h>
- #include <dt-bindings/media/video-interfaces.h>
i2c0 {
#address-cells = <1>;
diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
index 285c6075950ad..e80fcdf280f0b 100644
--- a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
+++ b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
@@ -92,7 +92,7 @@ examples:
#include <dt-bindings/clock/stm32mp1-clks.h>
#include <dt-bindings/media/video-interfaces.h>
#include <dt-bindings/reset/stm32mp1-resets.h>
- #
+
dcmi: dcmi@4c006000 {
compatible = "st,stm32-dcmi";
reg = <0x4c006000 0x400>;
It seems that there's also bus-type 7 that corresponds to MIPI DPI. Could
you add a macro for this one as well? :-) In particular it's used by
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml .
--
Kind regards,
Sakari Ailus
^ permalink raw reply related [flat|nested] 102+ messages in thread
* [PATCH v3 3/6] ARM: dts: freescale: Use new media bus type macros
2022-06-15 22:14 ` Laurent Pinchart
(?)
@ 2022-06-15 22:14 ` Laurent Pinchart
-1 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-06-15 22:14 UTC (permalink / raw)
To: devicetree, linux-media, dri-devel
Cc: linux-arm-kernel, Rob Herring, Sakari Ailus, Jacopo Mondi,
Eugen Hristev, Hugues Fruchet, Maxime Coquelin, Alexandre Torgue,
Lad Prabhakar, Fabio Estevam, Shawn Guo
Now that a header exists with macros for the media interface bus-type
values, replace hardcoding numerical constants with the corresponding
macros in the DT sources.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
index 1a18c41ce385..d98111f2100f 100644
--- a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
+++ b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
@@ -2,6 +2,8 @@
//
// Copyright (C) 2015 Freescale Semiconductor, Inc.
+#include <dt-bindings/media/video-interfaces.h>
+
/ {
chosen {
stdout-path = &uart1;
@@ -170,7 +172,7 @@ &csi {
port {
parallel_from_ov5640: endpoint {
remote-endpoint = <&ov5640_to_parallel>;
- bus-type = <5>; /* Parallel bus */
+ bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
};
};
};
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 102+ messages in thread* [PATCH v3 3/6] ARM: dts: freescale: Use new media bus type macros
@ 2022-06-15 22:14 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-06-15 22:14 UTC (permalink / raw)
To: devicetree, linux-media, dri-devel
Cc: linux-arm-kernel, Rob Herring, Sakari Ailus, Jacopo Mondi,
Eugen Hristev, Hugues Fruchet, Maxime Coquelin, Alexandre Torgue,
Lad Prabhakar, Fabio Estevam, Shawn Guo
Now that a header exists with macros for the media interface bus-type
values, replace hardcoding numerical constants with the corresponding
macros in the DT sources.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
index 1a18c41ce385..d98111f2100f 100644
--- a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
+++ b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
@@ -2,6 +2,8 @@
//
// Copyright (C) 2015 Freescale Semiconductor, Inc.
+#include <dt-bindings/media/video-interfaces.h>
+
/ {
chosen {
stdout-path = &uart1;
@@ -170,7 +172,7 @@ &csi {
port {
parallel_from_ov5640: endpoint {
remote-endpoint = <&ov5640_to_parallel>;
- bus-type = <5>; /* Parallel bus */
+ bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
};
};
};
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 102+ messages in thread* [PATCH v3 3/6] ARM: dts: freescale: Use new media bus type macros
@ 2022-06-15 22:14 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-06-15 22:14 UTC (permalink / raw)
To: devicetree, linux-media, dri-devel
Cc: Jacopo Mondi, Maxime Coquelin, Hugues Fruchet, Alexandre Torgue,
Shawn Guo, Lad Prabhakar, Rob Herring, Sakari Ailus,
Eugen Hristev, linux-arm-kernel
Now that a header exists with macros for the media interface bus-type
values, replace hardcoding numerical constants with the corresponding
macros in the DT sources.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
index 1a18c41ce385..d98111f2100f 100644
--- a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
+++ b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
@@ -2,6 +2,8 @@
//
// Copyright (C) 2015 Freescale Semiconductor, Inc.
+#include <dt-bindings/media/video-interfaces.h>
+
/ {
chosen {
stdout-path = &uart1;
@@ -170,7 +172,7 @@ &csi {
port {
parallel_from_ov5640: endpoint {
remote-endpoint = <&ov5640_to_parallel>;
- bus-type = <5>; /* Parallel bus */
+ bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
};
};
};
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 102+ messages in thread* Re: [PATCH v3 3/6] ARM: dts: freescale: Use new media bus type macros
2022-06-15 22:14 ` Laurent Pinchart
(?)
@ 2023-01-14 15:30 ` Laurent Pinchart
-1 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2023-01-14 15:30 UTC (permalink / raw)
To: Shawn Guo
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam
Shawn, could you please take this in your tree for v6.3 ? The two
patches that the DT changes depend on have been merged in v6.2.
On Thu, Jun 16, 2022 at 01:14:07AM +0300, Laurent Pinchart wrote:
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
> index 1a18c41ce385..d98111f2100f 100644
> --- a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
> +++ b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
> @@ -2,6 +2,8 @@
> //
> // Copyright (C) 2015 Freescale Semiconductor, Inc.
>
> +#include <dt-bindings/media/video-interfaces.h>
> +
> / {
> chosen {
> stdout-path = &uart1;
> @@ -170,7 +172,7 @@ &csi {
> port {
> parallel_from_ov5640: endpoint {
> remote-endpoint = <&ov5640_to_parallel>;
> - bus-type = <5>; /* Parallel bus */
> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> };
> };
> };
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 3/6] ARM: dts: freescale: Use new media bus type macros
@ 2023-01-14 15:30 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2023-01-14 15:30 UTC (permalink / raw)
To: Shawn Guo
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam
Shawn, could you please take this in your tree for v6.3 ? The two
patches that the DT changes depend on have been merged in v6.2.
On Thu, Jun 16, 2022 at 01:14:07AM +0300, Laurent Pinchart wrote:
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
> index 1a18c41ce385..d98111f2100f 100644
> --- a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
> +++ b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
> @@ -2,6 +2,8 @@
> //
> // Copyright (C) 2015 Freescale Semiconductor, Inc.
>
> +#include <dt-bindings/media/video-interfaces.h>
> +
> / {
> chosen {
> stdout-path = &uart1;
> @@ -170,7 +172,7 @@ &csi {
> port {
> parallel_from_ov5640: endpoint {
> remote-endpoint = <&ov5640_to_parallel>;
> - bus-type = <5>; /* Parallel bus */
> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> };
> };
> };
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 3/6] ARM: dts: freescale: Use new media bus type macros
@ 2023-01-14 15:30 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2023-01-14 15:30 UTC (permalink / raw)
To: Shawn Guo
Cc: devicetree, Jacopo Mondi, Maxime Coquelin, Hugues Fruchet,
Alexandre Torgue, dri-devel, Lad Prabhakar, Rob Herring,
Sakari Ailus, Eugen Hristev, linux-arm-kernel, linux-media
Shawn, could you please take this in your tree for v6.3 ? The two
patches that the DT changes depend on have been merged in v6.2.
On Thu, Jun 16, 2022 at 01:14:07AM +0300, Laurent Pinchart wrote:
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
> index 1a18c41ce385..d98111f2100f 100644
> --- a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
> +++ b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
> @@ -2,6 +2,8 @@
> //
> // Copyright (C) 2015 Freescale Semiconductor, Inc.
>
> +#include <dt-bindings/media/video-interfaces.h>
> +
> / {
> chosen {
> stdout-path = &uart1;
> @@ -170,7 +172,7 @@ &csi {
> port {
> parallel_from_ov5640: endpoint {
> remote-endpoint = <&ov5640_to_parallel>;
> - bus-type = <5>; /* Parallel bus */
> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> };
> };
> };
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 3/6] ARM: dts: freescale: Use new media bus type macros
2022-06-15 22:14 ` Laurent Pinchart
(?)
@ 2023-01-25 2:16 ` Shawn Guo
-1 siblings, 0 replies; 102+ messages in thread
From: Shawn Guo @ 2023-01-25 2:16 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam
On Thu, Jun 16, 2022 at 01:14:07AM +0300, Laurent Pinchart wrote:
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 3/6] ARM: dts: freescale: Use new media bus type macros
@ 2023-01-25 2:16 ` Shawn Guo
0 siblings, 0 replies; 102+ messages in thread
From: Shawn Guo @ 2023-01-25 2:16 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam
On Thu, Jun 16, 2022 at 01:14:07AM +0300, Laurent Pinchart wrote:
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 3/6] ARM: dts: freescale: Use new media bus type macros
@ 2023-01-25 2:16 ` Shawn Guo
0 siblings, 0 replies; 102+ messages in thread
From: Shawn Guo @ 2023-01-25 2:16 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, Jacopo Mondi, Maxime Coquelin, Hugues Fruchet,
Alexandre Torgue, dri-devel, Lad Prabhakar, Rob Herring,
Sakari Ailus, Eugen Hristev, linux-arm-kernel, linux-media
On Thu, Jun 16, 2022 at 01:14:07AM +0300, Laurent Pinchart wrote:
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 102+ messages in thread
* [PATCH v3 4/6] ARM: dts: omap: Use new media bus type macros
2022-06-15 22:14 ` Laurent Pinchart
(?)
@ 2022-06-15 22:14 ` Laurent Pinchart
-1 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-06-15 22:14 UTC (permalink / raw)
To: devicetree, linux-media, dri-devel
Cc: linux-arm-kernel, Rob Herring, Sakari Ailus, Jacopo Mondi,
Eugen Hristev, Hugues Fruchet, Maxime Coquelin, Alexandre Torgue,
Lad Prabhakar, Fabio Estevam, Shawn Guo
Now that a header exists with macros for the media interface bus-type
values, replace hardcoding numerical constants with the corresponding
macros in the DT sources.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/omap3-n900.dts | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
index d40c3d2c4914..9cad9d6a83e2 100644
--- a/arch/arm/boot/dts/omap3-n900.dts
+++ b/arch/arm/boot/dts/omap3-n900.dts
@@ -9,6 +9,7 @@
#include "omap34xx.dtsi"
#include <dt-bindings/input/input.h>
#include <dt-bindings/leds/common.h>
+#include <dt-bindings/media/video-interfaces.h>
/*
* Default secure signed bootloader (Nokia X-Loader) does not enable L3 firewall
@@ -194,7 +195,7 @@ port@1 {
csi_isp: endpoint {
remote-endpoint = <&csi_cam1>;
- bus-type = <3>; /* CCP2 */
+ bus-type = <MEDIA_BUS_TYPE_CCP2>;
clock-lanes = <1>;
data-lanes = <0>;
lane-polarity = <0 0>;
@@ -835,7 +836,7 @@ cam1: camera@3e {
port {
csi_cam1: endpoint {
- bus-type = <3>; /* CCP2 */
+ bus-type = <MEDIA_BUS_TYPE_CCP2>;
strobe = <1>;
clock-inv = <0>;
crc = <1>;
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 102+ messages in thread* [PATCH v3 4/6] ARM: dts: omap: Use new media bus type macros
@ 2022-06-15 22:14 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-06-15 22:14 UTC (permalink / raw)
To: devicetree, linux-media, dri-devel
Cc: linux-arm-kernel, Rob Herring, Sakari Ailus, Jacopo Mondi,
Eugen Hristev, Hugues Fruchet, Maxime Coquelin, Alexandre Torgue,
Lad Prabhakar, Fabio Estevam, Shawn Guo
Now that a header exists with macros for the media interface bus-type
values, replace hardcoding numerical constants with the corresponding
macros in the DT sources.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/omap3-n900.dts | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
index d40c3d2c4914..9cad9d6a83e2 100644
--- a/arch/arm/boot/dts/omap3-n900.dts
+++ b/arch/arm/boot/dts/omap3-n900.dts
@@ -9,6 +9,7 @@
#include "omap34xx.dtsi"
#include <dt-bindings/input/input.h>
#include <dt-bindings/leds/common.h>
+#include <dt-bindings/media/video-interfaces.h>
/*
* Default secure signed bootloader (Nokia X-Loader) does not enable L3 firewall
@@ -194,7 +195,7 @@ port@1 {
csi_isp: endpoint {
remote-endpoint = <&csi_cam1>;
- bus-type = <3>; /* CCP2 */
+ bus-type = <MEDIA_BUS_TYPE_CCP2>;
clock-lanes = <1>;
data-lanes = <0>;
lane-polarity = <0 0>;
@@ -835,7 +836,7 @@ cam1: camera@3e {
port {
csi_cam1: endpoint {
- bus-type = <3>; /* CCP2 */
+ bus-type = <MEDIA_BUS_TYPE_CCP2>;
strobe = <1>;
clock-inv = <0>;
crc = <1>;
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 102+ messages in thread* [PATCH v3 4/6] ARM: dts: omap: Use new media bus type macros
@ 2022-06-15 22:14 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-06-15 22:14 UTC (permalink / raw)
To: devicetree, linux-media, dri-devel
Cc: Jacopo Mondi, Maxime Coquelin, Hugues Fruchet, Alexandre Torgue,
Shawn Guo, Lad Prabhakar, Rob Herring, Sakari Ailus,
Eugen Hristev, linux-arm-kernel
Now that a header exists with macros for the media interface bus-type
values, replace hardcoding numerical constants with the corresponding
macros in the DT sources.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/omap3-n900.dts | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
index d40c3d2c4914..9cad9d6a83e2 100644
--- a/arch/arm/boot/dts/omap3-n900.dts
+++ b/arch/arm/boot/dts/omap3-n900.dts
@@ -9,6 +9,7 @@
#include "omap34xx.dtsi"
#include <dt-bindings/input/input.h>
#include <dt-bindings/leds/common.h>
+#include <dt-bindings/media/video-interfaces.h>
/*
* Default secure signed bootloader (Nokia X-Loader) does not enable L3 firewall
@@ -194,7 +195,7 @@ port@1 {
csi_isp: endpoint {
remote-endpoint = <&csi_cam1>;
- bus-type = <3>; /* CCP2 */
+ bus-type = <MEDIA_BUS_TYPE_CCP2>;
clock-lanes = <1>;
data-lanes = <0>;
lane-polarity = <0 0>;
@@ -835,7 +836,7 @@ cam1: camera@3e {
port {
csi_cam1: endpoint {
- bus-type = <3>; /* CCP2 */
+ bus-type = <MEDIA_BUS_TYPE_CCP2>;
strobe = <1>;
clock-inv = <0>;
crc = <1>;
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 102+ messages in thread* Re: [PATCH v3 4/6] ARM: dts: omap: Use new media bus type macros
2022-06-15 22:14 ` Laurent Pinchart
(?)
@ 2023-01-14 15:37 ` Laurent Pinchart
-1 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2023-01-14 15:37 UTC (permalink / raw)
To: Tony Lindgren
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo
Tony, could you take this patch in your tree for v6.3 ? The two patches
that it depends on have both been merged in v6.2.
On Thu, Jun 16, 2022 at 01:14:08AM +0300, Laurent Pinchart wrote:
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/boot/dts/omap3-n900.dts | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
> index d40c3d2c4914..9cad9d6a83e2 100644
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -9,6 +9,7 @@
> #include "omap34xx.dtsi"
> #include <dt-bindings/input/input.h>
> #include <dt-bindings/leds/common.h>
> +#include <dt-bindings/media/video-interfaces.h>
>
> /*
> * Default secure signed bootloader (Nokia X-Loader) does not enable L3 firewall
> @@ -194,7 +195,7 @@ port@1 {
>
> csi_isp: endpoint {
> remote-endpoint = <&csi_cam1>;
> - bus-type = <3>; /* CCP2 */
> + bus-type = <MEDIA_BUS_TYPE_CCP2>;
> clock-lanes = <1>;
> data-lanes = <0>;
> lane-polarity = <0 0>;
> @@ -835,7 +836,7 @@ cam1: camera@3e {
>
> port {
> csi_cam1: endpoint {
> - bus-type = <3>; /* CCP2 */
> + bus-type = <MEDIA_BUS_TYPE_CCP2>;
> strobe = <1>;
> clock-inv = <0>;
> crc = <1>;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 4/6] ARM: dts: omap: Use new media bus type macros
@ 2023-01-14 15:37 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2023-01-14 15:37 UTC (permalink / raw)
To: Tony Lindgren
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo
Tony, could you take this patch in your tree for v6.3 ? The two patches
that it depends on have both been merged in v6.2.
On Thu, Jun 16, 2022 at 01:14:08AM +0300, Laurent Pinchart wrote:
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/boot/dts/omap3-n900.dts | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
> index d40c3d2c4914..9cad9d6a83e2 100644
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -9,6 +9,7 @@
> #include "omap34xx.dtsi"
> #include <dt-bindings/input/input.h>
> #include <dt-bindings/leds/common.h>
> +#include <dt-bindings/media/video-interfaces.h>
>
> /*
> * Default secure signed bootloader (Nokia X-Loader) does not enable L3 firewall
> @@ -194,7 +195,7 @@ port@1 {
>
> csi_isp: endpoint {
> remote-endpoint = <&csi_cam1>;
> - bus-type = <3>; /* CCP2 */
> + bus-type = <MEDIA_BUS_TYPE_CCP2>;
> clock-lanes = <1>;
> data-lanes = <0>;
> lane-polarity = <0 0>;
> @@ -835,7 +836,7 @@ cam1: camera@3e {
>
> port {
> csi_cam1: endpoint {
> - bus-type = <3>; /* CCP2 */
> + bus-type = <MEDIA_BUS_TYPE_CCP2>;
> strobe = <1>;
> clock-inv = <0>;
> crc = <1>;
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 4/6] ARM: dts: omap: Use new media bus type macros
@ 2023-01-14 15:37 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2023-01-14 15:37 UTC (permalink / raw)
To: Tony Lindgren
Cc: devicetree, Jacopo Mondi, Maxime Coquelin, Hugues Fruchet,
Alexandre Torgue, dri-devel, Lad Prabhakar, Rob Herring,
Sakari Ailus, Eugen Hristev, Shawn Guo, linux-arm-kernel,
linux-media
Tony, could you take this patch in your tree for v6.3 ? The two patches
that it depends on have both been merged in v6.2.
On Thu, Jun 16, 2022 at 01:14:08AM +0300, Laurent Pinchart wrote:
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/boot/dts/omap3-n900.dts | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
> index d40c3d2c4914..9cad9d6a83e2 100644
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -9,6 +9,7 @@
> #include "omap34xx.dtsi"
> #include <dt-bindings/input/input.h>
> #include <dt-bindings/leds/common.h>
> +#include <dt-bindings/media/video-interfaces.h>
>
> /*
> * Default secure signed bootloader (Nokia X-Loader) does not enable L3 firewall
> @@ -194,7 +195,7 @@ port@1 {
>
> csi_isp: endpoint {
> remote-endpoint = <&csi_cam1>;
> - bus-type = <3>; /* CCP2 */
> + bus-type = <MEDIA_BUS_TYPE_CCP2>;
> clock-lanes = <1>;
> data-lanes = <0>;
> lane-polarity = <0 0>;
> @@ -835,7 +836,7 @@ cam1: camera@3e {
>
> port {
> csi_cam1: endpoint {
> - bus-type = <3>; /* CCP2 */
> + bus-type = <MEDIA_BUS_TYPE_CCP2>;
> strobe = <1>;
> clock-inv = <0>;
> crc = <1>;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 4/6] ARM: dts: omap: Use new media bus type macros
2023-01-14 15:37 ` Laurent Pinchart
(?)
@ 2023-01-19 7:59 ` Tony Lindgren
-1 siblings, 0 replies; 102+ messages in thread
From: Tony Lindgren @ 2023-01-19 7:59 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo
* Laurent Pinchart <laurent.pinchart@ideasonboard.com> [230114 15:37]:
> Tony, could you take this patch in your tree for v6.3 ? The two patches
> that it depends on have both been merged in v6.2.
OK applying into omap-for-v6.3/dt.
Thanks,
Tony
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 4/6] ARM: dts: omap: Use new media bus type macros
@ 2023-01-19 7:59 ` Tony Lindgren
0 siblings, 0 replies; 102+ messages in thread
From: Tony Lindgren @ 2023-01-19 7:59 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, Jacopo Mondi, Maxime Coquelin, Hugues Fruchet,
Alexandre Torgue, dri-devel, Lad Prabhakar, Rob Herring,
Sakari Ailus, Eugen Hristev, Shawn Guo, linux-arm-kernel,
linux-media
* Laurent Pinchart <laurent.pinchart@ideasonboard.com> [230114 15:37]:
> Tony, could you take this patch in your tree for v6.3 ? The two patches
> that it depends on have both been merged in v6.2.
OK applying into omap-for-v6.3/dt.
Thanks,
Tony
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 4/6] ARM: dts: omap: Use new media bus type macros
@ 2023-01-19 7:59 ` Tony Lindgren
0 siblings, 0 replies; 102+ messages in thread
From: Tony Lindgren @ 2023-01-19 7:59 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo
* Laurent Pinchart <laurent.pinchart@ideasonboard.com> [230114 15:37]:
> Tony, could you take this patch in your tree for v6.3 ? The two patches
> that it depends on have both been merged in v6.2.
OK applying into omap-for-v6.3/dt.
Thanks,
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 102+ messages in thread
* [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros
2022-06-15 22:14 ` Laurent Pinchart
(?)
@ 2022-06-15 22:14 ` Laurent Pinchart
-1 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-06-15 22:14 UTC (permalink / raw)
To: devicetree, linux-media, dri-devel
Cc: linux-arm-kernel, Rob Herring, Sakari Ailus, Jacopo Mondi,
Eugen Hristev, Hugues Fruchet, Maxime Coquelin, Alexandre Torgue,
Lad Prabhakar, Fabio Estevam, Shawn Guo
Now that a header exists with macros for the media interface bus-type
values, replace hardcoding numerical constants with the corresponding
macros in the DT sources.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++----
.../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++-
.../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++-
3 files changed, 13 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
index 4e58c54cde17..33ac4bd1e63b 100644
--- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
+++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
@@ -7,6 +7,9 @@
*/
/dts-v1/;
+
+#include <dt-bindings/media/video-interfaces.h>
+
#include "r8a7742-iwg21d-q7.dts"
/ {
@@ -242,7 +245,7 @@ port {
vin0ep: endpoint {
remote-endpoint = <&cam0ep>;
bus-width = <8>;
- bus-type = <6>;
+ bus-type = <MEDIA_BUS_TYPE_BT656>;
};
};
};
@@ -273,7 +276,7 @@ port {
vin1ep: endpoint {
remote-endpoint = <&cam1ep>;
bus-width = <8>;
- bus-type = <6>;
+ bus-type = <MEDIA_BUS_TYPE_BT656>;
};
};
};
@@ -305,7 +308,7 @@ vin2ep: endpoint {
remote-endpoint = <&cam2ep>;
bus-width = <8>;
data-shift = <8>;
- bus-type = <6>;
+ bus-type = <MEDIA_BUS_TYPE_BT656>;
};
};
};
@@ -335,7 +338,7 @@ port {
vin3ep: endpoint {
remote-endpoint = <&cam3ep>;
bus-width = <8>;
- bus-type = <6>;
+ bus-type = <MEDIA_BUS_TYPE_BT656>;
};
};
};
diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
index 40cef0b1d1e6..c73160df619d 100644
--- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
+++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
@@ -7,6 +7,8 @@
* Copyright (C) 2020 Renesas Electronics Corp.
*/
+#include <dt-bindings/media/video-interfaces.h>
+
#define CAM_ENABLED 1
&CAM_PARENT_I2C {
@@ -26,7 +28,7 @@ port {
CAM_EP: endpoint {
bus-width = <8>;
data-shift = <2>;
- bus-type = <6>;
+ bus-type = <MEDIA_BUS_TYPE_BT656>;
pclk-sample = <1>;
remote-endpoint = <&VIN_EP>;
};
diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
index f5e77f024251..a7f5cfec64b8 100644
--- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
+++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
@@ -7,6 +7,8 @@
* Copyright (C) 2020 Renesas Electronics Corp.
*/
+#include <dt-bindings/media/video-interfaces.h>
+
#define CAM_ENABLED 1
&CAM_PARENT_I2C {
@@ -21,7 +23,7 @@ ov7725@21 {
port {
CAM_EP: endpoint {
bus-width = <8>;
- bus-type = <6>;
+ bus-type = <MEDIA_BUS_TYPE_BT656>;
remote-endpoint = <&VIN_EP>;
};
};
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 102+ messages in thread* [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros
@ 2022-06-15 22:14 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-06-15 22:14 UTC (permalink / raw)
To: devicetree, linux-media, dri-devel
Cc: linux-arm-kernel, Rob Herring, Sakari Ailus, Jacopo Mondi,
Eugen Hristev, Hugues Fruchet, Maxime Coquelin, Alexandre Torgue,
Lad Prabhakar, Fabio Estevam, Shawn Guo
Now that a header exists with macros for the media interface bus-type
values, replace hardcoding numerical constants with the corresponding
macros in the DT sources.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++----
.../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++-
.../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++-
3 files changed, 13 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
index 4e58c54cde17..33ac4bd1e63b 100644
--- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
+++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
@@ -7,6 +7,9 @@
*/
/dts-v1/;
+
+#include <dt-bindings/media/video-interfaces.h>
+
#include "r8a7742-iwg21d-q7.dts"
/ {
@@ -242,7 +245,7 @@ port {
vin0ep: endpoint {
remote-endpoint = <&cam0ep>;
bus-width = <8>;
- bus-type = <6>;
+ bus-type = <MEDIA_BUS_TYPE_BT656>;
};
};
};
@@ -273,7 +276,7 @@ port {
vin1ep: endpoint {
remote-endpoint = <&cam1ep>;
bus-width = <8>;
- bus-type = <6>;
+ bus-type = <MEDIA_BUS_TYPE_BT656>;
};
};
};
@@ -305,7 +308,7 @@ vin2ep: endpoint {
remote-endpoint = <&cam2ep>;
bus-width = <8>;
data-shift = <8>;
- bus-type = <6>;
+ bus-type = <MEDIA_BUS_TYPE_BT656>;
};
};
};
@@ -335,7 +338,7 @@ port {
vin3ep: endpoint {
remote-endpoint = <&cam3ep>;
bus-width = <8>;
- bus-type = <6>;
+ bus-type = <MEDIA_BUS_TYPE_BT656>;
};
};
};
diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
index 40cef0b1d1e6..c73160df619d 100644
--- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
+++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
@@ -7,6 +7,8 @@
* Copyright (C) 2020 Renesas Electronics Corp.
*/
+#include <dt-bindings/media/video-interfaces.h>
+
#define CAM_ENABLED 1
&CAM_PARENT_I2C {
@@ -26,7 +28,7 @@ port {
CAM_EP: endpoint {
bus-width = <8>;
data-shift = <2>;
- bus-type = <6>;
+ bus-type = <MEDIA_BUS_TYPE_BT656>;
pclk-sample = <1>;
remote-endpoint = <&VIN_EP>;
};
diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
index f5e77f024251..a7f5cfec64b8 100644
--- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
+++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
@@ -7,6 +7,8 @@
* Copyright (C) 2020 Renesas Electronics Corp.
*/
+#include <dt-bindings/media/video-interfaces.h>
+
#define CAM_ENABLED 1
&CAM_PARENT_I2C {
@@ -21,7 +23,7 @@ ov7725@21 {
port {
CAM_EP: endpoint {
bus-width = <8>;
- bus-type = <6>;
+ bus-type = <MEDIA_BUS_TYPE_BT656>;
remote-endpoint = <&VIN_EP>;
};
};
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 102+ messages in thread* [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros
@ 2022-06-15 22:14 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-06-15 22:14 UTC (permalink / raw)
To: devicetree, linux-media, dri-devel
Cc: Jacopo Mondi, Maxime Coquelin, Hugues Fruchet, Alexandre Torgue,
Shawn Guo, Lad Prabhakar, Rob Herring, Sakari Ailus,
Eugen Hristev, linux-arm-kernel
Now that a header exists with macros for the media interface bus-type
values, replace hardcoding numerical constants with the corresponding
macros in the DT sources.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++----
.../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++-
.../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++-
3 files changed, 13 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
index 4e58c54cde17..33ac4bd1e63b 100644
--- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
+++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
@@ -7,6 +7,9 @@
*/
/dts-v1/;
+
+#include <dt-bindings/media/video-interfaces.h>
+
#include "r8a7742-iwg21d-q7.dts"
/ {
@@ -242,7 +245,7 @@ port {
vin0ep: endpoint {
remote-endpoint = <&cam0ep>;
bus-width = <8>;
- bus-type = <6>;
+ bus-type = <MEDIA_BUS_TYPE_BT656>;
};
};
};
@@ -273,7 +276,7 @@ port {
vin1ep: endpoint {
remote-endpoint = <&cam1ep>;
bus-width = <8>;
- bus-type = <6>;
+ bus-type = <MEDIA_BUS_TYPE_BT656>;
};
};
};
@@ -305,7 +308,7 @@ vin2ep: endpoint {
remote-endpoint = <&cam2ep>;
bus-width = <8>;
data-shift = <8>;
- bus-type = <6>;
+ bus-type = <MEDIA_BUS_TYPE_BT656>;
};
};
};
@@ -335,7 +338,7 @@ port {
vin3ep: endpoint {
remote-endpoint = <&cam3ep>;
bus-width = <8>;
- bus-type = <6>;
+ bus-type = <MEDIA_BUS_TYPE_BT656>;
};
};
};
diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
index 40cef0b1d1e6..c73160df619d 100644
--- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
+++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
@@ -7,6 +7,8 @@
* Copyright (C) 2020 Renesas Electronics Corp.
*/
+#include <dt-bindings/media/video-interfaces.h>
+
#define CAM_ENABLED 1
&CAM_PARENT_I2C {
@@ -26,7 +28,7 @@ port {
CAM_EP: endpoint {
bus-width = <8>;
data-shift = <2>;
- bus-type = <6>;
+ bus-type = <MEDIA_BUS_TYPE_BT656>;
pclk-sample = <1>;
remote-endpoint = <&VIN_EP>;
};
diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
index f5e77f024251..a7f5cfec64b8 100644
--- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
+++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
@@ -7,6 +7,8 @@
* Copyright (C) 2020 Renesas Electronics Corp.
*/
+#include <dt-bindings/media/video-interfaces.h>
+
#define CAM_ENABLED 1
&CAM_PARENT_I2C {
@@ -21,7 +23,7 @@ ov7725@21 {
port {
CAM_EP: endpoint {
bus-width = <8>;
- bus-type = <6>;
+ bus-type = <MEDIA_BUS_TYPE_BT656>;
remote-endpoint = <&VIN_EP>;
};
};
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 102+ messages in thread* Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros
2022-06-15 22:14 ` Laurent Pinchart
(?)
@ 2022-11-18 9:27 ` Lad, Prabhakar
-1 siblings, 0 replies; 102+ messages in thread
From: Lad, Prabhakar @ 2022-11-18 9:27 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo
Hi Laurent,
Thank you for the patch.
On Wed, Jun 15, 2022 at 11:21 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++----
> .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++-
> .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++-
> 3 files changed, 13 insertions(+), 6 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cheers,
Prabhakar
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros
@ 2022-11-18 9:27 ` Lad, Prabhakar
0 siblings, 0 replies; 102+ messages in thread
From: Lad, Prabhakar @ 2022-11-18 9:27 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo
Hi Laurent,
Thank you for the patch.
On Wed, Jun 15, 2022 at 11:21 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++----
> .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++-
> .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++-
> 3 files changed, 13 insertions(+), 6 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cheers,
Prabhakar
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros
@ 2022-11-18 9:27 ` Lad, Prabhakar
0 siblings, 0 replies; 102+ messages in thread
From: Lad, Prabhakar @ 2022-11-18 9:27 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, Jacopo Mondi, Maxime Coquelin, Hugues Fruchet,
Alexandre Torgue, dri-devel, Lad Prabhakar, Rob Herring,
Sakari Ailus, Eugen Hristev, Shawn Guo, linux-arm-kernel,
linux-media
Hi Laurent,
Thank you for the patch.
On Wed, Jun 15, 2022 at 11:21 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++----
> .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++-
> .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++-
> 3 files changed, 13 insertions(+), 6 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cheers,
Prabhakar
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros
2022-06-15 22:14 ` Laurent Pinchart
(?)
@ 2023-01-14 15:26 ` Laurent Pinchart
-1 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2023-01-14 15:26 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo
Geert, could you please take this in your tree for v6.3 ? The two
patches that the DT changes depend on have been merged in v6.2.
On Thu, Jun 16, 2022 at 01:14:09AM +0300, Laurent Pinchart wrote:
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++----
> .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++-
> .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++-
> 3 files changed, 13 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> index 4e58c54cde17..33ac4bd1e63b 100644
> --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> @@ -7,6 +7,9 @@
> */
>
> /dts-v1/;
> +
> +#include <dt-bindings/media/video-interfaces.h>
> +
> #include "r8a7742-iwg21d-q7.dts"
>
> / {
> @@ -242,7 +245,7 @@ port {
> vin0ep: endpoint {
> remote-endpoint = <&cam0ep>;
> bus-width = <8>;
> - bus-type = <6>;
> + bus-type = <MEDIA_BUS_TYPE_BT656>;
> };
> };
> };
> @@ -273,7 +276,7 @@ port {
> vin1ep: endpoint {
> remote-endpoint = <&cam1ep>;
> bus-width = <8>;
> - bus-type = <6>;
> + bus-type = <MEDIA_BUS_TYPE_BT656>;
> };
> };
> };
> @@ -305,7 +308,7 @@ vin2ep: endpoint {
> remote-endpoint = <&cam2ep>;
> bus-width = <8>;
> data-shift = <8>;
> - bus-type = <6>;
> + bus-type = <MEDIA_BUS_TYPE_BT656>;
> };
> };
> };
> @@ -335,7 +338,7 @@ port {
> vin3ep: endpoint {
> remote-endpoint = <&cam3ep>;
> bus-width = <8>;
> - bus-type = <6>;
> + bus-type = <MEDIA_BUS_TYPE_BT656>;
> };
> };
> };
> diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> index 40cef0b1d1e6..c73160df619d 100644
> --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> @@ -7,6 +7,8 @@
> * Copyright (C) 2020 Renesas Electronics Corp.
> */
>
> +#include <dt-bindings/media/video-interfaces.h>
> +
> #define CAM_ENABLED 1
>
> &CAM_PARENT_I2C {
> @@ -26,7 +28,7 @@ port {
> CAM_EP: endpoint {
> bus-width = <8>;
> data-shift = <2>;
> - bus-type = <6>;
> + bus-type = <MEDIA_BUS_TYPE_BT656>;
> pclk-sample = <1>;
> remote-endpoint = <&VIN_EP>;
> };
> diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> index f5e77f024251..a7f5cfec64b8 100644
> --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> @@ -7,6 +7,8 @@
> * Copyright (C) 2020 Renesas Electronics Corp.
> */
>
> +#include <dt-bindings/media/video-interfaces.h>
> +
> #define CAM_ENABLED 1
>
> &CAM_PARENT_I2C {
> @@ -21,7 +23,7 @@ ov7725@21 {
> port {
> CAM_EP: endpoint {
> bus-width = <8>;
> - bus-type = <6>;
> + bus-type = <MEDIA_BUS_TYPE_BT656>;
> remote-endpoint = <&VIN_EP>;
> };
> };
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros
@ 2023-01-14 15:26 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2023-01-14 15:26 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo
Geert, could you please take this in your tree for v6.3 ? The two
patches that the DT changes depend on have been merged in v6.2.
On Thu, Jun 16, 2022 at 01:14:09AM +0300, Laurent Pinchart wrote:
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++----
> .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++-
> .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++-
> 3 files changed, 13 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> index 4e58c54cde17..33ac4bd1e63b 100644
> --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> @@ -7,6 +7,9 @@
> */
>
> /dts-v1/;
> +
> +#include <dt-bindings/media/video-interfaces.h>
> +
> #include "r8a7742-iwg21d-q7.dts"
>
> / {
> @@ -242,7 +245,7 @@ port {
> vin0ep: endpoint {
> remote-endpoint = <&cam0ep>;
> bus-width = <8>;
> - bus-type = <6>;
> + bus-type = <MEDIA_BUS_TYPE_BT656>;
> };
> };
> };
> @@ -273,7 +276,7 @@ port {
> vin1ep: endpoint {
> remote-endpoint = <&cam1ep>;
> bus-width = <8>;
> - bus-type = <6>;
> + bus-type = <MEDIA_BUS_TYPE_BT656>;
> };
> };
> };
> @@ -305,7 +308,7 @@ vin2ep: endpoint {
> remote-endpoint = <&cam2ep>;
> bus-width = <8>;
> data-shift = <8>;
> - bus-type = <6>;
> + bus-type = <MEDIA_BUS_TYPE_BT656>;
> };
> };
> };
> @@ -335,7 +338,7 @@ port {
> vin3ep: endpoint {
> remote-endpoint = <&cam3ep>;
> bus-width = <8>;
> - bus-type = <6>;
> + bus-type = <MEDIA_BUS_TYPE_BT656>;
> };
> };
> };
> diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> index 40cef0b1d1e6..c73160df619d 100644
> --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> @@ -7,6 +7,8 @@
> * Copyright (C) 2020 Renesas Electronics Corp.
> */
>
> +#include <dt-bindings/media/video-interfaces.h>
> +
> #define CAM_ENABLED 1
>
> &CAM_PARENT_I2C {
> @@ -26,7 +28,7 @@ port {
> CAM_EP: endpoint {
> bus-width = <8>;
> data-shift = <2>;
> - bus-type = <6>;
> + bus-type = <MEDIA_BUS_TYPE_BT656>;
> pclk-sample = <1>;
> remote-endpoint = <&VIN_EP>;
> };
> diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> index f5e77f024251..a7f5cfec64b8 100644
> --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> @@ -7,6 +7,8 @@
> * Copyright (C) 2020 Renesas Electronics Corp.
> */
>
> +#include <dt-bindings/media/video-interfaces.h>
> +
> #define CAM_ENABLED 1
>
> &CAM_PARENT_I2C {
> @@ -21,7 +23,7 @@ ov7725@21 {
> port {
> CAM_EP: endpoint {
> bus-width = <8>;
> - bus-type = <6>;
> + bus-type = <MEDIA_BUS_TYPE_BT656>;
> remote-endpoint = <&VIN_EP>;
> };
> };
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros
@ 2023-01-14 15:26 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2023-01-14 15:26 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: devicetree, Jacopo Mondi, Maxime Coquelin, Hugues Fruchet,
Alexandre Torgue, dri-devel, Lad Prabhakar, Rob Herring,
Sakari Ailus, Eugen Hristev, Shawn Guo, linux-arm-kernel,
linux-media
Geert, could you please take this in your tree for v6.3 ? The two
patches that the DT changes depend on have been merged in v6.2.
On Thu, Jun 16, 2022 at 01:14:09AM +0300, Laurent Pinchart wrote:
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++----
> .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++-
> .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++-
> 3 files changed, 13 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> index 4e58c54cde17..33ac4bd1e63b 100644
> --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> @@ -7,6 +7,9 @@
> */
>
> /dts-v1/;
> +
> +#include <dt-bindings/media/video-interfaces.h>
> +
> #include "r8a7742-iwg21d-q7.dts"
>
> / {
> @@ -242,7 +245,7 @@ port {
> vin0ep: endpoint {
> remote-endpoint = <&cam0ep>;
> bus-width = <8>;
> - bus-type = <6>;
> + bus-type = <MEDIA_BUS_TYPE_BT656>;
> };
> };
> };
> @@ -273,7 +276,7 @@ port {
> vin1ep: endpoint {
> remote-endpoint = <&cam1ep>;
> bus-width = <8>;
> - bus-type = <6>;
> + bus-type = <MEDIA_BUS_TYPE_BT656>;
> };
> };
> };
> @@ -305,7 +308,7 @@ vin2ep: endpoint {
> remote-endpoint = <&cam2ep>;
> bus-width = <8>;
> data-shift = <8>;
> - bus-type = <6>;
> + bus-type = <MEDIA_BUS_TYPE_BT656>;
> };
> };
> };
> @@ -335,7 +338,7 @@ port {
> vin3ep: endpoint {
> remote-endpoint = <&cam3ep>;
> bus-width = <8>;
> - bus-type = <6>;
> + bus-type = <MEDIA_BUS_TYPE_BT656>;
> };
> };
> };
> diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> index 40cef0b1d1e6..c73160df619d 100644
> --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> @@ -7,6 +7,8 @@
> * Copyright (C) 2020 Renesas Electronics Corp.
> */
>
> +#include <dt-bindings/media/video-interfaces.h>
> +
> #define CAM_ENABLED 1
>
> &CAM_PARENT_I2C {
> @@ -26,7 +28,7 @@ port {
> CAM_EP: endpoint {
> bus-width = <8>;
> data-shift = <2>;
> - bus-type = <6>;
> + bus-type = <MEDIA_BUS_TYPE_BT656>;
> pclk-sample = <1>;
> remote-endpoint = <&VIN_EP>;
> };
> diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> index f5e77f024251..a7f5cfec64b8 100644
> --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> @@ -7,6 +7,8 @@
> * Copyright (C) 2020 Renesas Electronics Corp.
> */
>
> +#include <dt-bindings/media/video-interfaces.h>
> +
> #define CAM_ENABLED 1
>
> &CAM_PARENT_I2C {
> @@ -21,7 +23,7 @@ ov7725@21 {
> port {
> CAM_EP: endpoint {
> bus-width = <8>;
> - bus-type = <6>;
> + bus-type = <MEDIA_BUS_TYPE_BT656>;
> remote-endpoint = <&VIN_EP>;
> };
> };
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros
2023-01-14 15:26 ` Laurent Pinchart
(?)
@ 2023-01-16 10:24 ` Geert Uytterhoeven
-1 siblings, 0 replies; 102+ messages in thread
From: Geert Uytterhoeven @ 2023-01-16 10:24 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo, Linux-Renesas
Hi Laurent,
CC linux-renesas-soc
On Sat, Jan 14, 2023 at 4:26 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> Geert, could you please take this in your tree for v6.3 ? The two
> patches that the DT changes depend on have been merged in v6.2.
Thank you, I had missed these.
> On Thu, Jun 16, 2022 at 01:14:09AM +0300, Laurent Pinchart wrote:
> > Now that a header exists with macros for the media interface bus-type
> > values, replace hardcoding numerical constants with the corresponding
> > macros in the DT sources.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++----
> > .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++-
> > .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++-
> > 3 files changed, 13 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > index 4e58c54cde17..33ac4bd1e63b 100644
> > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > @@ -7,6 +7,9 @@
> > */
> >
> > /dts-v1/;
> > +
> > +#include <dt-bindings/media/video-interfaces.h>
> > +
> > #include "r8a7742-iwg21d-q7.dts"
> >
> > / {
> > @@ -242,7 +245,7 @@ port {
> > vin0ep: endpoint {
> > remote-endpoint = <&cam0ep>;
> > bus-width = <8>;
> > - bus-type = <6>;
> > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > };
> > };
> > };
> > @@ -273,7 +276,7 @@ port {
> > vin1ep: endpoint {
> > remote-endpoint = <&cam1ep>;
> > bus-width = <8>;
> > - bus-type = <6>;
> > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > };
> > };
> > };
> > @@ -305,7 +308,7 @@ vin2ep: endpoint {
> > remote-endpoint = <&cam2ep>;
> > bus-width = <8>;
> > data-shift = <8>;
> > - bus-type = <6>;
> > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > };
> > };
> > };
> > @@ -335,7 +338,7 @@ port {
> > vin3ep: endpoint {
> > remote-endpoint = <&cam3ep>;
> > bus-width = <8>;
> > - bus-type = <6>;
> > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > };
> > };
> > };
> > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > index 40cef0b1d1e6..c73160df619d 100644
> > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > @@ -7,6 +7,8 @@
> > * Copyright (C) 2020 Renesas Electronics Corp.
> > */
> >
> > +#include <dt-bindings/media/video-interfaces.h>
This .dtsi file is only intended to be included by
arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts, which already has
the include. Hence if you don't mind, I would like to drop this part
while applying and queuing in renesas-devel for v6.3.
> > +
> > #define CAM_ENABLED 1
> >
> > &CAM_PARENT_I2C {
> > @@ -26,7 +28,7 @@ port {
> > CAM_EP: endpoint {
> > bus-width = <8>;
> > data-shift = <2>;
> > - bus-type = <6>;
> > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > pclk-sample = <1>;
> > remote-endpoint = <&VIN_EP>;
> > };
> > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> > index f5e77f024251..a7f5cfec64b8 100644
> > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> > @@ -7,6 +7,8 @@
> > * Copyright (C) 2020 Renesas Electronics Corp.
> > */
> >
> > +#include <dt-bindings/media/video-interfaces.h>
Likewise
> > +
> > #define CAM_ENABLED 1
> >
> > &CAM_PARENT_I2C {
> > @@ -21,7 +23,7 @@ ov7725@21 {
> > port {
> > CAM_EP: endpoint {
> > bus-width = <8>;
> > - bus-type = <6>;
> > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > remote-endpoint = <&VIN_EP>;
> > };
> > };
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros
@ 2023-01-16 10:24 ` Geert Uytterhoeven
0 siblings, 0 replies; 102+ messages in thread
From: Geert Uytterhoeven @ 2023-01-16 10:24 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo, Linux-Renesas
Hi Laurent,
CC linux-renesas-soc
On Sat, Jan 14, 2023 at 4:26 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> Geert, could you please take this in your tree for v6.3 ? The two
> patches that the DT changes depend on have been merged in v6.2.
Thank you, I had missed these.
> On Thu, Jun 16, 2022 at 01:14:09AM +0300, Laurent Pinchart wrote:
> > Now that a header exists with macros for the media interface bus-type
> > values, replace hardcoding numerical constants with the corresponding
> > macros in the DT sources.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++----
> > .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++-
> > .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++-
> > 3 files changed, 13 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > index 4e58c54cde17..33ac4bd1e63b 100644
> > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > @@ -7,6 +7,9 @@
> > */
> >
> > /dts-v1/;
> > +
> > +#include <dt-bindings/media/video-interfaces.h>
> > +
> > #include "r8a7742-iwg21d-q7.dts"
> >
> > / {
> > @@ -242,7 +245,7 @@ port {
> > vin0ep: endpoint {
> > remote-endpoint = <&cam0ep>;
> > bus-width = <8>;
> > - bus-type = <6>;
> > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > };
> > };
> > };
> > @@ -273,7 +276,7 @@ port {
> > vin1ep: endpoint {
> > remote-endpoint = <&cam1ep>;
> > bus-width = <8>;
> > - bus-type = <6>;
> > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > };
> > };
> > };
> > @@ -305,7 +308,7 @@ vin2ep: endpoint {
> > remote-endpoint = <&cam2ep>;
> > bus-width = <8>;
> > data-shift = <8>;
> > - bus-type = <6>;
> > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > };
> > };
> > };
> > @@ -335,7 +338,7 @@ port {
> > vin3ep: endpoint {
> > remote-endpoint = <&cam3ep>;
> > bus-width = <8>;
> > - bus-type = <6>;
> > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > };
> > };
> > };
> > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > index 40cef0b1d1e6..c73160df619d 100644
> > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > @@ -7,6 +7,8 @@
> > * Copyright (C) 2020 Renesas Electronics Corp.
> > */
> >
> > +#include <dt-bindings/media/video-interfaces.h>
This .dtsi file is only intended to be included by
arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts, which already has
the include. Hence if you don't mind, I would like to drop this part
while applying and queuing in renesas-devel for v6.3.
> > +
> > #define CAM_ENABLED 1
> >
> > &CAM_PARENT_I2C {
> > @@ -26,7 +28,7 @@ port {
> > CAM_EP: endpoint {
> > bus-width = <8>;
> > data-shift = <2>;
> > - bus-type = <6>;
> > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > pclk-sample = <1>;
> > remote-endpoint = <&VIN_EP>;
> > };
> > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> > index f5e77f024251..a7f5cfec64b8 100644
> > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> > @@ -7,6 +7,8 @@
> > * Copyright (C) 2020 Renesas Electronics Corp.
> > */
> >
> > +#include <dt-bindings/media/video-interfaces.h>
Likewise
> > +
> > #define CAM_ENABLED 1
> >
> > &CAM_PARENT_I2C {
> > @@ -21,7 +23,7 @@ ov7725@21 {
> > port {
> > CAM_EP: endpoint {
> > bus-width = <8>;
> > - bus-type = <6>;
> > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > remote-endpoint = <&VIN_EP>;
> > };
> > };
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros
@ 2023-01-16 10:24 ` Geert Uytterhoeven
0 siblings, 0 replies; 102+ messages in thread
From: Geert Uytterhoeven @ 2023-01-16 10:24 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, Jacopo Mondi, Maxime Coquelin, Hugues Fruchet,
Alexandre Torgue, dri-devel, Lad Prabhakar, Linux-Renesas,
Rob Herring, Sakari Ailus, Eugen Hristev, Shawn Guo,
linux-arm-kernel, linux-media
Hi Laurent,
CC linux-renesas-soc
On Sat, Jan 14, 2023 at 4:26 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> Geert, could you please take this in your tree for v6.3 ? The two
> patches that the DT changes depend on have been merged in v6.2.
Thank you, I had missed these.
> On Thu, Jun 16, 2022 at 01:14:09AM +0300, Laurent Pinchart wrote:
> > Now that a header exists with macros for the media interface bus-type
> > values, replace hardcoding numerical constants with the corresponding
> > macros in the DT sources.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++----
> > .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++-
> > .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++-
> > 3 files changed, 13 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > index 4e58c54cde17..33ac4bd1e63b 100644
> > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > @@ -7,6 +7,9 @@
> > */
> >
> > /dts-v1/;
> > +
> > +#include <dt-bindings/media/video-interfaces.h>
> > +
> > #include "r8a7742-iwg21d-q7.dts"
> >
> > / {
> > @@ -242,7 +245,7 @@ port {
> > vin0ep: endpoint {
> > remote-endpoint = <&cam0ep>;
> > bus-width = <8>;
> > - bus-type = <6>;
> > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > };
> > };
> > };
> > @@ -273,7 +276,7 @@ port {
> > vin1ep: endpoint {
> > remote-endpoint = <&cam1ep>;
> > bus-width = <8>;
> > - bus-type = <6>;
> > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > };
> > };
> > };
> > @@ -305,7 +308,7 @@ vin2ep: endpoint {
> > remote-endpoint = <&cam2ep>;
> > bus-width = <8>;
> > data-shift = <8>;
> > - bus-type = <6>;
> > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > };
> > };
> > };
> > @@ -335,7 +338,7 @@ port {
> > vin3ep: endpoint {
> > remote-endpoint = <&cam3ep>;
> > bus-width = <8>;
> > - bus-type = <6>;
> > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > };
> > };
> > };
> > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > index 40cef0b1d1e6..c73160df619d 100644
> > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > @@ -7,6 +7,8 @@
> > * Copyright (C) 2020 Renesas Electronics Corp.
> > */
> >
> > +#include <dt-bindings/media/video-interfaces.h>
This .dtsi file is only intended to be included by
arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts, which already has
the include. Hence if you don't mind, I would like to drop this part
while applying and queuing in renesas-devel for v6.3.
> > +
> > #define CAM_ENABLED 1
> >
> > &CAM_PARENT_I2C {
> > @@ -26,7 +28,7 @@ port {
> > CAM_EP: endpoint {
> > bus-width = <8>;
> > data-shift = <2>;
> > - bus-type = <6>;
> > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > pclk-sample = <1>;
> > remote-endpoint = <&VIN_EP>;
> > };
> > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> > index f5e77f024251..a7f5cfec64b8 100644
> > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> > @@ -7,6 +7,8 @@
> > * Copyright (C) 2020 Renesas Electronics Corp.
> > */
> >
> > +#include <dt-bindings/media/video-interfaces.h>
Likewise
> > +
> > #define CAM_ENABLED 1
> >
> > &CAM_PARENT_I2C {
> > @@ -21,7 +23,7 @@ ov7725@21 {
> > port {
> > CAM_EP: endpoint {
> > bus-width = <8>;
> > - bus-type = <6>;
> > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > remote-endpoint = <&VIN_EP>;
> > };
> > };
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros
2023-01-16 10:24 ` Geert Uytterhoeven
(?)
@ 2023-01-16 10:38 ` Laurent Pinchart
-1 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2023-01-16 10:38 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: devicetree, Jacopo Mondi, Maxime Coquelin, Hugues Fruchet,
Alexandre Torgue, dri-devel, Lad Prabhakar, Linux-Renesas,
Rob Herring, Sakari Ailus, Eugen Hristev, Shawn Guo,
linux-arm-kernel, linux-media
Hi Geert,
On Mon, Jan 16, 2023 at 11:24:10AM +0100, Geert Uytterhoeven wrote:
> On Sat, Jan 14, 2023 at 4:26 PM Laurent Pinchart wrote:
> > Geert, could you please take this in your tree for v6.3 ? The two
> > patches that the DT changes depend on have been merged in v6.2.
>
> Thank you, I had missed these.
>
> > On Thu, Jun 16, 2022 at 01:14:09AM +0300, Laurent Pinchart wrote:
> > > Now that a header exists with macros for the media interface bus-type
> > > values, replace hardcoding numerical constants with the corresponding
> > > macros in the DT sources.
> > >
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> > > ---
> > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++----
> > > .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++-
> > > .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++-
> > > 3 files changed, 13 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > index 4e58c54cde17..33ac4bd1e63b 100644
> > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > @@ -7,6 +7,9 @@
> > > */
> > >
> > > /dts-v1/;
> > > +
> > > +#include <dt-bindings/media/video-interfaces.h>
> > > +
> > > #include "r8a7742-iwg21d-q7.dts"
> > >
> > > / {
> > > @@ -242,7 +245,7 @@ port {
> > > vin0ep: endpoint {
> > > remote-endpoint = <&cam0ep>;
> > > bus-width = <8>;
> > > - bus-type = <6>;
> > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > };
> > > };
> > > };
> > > @@ -273,7 +276,7 @@ port {
> > > vin1ep: endpoint {
> > > remote-endpoint = <&cam1ep>;
> > > bus-width = <8>;
> > > - bus-type = <6>;
> > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > };
> > > };
> > > };
> > > @@ -305,7 +308,7 @@ vin2ep: endpoint {
> > > remote-endpoint = <&cam2ep>;
> > > bus-width = <8>;
> > > data-shift = <8>;
> > > - bus-type = <6>;
> > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > };
> > > };
> > > };
> > > @@ -335,7 +338,7 @@ port {
> > > vin3ep: endpoint {
> > > remote-endpoint = <&cam3ep>;
> > > bus-width = <8>;
> > > - bus-type = <6>;
> > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > };
> > > };
> > > };
> > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > index 40cef0b1d1e6..c73160df619d 100644
> > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > @@ -7,6 +7,8 @@
> > > * Copyright (C) 2020 Renesas Electronics Corp.
> > > */
> > >
> > > +#include <dt-bindings/media/video-interfaces.h>
>
> This .dtsi file is only intended to be included by
> arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts, which already has
> the include. Hence if you don't mind, I would like to drop this part
> while applying and queuing in renesas-devel for v6.3.
Isn't it better to include headers as needed to avoid depending on
indirect includes ?
> > > +
> > > #define CAM_ENABLED 1
> > >
> > > &CAM_PARENT_I2C {
> > > @@ -26,7 +28,7 @@ port {
> > > CAM_EP: endpoint {
> > > bus-width = <8>;
> > > data-shift = <2>;
> > > - bus-type = <6>;
> > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > pclk-sample = <1>;
> > > remote-endpoint = <&VIN_EP>;
> > > };
> > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> > > index f5e77f024251..a7f5cfec64b8 100644
> > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> > > @@ -7,6 +7,8 @@
> > > * Copyright (C) 2020 Renesas Electronics Corp.
> > > */
> > >
> > > +#include <dt-bindings/media/video-interfaces.h>
>
> Likewise
>
> > > +
> > > #define CAM_ENABLED 1
> > >
> > > &CAM_PARENT_I2C {
> > > @@ -21,7 +23,7 @@ ov7725@21 {
> > > port {
> > > CAM_EP: endpoint {
> > > bus-width = <8>;
> > > - bus-type = <6>;
> > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > remote-endpoint = <&VIN_EP>;
> > > };
> > > };
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros
@ 2023-01-16 10:38 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2023-01-16 10:38 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo, Linux-Renesas
Hi Geert,
On Mon, Jan 16, 2023 at 11:24:10AM +0100, Geert Uytterhoeven wrote:
> On Sat, Jan 14, 2023 at 4:26 PM Laurent Pinchart wrote:
> > Geert, could you please take this in your tree for v6.3 ? The two
> > patches that the DT changes depend on have been merged in v6.2.
>
> Thank you, I had missed these.
>
> > On Thu, Jun 16, 2022 at 01:14:09AM +0300, Laurent Pinchart wrote:
> > > Now that a header exists with macros for the media interface bus-type
> > > values, replace hardcoding numerical constants with the corresponding
> > > macros in the DT sources.
> > >
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> > > ---
> > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++----
> > > .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++-
> > > .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++-
> > > 3 files changed, 13 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > index 4e58c54cde17..33ac4bd1e63b 100644
> > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > @@ -7,6 +7,9 @@
> > > */
> > >
> > > /dts-v1/;
> > > +
> > > +#include <dt-bindings/media/video-interfaces.h>
> > > +
> > > #include "r8a7742-iwg21d-q7.dts"
> > >
> > > / {
> > > @@ -242,7 +245,7 @@ port {
> > > vin0ep: endpoint {
> > > remote-endpoint = <&cam0ep>;
> > > bus-width = <8>;
> > > - bus-type = <6>;
> > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > };
> > > };
> > > };
> > > @@ -273,7 +276,7 @@ port {
> > > vin1ep: endpoint {
> > > remote-endpoint = <&cam1ep>;
> > > bus-width = <8>;
> > > - bus-type = <6>;
> > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > };
> > > };
> > > };
> > > @@ -305,7 +308,7 @@ vin2ep: endpoint {
> > > remote-endpoint = <&cam2ep>;
> > > bus-width = <8>;
> > > data-shift = <8>;
> > > - bus-type = <6>;
> > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > };
> > > };
> > > };
> > > @@ -335,7 +338,7 @@ port {
> > > vin3ep: endpoint {
> > > remote-endpoint = <&cam3ep>;
> > > bus-width = <8>;
> > > - bus-type = <6>;
> > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > };
> > > };
> > > };
> > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > index 40cef0b1d1e6..c73160df619d 100644
> > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > @@ -7,6 +7,8 @@
> > > * Copyright (C) 2020 Renesas Electronics Corp.
> > > */
> > >
> > > +#include <dt-bindings/media/video-interfaces.h>
>
> This .dtsi file is only intended to be included by
> arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts, which already has
> the include. Hence if you don't mind, I would like to drop this part
> while applying and queuing in renesas-devel for v6.3.
Isn't it better to include headers as needed to avoid depending on
indirect includes ?
> > > +
> > > #define CAM_ENABLED 1
> > >
> > > &CAM_PARENT_I2C {
> > > @@ -26,7 +28,7 @@ port {
> > > CAM_EP: endpoint {
> > > bus-width = <8>;
> > > data-shift = <2>;
> > > - bus-type = <6>;
> > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > pclk-sample = <1>;
> > > remote-endpoint = <&VIN_EP>;
> > > };
> > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> > > index f5e77f024251..a7f5cfec64b8 100644
> > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> > > @@ -7,6 +7,8 @@
> > > * Copyright (C) 2020 Renesas Electronics Corp.
> > > */
> > >
> > > +#include <dt-bindings/media/video-interfaces.h>
>
> Likewise
>
> > > +
> > > #define CAM_ENABLED 1
> > >
> > > &CAM_PARENT_I2C {
> > > @@ -21,7 +23,7 @@ ov7725@21 {
> > > port {
> > > CAM_EP: endpoint {
> > > bus-width = <8>;
> > > - bus-type = <6>;
> > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > remote-endpoint = <&VIN_EP>;
> > > };
> > > };
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros
@ 2023-01-16 10:38 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2023-01-16 10:38 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo, Linux-Renesas
Hi Geert,
On Mon, Jan 16, 2023 at 11:24:10AM +0100, Geert Uytterhoeven wrote:
> On Sat, Jan 14, 2023 at 4:26 PM Laurent Pinchart wrote:
> > Geert, could you please take this in your tree for v6.3 ? The two
> > patches that the DT changes depend on have been merged in v6.2.
>
> Thank you, I had missed these.
>
> > On Thu, Jun 16, 2022 at 01:14:09AM +0300, Laurent Pinchart wrote:
> > > Now that a header exists with macros for the media interface bus-type
> > > values, replace hardcoding numerical constants with the corresponding
> > > macros in the DT sources.
> > >
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> > > ---
> > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++----
> > > .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++-
> > > .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++-
> > > 3 files changed, 13 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > index 4e58c54cde17..33ac4bd1e63b 100644
> > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > @@ -7,6 +7,9 @@
> > > */
> > >
> > > /dts-v1/;
> > > +
> > > +#include <dt-bindings/media/video-interfaces.h>
> > > +
> > > #include "r8a7742-iwg21d-q7.dts"
> > >
> > > / {
> > > @@ -242,7 +245,7 @@ port {
> > > vin0ep: endpoint {
> > > remote-endpoint = <&cam0ep>;
> > > bus-width = <8>;
> > > - bus-type = <6>;
> > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > };
> > > };
> > > };
> > > @@ -273,7 +276,7 @@ port {
> > > vin1ep: endpoint {
> > > remote-endpoint = <&cam1ep>;
> > > bus-width = <8>;
> > > - bus-type = <6>;
> > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > };
> > > };
> > > };
> > > @@ -305,7 +308,7 @@ vin2ep: endpoint {
> > > remote-endpoint = <&cam2ep>;
> > > bus-width = <8>;
> > > data-shift = <8>;
> > > - bus-type = <6>;
> > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > };
> > > };
> > > };
> > > @@ -335,7 +338,7 @@ port {
> > > vin3ep: endpoint {
> > > remote-endpoint = <&cam3ep>;
> > > bus-width = <8>;
> > > - bus-type = <6>;
> > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > };
> > > };
> > > };
> > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > index 40cef0b1d1e6..c73160df619d 100644
> > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > @@ -7,6 +7,8 @@
> > > * Copyright (C) 2020 Renesas Electronics Corp.
> > > */
> > >
> > > +#include <dt-bindings/media/video-interfaces.h>
>
> This .dtsi file is only intended to be included by
> arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts, which already has
> the include. Hence if you don't mind, I would like to drop this part
> while applying and queuing in renesas-devel for v6.3.
Isn't it better to include headers as needed to avoid depending on
indirect includes ?
> > > +
> > > #define CAM_ENABLED 1
> > >
> > > &CAM_PARENT_I2C {
> > > @@ -26,7 +28,7 @@ port {
> > > CAM_EP: endpoint {
> > > bus-width = <8>;
> > > data-shift = <2>;
> > > - bus-type = <6>;
> > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > pclk-sample = <1>;
> > > remote-endpoint = <&VIN_EP>;
> > > };
> > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> > > index f5e77f024251..a7f5cfec64b8 100644
> > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi
> > > @@ -7,6 +7,8 @@
> > > * Copyright (C) 2020 Renesas Electronics Corp.
> > > */
> > >
> > > +#include <dt-bindings/media/video-interfaces.h>
>
> Likewise
>
> > > +
> > > #define CAM_ENABLED 1
> > >
> > > &CAM_PARENT_I2C {
> > > @@ -21,7 +23,7 @@ ov7725@21 {
> > > port {
> > > CAM_EP: endpoint {
> > > bus-width = <8>;
> > > - bus-type = <6>;
> > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > remote-endpoint = <&VIN_EP>;
> > > };
> > > };
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros
2023-01-16 10:38 ` Laurent Pinchart
(?)
@ 2023-01-16 10:44 ` Geert Uytterhoeven
-1 siblings, 0 replies; 102+ messages in thread
From: Geert Uytterhoeven @ 2023-01-16 10:44 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, Jacopo Mondi, Maxime Coquelin, Hugues Fruchet,
Alexandre Torgue, dri-devel, Lad Prabhakar, Linux-Renesas,
Rob Herring, Sakari Ailus, Eugen Hristev, Shawn Guo,
linux-arm-kernel, linux-media
Hi Laurent,
On Mon, Jan 16, 2023 at 11:38 AM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Mon, Jan 16, 2023 at 11:24:10AM +0100, Geert Uytterhoeven wrote:
> > On Sat, Jan 14, 2023 at 4:26 PM Laurent Pinchart wrote:
> > > Geert, could you please take this in your tree for v6.3 ? The two
> > > patches that the DT changes depend on have been merged in v6.2.
> >
> > Thank you, I had missed these.
> >
> > > On Thu, Jun 16, 2022 at 01:14:09AM +0300, Laurent Pinchart wrote:
> > > > Now that a header exists with macros for the media interface bus-type
> > > > values, replace hardcoding numerical constants with the corresponding
> > > > macros in the DT sources.
> > > >
> > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > > > ---
> > > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++----
> > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++-
> > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++-
> > > > 3 files changed, 13 insertions(+), 6 deletions(-)
> > > >
> > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > > index 4e58c54cde17..33ac4bd1e63b 100644
> > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > > @@ -7,6 +7,9 @@
> > > > */
> > > >
> > > > /dts-v1/;
> > > > +
> > > > +#include <dt-bindings/media/video-interfaces.h>
> > > > +
> > > > #include "r8a7742-iwg21d-q7.dts"
> > > >
> > > > / {
> > > > @@ -242,7 +245,7 @@ port {
> > > > vin0ep: endpoint {
> > > > remote-endpoint = <&cam0ep>;
> > > > bus-width = <8>;
> > > > - bus-type = <6>;
> > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > };
> > > > };
> > > > };
> > > > @@ -273,7 +276,7 @@ port {
> > > > vin1ep: endpoint {
> > > > remote-endpoint = <&cam1ep>;
> > > > bus-width = <8>;
> > > > - bus-type = <6>;
> > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > };
> > > > };
> > > > };
> > > > @@ -305,7 +308,7 @@ vin2ep: endpoint {
> > > > remote-endpoint = <&cam2ep>;
> > > > bus-width = <8>;
> > > > data-shift = <8>;
> > > > - bus-type = <6>;
> > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > };
> > > > };
> > > > };
> > > > @@ -335,7 +338,7 @@ port {
> > > > vin3ep: endpoint {
> > > > remote-endpoint = <&cam3ep>;
> > > > bus-width = <8>;
> > > > - bus-type = <6>;
> > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > };
> > > > };
> > > > };
> > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > > index 40cef0b1d1e6..c73160df619d 100644
> > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > > @@ -7,6 +7,8 @@
> > > > * Copyright (C) 2020 Renesas Electronics Corp.
> > > > */
> > > >
> > > > +#include <dt-bindings/media/video-interfaces.h>
> >
> > This .dtsi file is only intended to be included by
> > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts, which already has
> > the include. Hence if you don't mind, I would like to drop this part
> > while applying and queuing in renesas-devel for v6.3.
>
> Isn't it better to include headers as needed to avoid depending on
> indirect includes ?
In general, I agree.
In this particular case, (the multiple inclusions of) the
r8a7742-iwg21d-q7-dbcm-ov*-single.dtsi files are tied very intimately
to r8a7742-iwg21d-q7-dbcm-ca.dts.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros
@ 2023-01-16 10:44 ` Geert Uytterhoeven
0 siblings, 0 replies; 102+ messages in thread
From: Geert Uytterhoeven @ 2023-01-16 10:44 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo, Linux-Renesas
Hi Laurent,
On Mon, Jan 16, 2023 at 11:38 AM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Mon, Jan 16, 2023 at 11:24:10AM +0100, Geert Uytterhoeven wrote:
> > On Sat, Jan 14, 2023 at 4:26 PM Laurent Pinchart wrote:
> > > Geert, could you please take this in your tree for v6.3 ? The two
> > > patches that the DT changes depend on have been merged in v6.2.
> >
> > Thank you, I had missed these.
> >
> > > On Thu, Jun 16, 2022 at 01:14:09AM +0300, Laurent Pinchart wrote:
> > > > Now that a header exists with macros for the media interface bus-type
> > > > values, replace hardcoding numerical constants with the corresponding
> > > > macros in the DT sources.
> > > >
> > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > > > ---
> > > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++----
> > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++-
> > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++-
> > > > 3 files changed, 13 insertions(+), 6 deletions(-)
> > > >
> > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > > index 4e58c54cde17..33ac4bd1e63b 100644
> > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > > @@ -7,6 +7,9 @@
> > > > */
> > > >
> > > > /dts-v1/;
> > > > +
> > > > +#include <dt-bindings/media/video-interfaces.h>
> > > > +
> > > > #include "r8a7742-iwg21d-q7.dts"
> > > >
> > > > / {
> > > > @@ -242,7 +245,7 @@ port {
> > > > vin0ep: endpoint {
> > > > remote-endpoint = <&cam0ep>;
> > > > bus-width = <8>;
> > > > - bus-type = <6>;
> > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > };
> > > > };
> > > > };
> > > > @@ -273,7 +276,7 @@ port {
> > > > vin1ep: endpoint {
> > > > remote-endpoint = <&cam1ep>;
> > > > bus-width = <8>;
> > > > - bus-type = <6>;
> > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > };
> > > > };
> > > > };
> > > > @@ -305,7 +308,7 @@ vin2ep: endpoint {
> > > > remote-endpoint = <&cam2ep>;
> > > > bus-width = <8>;
> > > > data-shift = <8>;
> > > > - bus-type = <6>;
> > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > };
> > > > };
> > > > };
> > > > @@ -335,7 +338,7 @@ port {
> > > > vin3ep: endpoint {
> > > > remote-endpoint = <&cam3ep>;
> > > > bus-width = <8>;
> > > > - bus-type = <6>;
> > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > };
> > > > };
> > > > };
> > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > > index 40cef0b1d1e6..c73160df619d 100644
> > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > > @@ -7,6 +7,8 @@
> > > > * Copyright (C) 2020 Renesas Electronics Corp.
> > > > */
> > > >
> > > > +#include <dt-bindings/media/video-interfaces.h>
> >
> > This .dtsi file is only intended to be included by
> > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts, which already has
> > the include. Hence if you don't mind, I would like to drop this part
> > while applying and queuing in renesas-devel for v6.3.
>
> Isn't it better to include headers as needed to avoid depending on
> indirect includes ?
In general, I agree.
In this particular case, (the multiple inclusions of) the
r8a7742-iwg21d-q7-dbcm-ov*-single.dtsi files are tied very intimately
to r8a7742-iwg21d-q7-dbcm-ca.dts.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros
@ 2023-01-16 10:44 ` Geert Uytterhoeven
0 siblings, 0 replies; 102+ messages in thread
From: Geert Uytterhoeven @ 2023-01-16 10:44 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo, Linux-Renesas
Hi Laurent,
On Mon, Jan 16, 2023 at 11:38 AM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Mon, Jan 16, 2023 at 11:24:10AM +0100, Geert Uytterhoeven wrote:
> > On Sat, Jan 14, 2023 at 4:26 PM Laurent Pinchart wrote:
> > > Geert, could you please take this in your tree for v6.3 ? The two
> > > patches that the DT changes depend on have been merged in v6.2.
> >
> > Thank you, I had missed these.
> >
> > > On Thu, Jun 16, 2022 at 01:14:09AM +0300, Laurent Pinchart wrote:
> > > > Now that a header exists with macros for the media interface bus-type
> > > > values, replace hardcoding numerical constants with the corresponding
> > > > macros in the DT sources.
> > > >
> > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > > > ---
> > > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++----
> > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++-
> > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++-
> > > > 3 files changed, 13 insertions(+), 6 deletions(-)
> > > >
> > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > > index 4e58c54cde17..33ac4bd1e63b 100644
> > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > > @@ -7,6 +7,9 @@
> > > > */
> > > >
> > > > /dts-v1/;
> > > > +
> > > > +#include <dt-bindings/media/video-interfaces.h>
> > > > +
> > > > #include "r8a7742-iwg21d-q7.dts"
> > > >
> > > > / {
> > > > @@ -242,7 +245,7 @@ port {
> > > > vin0ep: endpoint {
> > > > remote-endpoint = <&cam0ep>;
> > > > bus-width = <8>;
> > > > - bus-type = <6>;
> > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > };
> > > > };
> > > > };
> > > > @@ -273,7 +276,7 @@ port {
> > > > vin1ep: endpoint {
> > > > remote-endpoint = <&cam1ep>;
> > > > bus-width = <8>;
> > > > - bus-type = <6>;
> > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > };
> > > > };
> > > > };
> > > > @@ -305,7 +308,7 @@ vin2ep: endpoint {
> > > > remote-endpoint = <&cam2ep>;
> > > > bus-width = <8>;
> > > > data-shift = <8>;
> > > > - bus-type = <6>;
> > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > };
> > > > };
> > > > };
> > > > @@ -335,7 +338,7 @@ port {
> > > > vin3ep: endpoint {
> > > > remote-endpoint = <&cam3ep>;
> > > > bus-width = <8>;
> > > > - bus-type = <6>;
> > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > };
> > > > };
> > > > };
> > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > > index 40cef0b1d1e6..c73160df619d 100644
> > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > > @@ -7,6 +7,8 @@
> > > > * Copyright (C) 2020 Renesas Electronics Corp.
> > > > */
> > > >
> > > > +#include <dt-bindings/media/video-interfaces.h>
> >
> > This .dtsi file is only intended to be included by
> > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts, which already has
> > the include. Hence if you don't mind, I would like to drop this part
> > while applying and queuing in renesas-devel for v6.3.
>
> Isn't it better to include headers as needed to avoid depending on
> indirect includes ?
In general, I agree.
In this particular case, (the multiple inclusions of) the
r8a7742-iwg21d-q7-dbcm-ov*-single.dtsi files are tied very intimately
to r8a7742-iwg21d-q7-dbcm-ca.dts.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros
2023-01-16 10:44 ` Geert Uytterhoeven
(?)
@ 2023-01-16 10:49 ` Laurent Pinchart
-1 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2023-01-16 10:49 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo, Linux-Renesas
On Mon, Jan 16, 2023 at 11:44:13AM +0100, Geert Uytterhoeven wrote:
> On Mon, Jan 16, 2023 at 11:38 AM Laurent Pinchart wrote:
> > On Mon, Jan 16, 2023 at 11:24:10AM +0100, Geert Uytterhoeven wrote:
> > > On Sat, Jan 14, 2023 at 4:26 PM Laurent Pinchart wrote:
> > > > Geert, could you please take this in your tree for v6.3 ? The two
> > > > patches that the DT changes depend on have been merged in v6.2.
> > >
> > > Thank you, I had missed these.
> > >
> > > > On Thu, Jun 16, 2022 at 01:14:09AM +0300, Laurent Pinchart wrote:
> > > > > Now that a header exists with macros for the media interface bus-type
> > > > > values, replace hardcoding numerical constants with the corresponding
> > > > > macros in the DT sources.
> > > > >
> > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > >
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > >
> > > > > ---
> > > > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++----
> > > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++-
> > > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++-
> > > > > 3 files changed, 13 insertions(+), 6 deletions(-)
> > > > >
> > > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > > > index 4e58c54cde17..33ac4bd1e63b 100644
> > > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > > > @@ -7,6 +7,9 @@
> > > > > */
> > > > >
> > > > > /dts-v1/;
> > > > > +
> > > > > +#include <dt-bindings/media/video-interfaces.h>
> > > > > +
> > > > > #include "r8a7742-iwg21d-q7.dts"
> > > > >
> > > > > / {
> > > > > @@ -242,7 +245,7 @@ port {
> > > > > vin0ep: endpoint {
> > > > > remote-endpoint = <&cam0ep>;
> > > > > bus-width = <8>;
> > > > > - bus-type = <6>;
> > > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > > };
> > > > > };
> > > > > };
> > > > > @@ -273,7 +276,7 @@ port {
> > > > > vin1ep: endpoint {
> > > > > remote-endpoint = <&cam1ep>;
> > > > > bus-width = <8>;
> > > > > - bus-type = <6>;
> > > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > > };
> > > > > };
> > > > > };
> > > > > @@ -305,7 +308,7 @@ vin2ep: endpoint {
> > > > > remote-endpoint = <&cam2ep>;
> > > > > bus-width = <8>;
> > > > > data-shift = <8>;
> > > > > - bus-type = <6>;
> > > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > > };
> > > > > };
> > > > > };
> > > > > @@ -335,7 +338,7 @@ port {
> > > > > vin3ep: endpoint {
> > > > > remote-endpoint = <&cam3ep>;
> > > > > bus-width = <8>;
> > > > > - bus-type = <6>;
> > > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > > };
> > > > > };
> > > > > };
> > > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > > > index 40cef0b1d1e6..c73160df619d 100644
> > > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > > > @@ -7,6 +7,8 @@
> > > > > * Copyright (C) 2020 Renesas Electronics Corp.
> > > > > */
> > > > >
> > > > > +#include <dt-bindings/media/video-interfaces.h>
> > >
> > > This .dtsi file is only intended to be included by
> > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts, which already has
> > > the include. Hence if you don't mind, I would like to drop this part
> > > while applying and queuing in renesas-devel for v6.3.
> >
> > Isn't it better to include headers as needed to avoid depending on
> > indirect includes ?
>
> In general, I agree.
> In this particular case, (the multiple inclusions of) the
> r8a7742-iwg21d-q7-dbcm-ov*-single.dtsi files are tied very intimately
> to r8a7742-iwg21d-q7-dbcm-ca.dts.
I'd still prefer keeping the #include here, but you're the maintainer
:-)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros
@ 2023-01-16 10:49 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2023-01-16 10:49 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo, Linux-Renesas
On Mon, Jan 16, 2023 at 11:44:13AM +0100, Geert Uytterhoeven wrote:
> On Mon, Jan 16, 2023 at 11:38 AM Laurent Pinchart wrote:
> > On Mon, Jan 16, 2023 at 11:24:10AM +0100, Geert Uytterhoeven wrote:
> > > On Sat, Jan 14, 2023 at 4:26 PM Laurent Pinchart wrote:
> > > > Geert, could you please take this in your tree for v6.3 ? The two
> > > > patches that the DT changes depend on have been merged in v6.2.
> > >
> > > Thank you, I had missed these.
> > >
> > > > On Thu, Jun 16, 2022 at 01:14:09AM +0300, Laurent Pinchart wrote:
> > > > > Now that a header exists with macros for the media interface bus-type
> > > > > values, replace hardcoding numerical constants with the corresponding
> > > > > macros in the DT sources.
> > > > >
> > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > >
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > >
> > > > > ---
> > > > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++----
> > > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++-
> > > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++-
> > > > > 3 files changed, 13 insertions(+), 6 deletions(-)
> > > > >
> > > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > > > index 4e58c54cde17..33ac4bd1e63b 100644
> > > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > > > @@ -7,6 +7,9 @@
> > > > > */
> > > > >
> > > > > /dts-v1/;
> > > > > +
> > > > > +#include <dt-bindings/media/video-interfaces.h>
> > > > > +
> > > > > #include "r8a7742-iwg21d-q7.dts"
> > > > >
> > > > > / {
> > > > > @@ -242,7 +245,7 @@ port {
> > > > > vin0ep: endpoint {
> > > > > remote-endpoint = <&cam0ep>;
> > > > > bus-width = <8>;
> > > > > - bus-type = <6>;
> > > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > > };
> > > > > };
> > > > > };
> > > > > @@ -273,7 +276,7 @@ port {
> > > > > vin1ep: endpoint {
> > > > > remote-endpoint = <&cam1ep>;
> > > > > bus-width = <8>;
> > > > > - bus-type = <6>;
> > > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > > };
> > > > > };
> > > > > };
> > > > > @@ -305,7 +308,7 @@ vin2ep: endpoint {
> > > > > remote-endpoint = <&cam2ep>;
> > > > > bus-width = <8>;
> > > > > data-shift = <8>;
> > > > > - bus-type = <6>;
> > > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > > };
> > > > > };
> > > > > };
> > > > > @@ -335,7 +338,7 @@ port {
> > > > > vin3ep: endpoint {
> > > > > remote-endpoint = <&cam3ep>;
> > > > > bus-width = <8>;
> > > > > - bus-type = <6>;
> > > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > > };
> > > > > };
> > > > > };
> > > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > > > index 40cef0b1d1e6..c73160df619d 100644
> > > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > > > @@ -7,6 +7,8 @@
> > > > > * Copyright (C) 2020 Renesas Electronics Corp.
> > > > > */
> > > > >
> > > > > +#include <dt-bindings/media/video-interfaces.h>
> > >
> > > This .dtsi file is only intended to be included by
> > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts, which already has
> > > the include. Hence if you don't mind, I would like to drop this part
> > > while applying and queuing in renesas-devel for v6.3.
> >
> > Isn't it better to include headers as needed to avoid depending on
> > indirect includes ?
>
> In general, I agree.
> In this particular case, (the multiple inclusions of) the
> r8a7742-iwg21d-q7-dbcm-ov*-single.dtsi files are tied very intimately
> to r8a7742-iwg21d-q7-dbcm-ca.dts.
I'd still prefer keeping the #include here, but you're the maintainer
:-)
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros
@ 2023-01-16 10:49 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2023-01-16 10:49 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: devicetree, Jacopo Mondi, Maxime Coquelin, Hugues Fruchet,
Alexandre Torgue, dri-devel, Lad Prabhakar, Linux-Renesas,
Rob Herring, Sakari Ailus, Eugen Hristev, Shawn Guo,
linux-arm-kernel, linux-media
On Mon, Jan 16, 2023 at 11:44:13AM +0100, Geert Uytterhoeven wrote:
> On Mon, Jan 16, 2023 at 11:38 AM Laurent Pinchart wrote:
> > On Mon, Jan 16, 2023 at 11:24:10AM +0100, Geert Uytterhoeven wrote:
> > > On Sat, Jan 14, 2023 at 4:26 PM Laurent Pinchart wrote:
> > > > Geert, could you please take this in your tree for v6.3 ? The two
> > > > patches that the DT changes depend on have been merged in v6.2.
> > >
> > > Thank you, I had missed these.
> > >
> > > > On Thu, Jun 16, 2022 at 01:14:09AM +0300, Laurent Pinchart wrote:
> > > > > Now that a header exists with macros for the media interface bus-type
> > > > > values, replace hardcoding numerical constants with the corresponding
> > > > > macros in the DT sources.
> > > > >
> > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > >
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > >
> > > > > ---
> > > > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++----
> > > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++-
> > > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++-
> > > > > 3 files changed, 13 insertions(+), 6 deletions(-)
> > > > >
> > > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > > > index 4e58c54cde17..33ac4bd1e63b 100644
> > > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > > > @@ -7,6 +7,9 @@
> > > > > */
> > > > >
> > > > > /dts-v1/;
> > > > > +
> > > > > +#include <dt-bindings/media/video-interfaces.h>
> > > > > +
> > > > > #include "r8a7742-iwg21d-q7.dts"
> > > > >
> > > > > / {
> > > > > @@ -242,7 +245,7 @@ port {
> > > > > vin0ep: endpoint {
> > > > > remote-endpoint = <&cam0ep>;
> > > > > bus-width = <8>;
> > > > > - bus-type = <6>;
> > > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > > };
> > > > > };
> > > > > };
> > > > > @@ -273,7 +276,7 @@ port {
> > > > > vin1ep: endpoint {
> > > > > remote-endpoint = <&cam1ep>;
> > > > > bus-width = <8>;
> > > > > - bus-type = <6>;
> > > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > > };
> > > > > };
> > > > > };
> > > > > @@ -305,7 +308,7 @@ vin2ep: endpoint {
> > > > > remote-endpoint = <&cam2ep>;
> > > > > bus-width = <8>;
> > > > > data-shift = <8>;
> > > > > - bus-type = <6>;
> > > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > > };
> > > > > };
> > > > > };
> > > > > @@ -335,7 +338,7 @@ port {
> > > > > vin3ep: endpoint {
> > > > > remote-endpoint = <&cam3ep>;
> > > > > bus-width = <8>;
> > > > > - bus-type = <6>;
> > > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > > };
> > > > > };
> > > > > };
> > > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > > > index 40cef0b1d1e6..c73160df619d 100644
> > > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > > > @@ -7,6 +7,8 @@
> > > > > * Copyright (C) 2020 Renesas Electronics Corp.
> > > > > */
> > > > >
> > > > > +#include <dt-bindings/media/video-interfaces.h>
> > >
> > > This .dtsi file is only intended to be included by
> > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts, which already has
> > > the include. Hence if you don't mind, I would like to drop this part
> > > while applying and queuing in renesas-devel for v6.3.
> >
> > Isn't it better to include headers as needed to avoid depending on
> > indirect includes ?
>
> In general, I agree.
> In this particular case, (the multiple inclusions of) the
> r8a7742-iwg21d-q7-dbcm-ov*-single.dtsi files are tied very intimately
> to r8a7742-iwg21d-q7-dbcm-ca.dts.
I'd still prefer keeping the #include here, but you're the maintainer
:-)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros
2023-01-16 10:49 ` Laurent Pinchart
(?)
@ 2023-01-16 11:23 ` Geert Uytterhoeven
-1 siblings, 0 replies; 102+ messages in thread
From: Geert Uytterhoeven @ 2023-01-16 11:23 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo, Linux-Renesas
Hi Laurent,
On Mon, Jan 16, 2023 at 11:49 AM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Mon, Jan 16, 2023 at 11:44:13AM +0100, Geert Uytterhoeven wrote:
> > On Mon, Jan 16, 2023 at 11:38 AM Laurent Pinchart wrote:
> > > On Mon, Jan 16, 2023 at 11:24:10AM +0100, Geert Uytterhoeven wrote:
> > > > On Sat, Jan 14, 2023 at 4:26 PM Laurent Pinchart wrote:
> > > > > Geert, could you please take this in your tree for v6.3 ? The two
> > > > > patches that the DT changes depend on have been merged in v6.2.
> > > >
> > > > Thank you, I had missed these.
> > > >
> > > > > On Thu, Jun 16, 2022 at 01:14:09AM +0300, Laurent Pinchart wrote:
> > > > > > Now that a header exists with macros for the media interface bus-type
> > > > > > values, replace hardcoding numerical constants with the corresponding
> > > > > > macros in the DT sources.
> > > > > >
> > > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > >
> > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > >
> > > > > > ---
> > > > > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++----
> > > > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++-
> > > > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++-
> > > > > > 3 files changed, 13 insertions(+), 6 deletions(-)
> > > > > >
> > > > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > > > > index 4e58c54cde17..33ac4bd1e63b 100644
> > > > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > > > > @@ -7,6 +7,9 @@
> > > > > > */
> > > > > >
> > > > > > /dts-v1/;
> > > > > > +
> > > > > > +#include <dt-bindings/media/video-interfaces.h>
> > > > > > +
> > > > > > #include "r8a7742-iwg21d-q7.dts"
> > > > > >
> > > > > > / {
> > > > > > @@ -242,7 +245,7 @@ port {
> > > > > > vin0ep: endpoint {
> > > > > > remote-endpoint = <&cam0ep>;
> > > > > > bus-width = <8>;
> > > > > > - bus-type = <6>;
> > > > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > > > };
> > > > > > };
> > > > > > };
> > > > > > @@ -273,7 +276,7 @@ port {
> > > > > > vin1ep: endpoint {
> > > > > > remote-endpoint = <&cam1ep>;
> > > > > > bus-width = <8>;
> > > > > > - bus-type = <6>;
> > > > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > > > };
> > > > > > };
> > > > > > };
> > > > > > @@ -305,7 +308,7 @@ vin2ep: endpoint {
> > > > > > remote-endpoint = <&cam2ep>;
> > > > > > bus-width = <8>;
> > > > > > data-shift = <8>;
> > > > > > - bus-type = <6>;
> > > > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > > > };
> > > > > > };
> > > > > > };
> > > > > > @@ -335,7 +338,7 @@ port {
> > > > > > vin3ep: endpoint {
> > > > > > remote-endpoint = <&cam3ep>;
> > > > > > bus-width = <8>;
> > > > > > - bus-type = <6>;
> > > > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > > > };
> > > > > > };
> > > > > > };
> > > > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > > > > index 40cef0b1d1e6..c73160df619d 100644
> > > > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > > > > @@ -7,6 +7,8 @@
> > > > > > * Copyright (C) 2020 Renesas Electronics Corp.
> > > > > > */
> > > > > >
> > > > > > +#include <dt-bindings/media/video-interfaces.h>
> > > >
> > > > This .dtsi file is only intended to be included by
> > > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts, which already has
> > > > the include. Hence if you don't mind, I would like to drop this part
> > > > while applying and queuing in renesas-devel for v6.3.
> > >
> > > Isn't it better to include headers as needed to avoid depending on
> > > indirect includes ?
> >
> > In general, I agree.
> > In this particular case, (the multiple inclusions of) the
> > r8a7742-iwg21d-q7-dbcm-ov*-single.dtsi files are tied very intimately
> > to r8a7742-iwg21d-q7-dbcm-ca.dts.
>
> I'd still prefer keeping the #include here, but you're the maintainer
> :-)
OK, will keep them.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros
@ 2023-01-16 11:23 ` Geert Uytterhoeven
0 siblings, 0 replies; 102+ messages in thread
From: Geert Uytterhoeven @ 2023-01-16 11:23 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo, Linux-Renesas
Hi Laurent,
On Mon, Jan 16, 2023 at 11:49 AM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Mon, Jan 16, 2023 at 11:44:13AM +0100, Geert Uytterhoeven wrote:
> > On Mon, Jan 16, 2023 at 11:38 AM Laurent Pinchart wrote:
> > > On Mon, Jan 16, 2023 at 11:24:10AM +0100, Geert Uytterhoeven wrote:
> > > > On Sat, Jan 14, 2023 at 4:26 PM Laurent Pinchart wrote:
> > > > > Geert, could you please take this in your tree for v6.3 ? The two
> > > > > patches that the DT changes depend on have been merged in v6.2.
> > > >
> > > > Thank you, I had missed these.
> > > >
> > > > > On Thu, Jun 16, 2022 at 01:14:09AM +0300, Laurent Pinchart wrote:
> > > > > > Now that a header exists with macros for the media interface bus-type
> > > > > > values, replace hardcoding numerical constants with the corresponding
> > > > > > macros in the DT sources.
> > > > > >
> > > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > >
> > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > >
> > > > > > ---
> > > > > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++----
> > > > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++-
> > > > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++-
> > > > > > 3 files changed, 13 insertions(+), 6 deletions(-)
> > > > > >
> > > > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > > > > index 4e58c54cde17..33ac4bd1e63b 100644
> > > > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > > > > @@ -7,6 +7,9 @@
> > > > > > */
> > > > > >
> > > > > > /dts-v1/;
> > > > > > +
> > > > > > +#include <dt-bindings/media/video-interfaces.h>
> > > > > > +
> > > > > > #include "r8a7742-iwg21d-q7.dts"
> > > > > >
> > > > > > / {
> > > > > > @@ -242,7 +245,7 @@ port {
> > > > > > vin0ep: endpoint {
> > > > > > remote-endpoint = <&cam0ep>;
> > > > > > bus-width = <8>;
> > > > > > - bus-type = <6>;
> > > > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > > > };
> > > > > > };
> > > > > > };
> > > > > > @@ -273,7 +276,7 @@ port {
> > > > > > vin1ep: endpoint {
> > > > > > remote-endpoint = <&cam1ep>;
> > > > > > bus-width = <8>;
> > > > > > - bus-type = <6>;
> > > > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > > > };
> > > > > > };
> > > > > > };
> > > > > > @@ -305,7 +308,7 @@ vin2ep: endpoint {
> > > > > > remote-endpoint = <&cam2ep>;
> > > > > > bus-width = <8>;
> > > > > > data-shift = <8>;
> > > > > > - bus-type = <6>;
> > > > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > > > };
> > > > > > };
> > > > > > };
> > > > > > @@ -335,7 +338,7 @@ port {
> > > > > > vin3ep: endpoint {
> > > > > > remote-endpoint = <&cam3ep>;
> > > > > > bus-width = <8>;
> > > > > > - bus-type = <6>;
> > > > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > > > };
> > > > > > };
> > > > > > };
> > > > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > > > > index 40cef0b1d1e6..c73160df619d 100644
> > > > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > > > > @@ -7,6 +7,8 @@
> > > > > > * Copyright (C) 2020 Renesas Electronics Corp.
> > > > > > */
> > > > > >
> > > > > > +#include <dt-bindings/media/video-interfaces.h>
> > > >
> > > > This .dtsi file is only intended to be included by
> > > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts, which already has
> > > > the include. Hence if you don't mind, I would like to drop this part
> > > > while applying and queuing in renesas-devel for v6.3.
> > >
> > > Isn't it better to include headers as needed to avoid depending on
> > > indirect includes ?
> >
> > In general, I agree.
> > In this particular case, (the multiple inclusions of) the
> > r8a7742-iwg21d-q7-dbcm-ov*-single.dtsi files are tied very intimately
> > to r8a7742-iwg21d-q7-dbcm-ca.dts.
>
> I'd still prefer keeping the #include here, but you're the maintainer
> :-)
OK, will keep them.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 5/6] ARM: dts: renesas: Use new media bus type macros
@ 2023-01-16 11:23 ` Geert Uytterhoeven
0 siblings, 0 replies; 102+ messages in thread
From: Geert Uytterhoeven @ 2023-01-16 11:23 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, Jacopo Mondi, Maxime Coquelin, Hugues Fruchet,
Alexandre Torgue, dri-devel, Lad Prabhakar, Linux-Renesas,
Rob Herring, Sakari Ailus, Eugen Hristev, Shawn Guo,
linux-arm-kernel, linux-media
Hi Laurent,
On Mon, Jan 16, 2023 at 11:49 AM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Mon, Jan 16, 2023 at 11:44:13AM +0100, Geert Uytterhoeven wrote:
> > On Mon, Jan 16, 2023 at 11:38 AM Laurent Pinchart wrote:
> > > On Mon, Jan 16, 2023 at 11:24:10AM +0100, Geert Uytterhoeven wrote:
> > > > On Sat, Jan 14, 2023 at 4:26 PM Laurent Pinchart wrote:
> > > > > Geert, could you please take this in your tree for v6.3 ? The two
> > > > > patches that the DT changes depend on have been merged in v6.2.
> > > >
> > > > Thank you, I had missed these.
> > > >
> > > > > On Thu, Jun 16, 2022 at 01:14:09AM +0300, Laurent Pinchart wrote:
> > > > > > Now that a header exists with macros for the media interface bus-type
> > > > > > values, replace hardcoding numerical constants with the corresponding
> > > > > > macros in the DT sources.
> > > > > >
> > > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > >
> > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > >
> > > > > > ---
> > > > > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 11 +++++++----
> > > > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi | 4 +++-
> > > > > > .../dts/r8a7742-iwg21d-q7-dbcm-ov7725-single.dtsi | 4 +++-
> > > > > > 3 files changed, 13 insertions(+), 6 deletions(-)
> > > > > >
> > > > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > > > > index 4e58c54cde17..33ac4bd1e63b 100644
> > > > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > > > > > @@ -7,6 +7,9 @@
> > > > > > */
> > > > > >
> > > > > > /dts-v1/;
> > > > > > +
> > > > > > +#include <dt-bindings/media/video-interfaces.h>
> > > > > > +
> > > > > > #include "r8a7742-iwg21d-q7.dts"
> > > > > >
> > > > > > / {
> > > > > > @@ -242,7 +245,7 @@ port {
> > > > > > vin0ep: endpoint {
> > > > > > remote-endpoint = <&cam0ep>;
> > > > > > bus-width = <8>;
> > > > > > - bus-type = <6>;
> > > > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > > > };
> > > > > > };
> > > > > > };
> > > > > > @@ -273,7 +276,7 @@ port {
> > > > > > vin1ep: endpoint {
> > > > > > remote-endpoint = <&cam1ep>;
> > > > > > bus-width = <8>;
> > > > > > - bus-type = <6>;
> > > > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > > > };
> > > > > > };
> > > > > > };
> > > > > > @@ -305,7 +308,7 @@ vin2ep: endpoint {
> > > > > > remote-endpoint = <&cam2ep>;
> > > > > > bus-width = <8>;
> > > > > > data-shift = <8>;
> > > > > > - bus-type = <6>;
> > > > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > > > };
> > > > > > };
> > > > > > };
> > > > > > @@ -335,7 +338,7 @@ port {
> > > > > > vin3ep: endpoint {
> > > > > > remote-endpoint = <&cam3ep>;
> > > > > > bus-width = <8>;
> > > > > > - bus-type = <6>;
> > > > > > + bus-type = <MEDIA_BUS_TYPE_BT656>;
> > > > > > };
> > > > > > };
> > > > > > };
> > > > > > diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > > > > index 40cef0b1d1e6..c73160df619d 100644
> > > > > > --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ov5640-single.dtsi
> > > > > > @@ -7,6 +7,8 @@
> > > > > > * Copyright (C) 2020 Renesas Electronics Corp.
> > > > > > */
> > > > > >
> > > > > > +#include <dt-bindings/media/video-interfaces.h>
> > > >
> > > > This .dtsi file is only intended to be included by
> > > > arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts, which already has
> > > > the include. Hence if you don't mind, I would like to drop this part
> > > > while applying and queuing in renesas-devel for v6.3.
> > >
> > > Isn't it better to include headers as needed to avoid depending on
> > > indirect includes ?
> >
> > In general, I agree.
> > In this particular case, (the multiple inclusions of) the
> > r8a7742-iwg21d-q7-dbcm-ov*-single.dtsi files are tied very intimately
> > to r8a7742-iwg21d-q7-dbcm-ca.dts.
>
> I'd still prefer keeping the #include here, but you're the maintainer
> :-)
OK, will keep them.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 102+ messages in thread
* [PATCH v3 6/6] ARM: dts: stm32: Use new media bus type macros
2022-06-15 22:14 ` Laurent Pinchart
(?)
@ 2022-06-15 22:14 ` Laurent Pinchart
-1 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-06-15 22:14 UTC (permalink / raw)
To: devicetree, linux-media, dri-devel
Cc: linux-arm-kernel, Rob Herring, Sakari Ailus, Jacopo Mondi,
Eugen Hristev, Hugues Fruchet, Maxime Coquelin, Alexandre Torgue,
Lad Prabhakar, Fabio Estevam, Shawn Guo
Now that a header exists with macros for the media interface bus-type
values, replace hardcoding numerical constants with the corresponding
macros in the DT sources.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/stm32429i-eval.dts | 3 ++-
arch/arm/boot/dts/stm32mp157c-ev1.dts | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/stm32429i-eval.dts b/arch/arm/boot/dts/stm32429i-eval.dts
index 0d98aca01736..5fae11e6607b 100644
--- a/arch/arm/boot/dts/stm32429i-eval.dts
+++ b/arch/arm/boot/dts/stm32429i-eval.dts
@@ -50,6 +50,7 @@
#include "stm32f429-pinctrl.dtsi"
#include <dt-bindings/input/input.h>
#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/media/video-interfaces.h>
/ {
model = "STMicroelectronics STM32429i-EVAL board";
@@ -186,7 +187,7 @@ &dcmi {
port {
dcmi_0: endpoint {
remote-endpoint = <&ov2640_0>;
- bus-type = <5>;
+ bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
bus-width = <8>;
hsync-active = <0>;
vsync-active = <0>;
diff --git a/arch/arm/boot/dts/stm32mp157c-ev1.dts b/arch/arm/boot/dts/stm32mp157c-ev1.dts
index d142dd30e16b..306d41a6138f 100644
--- a/arch/arm/boot/dts/stm32mp157c-ev1.dts
+++ b/arch/arm/boot/dts/stm32mp157c-ev1.dts
@@ -8,6 +8,7 @@
#include "stm32mp157c-ed1.dts"
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/input/input.h>
+#include <dt-bindings/media/video-interfaces.h>
/ {
model = "STMicroelectronics STM32MP157C eval daughter on eval mother";
@@ -90,7 +91,7 @@ &dcmi {
port {
dcmi_0: endpoint {
remote-endpoint = <&ov5640_0>;
- bus-type = <5>;
+ bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
bus-width = <8>;
hsync-active = <0>;
vsync-active = <0>;
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 102+ messages in thread* [PATCH v3 6/6] ARM: dts: stm32: Use new media bus type macros
@ 2022-06-15 22:14 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-06-15 22:14 UTC (permalink / raw)
To: devicetree, linux-media, dri-devel
Cc: linux-arm-kernel, Rob Herring, Sakari Ailus, Jacopo Mondi,
Eugen Hristev, Hugues Fruchet, Maxime Coquelin, Alexandre Torgue,
Lad Prabhakar, Fabio Estevam, Shawn Guo
Now that a header exists with macros for the media interface bus-type
values, replace hardcoding numerical constants with the corresponding
macros in the DT sources.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/stm32429i-eval.dts | 3 ++-
arch/arm/boot/dts/stm32mp157c-ev1.dts | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/stm32429i-eval.dts b/arch/arm/boot/dts/stm32429i-eval.dts
index 0d98aca01736..5fae11e6607b 100644
--- a/arch/arm/boot/dts/stm32429i-eval.dts
+++ b/arch/arm/boot/dts/stm32429i-eval.dts
@@ -50,6 +50,7 @@
#include "stm32f429-pinctrl.dtsi"
#include <dt-bindings/input/input.h>
#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/media/video-interfaces.h>
/ {
model = "STMicroelectronics STM32429i-EVAL board";
@@ -186,7 +187,7 @@ &dcmi {
port {
dcmi_0: endpoint {
remote-endpoint = <&ov2640_0>;
- bus-type = <5>;
+ bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
bus-width = <8>;
hsync-active = <0>;
vsync-active = <0>;
diff --git a/arch/arm/boot/dts/stm32mp157c-ev1.dts b/arch/arm/boot/dts/stm32mp157c-ev1.dts
index d142dd30e16b..306d41a6138f 100644
--- a/arch/arm/boot/dts/stm32mp157c-ev1.dts
+++ b/arch/arm/boot/dts/stm32mp157c-ev1.dts
@@ -8,6 +8,7 @@
#include "stm32mp157c-ed1.dts"
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/input/input.h>
+#include <dt-bindings/media/video-interfaces.h>
/ {
model = "STMicroelectronics STM32MP157C eval daughter on eval mother";
@@ -90,7 +91,7 @@ &dcmi {
port {
dcmi_0: endpoint {
remote-endpoint = <&ov5640_0>;
- bus-type = <5>;
+ bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
bus-width = <8>;
hsync-active = <0>;
vsync-active = <0>;
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 102+ messages in thread* [PATCH v3 6/6] ARM: dts: stm32: Use new media bus type macros
@ 2022-06-15 22:14 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-06-15 22:14 UTC (permalink / raw)
To: devicetree, linux-media, dri-devel
Cc: Jacopo Mondi, Maxime Coquelin, Hugues Fruchet, Alexandre Torgue,
Shawn Guo, Lad Prabhakar, Rob Herring, Sakari Ailus,
Eugen Hristev, linux-arm-kernel
Now that a header exists with macros for the media interface bus-type
values, replace hardcoding numerical constants with the corresponding
macros in the DT sources.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
arch/arm/boot/dts/stm32429i-eval.dts | 3 ++-
arch/arm/boot/dts/stm32mp157c-ev1.dts | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/stm32429i-eval.dts b/arch/arm/boot/dts/stm32429i-eval.dts
index 0d98aca01736..5fae11e6607b 100644
--- a/arch/arm/boot/dts/stm32429i-eval.dts
+++ b/arch/arm/boot/dts/stm32429i-eval.dts
@@ -50,6 +50,7 @@
#include "stm32f429-pinctrl.dtsi"
#include <dt-bindings/input/input.h>
#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/media/video-interfaces.h>
/ {
model = "STMicroelectronics STM32429i-EVAL board";
@@ -186,7 +187,7 @@ &dcmi {
port {
dcmi_0: endpoint {
remote-endpoint = <&ov2640_0>;
- bus-type = <5>;
+ bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
bus-width = <8>;
hsync-active = <0>;
vsync-active = <0>;
diff --git a/arch/arm/boot/dts/stm32mp157c-ev1.dts b/arch/arm/boot/dts/stm32mp157c-ev1.dts
index d142dd30e16b..306d41a6138f 100644
--- a/arch/arm/boot/dts/stm32mp157c-ev1.dts
+++ b/arch/arm/boot/dts/stm32mp157c-ev1.dts
@@ -8,6 +8,7 @@
#include "stm32mp157c-ed1.dts"
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/input/input.h>
+#include <dt-bindings/media/video-interfaces.h>
/ {
model = "STMicroelectronics STM32MP157C eval daughter on eval mother";
@@ -90,7 +91,7 @@ &dcmi {
port {
dcmi_0: endpoint {
remote-endpoint = <&ov5640_0>;
- bus-type = <5>;
+ bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
bus-width = <8>;
hsync-active = <0>;
vsync-active = <0>;
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 102+ messages in thread* Re: [PATCH v3 6/6] ARM: dts: stm32: Use new media bus type macros
2022-06-15 22:14 ` Laurent Pinchart
(?)
@ 2023-01-14 15:36 ` Laurent Pinchart
-1 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2023-01-14 15:36 UTC (permalink / raw)
To: Hugues Fruchet, Maxime Coquelin, Alexandre Torgue
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Lad Prabhakar, Fabio Estevam, Shawn Guo
Hugues, Maxime, Alexandre, could one of you take this patch in your tree
for v6.3 ? The two patches that it depends on have both been merged in
v6.2.
On Thu, Jun 16, 2022 at 01:14:10AM +0300, Laurent Pinchart wrote:
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/boot/dts/stm32429i-eval.dts | 3 ++-
> arch/arm/boot/dts/stm32mp157c-ev1.dts | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stm32429i-eval.dts b/arch/arm/boot/dts/stm32429i-eval.dts
> index 0d98aca01736..5fae11e6607b 100644
> --- a/arch/arm/boot/dts/stm32429i-eval.dts
> +++ b/arch/arm/boot/dts/stm32429i-eval.dts
> @@ -50,6 +50,7 @@
> #include "stm32f429-pinctrl.dtsi"
> #include <dt-bindings/input/input.h>
> #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/media/video-interfaces.h>
>
> / {
> model = "STMicroelectronics STM32429i-EVAL board";
> @@ -186,7 +187,7 @@ &dcmi {
> port {
> dcmi_0: endpoint {
> remote-endpoint = <&ov2640_0>;
> - bus-type = <5>;
> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> bus-width = <8>;
> hsync-active = <0>;
> vsync-active = <0>;
> diff --git a/arch/arm/boot/dts/stm32mp157c-ev1.dts b/arch/arm/boot/dts/stm32mp157c-ev1.dts
> index d142dd30e16b..306d41a6138f 100644
> --- a/arch/arm/boot/dts/stm32mp157c-ev1.dts
> +++ b/arch/arm/boot/dts/stm32mp157c-ev1.dts
> @@ -8,6 +8,7 @@
> #include "stm32mp157c-ed1.dts"
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/input/input.h>
> +#include <dt-bindings/media/video-interfaces.h>
>
> / {
> model = "STMicroelectronics STM32MP157C eval daughter on eval mother";
> @@ -90,7 +91,7 @@ &dcmi {
> port {
> dcmi_0: endpoint {
> remote-endpoint = <&ov5640_0>;
> - bus-type = <5>;
> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> bus-width = <8>;
> hsync-active = <0>;
> vsync-active = <0>;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 6/6] ARM: dts: stm32: Use new media bus type macros
@ 2023-01-14 15:36 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2023-01-14 15:36 UTC (permalink / raw)
To: Hugues Fruchet, Maxime Coquelin, Alexandre Torgue
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Lad Prabhakar, Fabio Estevam, Shawn Guo
Hugues, Maxime, Alexandre, could one of you take this patch in your tree
for v6.3 ? The two patches that it depends on have both been merged in
v6.2.
On Thu, Jun 16, 2022 at 01:14:10AM +0300, Laurent Pinchart wrote:
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/boot/dts/stm32429i-eval.dts | 3 ++-
> arch/arm/boot/dts/stm32mp157c-ev1.dts | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stm32429i-eval.dts b/arch/arm/boot/dts/stm32429i-eval.dts
> index 0d98aca01736..5fae11e6607b 100644
> --- a/arch/arm/boot/dts/stm32429i-eval.dts
> +++ b/arch/arm/boot/dts/stm32429i-eval.dts
> @@ -50,6 +50,7 @@
> #include "stm32f429-pinctrl.dtsi"
> #include <dt-bindings/input/input.h>
> #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/media/video-interfaces.h>
>
> / {
> model = "STMicroelectronics STM32429i-EVAL board";
> @@ -186,7 +187,7 @@ &dcmi {
> port {
> dcmi_0: endpoint {
> remote-endpoint = <&ov2640_0>;
> - bus-type = <5>;
> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> bus-width = <8>;
> hsync-active = <0>;
> vsync-active = <0>;
> diff --git a/arch/arm/boot/dts/stm32mp157c-ev1.dts b/arch/arm/boot/dts/stm32mp157c-ev1.dts
> index d142dd30e16b..306d41a6138f 100644
> --- a/arch/arm/boot/dts/stm32mp157c-ev1.dts
> +++ b/arch/arm/boot/dts/stm32mp157c-ev1.dts
> @@ -8,6 +8,7 @@
> #include "stm32mp157c-ed1.dts"
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/input/input.h>
> +#include <dt-bindings/media/video-interfaces.h>
>
> / {
> model = "STMicroelectronics STM32MP157C eval daughter on eval mother";
> @@ -90,7 +91,7 @@ &dcmi {
> port {
> dcmi_0: endpoint {
> remote-endpoint = <&ov5640_0>;
> - bus-type = <5>;
> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> bus-width = <8>;
> hsync-active = <0>;
> vsync-active = <0>;
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 6/6] ARM: dts: stm32: Use new media bus type macros
@ 2023-01-14 15:36 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2023-01-14 15:36 UTC (permalink / raw)
To: Hugues Fruchet, Maxime Coquelin, Alexandre Torgue
Cc: devicetree, Jacopo Mondi, Shawn Guo, Lad Prabhakar, dri-devel,
Rob Herring, Sakari Ailus, Eugen Hristev, linux-arm-kernel,
linux-media
Hugues, Maxime, Alexandre, could one of you take this patch in your tree
for v6.3 ? The two patches that it depends on have both been merged in
v6.2.
On Thu, Jun 16, 2022 at 01:14:10AM +0300, Laurent Pinchart wrote:
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/boot/dts/stm32429i-eval.dts | 3 ++-
> arch/arm/boot/dts/stm32mp157c-ev1.dts | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stm32429i-eval.dts b/arch/arm/boot/dts/stm32429i-eval.dts
> index 0d98aca01736..5fae11e6607b 100644
> --- a/arch/arm/boot/dts/stm32429i-eval.dts
> +++ b/arch/arm/boot/dts/stm32429i-eval.dts
> @@ -50,6 +50,7 @@
> #include "stm32f429-pinctrl.dtsi"
> #include <dt-bindings/input/input.h>
> #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/media/video-interfaces.h>
>
> / {
> model = "STMicroelectronics STM32429i-EVAL board";
> @@ -186,7 +187,7 @@ &dcmi {
> port {
> dcmi_0: endpoint {
> remote-endpoint = <&ov2640_0>;
> - bus-type = <5>;
> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> bus-width = <8>;
> hsync-active = <0>;
> vsync-active = <0>;
> diff --git a/arch/arm/boot/dts/stm32mp157c-ev1.dts b/arch/arm/boot/dts/stm32mp157c-ev1.dts
> index d142dd30e16b..306d41a6138f 100644
> --- a/arch/arm/boot/dts/stm32mp157c-ev1.dts
> +++ b/arch/arm/boot/dts/stm32mp157c-ev1.dts
> @@ -8,6 +8,7 @@
> #include "stm32mp157c-ed1.dts"
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/input/input.h>
> +#include <dt-bindings/media/video-interfaces.h>
>
> / {
> model = "STMicroelectronics STM32MP157C eval daughter on eval mother";
> @@ -90,7 +91,7 @@ &dcmi {
> port {
> dcmi_0: endpoint {
> remote-endpoint = <&ov5640_0>;
> - bus-type = <5>;
> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> bus-width = <8>;
> hsync-active = <0>;
> vsync-active = <0>;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 6/6] ARM: dts: stm32: Use new media bus type macros
2023-01-14 15:36 ` Laurent Pinchart
(?)
@ 2023-01-17 10:44 ` Alexandre TORGUE
-1 siblings, 0 replies; 102+ messages in thread
From: Alexandre TORGUE @ 2023-01-17 10:44 UTC (permalink / raw)
To: Laurent Pinchart, Hugues Fruchet, Maxime Coquelin
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Lad Prabhakar, Fabio Estevam, Shawn Guo
Hi Laurent
On 1/14/23 16:36, Laurent Pinchart wrote:
> Hugues, Maxime, Alexandre, could one of you take this patch in your tree
> for v6.3 ? The two patches that it depends on have both been merged in
> v6.2.
Yes sure.
Cheers
Alex
>
> On Thu, Jun 16, 2022 at 01:14:10AM +0300, Laurent Pinchart wrote:
>> Now that a header exists with macros for the media interface bus-type
>> values, replace hardcoding numerical constants with the corresponding
>> macros in the DT sources.
>>
>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> ---
>> arch/arm/boot/dts/stm32429i-eval.dts | 3 ++-
>> arch/arm/boot/dts/stm32mp157c-ev1.dts | 3 ++-
>> 2 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/stm32429i-eval.dts b/arch/arm/boot/dts/stm32429i-eval.dts
>> index 0d98aca01736..5fae11e6607b 100644
>> --- a/arch/arm/boot/dts/stm32429i-eval.dts
>> +++ b/arch/arm/boot/dts/stm32429i-eval.dts
>> @@ -50,6 +50,7 @@
>> #include "stm32f429-pinctrl.dtsi"
>> #include <dt-bindings/input/input.h>
>> #include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/media/video-interfaces.h>
>>
>> / {
>> model = "STMicroelectronics STM32429i-EVAL board";
>> @@ -186,7 +187,7 @@ &dcmi {
>> port {
>> dcmi_0: endpoint {
>> remote-endpoint = <&ov2640_0>;
>> - bus-type = <5>;
>> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
>> bus-width = <8>;
>> hsync-active = <0>;
>> vsync-active = <0>;
>> diff --git a/arch/arm/boot/dts/stm32mp157c-ev1.dts b/arch/arm/boot/dts/stm32mp157c-ev1.dts
>> index d142dd30e16b..306d41a6138f 100644
>> --- a/arch/arm/boot/dts/stm32mp157c-ev1.dts
>> +++ b/arch/arm/boot/dts/stm32mp157c-ev1.dts
>> @@ -8,6 +8,7 @@
>> #include "stm32mp157c-ed1.dts"
>> #include <dt-bindings/gpio/gpio.h>
>> #include <dt-bindings/input/input.h>
>> +#include <dt-bindings/media/video-interfaces.h>
>>
>> / {
>> model = "STMicroelectronics STM32MP157C eval daughter on eval mother";
>> @@ -90,7 +91,7 @@ &dcmi {
>> port {
>> dcmi_0: endpoint {
>> remote-endpoint = <&ov5640_0>;
>> - bus-type = <5>;
>> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
>> bus-width = <8>;
>> hsync-active = <0>;
>> vsync-active = <0>;
>
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 6/6] ARM: dts: stm32: Use new media bus type macros
@ 2023-01-17 10:44 ` Alexandre TORGUE
0 siblings, 0 replies; 102+ messages in thread
From: Alexandre TORGUE @ 2023-01-17 10:44 UTC (permalink / raw)
To: Laurent Pinchart, Hugues Fruchet, Maxime Coquelin
Cc: devicetree, Jacopo Mondi, Shawn Guo, Lad Prabhakar, dri-devel,
Rob Herring, Sakari Ailus, Eugen Hristev, linux-arm-kernel,
linux-media
Hi Laurent
On 1/14/23 16:36, Laurent Pinchart wrote:
> Hugues, Maxime, Alexandre, could one of you take this patch in your tree
> for v6.3 ? The two patches that it depends on have both been merged in
> v6.2.
Yes sure.
Cheers
Alex
>
> On Thu, Jun 16, 2022 at 01:14:10AM +0300, Laurent Pinchart wrote:
>> Now that a header exists with macros for the media interface bus-type
>> values, replace hardcoding numerical constants with the corresponding
>> macros in the DT sources.
>>
>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> ---
>> arch/arm/boot/dts/stm32429i-eval.dts | 3 ++-
>> arch/arm/boot/dts/stm32mp157c-ev1.dts | 3 ++-
>> 2 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/stm32429i-eval.dts b/arch/arm/boot/dts/stm32429i-eval.dts
>> index 0d98aca01736..5fae11e6607b 100644
>> --- a/arch/arm/boot/dts/stm32429i-eval.dts
>> +++ b/arch/arm/boot/dts/stm32429i-eval.dts
>> @@ -50,6 +50,7 @@
>> #include "stm32f429-pinctrl.dtsi"
>> #include <dt-bindings/input/input.h>
>> #include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/media/video-interfaces.h>
>>
>> / {
>> model = "STMicroelectronics STM32429i-EVAL board";
>> @@ -186,7 +187,7 @@ &dcmi {
>> port {
>> dcmi_0: endpoint {
>> remote-endpoint = <&ov2640_0>;
>> - bus-type = <5>;
>> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
>> bus-width = <8>;
>> hsync-active = <0>;
>> vsync-active = <0>;
>> diff --git a/arch/arm/boot/dts/stm32mp157c-ev1.dts b/arch/arm/boot/dts/stm32mp157c-ev1.dts
>> index d142dd30e16b..306d41a6138f 100644
>> --- a/arch/arm/boot/dts/stm32mp157c-ev1.dts
>> +++ b/arch/arm/boot/dts/stm32mp157c-ev1.dts
>> @@ -8,6 +8,7 @@
>> #include "stm32mp157c-ed1.dts"
>> #include <dt-bindings/gpio/gpio.h>
>> #include <dt-bindings/input/input.h>
>> +#include <dt-bindings/media/video-interfaces.h>
>>
>> / {
>> model = "STMicroelectronics STM32MP157C eval daughter on eval mother";
>> @@ -90,7 +91,7 @@ &dcmi {
>> port {
>> dcmi_0: endpoint {
>> remote-endpoint = <&ov5640_0>;
>> - bus-type = <5>;
>> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
>> bus-width = <8>;
>> hsync-active = <0>;
>> vsync-active = <0>;
>
^ permalink raw reply [flat|nested] 102+ messages in thread* Re: [PATCH v3 6/6] ARM: dts: stm32: Use new media bus type macros
@ 2023-01-17 10:44 ` Alexandre TORGUE
0 siblings, 0 replies; 102+ messages in thread
From: Alexandre TORGUE @ 2023-01-17 10:44 UTC (permalink / raw)
To: Laurent Pinchart, Hugues Fruchet, Maxime Coquelin
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Sakari Ailus, Jacopo Mondi, Eugen Hristev,
Lad Prabhakar, Fabio Estevam, Shawn Guo
Hi Laurent
On 1/14/23 16:36, Laurent Pinchart wrote:
> Hugues, Maxime, Alexandre, could one of you take this patch in your tree
> for v6.3 ? The two patches that it depends on have both been merged in
> v6.2.
Yes sure.
Cheers
Alex
>
> On Thu, Jun 16, 2022 at 01:14:10AM +0300, Laurent Pinchart wrote:
>> Now that a header exists with macros for the media interface bus-type
>> values, replace hardcoding numerical constants with the corresponding
>> macros in the DT sources.
>>
>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> ---
>> arch/arm/boot/dts/stm32429i-eval.dts | 3 ++-
>> arch/arm/boot/dts/stm32mp157c-ev1.dts | 3 ++-
>> 2 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/stm32429i-eval.dts b/arch/arm/boot/dts/stm32429i-eval.dts
>> index 0d98aca01736..5fae11e6607b 100644
>> --- a/arch/arm/boot/dts/stm32429i-eval.dts
>> +++ b/arch/arm/boot/dts/stm32429i-eval.dts
>> @@ -50,6 +50,7 @@
>> #include "stm32f429-pinctrl.dtsi"
>> #include <dt-bindings/input/input.h>
>> #include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/media/video-interfaces.h>
>>
>> / {
>> model = "STMicroelectronics STM32429i-EVAL board";
>> @@ -186,7 +187,7 @@ &dcmi {
>> port {
>> dcmi_0: endpoint {
>> remote-endpoint = <&ov2640_0>;
>> - bus-type = <5>;
>> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
>> bus-width = <8>;
>> hsync-active = <0>;
>> vsync-active = <0>;
>> diff --git a/arch/arm/boot/dts/stm32mp157c-ev1.dts b/arch/arm/boot/dts/stm32mp157c-ev1.dts
>> index d142dd30e16b..306d41a6138f 100644
>> --- a/arch/arm/boot/dts/stm32mp157c-ev1.dts
>> +++ b/arch/arm/boot/dts/stm32mp157c-ev1.dts
>> @@ -8,6 +8,7 @@
>> #include "stm32mp157c-ed1.dts"
>> #include <dt-bindings/gpio/gpio.h>
>> #include <dt-bindings/input/input.h>
>> +#include <dt-bindings/media/video-interfaces.h>
>>
>> / {
>> model = "STMicroelectronics STM32MP157C eval daughter on eval mother";
>> @@ -90,7 +91,7 @@ &dcmi {
>> port {
>> dcmi_0: endpoint {
>> remote-endpoint = <&ov5640_0>;
>> - bus-type = <5>;
>> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
>> bus-width = <8>;
>> hsync-active = <0>;
>> vsync-active = <0>;
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 6/6] ARM: dts: stm32: Use new media bus type macros
2022-06-15 22:14 ` Laurent Pinchart
(?)
@ 2023-01-17 11:24 ` Alexandre TORGUE
-1 siblings, 0 replies; 102+ messages in thread
From: Alexandre TORGUE @ 2023-01-17 11:24 UTC (permalink / raw)
To: Laurent Pinchart, devicetree, linux-media, dri-devel
Cc: linux-arm-kernel, Rob Herring, Sakari Ailus, Jacopo Mondi,
Eugen Hristev, Hugues Fruchet, Maxime Coquelin, Lad Prabhakar,
Fabio Estevam, Shawn Guo
Hi Laurent
On 6/16/22 00:14, Laurent Pinchart wrote:
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Applied on stm32-next.
Thanks.
Alex
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 6/6] ARM: dts: stm32: Use new media bus type macros
@ 2023-01-17 11:24 ` Alexandre TORGUE
0 siblings, 0 replies; 102+ messages in thread
From: Alexandre TORGUE @ 2023-01-17 11:24 UTC (permalink / raw)
To: Laurent Pinchart, devicetree, linux-media, dri-devel
Cc: Jacopo Mondi, Maxime Coquelin, Hugues Fruchet, Lad Prabhakar,
Shawn Guo, Rob Herring, Sakari Ailus, Eugen Hristev,
linux-arm-kernel
Hi Laurent
On 6/16/22 00:14, Laurent Pinchart wrote:
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Applied on stm32-next.
Thanks.
Alex
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 6/6] ARM: dts: stm32: Use new media bus type macros
@ 2023-01-17 11:24 ` Alexandre TORGUE
0 siblings, 0 replies; 102+ messages in thread
From: Alexandre TORGUE @ 2023-01-17 11:24 UTC (permalink / raw)
To: Laurent Pinchart, devicetree, linux-media, dri-devel
Cc: linux-arm-kernel, Rob Herring, Sakari Ailus, Jacopo Mondi,
Eugen Hristev, Hugues Fruchet, Maxime Coquelin, Lad Prabhakar,
Fabio Estevam, Shawn Guo
Hi Laurent
On 6/16/22 00:14, Laurent Pinchart wrote:
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT sources.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Applied on stm32-next.
Thanks.
Alex
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types
2022-06-15 22:14 ` Laurent Pinchart
(?)
@ 2022-07-17 6:54 ` Sakari Ailus
-1 siblings, 0 replies; 102+ messages in thread
From: Sakari Ailus @ 2022-07-17 6:54 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Jacopo Mondi, Eugen Hristev, Hugues Fruchet,
Maxime Coquelin, Alexandre Torgue, Lad Prabhakar, Fabio Estevam,
Shawn Guo
Folks,
> Laurent Pinchart (6):
> dt-bindings: media: Add macros for video interface bus types
> dt-bindings: Use new video interface bus type macros in examples
> ARM: dts: freescale: Use new media bus type macros
> ARM: dts: omap: Use new media bus type macros
> ARM: dts: renesas: Use new media bus type macros
> ARM: dts: stm32: Use new media bus type macros
What's the preference on the tree through which these would be merged?
The two first should probably go through the media tree but what about the
DTS? There's a dependency to the first patch. I can take these all if
people are fine with that.
--
Kind regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types
@ 2022-07-17 6:54 ` Sakari Ailus
0 siblings, 0 replies; 102+ messages in thread
From: Sakari Ailus @ 2022-07-17 6:54 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Jacopo Mondi, Eugen Hristev, Hugues Fruchet,
Maxime Coquelin, Alexandre Torgue, Lad Prabhakar, Fabio Estevam,
Shawn Guo
Folks,
> Laurent Pinchart (6):
> dt-bindings: media: Add macros for video interface bus types
> dt-bindings: Use new video interface bus type macros in examples
> ARM: dts: freescale: Use new media bus type macros
> ARM: dts: omap: Use new media bus type macros
> ARM: dts: renesas: Use new media bus type macros
> ARM: dts: stm32: Use new media bus type macros
What's the preference on the tree through which these would be merged?
The two first should probably go through the media tree but what about the
DTS? There's a dependency to the first patch. I can take these all if
people are fine with that.
--
Kind regards,
Sakari Ailus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types
@ 2022-07-17 6:54 ` Sakari Ailus
0 siblings, 0 replies; 102+ messages in thread
From: Sakari Ailus @ 2022-07-17 6:54 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, Jacopo Mondi, Hugues Fruchet, Alexandre Torgue,
dri-devel, Lad Prabhakar, Rob Herring, Maxime Coquelin,
Eugen Hristev, Shawn Guo, linux-arm-kernel, linux-media
Folks,
> Laurent Pinchart (6):
> dt-bindings: media: Add macros for video interface bus types
> dt-bindings: Use new video interface bus type macros in examples
> ARM: dts: freescale: Use new media bus type macros
> ARM: dts: omap: Use new media bus type macros
> ARM: dts: renesas: Use new media bus type macros
> ARM: dts: stm32: Use new media bus type macros
What's the preference on the tree through which these would be merged?
The two first should probably go through the media tree but what about the
DTS? There's a dependency to the first patch. I can take these all if
people are fine with that.
--
Kind regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types
2022-07-17 6:54 ` Sakari Ailus
(?)
@ 2022-11-18 9:23 ` Paul Elder
-1 siblings, 0 replies; 102+ messages in thread
From: Paul Elder @ 2022-11-18 9:23 UTC (permalink / raw)
To: Sakari Ailus
Cc: Laurent Pinchart, devicetree, linux-media, dri-devel,
linux-arm-kernel, Rob Herring, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo
Hi Sakari,
Gentle ping.
On Sun, Jul 17, 2022 at 06:54:00AM +0000, Sakari Ailus wrote:
> Folks,
>
> > Laurent Pinchart (6):
> > dt-bindings: media: Add macros for video interface bus types
> > dt-bindings: Use new video interface bus type macros in examples
> > ARM: dts: freescale: Use new media bus type macros
> > ARM: dts: omap: Use new media bus type macros
> > ARM: dts: renesas: Use new media bus type macros
> > ARM: dts: stm32: Use new media bus type macros
>
> What's the preference on the tree through which these would be merged?
>
> The two first should probably go through the media tree but what about the
> DTS? There's a dependency to the first patch. I can take these all if
> people are fine with that.
How is this going?
Thanks,
Paul
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types
@ 2022-11-18 9:23 ` Paul Elder
0 siblings, 0 replies; 102+ messages in thread
From: Paul Elder @ 2022-11-18 9:23 UTC (permalink / raw)
To: Sakari Ailus
Cc: devicetree, Jacopo Mondi, Hugues Fruchet, Alexandre Torgue,
dri-devel, Lad Prabhakar, Rob Herring, Laurent Pinchart,
Maxime Coquelin, Eugen Hristev, Shawn Guo, linux-arm-kernel,
linux-media
Hi Sakari,
Gentle ping.
On Sun, Jul 17, 2022 at 06:54:00AM +0000, Sakari Ailus wrote:
> Folks,
>
> > Laurent Pinchart (6):
> > dt-bindings: media: Add macros for video interface bus types
> > dt-bindings: Use new video interface bus type macros in examples
> > ARM: dts: freescale: Use new media bus type macros
> > ARM: dts: omap: Use new media bus type macros
> > ARM: dts: renesas: Use new media bus type macros
> > ARM: dts: stm32: Use new media bus type macros
>
> What's the preference on the tree through which these would be merged?
>
> The two first should probably go through the media tree but what about the
> DTS? There's a dependency to the first patch. I can take these all if
> people are fine with that.
How is this going?
Thanks,
Paul
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types
@ 2022-11-18 9:23 ` Paul Elder
0 siblings, 0 replies; 102+ messages in thread
From: Paul Elder @ 2022-11-18 9:23 UTC (permalink / raw)
To: Sakari Ailus
Cc: Laurent Pinchart, devicetree, linux-media, dri-devel,
linux-arm-kernel, Rob Herring, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo
Hi Sakari,
Gentle ping.
On Sun, Jul 17, 2022 at 06:54:00AM +0000, Sakari Ailus wrote:
> Folks,
>
> > Laurent Pinchart (6):
> > dt-bindings: media: Add macros for video interface bus types
> > dt-bindings: Use new video interface bus type macros in examples
> > ARM: dts: freescale: Use new media bus type macros
> > ARM: dts: omap: Use new media bus type macros
> > ARM: dts: renesas: Use new media bus type macros
> > ARM: dts: stm32: Use new media bus type macros
>
> What's the preference on the tree through which these would be merged?
>
> The two first should probably go through the media tree but what about the
> DTS? There's a dependency to the first patch. I can take these all if
> people are fine with that.
How is this going?
Thanks,
Paul
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types
2022-11-18 9:23 ` Paul Elder
(?)
@ 2022-11-19 19:15 ` Laurent Pinchart
-1 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-11-19 19:15 UTC (permalink / raw)
To: Paul Elder
Cc: Sakari Ailus, devicetree, linux-media, dri-devel,
linux-arm-kernel, Rob Herring, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo
Hello,
On Fri, Nov 18, 2022 at 06:23:38PM +0900, Paul Elder wrote:
> Hi Sakari,
>
> Gentle ping.
>
> On Sun, Jul 17, 2022 at 06:54:00AM +0000, Sakari Ailus wrote:
> > Folks,
> >
> > > Laurent Pinchart (6):
> > > dt-bindings: media: Add macros for video interface bus types
> > > dt-bindings: Use new video interface bus type macros in examples
> > > ARM: dts: freescale: Use new media bus type macros
> > > ARM: dts: omap: Use new media bus type macros
> > > ARM: dts: renesas: Use new media bus type macros
> > > ARM: dts: stm32: Use new media bus type macros
> >
> > What's the preference on the tree through which these would be merged?
> >
> > The two first should probably go through the media tree but what about the
> > DTS? There's a dependency to the first patch. I can take these all if
> > people are fine with that.
>
> How is this going?
Sakari, if there's a concern taking patches 3/6 to 6/6 in the media
tree, could you merge 1/6 and 2/6 ? If they can still be included in a
pull request for v6.2, I'll work on getting the dts changes in v6.3
through their respective trees.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types
@ 2022-11-19 19:15 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-11-19 19:15 UTC (permalink / raw)
To: Paul Elder
Cc: Sakari Ailus, devicetree, linux-media, dri-devel,
linux-arm-kernel, Rob Herring, Jacopo Mondi, Eugen Hristev,
Hugues Fruchet, Maxime Coquelin, Alexandre Torgue, Lad Prabhakar,
Fabio Estevam, Shawn Guo
Hello,
On Fri, Nov 18, 2022 at 06:23:38PM +0900, Paul Elder wrote:
> Hi Sakari,
>
> Gentle ping.
>
> On Sun, Jul 17, 2022 at 06:54:00AM +0000, Sakari Ailus wrote:
> > Folks,
> >
> > > Laurent Pinchart (6):
> > > dt-bindings: media: Add macros for video interface bus types
> > > dt-bindings: Use new video interface bus type macros in examples
> > > ARM: dts: freescale: Use new media bus type macros
> > > ARM: dts: omap: Use new media bus type macros
> > > ARM: dts: renesas: Use new media bus type macros
> > > ARM: dts: stm32: Use new media bus type macros
> >
> > What's the preference on the tree through which these would be merged?
> >
> > The two first should probably go through the media tree but what about the
> > DTS? There's a dependency to the first patch. I can take these all if
> > people are fine with that.
>
> How is this going?
Sakari, if there's a concern taking patches 3/6 to 6/6 in the media
tree, could you merge 1/6 and 2/6 ? If they can still be included in a
pull request for v6.2, I'll work on getting the dts changes in v6.3
through their respective trees.
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types
@ 2022-11-19 19:15 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-11-19 19:15 UTC (permalink / raw)
To: Paul Elder
Cc: devicetree, Jacopo Mondi, Maxime Coquelin, Hugues Fruchet,
Alexandre Torgue, dri-devel, Lad Prabhakar, Rob Herring,
Sakari Ailus, Eugen Hristev, Shawn Guo, linux-arm-kernel,
linux-media
Hello,
On Fri, Nov 18, 2022 at 06:23:38PM +0900, Paul Elder wrote:
> Hi Sakari,
>
> Gentle ping.
>
> On Sun, Jul 17, 2022 at 06:54:00AM +0000, Sakari Ailus wrote:
> > Folks,
> >
> > > Laurent Pinchart (6):
> > > dt-bindings: media: Add macros for video interface bus types
> > > dt-bindings: Use new video interface bus type macros in examples
> > > ARM: dts: freescale: Use new media bus type macros
> > > ARM: dts: omap: Use new media bus type macros
> > > ARM: dts: renesas: Use new media bus type macros
> > > ARM: dts: stm32: Use new media bus type macros
> >
> > What's the preference on the tree through which these would be merged?
> >
> > The two first should probably go through the media tree but what about the
> > DTS? There's a dependency to the first patch. I can take these all if
> > people are fine with that.
>
> How is this going?
Sakari, if there's a concern taking patches 3/6 to 6/6 in the media
tree, could you merge 1/6 and 2/6 ? If they can still be included in a
pull request for v6.2, I'll work on getting the dts changes in v6.3
through their respective trees.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types
2022-11-19 19:15 ` Laurent Pinchart
(?)
@ 2022-11-21 10:54 ` Sakari Ailus
-1 siblings, 0 replies; 102+ messages in thread
From: Sakari Ailus @ 2022-11-21 10:54 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Paul Elder, devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Jacopo Mondi, Eugen Hristev, Hugues Fruchet,
Maxime Coquelin, Alexandre Torgue, Lad Prabhakar, Fabio Estevam,
Shawn Guo
Hi Laurent,
On Sat, Nov 19, 2022 at 09:15:04PM +0200, Laurent Pinchart wrote:
> Hello,
>
> On Fri, Nov 18, 2022 at 06:23:38PM +0900, Paul Elder wrote:
> > Hi Sakari,
> >
> > Gentle ping.
> >
> > On Sun, Jul 17, 2022 at 06:54:00AM +0000, Sakari Ailus wrote:
> > > Folks,
> > >
> > > > Laurent Pinchart (6):
> > > > dt-bindings: media: Add macros for video interface bus types
> > > > dt-bindings: Use new video interface bus type macros in examples
> > > > ARM: dts: freescale: Use new media bus type macros
> > > > ARM: dts: omap: Use new media bus type macros
> > > > ARM: dts: renesas: Use new media bus type macros
> > > > ARM: dts: stm32: Use new media bus type macros
> > >
> > > What's the preference on the tree through which these would be merged?
> > >
> > > The two first should probably go through the media tree but what about the
> > > DTS? There's a dependency to the first patch. I can take these all if
> > > people are fine with that.
> >
> > How is this going?
>
> Sakari, if there's a concern taking patches 3/6 to 6/6 in the media
> tree, could you merge 1/6 and 2/6 ? If they can still be included in a
> pull request for v6.2, I'll work on getting the dts changes in v6.3
> through their respective trees.
I think I was expecting v4 from you. But I can address the comments, too,
they were minor matters.
For applying the DTS patches I'd like to have ack from respective
treemaintainers it's fine to take these through the media tree.
--
Kind regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types
@ 2022-11-21 10:54 ` Sakari Ailus
0 siblings, 0 replies; 102+ messages in thread
From: Sakari Ailus @ 2022-11-21 10:54 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Paul Elder, devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Jacopo Mondi, Eugen Hristev, Hugues Fruchet,
Maxime Coquelin, Alexandre Torgue, Lad Prabhakar, Fabio Estevam,
Shawn Guo
Hi Laurent,
On Sat, Nov 19, 2022 at 09:15:04PM +0200, Laurent Pinchart wrote:
> Hello,
>
> On Fri, Nov 18, 2022 at 06:23:38PM +0900, Paul Elder wrote:
> > Hi Sakari,
> >
> > Gentle ping.
> >
> > On Sun, Jul 17, 2022 at 06:54:00AM +0000, Sakari Ailus wrote:
> > > Folks,
> > >
> > > > Laurent Pinchart (6):
> > > > dt-bindings: media: Add macros for video interface bus types
> > > > dt-bindings: Use new video interface bus type macros in examples
> > > > ARM: dts: freescale: Use new media bus type macros
> > > > ARM: dts: omap: Use new media bus type macros
> > > > ARM: dts: renesas: Use new media bus type macros
> > > > ARM: dts: stm32: Use new media bus type macros
> > >
> > > What's the preference on the tree through which these would be merged?
> > >
> > > The two first should probably go through the media tree but what about the
> > > DTS? There's a dependency to the first patch. I can take these all if
> > > people are fine with that.
> >
> > How is this going?
>
> Sakari, if there's a concern taking patches 3/6 to 6/6 in the media
> tree, could you merge 1/6 and 2/6 ? If they can still be included in a
> pull request for v6.2, I'll work on getting the dts changes in v6.3
> through their respective trees.
I think I was expecting v4 from you. But I can address the comments, too,
they were minor matters.
For applying the DTS patches I'd like to have ack from respective
treemaintainers it's fine to take these through the media tree.
--
Kind regards,
Sakari Ailus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types
@ 2022-11-21 10:54 ` Sakari Ailus
0 siblings, 0 replies; 102+ messages in thread
From: Sakari Ailus @ 2022-11-21 10:54 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, Jacopo Mondi, Hugues Fruchet, Paul Elder,
Alexandre Torgue, dri-devel, Lad Prabhakar, Rob Herring,
Maxime Coquelin, Eugen Hristev, Shawn Guo, linux-arm-kernel,
linux-media
Hi Laurent,
On Sat, Nov 19, 2022 at 09:15:04PM +0200, Laurent Pinchart wrote:
> Hello,
>
> On Fri, Nov 18, 2022 at 06:23:38PM +0900, Paul Elder wrote:
> > Hi Sakari,
> >
> > Gentle ping.
> >
> > On Sun, Jul 17, 2022 at 06:54:00AM +0000, Sakari Ailus wrote:
> > > Folks,
> > >
> > > > Laurent Pinchart (6):
> > > > dt-bindings: media: Add macros for video interface bus types
> > > > dt-bindings: Use new video interface bus type macros in examples
> > > > ARM: dts: freescale: Use new media bus type macros
> > > > ARM: dts: omap: Use new media bus type macros
> > > > ARM: dts: renesas: Use new media bus type macros
> > > > ARM: dts: stm32: Use new media bus type macros
> > >
> > > What's the preference on the tree through which these would be merged?
> > >
> > > The two first should probably go through the media tree but what about the
> > > DTS? There's a dependency to the first patch. I can take these all if
> > > people are fine with that.
> >
> > How is this going?
>
> Sakari, if there's a concern taking patches 3/6 to 6/6 in the media
> tree, could you merge 1/6 and 2/6 ? If they can still be included in a
> pull request for v6.2, I'll work on getting the dts changes in v6.3
> through their respective trees.
I think I was expecting v4 from you. But I can address the comments, too,
they were minor matters.
For applying the DTS patches I'd like to have ack from respective
treemaintainers it's fine to take these through the media tree.
--
Kind regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types
2022-11-21 10:54 ` Sakari Ailus
(?)
@ 2022-11-21 11:06 ` Laurent Pinchart
-1 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-11-21 11:06 UTC (permalink / raw)
To: Sakari Ailus
Cc: devicetree, Jacopo Mondi, Hugues Fruchet, Paul Elder,
Alexandre Torgue, dri-devel, Lad Prabhakar, Rob Herring,
Maxime Coquelin, Eugen Hristev, Shawn Guo, linux-arm-kernel,
linux-media
Hi Sakari,
On Mon, Nov 21, 2022 at 10:54:01AM +0000, Sakari Ailus wrote:
> On Sat, Nov 19, 2022 at 09:15:04PM +0200, Laurent Pinchart wrote:
> > On Fri, Nov 18, 2022 at 06:23:38PM +0900, Paul Elder wrote:
> > > On Sun, Jul 17, 2022 at 06:54:00AM +0000, Sakari Ailus wrote:
> > > > Folks,
> > > >
> > > > > Laurent Pinchart (6):
> > > > > dt-bindings: media: Add macros for video interface bus types
> > > > > dt-bindings: Use new video interface bus type macros in examples
> > > > > ARM: dts: freescale: Use new media bus type macros
> > > > > ARM: dts: omap: Use new media bus type macros
> > > > > ARM: dts: renesas: Use new media bus type macros
> > > > > ARM: dts: stm32: Use new media bus type macros
> > > >
> > > > What's the preference on the tree through which these would be merged?
> > > >
> > > > The two first should probably go through the media tree but what about the
> > > > DTS? There's a dependency to the first patch. I can take these all if
> > > > people are fine with that.
> > >
> > > How is this going?
> >
> > Sakari, if there's a concern taking patches 3/6 to 6/6 in the media
> > tree, could you merge 1/6 and 2/6 ? If they can still be included in a
> > pull request for v6.2, I'll work on getting the dts changes in v6.3
> > through their respective trees.
>
> I think I was expecting v4 from you. But I can address the comments, too,
> they were minor matters.
That would be nice :-) Could it still be done for v6.2 ?
> For applying the DTS patches I'd like to have ack from respective
> treemaintainers it's fine to take these through the media tree.
Works for me, this can be done in v6.3.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types
@ 2022-11-21 11:06 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-11-21 11:06 UTC (permalink / raw)
To: Sakari Ailus
Cc: Paul Elder, devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Jacopo Mondi, Eugen Hristev, Hugues Fruchet,
Maxime Coquelin, Alexandre Torgue, Lad Prabhakar, Fabio Estevam,
Shawn Guo
Hi Sakari,
On Mon, Nov 21, 2022 at 10:54:01AM +0000, Sakari Ailus wrote:
> On Sat, Nov 19, 2022 at 09:15:04PM +0200, Laurent Pinchart wrote:
> > On Fri, Nov 18, 2022 at 06:23:38PM +0900, Paul Elder wrote:
> > > On Sun, Jul 17, 2022 at 06:54:00AM +0000, Sakari Ailus wrote:
> > > > Folks,
> > > >
> > > > > Laurent Pinchart (6):
> > > > > dt-bindings: media: Add macros for video interface bus types
> > > > > dt-bindings: Use new video interface bus type macros in examples
> > > > > ARM: dts: freescale: Use new media bus type macros
> > > > > ARM: dts: omap: Use new media bus type macros
> > > > > ARM: dts: renesas: Use new media bus type macros
> > > > > ARM: dts: stm32: Use new media bus type macros
> > > >
> > > > What's the preference on the tree through which these would be merged?
> > > >
> > > > The two first should probably go through the media tree but what about the
> > > > DTS? There's a dependency to the first patch. I can take these all if
> > > > people are fine with that.
> > >
> > > How is this going?
> >
> > Sakari, if there's a concern taking patches 3/6 to 6/6 in the media
> > tree, could you merge 1/6 and 2/6 ? If they can still be included in a
> > pull request for v6.2, I'll work on getting the dts changes in v6.3
> > through their respective trees.
>
> I think I was expecting v4 from you. But I can address the comments, too,
> they were minor matters.
That would be nice :-) Could it still be done for v6.2 ?
> For applying the DTS patches I'd like to have ack from respective
> treemaintainers it's fine to take these through the media tree.
Works for me, this can be done in v6.3.
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 102+ messages in thread
* Re: [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types
@ 2022-11-21 11:06 ` Laurent Pinchart
0 siblings, 0 replies; 102+ messages in thread
From: Laurent Pinchart @ 2022-11-21 11:06 UTC (permalink / raw)
To: Sakari Ailus
Cc: Paul Elder, devicetree, linux-media, dri-devel, linux-arm-kernel,
Rob Herring, Jacopo Mondi, Eugen Hristev, Hugues Fruchet,
Maxime Coquelin, Alexandre Torgue, Lad Prabhakar, Fabio Estevam,
Shawn Guo
Hi Sakari,
On Mon, Nov 21, 2022 at 10:54:01AM +0000, Sakari Ailus wrote:
> On Sat, Nov 19, 2022 at 09:15:04PM +0200, Laurent Pinchart wrote:
> > On Fri, Nov 18, 2022 at 06:23:38PM +0900, Paul Elder wrote:
> > > On Sun, Jul 17, 2022 at 06:54:00AM +0000, Sakari Ailus wrote:
> > > > Folks,
> > > >
> > > > > Laurent Pinchart (6):
> > > > > dt-bindings: media: Add macros for video interface bus types
> > > > > dt-bindings: Use new video interface bus type macros in examples
> > > > > ARM: dts: freescale: Use new media bus type macros
> > > > > ARM: dts: omap: Use new media bus type macros
> > > > > ARM: dts: renesas: Use new media bus type macros
> > > > > ARM: dts: stm32: Use new media bus type macros
> > > >
> > > > What's the preference on the tree through which these would be merged?
> > > >
> > > > The two first should probably go through the media tree but what about the
> > > > DTS? There's a dependency to the first patch. I can take these all if
> > > > people are fine with that.
> > >
> > > How is this going?
> >
> > Sakari, if there's a concern taking patches 3/6 to 6/6 in the media
> > tree, could you merge 1/6 and 2/6 ? If they can still be included in a
> > pull request for v6.2, I'll work on getting the dts changes in v6.3
> > through their respective trees.
>
> I think I was expecting v4 from you. But I can address the comments, too,
> they were minor matters.
That would be nice :-) Could it still be done for v6.2 ?
> For applying the DTS patches I'd like to have ack from respective
> treemaintainers it's fine to take these through the media tree.
Works for me, this can be done in v6.3.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 102+ messages in thread