* [PATCH 0/5] staging: greybus Various stylistic errors
@ 2018-11-02 2:00 Ioannis Valasakis
2018-11-02 2:02 ` [PATCH 1/5] staging: greybus Fix styling, parenthesis matching Ioannis Valasakis
` (4 more replies)
0 siblings, 5 replies; 15+ messages in thread
From: Ioannis Valasakis @ 2018-11-02 2:00 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Ioannis Valasakis (5):
staging: greybus Fix styling, parenthesis matching
staging: greybus Change comparison to NULL
staging: greybus Add a blank line after declaration
staging: greybus Match with open parentheses
staging: greybus Fix SPDX identifier
drivers/staging/greybus/control.h | 5 +++--
drivers/staging/greybus/core.c | 6 +++---
2 files changed, 6 insertions(+), 5 deletions(-)
--
2.19.1
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 1/5] staging: greybus Fix styling, parenthesis matching
2018-11-02 2:00 [PATCH 0/5] staging: greybus Various stylistic errors Ioannis Valasakis
@ 2018-11-02 2:02 ` Ioannis Valasakis
2018-11-02 7:15 ` [Outreachy kernel] " Julia Lawall
2018-11-02 2:02 ` [PATCH 2/5] staging: greybus Change comparison to NULL Ioannis Valasakis
` (3 subsequent siblings)
4 siblings, 1 reply; 15+ messages in thread
From: Ioannis Valasakis @ 2018-11-02 2:02 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Fix two instances where a styling issue is found. That is unmatched
parentheses correct to match.
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
drivers/staging/greybus/core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/greybus/core.c b/drivers/staging/greybus/core.c
index dafa430d176e..d28773e06838 100644
--- a/drivers/staging/greybus/core.c
+++ b/drivers/staging/greybus/core.c
@@ -28,7 +28,7 @@ int greybus_disabled(void)
EXPORT_SYMBOL_GPL(greybus_disabled);
static bool greybus_match_one_id(struct gb_bundle *bundle,
- const struct greybus_bundle_id *id)
+ const struct greybus_bundle_id *id)
{
if ((id->match_flags & GREYBUS_ID_MATCH_VENDOR) &&
(id->vendor != bundle->intf->vendor_id))
@@ -48,7 +48,7 @@ static bool greybus_match_one_id(struct gb_bundle *bundle,
static const struct greybus_bundle_id *
greybus_match_id(struct gb_bundle *bundle, const struct greybus_bundle_id *id)
{
- if (id == NULL)
+ if (!id == NULL)
return NULL;
for (; id->vendor || id->product || id->class || id->driver_info;
@@ -266,7 +266,7 @@ static int greybus_remove(struct device *dev)
}
int greybus_register_driver(struct greybus_driver *driver, struct module *owner,
- const char *mod_name)
+ const char *mod_name)
{
int retval;
--
2.19.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 2/5] staging: greybus Change comparison to NULL
2018-11-02 2:00 [PATCH 0/5] staging: greybus Various stylistic errors Ioannis Valasakis
2018-11-02 2:02 ` [PATCH 1/5] staging: greybus Fix styling, parenthesis matching Ioannis Valasakis
@ 2018-11-02 2:02 ` Ioannis Valasakis
2018-11-02 7:10 ` [Outreachy kernel] " Julia Lawall
2018-11-02 2:04 ` [PATCH 3/5] staging: greybus Add a blank line after declaration Ioannis Valasakis
` (2 subsequent siblings)
4 siblings, 1 reply; 15+ messages in thread
From: Ioannis Valasakis @ 2018-11-02 2:02 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Rewrite the comparison to null shortened.
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
drivers/staging/greybus/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/core.c b/drivers/staging/greybus/core.c
index d28773e06838..d6b0d49130c0 100644
--- a/drivers/staging/greybus/core.c
+++ b/drivers/staging/greybus/core.c
@@ -48,7 +48,7 @@ static bool greybus_match_one_id(struct gb_bundle *bundle,
static const struct greybus_bundle_id *
greybus_match_id(struct gb_bundle *bundle, const struct greybus_bundle_id *id)
{
- if (!id == NULL)
+ if (!id)
return NULL;
for (; id->vendor || id->product || id->class || id->driver_info;
--
2.19.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 3/5] staging: greybus Add a blank line after declaration
2018-11-02 2:00 [PATCH 0/5] staging: greybus Various stylistic errors Ioannis Valasakis
2018-11-02 2:02 ` [PATCH 1/5] staging: greybus Fix styling, parenthesis matching Ioannis Valasakis
2018-11-02 2:02 ` [PATCH 2/5] staging: greybus Change comparison to NULL Ioannis Valasakis
@ 2018-11-02 2:04 ` Ioannis Valasakis
2018-11-02 2:04 ` [PATCH 4/5] staging: greybus Match with open parentheses Ioannis Valasakis
2018-11-02 2:05 ` [PATCH 5/5] staging: greybus Fix SPDX identifier Ioannis Valasakis
4 siblings, 0 replies; 15+ messages in thread
From: Ioannis Valasakis @ 2018-11-02 2:04 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Add a blank line after the struct declaration
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
drivers/staging/greybus/control.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h
index 643ddb9e0f92..9c453e0b1b33 100644
--- a/drivers/staging/greybus/control.h
+++ b/drivers/staging/greybus/control.h
@@ -24,6 +24,7 @@ struct gb_control {
char *vendor_string;
char *product_string;
};
+
#define to_gb_control(d) container_of(d, struct gb_control, dev)
struct gb_control *gb_control_create(struct gb_interface *intf);
--
2.19.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 4/5] staging: greybus Match with open parentheses
2018-11-02 2:00 [PATCH 0/5] staging: greybus Various stylistic errors Ioannis Valasakis
` (2 preceding siblings ...)
2018-11-02 2:04 ` [PATCH 3/5] staging: greybus Add a blank line after declaration Ioannis Valasakis
@ 2018-11-02 2:04 ` Ioannis Valasakis
2018-11-02 4:53 ` Greg KH
2018-11-02 2:05 ` [PATCH 5/5] staging: greybus Fix SPDX identifier Ioannis Valasakis
4 siblings, 1 reply; 15+ messages in thread
From: Ioannis Valasakis @ 2018-11-02 2:04 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Fix the arguments by open parentheses
Reported by checkpatch.
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
drivers/staging/greybus/control.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h
index 9c453e0b1b33..08a51c652a10 100644
--- a/drivers/staging/greybus/control.h
+++ b/drivers/staging/greybus/control.h
@@ -41,7 +41,7 @@ int gb_control_get_bundle_versions(struct gb_control *control);
int gb_control_connected_operation(struct gb_control *control, u16 cport_id);
int gb_control_disconnected_operation(struct gb_control *control, u16 cport_id);
int gb_control_disconnecting_operation(struct gb_control *control,
- u16 cport_id);
+ u17 cport_id);
int gb_control_mode_switch_operation(struct gb_control *control);
void gb_control_mode_switch_prepare(struct gb_control *control);
void gb_control_mode_switch_complete(struct gb_control *control);
--
2.19.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 5/5] staging: greybus Fix SPDX identifier
2018-11-02 2:00 [PATCH 0/5] staging: greybus Various stylistic errors Ioannis Valasakis
` (3 preceding siblings ...)
2018-11-02 2:04 ` [PATCH 4/5] staging: greybus Match with open parentheses Ioannis Valasakis
@ 2018-11-02 2:05 ` Ioannis Valasakis
2018-11-02 7:08 ` [Outreachy kernel] " Julia Lawall
4 siblings, 1 reply; 15+ messages in thread
From: Ioannis Valasakis @ 2018-11-02 2:05 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Fix the SPDX identifier as by replacing with standard C comment the
file
Reported by checkpatch
Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
drivers/staging/greybus/control.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h
index 08a51c652a10..efa0d30a88c2 100644
--- a/drivers/staging/greybus/control.h
+++ b/drivers/staging/greybus/control.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Greybus CPort control protocol
*
--
2.19.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 4/5] staging: greybus Match with open parentheses
2018-11-02 2:04 ` [PATCH 4/5] staging: greybus Match with open parentheses Ioannis Valasakis
@ 2018-11-02 4:53 ` Greg KH
2018-11-02 12:25 ` Ioannis Valasakis
0 siblings, 1 reply; 15+ messages in thread
From: Greg KH @ 2018-11-02 4:53 UTC (permalink / raw)
To: Ioannis Valasakis; +Cc: outreachy-kernel
On Fri, Nov 02, 2018 at 02:04:49AM +0000, Ioannis Valasakis wrote:
> Fix the arguments by open parentheses
> Reported by checkpatch.
>
> Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> ---
> drivers/staging/greybus/control.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h
> index 9c453e0b1b33..08a51c652a10 100644
> --- a/drivers/staging/greybus/control.h
> +++ b/drivers/staging/greybus/control.h
> @@ -41,7 +41,7 @@ int gb_control_get_bundle_versions(struct gb_control *control);
> int gb_control_connected_operation(struct gb_control *control, u16 cport_id);
> int gb_control_disconnected_operation(struct gb_control *control, u16 cport_id);
> int gb_control_disconnecting_operation(struct gb_control *control,
> - u16 cport_id);
> + u17 cport_id);
I don't think you built this code :(
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Outreachy kernel] [PATCH 5/5] staging: greybus Fix SPDX identifier
2018-11-02 2:05 ` [PATCH 5/5] staging: greybus Fix SPDX identifier Ioannis Valasakis
@ 2018-11-02 7:08 ` Julia Lawall
0 siblings, 0 replies; 15+ messages in thread
From: Julia Lawall @ 2018-11-02 7:08 UTC (permalink / raw)
To: Ioannis Valasakis; +Cc: outreachy-kernel, gregkh
On Fri, 2 Nov 2018, Ioannis Valasakis wrote:
> Fix the SPDX identifier as by replacing with standard C comment the
> file
> Reported by checkpatch
Try not to use Fix in your log messages. It takes up a word and doesn't
give any information. Here you could start the sentence wit Replace, and
the Fix would go away.
julia
>
> Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> ---
> drivers/staging/greybus/control.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h
> index 08a51c652a10..efa0d30a88c2 100644
> --- a/drivers/staging/greybus/control.h
> +++ b/drivers/staging/greybus/control.h
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> * Greybus CPort control protocol
> *
> --
> 2.19.1
>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/a37d37114de31fc8bb116bceadd2cb0fbc28f56c.1541123999.git.code%40wizofe.uk.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Outreachy kernel] [PATCH 2/5] staging: greybus Change comparison to NULL
2018-11-02 2:02 ` [PATCH 2/5] staging: greybus Change comparison to NULL Ioannis Valasakis
@ 2018-11-02 7:10 ` Julia Lawall
0 siblings, 0 replies; 15+ messages in thread
From: Julia Lawall @ 2018-11-02 7:10 UTC (permalink / raw)
To: Ioannis Valasakis; +Cc: outreachy-kernel, gregkh
On Fri, 2 Nov 2018, Ioannis Valasakis wrote:
> Rewrite the comparison to null shortened.
This would be more clear as Shorten the comparison to NULL. Or Use ! to
make a NULL test.
julia
> Reported by checkpatch.
>
> Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> ---
> drivers/staging/greybus/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/core.c b/drivers/staging/greybus/core.c
> index d28773e06838..d6b0d49130c0 100644
> --- a/drivers/staging/greybus/core.c
> +++ b/drivers/staging/greybus/core.c
> @@ -48,7 +48,7 @@ static bool greybus_match_one_id(struct gb_bundle *bundle,
> static const struct greybus_bundle_id *
> greybus_match_id(struct gb_bundle *bundle, const struct greybus_bundle_id *id)
> {
> - if (!id == NULL)
> + if (!id)
> return NULL;
>
> for (; id->vendor || id->product || id->class || id->driver_info;
> --
> 2.19.1
>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/b305b4321ae1a13c4a8a6391a8db0c8cce109226.1541123999.git.code%40wizofe.uk.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Outreachy kernel] [PATCH 1/5] staging: greybus Fix styling, parenthesis matching
2018-11-02 2:02 ` [PATCH 1/5] staging: greybus Fix styling, parenthesis matching Ioannis Valasakis
@ 2018-11-02 7:15 ` Julia Lawall
2018-11-02 10:06 ` Ioannis Valasakis
0 siblings, 1 reply; 15+ messages in thread
From: Julia Lawall @ 2018-11-02 7:15 UTC (permalink / raw)
To: Ioannis Valasakis; +Cc: outreachy-kernel, gregkh
On Fri, 2 Nov 2018, Ioannis Valasakis wrote:
> Fix two instances where a styling issue is found. That is unmatched
> parentheses correct to match.
This makes three changes and the second one is quit incorrect.
The first sentence of the log message gives no information. I don't know
what s styling issue is; there are lots of them. I don't understand the
second sentence, and I don't see the connection with the change that is
made. It looks like Align parameters to the right side of the
corresponing (.
Sorry to be picky about your English, which seems to not be your native
language. I realize that of my suggestions, only "avoid fix" is the only
one that is easily generalizable. Still it is important to be clear. For
what you want to say, try to find an appropriate verb, and put it at the
beginning of the sentence. Your messages often contain many words, with
the important part coming later.
julia
> Reported by checkpatch.
>
> Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> ---
> drivers/staging/greybus/core.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/greybus/core.c b/drivers/staging/greybus/core.c
> index dafa430d176e..d28773e06838 100644
> --- a/drivers/staging/greybus/core.c
> +++ b/drivers/staging/greybus/core.c
> @@ -28,7 +28,7 @@ int greybus_disabled(void)
> EXPORT_SYMBOL_GPL(greybus_disabled);
>
> static bool greybus_match_one_id(struct gb_bundle *bundle,
> - const struct greybus_bundle_id *id)
> + const struct greybus_bundle_id *id)
> {
> if ((id->match_flags & GREYBUS_ID_MATCH_VENDOR) &&
> (id->vendor != bundle->intf->vendor_id))
> @@ -48,7 +48,7 @@ static bool greybus_match_one_id(struct gb_bundle *bundle,
> static const struct greybus_bundle_id *
> greybus_match_id(struct gb_bundle *bundle, const struct greybus_bundle_id *id)
> {
> - if (id == NULL)
> + if (!id == NULL)
> return NULL;
>
> for (; id->vendor || id->product || id->class || id->driver_info;
> @@ -266,7 +266,7 @@ static int greybus_remove(struct device *dev)
> }
>
> int greybus_register_driver(struct greybus_driver *driver, struct module *owner,
> - const char *mod_name)
> + const char *mod_name)
> {
> int retval;
>
> --
> 2.19.1
>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/833e98c464540e296f7a577fe672ab5c7931ee10.1541123999.git.code%40wizofe.uk.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Outreachy kernel] [PATCH 1/5] staging: greybus Fix styling, parenthesis matching
2018-11-02 7:15 ` [Outreachy kernel] " Julia Lawall
@ 2018-11-02 10:06 ` Ioannis Valasakis
0 siblings, 0 replies; 15+ messages in thread
From: Ioannis Valasakis @ 2018-11-02 10:06 UTC (permalink / raw)
To: Julia Lawall; +Cc: outreachy-kernel, gregkh
On Fri, Nov 02, 2018 at 08:15:49AM +0100, Julia Lawall wrote:
>
>
> On Fri, 2 Nov 2018, Ioannis Valasakis wrote:
>
> > Fix two instances where a styling issue is found. That is unmatched
> > parentheses correct to match.
>
> This makes three changes and the second one is quit incorrect.
> The first sentence of the log message gives no information. I don't know
> what s styling issue is; there are lots of them. I don't understand the
> second sentence, and I don't see the connection with the change that is
> made. It looks like Align parameters to the right side of the
> corresponing (.
>
> Sorry to be picky about your English, which seems to not be your native
> language. I realize that of my suggestions, only "avoid fix" is the only
> one that is easily generalizable. Still it is important to be clear. For
> what you want to say, try to find an appropriate verb, and put it at the
> beginning of the sentence. Your messages often contain many words, with
> the important part coming later.
Indeed as you probably noticed, English isn't my first language. That is
to say though that writting descriptive commits needs also a different
approach. Don't be sorry, any room of improvement is important to be
able to write more clear commit messages. Thanks for the tips!
ta
ioannis
>
> julia
>
>
> > Reported by checkpatch.
> >
> > Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> > ---
> > drivers/staging/greybus/core.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/greybus/core.c b/drivers/staging/greybus/core.c
> > index dafa430d176e..d28773e06838 100644
> > --- a/drivers/staging/greybus/core.c
> > +++ b/drivers/staging/greybus/core.c
> > @@ -28,7 +28,7 @@ int greybus_disabled(void)
> > EXPORT_SYMBOL_GPL(greybus_disabled);
> >
> > static bool greybus_match_one_id(struct gb_bundle *bundle,
> > - const struct greybus_bundle_id *id)
> > + const struct greybus_bundle_id *id)
> > {
> > if ((id->match_flags & GREYBUS_ID_MATCH_VENDOR) &&
> > (id->vendor != bundle->intf->vendor_id))
> > @@ -48,7 +48,7 @@ static bool greybus_match_one_id(struct gb_bundle *bundle,
> > static const struct greybus_bundle_id *
> > greybus_match_id(struct gb_bundle *bundle, const struct greybus_bundle_id *id)
> > {
> > - if (id == NULL)
> > + if (!id == NULL)
> > return NULL;
> >
> > for (; id->vendor || id->product || id->class || id->driver_info;
> > @@ -266,7 +266,7 @@ static int greybus_remove(struct device *dev)
> > }
> >
> > int greybus_register_driver(struct greybus_driver *driver, struct module *owner,
> > - const char *mod_name)
> > + const char *mod_name)
> > {
> > int retval;
> >
> > --
> > 2.19.1
> >
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/833e98c464540e296f7a577fe672ab5c7931ee10.1541123999.git.code%40wizofe.uk.
> > For more options, visit https://groups.google.com/d/optout.
> >
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 4/5] staging: greybus Match with open parentheses
2018-11-02 4:53 ` Greg KH
@ 2018-11-02 12:25 ` Ioannis Valasakis
2018-11-02 12:43 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 15+ messages in thread
From: Ioannis Valasakis @ 2018-11-02 12:25 UTC (permalink / raw)
To: Greg KH; +Cc: outreachy-kernel
On Fri, Nov 02, 2018 at 05:53:00AM +0100, Greg KH wrote:
> On Fri, Nov 02, 2018 at 02:04:49AM +0000, Ioannis Valasakis wrote:
> > Fix the arguments by open parentheses
> > Reported by checkpatch.
> >
> > Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> > ---
> > drivers/staging/greybus/control.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h
> > index 9c453e0b1b33..08a51c652a10 100644
> > --- a/drivers/staging/greybus/control.h
> > +++ b/drivers/staging/greybus/control.h
> > @@ -41,7 +41,7 @@ int gb_control_get_bundle_versions(struct gb_control *control);
> > int gb_control_connected_operation(struct gb_control *control, u16 cport_id);
> > int gb_control_disconnected_operation(struct gb_control *control, u16 cport_id);
> > int gb_control_disconnecting_operation(struct gb_control *control,
> > - u16 cport_id);
> > + u17 cport_id);
>
> I don't think you built this code :(
I did built it indeed but I didn't include the module on the make
menuconfig, so I had the false impression of compiling. Silly me.
Thanks gregkh for the node.
ta
ioannis
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH 4/5] staging: greybus Match with open parentheses
2018-11-02 12:25 ` Ioannis Valasakis
@ 2018-11-02 12:43 ` Julia Lawall
2018-11-02 14:31 ` Sasha Levin
0 siblings, 1 reply; 15+ messages in thread
From: Julia Lawall @ 2018-11-02 12:43 UTC (permalink / raw)
To: Ioannis Valasakis; +Cc: Greg KH, outreachy-kernel
On Fri, 2 Nov 2018, Ioannis Valasakis wrote:
> On Fri, Nov 02, 2018 at 05:53:00AM +0100, Greg KH wrote:
> > On Fri, Nov 02, 2018 at 02:04:49AM +0000, Ioannis Valasakis wrote:
> > > Fix the arguments by open parentheses
> > > Reported by checkpatch.
> > >
> > > Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> > > ---
> > > drivers/staging/greybus/control.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h
> > > index 9c453e0b1b33..08a51c652a10 100644
> > > --- a/drivers/staging/greybus/control.h
> > > +++ b/drivers/staging/greybus/control.h
> > > @@ -41,7 +41,7 @@ int gb_control_get_bundle_versions(struct gb_control *control);
> > > int gb_control_connected_operation(struct gb_control *control, u16 cport_id);
> > > int gb_control_disconnected_operation(struct gb_control *control, u16 cport_id);
> > > int gb_control_disconnecting_operation(struct gb_control *control,
> > > - u16 cport_id);
> > > + u17 cport_id);
> >
> > I don't think you built this code :(
> I did built it indeed but I didn't include the module on the make
> menuconfig, so I had the false impression of compiling. Silly me.
You can check for a .o file of the .c file you have modified.
julia
>
> Thanks gregkh for the node.
>
> ta
> ioannis
> >
>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181102122539.GA1372%40kvasir.local.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH 4/5] staging: greybus Match with open parentheses
2018-11-02 12:43 ` [Outreachy kernel] " Julia Lawall
@ 2018-11-02 14:31 ` Sasha Levin
2018-11-02 14:33 ` Ioannis Valasakis
0 siblings, 1 reply; 15+ messages in thread
From: Sasha Levin @ 2018-11-02 14:31 UTC (permalink / raw)
To: Julia Lawall; +Cc: Ioannis Valasakis, Greg KH, outreachy-kernel
On Fri, Nov 02, 2018 at 01:43:42PM +0100, Julia Lawall wrote:
>
>
>On Fri, 2 Nov 2018, Ioannis Valasakis wrote:
>
>> On Fri, Nov 02, 2018 at 05:53:00AM +0100, Greg KH wrote:
>> > On Fri, Nov 02, 2018 at 02:04:49AM +0000, Ioannis Valasakis wrote:
>> > > Fix the arguments by open parentheses
>> > > Reported by checkpatch.
>> > >
>> > > Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
>> > > ---
>> > > drivers/staging/greybus/control.h | 2 +-
>> > > 1 file changed, 1 insertion(+), 1 deletion(-)
>> > >
>> > > diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h
>> > > index 9c453e0b1b33..08a51c652a10 100644
>> > > --- a/drivers/staging/greybus/control.h
>> > > +++ b/drivers/staging/greybus/control.h
>> > > @@ -41,7 +41,7 @@ int gb_control_get_bundle_versions(struct gb_control *control);
>> > > int gb_control_connected_operation(struct gb_control *control, u16 cport_id);
>> > > int gb_control_disconnected_operation(struct gb_control *control, u16 cport_id);
>> > > int gb_control_disconnecting_operation(struct gb_control *control,
>> > > - u16 cport_id);
>> > > + u17 cport_id);
>> >
>> > I don't think you built this code :(
>> I did built it indeed but I didn't include the module on the make
>> menuconfig, so I had the false impression of compiling. Silly me.
>
>You can check for a .o file of the .c file you have modified.
My local workflow for this is to do a 'make allmodconfig' to enable
pretty much everything, and then just do targetted builds of subsystems
I touch. In this case I would do 'make drivers/staging/greybus/'.
This way you don't have to worry about enabling the right things in
menuconfig.
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH 4/5] staging: greybus Match with open parentheses
2018-11-02 14:31 ` Sasha Levin
@ 2018-11-02 14:33 ` Ioannis Valasakis
0 siblings, 0 replies; 15+ messages in thread
From: Ioannis Valasakis @ 2018-11-02 14:33 UTC (permalink / raw)
To: Sasha Levin; +Cc: Julia Lawall, Greg KH, outreachy-kernel
On Fri, Nov 02, 2018 at 10:31:14AM -0400, Sasha Levin wrote:
> On Fri, Nov 02, 2018 at 01:43:42PM +0100, Julia Lawall wrote:
> >
> >
> > On Fri, 2 Nov 2018, Ioannis Valasakis wrote:
> >
> > > On Fri, Nov 02, 2018 at 05:53:00AM +0100, Greg KH wrote:
> > > > On Fri, Nov 02, 2018 at 02:04:49AM +0000, Ioannis Valasakis wrote:
> > > > > Fix the arguments by open parentheses
> > > > > Reported by checkpatch.
> > > > >
> > > > > Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> > > > > ---
> > > > > drivers/staging/greybus/control.h | 2 +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h
> > > > > index 9c453e0b1b33..08a51c652a10 100644
> > > > > --- a/drivers/staging/greybus/control.h
> > > > > +++ b/drivers/staging/greybus/control.h
> > > > > @@ -41,7 +41,7 @@ int gb_control_get_bundle_versions(struct gb_control *control);
> > > > > int gb_control_connected_operation(struct gb_control *control, u16 cport_id);
> > > > > int gb_control_disconnected_operation(struct gb_control *control, u16 cport_id);
> > > > > int gb_control_disconnecting_operation(struct gb_control *control,
> > > > > - u16 cport_id);
> > > > > + u17 cport_id);
> > > >
> > > > I don't think you built this code :(
> > > I did built it indeed but I didn't include the module on the make
> > > menuconfig, so I had the false impression of compiling. Silly me.
> >
> > You can check for a .o file of the .c file you have modified.
>
> My local workflow for this is to do a 'make allmodconfig' to enable
> pretty much everything, and then just do targetted builds of subsystems
> I touch. In this case I would do 'make drivers/staging/greybus/'.
>
> This way you don't have to worry about enabling the right things in
> menuconfig.
>
> --
> Thanks,
> Sasha
That is very useful, thank you! Noted.
--
ta
ioannis
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2018-11-02 14:34 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-02 2:00 [PATCH 0/5] staging: greybus Various stylistic errors Ioannis Valasakis
2018-11-02 2:02 ` [PATCH 1/5] staging: greybus Fix styling, parenthesis matching Ioannis Valasakis
2018-11-02 7:15 ` [Outreachy kernel] " Julia Lawall
2018-11-02 10:06 ` Ioannis Valasakis
2018-11-02 2:02 ` [PATCH 2/5] staging: greybus Change comparison to NULL Ioannis Valasakis
2018-11-02 7:10 ` [Outreachy kernel] " Julia Lawall
2018-11-02 2:04 ` [PATCH 3/5] staging: greybus Add a blank line after declaration Ioannis Valasakis
2018-11-02 2:04 ` [PATCH 4/5] staging: greybus Match with open parentheses Ioannis Valasakis
2018-11-02 4:53 ` Greg KH
2018-11-02 12:25 ` Ioannis Valasakis
2018-11-02 12:43 ` [Outreachy kernel] " Julia Lawall
2018-11-02 14:31 ` Sasha Levin
2018-11-02 14:33 ` Ioannis Valasakis
2018-11-02 2:05 ` [PATCH 5/5] staging: greybus Fix SPDX identifier Ioannis Valasakis
2018-11-02 7:08 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.