All of lore.kernel.org
 help / color / mirror / Atom feed
* linux-next: usb tree build failure
@ 2008-10-14  3:59 Stephen Rothwell
  2008-10-14  8:24 ` Dmitry
  2008-10-16 16:05 ` Greg KH
  0 siblings, 2 replies; 60+ messages in thread
From: Stephen Rothwell @ 2008-10-14  3:59 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, Dmitry Baryshkov

[-- Attachment #1: Type: text/plain, Size: 663 bytes --]

Hi Greg,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

drivers/usb/Kconfig:63:error: found recursive dependency: USB -> USB_OHCI_HCD -> I2C -> MCU_MPC8349EMITX -> ARCH_REQUIRE_GPIOLIB -> GPIOLIB -> MFD_TC6393XB -> USB_ARCH_HAS_OHCI -> USB_ARCH_HAS_HCD -> MOUSE_APPLETOUCH -> USB
make[2]: *** [ppc64_defconfig] Error 1
make[1]: *** [ppc64_defconfig] Error 2
make: *** [sub-make] Error 2

Direct cause is commit 51f54ddba226b3b33f55d1be058e809fcfdc30c4 ("USB:
ohci: add support for tmio-ohci cell") which I have reverted.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 60+ messages in thread
* linux-next: usb tree build failure
@ 2010-02-02  6:10 Stephen Rothwell
  2010-02-02 13:53 ` Greg KH
  0 siblings, 1 reply; 60+ messages in thread
From: Stephen Rothwell @ 2010-02-02  6:10 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, linux-kernel, Catalin Marinas

[-- Attachment #1: Type: text/plain, Size: 512 bytes --]

Hi Greg,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/usb/host/isp1760-hcd.c:22:24: error: asm/memory.h: No such file or directory

Caused by commit 571da0df39107568bb137d928862121ddae6aad1 ("isp1760:
Flush the D-cache for the pipe-in transfer buffers").

Only arm has an asm/memory.h ... so I guess it was only tested there?

I reverted that patch for today ...
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 60+ messages in thread
* linux-next: usb tree build failure
@ 2009-08-19  8:34 Stephen Rothwell
  2009-08-19 13:52 ` Greg KH
  0 siblings, 1 reply; 60+ messages in thread
From: Stephen Rothwell @ 2009-08-19  8:34 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, linux-kernel, Jason Wessel

[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]

Hi Greg,

Today's linux-next build (x86_64 allmodconfig) failed like this:

arch/x86/built-in.o: In function `setup_early_printk':
early_printk.c:(.init.text+0x159de): undefined reference to `early_dbgp_init'
early_printk.c:(.init.text+0x159f9): undefined reference to `early_dbgp_console'

Caused by commit 77f162cc16ff4bff1adefe47dbe48ab6b2d9247b ("USB: ehci
early_printk: split ehci debug driver from early_printk.c").

I have reverted that commit for today (along with commits
37e541af790703d66ba88cf3a71b5ae97654b753 ("USB: early_printk: insert cr
prior to nl as needed"), 71c0553ae63d2738a126d4f5b37730dfaa7a2fd7 ("USB:
ehci-dbgp: Execute early BIOS hand off"),
3f038d06f259fd02142aaaaa47addfb4934d4faa ("USB: early_printk: EHCI debug
controller initialization delays") and
f6ee359e79de27b46213f8b5293251a26bc22b1e ("USB: ehci-dbgp: stability
improvements and external re-init") that depended on it).
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 60+ messages in thread
* linux-next: usb tree build failure
@ 2009-04-29  7:17 Stephen Rothwell
  2009-04-29 14:15 ` Greg KH
  2009-04-29 15:18 ` Randy Dunlap
  0 siblings, 2 replies; 60+ messages in thread
From: Stephen Rothwell @ 2009-04-29  7:17 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, Sarah Sharp

Hi Greg,

Today's linux-next build (powerpc allyesconfig) failed like this:

drivers/usb/built-in.o: In function `.handle_event':
(.text+0x67dd0): multiple definition of `.handle_event'
drivers/pcmcia/built-in.o:(.text+0xcfcc): first defined here
drivers/usb/built-in.o: In function `handle_event':
(.opd+0x5bc8): multiple definition of `handle_event'
drivers/pcmcia/built-in.o:(.opd+0xed0): first defined here

Caused by commit 787747a731389c767e6d437f5f94bdc8169ec968 ("USB: xhci:
No-op command queueing and irq handler").  handle_event is a bit generic
for a global symbol (pcmcia should probably be fixed as well).

[Also, the handle_event routine is tail recursive?]
[Also, there a a few other global routines in there that may want less
generic names.]
[Also, I can't find this large series of patches posted on lkml? Maybe
more exposure would be good.]

I added the following patch just for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 29 Apr 2009 17:06:13 +1000
Subject: [PATCH] usb: use xhci_handle_event instead of handle_event

The former is way to generic for a global symbol.

Fixes this build error:

drivers/usb/built-in.o: In function `.handle_event':
(.text+0x67dd0): multiple definition of `.handle_event'
drivers/pcmcia/built-in.o:(.text+0xcfcc): first defined here
drivers/usb/built-in.o: In function `handle_event':
(.opd+0x5bc8): multiple definition of `handle_event'
drivers/pcmcia/built-in.o:(.opd+0xed0): first defined here

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/usb/host/xhci-hcd.c  |    2 +-
 drivers/usb/host/xhci-ring.c |    4 ++--
 drivers/usb/host/xhci.h      |    2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/host/xhci-hcd.c b/drivers/usb/host/xhci-hcd.c
index 4763144..3ac7fbf 100644
--- a/drivers/usb/host/xhci-hcd.c
+++ b/drivers/usb/host/xhci-hcd.c
@@ -251,7 +251,7 @@ static void xhci_work(struct xhci_hcd *xhci)
 	xhci_readl(xhci, &xhci->ir_set->irq_pending);
 
 	/* FIXME this should be a delayed service routine that clears the EHB */
-	handle_event(xhci);
+	xhci_handle_event(xhci);
 
 	/* Clear the event handler busy flag; the event ring should be empty. */
 	temp = xhci_readl(xhci, &xhci->ir_set->erst_dequeue[0]);
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index b7dcbf0..0be8d68 100644
--- a/drivers/usb/host/xhci-ring.c
+++ b/drivers/usb/host/xhci-ring.c
@@ -1016,7 +1016,7 @@ cleanup:
  * This function handles all OS-owned events on the event ring.  It may drop
  * xhci->lock between event processing (e.g. to pass up port status changes).
  */
-void handle_event(struct xhci_hcd *xhci)
+void xhci_handle_event(struct xhci_hcd *xhci)
 {
 	union xhci_trb *event;
 	int update_ptrs = 1;
@@ -1061,7 +1061,7 @@ void handle_event(struct xhci_hcd *xhci)
 		set_hc_event_deq(xhci);
 	}
 	/* Are there more items on the event ring? */
-	handle_event(xhci);
+	xhci_handle_event(xhci);
 }
 
 /****		Endpoint Ring Operations	****/
diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
index 0475066..1f71fad 100644
--- a/drivers/usb/host/xhci.h
+++ b/drivers/usb/host/xhci.h
@@ -1142,7 +1142,7 @@ void xhci_reset_bandwidth(struct usb_hcd *hcd, struct usb_device *udev);
 dma_addr_t trb_virt_to_dma(struct xhci_segment *seg, union xhci_trb *trb);
 void ring_cmd_db(struct xhci_hcd *xhci);
 void *setup_one_noop(struct xhci_hcd *xhci);
-void handle_event(struct xhci_hcd *xhci);
+void xhci_handle_event(struct xhci_hcd *xhci);
 void set_hc_event_deq(struct xhci_hcd *xhci);
 int queue_slot_control(struct xhci_hcd *xhci, u32 trb_type, u32 slot_id);
 int queue_address_device(struct xhci_hcd *xhci, dma_addr_t in_ctx_ptr, u32 slot_id);
-- 
1.6.2.4

^ permalink raw reply related	[flat|nested] 60+ messages in thread
* linux-next: usb tree build failure
@ 2008-12-22  0:33 Stephen Rothwell
  2008-12-22  1:31 ` Greg KH
  2008-12-29  3:55 ` Stephen Rothwell
  0 siblings, 2 replies; 60+ messages in thread
From: Stephen Rothwell @ 2008-12-22  0:33 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, Inaky Perez-Gonzalez

[-- Attachment #1: Type: text/plain, Size: 431 bytes --]

Hi Greg,

Today's linux-next build (x86_64 allmodconfig) failed like this:

x86_64-linux-ld: drivers/net/wimax/built-in.o: No such file: No such file or directory

I reverted commit 66aa675719ab82a03a66b75210fd40be6541f8fb ("wimax:
Makefile, Kconfig and docbook linkage for the stack") just to make the
build work.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 60+ messages in thread
* linux-next: usb tree build failure
@ 2008-11-03  0:36 Stephen Rothwell
  2008-11-05  4:47 ` Greg KH
  0 siblings, 1 reply; 60+ messages in thread
From: Stephen Rothwell @ 2008-11-03  0:36 UTC (permalink / raw)
  To: Greg KH
  Cc: linux-next, Alexey Klimov, Mauro Carvalho Chehab,
	Douglas Schilling Landgraf

Hi Greg,

I am still getting these errors after merging the usb tree:

drivers/media/radio/radio-mr800.c: In function 'vidioc_s_frequency':
drivers/media/radio/radio-mr800.c:362: error: implicit declaration of function 'warn'
drivers/media/radio/radio-mr800.c: In function 'usb_amradio_suspend':
drivers/media/radio/radio-mr800.c:513: error: implicit declaration of function 'info'

I have been reverting these patches for a while:
	USB: remove info() macro from usb.h
	USB: remove warn() macro from usb.h

Today, I excluded those patches completely from my tree and they will
stay excluded until a fix is applied to drivers/media/radio/radio-mr800.c.

Alexey sent a patch on Oct 12 (see below).  Greg, you might as well put
this your series until Mauro or Douglas gets around to sending it to
Linus.  However, that patch does not address the warn() usage ...

Mauro, Douglas, any comment?

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Alexey Klimov <klimov.linux@gmail.com>
Date: Sun, Oct 12, 2008 at 3:05 AM
Subject: [patch] radio-mr800: remove info-macro
To: Douglas Schilling Landgraf <dougsland@gmail.com>


Hello, Douglas!
Here is the patch, that removes 3 info()-statements in radio-mr800,
and place standart printk() there.

Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>

diff -r 4092ed90412b linux/drivers/media/radio/radio-mr800.c
--- a/linux/drivers/media/radio/radio-mr800.c	Sun Oct 12 01:34:43 2008 +0400
+++ b/linux/drivers/media/radio/radio-mr800.c	Sun Oct 12 02:55:32 2008 +0400
@@ -508,7 +508,7 @@
 	if (amradio_stop(radio) < 0)
 		warn("amradio_stop() failed");
 
-	info("radio-mr800: Going into suspend..");
+	printk(KERN_INFO KBUILD_MODNAME ": Going into suspend..\n");
 
 	return 0;
 }
@@ -521,7 +521,7 @@
 	if (amradio_start(radio) < 0)
 		warn("amradio_start() failed");
 
-	info("radio-mr800: Coming out of suspend..");
+	printk(KERN_INFO KBUILD_MODNAME ": Coming out of suspend..\n");
 
 	return 0;
 }
@@ -615,7 +615,8 @@
 {
 	int retval = usb_register(&usb_amradio_driver);
 
-	info(DRIVER_VERSION " " DRIVER_DESC);
+	printk(KERN_INFO KBUILD_MODNAME ": "
+			DRIVER_VERSION " " DRIVER_DESC "\n");
 	if (retval)
 		err("usb_register failed. Error number %d", retval);
 	return retval;

^ permalink raw reply	[flat|nested] 60+ messages in thread
* linux-next: usb tree build failure
@ 2008-10-14  4:08 Stephen Rothwell
  2008-10-14  5:51 ` Alexey Klimov
  0 siblings, 1 reply; 60+ messages in thread
From: Stephen Rothwell @ 2008-10-14  4:08 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, Alexey Klimov, Mauro Carvalho Chehab

[-- Attachment #1: Type: text/plain, Size: 919 bytes --]

Hi Greg,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/media/radio/radio-mr800.c: In function 'vidioc_s_frequency':
drivers/media/radio/radio-mr800.c:362: error: implicit declaration of function 'warn'
drivers/media/radio/radio-mr800.c: In function 'usb_amradio_suspend':
drivers/media/radio/radio-mr800.c:508: error: implicit declaration of function 'info'

Direct cause is commits 9ade02815223bc15481f64dc9bef0ba7493d9fdc ("USB:
remove info() macro from usb.h") and
fb2d8e064998cfc6fdc3f8e2d30382e4f8dfd40a ("USB: remove warn() macro from
usb.h") which I have reverted.

Commit 2aa72f3b63e4b524e9e4b1438f6c0d50a214d836 ("4L/DVB (9101):
radio-mr800: Add driver for AverMedia MR 800 USB FM radio devices") in
Linus' tree added new references to warn() and info().

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 60+ messages in thread
* linux-next: usb tree build failure
@ 2008-08-13  6:37 Stephen Rothwell
  2008-08-13  7:33 ` Stephen Rothwell
  0 siblings, 1 reply; 60+ messages in thread
From: Stephen Rothwell @ 2008-08-13  6:37 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next

Hi Greg,

Today's linux-next build (powerpc ppc44x_config) failed like this:

drivers/usb/host/ohci-ppc-of.c: In function 'ohci_hcd_ppc_of_probe':
drivers/usb/host/ohci-ppc-of.c:103: error: implicit declaration of function 'usb_dbg'

Caused by commit f64f8413f2cf9f4d549c033bc546b9c3d30e78f6 ("USB: convert
the USB host controller code to use usb_dbg()").

I applied the following patch.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 13 Aug 2008 16:34:50 +1000
Subject: [PATCH] usb: fix up use of usb_dbg

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/usb/host/ohci-ppc-of.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/host/ohci-ppc-of.c b/drivers/usb/host/ohci-ppc-of.c
index a1170e4..5b07e42 100644
--- a/drivers/usb/host/ohci-ppc-of.c
+++ b/drivers/usb/host/ohci-ppc-of.c
@@ -18,6 +18,7 @@
 
 #include <asm/prom.h>
 
+#include "../core/usb.h"
 
 static int __devinit
 ohci_ppc_of_start(struct usb_hcd *hcd)
-- 
1.5.6.3

^ permalink raw reply related	[flat|nested] 60+ messages in thread
* linux-next: usb tree build failure
@ 2008-07-18  1:31 Stephen Rothwell
  0 siblings, 0 replies; 60+ messages in thread
From: Stephen Rothwell @ 2008-07-18  1:31 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, Jesse Barnes

Hi Greg,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

drivers/usb/core/driver.c: In function 'do_unbind_rebind':
drivers/usb/core/driver.c:865: error: 'struct dev_pm_info' has no member named 'sleeping'

I have been carrying the patch below and applying it after the pci tree
merge for some time now.  I am not sure if this is the correct fix but it
now needs to be applied after the usb tree is merged.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

>From 415f4b3e7d47ae060f365fe640d229f071b8d44e Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 1 Jul 2008 14:10:53 +1000
Subject: [PATCH] pci: usb fixup 1

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/usb/core/driver.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c
index 21254cb..ddb54e1 100644
--- a/drivers/usb/core/driver.c
+++ b/drivers/usb/core/driver.c
@@ -862,7 +862,7 @@ static void do_unbind_rebind(struct usb_device *udev, int action)
 	 * complete() callback.  Until that is implemented, we have to
 	 * use this hack.
 	 */
-					intf->dev.power.sleeping = 0;
+//					intf->dev.power.sleeping = 0;
 
 					usb_rebind_intf(intf);
 				}
-- 
1.5.6

^ permalink raw reply related	[flat|nested] 60+ messages in thread
end of thread, other threads:[~2010-02-02 22:33 UTC | newest]

Thread overview: 60+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-14  3:59 linux-next: usb tree build failure Stephen Rothwell
2008-10-14  8:24 ` Dmitry
2008-10-14 15:42   ` Dmitry
2008-10-16 16:05 ` Greg KH
2008-10-16 17:27   ` Dmitry Baryshkov
2008-10-16 21:36   ` Dmitry Baryshkov
2008-10-17  0:26     ` Stephen Rothwell
2008-10-17  0:41       ` Dmitry
2008-10-20 18:45         ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2010-02-02  6:10 Stephen Rothwell
2010-02-02 13:53 ` Greg KH
2010-02-02 22:33   ` Stephen Rothwell
2009-08-19  8:34 Stephen Rothwell
2009-08-19 13:52 ` Greg KH
2009-08-19 23:45   ` Greg KH
2009-08-19 23:58     ` Stephen Rothwell
2009-04-29  7:17 Stephen Rothwell
2009-04-29 14:15 ` Greg KH
2009-04-29 15:00   ` Stephen Rothwell
2009-04-29 15:16     ` Greg KH
2009-04-29 15:18 ` Randy Dunlap
2009-04-29 15:37   ` Greg KH
2009-04-29 15:44     ` Randy Dunlap
2009-04-29 17:44       ` Greg KH
2009-04-29 17:53         ` Randy Dunlap
2009-04-30 16:13           ` Greg KH
2009-04-30 16:27             ` Randy Dunlap
2008-12-22  0:33 Stephen Rothwell
2008-12-22  1:31 ` Greg KH
2008-12-22  2:42   ` Stephen Rothwell
2008-12-22  6:45     ` Sam Ravnborg
2008-12-22 17:26       ` Inaky Perez-Gonzalez
2008-12-22 17:53         ` Sam Ravnborg
2008-12-22 23:37           ` Inaky Perez-Gonzalez
2008-12-23  4:31             ` Greg KH
2008-12-23  4:30           ` Greg KH
2008-12-23  4:31         ` Greg KH
2008-12-23 10:26           ` Inaky Perez-Gonzalez
2008-12-23 17:17             ` Greg KH
2008-12-24  1:07               ` Inaky Perez-Gonzalez
2009-01-05  4:34                 ` Greg KH
2009-01-05  5:55                   ` Stephen Rothwell
2008-12-29  3:55 ` Stephen Rothwell
2009-01-02  7:27   ` Greg KH
2009-01-03  4:33     ` Stephen Rothwell
2008-11-03  0:36 Stephen Rothwell
2008-11-05  4:47 ` Greg KH
2008-11-05 18:19   ` Mauro Carvalho Chehab
2008-10-14  4:08 Stephen Rothwell
2008-10-14  5:51 ` Alexey Klimov
2008-10-14 17:41   ` Alexey Klimov
2008-10-14 17:26     ` Mauro Carvalho Chehab
2008-08-13  6:37 Stephen Rothwell
2008-08-13  7:33 ` Stephen Rothwell
2008-08-13 14:23   ` Stephen Rothwell
2008-08-14  6:28     ` Stephen Rothwell
2008-08-14  6:54       ` Stephen Rothwell
2008-08-14 12:25         ` Greg KH
2008-08-15  0:16           ` Stephen Rothwell
2008-07-18  1:31 Stephen Rothwell

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.