From: Akhil P Oommen <quic_akhilpo@quicinc.com> To: Konrad Dybcio <konrad.dybcio@linaro.org> Cc: Rob Clark <robdclark@chromium.org>, devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Sean Paul <sean@poorly.run>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@somainline.org>, Abhinav Kumar <quic_abhinavk@quicinc.com>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, linux-arm-msm@vger.kernel.org, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Marijn Suijten <marijn.suijten@somainline.org>, freedreno@lists.freedesktop.org Subject: Re: [Freedreno] [PATCH v8 11/18] drm/msm/adreno: Disable has_cached_coherent in GMU wrapper configurations Date: Tue, 6 Jun 2023 21:09:52 +0530 [thread overview] Message-ID: <yx4pb2j2dn274ebhufxibti7zt6tozgd7c6qkaun6q7eonz3tw@roapp52oed75> (raw) In-Reply-To: <20230223-topic-gmuwrapper-v8-11-69c68206609e@linaro.org> On Mon, May 29, 2023 at 03:52:30PM +0200, Konrad Dybcio wrote: > > A610 and A619_holi don't support the feature. Disable it to make the GPU stop > crashing after almost each and every submission - the received data on > the GPU end was simply incomplete in garbled, resulting in almost nothing > being executed properly. Extend the disablement to adreno_has_gmu_wrapper, > as none of the GMU wrapper Adrenos that don't support yet seem to feature it. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- Reviewed-by: Akhil P Oommen <quic_akhilpo@quicinc.com> -Akhil > drivers/gpu/drm/msm/adreno/adreno_device.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c > index 8cff86e9d35c..b133755a56c4 100644 > --- a/drivers/gpu/drm/msm/adreno/adreno_device.c > +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c > @@ -551,7 +551,6 @@ static int adreno_bind(struct device *dev, struct device *master, void *data) > config.rev.minor, config.rev.patchid); > > priv->is_a2xx = config.rev.core == 2; > - priv->has_cached_coherent = config.rev.core >= 6; > > gpu = info->init(drm); > if (IS_ERR(gpu)) { > @@ -563,6 +562,10 @@ static int adreno_bind(struct device *dev, struct device *master, void *data) > if (ret) > return ret; > > + if (config.rev.core >= 6) > + if (!adreno_has_gmu_wrapper(to_adreno_gpu(gpu))) > + priv->has_cached_coherent = true; > + > return 0; > } > > > -- > 2.40.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Akhil P Oommen <quic_akhilpo@quicinc.com> To: Konrad Dybcio <konrad.dybcio@linaro.org> Cc: Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@somainline.org>, Conor Dooley <conor+dt@kernel.org>, Rob Clark <robdclark@chromium.org>, <devicetree@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>, "Marijn Suijten" <marijn.suijten@somainline.org>, <freedreno@lists.freedesktop.org> Subject: Re: [Freedreno] [PATCH v8 11/18] drm/msm/adreno: Disable has_cached_coherent in GMU wrapper configurations Date: Tue, 6 Jun 2023 21:09:52 +0530 [thread overview] Message-ID: <yx4pb2j2dn274ebhufxibti7zt6tozgd7c6qkaun6q7eonz3tw@roapp52oed75> (raw) In-Reply-To: <20230223-topic-gmuwrapper-v8-11-69c68206609e@linaro.org> On Mon, May 29, 2023 at 03:52:30PM +0200, Konrad Dybcio wrote: > > A610 and A619_holi don't support the feature. Disable it to make the GPU stop > crashing after almost each and every submission - the received data on > the GPU end was simply incomplete in garbled, resulting in almost nothing > being executed properly. Extend the disablement to adreno_has_gmu_wrapper, > as none of the GMU wrapper Adrenos that don't support yet seem to feature it. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- Reviewed-by: Akhil P Oommen <quic_akhilpo@quicinc.com> -Akhil > drivers/gpu/drm/msm/adreno/adreno_device.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c > index 8cff86e9d35c..b133755a56c4 100644 > --- a/drivers/gpu/drm/msm/adreno/adreno_device.c > +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c > @@ -551,7 +551,6 @@ static int adreno_bind(struct device *dev, struct device *master, void *data) > config.rev.minor, config.rev.patchid); > > priv->is_a2xx = config.rev.core == 2; > - priv->has_cached_coherent = config.rev.core >= 6; > > gpu = info->init(drm); > if (IS_ERR(gpu)) { > @@ -563,6 +562,10 @@ static int adreno_bind(struct device *dev, struct device *master, void *data) > if (ret) > return ret; > > + if (config.rev.core >= 6) > + if (!adreno_has_gmu_wrapper(to_adreno_gpu(gpu))) > + priv->has_cached_coherent = true; > + > return 0; > } > > > -- > 2.40.1 >
next prev parent reply other threads:[~2023-06-06 15:40 UTC|newest] Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-29 13:52 [PATCH v8 00/18] GMU-less A6xx support (A610, A619_holi) Konrad Dybcio 2023-05-29 13:52 ` Konrad Dybcio 2023-05-29 13:52 ` [PATCH v8 01/18] dt-bindings: display/msm: gpu: Document GMU wrapper-equipped A6xx Konrad Dybcio 2023-05-29 13:52 ` Konrad Dybcio 2023-05-30 12:26 ` Krzysztof Kozlowski 2023-05-30 12:26 ` Krzysztof Kozlowski 2023-05-30 13:35 ` Konrad Dybcio 2023-05-30 13:35 ` Konrad Dybcio 2023-06-08 20:58 ` Rob Herring 2023-06-08 20:58 ` Rob Herring 2023-06-09 9:12 ` Konrad Dybcio 2023-06-09 9:12 ` Konrad Dybcio 2023-06-08 21:00 ` Rob Herring 2023-06-08 21:00 ` Rob Herring 2023-05-29 13:52 ` [PATCH v8 02/18] dt-bindings: display/msm/gmu: Add GMU wrapper Konrad Dybcio 2023-05-29 13:52 ` Konrad Dybcio 2023-05-29 13:52 ` [PATCH v8 03/18] drm/msm/a6xx: Remove static keyword from sptprac en/disable functions Konrad Dybcio 2023-05-29 13:52 ` Konrad Dybcio 2023-05-29 13:52 ` [PATCH v8 04/18] drm/msm/a6xx: Move force keepalive vote removal to a6xx_gmu_force_off() Konrad Dybcio 2023-05-29 13:52 ` Konrad Dybcio 2023-06-06 15:30 ` Akhil P Oommen 2023-06-06 15:30 ` Akhil P Oommen 2023-05-29 13:52 ` [PATCH v8 05/18] drm/msm/a6xx: Move a6xx_bus_clear_pending_transactions to a6xx_gpu Konrad Dybcio 2023-05-29 13:52 ` Konrad Dybcio 2023-06-06 15:35 ` Akhil P Oommen 2023-06-06 15:35 ` Akhil P Oommen 2023-05-29 13:52 ` [PATCH v8 06/18] drm/msm/a6xx: Improve a6xx_bus_clear_pending_transactions() Konrad Dybcio 2023-05-29 13:52 ` Konrad Dybcio 2023-06-06 17:09 ` Akhil P Oommen 2023-06-06 17:09 ` Akhil P Oommen 2023-05-29 13:52 ` [PATCH v8 07/18] drm/msm/a6xx: Add a helper for software-resetting the GPU Konrad Dybcio 2023-05-29 13:52 ` Konrad Dybcio 2023-06-06 17:18 ` Akhil P Oommen 2023-06-06 17:18 ` Akhil P Oommen 2023-06-15 10:34 ` Konrad Dybcio 2023-06-15 10:34 ` Konrad Dybcio 2023-06-15 20:11 ` Akhil P Oommen 2023-06-15 20:11 ` Akhil P Oommen 2023-06-15 20:59 ` Konrad Dybcio 2023-06-15 20:59 ` Konrad Dybcio 2023-06-15 21:17 ` Akhil P Oommen 2023-06-15 21:17 ` Akhil P Oommen 2023-05-29 13:52 ` [PATCH v8 08/18] drm/msm/a6xx: Remove both GBIF and RBBM GBIF halt on hw init Konrad Dybcio 2023-05-29 13:52 ` Konrad Dybcio 2023-06-09 18:25 ` Akhil P Oommen 2023-06-09 18:25 ` Akhil P Oommen 2023-06-09 18:35 ` Konrad Dybcio 2023-06-09 18:35 ` Konrad Dybcio 2023-05-29 13:52 ` [PATCH v8 09/18] drm/msm/a6xx: Extend and explain UBWC config Konrad Dybcio 2023-05-29 13:52 ` Konrad Dybcio 2023-06-09 18:41 ` Akhil P Oommen 2023-06-09 18:41 ` Akhil P Oommen 2023-05-29 13:52 ` [PATCH v8 10/18] drm/msm/a6xx: Introduce GMU wrapper support Konrad Dybcio 2023-05-29 13:52 ` Konrad Dybcio 2023-06-09 22:06 ` Akhil P Oommen 2023-06-09 22:06 ` Akhil P Oommen 2023-06-15 21:43 ` Konrad Dybcio 2023-06-15 21:43 ` Konrad Dybcio 2023-06-16 17:54 ` [Freedreno] " Akhil P Oommen 2023-06-16 17:54 ` Akhil P Oommen 2023-06-17 0:00 ` Konrad Dybcio 2023-06-17 0:00 ` Konrad Dybcio 2023-06-17 16:07 ` Akhil P Oommen 2023-06-17 16:07 ` Akhil P Oommen 2023-06-19 13:10 ` Konrad Dybcio 2023-06-19 13:10 ` Konrad Dybcio 2023-05-29 13:52 ` [PATCH v8 11/18] drm/msm/adreno: Disable has_cached_coherent in GMU wrapper configurations Konrad Dybcio 2023-05-29 13:52 ` Konrad Dybcio 2023-06-06 15:39 ` Akhil P Oommen [this message] 2023-06-06 15:39 ` [Freedreno] " Akhil P Oommen 2023-05-29 13:52 ` [PATCH v8 12/18] drm/msm/a6xx: Add support for A619_holi Konrad Dybcio 2023-05-29 13:52 ` Konrad Dybcio 2023-05-29 13:52 ` [PATCH v8 13/18] drm/msm/a6xx: Add A610 support Konrad Dybcio 2023-05-29 13:52 ` Konrad Dybcio 2023-06-14 19:41 ` Akhil P Oommen 2023-06-14 19:41 ` Akhil P Oommen 2023-06-15 10:02 ` Konrad Dybcio 2023-06-15 10:02 ` Konrad Dybcio 2023-05-29 13:52 ` [PATCH v8 14/18] drm/msm/a6xx: Fix some A619 tunables Konrad Dybcio 2023-05-29 13:52 ` Konrad Dybcio 2023-06-14 19:44 ` Akhil P Oommen 2023-06-14 19:44 ` Akhil P Oommen 2023-05-29 13:52 ` [PATCH v8 15/18] drm/msm/a6xx: Use "else if" in GPU speedbin rev matching Konrad Dybcio 2023-05-29 13:52 ` Konrad Dybcio 2023-06-14 19:46 ` Akhil P Oommen 2023-06-14 19:46 ` Akhil P Oommen 2023-05-29 13:52 ` [PATCH v8 16/18] drm/msm/a6xx: Use adreno_is_aXYZ macros in speedbin matching Konrad Dybcio 2023-05-29 13:52 ` Konrad Dybcio 2023-06-14 19:50 ` Akhil P Oommen 2023-06-14 19:50 ` Akhil P Oommen 2023-05-29 13:52 ` [PATCH v8 17/18] drm/msm/a6xx: Add A619_holi speedbin support Konrad Dybcio 2023-05-29 13:52 ` Konrad Dybcio 2023-06-14 20:15 ` Akhil P Oommen 2023-06-14 20:15 ` Akhil P Oommen 2023-05-29 13:52 ` [PATCH v8 18/18] drm/msm/a6xx: Add A610 " Konrad Dybcio 2023-05-29 13:52 ` Konrad Dybcio 2023-06-14 20:18 ` Akhil P Oommen 2023-06-14 20:18 ` Akhil P Oommen 2023-06-15 10:04 ` Konrad Dybcio 2023-06-15 10:04 ` Konrad Dybcio 2023-05-31 12:14 ` [PATCH v8 00/18] GMU-less A6xx support (A610, A619_holi) Konrad Dybcio 2023-05-31 12:14 ` Konrad Dybcio
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=yx4pb2j2dn274ebhufxibti7zt6tozgd7c6qkaun6q7eonz3tw@roapp52oed75 \ --to=quic_akhilpo@quicinc.com \ --cc=andersson@kernel.org \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=konrad.dybcio@linaro.org \ --cc=konrad.dybcio@somainline.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marijn.suijten@somainline.org \ --cc=quic_abhinavk@quicinc.com \ --cc=robdclark@chromium.org \ --cc=robh+dt@kernel.org \ --cc=sean@poorly.run \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.