From: David Miller <davem@davemloft.net>
To: daniel@iogearbox.net
Cc: toke@redhat.com, kuba@kernel.org, lorenzo@kernel.org,
netdev@vger.kernel.org, ilias.apalodimas@linaro.org,
lorenzo.bianconi@redhat.com, andrew@lunn.ch, brouer@redhat.com,
dsahern@kernel.org, bpf@vger.kernel.org
Subject: Re: [RFC net-next] net: mvneta: align xdp stats naming scheme to mlx5 driver
Date: Tue, 18 Feb 2020 15:48:28 -0800 (PST) [thread overview]
Message-ID: <20200218.154828.858448801341482999.davem@davemloft.net> (raw)
In-Reply-To: <703ce998-e454-713c-fc7a-d5f1609146d8@iogearbox.net>
From: Daniel Borkmann <daniel@iogearbox.net>
Date: Wed, 19 Feb 2020 00:19:36 +0100
> On 2/18/20 11:23 PM, Toke Høiland-Jørgensen wrote:
>> Jakub Kicinski <kuba@kernel.org> writes:
>>> On Tue, 18 Feb 2020 01:14:29 +0100 Lorenzo Bianconi wrote:
>>>> Introduce "rx" prefix in the name scheme for xdp counters
>>>> on rx path.
>>>> Differentiate between XDP_TX and ndo_xdp_xmit counters
>>>>
>>>> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
>>>
>>> Sorry for coming in late.
>>>
>>> I thought the ability to attach a BPF program to a fexit of another
>>> BPF
>>> program will put an end to these unnecessary statistics. IOW I
>>> maintain
>>> my position that there should be no ethtool stats for XDP.
>>>
>>> As discussed before real life BPF progs will maintain their own stats
>>> at the granularity of their choosing, so we're just wasting datapath
>>> cycles.
>
> +1
Bugs in bpf programs leading to lack of fundamental statistics.
I think that is absolutely the wrong tradeoff.
And if performance is a concern, we can have a knob to turn off
the xdp counter bumps. This is something I totally support.
next prev parent reply other threads:[~2020-02-18 23:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 0:14 [RFC net-next] net: mvneta: align xdp stats naming scheme to mlx5 driver Lorenzo Bianconi
2020-02-18 3:12 ` David Ahern
2020-02-18 17:02 ` Jesper Dangaard Brouer
2020-02-18 17:17 ` Lorenzo Bianconi
2020-02-18 17:48 ` Jesper Dangaard Brouer
2020-02-18 18:03 ` Lorenzo Bianconi
2020-02-18 21:29 ` Jakub Kicinski
2020-02-18 22:23 ` Toke Høiland-Jørgensen
2020-02-18 23:19 ` Daniel Borkmann
2020-02-18 23:24 ` David Ahern
2020-02-18 23:49 ` David Miller
2020-02-18 23:48 ` David Miller [this message]
2020-02-18 23:47 ` David Miller
2020-02-19 3:31 ` Jakub Kicinski
2020-02-19 8:26 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218.154828.858448801341482999.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=dsahern@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=kuba@kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).