From: Daniel Borkmann <daniel@iogearbox.net>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Lorenzo Bianconi" <lorenzo@kernel.org>
Cc: netdev@vger.kernel.org, ilias.apalodimas@linaro.org,
davem@davemloft.net, lorenzo.bianconi@redhat.com, andrew@lunn.ch,
brouer@redhat.com, dsahern@kernel.org, bpf@vger.kernel.org
Subject: Re: [RFC net-next] net: mvneta: align xdp stats naming scheme to mlx5 driver
Date: Wed, 19 Feb 2020 00:19:36 +0100 [thread overview]
Message-ID: <703ce998-e454-713c-fc7a-d5f1609146d8@iogearbox.net> (raw)
In-Reply-To: <87eeury1ph.fsf@toke.dk>
On 2/18/20 11:23 PM, Toke Høiland-Jørgensen wrote:
> Jakub Kicinski <kuba@kernel.org> writes:
>> On Tue, 18 Feb 2020 01:14:29 +0100 Lorenzo Bianconi wrote:
>>> Introduce "rx" prefix in the name scheme for xdp counters
>>> on rx path.
>>> Differentiate between XDP_TX and ndo_xdp_xmit counters
>>>
>>> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
>>
>> Sorry for coming in late.
>>
>> I thought the ability to attach a BPF program to a fexit of another BPF
>> program will put an end to these unnecessary statistics. IOW I maintain
>> my position that there should be no ethtool stats for XDP.
>>
>> As discussed before real life BPF progs will maintain their own stats
>> at the granularity of their choosing, so we're just wasting datapath
>> cycles.
+1
>> The previous argument that the BPF prog stats are out of admin control
>> is no longer true with the fexit option (IIUC how that works).
>
> So you're proposing an admin that wants to keep track of XDP has to
> (permantently?) attach an fexit program to every running XDP program and
> use that to keep statistics? But presumably he'd first need to discover
> that XDP is enabled; which the ethtool stats is a good hint for :)
Doesn't iproute2 clearly show that already via `ip l` that XDP is attached?
next prev parent reply other threads:[~2020-02-18 23:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 0:14 [RFC net-next] net: mvneta: align xdp stats naming scheme to mlx5 driver Lorenzo Bianconi
2020-02-18 3:12 ` David Ahern
2020-02-18 17:02 ` Jesper Dangaard Brouer
2020-02-18 17:17 ` Lorenzo Bianconi
2020-02-18 17:48 ` Jesper Dangaard Brouer
2020-02-18 18:03 ` Lorenzo Bianconi
2020-02-18 21:29 ` Jakub Kicinski
2020-02-18 22:23 ` Toke Høiland-Jørgensen
2020-02-18 23:19 ` Daniel Borkmann [this message]
2020-02-18 23:24 ` David Ahern
2020-02-18 23:49 ` David Miller
2020-02-18 23:48 ` David Miller
2020-02-18 23:47 ` David Miller
2020-02-19 3:31 ` Jakub Kicinski
2020-02-19 8:26 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=703ce998-e454-713c-fc7a-d5f1609146d8@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=andrew@lunn.ch \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=kuba@kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).