From: David Ahern <dsahern@gmail.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>, netdev@vger.kernel.org
Cc: ilias.apalodimas@linaro.org, davem@davemloft.net,
lorenzo.bianconi@redhat.com, andrew@lunn.ch, brouer@redhat.com,
dsahern@kernel.org, bpf@vger.kernel.org
Subject: Re: [RFC net-next] net: mvneta: align xdp stats naming scheme to mlx5 driver
Date: Mon, 17 Feb 2020 20:12:43 -0700 [thread overview]
Message-ID: <70db0e12-22df-e612-b885-bce926bbaf5f@gmail.com> (raw)
In-Reply-To: <526238d9bcc60500ed61da1a4af8b65af1af9583.1581984697.git.lorenzo@kernel.org>
On 2/17/20 5:14 PM, Lorenzo Bianconi wrote:
> @@ -399,10 +400,11 @@ static const struct mvneta_statistic mvneta_statistics[] = {
> { ETHTOOL_STAT_EEE_WAKEUP, T_SW, "eee_wakeup_errors", },
> { ETHTOOL_STAT_SKB_ALLOC_ERR, T_SW, "skb_alloc_errors", },
> { ETHTOOL_STAT_REFILL_ERR, T_SW, "refill_errors", },
> - { ETHTOOL_XDP_REDIRECT, T_SW, "xdp_redirect", },
> - { ETHTOOL_XDP_PASS, T_SW, "xdp_pass", },
> - { ETHTOOL_XDP_DROP, T_SW, "xdp_drop", },
> - { ETHTOOL_XDP_TX, T_SW, "xdp_tx", },
> + { ETHTOOL_XDP_REDIRECT, T_SW, "rx_xdp_redirect", },
> + { ETHTOOL_XDP_PASS, T_SW, "rx_xdp_pass", },
> + { ETHTOOL_XDP_DROP, T_SW, "rx_xdp_drop", },
> + { ETHTOOL_XDP_TX, T_SW, "rx_xdp_tx_xmit", },
> + { ETHTOOL_XDP_XMIT, T_SW, "tx_xdp_xmit", },
> };
>
LGTM
Acked-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2020-02-18 3:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 0:14 [RFC net-next] net: mvneta: align xdp stats naming scheme to mlx5 driver Lorenzo Bianconi
2020-02-18 3:12 ` David Ahern [this message]
2020-02-18 17:02 ` Jesper Dangaard Brouer
2020-02-18 17:17 ` Lorenzo Bianconi
2020-02-18 17:48 ` Jesper Dangaard Brouer
2020-02-18 18:03 ` Lorenzo Bianconi
2020-02-18 21:29 ` Jakub Kicinski
2020-02-18 22:23 ` Toke Høiland-Jørgensen
2020-02-18 23:19 ` Daniel Borkmann
2020-02-18 23:24 ` David Ahern
2020-02-18 23:49 ` David Miller
2020-02-18 23:48 ` David Miller
2020-02-18 23:47 ` David Miller
2020-02-19 3:31 ` Jakub Kicinski
2020-02-19 8:26 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70db0e12-22df-e612-b885-bce926bbaf5f@gmail.com \
--to=dsahern@gmail.com \
--cc=andrew@lunn.ch \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).