From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: netdev@vger.kernel.org, ilias.apalodimas@linaro.org,
davem@davemloft.net, lorenzo.bianconi@redhat.com, andrew@lunn.ch,
dsahern@kernel.org, bpf@vger.kernel.org,
"Toke Høiland-Jørgensen" <toke@redhat.com>
Subject: Re: [RFC net-next] net: mvneta: align xdp stats naming scheme to mlx5 driver
Date: Tue, 18 Feb 2020 18:17:16 +0100 [thread overview]
Message-ID: <20200218171716.GA13376@localhost.localdomain> (raw)
In-Reply-To: <20200218180210.130f0e6d@carbon>
[-- Attachment #1: Type: text/plain, Size: 4786 bytes --]
> On Tue, 18 Feb 2020 01:14:29 +0100
> Lorenzo Bianconi <lorenzo@kernel.org> wrote:
>
> > Introduce "rx" prefix in the name scheme for xdp counters
> > on rx path.
> > Differentiate between XDP_TX and ndo_xdp_xmit counters
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> > drivers/net/ethernet/marvell/mvneta.c | 22 +++++++++++++++++-----
> > 1 file changed, 17 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
> > index b7045b6a15c2..6223700dc3df 100644
> > --- a/drivers/net/ethernet/marvell/mvneta.c
> > +++ b/drivers/net/ethernet/marvell/mvneta.c
> > @@ -344,6 +344,7 @@ enum {
> > ETHTOOL_XDP_REDIRECT,
> > ETHTOOL_XDP_PASS,
> > ETHTOOL_XDP_DROP,
> > + ETHTOOL_XDP_XMIT,
> > ETHTOOL_XDP_TX,
> > ETHTOOL_MAX_STATS,
> > };
> > @@ -399,10 +400,11 @@ static const struct mvneta_statistic mvneta_statistics[] = {
> > { ETHTOOL_STAT_EEE_WAKEUP, T_SW, "eee_wakeup_errors", },
> > { ETHTOOL_STAT_SKB_ALLOC_ERR, T_SW, "skb_alloc_errors", },
> > { ETHTOOL_STAT_REFILL_ERR, T_SW, "refill_errors", },
> > - { ETHTOOL_XDP_REDIRECT, T_SW, "xdp_redirect", },
> > - { ETHTOOL_XDP_PASS, T_SW, "xdp_pass", },
> > - { ETHTOOL_XDP_DROP, T_SW, "xdp_drop", },
> > - { ETHTOOL_XDP_TX, T_SW, "xdp_tx", },
> > + { ETHTOOL_XDP_REDIRECT, T_SW, "rx_xdp_redirect", },
> > + { ETHTOOL_XDP_PASS, T_SW, "rx_xdp_pass", },
> > + { ETHTOOL_XDP_DROP, T_SW, "rx_xdp_drop", },
> > + { ETHTOOL_XDP_TX, T_SW, "rx_xdp_tx_xmit", },
>
> Hmmm... "rx_xdp_tx_xmit", I expected this to be named "rx_xdp_tx" to
> count the XDP_TX actions, but I guess this means something else.
just reused mlx5 naming scheme here :)
>
> > + { ETHTOOL_XDP_XMIT, T_SW, "tx_xdp_xmit", },
>
> Okay, maybe. I guess, this will still be valid for when we add an XDP
> egress/TX-hook point.
same here
>
> > };
> >
> > struct mvneta_stats {
> > @@ -414,6 +416,7 @@ struct mvneta_stats {
> > u64 xdp_redirect;
> > u64 xdp_pass;
> > u64 xdp_drop;
> > + u64 xdp_xmit;
> > u64 xdp_tx;
> > };
> >
> > @@ -2050,7 +2053,10 @@ mvneta_xdp_submit_frame(struct mvneta_port *pp, struct mvneta_tx_queue *txq,
> > u64_stats_update_begin(&stats->syncp);
> > stats->es.ps.tx_bytes += xdpf->len;
> > stats->es.ps.tx_packets++;
> > - stats->es.ps.xdp_tx++;
> > + if (buf->type == MVNETA_TYPE_XDP_NDO)
> > + stats->es.ps.xdp_xmit++;
> > + else
> > + stats->es.ps.xdp_tx++;
>
> I don't like that you add a branch (if-statement) in this fast-path code.
>
> Do we really need to account in the xmit frame function, if this was a
> XDP_REDIRECT or XDP_TX that started the xmit? I mean we already have
> action counters for XDP_REDIRECT and XDP_TX (but I guess you skipped
> the XDP_TX action counter).
ack, good point..I think we can move the code in
mvneta_xdp_xmit_back/mvneta_xdp_xmit in order to avoid the if() condition.
Moreover we can move it out the for loop in mvneta_xdp_xmit().
I will fix in a formal patch
>
>
> > u64_stats_update_end(&stats->syncp);
> >
> > mvneta_txq_inc_put(txq);
> > @@ -4484,6 +4490,7 @@ mvneta_ethtool_update_pcpu_stats(struct mvneta_port *pp,
> > u64 xdp_redirect;
> > u64 xdp_pass;
> > u64 xdp_drop;
> > + u64 xdp_xmit;
> > u64 xdp_tx;
> >
> > stats = per_cpu_ptr(pp->stats, cpu);
> > @@ -4494,6 +4501,7 @@ mvneta_ethtool_update_pcpu_stats(struct mvneta_port *pp,
> > xdp_redirect = stats->es.ps.xdp_redirect;
> > xdp_pass = stats->es.ps.xdp_pass;
> > xdp_drop = stats->es.ps.xdp_drop;
> > + xdp_xmit = stats->es.ps.xdp_xmit;
> > xdp_tx = stats->es.ps.xdp_tx;
> > } while (u64_stats_fetch_retry_irq(&stats->syncp, start));
> >
> > @@ -4502,6 +4510,7 @@ mvneta_ethtool_update_pcpu_stats(struct mvneta_port *pp,
> > es->ps.xdp_redirect += xdp_redirect;
> > es->ps.xdp_pass += xdp_pass;
> > es->ps.xdp_drop += xdp_drop;
> > + es->ps.xdp_xmit += xdp_xmit;
> > es->ps.xdp_tx += xdp_tx;
> > }
> > }
> > @@ -4555,6 +4564,9 @@ static void mvneta_ethtool_update_stats(struct mvneta_port *pp)
> > case ETHTOOL_XDP_TX:
> > pp->ethtool_stats[i] = stats.ps.xdp_tx;
> > break;
> > + case ETHTOOL_XDP_XMIT:
> > + pp->ethtool_stats[i] = stats.ps.xdp_xmit;
> > + break;
> > }
> > break;
> > }
>
> It doesn't look like you have an action counter for XDP_TX, but we have
> one for XDP_REDIRECT?
I did not get you here sorry, I guess they should be accounted in two separated
counters.
Regards,
Lorenzo
>
> --
> Best regards,
> Jesper Dangaard Brouer
> MSc.CS, Principal Kernel Engineer at Red Hat
> LinkedIn: http://www.linkedin.com/in/brouer
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2020-02-18 17:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 0:14 [RFC net-next] net: mvneta: align xdp stats naming scheme to mlx5 driver Lorenzo Bianconi
2020-02-18 3:12 ` David Ahern
2020-02-18 17:02 ` Jesper Dangaard Brouer
2020-02-18 17:17 ` Lorenzo Bianconi [this message]
2020-02-18 17:48 ` Jesper Dangaard Brouer
2020-02-18 18:03 ` Lorenzo Bianconi
2020-02-18 21:29 ` Jakub Kicinski
2020-02-18 22:23 ` Toke Høiland-Jørgensen
2020-02-18 23:19 ` Daniel Borkmann
2020-02-18 23:24 ` David Ahern
2020-02-18 23:49 ` David Miller
2020-02-18 23:48 ` David Miller
2020-02-18 23:47 ` David Miller
2020-02-19 3:31 ` Jakub Kicinski
2020-02-19 8:26 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218171716.GA13376@localhost.localdomain \
--to=lorenzo@kernel.org \
--cc=andrew@lunn.ch \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).