DriverDev-Devel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] staging: gasket: gasket_ioctl: Remove unnecessary line-breaks in funtion signature
@ 2019-11-06 18:08 Valery Ivanov
  2019-11-06 19:12 ` Joe Perches
  2019-11-07 15:08 ` Greg KH
  0 siblings, 2 replies; 4+ messages in thread
From: Valery Ivanov @ 2019-11-06 18:08 UTC (permalink / raw)
  To: rspringer, toddpoynor, benchan; +Cc: devel, gregkh, linux-kernel

	This patch fix the function signature for trace_gasket_ioctl_page_table_data
	to avoid the checkpatch.pl warning:

		CHECK: Lines should not end with a '('

Signed-off-by: Valery Ivanov <ivalery111@gmail.com>
---
 drivers/staging/gasket/gasket_ioctl.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/gasket/gasket_ioctl.c b/drivers/staging/gasket/gasket_ioctl.c
index 240f9bb..55cb6b1 100644
--- a/drivers/staging/gasket/gasket_ioctl.c
+++ b/drivers/staging/gasket/gasket_ioctl.c
@@ -54,9 +54,10 @@ static int gasket_read_page_table_size(struct gasket_dev *gasket_dev,
 	ibuf.size = gasket_page_table_num_entries(
 		gasket_dev->page_table[ibuf.page_table_index]);
 
-	trace_gasket_ioctl_page_table_data(
-		ibuf.page_table_index, ibuf.size, ibuf.host_address,
-		ibuf.device_address);
+	trace_gasket_ioctl_page_table_data(ibuf.page_table_index,
+					   ibuf.size,
+					   ibuf.host_address,
+					   ibuf.device_address);
 
 	if (copy_to_user(argp, &ibuf, sizeof(ibuf)))
 		return -EFAULT;
-- 
1.8.3.1

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] staging: gasket: gasket_ioctl: Remove unnecessary line-breaks in funtion signature
  2019-11-06 18:08 [PATCH] staging: gasket: gasket_ioctl: Remove unnecessary line-breaks in funtion signature Valery Ivanov
@ 2019-11-06 19:12 ` Joe Perches
  2019-11-07 15:09   ` Greg KH
  2019-11-07 15:08 ` Greg KH
  1 sibling, 1 reply; 4+ messages in thread
From: Joe Perches @ 2019-11-06 19:12 UTC (permalink / raw)
  To: Valery Ivanov, rspringer, toddpoynor, benchan, Simon Que, John Joseph
  Cc: devel, gregkh, linux-kernel

On Wed, 2019-11-06 at 18:08 +0000, Valery Ivanov wrote:
> 	This patch fix the function signature for trace_gasket_ioctl_page_table_data
> 	to avoid the checkpatch.pl warning:
> 
> 		CHECK: Lines should not end with a '('
> 
> Signed-off-by: Valery Ivanov <ivalery111@gmail.com>

All of this stuff is no-op and could just as easily be removed
completely as GASKET_KERNEL_TRACE_SUPPORT is not #defined anywhere.

Is the actual trace #include file supposed to be available somewhere?

#ifdef GASKET_KERNEL_TRACE_SUPPORT
#define CREATE_TRACE_POINTS
#include <trace/events/gasket_ioctl.h>
#else
#define trace_gasket_ioctl_entry(x, ...)
#define trace_gasket_ioctl_exit(x)
#define trace_gasket_ioctl_integer_data(x)
#define trace_gasket_ioctl_eventfd_data(x, ...)
#define trace_gasket_ioctl_page_table_data(x, ...)
#define trace_gasket_ioctl_config_coherent_allocator(x, ...)
#endif

trace file not found...

> ---
>  drivers/staging/gasket/gasket_ioctl.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/gasket/gasket_ioctl.c b/drivers/staging/gasket/gasket_ioctl.c
> index 240f9bb..55cb6b1 100644
> --- a/drivers/staging/gasket/gasket_ioctl.c
> +++ b/drivers/staging/gasket/gasket_ioctl.c
> @@ -54,9 +54,10 @@ static int gasket_read_page_table_size(struct gasket_dev *gasket_dev,
>  	ibuf.size = gasket_page_table_num_entries(
>  		gasket_dev->page_table[ibuf.page_table_index]);
>  
> -	trace_gasket_ioctl_page_table_data(
> -		ibuf.page_table_index, ibuf.size, ibuf.host_address,
> -		ibuf.device_address);
> +	trace_gasket_ioctl_page_table_data(ibuf.page_table_index,
> +					   ibuf.size,
> +					   ibuf.host_address,
> +					   ibuf.device_address);
>  
>  	if (copy_to_user(argp, &ibuf, sizeof(ibuf)))
>  		return -EFAULT;

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] staging: gasket: gasket_ioctl: Remove unnecessary line-breaks in funtion signature
  2019-11-06 18:08 [PATCH] staging: gasket: gasket_ioctl: Remove unnecessary line-breaks in funtion signature Valery Ivanov
  2019-11-06 19:12 ` Joe Perches
@ 2019-11-07 15:08 ` Greg KH
  1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2019-11-07 15:08 UTC (permalink / raw)
  To: Valery Ivanov; +Cc: devel, toddpoynor, rspringer, linux-kernel

On Wed, Nov 06, 2019 at 06:08:21PM +0000, Valery Ivanov wrote:
> 	This patch fix the function signature for trace_gasket_ioctl_page_table_data
> 	to avoid the checkpatch.pl warning:
> 
> 		CHECK: Lines should not end with a '('

Why the huge indentation?

THat's not ok, please fix up.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] staging: gasket: gasket_ioctl: Remove unnecessary line-breaks in funtion signature
  2019-11-06 19:12 ` Joe Perches
@ 2019-11-07 15:09   ` Greg KH
  0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2019-11-07 15:09 UTC (permalink / raw)
  To: Joe Perches
  Cc: devel, John Joseph, linux-kernel, Simon Que, rspringer,
	Valery Ivanov, toddpoynor

On Wed, Nov 06, 2019 at 11:12:09AM -0800, Joe Perches wrote:
> On Wed, 2019-11-06 at 18:08 +0000, Valery Ivanov wrote:
> > 	This patch fix the function signature for trace_gasket_ioctl_page_table_data
> > 	to avoid the checkpatch.pl warning:
> > 
> > 		CHECK: Lines should not end with a '('
> > 
> > Signed-off-by: Valery Ivanov <ivalery111@gmail.com>
> 
> All of this stuff is no-op and could just as easily be removed
> completely as GASKET_KERNEL_TRACE_SUPPORT is not #defined anywhere.
> 
> Is the actual trace #include file supposed to be available somewhere?
> 
> #ifdef GASKET_KERNEL_TRACE_SUPPORT
> #define CREATE_TRACE_POINTS
> #include <trace/events/gasket_ioctl.h>
> #else
> #define trace_gasket_ioctl_entry(x, ...)
> #define trace_gasket_ioctl_exit(x)
> #define trace_gasket_ioctl_integer_data(x)
> #define trace_gasket_ioctl_eventfd_data(x, ...)
> #define trace_gasket_ioctl_page_table_data(x, ...)
> #define trace_gasket_ioctl_config_coherent_allocator(x, ...)
> #endif
> 
> trace file not found...

I'm thinking the whole gasket driver should be deleted as there has not
been any effort done to fix it up and get it out of staging.  I'll give
it until 5.5 before I drop it...

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-06 18:08 [PATCH] staging: gasket: gasket_ioctl: Remove unnecessary line-breaks in funtion signature Valery Ivanov
2019-11-06 19:12 ` Joe Perches
2019-11-07 15:09   ` Greg KH
2019-11-07 15:08 ` Greg KH

DriverDev-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/driverdev-devel/0 driverdev-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 driverdev-devel driverdev-devel/ https://lore.kernel.org/driverdev-devel \
		driverdev-devel@linuxdriverproject.org devel@driverdev.osuosl.org
	public-inbox-index driverdev-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.linuxdriverproject.driverdev-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git