Re: [PATCH v12 08/16] dt: bindings: lp55xx: Update binding for Multicolor Framework

[Jacek Anaszewski <jacek.anaszewski@gmail.com>]

Dan,

On 10/12/19 2:54 AM, Dan Murphy wrote:
> Jacek
> 
> On 10/11/19 3:15 PM, Jacek Anaszewski wrote:
>> Dan,
>>
>> On 10/11/19 3:06 PM, Dan Murphy wrote:
>>> Update the DT binding to include the properties to use the
>>> multicolor framework for the devices that use the LP55xx
>>> framework.
>>>
>>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>>> CC: Tony Lindgren <tony@atomide.com>
>>> CC: "Benoît Cousson" <bcousson@baylibre.com>
>>> CC: Linus Walleij <linus.walleij@linaro.org>
>>> CC: Shawn Guo <shawnguo@kernel.org>
>>> CC: Sascha Hauer <s.hauer@pengutronix.de>
>>> CC: Pengutronix Kernel Team <kernel@pengutronix.de>
>>> CC: Fabio Estevam <festevam@gmail.com>
>>> CC: NXP Linux Team <linux-imx@nxp.com>
>>> ---
>>>   .../devicetree/bindings/leds/leds-lp55xx.txt  | 149 +++++++++++++++---
>>>   1 file changed, 124 insertions(+), 25 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/leds/leds-lp55xx.txt
>>> b/Documentation/devicetree/bindings/leds/leds-lp55xx.txt
>>> index bfe2805c5534..736a2e1538be 100644
>>> --- a/Documentation/devicetree/bindings/leds/leds-lp55xx.txt
>>> +++ b/Documentation/devicetree/bindings/leds/leds-lp55xx.txt
>>> @@ -1,6 +1,8 @@
>>>   Binding for TI/National Semiconductor LP55xx LED Drivers
>>>     Required properties:
>>> +- #address-cells: 1
>>> +- #size-cells: 0
>>>   - compatible: one of
>>>       national,lp5521
>>>       national,lp5523
>>> @@ -14,6 +16,18 @@ Required properties:
>>>   Each child has own specific current settings
>>>   - led-cur: Current setting at each LED channel (mA x10, 0 if LED is
>>> not connected)
>>>   - max-cur: Maximun current at each LED channel.
>>> +- reg: Output channel for the LED.  This is zero based channel
>>> identifier and
>>> +    the data sheet is a one based channel identifier.
>>> +    reg value to output to LED output number
>>> +    D1 = reg value is 0
>>> +    D2 = reg value is 1
>>> +    D3 = reg value is 2
>>> +    D4 = reg value is 3
>>> +    D5 = reg value is 4
>>> +    D6 = reg value is 5
>>> +    D7 = reg value is 6
>>> +    D8 = reg value is 7
>>> +    D9 = reg value is 8
>>>     Optional properties:
>>>   - enable-gpio: GPIO attached to the chip's enable pin
>>> @@ -35,23 +49,28 @@ example 1) LP5521
>>>   on channel 0.
>>>     lp5521@32 {
>> While at it let's fix node prefix to led-controller.
>> It will not break anyone and yet it will adapt the node naming
>> to what is now recommended.
> 
> I would love to do that but honestly I prefer to fix that in a different
> patch series and not add more changes to this patch review.

ack

>>> +    #address-cells = <1>;
>>> +    #size-cells = <0>;
>>>       compatible = "national,lp5521";
>>>       reg = <0x32>;
>>>       label = "lp5521_pri";
>>>       clock-mode = /bits/ 8 <2>;
>>>   -    chan0 {
>>> +    chan@0 {
>> Similarly in case of every child node:
>>

>>> +Multicolor LED example:
>>> +lp5523: lp5523@32 {
>> Do you really need "lp5523:" node label ?
>>
>> Besides:
>>
>> s/lp5523@32/led-controller@32/
> 
> This change I will make since I added this.

Good, it was the first thing that struck me - if we're
adding new bindings they should conform to the current
standards.

-- 
Best regards,
Jacek Anaszewski