From: "Gupta, Pekon" <pekon@ti.com>
To: Lee Jones <lee.jones@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "angus.clark@st.com" <angus.clark@st.com>,
"kernel@stlinux.com" <kernel@stlinux.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"Ezequiel Garcia \(ezequiel.garcia@free-electrons.com\)"
<ezequiel.garcia@free-electrons.com>,
"computersforpeace@gmail.com" <computersforpeace@gmail.com>,
"dwmw2@infradead.org" <dwmw2@infradead.org>
Subject: RE: [RFC 43/47] mtd: nand: stm_nand_bch: read and write functions (BCH)
Date: Wed, 26 Mar 2014 10:31:14 +0000 [thread overview]
Message-ID: <20980858CB6D3A4BAE95CA194937D5E73EAB5CC7@DBDE04.ent.ti.com> (raw)
In-Reply-To: <1395735604-26706-44-git-send-email-lee.jones@linaro.org>
Hi Lee,
>From: Lee Jones [mailto:lee.jones@linaro.org]
>
>Helper function for bch_mtd_read() and bch_mtd_write() to handle
>multi-page or non-aligned reads and writes respectively.
>
>Signed-off-by: Lee Jones <lee.jones@linaro.org>
>---
I think below code is duplicate of nand_do_read_ops() and nand_do_write_ops()
in nand_base.c. If you could just populate chip->ecc.read_page and
chip->ecc.write_page much of this could be avoided.
Also, you need to break your bch_read_page() into given generic NAND
driver interfaces chip->ecc.calculate(), chip->ecc.correct() ...
This would make your driver much more simpler, and easy to maintain.
> drivers/mtd/nand/stm_nand_bch.c | 143 ++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 143 insertions(+)
>
>diff --git a/drivers/mtd/nand/stm_nand_bch.c b/drivers/mtd/nand/stm_nand_bch.c
>index 389ccee..bcaed32 100644
>--- a/drivers/mtd/nand/stm_nand_bch.c
>+++ b/drivers/mtd/nand/stm_nand_bch.c
>@@ -507,6 +507,149 @@ static uint8_t bch_write_page(struct nandi_controller *nandi,
> return status;
> }
>
>+/* Helper function for bch_mtd_read to handle multi-page or non-aligned reads */
>+static int bch_read(struct nandi_controller *nandi,
>+ loff_t from, size_t len,
>+ size_t *retlen, u_char *buf)
>+{
>+ struct mtd_ecc_stats stats;
>+ uint32_t page_size = nandi->info.mtd.writesize;
>+ uint32_t col_offs;
>+ loff_t page_mask;
>+ loff_t page_offs;
>+ int ecc_errs, max_ecc_errs = 0;
>+ int page_num;
>+ size_t bytes;
>+ uint8_t *p;
>+ bool bounce = false;
>+
>+ dev_dbg(nandi->dev, "%s: %llu @ 0x%012llx\n", __func__,
>+ (unsigned long long)len, from);
>+
>+ stats = nandi->info.mtd.ecc_stats;
>+ page_mask = (loff_t)page_size - 1;
>+ col_offs = (uint32_t)(from & page_mask);
>+ page_offs = from & ~page_mask;
>+ page_num = (int)(page_offs >> nandi->page_shift);
>+
>+ while (len > 0) {
>+ bytes = min((page_size - col_offs), len);
>+
>+ if ((bytes != page_size) ||
>+ ((unsigned int)buf & (NANDI_BCH_DMA_ALIGNMENT - 1)) ||
>+ (!virt_addr_valid(buf))) /* vmalloc'd buffer! */
>+ bounce = true;
>+
>+ if (page_num == nandi->cached_page) {
>+ memcpy(buf, nandi->page_buf + col_offs, bytes);
>+ goto done;
>+ }
>+
>+ p = bounce ? nandi->page_buf : buf;
>+
>+ ecc_errs = bch_read_page(nandi, page_offs, p);
>+ if (bounce)
>+ memcpy(buf, p + col_offs, bytes);
>+
>+ if (ecc_errs < 0) {
>+ dev_err(nandi->dev,
>+ "%s: uncorrectable error at 0x%012llx\n",
>+ __func__, page_offs);
>+ nandi->info.mtd.ecc_stats.failed++;
>+
>+ /* Do not cache uncorrectable pages */
>+ if (bounce)
>+ nandi->cached_page = -1;
>+
>+ goto done;
>+ }
>+
>+ if (ecc_errs) {
>+ dev_info(nandi->dev,
>+ "%s: corrected %u error(s) at 0x%012llx\n",
>+ __func__, ecc_errs, page_offs);
>+
>+ nandi->info.mtd.ecc_stats.corrected += ecc_errs;
>+
>+ if (ecc_errs > max_ecc_errs)
>+ max_ecc_errs = ecc_errs;
>+ }
>+
>+ if (bounce)
>+ nandi->cached_page = page_num;
>+
>+done:
>+ buf += bytes;
>+ len -= bytes;
>+
>+ if (retlen)
>+ *retlen += bytes;
>+
>+ /* We are now page-aligned */
>+ page_offs += page_size;
>+ page_num++;
>+ col_offs = 0;
>+ }
>+
>+ /* Return '-EBADMSG' on uncorrectable errors */
>+ if (nandi->info.mtd.ecc_stats.failed - stats.failed)
>+ return -EBADMSG;
>+
>+ return max_ecc_errs;
>+}
>+
>+/* Helper function for mtd_write, to handle multi-page and non-aligned writes */
>+static int bch_write(struct nandi_controller *nandi,
>+ loff_t to, size_t len,
>+ size_t *retlen, const uint8_t *buf)
>+{
>+ uint32_t page_size = nandi->info.mtd.writesize;
>+ int page_num;
>+ bool bounce = false;
>+ const uint8_t *p = NULL;
>+ uint8_t ret;
>+
>+ dev_dbg(nandi->dev, "%s: %llu @ 0x%012llx\n", __func__,
>+ (unsigned long long)len, to);
>+
>+ BUG_ON(len & (page_size - 1));
>+ BUG_ON(to & (page_size - 1));
>+
>+ if (((unsigned long)buf & (NANDI_BCH_DMA_ALIGNMENT - 1)) ||
>+ !virt_addr_valid(buf)) { /* vmalloc'd buffer! */
>+ bounce = true;
>+ }
>+
>+ page_num = (int)(to >> nandi->page_shift);
>+
>+ while (len > 0) {
>+ if (bounce) {
>+ memcpy(nandi->page_buf, buf, page_size);
>+ p = nandi->page_buf;
>+ nandi->cached_page = -1;
>+ } else {
>+ p = buf;
>+ }
>+
>+ if (nandi->cached_page == page_num)
>+ nandi->cached_page = -1;
>+
>+ ret = bch_write_page(nandi, to, p);
>+ if (ret & NAND_STATUS_FAIL)
>+ return -EIO;
>+
>+ to += page_size;
>+ page_num++;
>+ buf += page_size;
>+ len -= page_size;
>+
>+ if (retlen)
>+ *retlen += page_size;
>+ }
>+
>+ return 0;
>+}
>+
> /*
> * Hamming-FLEX operations
> */
>--
>1.8.3.2
with regards, pekon
next prev parent reply other threads:[~2014-03-26 10:31 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 8:19 [RFC 00/47] mtd: nand: Add new driver supporting ST's BCH h/w Lee Jones
2014-03-25 8:19 ` [RFC 01/47] mtd: nand: export useful functions from core driver Lee Jones
2014-03-25 12:57 ` Ezequiel Garcia
2014-03-25 14:58 ` Lee Jones
2014-03-25 8:19 ` [RFC 02/47] mtd: nand: add ONFI NAND Timing Mode Specifications Lee Jones
2014-03-25 17:01 ` Jason Gunthorpe
2014-03-25 8:19 ` [RFC 03/47] mtd: nand: add shared register defines for ST's NAND Controller drivers Lee Jones
2014-03-25 8:19 ` [RFC 04/47] mtd: nand: adding ST's BCH NAND Controller driver Lee Jones
2014-03-25 8:19 ` [RFC 05/47] mtd: nand: stm_nand_bch: IRQ support for " Lee Jones
2014-03-26 7:10 ` Gupta, Pekon
2014-03-25 8:19 ` [RFC 06/47] mtd: nand: stm_nand_bch: change between BCH and Hamming modes Lee Jones
2014-03-25 8:19 ` [RFC 07/47] mtd: nand: stm_nand_bch: initialise the BCH Controller Lee Jones
2014-03-26 10:25 ` Gupta, Pekon
2014-04-30 10:22 ` Lee Jones
2014-04-30 10:59 ` Gupta, Pekon
2014-04-30 12:29 ` Lee Jones
2014-03-25 8:19 ` [RFC 08/47] mtd: nand: stm_nand_bch: supply clock support Lee Jones
2014-03-26 7:15 ` Gupta, Pekon
2014-03-25 8:19 ` [RFC 09/47] mtd: nand: stm_nand_bch: introduce and initialise some important data structures Lee Jones
2014-03-25 8:19 ` [RFC 10/47] mtd: nand: stm_nand_bch: initialise the Hamming Controller Lee Jones
2014-03-25 8:19 ` [RFC 11/47] mtd: nand: stm_nand_bch: add Power Management Lee Jones
2014-03-25 8:19 ` [RFC 12/47] mtd: nand: stm_nand_bch: scan for NAND devices Lee Jones
2014-03-25 8:19 ` [RFC 13/47] mtd: nand: stm_nand_bch: provide Device Tree support Lee Jones
2014-03-26 9:18 ` Gupta, Pekon
2014-04-30 12:54 ` Lee Jones
2014-05-05 6:55 ` Gupta, Pekon
2014-05-09 10:03 ` Lee Jones
2014-05-09 10:32 ` Gupta, Pekon
2014-05-09 10:38 ` Lee Jones
2014-05-19 14:02 ` Lee Jones
2014-03-25 8:19 ` [RFC 14/47] mtd: nand: stm_nand_bch: configure BCH and FLEX by ONFI timing mode Lee Jones
2014-03-25 8:19 ` [RFC 15/47] mtd: nand: stm_nand_bch: add compatible page size check Lee Jones
2014-03-25 8:19 ` [RFC 16/47] mtd: nand: stm_nand_bch: derive some working variables for latter use Lee Jones
2014-03-25 8:19 ` [RFC 17/47] mtd: nand: stm_nand_bch: automatically set EEC mode if requested Lee Jones
2014-03-25 8:19 ` [RFC 18/47] mtd: nand: stm_nand_bch: ensure configuration is compatible with this driver Lee Jones
2014-03-25 8:19 ` [RFC 19/47] mtd: nand: stm_nand_bch: configure BCH read/write/erase programs Lee Jones
2014-03-25 8:19 ` [RFC 20/47] mtd: nand: stm_nand_bch: initialise working buffers Lee Jones
2014-03-25 8:19 ` [RFC 21/47] mtd: nand: stm_nand_bch: provide shared BCH operations Lee Jones
2014-03-25 8:19 ` [RFC 22/47] mtd: nand: stm_nand_bch: check erased page for zeros Lee Jones
2014-03-25 8:19 ` [RFC 23/47] mtd: nand: stm_nand_bch: read and write page (BCH) Lee Jones
2014-03-26 10:17 ` Gupta, Pekon
2014-04-30 11:19 ` Lee Jones
2014-03-25 8:19 ` [RFC 24/47] mtd: nand: stm_nand_bch: find IBBT signature Lee Jones
2014-03-25 8:19 ` [RFC 25/47] mtd: nand: stm_nand_bch: bad block marking helpers Lee Jones
2014-03-25 8:19 ` [RFC 26/47] mtd: nand: stm_nand_bch: populate IBBT BCH Header Lee Jones
2014-03-25 8:19 ` [RFC 27/47] mtd: nand: stm_nand_bch: write IBBT to Flash Lee Jones
2014-03-25 8:19 ` [RFC 28/47] mtd: nand: stm_nand_bch: update flash-resident BBT(s) Lee Jones
2014-03-25 8:19 ` [RFC 29/47] mtd: nand: stm_nand_bch: add Hamming-FLEX operations Lee Jones
2014-03-25 8:19 ` [RFC 30/47] mtd: nand: stm_nand_bch: read and write raw (FLEX) Lee Jones
2014-03-25 8:19 ` [RFC 31/47] mtd: nand: stm_nand_bch: scan block for BBM(s) according to specified BBT options Lee Jones
2014-03-25 8:19 ` [RFC 32/47] mtd: nand: stm_nand_bch: scan for BBMs and build memory-resident BBT Lee Jones
2014-03-25 8:19 ` [RFC 33/47] mtd: nand: stm_nand_bch: search for and load flash-resident BBT Lee Jones
2014-03-25 8:19 ` [RFC 34/47] mtd: nand: stm_nand_bch: " Lee Jones
2014-03-25 8:19 ` [RFC 35/47] mtd: nand: stm_nand_bch: dump bad blocks Lee Jones
2014-03-25 12:53 ` Ezequiel Garcia
2014-03-25 8:19 ` [RFC 36/47] mtd: nand: stm_nand_bch: parse partitions and register an MTD device Lee Jones
2014-03-25 8:19 ` [RFC 37/47] mtd: nand: stm_nand_bch: fetch the bit-flips threshold Lee Jones
2014-03-25 8:19 ` [RFC 38/47] mtd: nand: stm_nand_bch: check WP (FLEX) Lee Jones
2014-03-25 8:19 ` [RFC 39/47] mtd: nand: stm_nand_bch: read and write ops (FLEX) Lee Jones
2014-03-25 8:19 ` [RFC 40/47] mtd: nand: stm_nand_bch: MTD erase (BCH) Lee Jones
2014-03-25 8:19 ` [RFC 41/47] mtd: nand: stm_nand_bch: MTD mark and check for bad blocks (BCH) Lee Jones
2014-03-25 8:19 ` [RFC 42/47] mtd: nand: stm_nand_bch: add read and write OOB (BCH) Lee Jones
2014-03-25 8:20 ` [RFC 43/47] mtd: nand: stm_nand_bch: read and write functions (BCH) Lee Jones
2014-03-26 10:31 ` Gupta, Pekon [this message]
2014-04-30 9:19 ` Lee Jones
2014-03-25 8:20 ` [RFC 44/47] mtd: nand: stm_nand_bch: MTD read and write (BCH) Lee Jones
2014-03-25 8:20 ` [RFC 45/47] mtd: nand: stm_nand_bch: read and write buffers (FLEX) Lee Jones
2014-03-25 8:20 ` [RFC 46/47] mtd: nand: mtd_nand_bch: add remaining FLEX functions Lee Jones
2014-03-25 8:20 ` [RFC 47/47] mtd: nand: stm_nand_bch: catch unsupported calls Lee Jones
2014-03-25 12:50 ` [RFC 00/47] mtd: nand: Add new driver supporting ST's BCH h/w Ezequiel Garcia
2014-03-25 13:11 ` Lee Jones
2014-03-25 22:00 ` Ezequiel Garcia
2014-03-26 7:28 ` Brian Norris
2014-03-27 10:28 ` Lee Jones
2014-04-01 11:29 ` Lee Jones
2014-04-10 20:00 ` Brian Norris
2014-04-30 9:57 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20980858CB6D3A4BAE95CA194937D5E73EAB5CC7@DBDE04.ent.ti.com \
--to=pekon@ti.com \
--cc=angus.clark@st.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=kernel@stlinux.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).