From: Manikanta Maddireddy <mmaddireddy@nvidia.com> To: Thierry Reding <thierry.reding@gmail.com> Cc: <bhelgaas@google.com>, <robh+dt@kernel.org>, <mark.rutland@arm.com>, <jonathanh@nvidia.com>, <lorenzo.pieralisi@arm.com>, <vidyas@nvidia.com>, <linux-tegra@vger.kernel.org>, <linux-pci@vger.kernel.org>, <devicetree@vger.kernel.org> Subject: Re: [PATCH 21/30] PCI: tegra: Add "pci" type check before parsing child device tree node Date: Mon, 15 Apr 2019 21:00:58 +0530 Message-ID: <059fd53c-8a53-be56-a5bc-393f37aae168@nvidia.com> (raw) In-Reply-To: <20190415133715.GV29254@ulmo> On 15-Apr-19 7:07 PM, Thierry Reding wrote: > On Thu, Apr 11, 2019 at 10:33:46PM +0530, Manikanta Maddireddy wrote: >> Each root port is added as a child device tree node of PCIe controller >> node. These child nodes are parsed using open firmware PCI bus accessor >> functions. If the child node is not of "pci" type then device tree >> parsing fails. Add "pci" type check before parsing child device tree node. >> >> Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com> >> --- >> drivers/pci/controller/pci-tegra.c | 3 +++ >> 1 file changed, 3 insertions(+) > Erm... what is the use-case that you're trying to support? Why would we > ever have children nodes that are not of type "pci"? > > Thierry In downstream kernel we have "prod-settings" node as one of the child nodes. Even though we are not supporting this in upstream kernel, I believe this check is good to have. Manikanta >> diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c >> index 8fdc7934d4c9..d08a63132c77 100644 >> --- a/drivers/pci/controller/pci-tegra.c >> +++ b/drivers/pci/controller/pci-tegra.c >> @@ -2197,6 +2197,9 @@ static int tegra_pcie_parse_dt(struct tegra_pcie *pcie) >> unsigned int index; >> u32 value; >> >> + if (!of_node_is_type(port, "pci")) >> + continue; >> + >> err = of_pci_get_devfn(port); >> if (err < 0) { >> dev_err(dev, "failed to parse address: %d\n", err); >> -- >> 2.17.1 >>
next prev parent reply index Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-11 17:03 [PATCH 00/30] Enable Tegra PCIe root port features Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 01/30] soc/tegra: pmc: Export tegra_powergate_power_on() Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 02/30] PCI: tegra: Fix PCIe host power up sequence Manikanta Maddireddy 2019-04-15 11:01 ` Thierry Reding 2019-04-15 14:11 ` Manikanta Maddireddy 2019-04-15 14:30 ` Thierry Reding 2019-04-15 18:14 ` Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 03/30] PCI: tegra: Move REFCLK pad settings out of phy_power_on() Manikanta Maddireddy 2019-04-15 11:06 ` Thierry Reding 2019-04-15 14:20 ` Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 04/30] PCI: tegra: Add PCIe Gen2 link speed support Manikanta Maddireddy 2019-04-15 11:21 ` Thierry Reding 2019-04-15 14:47 ` Manikanta Maddireddy 2019-04-15 15:36 ` Thierry Reding 2019-04-15 15:53 ` Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 05/30] PCI: tegra: Advertise PCIe Advanced Error Reporting (AER) capability Manikanta Maddireddy 2019-04-15 11:23 ` Thierry Reding 2019-04-15 14:49 ` Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 06/30] PCI: tegra: Program UPHY electrical settings for Tegra210 Manikanta Maddireddy 2019-04-15 11:29 ` Thierry Reding 2019-04-15 14:55 ` Manikanta Maddireddy 2019-04-15 15:38 ` Thierry Reding 2019-04-11 17:03 ` [PATCH 07/30] PCI: tegra: Enable opportunistic update FC and ACK Manikanta Maddireddy 2019-04-15 11:30 ` Thierry Reding 2019-04-11 17:03 ` [PATCH 08/30] PCI: tegra: Disable AFI dynamic clock gating Manikanta Maddireddy 2019-04-15 11:32 ` Thierry Reding 2019-04-11 17:03 ` [PATCH 09/30] PCI: tegra: Process pending DLL transactions before entering L1 or L2 Manikanta Maddireddy 2019-04-15 11:33 ` Thierry Reding 2019-04-11 17:03 ` [PATCH 10/30] PCI: tegra: Enable PCIe xclk clock clamping Manikanta Maddireddy 2019-04-15 11:37 ` Thierry Reding 2019-04-15 14:58 ` Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 11/30] PCI: tegra: Increase the deskew retry time Manikanta Maddireddy 2019-04-15 11:39 ` Thierry Reding 2019-04-15 14:58 ` Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 12/30] PCI: tegra: Add SW fixup for RAW violations Manikanta Maddireddy 2019-04-11 20:01 ` Bjorn Helgaas 2019-04-12 5:59 ` Manikanta Maddireddy 2019-04-15 11:41 ` Thierry Reding 2019-04-15 11:45 ` Thierry Reding 2019-04-15 15:02 ` Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 13/30] PCI: tegra: Update flow control threshold in Tegra210 Manikanta Maddireddy 2019-04-15 11:47 ` Thierry Reding 2019-04-15 15:05 ` Manikanta Maddireddy 2019-04-23 9:27 ` Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 14/30] PCI: tegra: Set target speed as Gen1 before link up Manikanta Maddireddy 2019-04-11 20:04 ` Bjorn Helgaas 2019-04-12 6:44 ` Manikanta Maddireddy 2019-04-12 14:35 ` Bjorn Helgaas 2019-04-15 10:43 ` Manikanta Maddireddy 2019-04-15 11:52 ` Thierry Reding 2019-04-15 15:12 ` Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 15/30] PCI: tegra: Fix PLLE powerdown issue due to CLKREQ# signal Manikanta Maddireddy 2019-04-15 13:17 ` Thierry Reding 2019-04-15 15:14 ` Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 16/30] PCI: tegra: Program AFI_CACHE* registers only for Tegra20 Manikanta Maddireddy 2019-04-15 13:20 ` Thierry Reding 2019-04-16 10:47 ` Manikanta Maddireddy 2019-04-16 16:11 ` Thierry Reding 2019-04-11 17:03 ` [PATCH 17/30] PCI: tegra: Use switch statements in tegra_pcie_isr() Manikanta Maddireddy 2019-04-15 13:25 ` Thierry Reding 2019-04-15 15:25 ` Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 18/30] PCI: tegra: Change PRSNT_SENSE irq log to debug Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 19/30] PCI: tegra: Use legacy irq for port service drivers Manikanta Maddireddy 2019-04-15 13:35 ` Thierry Reding 2019-04-11 17:03 ` [PATCH 20/30] PCI: tegra: Add AFI_PEX2_CTRL reg offset as part of soc struct Manikanta Maddireddy 2019-04-15 13:31 ` Thierry Reding 2019-04-11 17:03 ` [PATCH 21/30] PCI: tegra: Add "pci" type check before parsing child device tree node Manikanta Maddireddy 2019-04-15 13:37 ` Thierry Reding 2019-04-15 15:30 ` Manikanta Maddireddy [this message] 2019-04-15 15:42 ` Thierry Reding 2019-04-11 17:03 ` [PATCH 22/30] PCI: tegra: Access endpoint config only if PCIe link is up Manikanta Maddireddy 2019-04-11 20:15 ` Bjorn Helgaas 2019-04-12 7:00 ` Manikanta Maddireddy 2019-04-12 14:50 ` Bjorn Helgaas 2019-04-15 11:36 ` Manikanta Maddireddy 2019-04-15 13:45 ` Thierry Reding 2019-04-15 13:52 ` Thierry Reding 2019-04-15 14:04 ` Bjorn Helgaas 2019-04-15 15:43 ` Manikanta Maddireddy 2019-04-23 20:24 ` Bjorn Helgaas 2019-04-11 17:03 ` [PATCH 23/30] dt-bindings: pci: tegra: Document PCIe DPD pinctrl optional prop Manikanta Maddireddy 2019-04-15 14:07 ` Thierry Reding 2019-04-15 15:48 ` Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 24/30] arm64: tegra: Add PEX DPD states as pinctrl properties Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 25/30] PCI: tegra: Put PEX CLK & BIAS pads in DPD mode Manikanta Maddireddy 2019-04-15 14:11 ` Thierry Reding 2019-04-11 17:03 ` [PATCH 26/30] dt-bindings: pci: tegra: Document nvidia,plat-gpios optional prop Manikanta Maddireddy 2019-04-11 20:18 ` Bjorn Helgaas 2019-04-12 7:01 ` Manikanta Maddireddy 2019-04-15 14:16 ` Thierry Reding 2019-04-15 17:58 ` Manikanta Maddireddy 2019-04-16 15:34 ` Thierry Reding 2019-04-17 11:22 ` Manikanta Maddireddy 2019-04-17 15:19 ` Thierry Reding 2019-04-17 18:26 ` Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 27/30] PCI: tegra: Add support to configure platform GPIOs Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 28/30] dt-bindings: pci: tegra: Document nvidia,rst-gpio optional prop Manikanta Maddireddy 2019-04-15 14:20 ` Thierry Reding 2019-04-15 18:01 ` Manikanta Maddireddy 2019-04-29 18:33 ` Rob Herring 2019-04-11 17:03 ` [PATCH 29/30] PCI: tegra: Add support for GPIO based PCIe reset Manikanta Maddireddy 2019-04-15 14:20 ` Thierry Reding 2019-04-15 18:03 ` Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 30/30] PCI: tegra: Change link retry log level to INFO Manikanta Maddireddy 2019-04-15 14:23 ` Thierry Reding 2019-04-15 18:05 ` Manikanta Maddireddy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=059fd53c-8a53-be56-a5bc-393f37aae168@nvidia.com \ --to=mmaddireddy@nvidia.com \ --cc=bhelgaas@google.com \ --cc=devicetree@vger.kernel.org \ --cc=jonathanh@nvidia.com \ --cc=linux-pci@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=thierry.reding@gmail.com \ --cc=vidyas@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-PCI Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-pci/0 linux-pci/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-pci linux-pci/ https://lore.kernel.org/linux-pci \ linux-pci@vger.kernel.org public-inbox-index linux-pci Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pci AGPL code for this site: git clone https://public-inbox.org/public-inbox.git