From: Manikanta Maddireddy <mmaddireddy@nvidia.com> To: <thierry.reding@gmail.com>, <bhelgaas@google.com>, <robh+dt@kernel.org>, <mark.rutland@arm.com>, <jonathanh@nvidia.com>, <lorenzo.pieralisi@arm.com>, <vidyas@nvidia.com> Cc: <linux-tegra@vger.kernel.org>, <linux-pci@vger.kernel.org>, <devicetree@vger.kernel.org>, Manikanta Maddireddy <mmaddireddy@nvidia.com> Subject: [PATCH 25/30] PCI: tegra: Put PEX CLK & BIAS pads in DPD mode Date: Thu, 11 Apr 2019 22:33:50 +0530 Message-ID: <20190411170355.6882-26-mmaddireddy@nvidia.com> (raw) In-Reply-To: <20190411170355.6882-1-mmaddireddy@nvidia.com> In Tegra210 AFI design has clamp value for the BIAS pad as 0, which keeps the bias pad in non power down mode. This is leading to power consumption of 2 mW in BIAS pad, even if the PCIe partition is power gated. To avoid unnecessary power consumption, put PEX CLK & BIAS pads in deep power down mode when PCIe partition is power gated. Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com> --- drivers/pci/controller/pci-tegra.c | 65 +++++++++++++++++++++++++++++- 1 file changed, 64 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c index c050687020f0..92c6daa0de84 100644 --- a/drivers/pci/controller/pci-tegra.c +++ b/drivers/pci/controller/pci-tegra.c @@ -30,6 +30,7 @@ #include <linux/of_platform.h> #include <linux/pci.h> #include <linux/phy/phy.h> +#include <linux/pinctrl/consumer.h> #include <linux/platform_device.h> #include <linux/reset.h> #include <linux/sizes.h> @@ -323,6 +324,7 @@ struct tegra_pcie_soc { bool program_deskew_time; bool raw_violation_fixup; bool update_fc_threshold; + bool config_pex_io_dpd; struct { struct { u32 rp_ectl_2_r1; @@ -385,6 +387,10 @@ struct tegra_pcie { const struct tegra_pcie_soc *soc; struct dentry *debugfs; + + struct pinctrl *pex_pinctrl; + struct pinctrl_state *pex_dpd_enable; + struct pinctrl_state *pex_dpd_disable; }; struct tegra_pcie_port { @@ -2154,6 +2160,37 @@ static int tegra_pcie_get_regulators(struct tegra_pcie *pcie, u32 lane_mask) return tegra_pcie_get_legacy_regulators(pcie); } +static int tegra_pcie_parse_pinctrl(struct tegra_pcie *pcie) +{ + struct device *dev = pcie->dev; + int err = 0; + + pcie->pex_pinctrl = devm_pinctrl_get(dev); + if (IS_ERR(pcie->pex_pinctrl)) { + err = PTR_ERR(pcie->pex_pinctrl); + dev_err(dev, "failed to get pinctrl handle: %d\n", err); + return err; + } + + pcie->pex_dpd_enable = pinctrl_lookup_state(pcie->pex_pinctrl, + "pex-dpd-enable"); + if (IS_ERR(pcie->pex_dpd_enable)) { + err = PTR_ERR(pcie->pex_dpd_enable); + dev_err(dev, "missing pex-dpd-enable state: %d\n", err); + return err; + } + + pcie->pex_dpd_disable = pinctrl_lookup_state(pcie->pex_pinctrl, + "pex-dpd-disable"); + if (IS_ERR(pcie->pex_dpd_disable)) { + err = PTR_ERR(pcie->pex_dpd_disable); + dev_err(dev, "missing pex-dpd-disable state: %d\n", err); + return err; + } + + return err; +} + static int tegra_pcie_parse_dt(struct tegra_pcie *pcie) { struct device *dev = pcie->dev; @@ -2496,6 +2533,7 @@ static const struct tegra_pcie_soc tegra20_pcie = { .program_deskew_time = false, .raw_violation_fixup = false, .update_fc_threshold = false, + .config_pex_io_dpd = false, .ectl.enable = false, }; @@ -2524,6 +2562,7 @@ static const struct tegra_pcie_soc tegra30_pcie = { .program_deskew_time = false, .raw_violation_fixup = false, .update_fc_threshold = false, + .config_pex_io_dpd = false, .ectl.enable = false, }; @@ -2547,6 +2586,7 @@ static const struct tegra_pcie_soc tegra124_pcie = { .program_deskew_time = false, .raw_violation_fixup = true, .update_fc_threshold = false, + .config_pex_io_dpd = false, .ectl.enable = false, }; @@ -2570,6 +2610,7 @@ static const struct tegra_pcie_soc tegra210_pcie = { .program_deskew_time = true, .raw_violation_fixup = false, .update_fc_threshold = true, + .config_pex_io_dpd = true, .ectl.regs.rp_ectl_2_r1 = 0x0000000f, .ectl.regs.rp_ectl_4_r1 = 0x00000067, .ectl.regs.rp_ectl_5_r1 = 0x55010000, @@ -2607,6 +2648,7 @@ static const struct tegra_pcie_soc tegra186_pcie = { .program_deskew_time = false, .raw_violation_fixup = false, .update_fc_threshold = false, + .config_pex_io_dpd = false, .ectl.enable = false, }; @@ -2753,6 +2795,12 @@ static int tegra_pcie_probe(struct platform_device *pdev) INIT_LIST_HEAD(&pcie->ports); pcie->dev = dev; + if (pcie->soc->config_pex_io_dpd) { + err = tegra_pcie_parse_pinctrl(pcie); + if (err < 0) + return err; + } + err = tegra_pcie_parse_dt(pcie); if (err < 0) return err; @@ -2866,6 +2914,8 @@ static int __maybe_unused tegra_pcie_pm_suspend(struct device *dev) tegra_pcie_disable_msi(pcie); tegra_pcie_disable_controller(pcie); + if (pcie->soc->config_pex_io_dpd) + pinctrl_select_state(pcie->pex_pinctrl, pcie->pex_dpd_enable); tegra_pcie_power_off(pcie); return 0; @@ -2881,10 +2931,20 @@ static int __maybe_unused tegra_pcie_pm_resume(struct device *dev) dev_err(dev, "tegra pcie power on fail: %d\n", err); return err; } + + if (pcie->soc->config_pex_io_dpd) { + err = pinctrl_select_state(pcie->pex_pinctrl, + pcie->pex_dpd_disable); + if (err < 0) { + dev_err(dev, "disabling PCIe IO DPD failed: %d\n", err); + goto poweroff; + } + } + err = tegra_pcie_enable_controller(pcie); if (err) { dev_err(dev, "tegra pcie controller enable fail: %d\n", err); - goto poweroff; + goto pex_dpd_enable; } tegra_pcie_setup_translations(pcie); @@ -2904,6 +2964,9 @@ static int __maybe_unused tegra_pcie_pm_resume(struct device *dev) disable_controller: tegra_pcie_disable_controller(pcie); +pex_dpd_enable: + if (pcie->soc->config_pex_io_dpd) + pinctrl_select_state(pcie->pex_pinctrl, pcie->pex_dpd_enable); poweroff: tegra_pcie_power_off(pcie); -- 2.17.1
next prev parent reply index Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-11 17:03 [PATCH 00/30] Enable Tegra PCIe root port features Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 01/30] soc/tegra: pmc: Export tegra_powergate_power_on() Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 02/30] PCI: tegra: Fix PCIe host power up sequence Manikanta Maddireddy 2019-04-15 11:01 ` Thierry Reding 2019-04-15 14:11 ` Manikanta Maddireddy 2019-04-15 14:30 ` Thierry Reding 2019-04-15 18:14 ` Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 03/30] PCI: tegra: Move REFCLK pad settings out of phy_power_on() Manikanta Maddireddy 2019-04-15 11:06 ` Thierry Reding 2019-04-15 14:20 ` Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 04/30] PCI: tegra: Add PCIe Gen2 link speed support Manikanta Maddireddy 2019-04-15 11:21 ` Thierry Reding 2019-04-15 14:47 ` Manikanta Maddireddy 2019-04-15 15:36 ` Thierry Reding 2019-04-15 15:53 ` Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 05/30] PCI: tegra: Advertise PCIe Advanced Error Reporting (AER) capability Manikanta Maddireddy 2019-04-15 11:23 ` Thierry Reding 2019-04-15 14:49 ` Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 06/30] PCI: tegra: Program UPHY electrical settings for Tegra210 Manikanta Maddireddy 2019-04-15 11:29 ` Thierry Reding 2019-04-15 14:55 ` Manikanta Maddireddy 2019-04-15 15:38 ` Thierry Reding 2019-04-11 17:03 ` [PATCH 07/30] PCI: tegra: Enable opportunistic update FC and ACK Manikanta Maddireddy 2019-04-15 11:30 ` Thierry Reding 2019-04-11 17:03 ` [PATCH 08/30] PCI: tegra: Disable AFI dynamic clock gating Manikanta Maddireddy 2019-04-15 11:32 ` Thierry Reding 2019-04-11 17:03 ` [PATCH 09/30] PCI: tegra: Process pending DLL transactions before entering L1 or L2 Manikanta Maddireddy 2019-04-15 11:33 ` Thierry Reding 2019-04-11 17:03 ` [PATCH 10/30] PCI: tegra: Enable PCIe xclk clock clamping Manikanta Maddireddy 2019-04-15 11:37 ` Thierry Reding 2019-04-15 14:58 ` Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 11/30] PCI: tegra: Increase the deskew retry time Manikanta Maddireddy 2019-04-15 11:39 ` Thierry Reding 2019-04-15 14:58 ` Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 12/30] PCI: tegra: Add SW fixup for RAW violations Manikanta Maddireddy 2019-04-11 20:01 ` Bjorn Helgaas 2019-04-12 5:59 ` Manikanta Maddireddy 2019-04-15 11:41 ` Thierry Reding 2019-04-15 11:45 ` Thierry Reding 2019-04-15 15:02 ` Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 13/30] PCI: tegra: Update flow control threshold in Tegra210 Manikanta Maddireddy 2019-04-15 11:47 ` Thierry Reding 2019-04-15 15:05 ` Manikanta Maddireddy 2019-04-23 9:27 ` Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 14/30] PCI: tegra: Set target speed as Gen1 before link up Manikanta Maddireddy 2019-04-11 20:04 ` Bjorn Helgaas 2019-04-12 6:44 ` Manikanta Maddireddy 2019-04-12 14:35 ` Bjorn Helgaas 2019-04-15 10:43 ` Manikanta Maddireddy 2019-04-15 11:52 ` Thierry Reding 2019-04-15 15:12 ` Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 15/30] PCI: tegra: Fix PLLE powerdown issue due to CLKREQ# signal Manikanta Maddireddy 2019-04-15 13:17 ` Thierry Reding 2019-04-15 15:14 ` Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 16/30] PCI: tegra: Program AFI_CACHE* registers only for Tegra20 Manikanta Maddireddy 2019-04-15 13:20 ` Thierry Reding 2019-04-16 10:47 ` Manikanta Maddireddy 2019-04-16 16:11 ` Thierry Reding 2019-04-11 17:03 ` [PATCH 17/30] PCI: tegra: Use switch statements in tegra_pcie_isr() Manikanta Maddireddy 2019-04-15 13:25 ` Thierry Reding 2019-04-15 15:25 ` Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 18/30] PCI: tegra: Change PRSNT_SENSE irq log to debug Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 19/30] PCI: tegra: Use legacy irq for port service drivers Manikanta Maddireddy 2019-04-15 13:35 ` Thierry Reding 2019-04-11 17:03 ` [PATCH 20/30] PCI: tegra: Add AFI_PEX2_CTRL reg offset as part of soc struct Manikanta Maddireddy 2019-04-15 13:31 ` Thierry Reding 2019-04-11 17:03 ` [PATCH 21/30] PCI: tegra: Add "pci" type check before parsing child device tree node Manikanta Maddireddy 2019-04-15 13:37 ` Thierry Reding 2019-04-15 15:30 ` Manikanta Maddireddy 2019-04-15 15:42 ` Thierry Reding 2019-04-11 17:03 ` [PATCH 22/30] PCI: tegra: Access endpoint config only if PCIe link is up Manikanta Maddireddy 2019-04-11 20:15 ` Bjorn Helgaas 2019-04-12 7:00 ` Manikanta Maddireddy 2019-04-12 14:50 ` Bjorn Helgaas 2019-04-15 11:36 ` Manikanta Maddireddy 2019-04-15 13:45 ` Thierry Reding 2019-04-15 13:52 ` Thierry Reding 2019-04-15 14:04 ` Bjorn Helgaas 2019-04-15 15:43 ` Manikanta Maddireddy 2019-04-23 20:24 ` Bjorn Helgaas 2019-04-11 17:03 ` [PATCH 23/30] dt-bindings: pci: tegra: Document PCIe DPD pinctrl optional prop Manikanta Maddireddy 2019-04-15 14:07 ` Thierry Reding 2019-04-15 15:48 ` Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 24/30] arm64: tegra: Add PEX DPD states as pinctrl properties Manikanta Maddireddy 2019-04-11 17:03 ` Manikanta Maddireddy [this message] 2019-04-15 14:11 ` [PATCH 25/30] PCI: tegra: Put PEX CLK & BIAS pads in DPD mode Thierry Reding 2019-04-11 17:03 ` [PATCH 26/30] dt-bindings: pci: tegra: Document nvidia,plat-gpios optional prop Manikanta Maddireddy 2019-04-11 20:18 ` Bjorn Helgaas 2019-04-12 7:01 ` Manikanta Maddireddy 2019-04-15 14:16 ` Thierry Reding 2019-04-15 17:58 ` Manikanta Maddireddy 2019-04-16 15:34 ` Thierry Reding 2019-04-17 11:22 ` Manikanta Maddireddy 2019-04-17 15:19 ` Thierry Reding 2019-04-17 18:26 ` Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 27/30] PCI: tegra: Add support to configure platform GPIOs Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 28/30] dt-bindings: pci: tegra: Document nvidia,rst-gpio optional prop Manikanta Maddireddy 2019-04-15 14:20 ` Thierry Reding 2019-04-15 18:01 ` Manikanta Maddireddy 2019-04-29 18:33 ` Rob Herring 2019-04-11 17:03 ` [PATCH 29/30] PCI: tegra: Add support for GPIO based PCIe reset Manikanta Maddireddy 2019-04-15 14:20 ` Thierry Reding 2019-04-15 18:03 ` Manikanta Maddireddy 2019-04-11 17:03 ` [PATCH 30/30] PCI: tegra: Change link retry log level to INFO Manikanta Maddireddy 2019-04-15 14:23 ` Thierry Reding 2019-04-15 18:05 ` Manikanta Maddireddy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190411170355.6882-26-mmaddireddy@nvidia.com \ --to=mmaddireddy@nvidia.com \ --cc=bhelgaas@google.com \ --cc=devicetree@vger.kernel.org \ --cc=jonathanh@nvidia.com \ --cc=linux-pci@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=thierry.reding@gmail.com \ --cc=vidyas@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-PCI Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-pci/0 linux-pci/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-pci linux-pci/ https://lore.kernel.org/linux-pci \ linux-pci@vger.kernel.org public-inbox-index linux-pci Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pci AGPL code for this site: git clone https://public-inbox.org/public-inbox.git