From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Manikanta Maddireddy <mmaddireddy@nvidia.com>
Cc: thierry.reding@gmail.com, bhelgaas@google.com,
robh+dt@kernel.org, mark.rutland@arm.com, jonathanh@nvidia.com,
vidyas@nvidia.com, linux-tegra@vger.kernel.org,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH V6 06/27] PCI: tegra: Add PCIe Gen2 link speed support
Date: Thu, 20 Jun 2019 15:32:51 +0100 [thread overview]
Message-ID: <20190620143251.GB31996@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <20190618180206.4908-7-mmaddireddy@nvidia.com>
On Tue, Jun 18, 2019 at 11:31:45PM +0530, Manikanta Maddireddy wrote:
> Tegra124, Tegra132, Tegra210 and Tegra186 support Gen2 link speed. After
> PCIe link is up in Gen1, set target link speed as Gen2 and retrain link.
> Link switches to Gen2 speed if Gen2 capable end point is connected, else
> link stays in Gen1.
>
> Per PCIe 4.0r0.9 sec 7.6.3.7 implementation note, driver need to wait for
> PCIe LTSSM to come back from recovery before retraining the link.
>
> Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
> Acked-by: Thierry Reding <treding@nvidia.com>
> ---
> V6: No change
>
> V5: No change
>
> V4: No change
>
> V3: Added blank line after each while loop.
>
> V2: Changed "for loop" to "while", to make it compact and handled coding
> style comments.
>
> drivers/pci/controller/pci-tegra.c | 64 ++++++++++++++++++++++++++++++
> 1 file changed, 64 insertions(+)
>
> diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
> index 5e9fcef5f8eb..5d19067f7193 100644
> --- a/drivers/pci/controller/pci-tegra.c
> +++ b/drivers/pci/controller/pci-tegra.c
> @@ -191,6 +191,8 @@
> #define RP_LINK_CONTROL_STATUS_DL_LINK_ACTIVE 0x20000000
> #define RP_LINK_CONTROL_STATUS_LINKSTAT_MASK 0x3fff0000
>
> +#define RP_LINK_CONTROL_STATUS_2 0x000000b0
> +
> #define PADS_CTL_SEL 0x0000009c
>
> #define PADS_CTL 0x000000a0
> @@ -226,6 +228,7 @@
> #define PADS_REFCLK_CFG_DRVI_SHIFT 12 /* 15:12 */
>
> #define PME_ACK_TIMEOUT 10000
> +#define LINK_RETRAIN_TIMEOUT 100000 /* in usec */
>
> struct tegra_msi {
> struct msi_controller chip;
> @@ -2089,6 +2092,64 @@ static bool tegra_pcie_port_check_link(struct tegra_pcie_port *port)
> return false;
> }
>
> +static void tegra_pcie_change_link_speed(struct tegra_pcie *pcie)
> +{
> + struct device *dev = pcie->dev;
> + struct tegra_pcie_port *port, *tmp;
> + ktime_t deadline;
> + u32 value;
> +
> + list_for_each_entry_safe(port, tmp, &pcie->ports, list) {
And the reason to use the _safe version is ?
Lorenzo
> + /*
> + * "Supported Link Speeds Vector" in "Link Capabilities 2"
> + * is not supported by Tegra. tegra_pcie_change_link_speed()
> + * is called only for Tegra chips which support Gen2.
> + * So there no harm if supported link speed is not verified.
> + */
> + value = readl(port->base + RP_LINK_CONTROL_STATUS_2);
> + value &= ~PCI_EXP_LNKSTA_CLS;
> + value |= PCI_EXP_LNKSTA_CLS_5_0GB;
> + writel(value, port->base + RP_LINK_CONTROL_STATUS_2);
> +
> + /*
> + * Poll until link comes back from recovery to avoid race
> + * condition.
> + */
> + deadline = ktime_add_us(ktime_get(), LINK_RETRAIN_TIMEOUT);
> +
> + while (ktime_before(ktime_get(), deadline)) {
> + value = readl(port->base + RP_LINK_CONTROL_STATUS);
> + if ((value & PCI_EXP_LNKSTA_LT) == 0)
> + break;
> +
> + usleep_range(2000, 3000);
> + }
> +
> + if (value & PCI_EXP_LNKSTA_LT)
> + dev_warn(dev, "PCIe port %u link is in recovery\n",
> + port->index);
> +
> + /* Retrain the link */
> + value = readl(port->base + RP_LINK_CONTROL_STATUS);
> + value |= PCI_EXP_LNKCTL_RL;
> + writel(value, port->base + RP_LINK_CONTROL_STATUS);
> +
> + deadline = ktime_add_us(ktime_get(), LINK_RETRAIN_TIMEOUT);
> +
> + while (ktime_before(ktime_get(), deadline)) {
> + value = readl(port->base + RP_LINK_CONTROL_STATUS);
> + if ((value & PCI_EXP_LNKSTA_LT) == 0)
> + break;
> +
> + usleep_range(2000, 3000);
> + }
> +
> + if (value & PCI_EXP_LNKSTA_LT)
> + dev_err(dev, "failed to retrain link of port %u\n",
> + port->index);
> + }
> +}
> +
> static void tegra_pcie_enable_ports(struct tegra_pcie *pcie)
> {
> struct device *dev = pcie->dev;
> @@ -2113,6 +2174,9 @@ static void tegra_pcie_enable_ports(struct tegra_pcie *pcie)
> tegra_pcie_port_disable(port);
> tegra_pcie_port_free(port);
> }
> +
> + if (pcie->soc->has_gen2)
> + tegra_pcie_change_link_speed(pcie);
> }
>
> static void tegra_pcie_disable_ports(struct tegra_pcie *pcie)
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-06-20 14:32 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 18:01 [PATCH V6 00/27] Enable Tegra PCIe root port features Manikanta Maddireddy
2019-06-18 18:01 ` [PATCH V6 01/27] soc/tegra: pmc: Export tegra_powergate_power_on() Manikanta Maddireddy
2019-06-18 18:01 ` [PATCH V6 02/27] PCI: tegra: Handle failure cases in tegra_pcie_power_on() Manikanta Maddireddy
2019-06-18 18:01 ` [PATCH V6 03/27] PCI: tegra: Rearrange Tegra PCIe driver functions Manikanta Maddireddy
2019-06-18 18:01 ` [PATCH V6 04/27] PCI: tegra: Mask AFI_INTR in runtime suspend Manikanta Maddireddy
2019-06-20 14:27 ` Lorenzo Pieralisi
2019-06-20 14:46 ` Manikanta Maddireddy
2019-06-18 18:01 ` [PATCH V6 05/27] PCI: tegra: Fix PCIe host power up sequence Manikanta Maddireddy
2019-06-18 18:01 ` [PATCH V6 06/27] PCI: tegra: Add PCIe Gen2 link speed support Manikanta Maddireddy
2019-06-20 14:32 ` Lorenzo Pieralisi [this message]
2019-06-20 14:57 ` Manikanta Maddireddy
2019-06-20 15:22 ` Lorenzo Pieralisi
2019-06-18 18:01 ` [PATCH V6 07/27] PCI: tegra: Advertise PCIe Advanced Error Reporting (AER) capability Manikanta Maddireddy
2019-06-18 18:01 ` [PATCH V6 08/27] PCI: tegra: Program UPHY electrical settings for Tegra210 Manikanta Maddireddy
2019-06-18 18:01 ` [PATCH V6 09/27] PCI: tegra: Enable opportunistic UpdateFC and ACK Manikanta Maddireddy
2019-06-18 18:01 ` [PATCH V6 10/27] PCI: tegra: Disable AFI dynamic clock gating Manikanta Maddireddy
2019-06-18 18:01 ` [PATCH V6 11/27] PCI: tegra: Process pending DLL transactions before entering L1 or L2 Manikanta Maddireddy
2019-06-18 18:01 ` [PATCH V6 12/27] PCI: tegra: Enable PCIe xclk clock clamping Manikanta Maddireddy
2019-06-18 18:01 ` [PATCH V6 13/27] PCI: tegra: Increase the deskew retry time Manikanta Maddireddy
2019-06-18 18:01 ` [PATCH V6 14/27] PCI: tegra: Add SW fixup for RAW violations Manikanta Maddireddy
2019-06-18 18:01 ` [PATCH V6 15/27] PCI: tegra: Update flow control timer frequency in Tegra210 Manikanta Maddireddy
2019-06-18 18:01 ` [PATCH V6 16/27] PCI: tegra: Set target speed as Gen1 before starting LTSSM Manikanta Maddireddy
2019-06-18 18:01 ` [PATCH V6 17/27] PCI: tegra: Fix PLLE power down issue due to CLKREQ# signal Manikanta Maddireddy
2019-06-18 18:01 ` [PATCH V6 18/27] PCI: tegra: Program AFI_CACHE* registers only for Tegra20 Manikanta Maddireddy
2019-06-20 16:26 ` Lorenzo Pieralisi
2019-06-20 16:35 ` Manikanta Maddireddy
2019-06-18 18:01 ` [PATCH V6 19/27] PCI: tegra: Change PRSNT_SENSE IRQ log to debug Manikanta Maddireddy
2019-06-18 18:01 ` [PATCH V6 20/27] PCI: tegra: Disable MSI for Tegra PCIe root port Manikanta Maddireddy
2019-06-18 19:48 ` Bjorn Helgaas
2019-06-19 3:55 ` Manikanta Maddireddy
2019-06-19 9:50 ` Lorenzo Pieralisi
2019-06-18 18:02 ` [PATCH V6 21/27] PCI: tegra: Add AFI_PEX2_CTRL reg offset as part of soc struct Manikanta Maddireddy
2019-06-18 18:02 ` [PATCH V6 22/27] dt-bindings: pci: tegra: Document PCIe DPD pinctrl optional prop Manikanta Maddireddy
2019-06-18 18:02 ` [PATCH V6 23/27] arm64: tegra: Add PEX DPD states as pinctrl properties Manikanta Maddireddy
2019-06-20 10:14 ` Thierry Reding
2019-06-18 18:02 ` [PATCH V6 24/27] PCI: tegra: Put PEX CLK & BIAS pads in DPD mode Manikanta Maddireddy
2019-06-18 18:02 ` [PATCH V6 25/27] PCI: Add DT binding for "reset-gpios" property Manikanta Maddireddy
2019-06-18 18:02 ` [PATCH V6 26/27] PCI: tegra: Add support for GPIO based PERST# Manikanta Maddireddy
2019-07-04 14:48 ` Jon Hunter
2019-07-04 15:29 ` Manikanta Maddireddy
2019-07-04 17:23 ` Jon Hunter
2019-06-18 18:02 ` [PATCH V6 27/27] PCI: tegra: Change link retry log level to debug Manikanta Maddireddy
2019-06-20 10:25 ` [PATCH V6 00/27] Enable Tegra PCIe root port features Thierry Reding
2019-06-20 10:53 ` Lorenzo Pieralisi
2019-06-20 11:14 ` Thierry Reding
2019-06-20 16:46 ` Lorenzo Pieralisi
2019-06-20 17:23 ` Manikanta Maddireddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190620143251.GB31996@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mmaddireddy@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).