linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: Changelogs on kernel.org
@ 2002-05-15 21:38 James Bottomley
  0 siblings, 0 replies; 75+ messages in thread
From: James Bottomley @ 2002-05-15 21:38 UTC (permalink / raw)
  To: Larry McVoy; +Cc: linux-kernel, James.Bottomley

[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]

lm@bitmover.com said:
> We've already built all the interfaces you need to do this, so would
> you be interested in writing the shell script that does it?  The
> interfaces you will want:

>         bk export -tpatch
>         bk import -tpatch
>         bk comments
>         bk changes -v

> You'll want this, I believe that you can take the output of this
> command and feed it into bk comments and have that be a noop.  If that
> works, this is what you need to save as the comments part of the
> patch, and now it's pretty trivial to move the patch backwards.

I've got a shell script which does this (I use it to take test patches from my 
build tree back to a pristine source for submission to linus).  I'm afraid 
it's a bit rough and ready, but it takes a given set of changes, wraps them up 
as patches, extracts the comments and applies them as patches to a different 
tree and then inserts the comments.  I wrote it a while ago, so it may be a 
little dusty and lacking in the newer bitkeeper features.

James



[-- Attachment #2: bkexport --]
[-- Type: text/plain , Size: 1347 bytes --]

#!/bin/bash
#
##
# Author: James Bottomley
##
# Tool to backport from bitkeeper repositories
##
# $Id: bkexport,v 1.1 2002/03/16 15:50:50 jejb Exp $
##

usage() {
    echo "Usage: $0 {-C <change set list>|-R <repository>} <other repository>";
    exit 1;
}

tmp=/tmp/$$
tmpdiff=$tmp.diff
tmpfile=$tmp.file

if [ $# -ne 3 ]; then
    usage;
fi

case $1 in
    -C)		changeset=$2
		dir=$3;;

    -R)		changeset=`bk changes -d':REV:\n' -L $2|sort -n`
		dir=$3;;

    *)		usage;;
esac

if [ ! -d $dir ]; then
    echo "DIRECTORY $dir MUST EXIST" 2>&1
    exit 1;
fi

# get the changes

for c in $changeset; do
    echo "Applying ChangeSet $c"
    bk export -tpatch -du -r$c > $tmpdiff
    pushd $dir > /dev/null
    bk get -e `awk '/^diff/{print substr($3,3)}' < $tmpdiff`
    patch -p1 < $tmpdiff
    popd > /dev/null
    bk changes -v -n -d':GFILE: :REV:' -r$c | {
    while read file rev; do
	if [ "$file" = "ChangeSet" ]; then
	    continue
	fi
	echo "Applying change log for $file revision $rev"
	bk prs -h -d'$each(:C:){(:C:)\n}' -r$rev $file > $tmpfile
	pushd $dir > /dev/null
	bk ci -y"`cat $tmpfile`" $file
	popd > /dev/null
    done
    bk prs -h -d'$each(:C:){(:C:)\n}' -r$c ChangeSet > $tmpfile
    pushd $dir > /dev/null
    echo "Commiting ChangeSet $c"
    bk commit -d -Y$tmpfile
    popd > /dev/null
    }
done
rm -f $tmpdiff $tmpfile

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-15 20:15         ` David Woodhouse
  2002-05-15 20:34           ` Larry McVoy
  2002-05-15 21:03           ` Kenneth Johansson
@ 2002-05-16  7:02           ` Rusty Russell
  2 siblings, 0 replies; 75+ messages in thread
From: Rusty Russell @ 2002-05-16  7:02 UTC (permalink / raw)
  To: David Woodhouse; +Cc: lm, linux-kernel

On Wed, 15 May 2002 21:15:37 +0100
David Woodhouse <dwmw2@infradead.org> wrote:
> What it actually encourages is for people to have multiple throwaway trees. 
> (Which isn't quite so much of a BK turnoff once you discover compilercache.)

s/compilercache/ccache/

http://ccache.samba.org

Cheers,
Rusty.
-- 
   there are those who do and those who hang on and you don't see too
   many doers quoting their contemporaries.  -- Larry McVoy

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-15 22:59                 ` Larry McVoy
@ 2002-05-16  2:26                   ` Horst von Brand
  0 siblings, 0 replies; 75+ messages in thread
From: Horst von Brand @ 2002-05-16  2:26 UTC (permalink / raw)
  To: Larry McVoy; +Cc: Kernel Mailing List

Larry McVoy <lm@bitmover.com> said:
> On Wed, May 15, 2002 at 05:56:18PM -0500, Kai Germaschewski wrote:

[...]

> > So what's the undocumented option to turn off consistency checks? ;-)

[...]

> We've got a release in the works which makes it so you can run them only
> once in a 24 hour period.  I'm fixing up the stuff that caused the problems
> on multiple patch imports and then we'll do a release.

What happened to "... gives you enough rope to shoot your feet"?
--
Horst von Brand                             vonbrand@sleipnir.valparaiso.cl
Casilla 9G, Vin~a del Mar, Chile                               +56 32 672616

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-15 22:56               ` Kai Germaschewski
@ 2002-05-15 22:59                 ` Larry McVoy
  2002-05-16  2:26                   ` Horst von Brand
  0 siblings, 1 reply; 75+ messages in thread
From: Larry McVoy @ 2002-05-15 22:59 UTC (permalink / raw)
  To: Kai Germaschewski; +Cc: Larry McVoy, Kernel Mailing List

On Wed, May 15, 2002 at 05:56:18PM -0500, Kai Germaschewski wrote:
> On Wed, 15 May 2002, Larry McVoy wrote:
> 
> > bk park		# saves work as a patch
> > bk pull
> > bk unpark	# restores the patch
> > 
> > park/unpark are undocumented because they puke when there are patch rejects.
> > If we document them, then we have to explain to people what to do when there
> > are patch rejects, and if you need that explanation, we probably can't help
> > you.  You guys all grok patch rejects, so try park/unpark.
> 
> So what's the undocumented option to turn off consistency checks? ;-)
> 
> I understand that they exist for a reason, etc, but I'd really like to 
> have the option to switch them off (and suffer the consequences all by 
> myself)

We've got a release in the works which makes it so you can run them only
once in a 24 hour period.  I'm fixing up the stuff that caused the problems
on multiple patch imports and then we'll do a release.
-- 
---
Larry McVoy            	 lm at bitmover.com           http://www.bitmover.com/lm 

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-15 22:30             ` Larry McVoy
@ 2002-05-15 22:56               ` Kai Germaschewski
  2002-05-15 22:59                 ` Larry McVoy
  0 siblings, 1 reply; 75+ messages in thread
From: Kai Germaschewski @ 2002-05-15 22:56 UTC (permalink / raw)
  To: Larry McVoy; +Cc: Kernel Mailing List

On Wed, 15 May 2002, Larry McVoy wrote:

> bk park		# saves work as a patch
> bk pull
> bk unpark	# restores the patch
> 
> park/unpark are undocumented because they puke when there are patch rejects.
> If we document them, then we have to explain to people what to do when there
> are patch rejects, and if you need that explanation, we probably can't help
> you.  You guys all grok patch rejects, so try park/unpark.

So what's the undocumented option to turn off consistency checks? ;-)

I understand that they exist for a reason, etc, but I'd really like to 
have the option to switch them off (and suffer the consequences all by 
myself)

--Kai



^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-15 21:03           ` Kenneth Johansson
@ 2002-05-15 22:30             ` Larry McVoy
  2002-05-15 22:56               ` Kai Germaschewski
  0 siblings, 1 reply; 75+ messages in thread
From: Larry McVoy @ 2002-05-15 22:30 UTC (permalink / raw)
  To: Kenneth Johansson; +Cc: David Woodhouse, Larry McVoy, Kernel Mailing List

> Also I have found that it is a pain in the a** to have debug code that I
> really don't want to save but it's temporary usefull. When I do a pull

bk park		# saves work as a patch
bk pull
bk unpark	# restores the patch

park/unpark are undocumented because they puke when there are patch rejects.
If we document them, then we have to explain to people what to do when there
are patch rejects, and if you need that explanation, we probably can't help
you.  You guys all grok patch rejects, so try park/unpark.
-- 
---
Larry McVoy            	 lm at bitmover.com           http://www.bitmover.com/lm 

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-15 20:15         ` David Woodhouse
  2002-05-15 20:34           ` Larry McVoy
@ 2002-05-15 21:03           ` Kenneth Johansson
  2002-05-15 22:30             ` Larry McVoy
  2002-05-16  7:02           ` Rusty Russell
  2 siblings, 1 reply; 75+ messages in thread
From: Kenneth Johansson @ 2002-05-15 21:03 UTC (permalink / raw)
  To: David Woodhouse; +Cc: Larry McVoy, Kernel Mailing List

On Wed, 2002-05-15 at 22:15, David Woodhouse wrote:
> 
> lm@bitmover.com said:
> > It's probably best if you simply view this as a BK limitation which
> > isn't going away any time soon and don't put junk changesets in the
> > middle of your stream of changes.  It's easy enough to export the
> > change you want as a patch, export the comments in the form that bk
> > comments wants, undo the junk changeset, import the patch, and set the
> > comments.  Yeah, it's awkward; consider that a feedback loop which
> > encourages you to think a bit more about what you put in the tree.
> 
> What it actually encourages is for people to have multiple throwaway trees. 
> (Which isn't quite so much of a BK turnoff once you discover compilercache.)
> 
> If the tree's going to be thrown away anyway, it doesn't matter if it gets 
> confused -- how about making it a little easier to backport changesets -- 
> surely it should be possible to make BK import a changeset iff all the 
> affected files are identical in both trees before the changeset? 

while we are adding to the wishlist here is a few more items.

Away to make a clone with all files checked out in edit mode. I find
that I always do the checkout anyway and maybe it's possible to make it
faster if it's done at clone time.

Also I have found that it is a pain in the a** to have debug code that I
really don't want to save but it's temporary usefull. When I do a pull
that changes the same file the pull don't work and I have to unedit the
file and lose the debug code or make a needless checkin. I would really
like if it was possible to do a merge that is only in the checkedout
file not stored as a changeset.

 



^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-15 20:15         ` David Woodhouse
@ 2002-05-15 20:34           ` Larry McVoy
  2002-05-15 21:03           ` Kenneth Johansson
  2002-05-16  7:02           ` Rusty Russell
  2 siblings, 0 replies; 75+ messages in thread
From: Larry McVoy @ 2002-05-15 20:34 UTC (permalink / raw)
  To: David Woodhouse; +Cc: Larry McVoy, Kernel Mailing List

On Wed, May 15, 2002 at 09:15:37PM +0100, David Woodhouse wrote:
> lm@bitmover.com said:
> > It's probably best if you simply view this as a BK limitation which
> > isn't going away any time soon and don't put junk changesets in the
> > middle of your stream of changes.  It's easy enough to export the
> > change you want as a patch, export the comments in the form that bk
> > comments wants, undo the junk changeset, import the patch, and set the
> > comments.  Yeah, it's awkward; consider that a feedback loop which
> > encourages you to think a bit more about what you put in the tree.
> 
> What it actually encourages is for people to have multiple throwaway trees. 
> (Which isn't quite so much of a BK turnoff once you discover compilercache.)

Yup, we use that here, works great.

> If the tree's going to be thrown away anyway, it doesn't matter if it gets 
> confused -- how about making it a little easier to backport changesets -- 
> surely it should be possible to make BK import a changeset iff all the 
> affected files are identical in both trees before the changeset? 

We've already built all the interfaces you need to do this, so would
you be interested in writing the shell script that does it?  The 
interfaces you will want:

	bk export -tpatch
	bk import -tpatch
	bk comments
	bk changes -v

You'll want this, I believe that you can take the output of this command
and feed it into bk comments and have that be a noop.  If that works, this
is what you need to save as the comments part of the patch, and now it's
pretty trivial to move the patch backwards.

bk changes -r+ -vd'### Comments for :GFILE:|+\n$each(:C:){(:C:)\n}'

If you do write this, let me know if you want it included as a "bk backport"
command.  

Also note that there is a `bk bin`/bk.script which is a set of shell script
functions.  Many BK commands start out their life as 

# bk backport - cherry pick a change out of tree A and put it in tree B
# usage: bk backport -r<rev> from to
_backport() {
}

If you start the command with a underscore, then BK will autotranslate that
into a command that you can use like

	bk backport ....

If you prefer a standalone command (for licensing reasons, perhaps), then
make it a standalone shell script, put it in `bk bin`, and bk will find it.
-- 
---
Larry McVoy            	 lm at bitmover.com           http://www.bitmover.com/lm 

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-15 20:08       ` Larry McVoy
@ 2002-05-15 20:15         ` David Woodhouse
  2002-05-15 20:34           ` Larry McVoy
                             ` (2 more replies)
  0 siblings, 3 replies; 75+ messages in thread
From: David Woodhouse @ 2002-05-15 20:15 UTC (permalink / raw)
  To: Larry McVoy; +Cc: Kernel Mailing List


lm@bitmover.com said:
> It's probably best if you simply view this as a BK limitation which
> isn't going away any time soon and don't put junk changesets in the
> middle of your stream of changes.  It's easy enough to export the
> change you want as a patch, export the comments in the form that bk
> comments wants, undo the junk changeset, import the patch, and set the
> comments.  Yeah, it's awkward; consider that a feedback loop which
> encourages you to think a bit more about what you put in the tree.

What it actually encourages is for people to have multiple throwaway trees. 
(Which isn't quite so much of a BK turnoff once you discover compilercache.)

If the tree's going to be thrown away anyway, it doesn't matter if it gets 
confused -- how about making it a little easier to backport changesets -- 
surely it should be possible to make BK import a changeset iff all the 
affected files are identical in both trees before the changeset? 

--
dwmw2



^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-15 20:03     ` David Woodhouse
@ 2002-05-15 20:08       ` Larry McVoy
  2002-05-15 20:15         ` David Woodhouse
  0 siblings, 1 reply; 75+ messages in thread
From: Larry McVoy @ 2002-05-15 20:08 UTC (permalink / raw)
  To: David Woodhouse; +Cc: Larry McVoy, Linus Torvalds, Kernel Mailing List

On Wed, May 15, 2002 at 09:03:40PM +0100, David Woodhouse wrote:
> 
> lm@bitmover.com said:
> > FYI, if they do a 
> > 	bk send -ubk://linux.bkbits.net/linux-2.5 torvalds@transmeta.com
> > that problem goes away.  The -u<url> stuff does the same sort of
> > handshake that a pull does to figure out what needs to be sent to fill
> > in the holes.
> 
> Not quite. The sender usually omits changesets for a _reason_. You'll often
> find that one of the changesets in the middle wasn't necessary and didn't
> touch any of the same files -- in which case patches would have applied 
> just fine.

Understood.  BK doesn't work that way for multiple reasons, some which have
to do with how it synchronizes replicas, and some which have to do with
being able to reproduce a tree exactly.

It's probably best if you simply view this as a BK limitation which isn't
going away any time soon and don't put junk changesets in the middle of
your stream of changes.  It's easy enough to export the change you want
as a patch, export the comments in the form that bk comments wants,
undo the junk changeset, import the patch, and set the comments.  Yeah,
it's awkward; consider that a feedback loop which encourages you to
think a bit more about what you put in the tree.
-- 
---
Larry McVoy            	 lm at bitmover.com           http://www.bitmover.com/lm 

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-15 19:20   ` Larry McVoy
@ 2002-05-15 20:03     ` David Woodhouse
  2002-05-15 20:08       ` Larry McVoy
  0 siblings, 1 reply; 75+ messages in thread
From: David Woodhouse @ 2002-05-15 20:03 UTC (permalink / raw)
  To: Larry McVoy; +Cc: Linus Torvalds, Kernel Mailing List


lm@bitmover.com said:
> FYI, if they do a 
> 	bk send -ubk://linux.bkbits.net/linux-2.5 torvalds@transmeta.com
> that problem goes away.  The -u<url> stuff does the same sort of
> handshake that a pull does to figure out what needs to be sent to fill
> in the holes.

Not quite. The sender usually omits changesets for a _reason_. You'll often
find that one of the changesets in the middle wasn't necessary and didn't
touch any of the same files -- in which case patches would have applied 
just fine.

--
dwmw2



^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-15 16:39 ` Linus Torvalds
  2002-05-15 18:07   ` David Woodhouse
@ 2002-05-15 19:20   ` Larry McVoy
  2002-05-15 20:03     ` David Woodhouse
  1 sibling, 1 reply; 75+ messages in thread
From: Larry McVoy @ 2002-05-15 19:20 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: David Woodhouse, Kernel Mailing List

On Wed, May 15, 2002 at 09:39:30AM -0700, Linus Torvalds wrote:
> On Wed, 15 May 2002, David Woodhouse wrote:
> > Are you still accepting BK changesets by mail? I heard rumours that you'd
> > said you didn't want them any more -- but couldn't find a message in which
> > you actually said that.
> 
> I try to avoid it as much as possible - it's actually more work for me,
> and about 50% of the BK patches I get don't even apply, because the person
> who sent them to me didn't send the whole series (ie left out some patch
> he didn't like or something like that).

FYI, if they do a 

	bk send -ubk://linux.bkbits.net/linux-2.5 torvalds@transmeta.com

that problem goes away.  The -u<url> stuff does the same sort of handshake
that a pull does to figure out what needs to be sent to fill in the holes.

> > Having the facility to put per-file changelogs in with BK rather than just
> > sending patches is something I quite like, so I'd rather not just revert to
> > sending patches.
> 
> [ Personal opinion alert! No impact on patch acceptance, as long as
>   enough changelog information exists _somewhere_ ]
> 
> I personally like good changelog comments, and I find per-file comments to
> be a mistake.

<Also personal opinion>

Sometimes yes, sometimes no.  Certainly the high order bit is to capture
the logical change in the changeset comment.  One should only have to read
the change{set,log} comment to see if that change is interesting or not,
it should not be necessary to go read the file comments.

The file comments are more about the details of the implementation, not
the idea.  I think the reason that Linus doesn't care about file comments
is that he always reads the diffs and that's better than any comment, in
general.  That's more or less true, but the file comment is a place to
give yourself or others a hint as to what was in your mind when you made
that change.  Those hints can really save your butt when the pressure is
on to turn around a bugfix fast for a customer/whatever.

One of the engineers here said "Changeset comments are for managers,
file comments are for engineers", which is another way to look at it.

Anyway, I would agree 100% that the changeset comments are the most
important in general, so if those are gotten right then we're ahead
of the game.

>  - the per-file comments don't show up in many of the standard changelogs
>    (not mine, not in "bk changes" etc), so the per-changeset comment

bk changes -v

will list the file comments as well.  There is a minor sorting bug in there
when the timestamps are screwed up, but it tries pretty hard to make it be

	ChangeSet comments

	    File 1 comments

	    File 2 comments

	    Etc.
-- 
---
Larry McVoy            	 lm at bitmover.com           http://www.bitmover.com/lm 

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-15 16:39 ` Linus Torvalds
@ 2002-05-15 18:07   ` David Woodhouse
  2002-05-15 19:20   ` Larry McVoy
  1 sibling, 0 replies; 75+ messages in thread
From: David Woodhouse @ 2002-05-15 18:07 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Kernel Mailing List


torvalds@transmeta.com said:
>  I try to avoid it as much as possible - it's actually more work for
> me, and about 50% of the BK patches I get don't even apply, because
> the person who sent them to me didn't send the whole series (ie left
> out some patch he didn't like or something like that). 

Oh Larry, are you listening? :)

>  I much prefer a bk pull, if the tree I pull from is clean (ie it
> doesn't have random crud in it, and it contains changsets from just
> one project). 

Noted. Thanks.

>  I personally like good changelog comments, and I find per-file
> comments to be a mistake. 

They can be, but sometimes it can be useful to put a high-level overview of
what you've done suitable for people who aren't familiar with the code into
the changeset comment, and describe exactly _how_ you did it in per-file
comments.

Which in the case of the patch I sent you yesterday would be something like
'fix zisofs breakage with shared zlib' on the changeset and 'set return 
value to trv not f in NEEDBYTE' in the lib/zlib_inflate/inflate.c log.

In this case, the latter can obviously be deduced from the diffs because
it's a one-liner, so perhaps it's a bad example -- but you don't always
actually want to have to refer to the diffs.

--
dwmw2



^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
       [not found] <30386.1021456050@redhat.com>
@ 2002-05-15 16:39 ` Linus Torvalds
  2002-05-15 18:07   ` David Woodhouse
  2002-05-15 19:20   ` Larry McVoy
  0 siblings, 2 replies; 75+ messages in thread
From: Linus Torvalds @ 2002-05-15 16:39 UTC (permalink / raw)
  To: David Woodhouse; +Cc: Kernel Mailing List



On Wed, 15 May 2002, David Woodhouse wrote:
>
> Are you still accepting BK changesets by mail? I heard rumours that you'd
> said you didn't want them any more -- but couldn't find a message in which
> you actually said that.

I try to avoid it as much as possible - it's actually more work for me,
and about 50% of the BK patches I get don't even apply, because the person
who sent them to me didn't send the whole series (ie left out some patch
he didn't like or something like that).

> When making changesets to send to you, I usually start with a fresh clone
> of your latest tree and apply my changes to that -- would you prefer me to
> make the whole tree available somewhere public (or on master.kernel.org)
> for a 'bk pull' instead?

I much prefer a bk pull, if the tree I pull from is clean (ie it doesn't
have random crud in it, and it contains changsets from just one project).

Some people actually use BK but then send me regular patches anyway,
because they find that easier than setting up an exported BK tree and
being careful about cleanliness. I don't much care one way or the other:
regular email patches are easy for me to integrate, so it's really up to
you.

> Having the facility to put per-file changelogs in with BK rather than just
> sending patches is something I quite like, so I'd rather not just revert to
> sending patches.

[ Personal opinion alert! No impact on patch acceptance, as long as
  enough changelog information exists _somewhere_ ]

I personally like good changelog comments, and I find per-file comments to
be a mistake.

I have a few simple reasons for this:

 - most changes are related, and per-file comments tend to just repeat.

   In fact, for patches, I just repeat the Subject: line in the per-file
   comments, so that they have just enough context to get the big picture.

 - if your changes _aren't_ related, you should have done multiple
   changesets in the first place. Rince and repeat as necessary.

 - the per-file comments don't show up in many of the standard changelogs
   (not mine, not in "bk changes" etc), so the per-changeset comment
   should be "sufficient" in many ways anyway.

But to each his own.

[ End personal opinion ]

		Linus


^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-14  8:43                     ` Matthias Andree
@ 2002-05-14  9:23                       ` Tomas Szepe
  0 siblings, 0 replies; 75+ messages in thread
From: Tomas Szepe @ 2002-05-14  9:23 UTC (permalink / raw)
  To: linux-kernel, Matthias Andree

> > +die "Usage $0 [-n] <Changelog file>\nThis Perl script is meant to simplify/beautify BK ChangeLogs\nfor the linux kernel\n\nn\tFormat for the output\n\t0 - Short mode (one changelog == one line)\n\t1 - Full mode (changelogs separated by dashed line)\n\t2 - Original mode (one line consisting of changelog and author)[DEFAULT]\n" unless defined $ARGV[0];
> Why forbid filtering?

Jup, please keep that.

> > +my $fd = $ARGV[0];
> > +
> > +if (grep(/^-/,$ARGV[0])) {
> > +	$mode = $ARGV[0];
> > +	$mode =~ s/-//;
> > +	$mode = 2 if ($mode > 2);
> > +	$fd = $ARGV[1];
> It's time for some Getopt::. I'll merge the interesting parts of 0.92
> as posted by Tomas, my plan is: use the LINUX_BK2CHANGELOG variable for
> defaults, but allow to override them with command line arguments.

That's great as long as we're able to use the script both as a filter
and as a file processor (allowing multiple filenames given on cmdline).

> >  # minimum space between entry and author for the original mode
> > @@ -160,7 +167,9 @@
> >  	}
> >  }
> >  
> > -while (<>)
> > +open FD,$fd;
> This gives room for nasty surprises, if $ARGV[whatever] starts with a
> ">" or "|". Easy to fix, but we can avoid this, because Perl already
> handles it for us. Check the docs on <> behaviour when extra command
> line arguments are left over.

Right.

T.

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13 23:41                     ` Tomas Szepe
@ 2002-05-14  8:44                       ` Matthias Andree
  0 siblings, 0 replies; 75+ messages in thread
From: Matthias Andree @ 2002-05-14  8:44 UTC (permalink / raw)
  To: linux-kernel

On Tue, 14 May 2002, Tomas Szepe wrote:

> > - Added an usage note
> > - Changed CMODE environment variable for a command line argument
> 
> Thanks, but the idea behind CMODE is that it's possible to set the
> output mode and still have the script act both as a filter and file
> eater (multiple changelogs on cmdline are ok of course) w/o having
> to handle the eating "explicitly."
> 
> Plus one can put "export CMODE=something" in ~/.profile and forget
> about the modes entirely.
> 
> Here comes 0.92 (s/LOWER CAPS/lower case/ as pointed out by
> Kai Henningsen). Let's call it a candidate for inclusion in
> scripts/. Linus?

Too early. It's undocumented, for example.

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13 22:05                   ` Robinson Maureira Castillo
  2002-05-13 23:41                     ` Tomas Szepe
@ 2002-05-14  8:43                     ` Matthias Andree
  2002-05-14  9:23                       ` Tomas Szepe
  1 sibling, 1 reply; 75+ messages in thread
From: Matthias Andree @ 2002-05-14  8:43 UTC (permalink / raw)
  To: linux-kernel

On Mon, 13 May 2002, Robinson Maureira Castillo wrote:

> +die "Usage $0 [-n] <Changelog file>\nThis Perl script is meant to simplify/beautify BK ChangeLogs\nfor the linux kernel\n\nn\tFormat for the output\n\t0 - Short mode (one changelog == one line)\n\t1 - Full mode (changelogs separated by dashed line)\n\t2 - Original mode (one line consisting of changelog and author)[DEFAULT]\n" unless defined $ARGV[0];

Why forbid filtering?

> +my $fd = $ARGV[0];
> +
> +if (grep(/^-/,$ARGV[0])) {
> +	$mode = $ARGV[0];
> +	$mode =~ s/-//;
> +	$mode = 2 if ($mode > 2);
> +	$fd = $ARGV[1];

It's time for some Getopt::. I'll merge the interesting parts of 0.92 as
posted by Tomas, my plan is: use the LINUX_BK2CHANGELOG variable for
defaults, but allow to override them with command line arguments.

>  # minimum space between entry and author for the original mode
> @@ -160,7 +167,9 @@
>  	}
>  }
>  
> -while (<>)
> +open FD,$fd;

This gives room for nasty surprises, if $ARGV[whatever] starts with a
">" or "|". Easy to fix, but we can avoid this, because Perl already
handles it for us. Check the docs on <> behaviour when extra command
line arguments are left over.

-- 
Matthias Andree

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13 20:57       ` Linus Torvalds
@ 2002-05-14  0:29         ` Arnaldo Carvalho de Melo
  0 siblings, 0 replies; 75+ messages in thread
From: Arnaldo Carvalho de Melo @ 2002-05-14  0:29 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Dr. David Alan Gilbert, linux-kernel

Em Mon, May 13, 2002 at 01:57:15PM -0700, Linus Torvalds escreveu:
> 
> On Sun, 12 May 2002, Arnaldo Carvalho de Melo wrote:
> 
> > Em Sun, May 12, 2002 at 09:31:03PM +0100, Dr. David Alan Gilbert escreveu:
> > > Perhaps insisting that each check in message includes a single line (sub
> > > 60 chars) description; could turn those into description : name and
> > > remove dupes?
> > 
> > That'd be nice indeed, like %{summary} and %{description} in rpm spec files 8)
> 
> seem to do when they just want to check something in (ie very few people
> would send an email saying "fix misc problems" as the body of the email,
> yet it's easy to do when you do "bk citool").

As a bk newbie I'm trying to follow these rules... 8)

- Arnaldo

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13 22:05                   ` Robinson Maureira Castillo
@ 2002-05-13 23:41                     ` Tomas Szepe
  2002-05-14  8:44                       ` Matthias Andree
  2002-05-14  8:43                     ` Matthias Andree
  1 sibling, 1 reply; 75+ messages in thread
From: Tomas Szepe @ 2002-05-13 23:41 UTC (permalink / raw)
  To: Robinson Maureira Castillo; +Cc: linux-kernel, Linus Torvalds

> - Added an usage note
> - Changed CMODE environment variable for a command line argument

Thanks, but the idea behind CMODE is that it's possible to set the
output mode and still have the script act both as a filter and file
eater (multiple changelogs on cmdline are ok of course) w/o having
to handle the eating "explicitly."

Plus one can put "export CMODE=something" in ~/.profile and forget
about the modes entirely.

Here comes 0.92 (s/LOWER CAPS/lower case/ as pointed out by
Kai Henningsen). Let's call it a candidate for inclusion in
scripts/. Linus?

Take care,
T.


#!/usr/bin/perl -w
#
# This Perl script is meant to simplify/beautify BK ChangeLogs
# for the linux kernel.
#
# (C) Copyright 2002 by Matthias Andree <matthias.andree@gmx.de>,
#			Marcus Alanen <maalanen@abo.fi>,
#			Tomas Szepe <szepe@pinerecords.com>
#
# Version 0.92.
# (Please don't bump this if you've just added another email-to-name
# mapping entry to the db.)
#
# ------------------------------------------------------------------
# Distribution of this script is permitted under the terms of the
# GNU General Public License (GNU GPL) v2.
# ------------------------------------------------------------------
#
# This program expects its input in the following format:
# (E-Mail Addresses MUST NOT bear leading whitespace!)
#
# <email@ddr.ess>
#	changelog text
#	more changelog text
# <email@ddr.ess>
#	yet another changelog
# <another@add.ress>
#	changelog #3
#	more lines
#
# Groups and sorts the entries by email address:
#
# another@add.ress:
#	changelog #3
# email@ddr.ess
#	changelog text
#	yet another changelog
#
# There are three different modes:
# - Short mode (one changelog == one line)
# - Full mode (changelogs separated by dashed line)
# - Original mode (one line consisting of changelog and author)
#
# Where possible, also adds the real name of the author using
# a static hash %addresses
#

use strict;

# CMODE environment variable selects output mode:
# 0 for short, 1 for full, 2 for "original changelog"
# (default is 2 if $CMODE unset)
#
my $mode = 2;
foreach my $en (keys(%ENV)) {
	if ($en eq "CMODE") {
		$mode = $ENV{CMODE};
		if ($mode ne "0" && $mode ne "1" && $mode ne "2") {
			print "CMODE has to be 0 for short, 1 for full, 2 for orig. Undefined defaults to 2.\n";
			die();
		}
		last;
	}
}

# minimum space between entry and author for the original mode
my $space = 5;

# The key is the email address *in lower case*,
# the value is the real name of the person.
#
my %addresses = (
	'aia21@cantab.net'			=> 'Anton Altaparmakov',
	'ak@muc.de'				=> 'Andi Kleen',
	'akpm@zip.com.au'			=> 'Andrew Morton',
	'alan@lxorguk.ukuu.org.uk'		=> 'Alan Cox',
	'andrea@suse.de'			=> 'Andrea Arcangeli',
	'ankry@green.mif.pg.gda.pl'		=> 'Andrzej Krzysztofowicz',
	'axboe@suse.de'				=> 'Jens Axboe',
	'bgerst@didntduck.org'			=> 'Brian Gerst',
	'dalecki@evision-ventures.com'		=> 'Martin Dalecki',
	'davem@redhat.com'			=> 'David S. Miller',
	'davidel@xmailserver.org'		=> 'Davide Libenzi',
	'green@namesys.com'			=> 'Oleg Drokin',
	'hch@infradead.org'			=> 'Christoph Hellwig',
	'jgarzik@mandrakesoft.com'		=> 'Jeff Garzik',
	'jsimmons@heisenberg.transvirtual.com'	=> 'James Simmons',
	'jsimmons@transvirtual.com'		=> 'James Simmons',
	'kaos@ocs.com.au'			=> 'Keith Owens',
	'lm@bitmover.com'			=> 'Larry McVoy',
	'manfred@colorfullife.com'		=> 'Manfred Spraul',
	'neilb@cse.unsw.edu.au'			=> 'Neil Brown',
	'paulus@samba.org'			=> 'Paul Mackerras',
	'perex@suse.cz'				=> 'Jaroslav Kysela',
	'rgooch@ras.ucalgary.ca'		=> 'Richard Gooch',
	'rmk@arm.linux.org.uk'			=> 'Russell King',
	'szepe@pinerecords.com'			=> 'Tomas Szepe',
	'torvalds@transmeta.com'		=> 'Linus Torvalds',
	'viro@math.psu.edu'			=> 'Alexander Viro',
	'~~~~thisentrylastforconvenience~~~~'	=> 'Cesar Brutus Anonymous'
);

my %people = ();
my $addr = "";
my @cur = ();

sub append_item()
{
	if (!$addr) {
		return;
	}
	if (!$people{$addr}) {
		@{$people{$addr}} = ();
	}
	push @{$people{$addr}}, [@cur];

	@cur = ();
}

# get name associated to an email address
sub rmap_address
{
	my @o = map {defined $addresses{lc $_} ? $addresses{lc $_} : $_ } @_;
	return wantarray ? @o : $o[0];
}

sub print_items($)
{
	my $person = $_[0];
	my $realname = rmap_address($person);
	my @items = @{$people{$person}};

	# Vain attempt to sort patches from one address
	@items = sort @items;
	if ($mode == 0 or $mode == 1) {
		if ($realname ne $person) {
			print "$realname ";
		}
		print "<$person>\n";
	}
	while ($_ = shift @items) {
		if ($mode == 0) {
			print "\to " . @$_[0];
		} elsif ($mode == 1) {
			print "\t------------------------------------------------------------\n";
			foreach $_ (@$_) {
				print "\t$_";
			}
		} elsif ($mode == 2) {
			$_ = @$_[0];
			chop;
			$_ = "o $_";
			# Split it onto two lines if necessary
			if (length("$_ . $realname") > 76 - $space) {
				print "$_\n" . " " x (76 - length($realname)) . "$realname\n";
			} else {
				print "$_" . " " x (76 - length($realname) - length($_)) . "$realname\n";
			}
		}
	}
}

while (<>)
{
	# Match address
	if (/^<([^>]+)>/) {
		# Add old item (if any) before beginning new
		append_item();
		$addr = $1;
	} elsif ($addr) {
		# Add line to patch
		s/^\s*(.*)\s*$/$1/;
		s/\[?PATCH\]?\s*//i;
		push @cur, "$_\n";
	} else {
		# Header information
		print;
	}
}
append_item();

# Print the information
foreach $addr (sort keys %people) {
	print_items($addr);
	if ($mode != 2) { print "\n"; }
}

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13 14:45                 ` Tomas Szepe
  2002-05-13 14:06                   ` Greg KH
@ 2002-05-13 22:05                   ` Robinson Maureira Castillo
  2002-05-13 23:41                     ` Tomas Szepe
  2002-05-14  8:43                     ` Matthias Andree
  1 sibling, 2 replies; 75+ messages in thread
From: Robinson Maureira Castillo @ 2002-05-13 22:05 UTC (permalink / raw)
  To: Tomas Szepe
  Cc: Marcus Alanen, matthias.andree, riel, Johnny Mnemonic,
	linux-kernel, Russell King

On Mon, 13 May 2002, Tomas Szepe wrote:

> > > Somebody make the mode changeable via command-line option...
> > 
> > Done... in a slightly different manner :)
> > 
> > cl:
> > - clean up
> > - indentation
> > - CMODE environment variable
> > 
> > ./fmt /usr/src/ChangeLog-2.5.14			gives output in orig. mode
> > CMODE=2 ./fmt /usr/src/ChangeLog-2.5.14		gives output in orig. mode
> > CMODE=1 ./fmt /usr/src/ChangeLog-2.5.14		gives output in full mode
> > CMODE=0 ./fmt /usr/src/ChangeLog-2.5.14		gives output in terse mode
> 
> Version 0.91.
> 	- Add a missing "last;" statement (major major speedup! :D)
> 	- Add a couple comments
> 	- More indentation changes and cleanups
> 
> 

What do you think about this patch for a 0.92 version?

- Added an usage note
- Changed CMODE environment variable for a command line argument

Best regards
Robinson Maureira C.

--- fmclog.pl.orig	Mon May 13 17:56:35 2002
+++ fmclog.pl	Mon May 13 17:55:13 2002
@@ -5,9 +5,13 @@
 #
 # (C) Copyright 2002 by Matthias Andree <matthias.andree@gmx.de>,
 #			Marcus Alanen <maalanen@abo.fi>,
-#			Tomas Szepe <szepe@pinerecords.com>
+#			Tomas Szepe <szepe@pinerecords.com>,
+#			Robinson Maureira <rmaureira@alumno.inacap.cl>
+#
+# Version 0.92.
+#
+# Changed use of an environment variable for a command line argument
 #
-# Version 0.91.
 # (Please don't bump this if you've just added another email-to-name
 # mapping entry to the db.)
 #
@@ -47,20 +51,23 @@
 
 use strict;
 
-# CMODE environment variable selects output mode:
-# 0 for short, 1 for full, 2 for "original changelog"
-# (default is 2 if $CMODE unset)
-#
+# Dump usage if we get no arguments
+
+die "Usage $0 [-n] <Changelog file>\nThis Perl script is meant to simplify/beautify BK ChangeLogs\nfor the linux kernel\n\nn\tFormat for the output\n\t0 - Short mode (one changelog == one line)\n\t1 - Full mode (changelogs separated by dashed line)\n\t2 - Original mode (one line consisting of changelog and author)[DEFAULT]\n" unless defined $ARGV[0];
+
+# Check if we received an argument for the mode
+# If we do, we set $mode properly an set the apropiate name for $fd
+# Also, we default to $mode = 2 and $fd being the first parameter
+# TODO: Check for a non-numeric character in $mode
+
 my $mode = 2;
-foreach my $en (keys(%ENV)) {
-	if ($en eq "CMODE") {
-		$mode = $ENV{CMODE};
-		if ($mode ne "0" && $mode ne "1" && $mode ne "2") {
-			print "CMODE has to be 0 for short, 1 for full, 2 for orig. Undefined defaults to 2.\n";
-			die();
-		}
-		last;
-	}
+my $fd = $ARGV[0];
+
+if (grep(/^-/,$ARGV[0])) {
+	$mode = $ARGV[0];
+	$mode =~ s/-//;
+	$mode = 2 if ($mode > 2);
+	$fd = $ARGV[1];
 }
 
 # minimum space between entry and author for the original mode
@@ -160,7 +167,9 @@
 	}
 }
 
-while (<>)
+open FD,$fd;
+
+while (<FD>)
 {
 	# Match address
 	if (/^<([^>]+)>/) {
@@ -177,6 +186,8 @@
 		print;
 	}
 }
+
+close(FD);
 append_item();
 
 # Print the information



^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-12 20:41     ` Arnaldo Carvalho de Melo
@ 2002-05-13 20:57       ` Linus Torvalds
  2002-05-14  0:29         ` Arnaldo Carvalho de Melo
  0 siblings, 1 reply; 75+ messages in thread
From: Linus Torvalds @ 2002-05-13 20:57 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo; +Cc: Dr. David Alan Gilbert, linux-kernel


On Sun, 12 May 2002, Arnaldo Carvalho de Melo wrote:

> Em Sun, May 12, 2002 at 09:31:03PM +0100, Dr. David Alan Gilbert escreveu:
> > Perhaps insisting that each check in message includes a single line (sub
> > 60 chars) description; could turn those into description : name and
> > remove dupes?
> 
> That'd be nice indeed, like %{summary} and %{description} in rpm spec files 8)

We already have that requirement for patches that are emailed to me: the 
Subject line becomes the first line of the changelog, and as a result 
those changelogs are already fairly readable.

The email-patches also tend to have better changelogs for the simple
reason that people think more when they submit patches to me than they
seem to do when they just want to check something in (ie very few people
would send an email saying "fix misc problems" as the body of the email,
yet it's easy to do when you do "bk citool").

		Linus


^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13 10:37         ` Helge Hafting
@ 2002-05-13 19:00           ` Jeff Garzik
  0 siblings, 0 replies; 75+ messages in thread
From: Jeff Garzik @ 2002-05-13 19:00 UTC (permalink / raw)
  To: Helge Hafting; +Cc: linux-kernel

Helge Hafting wrote:

>Jeff Garzik wrote:
>
>>(speaking more to the crowd...)
>>Changeset comments need to be written as if they stand alone, without
>>any other context -- including the author.  A reader should not need to
>>know that (for examples) James Simmons hacks on fbdev stuff.
>>
>
>I think it is nice to have the names.  A new kernel
>might break something,  It is then nice to know
>where to send the bug report. (It is usually, but not
>necessarily the maintainer that did it.)
>

Having the name is fine -- I agree it should not be removed.

However, that was not the point of my message.  The point is, each 
changeset comment comes with -no context at all-.  If the author of the 
comment assumes that, by his name, we can figure out what a comment like 
"minor fixes" mean, that author is making a mistake.  Each cset comment 
needs to tell exactly what the change is, and should not require 
knowledge of the author's identity to determine what is in the changeset.

    Jeff




^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13 14:51                       ` Greg KH
@ 2002-05-13 15:58                         ` Matthias Andree
  0 siblings, 0 replies; 75+ messages in thread
From: Matthias Andree @ 2002-05-13 15:58 UTC (permalink / raw)
  To: linux-kernel

On Mon, 13 May 2002, Greg KH wrote:

> Because we were throwing out things we wished the script could handle?
> It's just a suggestion.  :)

Well, the script is already there, we're just playing source coding here
and writing an irrelevance reduction tool to accompany it.
</engineering>

:-)

BTW, no need to reply to all, please reply to the list only.
Mail-Followup-To: should be set unless my mutt is buggy.

-- 
Matthias Andree

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13 15:29                   ` Tomas Szepe
@ 2002-05-13 15:37                     ` Larry McVoy
  0 siblings, 0 replies; 75+ messages in thread
From: Larry McVoy @ 2002-05-13 15:37 UTC (permalink / raw)
  To: Tomas Szepe; +Cc: Russell King, Dave Gilbert (Home), Rik van Riel, linux-kernel

On Mon, May 13, 2002 at 05:29:23PM +0200, Tomas Szepe wrote:
> > BK reporting is keyed off of somehing called "dspecs" (for data
> > specification).  They are a lot like a primitive printf format.
> > The default dspec for changes is
> > 
> > 	":DPN:@:I:, :Dy:-:Dm:-:Dd: :T::TZ:, :P:$if(:HT:){@:HT:}\n$each(:C:){  (:C:)\n}$each(:TAG:){  TAG: (:TAG:)\n}\n"
> 
> Nice!
> 
> The idea with the perl script was, I reckon, to merely provide a tool
> thru which people could pipe the standard linux 2.5 ChangeLog and get
> an output that suits their own eye. Something like
> 
> $ wget -q ftp://ftp.kernel.org/pub/linux/kernel/v2.5/ChangeLog-2.5.16
> $ cat ChangeLog-2.5.16| CMODE=1 /usr/src/linux/scripts/cl.pl| less

That's cool by me, perl is the language of choice here.  If I could have
embedded perl into the dspecs, I would have :)  If you get to the point
where you want more information from the changelogs than is there, just
remember there is probably a way to get it easily.

Cheers,
-- 
---
Larry McVoy            	 lm at bitmover.com           http://www.bitmover.com/lm 

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13 15:12                 ` Larry McVoy
@ 2002-05-13 15:29                   ` Tomas Szepe
  2002-05-13 15:37                     ` Larry McVoy
  0 siblings, 1 reply; 75+ messages in thread
From: Tomas Szepe @ 2002-05-13 15:29 UTC (permalink / raw)
  To: Larry McVoy, Russell King, Dave Gilbert (Home),
	Rik van Riel, linux-kernel

> BK reporting is keyed off of somehing called "dspecs" (for data
> specification).  They are a lot like a primitive printf format.
> The default dspec for changes is
> 
> 	":DPN:@:I:, :Dy:-:Dm:-:Dd: :T::TZ:, :P:$if(:HT:){@:HT:}\n$each(:C:){  (:C:)\n}$each(:TAG:){  TAG: (:TAG:)\n}\n"

Nice!

The idea with the perl script was, I reckon, to merely provide a tool
thru which people could pipe the standard linux 2.5 ChangeLog and get
an output that suits their own eye. Something like

$ wget -q ftp://ftp.kernel.org/pub/linux/kernel/v2.5/ChangeLog-2.5.16
$ cat ChangeLog-2.5.16| CMODE=1 /usr/src/linux/scripts/cl.pl| less

T.

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13 14:06                   ` Greg KH
  2002-05-13 15:11                     ` Tomas Szepe
@ 2002-05-13 15:21                     ` Matthias Andree
  1 sibling, 0 replies; 75+ messages in thread
From: Matthias Andree @ 2002-05-13 15:21 UTC (permalink / raw)
  To: linux-kernel

On Mon, 13 May 2002, Greg KH wrote:

> What would be even _nicer_ is to remove the dependency on the changelog
> script entirely (right now you have to pipe the output through this perl
> script to get the results.)
> 
> The script that Linus (and others) uses can be found at:
> 	http://gkernel.bkbits.net:8080/BK-kernel-tools/anno/changelog@1.5?nav=index.html|src/

I'm a BK ignorant, and for robustness and programmer efficiency ;-)
reasons, I'd prefer not to call other software from a Perl script. Doing
that properly and handling errors correctly costs some dozens of lines
of code that we save when we're just building on what we have now. The
way it is now, we can deal with old and current ChangeLogs, we have the
verbose summary (overview, actually) and that's it. As these scripts are
not called more than several times a month, I fail to see the point in
eliminating the original bk stuff. Maybe someone uses Arch or Subversion
some day? Who knows? We have a well-defined input format that is easy
enough to parse.

Enough of this, I'm not about to waste more of my and your time :-)

(Now back to merging and optimizing the things that have been done to my
script...  thanks!)

-- 
Matthias Andree

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13 13:27               ` Tomas Szepe
  2002-05-13 13:42                 ` Russell King
@ 2002-05-13 15:12                 ` Larry McVoy
  2002-05-13 15:29                   ` Tomas Szepe
  1 sibling, 1 reply; 75+ messages in thread
From: Larry McVoy @ 2002-05-13 15:12 UTC (permalink / raw)
  To: Tomas Szepe; +Cc: Russell King, Dave Gilbert (Home), Rik van Riel, linux-kernel


In case you don't know, there is piles of information available from
BK about the changes made, you can make the reposrting be as verbose 
or as terse as you want.  You can also restrict output to a particular
user or expression.

Examples:

	bk changes 	# gets you the default output, time sorted changesets
	bk changes -v	# same thing but includes file comments as well

BK reporting is keyed off of somehing called "dspecs" (for data
specification).  They are a lot like a primitive printf format.
The default dspec for changes is

	":DPN:@:I:, :Dy:-:Dm:-:Dd: :T::TZ:, :P:$if(:HT:){@:HT:}\n$each(:C:){  (:C:)\n}$each(:TAG:){  TAG: (:TAG:)\n}\n"

You can use dspecs to dig out anything you want, see "bk help prs" to get
the list of fields available.  A field is like :P: which is replaced with
the name of the person who made the checkin.

If you want to restrict output to a particular programmer, you can do stuff

	-d'$if(:P:=torvalds){:P:@nospam.com}'

I suspect that once you figure out how you want things to look, we can make
dspecs which do it, and if not, we'll fix the reporting engine.

Just as an FYI, bkweb is really little more than some gigantic dspecs.
-- 
---
Larry McVoy            	 lm at bitmover.com           http://www.bitmover.com/lm 

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13 14:06                   ` Greg KH
@ 2002-05-13 15:11                     ` Tomas Szepe
  2002-05-13 14:51                       ` Greg KH
  2002-05-13 15:21                     ` Matthias Andree
  1 sibling, 1 reply; 75+ messages in thread
From: Tomas Szepe @ 2002-05-13 15:11 UTC (permalink / raw)
  To: Greg KH
  Cc: Marcus Alanen, matthias.andree, riel, Johnny Mnemonic, linux-kernel

> On Mon, May 13, 2002 at 04:45:19PM +0200, Tomas Szepe wrote:
>
> > > > Somebody make the mode changeable via command-line option...
> > > 
> > > Done... in a slightly different manner :)
> 
> What would be even _nicer_ is to remove the dependency on the changelog
> script entirely (right now you have to pipe the output through this perl
> script to get the results.)
> 
> The script that Linus (and others) uses can be found at:
> 	http://gkernel.bkbits.net:8080/BK-kernel-tools/anno/changelog@1.5?nav=index.html|src/

Hmm that could be done of course, but... why?
1) One more pipe can't hurt.
2) Linus himself requested a perl script that'd take the changelog as input.

T.

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13 15:11                     ` Tomas Szepe
@ 2002-05-13 14:51                       ` Greg KH
  2002-05-13 15:58                         ` Matthias Andree
  0 siblings, 1 reply; 75+ messages in thread
From: Greg KH @ 2002-05-13 14:51 UTC (permalink / raw)
  To: Tomas Szepe
  Cc: Marcus Alanen, matthias.andree, riel, Johnny Mnemonic, linux-kernel

On Mon, May 13, 2002 at 05:11:21PM +0200, Tomas Szepe wrote:
> > 
> > What would be even _nicer_ is to remove the dependency on the changelog
> > script entirely (right now you have to pipe the output through this perl
> > script to get the results.)
> > 
> > The script that Linus (and others) uses can be found at:
> > 	http://gkernel.bkbits.net:8080/BK-kernel-tools/anno/changelog@1.5?nav=index.html|src/
> 
> Hmm that could be done of course, but... why?
> 1) One more pipe can't hurt.
> 2) Linus himself requested a perl script that'd take the changelog as input.

Because we were throwing out things we wished the script could handle?
It's just a suggestion.  :)

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13 14:08               ` Tomas Szepe
@ 2002-05-13 14:45                 ` Tomas Szepe
  2002-05-13 14:06                   ` Greg KH
  2002-05-13 22:05                   ` Robinson Maureira Castillo
  0 siblings, 2 replies; 75+ messages in thread
From: Tomas Szepe @ 2002-05-13 14:45 UTC (permalink / raw)
  To: Marcus Alanen
  Cc: matthias.andree, riel, Johnny Mnemonic, linux-kernel, Russell King

> > Somebody make the mode changeable via command-line option...
> 
> Done... in a slightly different manner :)
> 
> cl:
> - clean up
> - indentation
> - CMODE environment variable
> 
> ./fmt /usr/src/ChangeLog-2.5.14			gives output in orig. mode
> CMODE=2 ./fmt /usr/src/ChangeLog-2.5.14		gives output in orig. mode
> CMODE=1 ./fmt /usr/src/ChangeLog-2.5.14		gives output in full mode
> CMODE=0 ./fmt /usr/src/ChangeLog-2.5.14		gives output in terse mode

Version 0.91.
	- Add a missing "last;" statement (major major speedup! :D)
	- Add a couple comments
	- More indentation changes and cleanups


#!/usr/bin/perl -w
#
# This Perl script is meant to simplify/beautify BK ChangeLogs
# for the linux kernel.
#
# (C) Copyright 2002 by Matthias Andree <matthias.andree@gmx.de>,
#			Marcus Alanen <maalanen@abo.fi>,
#			Tomas Szepe <szepe@pinerecords.com>
#
# Version 0.91.
# (Please don't bump this if you've just added another email-to-name
# mapping entry to the db.)
#
# ------------------------------------------------------------------
# Distribution of this script is permitted under the terms of the
# GNU General Public License (GNU GPL) v2.
# ------------------------------------------------------------------
#
# This program expects its input in the following format:
# (E-Mail Addresses MUST NOT bear leading whitespace!)
#
# <email@ddr.ess>
#	changelog text
#	more changelog text
# <email@ddr.ess>
#	yet another changelog
# <another@add.ress>
#	changelog #3
#	more lines
#
# Groups and sorts the entries by email address:
#
# another@add.ress:
#	changelog #3
# email@ddr.ess
#	changelog text
#	yet another changelog
#
# There are three different modes:
# - Short mode (one changelog == one line)
# - Full mode (changelogs separated by dashed line)
# - Original mode (one line consisting of changelog and author)
#
# Where possible, also adds the real name of the author using
# a static hash %addresses
#

use strict;

# CMODE environment variable selects output mode:
# 0 for short, 1 for full, 2 for "original changelog"
# (default is 2 if $CMODE unset)
#
my $mode = 2;
foreach my $en (keys(%ENV)) {
	if ($en eq "CMODE") {
		$mode = $ENV{CMODE};
		if ($mode ne "0" && $mode ne "1" && $mode ne "2") {
			print "CMODE has to be 0 for short, 1 for full, 2 for orig. Undefined defaults to 2.\n";
			die();
		}
		last;
	}
}

# minimum space between entry and author for the original mode
my $space = 5;

# the key is the email address in ALL LOWER CAPS!
# the value is the real name of the person
#
my %addresses = (
	'aia21@cantab.net'			=> 'Anton Altaparmakov',
	'ak@muc.de'				=> 'Andi Kleen',
	'akpm@zip.com.au'			=> 'Andrew Morton',
	'alan@lxorguk.ukuu.org.uk'		=> 'Alan Cox',
	'andrea@suse.de'			=> 'Andrea Arcangeli',
	'ankry@green.mif.pg.gda.pl'		=> 'Andrzej Krzysztofowicz',
	'axboe@suse.de'				=> 'Jens Axboe',
	'bgerst@didntduck.org'			=> 'Brian Gerst',
	'dalecki@evision-ventures.com'		=> 'Martin Dalecki',
	'davem@redhat.com'			=> 'David S. Miller',
	'davidel@xmailserver.org'		=> 'Davide Libenzi',
	'green@namesys.com'			=> 'Oleg Drokin',
	'hch@infradead.org'			=> 'Christoph Hellwig',
	'jgarzik@mandrakesoft.com'		=> 'Jeff Garzik',
	'jsimmons@heisenberg.transvirtual.com'	=> 'James Simmons',
	'jsimmons@transvirtual.com'		=> 'James Simmons',
	'kaos@ocs.com.au'			=> 'Keith Owens',
	'lm@bitmover.com'			=> 'Larry McVoy',
	'manfred@colorfullife.com'		=> 'Manfred Spraul',
	'neilb@cse.unsw.edu.au'			=> 'Neil Brown',
	'paulus@samba.org'			=> 'Paul Mackerras',
	'perex@suse.cz'				=> 'Jaroslav Kysela',
	'rgooch@ras.ucalgary.ca'		=> 'Richard Gooch',
	'rmk@arm.linux.org.uk'			=> 'Russell King',
	'szepe@pinerecords.com'			=> 'Tomas Szepe',
	'torvalds@transmeta.com'		=> 'Linus Torvalds',
	'viro@math.psu.edu'			=> 'Alexander Viro',
	'~~~~thisentrylastforconvenience~~~~'	=> 'Cesar Brutus Anonymous'
);

my %people = ();
my $addr = "";
my @cur = ();

sub append_item()
{
	if (!$addr) {
		return;
	}
	if (!$people{$addr}) {
		@{$people{$addr}} = ();
	}
	push @{$people{$addr}}, [@cur];

	@cur = ();
}

# get name associated to an email address
sub rmap_address
{
	my @o = map {defined $addresses{lc $_} ? $addresses{lc $_} : $_ } @_;
	return wantarray ? @o : $o[0];
}

sub print_items($)
{
	my $person = $_[0];
	my $realname = rmap_address($person);
	my @items = @{$people{$person}};

	# Vain attempt to sort patches from one address
	@items = sort @items;
	if ($mode == 0 or $mode == 1) {
		if ($realname ne $person) {
			print "$realname ";
		}
		print "<$person>\n";
	}
	while ($_ = shift @items) {
		if ($mode == 0) {
			print "\to " . @$_[0];
		} elsif ($mode == 1) {
			print "\t------------------------------------------------------------\n";
			foreach $_ (@$_) {
				print "\t$_";
			}
		} elsif ($mode == 2) {
			$_ = @$_[0];
			chop;
			$_ = "o $_";
			# Split it onto two lines if necessary
			if (length("$_ . $realname") > 76 - $space) {
				print "$_\n" . " " x (76 - length($realname)) . "$realname\n";
			} else {
				print "$_" . " " x (76 - length($realname) - length($_)) . "$realname\n";
			}
		}
	}
}

while (<>)
{
	# Match address
	if (/^<([^>]+)>/) {
		# Add old item (if any) before beginning new
		append_item();
		$addr = $1;
	} elsif ($addr) {
		# Add line to patch
		s/^\s*(.*)\s*$/$1/;
		s/\[?PATCH\]?\s*//i;
		push @cur, "$_\n";
	} else {
		# Header information
		print;
	}
}
append_item();

# Print the information
foreach $addr (sort keys %people) {
	print_items($addr);
	if ($mode != 2) { print "\n"; }
}

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13 13:08             ` Marcus Alanen
@ 2002-05-13 14:08               ` Tomas Szepe
  2002-05-13 14:45                 ` Tomas Szepe
  0 siblings, 1 reply; 75+ messages in thread
From: Tomas Szepe @ 2002-05-13 14:08 UTC (permalink / raw)
  To: Marcus Alanen
  Cc: matthias.andree, riel, Johnny Mnemonic, linux-kernel, Russell King

> Somebody make the mode changeable via command-line option...

Done... in a slightly different manner :)

cl:
- clean up
- indentation
- CMODE environment variable

./fmt /usr/src/ChangeLog-2.5.14			gives output in orig. mode
CMODE=2 ./fmt /usr/src/ChangeLog-2.5.14		gives output in orig. mode
CMODE=1 ./fmt /usr/src/ChangeLog-2.5.14		gives output in full mode
CMODE=0 ./fmt /usr/src/ChangeLog-2.5.14		gives output in terse mode


#!/usr/bin/perl -w
#
# This Perl script is meant to simplify/beautify BK ChangeLogs
# for the linux kernel.
#
# (C) Copyright 2002 by Matthias Andree <matthias.andree@gmx.de>,
#			Marcus Alanen <maalanen@abo.fi>,
#			Tomas Szepe <szepe@pinerecords.com>
#
# Version 0.90.
#
# ------------------------------------------------------------------
# Distribution of this script is permitted under the terms of the
# GNU General Public License (GNU GPL) v2.
# ------------------------------------------------------------------
#
# This program expects its input in the following format:
# (E-Mail Addresses MUST NOT bear leading whitespace!)
#
# <email@ddr.ess>
#	changelog text
#	more changelog text
# <email@ddr.ess>
#	yet another changelog
# <another@add.ress>
#	changelog #3
#	more lines
#
# Groups and sorts the entries by email address:
#
# another@add.ress:
#	changelog #3
# email@ddr.ess
#	changelog text
#	yet another changelog
#
# There are three different modes:
# - Short mode (one changelog == one line)
# - Full mode (changelogs separated by dashed line)
# - Original mode (one line consisting of changelog and author)
#
# Where possible, also adds the real name of the author using
# a static hash %addresses
#

use strict;

# CMODE environment variable selects output mode:
# 0 for short, 1 for full, 2 for "original changelog"
# (default is 2 if $CMODE unset)
#
my $mode = 2;
foreach my $en (keys(%ENV)) {
	if ($en eq "CMODE") {
		$mode = $ENV{CMODE};
		if ($mode ne "0" && $mode ne "1" && $mode ne "2") {
			print "CMODE has to be 0 for short, 1 for full, 2 for orig. Undefined defaults to 2.\n";
			die();
		}
	}
}

# minimum space between entry and author for the original mode
my $space = 5;

# the key is the email address in ALL LOWER CAPS!
# the value is the real name of the person
my %addresses = (
	'aia21@cantab.net' => 'Anton Altaparmakov',
	'ak@muc.de' => 'Andi Kleen',
	'akpm@zip.com.au' => 'Andrew Morton',
	'alan@lxorguk.ukuu.org.uk' => 'Alan Cox',
	'andrea@suse.de' => 'Andrea Arcangeli',
	'ankry@green.mif.pg.gda.pl' => 'Andrzej Krzysztofowicz',
	'axboe@suse.de' => 'Jens Axboe',
	'bgerst@didntduck.org' => 'Brian Gerst',
	'dalecki@evision-ventures.com' => 'Martin Dalecki',
	'davem@redhat.com' => 'David S. Miller',
	'davidel@xmailserver.org' => 'Davide Libenzi',
	'green@namesys.com' => 'Oleg Drokin',
	'hch@infradead.org' => 'Christoph Hellwig',
	'jgarzik@mandrakesoft.com' => 'Jeff Garzik',
	'jsimmons@heisenberg.transvirtual.com' => 'James Simmons',
	'jsimmons@transvirtual.com' => 'James Simmons',
	'kaos@ocs.com.au' => 'Keith Owens',
	'lm@bitmover.com' => 'Larry McVoy',
	'manfred@colorfullife.com' => 'Manfred Spraul',
	'neilb@cse.unsw.edu.au' => 'Neil Brown',
	'paulus@samba.org' => 'Paul Mackerras',
	'perex@suse.cz' => 'Jaroslav Kysela',
	'rgooch@ras.ucalgary.ca' => 'Richard Gooch',
	'rmk@arm.linux.org.uk' => 'Russell King',
	'szepe@pinerecords.com' => 'Tomas Szepe',
	'torvalds@transmeta.com' => 'Linus Torvalds',
	'viro@math.psu.edu' => 'Alexander Viro',
	'~~~~~~thisentrylastforconvenience~~~~~' => 'Cesar Brutus Anonymous'
);

my %people = ();
my $addr = "";
my @cur = ();

sub append_item()
{
	if (!$addr) {
		return;
	}
	if (!$people{$addr}) {
		@{$people{$addr}} = ();
	}
	push @{$people{$addr}}, [@cur];

	@cur = ();
}

# get name associated to an email address
sub rmap_address
{
	my @o = map {defined $addresses{lc $_} ? $addresses{lc $_} : $_ } @_;
	return wantarray ? @o : $o[0];
}

sub print_items($)
{
	my $person = $_[0];
	my $realname = rmap_address($person);
	my @items = @{$people{$person}};
	# Vain attempt to sort patches from one address
	@items = sort @items;
	if ($mode == 0 or $mode == 1) {
		if ($realname ne $person) {
			print "$realname ";
		}
		print "<$person>\n";
	}
	while ($_ = shift @items) {
		if ($mode == 0) {
			print "\to " . @$_[0];
		} elsif ($mode == 1) {
			print "\t------------------------------------------------------------\n";
			foreach $_ (@$_) {
				print "\t$_";
			}
		} elsif ($mode == 2) {
			$_ = @$_[0];
			chop;
			$_ = "o $_";
			# Split it onto two lines if necessary
			if (length("$_ . $realname") > 76 - $space) {
				print ("$_\n" . " " x (76-length($realname)) . "$realname\n");
			} else {
				print ("$_" . " " x (76-length($realname)-length($_)) . "$realname\n");
			}
		}
	}
}

while (<>)
{
	# Match address
	if (/^<([^>]+)>/) {
		# Add old item (if any) before beginning new
		append_item();
		$addr = $1;
	} elsif ($addr) {
		# Add line to patch
		s/^\s*(.*)\s*$/$1/;
		$_ =~ s/\[?PATCH\]?\s*//i;
		push @cur, "$_\n";
	} else {
		# Header information
		print;
	}
}
append_item();

# Print the information
foreach $addr (sort keys %people) {
	print_items($addr);
	if ($mode != 2) { print "\n"; }
}

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13 14:45                 ` Tomas Szepe
@ 2002-05-13 14:06                   ` Greg KH
  2002-05-13 15:11                     ` Tomas Szepe
  2002-05-13 15:21                     ` Matthias Andree
  2002-05-13 22:05                   ` Robinson Maureira Castillo
  1 sibling, 2 replies; 75+ messages in thread
From: Greg KH @ 2002-05-13 14:06 UTC (permalink / raw)
  To: Tomas Szepe
  Cc: Marcus Alanen, matthias.andree, riel, Johnny Mnemonic, linux-kernel

On Mon, May 13, 2002 at 04:45:19PM +0200, Tomas Szepe wrote:
> > > Somebody make the mode changeable via command-line option...
> > 
> > Done... in a slightly different manner :)

What would be even _nicer_ is to remove the dependency on the changelog
script entirely (right now you have to pipe the output through this perl
script to get the results.)

The script that Linus (and others) uses can be found at:
	http://gkernel.bkbits.net:8080/BK-kernel-tools/anno/changelog@1.5?nav=index.html|src/

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13 13:27               ` Tomas Szepe
@ 2002-05-13 13:42                 ` Russell King
  2002-05-13 15:12                 ` Larry McVoy
  1 sibling, 0 replies; 75+ messages in thread
From: Russell King @ 2002-05-13 13:42 UTC (permalink / raw)
  To: Tomas Szepe; +Cc: Dave Gilbert (Home), Rik van Riel, linux-kernel

On Mon, May 13, 2002 at 03:27:34PM +0200, Tomas Szepe wrote:
> How's this for another try? (logwidth = 38, adjustable per taste)
> Myself I'd say this is crap and a nice 140-char xterm will do much
> better (you're going to see "long" lines anyway, look at the NTFS
> entry below).

heh.  I agree with the first bit of your second line there 8)

However, Marcus Alanen has posted something (in "original mode") that
looks a lot nicer.  In fact, its quite close to my release note
formatting, see:

http://lists.arm.linux.org.uk/pipermail/linux-arm-announce/2002-April/000186.html


-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html


^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13 13:01             ` Russell King
@ 2002-05-13 13:27               ` Tomas Szepe
  2002-05-13 13:42                 ` Russell King
  2002-05-13 15:12                 ` Larry McVoy
  0 siblings, 2 replies; 75+ messages in thread
From: Tomas Szepe @ 2002-05-13 13:27 UTC (permalink / raw)
  To: Russell King; +Cc: Dave Gilbert (Home), Rik van Riel, linux-kernel

> > > Alright, another one.
> > > 
> > > $ ./fmtcl2.pl /usr/src/ChangeLog-2.5.14
> > > 
> > > Summary of changes from v2.5.13 to v2.5.14
> > > ============================================
> > > 
> > > o  kd.h                                                                             (Andries.Brouwer@cwi.nl)
> > > o  NTFS: Release 2.0.6 - Major bugfix to make compatible with other kernel changes. (aia21@cantab.net)
> > > o  mm/memory.c:                                                                     (aia21@cantab.net)
> > > o  suppress allocation warnings for radix-tree allocations                          (akpm@zip.com.au)
> > 
> > <snip>
> > 
> > Ah - thats it!
> 
> Not quite.  In mutt, it looks like this:
> 
> o  kd.h
> +(Andries.Brouwer@cwi.nl)
> o  NTFS: Release 2.0.6 - Major bugfix to make compatible with other kernel
> +changes. (aia21@cantab.net)
> o  mm/memory.c:
> +(aia21@cantab.net)
> o  suppress allocation warnings for radix-tree allocations
> +(akpm@zip.com.au)
> o  radix-tree locking fix
> +(akpm@zip.com.au)
> o  Allow truncate to discard unmapped buffers
> +(akpm@zip.com.au)
> o  decouple swapper_space treatment from other address_spaces
> 
> NOT easy to read.

Hmm, now that's true.

How's this for another try? (logwidth = 38, adjustable per taste)
Myself I'd say this is crap and a nice 140-char xterm will do much
better (you're going to see "long" lines anyway, look at the NTFS
entry below).

$ ./fmtcl3.pl /usr/src/ChangeLog-2.5.14

Summary of changes from v2.5.13 to v2.5.14
============================================

o  kd.h                                (Andries.Brouwer@cwi.nl)
o  NTFS: Release 2.0.6 - Major bugfix to make compatible with other kernel changes.
                                       (aia21@cantab.net)
o  mm/memory.c:                        (aia21@cantab.net)
o  suppress allocation warnings for radix-tree allocations
                                       (akpm@zip.com.au)
o  radix-tree locking fix              (akpm@zip.com.au)
o  Allow truncate to discard unmapped buffers
                                       (akpm@zip.com.au)
o  decouple swapper_space treatment from other address_spaces
                                       (akpm@zip.com.au)
o  Allow ext3 pages to be written back by VM pressure
                                       (akpm@zip.com.au)
o  Fix SMP race in truncate            (akpm@zip.com.au)
o  handle concurrent block_write_full_page and set_page_dirty
                                       (akpm@zip.com.au)
o  Fix PG_launder                      (akpm@zip.com.au)
o  Fix concurrent writepage and readpage
                                       (akpm@zip.com.au)
<snip>


#!/usr/bin/perl -w

use strict;

my $logwidth = 38;

my %people = ();
my $addr = "";
my @cur = ();

sub append_item()
{
	if (!$addr) { return; }
	if (!$people{$addr}) { @{$people{$addr}} = (); }
	push @{$people{$addr}}, [@cur];

	@cur = ();
}

sub print_terse_items($)
{
	my @items = @{$people{$_[0]}};
	while ($_ = shift @items) {
		my $len = length(@$_[0]);
		my $fill = ($len <= $logwidth) ? (" " x ($logwidth - $len + 1)) : ("\n" . (" " x ($logwidth + 1)));
		print "@$_[0]$fill($_[0])\n";
	}
}

while (<>) {
	# Match address
	if (/^\s*<([^>]+)>/) {
		# Add old item (if any) before beginning new
		append_item();
		$addr = $1;
	} elsif ($addr) {
		# Add line to patch
		# strip whitespace at start & end
		s/^\s*(.*)\s*$/$1/;
		# kill starting 'PATCH' captions
		s/\s*\[?PATCH\]?\s*//;
		# insert a bullet
		s/^(.*)$/o  $1/;
		# Only save 1 line
		if (scalar(@cur) < 1) { push @cur, "$_"; }
	} else {
		# Header information
		print;
	}
}

append_item();
foreach $addr (sort keys %people) {
	print_terse_items($addr);
}

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13 12:09           ` Tomas Szepe
@ 2002-05-13 13:08             ` Marcus Alanen
  2002-05-13 14:08               ` Tomas Szepe
  0 siblings, 1 reply; 75+ messages in thread
From: Marcus Alanen @ 2002-05-13 13:08 UTC (permalink / raw)
  To: matthias.andree, Tomas Szepe; +Cc: riel, Johnny Mnemonic, linux-kernel

On Mon, 13 May 2002, Tomas Szepe wrote:

> > The original mode you requested prints the e-mail address, I guess
> > it should be the author's real name to look more nice.
> Okay.. how about the name db? That seems to be the last feature missing.

Yes, ok with Matthias I hope?

> s/^\s*(.*)\s*$/$1/;
> s/^\[?PATCH\]?\s*//;
> 
> will be sufficient I believe. Also, the "/g" is not a good idea.

Agreed. Added /i for case-insensitivity. Also, e-mail addresses must 
be at beginning of line, otherwise it is too easily confused.

Somebody make the mode changeable via command-line option...

So is any of this usable?





Short mode:

<adam@nmt.edu>
        o 3ware driver update for 2.5.8-pre1
 
<adilger@clusterfs.com>
        o Add three scripts for BK users, to Documentation/BK-usage:
 
<agrover@dexter.groveronline.com>
        o ACPI interpreter update.
        o MADT parsing improvements (Paul D & Richard Schaal)
        o ACPI driver updates


Original mode:

o loop deadlock fix                                            Andrew Morton
o ->setattr() locking changes                                  Andrew Morton
o Various minor bug fixes for 3c59x net driver.                Andrew Morton
o This fixes the "i_blocks went wrong when the disk filled up"
                                                               Andrew Morton
o ext3 filesystem sync mount speedup:                          Andrew Morton
o ext2_fill_super breakage                                     Andrew Morton
o Fix jiffies-comparison timeout bug in arlan net driver.           Alan Cox
o ppc64: update for pte in highmem changes                   anton@samba.org



#!/usr/bin/perl -w

# This Perl script is meant to simplify BK ChangeLogs for the linux
# kernel.
#
# (C) Copyright 2002 by Matthias Andree <matthias.andree@gmx.de>,
#                       Marcus Alanen   <maalanen@abo.fi>
#
# ----------------------------------------------------------------------
# Distribution of this script is permitted under the terms of the
# GNU General Public License (GNU GPL) v2.
# ----------------------------------------------------------------------

# This program expects its input in the following format:
# (E-Mail Addresses MUST NOT bear leading white space!)
#
# <email@ddr.ess>
#   changelog text
#   more changelog text
# <email@ddr.ess>
#   yet another changelog
# <another@add.ress>
#   changelog #3
#   more lines
#
# Groups and sorts the entries by email address:
#
# another@add.ress:
#   changelog #3
# email@ddr.ess
#   changelog text
#   yet another changelog
#
# There are three different modes:
# - Short mode (one changelog == one line)
# - Full mode  (changelogs separated by dashed line)
# - Original mode (one line consisting of changelog and author)
#
# Where possible, also adds the real name of the author using
# a static hash %addresses
#

use strict;


# 0 for short, 1 for full, 2 for "original changelog"
my $mode = 2;



# minimum space between entry and author for the original mode
my $space = 5;


# the key is the email address in ALL LOWER CAPS!
# the value is the real name of the person
my %addresses = (
'aia21@cantab.net' => 'Anton Altaparmakov',
'ak@muc.de' => 'Andi Kleen',
'akpm@zip.com.au' => 'Andrew Morton',
'alan@lxorguk.ukuu.org.uk' => 'Alan Cox',
'andrea@suse.de' => 'Andrea Arcangeli',
'ankry@green.mif.pg.gda.pl' => 'Andrzej Krzysztofowicz',
'axboe@suse.de' => 'Jens Axboe',
'bgerst@didntduck.org' => 'Brian Gerst',
'dalecki@evision-ventures.com' => 'Martin Dalecki',
'davem@redhat.com' => 'David S. Miller',
'davidel@xmailserver.org' => 'Davide Libenzi',
'green@namesys.com' => 'Oleg Drokin',
'hch@infradead.org' => 'Christoph Hellwig',
'jgarzik@mandrakesoft.com' => 'Jeff Garzik',
'jsimmons@heisenberg.transvirtual.com' => 'James Simmons',
'jsimmons@transvirtual.com' => 'James Simmons',
'kaos@ocs.com.au' => 'Keith Owens',
'lm@bitmover.com' => 'Larry McVoy',
'manfred@colorfullife.com' => 'Manfred Spraul',
'neilb@cse.unsw.edu.au' => 'Neil Brown',
'paulus@samba.org' => 'Paul Mackerras',
'perex@suse.cz' => 'Jaroslav Kysela',
'rgooch@ras.ucalgary.ca' => 'Richard Gooch',
'rmk@arm.linux.org.uk' => 'Russell King',
'szepe@pinerecords.com' => 'Tomas Szepe',
'torvalds@transmeta.com' => 'Linus Torvalds',
'viro@math.psu.edu' => 'Alexander Viro',
'~~~~~~thisentrylastforconvenience~~~~~' => 'Cesar Brutus Anonymous'
);




my %people = ();
my $addr = "";
my @cur = ();


sub append_item() {
        if (!$addr) {
                return;
        }
        if (!$people{$addr}) {
                @{$people{$addr}} = ();
        }
        push @{$people{$addr}}, [@cur];

        @cur = ();
}

while (<>) {
        # Match address
        if (/^<([^>]+)>/) {
                # Add old item (if any) before beginning new
                append_item();
                $addr = $1;
        } elsif ($addr) {
                # Add line to patch
                s/^\s*(.*)\s*$/$1/;
                $_ =~ s/\[?PATCH\]?\s*//i;
		push @cur, "$_\n";
        } else {
                # Header information
                print;
        }
}
append_item();


# get name associated to an email address
sub rmap_address {
  #my @i = map { lc; } @_;
  my @o = map {defined $addresses{lc $_} ? $addresses{lc $_} : $_ } @_;
  return wantarray ? @o : $o[0];
}

sub print_items($) {
        my $person = $_[0];
	my $realname = rmap_address($person);
        my @items = @{$people{$person}};
        # Vain attempt to sort patches from one address
        @items = sort @items;
	if ($mode == 0 or $mode == 1) {
	        if ($realname ne $person) {
		        print "$realname ";
		}
                print "<$person>\n";
	}
        while ($_ = shift @items) {
	        if ($mode == 0) {
		        print "\to " . @$_[0];
	        } elsif ($mode == 1) {
		        print "\t------------------------------------------------------------\n";
                        foreach $_ (@$_) {
			        print "\t$_";
			}
		} elsif ($mode == 2) {
		        $_ = @$_[0];
			chop;
			$_ = "o $_";
			# Split it onto two lines if necessary
		        if (length("$_ . $realname") > 76 - $space) {
			        print ("$_\n" . " " x (76-length($realname)) . "$realname\n");
			} else {
			        print ("$_" . " " x (76-length($realname)-length($_)) . "$realname\n");
			}
		}
        }
}

# Print the information
foreach $addr (sort keys %people) {
        print_items($addr);
        if ($mode != 2) { print "\n"; }
}


-- 
Marcus Alanen * Department of Computer Science * http://www.cs.abo.fi/
maalanen@abo.fi


^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13 12:39           ` Dave Gilbert (Home)
@ 2002-05-13 13:01             ` Russell King
  2002-05-13 13:27               ` Tomas Szepe
  0 siblings, 1 reply; 75+ messages in thread
From: Russell King @ 2002-05-13 13:01 UTC (permalink / raw)
  To: Dave Gilbert (Home); +Cc: Tomas Szepe, Rik van Riel, linux-kernel

On Mon, May 13, 2002 at 01:39:54PM +0100, Dave Gilbert (Home) wrote:
> Tomas Szepe wrote:
> 
> > Alright, another one.
> > 
> > $ ./fmtcl2.pl /usr/src/ChangeLog-2.5.14
> > 
> > Summary of changes from v2.5.13 to v2.5.14
> > ============================================
> > 
> > o  kd.h                                                                             (Andries.Brouwer@cwi.nl)
> > o  NTFS: Release 2.0.6 - Major bugfix to make compatible with other kernel changes. (aia21@cantab.net)
> > o  mm/memory.c:                                                                     (aia21@cantab.net)
> > o  suppress allocation warnings for radix-tree allocations                          (akpm@zip.com.au)
> 
> <snip>
> 
> Ah - thats it!

Not quite.  In mutt, it looks like this:

o  kd.h
+(Andries.Brouwer@cwi.nl)
o  NTFS: Release 2.0.6 - Major bugfix to make compatible with other kernel
+changes. (aia21@cantab.net)
o  mm/memory.c:
+(aia21@cantab.net)
o  suppress allocation warnings for radix-tree allocations
+(akpm@zip.com.au)
o  radix-tree locking fix
+(akpm@zip.com.au)
o  Allow truncate to discard unmapped buffers
+(akpm@zip.com.au)
o  decouple swapper_space treatment from other address_spaces

NOT easy to read.

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html


^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13 10:12       ` Tomas Szepe
  2002-05-13 10:17         ` Tomas Szepe
@ 2002-05-13 13:00         ` Ian Molton
  1 sibling, 0 replies; 75+ messages in thread
From: Ian Molton @ 2002-05-13 13:00 UTC (permalink / raw)
  To: Tomas Szepe; +Cc: torvalds, gilbertd, linux-kernel

On Mon, 13 May 2002 12:12:28 +0200
Tomas Szepe <szepe@pinerecords.com> wrote:

> > [Linus Torvalds <torvalds@transmeta.com>, May-12 2002, Sun, 18:56
> > -0700]
> >
> > As an example, if the long version looks like this:
> > ...
> > The short version could look like
> > ...
> 
> How's this? (script attached)

very nice :)

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13 11:58         ` Tomas Szepe
@ 2002-05-13 12:39           ` Dave Gilbert (Home)
  2002-05-13 13:01             ` Russell King
  0 siblings, 1 reply; 75+ messages in thread
From: Dave Gilbert (Home) @ 2002-05-13 12:39 UTC (permalink / raw)
  To: Tomas Szepe; +Cc: Rik van Riel, linux-kernel

Tomas Szepe wrote:

> Alright, another one.
> 
> $ ./fmtcl2.pl /usr/src/ChangeLog-2.5.14
> 
> Summary of changes from v2.5.13 to v2.5.14
> ============================================
> 
> o  kd.h                                                                             (Andries.Brouwer@cwi.nl)
> o  NTFS: Release 2.0.6 - Major bugfix to make compatible with other kernel changes. (aia21@cantab.net)
> o  mm/memory.c:                                                                     (aia21@cantab.net)
> o  suppress allocation warnings for radix-tree allocations                          (akpm@zip.com.au)

<snip>

Ah - thats it!



^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13 11:52         ` Marcus Alanen
@ 2002-05-13 12:09           ` Tomas Szepe
  2002-05-13 13:08             ` Marcus Alanen
  0 siblings, 1 reply; 75+ messages in thread
From: Tomas Szepe @ 2002-05-13 12:09 UTC (permalink / raw)
  To: Marcus Alanen; +Cc: riel, Johnny Mnemonic, linux-kernel

> [Marcus Alanen <marcus@infa.abo.fi>, May-13 2002, Mon, 14:52 +0300]
> 
> Combining the efforts, the following almost makes coffee.

Neat!

> - Short mode
> - Full mode
> - Original mode
> 
> The original mode you requested prints the e-mail address, I guess
> it should be the author's real name to look more nice.

Okay.. how about the name db? That seems to be the last feature missing.

>                 s/^\s*(.*)\s*$/$1/;
>                 $_ =~ s/\[PATCH\] //g;
>                 $_ =~ s/\s*PATCH //g;

s/^\s*(.*)\s*$/$1/;
s/^\[?PATCH\]?\s*//;

will be sufficient I believe. Also, the "/g" is not a good idea.


T.

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13  0:46       ` Rik van Riel
  2002-05-13 11:52         ` Marcus Alanen
@ 2002-05-13 11:58         ` Tomas Szepe
  2002-05-13 12:39           ` Dave Gilbert (Home)
  1 sibling, 1 reply; 75+ messages in thread
From: Tomas Szepe @ 2002-05-13 11:58 UTC (permalink / raw)
  To: Rik van Riel; +Cc: linux-kernel

> > I agree. If developers need that changelog style it's fine, but on kernel.org
> > homepage there should the old changelog format, so everyone can read it.
> > The best changelog i've ever seen is the one used around ~2.4.9 release
> >
> >  - changedescription                         (author)
> 
> So, is there anybody willing to put together the scripts to
> generate this changelog format automatically ?

Alright, another one.

$ ./fmtcl2.pl /usr/src/ChangeLog-2.5.14

Summary of changes from v2.5.13 to v2.5.14
============================================

o  kd.h                                                                             (Andries.Brouwer@cwi.nl)
o  NTFS: Release 2.0.6 - Major bugfix to make compatible with other kernel changes. (aia21@cantab.net)
o  mm/memory.c:                                                                     (aia21@cantab.net)
o  suppress allocation warnings for radix-tree allocations                          (akpm@zip.com.au)
o  radix-tree locking fix                                                           (akpm@zip.com.au)
o  Allow truncate to discard unmapped buffers                                       (akpm@zip.com.au)
o  decouple swapper_space treatment from other address_spaces                       (akpm@zip.com.au)
o  Allow ext3 pages to be written back by VM pressure                               (akpm@zip.com.au)
o  Fix SMP race in truncate                                                         (akpm@zip.com.au)
o  handle concurrent block_write_full_page and set_page_dirty                       (akpm@zip.com.au)
o  Fix PG_launder                                                                   (akpm@zip.com.au)
o  Fix concurrent writepage and readpage                                            (akpm@zip.com.au)
o  Documentation update                                                             (akpm@zip.com.au)
o  remove PRD_SEGMENTS                                                              (axboe@suse.de)
o  2.5.13 IDE 50                                                                    (dalecki@evision-ventures.com)
o  2.5.13 IDE 51                                                                    (dalecki@evision-ventures.com)
o  2.5.13 IDE 52                                                                    (dalecki@evision-ventures.com)
o  2.5.13 IDE 53                                                                    (dalecki@evision-ventures.com)
o  [PATCH 2.5.13 IDE 54                                                             (dalecki@evision-ventures.com)
o  remove global_bufferlist_lock                                                    (hch@infradead.org)
o  fix config.in syntax errors.                                                     (hch@infradead.org)
<snip>


#!/usr/bin/perl -w

use strict;

my %people = ();
my $addr = "";
my @cur = ();
my $len = 60;

sub append_item()
{
	if (!$addr) { return; }
	if (!$people{$addr}) { @{$people{$addr}} = (); }
	push @{$people{$addr}}, [@cur];

	@cur = ();
}

sub print_terse_items($)
{
	my @items = @{$people{$_[0]}};
	while ($_ = shift @items) {
		my $fill = (" " x ($len - length(@$_[0]) + 1));
		print "@$_$fill($_[0])\n";
	}
}

while (<>) {
	# Match address
	if (/^\s*<([^>]+)>/) {
		# Add old item (if any) before beginning new
		append_item();
		$addr = $1;
	} elsif ($addr) {
		# Add line to patch
		# strip whitespace at start & end
		s/^\s*(.*)\s*$/$1/;
		# kill starting 'PATCH' captions
		s/\s*\[?PATCH\]?\s*//;
		# insert a bullet
		s/^(.*)$/o  $1/;
		# Only save 1 line
		if (scalar(@cur) < 1) {
			push @cur, "$_";
			# save record line length
			if ((my $nlen = length($_)) > $len) { $len = $nlen; }
		}
	} else {
		# Header information
		print;
	}
}

append_item();
foreach $addr (sort keys %people) {
	print_terse_items($addr);
}

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13  0:46       ` Rik van Riel
@ 2002-05-13 11:52         ` Marcus Alanen
  2002-05-13 12:09           ` Tomas Szepe
  2002-05-13 11:58         ` Tomas Szepe
  1 sibling, 1 reply; 75+ messages in thread
From: Marcus Alanen @ 2002-05-13 11:52 UTC (permalink / raw)
  To: riel, Johnny Mnemonic; +Cc: linux-kernel

>>  - changedescription                         (author)
>So, is there anybody willing to put together the scripts to
>generate this changelog format automatically ?

Combining the efforts, the following almost makes coffee.

- Short mode
- Full mode
- Original mode

The original mode you requested prints the e-mail address, I guess
it should be the author's real name to look more nice.


#!/usr/bin/perl -w

use strict;


# 0 for short, 1 for full, 2 for "original changelog"
my $mode = 2;



# minimum space between entry and author for the original mode
my $space = 5;


my %people = ();
my $addr = "";
my @cur = ();
my $comment = 0;


sub append_item() {
        if (!$addr) {
                return;
        }
        if (!$people{$addr}) {
                @{$people{$addr}} = ();
        }
        push @{$people{$addr}}, [@cur];

        @cur = ();
}

while (<>) {
        # Match address
        if (/^\s*<([^>]+)>/) {
                # Add old item (if any) before beginning new
                append_item();
                $addr = $1;
                $comment = 1;
        } elsif ($addr) {
                # Add line to patch
                s/^\s*(.*)\s*$/$1/;
                $_ =~ s/\[PATCH\] //g;
                $_ =~ s/\s*PATCH //g;
                if ($comment == 1 or $mode != 0) {
                        push @cur, "$_\n";
                        $comment = 0;
                }
        } else {
                # Header information
                print;
        }
}
append_item();


sub print_items($) {
        my $person = $_[0];
        my @items = @{$people{$person}};
        # Vain attempt to sort patches from one address
        @items = sort @items;
	if ($mode == 0 or $mode == 1) {
                print "<$person>\n";
	} else {
	        $person = "($person)";
	}
        while ($_ = shift @items) {
	        if ($mode == 0) {
		        print "\to " . @$_[0];
	        } elsif ($mode == 1) {
		        print "\t------------------------------------------------------------\n";
                        foreach $_ (@$_) {
			        print "\t$_";
			}
		} elsif ($mode == 2) {
		        $_ = @$_[0];
			chop;
			$_ = "- $_";
			# Split it onto two lines if necessary
		        if (length("$_ . $person") > 76 - $space) {
			        print ("$_\n" . " " x (76-length($person)) . "$person\n");
			} else {
			        print ("$_" . " " x (76-length($person)-length($_)) . "$person\n");
			}
		}
        }
}

# Print the information
foreach $addr (sort keys %people) {
        print_items($addr);
        if ($mode != 2) { print "\n"; }
}



-- 
Marcus Alanen
maalanen@abo.fi

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13  8:52         ` Greg KH
@ 2002-05-13 10:41           ` Matthias Andree
  0 siblings, 0 replies; 75+ messages in thread
From: Matthias Andree @ 2002-05-13 10:41 UTC (permalink / raw)
  To: linux-kernel

On Mon, 13 May 2002, Greg KH wrote:

> On Mon, May 13, 2002 at 11:31:42AM +0200, Matthias Andree wrote:
> > 
> > I sent a first version of a Perl program to Linus, a copy of the program
> > is available at
> > http://mandree.home.pages.de/linux/kernel/lk-changelog.pl
> > (Yes I know the first $Log:$ entry is missing.)
> 
> Please make the following change to the patch, otherwise email address
> (or other things within a <>) in the body of the change message are
> improperly picked up.
> 
> Other than that minor problem, looks very nice.

Done, thanks.

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13  5:10       ` Jeff Garzik
  2002-05-13  5:17         ` Larry McVoy
@ 2002-05-13 10:37         ` Helge Hafting
  2002-05-13 19:00           ` Jeff Garzik
  1 sibling, 1 reply; 75+ messages in thread
From: Helge Hafting @ 2002-05-13 10:37 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: linux-kernel

Jeff Garzik wrote:

> (speaking more to the crowd...)
> Changeset comments need to be written as if they stand alone, without
> any other context -- including the author.  A reader should not need to
> know that (for examples) James Simmons hacks on fbdev stuff.

I think it is nice to have the names.  A new kernel
might break something,  It is then nice to know
where to send the bug report. (It is usually, but not
necessarily the maintainer that did it.)

That's why I like a long format, merely with the
_duplicated_ names removed.  I guess people
like to see their name in the changelog too. :-)

Helge Hafting

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-12 22:12       ` Tomas Szepe
@ 2002-05-13 10:32         ` Helge Hafting
  0 siblings, 0 replies; 75+ messages in thread
From: Helge Hafting @ 2002-05-13 10:32 UTC (permalink / raw)
  To: Tomas Szepe; +Cc: linux-kernel

Tomas Szepe wrote:
> 
> > [Marcus Alanen <marcus@infa.abo.fi>, May-13 2002, Mon, 00:42 +0300]
> > In mailing-lists.linux-kernel, you wrote:
> > >torvalds@transmeta.com (Linus Torvalds) writes:
> > >
> > >> Perl is the obvious choice for doing transformations like these. Is
> > >> anybody willing to write a perl script that does the "sort by author"
> > >> thing?
> >
> > [snip]
> > Basically the same, this treats each patch separately:
> 
> I took the liberty of kicking it up another notch :)

Perfect for me.  
I like reading the details, now I don't have to
skip the repeated email addresses over and over.

Helge Hafting

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13 10:12       ` Tomas Szepe
@ 2002-05-13 10:17         ` Tomas Szepe
  2002-05-13 13:00         ` Ian Molton
  1 sibling, 0 replies; 75+ messages in thread
From: Tomas Szepe @ 2002-05-13 10:17 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Dr. David Alan Gilbert, linux-kernel

> [Tomas Szepe <szepe@pinerecords.com>, May-13 2002, Mon, 12:12 +0200]
> > [Linus Torvalds <torvalds@transmeta.com>, May-12 2002, Sun, 18:56 -0700]
> >
> > As an example, if the long version looks like this:
> > ...
> > The short version could look like
> > ...
> 
> How's this? (script attached)

hmmm, forgot to remove this one before submitting (not that it hurts)...

--- fmtcl.pl~	Mon May 13 12:15:51 2002
+++ fmtcl.pl	Mon May 13 12:15:56 2002
@@ -51,7 +51,7 @@
 	while ($_ = shift @items) {
 		# Item separator
 		print "\t--------------------------------------------------------------\n";
-		my $line; foreach $line (@$_) { print "$line"; }
+		print @$_;
 	}
 }

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13  1:56     ` Linus Torvalds
  2002-05-13  9:31       ` Matthias Andree
@ 2002-05-13 10:12       ` Tomas Szepe
  2002-05-13 10:17         ` Tomas Szepe
  2002-05-13 13:00         ` Ian Molton
  1 sibling, 2 replies; 75+ messages in thread
From: Tomas Szepe @ 2002-05-13 10:12 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Dr. David Alan Gilbert, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 53140 bytes --]

> [Linus Torvalds <torvalds@transmeta.com>, May-12 2002, Sun, 18:56 -0700]
>
> As an example, if the long version looks like this:
> ...
> The short version could look like
> ...

How's this? (script attached)

$ ./fmtcl.pl /usr/src/ChangeLog-2.5.15

Summary of changes from v2.5.14 to v2.5.15
============================================

-- Terse ChangeLog starts here --

<acme@brinquedo.oo.ps>
	o  - remove spurious spaces and tabs at end of lines

<acme@conectiva.com.br>
	o  net/ipv4/arp.c:

<aia21@cantab.net>
	o  NTFS: Fix compilation on 2.5.14 ({set_,clear_,}buffer_async was renamed

<akpm@zip.com.au>
	o  [PATCH] Fix: writing to the swap space

<anton@samba.org>
	o  [PATCH] acenic driver and 867 MHz G4 sound problems

<axboe@suse.de>
	o  [PATCH] tcq initialization fix

<colin@gibbs.dhs.org>
	o  copy_mm fix:

<dalecki@evision-ventures.com>
	o  [PATCH] 2.5.14 IDE 55
	o  [PATCH] IDE 58
	o  [PATCH] 2.5.14 IDE 57
	o  [PATCH] 2.5.14 IDE 56
	o  [PATCH] 2.5.14 IDE 59

<davej@suse.de>
	o  [PATCH] capabilities for mtrr driver.
	o  [PATCH] region handling cleanup
	o  [PATCH] region handling cleanup
	o  [PATCH] region handling cleanup
	o  [PATCH] region handling cleanup
	o  [PATCH] CREDITS update
	o  [PATCH] check various return codes in advantechwdt.
	o  [PATCH] IA64 ZX1 AGPGart support.
	o  [PATCH] region handling cleanup
	o  [PATCH] typo.
	o  [PATCH] region handling cleanup
	o  [PATCH] documentation for Cyrix IRQ routing
	o  [PATCH] sonypi update
	o  [PATCH] VIA quirk update.
	o  [PATCH] region handling cleanup
	o  [PATCH] prefetching too far in mem copies
	o  [PATCH] update NBD URL
	o  [PATCH] DMI update.
	o  [PATCH] motioneye driver update.
	o  [PATCH] typo in z2ram driver
	o  [PATCH] simplify wdt285 copying.
	o  [PATCH] dmasound update.
	o  [PATCH] PNPBIOS / floppy conflict.
	o  [PATCH] NCR5380 update.
	o  [PATCH] list macro conversion.
	o  [PATCH] swap file missing error check
	o  [PATCH] HP ZX1 AGP/DRM support.
	o  [PATCH] ptrace bug

<davem@nuts.ninka.net>
	o  net/core/neighbour.c: Delete ancient ASSERT_WL debugging.
	o  Sparc64: Implement pfn_pte.
	o  Sparc64 updates:
	o  Sparc64: Fix thinko in page_to_pfn
	o  Sparc64: Update ioctl32 for bluetooth updates.
	o  soft-fp fix:
	o  Sparc64: Fix pfn_foo macros and add descriptive commentary
	o  Sparc64: Make use of USE_STANDARD_AS_RULE.
	o  SLAB: When using get_user on kernel pointers, enter KERNEL_DS.
	o  Soft-fp fix:
	o  Sparc64: Enter KERNEL_DS when invoking do_sigaltstack with
	o  drivers/usb/net/rtl8150.c: Include linux/init.h
	o  Sparc64: Make pcibios_init a subsys_initcall.
	o  Sparc64: Keep totalram_pages equal to num_physpages.
	o  Sparc: Kill references to buffermem_pages.
	o  asm-sparc64/thread_info.h: Include asm/page.h even if __ASSEMBLY__

<david-b@pacbell.net>
	o  [PATCH] PATCH ehci -- interrupt xfer requeue
	o  [PATCH] USB usbnet driver update
	o  [PATCH] PATCH 2.5.14 -- ehci misc fixes

<dougg@torque.net>
	o  [PATCH] osst update
	o  [PATCH] sg update
	o  [PATCH] aha1542 update

<greg@kroah.com>
	o  add back NCR53c810 PCI quirk code from davej that was lost in the merge
	o  hand merge of davej's x86 pci-pc janitor work
	o  PCI hotplug update 
	o  USB pl2303 driver
	o  Move arch/i386/kernel/pci/ to arch/i386/pci/
	o  PCI hotplug drivers
	o  USB Config.in and Makefile minor changes
	o  USB ohci driver update
	o  USB
	o  moved the pci_alloc_consistent() and pci_free_consistent() functions back
	o  PCI Hotplug core
	o  IBM PCI Hotplug driver

<grundler@cup.hp.com>
	o  Tigon3 fix:

<hch@infradead.org>
	o  [PATCH] small filemap.c/pagemap.h cleanups

<hoho@binbash.net>
	o  [PATCH] suser() -> capable() checks

<ink@jurassic.park.msu.ru>
	o  [PATCH] Fix missing #includes
	o  [PATCH] fixes for PCI reorg changes
	o  [PATCH] 2.5.14: New PCI allocation code (alpha, arm, parisc) [2/2]
	o  [PATCH] 2.5.14: New PCI allocation code (alpha, arm, parisc) [1/2]

<jmorris@intercode.com.au>
	o  Tigon3: Handle Netgear GA302T correctly.

<kai@tp1.ruhr-uni-bochum.de>
	o  Move the IPv6 symbols into the ipv6 module
	o  Documentation/kbuild/makefiles.txt polish
	o  drivers/net/Makefile cleanup
	o  Link drivers/net/* from drivers/net/Makefile
	o  ISDN: CAPI cleanup: register/release
	o  ISDN: CAPI cleanup
	o  ISDN: CAPI maintain driver MOD_USE_COUNT
	o  ISDN: CAPI: use <linux/list.h> lists
	o  ISDN: export callbacks directly
	o  ISDN: CAPI: alloc struct capi_ctr dynamically
	o  ISDN: CAPI: alloc struct capi_appl dynamically
	o  ISDN: CAPI remove NCCI up/down notification
	o  ISDN: CAPI fix new "ncci up"
	o  Fix compile time warning in serial.c
	o  Fix cut'n'paste error in drivers/message/Makefile
	o  Cleanup drivers/pcmcia/Makefile
	o  Remove PCMCIA backwards compatibility rule.
	o  Link drivers/char/* from drivers/char/Makefile
	o  Cleanup drivers/fusion/* build
	o  Cleanup drivers/pcmcia/Makefile part 2
	o  Fix the Makefile cleanups

<laforge@gnumonks.org>
	o  Netfilter ipt_ULOG fix:

<mochel@segfault.osdl.org>
	o  Move arch/i386/kernel/pci-*.c to arch/i386/kernel/pci/; prepare for further cleanups
	o  Further split/cleanup of x86 PCI code
	o  Split drivers/pci/pci.c into smaller, bite-size chunks
	o  Further break-up-age
	o  don't enable debug in arch/i386/kernel/pci/
	o  Fix NUMA compile after PCI cleanup
	o  Move arch/i386/kernel/pci/ to arch/i386/pci/
	o  PCI Update: Fix oops on boot w/ ACPI enabled
	o  Re-add check for valid acpi routing information, instead of assuming it works

<neilb@cse.unsw.edu.au>
	o  [PATCH] PATCH - kNFSd in 2.5.14 - Tidy up comments in expfs.c
	o  [PATCH] PATCH - kNFSd in 2.5.14 - Two small changes to nfsd/nfssvc.c
	o  [PATCH] PATCH - kNFSd - Remove flowcontrol problems with lockd/tcp
	o  [PATCH] PATCH - kNFSd in 2.5.14 - Add a kernel_lock in d_splice_alias
	o  [PATCH] PATCH - kNFSd/FAT in 2.5.14 - Add export_operations support for FAT
	o  [PATCH] PATCH - kNFSd/ext3 in 2.5.14 - export_operations support for ext3
	o  [PATCH] PATHC - kNFSd/reiserfs in 2.5.14 - Convert reisferfs to use export_operations

<oliver@neukum.name>
	o  [PATCH] USB printer freeing minors in probe error path
	o  [PATCH] usage count handling during disconnect

<paulus@nanango.paulus.ozlabs.org>
	o  PPC32: add SIGURG to the list of signals ignored by default
	o  PPC32: add a subsys_initcall so pcibios_init gets called

<paulus@quango.ozlabs.ibm.com>
	o  PPC32: Rename ppc_defs.h to asm-offsets.h to ease the transition to kbuild-2.5 later.
	o  Update the Config.help for ppc32.  References to 486s and pentiums aren't

<paulus@samba.org>
	o  Define pfn_to_page, page_to_pfn, pte_pfn, pfn_pte for ppc32.
	o  PPC32: This changeset adds preemptible kernel support for ppc32
	o  PPC32: minor cosmetic changes, eliminate compile warnings
	o  PPC32: fix serial clock for embedded EP405 board.
	o  PPC32: remove some compiler warnings, xmon update
	o  PPC32: powermac update from Ben Herrenschmidt.
	o  [PATCH] fix drivers/pci/Makefile for PPC
	o  [PATCH] fix drivers/scsi/sd.c for ppc32

<rob@osinvestor.com>
	o  Sparc32 sun4c:

<robert.olsson@data.slu.se>
	o  IPV4: Add statistics for route cache GC monitoring.

<sfr@canb.auug.org.au>
	o  [PATCH] USE_STANDARD_AS_RULE in i386 arch Makefiles
	o  [PATCH] Directory Notification Fix

<shaggy@austin.ibm.com>
	o  [PATCH] Fix JFS file system corruption

<torvalds@home.transmeta.com>
	o  Re-apply Dave's VIA quirk update from 2.4.x
	o  Update kernel version

<torvalds@penguin.transmeta.com>
	o  Add SIGURG to list of ignore-by-default signals
	o  Fix makefile errors

<trini@bill-the-cat.bloom.county>
	o  PPC32: Update Motorola LoPEC support to match recent changes.
	o  PPC32: Minor cleanups to the i8259 and OpenPIC code.  From myself and
	o  PPC32: Modify the OpenPIC code to allow for all combinations of sense
	o  PPC32: define some important magic constants.
	o  PPC32: Modify openpic_get_irq() to call i8259_irq() for cascaded IRQs.  This
	o  Fix building of CONFIG_XMON && !CONFIG_MAGIC_SYSRQ

<vandrove@vc.cvut.cz>
	o  [PATCH] NLS: Invalid koi8-ru return values
	o  [PATCH] NLS: Allow user to select 1:1 mapping

<vojtech@twilight.ucw.cz>
	o  Fix for the previous fix. hid->name is 128 bytes, not 64 bytes long.
	o  This fixes a possible buffer overflow in hid-core.c in case a

<zippel@linux-m68k.org>
	o  [PATCH] m68k: atari updates [2/20]
	o  [PATCH] m68k: AFFS update [1/20]
	o  [PATCH] m68k: bitops update [3/20]
	o  [PATCH] m68k: add cacheflush.h [4/20]
	o  [PATCH] m68k: config.in update [5/20]
	o  [PATCH] m68k: license updates [7/20]
	o  [PATCH] m68k: hp300 update [8/20]
	o  [PATCH] m68k: idle update [10/20]
	o  [PATCH] m68k: remove hwclk_time/gettod [9/20]
	o  [PATCH] m68k: add missing include [11/20]
	o  [PATCH] m68k: Rename KTHREAD_SIZE [12/20]
	o  [PATCH] m68k: math-emu updates [13/20]
	o  [PATCH] m68k: rename p_pptr [14/20]
	o  [PATCH] m68k: readd lost proc functions [15/20]
	o  [PATCH] m68k: rlimits update [16/20]
	o  [PATCH] m68k: seq_file fixes [17/20]
	o  [PATCH] m68k: add tlbflush.h [18/20]
	o  [PATCH] m68k: add show_trace/show_trace_task [19/20]
	o  [PATCH] m68k: zorro updates [20/20]
	o  [PATCH] m68k: driver updates [6/20]

-- Full ChangeLog starts here --

<acme@brinquedo.oo.ps>
	--------------------------------------------------------------
	- remove spurious spaces and tabs at end of lines
	- make sure if, while, for, switch has a space before the opening '('
	- make sure no line has more than 80 chars
	- move initializations to the declaration line where possible
	- bitwise, logical and arithmetic operators have spaces before and after,
	  improving readability of complex expressions
	- remove uneeded () in returns
	- other minor cleanups


<acme@conectiva.com.br>
	--------------------------------------------------------------
	net/ipv4/arp.c:
	- htons cleanups
	- remove duplicated code
	- apply CodingStyle


<aia21@cantab.net>
	--------------------------------------------------------------
	NTFS: Fix compilation on 2.5.14 ({set_,clear_,}buffer_async was renamed
	to {set_,clear_,}buffer_async_read).


<akpm@zip.com.au>
	--------------------------------------------------------------
	[PATCH] Fix: writing to the swap space
	
	Ah.  That's some left-over code.  Reads will be OK, but writes will be
	unexpectedly asynchronous.  Nothing in the kernel uses that function for
	writes so it didn't show up.


<anton@samba.org>
	--------------------------------------------------------------
	[PATCH] acenic driver and 867 MHz G4 sound problems
	
	Fix acenic driver


<axboe@suse.de>
	--------------------------------------------------------------
	[PATCH] tcq initialization fix
	
	Transposed the last two arguments to memset, causing a slab poisoned
	kernel not to use tagging correctly... Brown paper bag stuff.


<colin@gibbs.dhs.org>
	--------------------------------------------------------------
	copy_mm fix:
	- If dup_mmap fails we will try to destroy_context before
	init_new_context occurs.  Platforms with non-trivial
	init_new_context can explode because of this.  The fix
	is to invoke init_new_context before dup_mmap.


<dalecki@evision-ventures.com>
	--------------------------------------------------------------
	[PATCH] 2.5.14 IDE 55
	
	 - Update HPT374 driver carried over from 2.4.xx series by Andrew Morton.
	   Resync it with the recent host chip driver changes, or better the
	   introduction of an API at all.
	
	 - Consolidate the handling of device ID byte order in one place.
	   This was spotted and patched by Bartomiej onierkiewicz.
	
	 - Eliminate CONFIG_BLK_DEV_IDEPCI - it's duplicating the functionality of the
	   already present and fine CONFIG_PCI flag and if we are a PCI host, we are
	   indeed very likely to need host chip support anyway.
	
	 - Remove some redundant info about the model and channel number from
	   /proc/ide. Remove the binary entries not helpful to the user, and not used
	   by any program and redundant to corresponding ioctls.
	
	 - Properly return udma_read and udma_write values in taskfile.
	
	 - Only initialize XXX_udma to the default handlers if it has not been
	   initialized by the host chip initialization.
	
	I have enabled spin lock debugging and can see that on device
	flush the spin locks get wrong counts... no problems elsewher ethus
	far. I will re check them next time around.

	--------------------------------------------------------------
	[PATCH] IDE 58
	
	 - m68k fixes by Roman Zippel.
	
	 - CDROM PIO mode fix by Osamu Tamita.
	   (You are true "Hawk-eye" hovering over my head! Respect - and many Thanks.)
	
	 - Virtualize the udma_enable method as well to help ARM and PPC people.  Please
	   please if you would like to have some other methods virtualized in a similar
	   way - just tell me or even better do it yourself at the end of ide-dma.c.
	   I *don't mind* patches.
	
	 - Fix the pmac code to adhere to the new API. It's supposed to work again.
	   However this is blind coding... I give myself 80% chances for it to work ;-).

	--------------------------------------------------------------
	[PATCH] 2.5.14 IDE 57
	
	Nuke /proc/ide. For explanations why, please see the frustrated comments in the
	previous change log. If one still don't see why it wasn't a good thing,
	well please just take a look at the following:
	
	Kernel size before:
	
	    text    data     bss     dec     hex filename
	1716049  403968  470252 2590269  27863d vmlinux
	
	Kernel size after:
	
	    text    data     bss     dec     hex filename
	1680993  403488  470124 2554605  26faed vmlinux
	
	2% of overall size! And this is not exactly an minimalistic setup.

	--------------------------------------------------------------
	[PATCH] 2.5.14 IDE 56
	
	 - Push poll_timeout down from the hwgroup to the channel. We are resetting the
	   channel and not a whole hwgroup. This way using multiple pdc202xxx cards
	   should magically start to work with multiple performance and resets will no
	   longer lock the system.
	
	 - Updates for PDC4030 by Peter Denison <peterd@marshadder.uklinux.net>.
	
	 - Make ide_raw_taskfile don't care about request buffers. They where always
	   NULL.
	
	 - Port set multi mode count over from the special setting interface to
	   ide_raw_taskfile. Fix errors in the corresponding interrupt handler in one go
	   as well. It turned out that this is precisely the same code as in
	   task_no_data_intr, so we can nuke it altogether. And finally we have found
	   some problems with the set_pio_mode() command which can fail with -EBUSY -
	   this is in esp. probably *very* common during boot hdparm usage those days!
	   (OK it was masked by reportig too early that it finished...  Crap Crap utter
	   crap it was!!!) Right now hdparm should just be extendid to properly
	   sync and retry on   -EBUSY and everything should be fine.
	
	   And now the 1 Milion EUR question for everybody who loves to put driver
	   settings in to /proc:
	
	   How the hell could echo > /proc/ide/ide0/settings blah blah blah blah handle
	   properly cases like -EIO, -EBUSY and so on??? Having the possibility o do it
	   does not mean that it is a good idea to use it.
	
	   OK. After realizing the simple fact that quite a lot of low level hardware
	   manipulating ioctls may require assistance in usage from proper logic which is
	   *very* unlikely to be implemented in a bash (for me preferable still ksh) I
	   have made my mind up.
	
		/proc/ide will be nuked.
	
	 - Execute the recalibration for error recovery on precisely the same request as
	   the one which failed.
	
	 - Remove set geometry.  It's crap by means of standard specification. Because:
	
	   1. We rely on the existence of the identify command anyway.
	
	   2. This command was obsoleted *before* the identify command existed as far
	   as I can see.
	
	   2. I'm able to have a look at what other ATA/ATAPI drivers in the wild do:
	   They don't do it.
	
	 - Just call tuneproc in set_pio_mode() directly - we are already behind the rq
	   queue there.
	
	 - After we have uncovered the broken logics behind the whole ioctl handling we
	   now just have made ide_spin_wait_hwgroup() waiting for a proper somehow
	   longer timeout before giving up. This was previously just hiding the broken
	   concept of setting ioctl values through /proc/ide/ideX/settings - now it just
	   really helps hdparm to not to give up too early. (It shouldn't probably play
	   wreck havock on the global driver spin lock as well. I will look in to this
	   later.)
	
	 - Scrap the non necessary, to say the least, disabling of interrupts for 3,
	   read it again please, 3 seconds, on the local CPU inside
	   ide_spin_wait_hwgroup().  Spin lock handling needs checking there badly as I
	   see now as well...
	
	Hey apparently any "special" requests are gone. We now have only
	to deal with REQ_DEVICE_ACB and REQ_DEVICE_CMD. One of them is still too
	much and will be killed.

	--------------------------------------------------------------
	[PATCH] 2.5.14 IDE 59
	
	Basically PCI driver handling reorganization. This is one step further
	ahead toward the goal of fully modularized host chip drivers.
	
	 - Adjust ide-scsi to the new error handling. Just don't try any device
	   resets there.
	
	 - Add unmasking of IRQ per default to the PMac PCI code.
	
	 - Split up the crap table from ide-pci. Let the corresponding drivers do
	   registration of the functions they provide. This small change makes
	   this patch rather big.
	
	 - Hard-code the number of ports requested for DMA engines. They are always
	   precisely 8 on PCs. If you hove something different to deal with,
	   well then please just provide your own init_dma method.
	
	 - Remove the HDIO_GETGEO_BIG ioctl. Patch by Andries Brouwer. Applies
	   unmodified.
	
	 - Make ON_BOARD be equal 0, so we can spare ourself some typing in structure
	   initialization.
	
	 - Normalize the terminology in the host chip drivers. It will make spotting
	   the tons of common code found there later easier.


<davej@suse.de>
	--------------------------------------------------------------
	[PATCH] capabilities for mtrr driver.
	

	--------------------------------------------------------------
	[PATCH] region handling cleanup
	
	Done by William Stinson.
	Adds error handling to request_region() calls,
	and converts some old check_region() calls too.

	--------------------------------------------------------------
	[PATCH] region handling cleanup
	
	Done by William Stinson.
	Adds error handling to request_region() calls,
	and converts some old check_region() calls too.

	--------------------------------------------------------------
	[PATCH] region handling cleanup
	
	Done by William Stinson.
	Adds error handling to request_region() calls,
	and converts some old check_region() calls too.

	--------------------------------------------------------------
	[PATCH] region handling cleanup
	
	Done by William Stinson.
	Adds error handling to request_region() calls,
	and converts some old check_region() calls too.

	--------------------------------------------------------------
	[PATCH] CREDITS update
	

	--------------------------------------------------------------
	[PATCH] check various return codes in advantechwdt.
	
	Adds missing checks. Probably another from William Stinson

	--------------------------------------------------------------
	[PATCH] IA64 ZX1 AGPGart support.
	
	From 2.4

	--------------------------------------------------------------
	[PATCH] region handling cleanup
	
	Done by William Stinson.
	Adds error handling to request_region() calls,
	and converts some old check_region() calls too.

	--------------------------------------------------------------
	[PATCH] typo.
	

	--------------------------------------------------------------
	[PATCH] region handling cleanup
	
	Done by William Stinson.
	Adds error handling to request_region() calls,
	and converts some old check_region() calls too.

	--------------------------------------------------------------
	[PATCH] documentation for Cyrix IRQ routing
	

	--------------------------------------------------------------
	[PATCH] sonypi update
	
	Syncs up with latest from Stelian

	--------------------------------------------------------------
	[PATCH] VIA quirk update.
	
	Brings up to date with the quirk in 2.4
	This makes sure we only apply it on the right chipsets,
	and adjusts the bits that get poked depending on which we find.

	--------------------------------------------------------------
	[PATCH] region handling cleanup
	
	Done by William Stinson.
	Adds error handling to request_region() calls,
	and converts some old check_region() calls too.

	--------------------------------------------------------------
	[PATCH] prefetching too far in mem copies
	
	This patch from 2.4 makes sure we don't prefetch past the
	end of a range to be copied (in case its at the end of a memrange)
	i386 case looks safe already, we just weren't optimal for the last
	chunk to be copied.
	
	Andi. same change needed for x86-64.
	
	    Dave.

	--------------------------------------------------------------
	[PATCH] update NBD URL
	

	--------------------------------------------------------------
	[PATCH] DMI update.
	
	Another Sony for the apm blacklist.

	--------------------------------------------------------------
	[PATCH] motioneye driver update.
	
	Syncs up with Stelians latest

	--------------------------------------------------------------
	[PATCH] typo in z2ram driver
	

	--------------------------------------------------------------
	[PATCH] simplify wdt285 copying.
	
	copy_to_user already does the relevant checking.

	--------------------------------------------------------------
	[PATCH] dmasound update.
	
	The largest part of the OSS update from 2.4
	Various changelog entries scattered throughout the patch.

	--------------------------------------------------------------
	[PATCH] PNPBIOS / floppy conflict.
	
	The PNPBIOS driver and the floppy driver both fight over reservation
	of the floppy port. This patch makes things friendly again.
	As the comment suggests, this fix could be done better, but until
	someone steps forward to fix this, this is the best we have.

	--------------------------------------------------------------
	[PATCH] NCR5380 update.
	
	From 2.4
	- Lindented
	- Add Docbook comments
	- Remove duplicate MODULE_LICENSE tag

	--------------------------------------------------------------
	[PATCH] list macro conversion.
	
	Use listwalking macro..

	--------------------------------------------------------------
	[PATCH] swap file missing error check
	
	Found by Andries Brouwer a while back iirc.

	--------------------------------------------------------------
	[PATCH] HP ZX1 AGP/DRM support.
	
	From 2.4

	--------------------------------------------------------------
	[PATCH] ptrace bug
	
	We weren't incrementing the address when walking a processes
	address space.  From 2.4


<davem@nuts.ninka.net>
	--------------------------------------------------------------
	net/core/neighbour.c: Delete ancient ASSERT_WL debugging.

	--------------------------------------------------------------
	Sparc64: Implement pfn_pte.

	--------------------------------------------------------------
	Sparc64 updates:
	- Implement changes for pfn_to_page et al.
	- Update defconfig.

	--------------------------------------------------------------
	Sparc64: Fix thinko in page_to_pfn

	--------------------------------------------------------------
	Sparc64: Update ioctl32 for bluetooth updates.

	--------------------------------------------------------------
	soft-fp fix:
	- When converting from integer to float, rounding is done
	incorrectly due to off-by-one shift in conversion

	--------------------------------------------------------------
	Sparc64: Fix pfn_foo macros and add descriptive commentary
	above explaining the {phys,pfn}_base stuff.

	--------------------------------------------------------------
	Sparc64: Make use of USE_STANDARD_AS_RULE.

	--------------------------------------------------------------
	SLAB: When using get_user on kernel pointers, enter KERNEL_DS.

	--------------------------------------------------------------
	Soft-fp fix:
	- Fix handling of implicit 1 bit of fraction part when converting
	from int to float.  We cannot handle it properly unless we
	defer implicit 1 bit handling till after rounding as
	rounding may move where the implicit 1 bit is in
	the final converted integer.

	--------------------------------------------------------------
	Sparc64: Enter KERNEL_DS when invoking do_sigaltstack with
	kernel pointers.

	--------------------------------------------------------------
	drivers/usb/net/rtl8150.c: Include linux/init.h

	--------------------------------------------------------------
	Sparc64: Make pcibios_init a subsys_initcall.

	--------------------------------------------------------------
	Sparc64: Keep totalram_pages equal to num_physpages.

	--------------------------------------------------------------
	Sparc: Kill references to buffermem_pages.

	--------------------------------------------------------------
	asm-sparc64/thread_info.h: Include asm/page.h even if __ASSEMBLY__


<david-b@pacbell.net>
	--------------------------------------------------------------
	[PATCH] PATCH ehci -- interrupt xfer requeue
	
	The fix basically removes a bit-complement that shouldn't have
	been there.  (Plus related simplification.)  That changed the PID,
	so that (for one example) only the first hub plug/unplug event could
	work.  So it's essential for anyone using high speed hubs.
	
	I'm still not quite sure why this hasn't affected more testing, but
	that's life ... :)

	--------------------------------------------------------------
	[PATCH] USB usbnet driver update
	
	    - generalizes/cleans keventd support to also handle
	        * rx stalls (and usb 2.0 transaction translator unplug)
	        * rx memory shortfalls (latent bug Oliver noticed)
	        * cleanup on device disconnect (quiesce first)
	    - merges Brad's patch to use the IEEE802 "locally assigned" bit
	    - fixes a couple minor bugs on error paths (leak, bogus diagnostic)
	    - updates some comments

	--------------------------------------------------------------
	[PATCH] PATCH 2.5.14 -- ehci misc fixes
	
	    - Report better errors, and in one case the correct one.
	    - Adds strategic wmb() calls
	    - Claims the right (scaled) ISO bandwidth
	    - Uses non-CVS version ID
	
	This will likely resolve that Archos MP3 Jukebox issue, where "-104"
	(-ECONNRESET) was appearing mysteriously.


<dougg@torque.net>
	--------------------------------------------------------------
	[PATCH] osst update
	
	This is the OnStream variant of the st driver that
	has been in Dave's tree for some time.
	
	The change looks like it is from Willem Riede (osst@riede.org)
	and that it has been forwarded ported from lk 2.4 .

	--------------------------------------------------------------
	[PATCH] sg update
	
	Here is one fix and one enhancement to the scsi generic (sg)
	driver in 2.5.14
	Changelog:
	    - off by one fix for last scatter gather element
	    - if possible compact kiobuf_map into scatter gather list

	--------------------------------------------------------------
	[PATCH] aha1542 update
	
	This ISA scsi adapter still seems to be popular
	given the number of people that supply patches
	for it collected in Dave's tree.
	
	The latest patch was from William Stinson (first item):
	  - request_region cleanup
	  - removal of old scsi error handling (leaving newer version)
	  - scatterlist::address replaced
	  - host_lock replacing io_request_lock
	
	
	Doug Gilbert
	
	P.S. This is a transfer from Dave's tree. It runs fine for
	me on a dual Celeron SMP box.


<greg@kroah.com>
	--------------------------------------------------------------
	add back NCR53c810 PCI quirk code from davej that was lost in the merge

	--------------------------------------------------------------
	hand merge of davej's x86 pci-pc janitor work

	--------------------------------------------------------------
	PCI hotplug update 
	
	include file location changed due to pci changes

	--------------------------------------------------------------
	USB pl2303 driver
	
	added support for another pl2303 device thanks to lutz rothhardt

	--------------------------------------------------------------
	Move arch/i386/kernel/pci/ to arch/i386/pci/

	--------------------------------------------------------------
	PCI hotplug drivers
	
	change due to moved location of i386's pci.h

	--------------------------------------------------------------
	USB Config.in and Makefile minor changes
	
	sync up with -dj tree

	--------------------------------------------------------------
	USB ohci driver update
	
	add PMAC changes found in -dj tree

	--------------------------------------------------------------
	USB
	
	minor -dj tree updates.

	--------------------------------------------------------------
	moved the pci_alloc_consistent() and pci_free_consistent() functions back
	into arch/i386/kernel as they are needed even if CONFIG_PCI is not enabled.

	--------------------------------------------------------------
	PCI Hotplug core
	
	removed pcihpfs_statfs(), as it's not used anymore.

	--------------------------------------------------------------
	IBM PCI Hotplug driver
	
	update the ibm pci hotplug driver to the latest version.  Contains lots of
	small bugfixes and added features for new hardware.


<grundler@cup.hp.com>
	--------------------------------------------------------------
	Tigon3 fix:
	- Fix typo in setting MR_LP_ADV duplex flags.


<hch@infradead.org>
	--------------------------------------------------------------
	[PATCH] small filemap.c/pagemap.h cleanups
	
	 - remove page_cache_entry - I think it never ever was actually used.
	 - remmove wake_up_page (as in 2.4) - never used
	 - remove misleading comment ontop of pagemap.h
	 - make wait_on_page* directly call wait_on_page_bit
	 - some reordering and additional comments in pagemap.h


<hoho@binbash.net>
	--------------------------------------------------------------
	[PATCH] suser() -> capable() checks
	
	  Trivial patch to change some instances of suser() and fsuser() to
	proper capable() checks.


<ink@jurassic.park.msu.ru>
	--------------------------------------------------------------
	[PATCH] Fix missing #includes
	
	There are missing #includes which will break compilation on some non-x86
	platforms. With following patch this compiles and works on alpha.
	
	Ivan.

	--------------------------------------------------------------
	[PATCH] fixes for PCI reorg changes
	
	There are missing #includes which will break compilation on some non-x86
	platforms. With following patch this compiles and works on alpha.

	--------------------------------------------------------------
	[PATCH] 2.5.14: New PCI allocation code (alpha, arm, parisc) [2/2]
	
	Summary of changes:
	- alpha, arm: code related to PCI-PCI bridges from pcibios_fixup_bus()
	  removed - now it's generic;
	- pdev_sort_resource: sort resources all together, no matter IO or memory;
	- pbus_assign_resources_sorted: ditto;
	- pci_bridge_check_ranges, pci_setup_bridge: changed for prefetch support;
	- pbus_size_io, pbus_size_mem: core stuff; tested with randomly generated
	  sets of resources;
	- pbus_size_bridges: pass #2 (pass #1 is PCI probing, common for all archs);
	- pbus_assign_resources: pass #3.
	
	Ivan.

	--------------------------------------------------------------
	[PATCH] 2.5.14: New PCI allocation code (alpha, arm, parisc) [1/2]
	
	This changes PCI resource allocation algorithm to 3 passes vs.
	current 2 passes. Extra pass is used for calculation of required
	size and alignment of PCI buses behind PCI-PCI bridges. After
	that, in the pass #3, these buses get allocated like regular
	PCI devices. This gives tighter PCI IO and memory packing -
	for instance, this fixes allocation problems on certain alphas
	with very small (112Mb) PCI memory range. Also, the new code
	- will allow mixed approach to resource allocation:
	  architecture can keep BIOS settings for some devices,
	  and re-allocate resources for others, including improperly
	  initialized bridges;
	- makes prefetchable ranges support much simpler;
	- allows sizing of IO and memory ranges for the host
	  bridges, which might be very useful in some situations.
	
	It was tested on various alphas; I haven't heard any complaints
	from rmk and rth, so probably all of this is ok. :-)
	
	Part 1:
	- for all archs, 4th argument (align) added to
	  pcibios_align_resource (and its callers).
	  It's necessary because this function will be called for
	  bus resources as well, and in this case size != alignment.
	- for several archs, dead/bogus code removed from
	  pcibios_fixup_pbus_ranges().


<jmorris@intercode.com.au>
	--------------------------------------------------------------
	Tigon3: Handle Netgear GA302T correctly.


<kai@tp1.ruhr-uni-bochum.de>
	--------------------------------------------------------------
	Move the IPv6 symbols into the ipv6 module
	
	Currently, we're trying to export the IPv6 modules from netsyms.c,
	which can't work when netsyms is built-in, but IPv6 is modular. Fix is to
	move the IPv6 symbols to the ipv6 module. Actually, netsyms.c could use a
	lot more of this kind of untangling.
	
	Also, move exporting the secure_*v6* symbols to drivers/char/random.c, 
	since that's where they're defined.
	
	The reason why things worked before is that the ipv6 module doesn't have
	a EXPORT_NO_SYMBOLS directive, so _all_ of its symbols where exported by
	modutils.
	

	--------------------------------------------------------------
	Documentation/kbuild/makefiles.txt polish
	
	Some improvements to the wording by Toshiyasu Morita.

	--------------------------------------------------------------
	drivers/net/Makefile cleanup
	
	Group selecting subdirs and linking them together. (Doesn't change
	the link order)

	--------------------------------------------------------------
	Link drivers/net/* from drivers/net/Makefile
	
	Group knowledge about building objects and linking them together
	instead of splitting it between the top-level Makefile and
	the per-directory Makefiles.
	
	This change tries to keep the link order the same as it was, at least
	as far as possible. One critical point is that we now link
	the pcmcia / wireless netdrivers before the pcmcia subsystem.
	However, the pcmcia subsystem is initialized via a late_initcall(),
	so this shouldn't make a difference.
	
	drivers/net/Makefile looks a bit long now, but that can be improved
	a lot, patch yet to come.

	--------------------------------------------------------------
	ISDN: CAPI cleanup: register/release
	
	Introduce register_appl() / release_appl() which are basically equivalent 
	to open()/close() for net_device's.
	
	Remove the registered() / released() callbacks and do the work immediately
	instead.

	--------------------------------------------------------------
	ISDN: CAPI cleanup
	
	Remove unused header file.

	--------------------------------------------------------------
	ISDN: CAPI maintain driver MOD_USE_COUNT
	
	Apart from the indentation changes, add an owner field to the hardware
	driver struct and use that to automatically inc/dec the module use count
	on register_appl()/release_appl()

	--------------------------------------------------------------
	ISDN: CAPI: use <linux/list.h> lists
	
	

	--------------------------------------------------------------
	ISDN: export callbacks directly
	
	Just EXPORT_SYMBOL() the callbacks, instead of passing them to the
	drivers in a struct.

	--------------------------------------------------------------
	ISDN: CAPI: alloc struct capi_ctr dynamically
	
	First step in actually having the hardware drivers alloc this as part
	of their per-controller data.

	--------------------------------------------------------------
	ISDN: CAPI: alloc struct capi_appl dynamically
	
	First step in having the users alloc this as part of the state info
	they have to maintain anyway.

	--------------------------------------------------------------
	ISDN: CAPI remove NCCI up/down notification
	
	Applications really ought to take care of maintaing the state themselves,
	instead of cheating by listening to controller private messages.

	--------------------------------------------------------------
	ISDN: CAPI fix new "ncci up"
	
	There's actually two cases when a new NCCI is created:
	outgoing and incoming connections (had missed the latter)

	--------------------------------------------------------------
	Fix compile time warning in serial.c

	--------------------------------------------------------------
	Fix cut'n'paste error in drivers/message/Makefile

	--------------------------------------------------------------
	Cleanup drivers/pcmcia/Makefile
	
	Use the usual list-based approach. Still not too nice.

	--------------------------------------------------------------
	Remove PCMCIA backwards compatibility rule.
	
	Old pcmcia-cs versions expect the pcmcia modules in 
	/lib/modules/`uname -r`/pcmcia, so we symlinked them for compatibility.
	According to the comment, the generation of these links should have
	been removed in 2.4, so it's definitely time for it to go now.

	--------------------------------------------------------------
	Link drivers/char/* from drivers/char/Makefile
	
	Link the subdirs of drivers/char from drivers/char/Makefile instead the
	top-level Makefile. 
	
	Link order changes slightly, shouldn't case any problems, though.
	
	Fix drivers/char/pcmcia/Config.in.
	
	Cleanup drivers/char/pcmcia/Makefile.
	
	Fix rio build rules in drivers/char/Makefile.

	--------------------------------------------------------------
	Cleanup drivers/fusion/* build
	
	Don't shortcut from drivers/Makefile to 
	drivers/message/{fusion,i2o}/Makefile, but use intermediate
	drivers/message/Makefile.
	
	Cleanup drivers/message/fusion/Config.in and get rid of unnecessary
	CONFIG_FUSION_BOOT.

	--------------------------------------------------------------
	Cleanup drivers/pcmcia/Makefile part 2
	
	Adding some more flexibility to Config.in (Allow for core built-in but
	socket driver modular) cleans up the Makefile as well ;-)

	--------------------------------------------------------------
	Fix the Makefile cleanups
	


<laforge@gnumonks.org>
	--------------------------------------------------------------
	Netfilter ipt_ULOG fix:
	- If timers were pending during module unload, we would OOPS.


<mochel@segfault.osdl.org>
	--------------------------------------------------------------
	Move arch/i386/kernel/pci-*.c to arch/i386/kernel/pci/; prepare for further cleanups

	--------------------------------------------------------------
	Further split/cleanup of x86 PCI code

	--------------------------------------------------------------
	Split drivers/pci/pci.c into smaller, bite-size chunks

	--------------------------------------------------------------
	Further break-up-age
	Make ACPI PCI IRQ routing work a bit better...

	--------------------------------------------------------------
	don't enable debug in arch/i386/kernel/pci/

	--------------------------------------------------------------
	Fix NUMA compile after PCI cleanup

	--------------------------------------------------------------
	Move arch/i386/kernel/pci/ to arch/i386/pci/

	--------------------------------------------------------------
	PCI Update: Fix oops on boot w/ ACPI enabled

	--------------------------------------------------------------
	Re-add check for valid acpi routing information, instead of assuming it works


<neilb@cse.unsw.edu.au>
	--------------------------------------------------------------
	[PATCH] PATCH - kNFSd in 2.5.14 - Tidy up comments in expfs.c
	
	Chris Wright <chris@wirex.com>  suggested these to limit to 80
	columns and such.

	--------------------------------------------------------------
	[PATCH] PATCH - kNFSd in 2.5.14 - Two small changes to nfsd/nfssvc.c
	
	1/ Return correct error code if nfs server creation fails
	2/ Increase limit on number of nfsd threads
	
	   There is no real justification for stopping a sysadmin
	   from running lots and lots of nfsd threads, so we raise the
	   imposed limit from 128 to 8192... maybe it should just go away...

	--------------------------------------------------------------
	[PATCH] PATCH - kNFSd - Remove flowcontrol problems with lockd/tcp
	
	The sunrpc/tcp layer currently allocates some resources linearly with
	number of server threads.  This causes problems when there are very
	small numbers of threads (e.g. lockd with one thread), so this patch
	adds a small constant to the number of threads before calculating
	resoures to allocate.
	
	This patch also provide proper upper-limits for the response sizes for
	lockd requests, so resources are not over-allocated.
	
	Together these resolve problems with heavy lockd load over tcp.

	--------------------------------------------------------------
	[PATCH] PATCH - kNFSd in 2.5.14 - Add a kernel_lock in d_splice_alias
	
	d_move wants the kernel to be locked, so
	d_splice_alias now takes that lock.

	--------------------------------------------------------------
	[PATCH] PATCH - kNFSd/FAT in 2.5.14 - Add export_operations support for FAT
	
	This actually contains a lot of code that is never used,
	as we don't currently attempt to load an inode that isn't
	in cache, so the fat_get_parent is never actually reached.
	However it is there (and should be right) incase some brave
	soul does decide to enhance fat_get_dentry accordingly.

	--------------------------------------------------------------
	[PATCH] PATCH - kNFSd/ext3 in 2.5.14 - export_operations support for ext3
	
	This patch converts ext3 to use the new export_operations for
	exporting a filesystem.
	In particular it
	 - defines "ext3_get_parent" to do a lookup(".."),
	 - calls d_splice_alias when ext3_lookup finds something,
	   so that build a dcache path from the bottom up works, and
	 - sets sb->s_export_op to point to an (almost empty)
	   export_operations structure.  The fact that it is mostly empty
	   means that the default lookup operations are used, which match the
	   previous approach (i.e. use iget, and then check the generation
	   number).

	--------------------------------------------------------------
	[PATCH] PATHC - kNFSd/reiserfs in 2.5.14 - Convert reisferfs to use export_operations
	
	This patch converts reiserfs to use the new export_operations
	interface for exporting a filesystem instead of the old
	fh_to_dentry and dentry_to_fh.
	Essentially it:
	
	  - renamed reiserfs_dentry_to_fh to reiserfs_encode_fh
	  - split reiserfs_fh_to_dentry into reiserfs_get_dentry
	    and reiserfs_decode_fh
	  - calls d_splice_alias from reiserfs_lookup so that building
	    a dcache path from the bottom works well
	  - addes reiserfs_get_parent to do a lookup of ".." without going
	    through the VFS interfaces.
	  - sets sb->s_export_op to be an appropriately initialised
	    struct export_operations
	
	This has been tested and works.


<oliver@neukum.name>
	--------------------------------------------------------------
	[PATCH] USB printer freeing minors in probe error path
	
	fix a failure to free a minor in the error path of probe

	--------------------------------------------------------------
	[PATCH] usage count handling during disconnect
	
	in usb.c during disconnect handling a reference to a driver is passed
	after the module usage count is decremented. In theory this is a race.


<paulus@nanango.paulus.ozlabs.org>
	--------------------------------------------------------------
	PPC32: add SIGURG to the list of signals ignored by default

	--------------------------------------------------------------
	PPC32: add a subsys_initcall so pcibios_init gets called


<paulus@quango.ozlabs.ibm.com>
	--------------------------------------------------------------
	PPC32: Rename ppc_defs.h to asm-offsets.h to ease the transition to kbuild-2.5 later.

	--------------------------------------------------------------
	Update the Config.help for ppc32.  References to 486s and pentiums aren't
	really helpful here. :)


<paulus@samba.org>
	--------------------------------------------------------------
	Define pfn_to_page, page_to_pfn, pte_pfn, pfn_pte for ppc32.

	--------------------------------------------------------------
	PPC32: This changeset adds preemptible kernel support for ppc32
	and also streamlines the exception entry/exit code by not saving
	all the GPRs on the common exceptions (system call, external
	interrupt and decrementer).

	--------------------------------------------------------------
	PPC32: minor cosmetic changes, eliminate compile warnings

	--------------------------------------------------------------
	PPC32: fix serial clock for embedded EP405 board.

	--------------------------------------------------------------
	PPC32: remove some compiler warnings, xmon update

	--------------------------------------------------------------
	PPC32: powermac update from Ben Herrenschmidt.
	This adds support for recent powermac models and fixes a few bugs.

	--------------------------------------------------------------
	[PATCH] fix drivers/pci/Makefile for PPC
	
	On 32-bit PPC we don't need setup-bus.o but we do need setup-irq.o.
	This patch changes drivers/pci/Makefile to reflect that.

	--------------------------------------------------------------
	[PATCH] fix drivers/scsi/sd.c for ppc32
	
	This patch fixes the compile errors in sd_find_target, which is only
	used on 32-bit PPC systems, and changes the ifdef around from
	CONFIG_PPC to CONFIG_PPC32 since ppc64 doesn't need this routine.


<rob@osinvestor.com>
	--------------------------------------------------------------
	Sparc32 sun4c:
	- In sun4c_pmd_set, actually set the thing.
	- In ld_mmu_sun4c, pmd_set no longer BTFIXUPCALL_NOP.


<robert.olsson@data.slu.se>
	--------------------------------------------------------------
	IPV4: Add statistics for route cache GC monitoring.


<sfr@canb.auug.org.au>
	--------------------------------------------------------------
	[PATCH] USE_STANDARD_AS_RULE in i386 arch Makefiles
	
	In Rules.make, a comment says:
	
	# Old makefiles define their own rules for compiling .S files,
	# but these standard rules are available for any Makefile that
	# wants to use them.  Our plan is to incrementally convert all
	# the Makefiles to these standard rules.  -- rmk, mec
	
	This patch does that for the i386 arch Makefiles.

	--------------------------------------------------------------
	[PATCH] Directory Notification Fix
	
	This patch fixes directory notification so that notifications get
	cancelled when a process exits.  This make dnotify MUCH more stable and
	usable :-)


<shaggy@austin.ibm.com>
	--------------------------------------------------------------
	[PATCH] Fix JFS file system corruption
	
	JFS: Flush dirty metadata to disk when remounting from read-write
	to read-only.  Also fix umount ordering to make sure metadata is
	written before journal closed.
	
	With Andrew Morton's recent changes, JFS is no longer writing much
	of its dirty metadata when remounting from read-write to read-only.
	This causes severe file system corruption.  A JFS root file system
	will be corrupted on shutdown.
	
	This patch fixes the problem by explicitly writing the dirty metadata
	before the journal is closed.  It also fixes the ordering so that
	the dirty metadata is completely written before the journal is closed
	for the normal unmount case as well.


<torvalds@home.transmeta.com>
	--------------------------------------------------------------
	Re-apply Dave's VIA quirk update from 2.4.x
	after the manual merge of the PCI re-organization
	removed it.

	--------------------------------------------------------------
	Update kernel version


<torvalds@penguin.transmeta.com>
	--------------------------------------------------------------
	Add SIGURG to list of ignore-by-default signals

	--------------------------------------------------------------
	Fix makefile errors


<trini@bill-the-cat.bloom.county>
	--------------------------------------------------------------
	PPC32: Update Motorola LoPEC support to match recent changes.

	--------------------------------------------------------------
	PPC32: Minor cleanups to the i8259 and OpenPIC code.  From myself and
	Hollis Blanchard.

	--------------------------------------------------------------
	PPC32: Modify the OpenPIC code to allow for all combinations of sense
	and polarity of IRQs.  Update the machines in CONFIG_ALL_PPC for this change.

	--------------------------------------------------------------
	PPC32: define some important magic constants.

	--------------------------------------------------------------
	PPC32: Modify openpic_get_irq() to call i8259_irq() for cascaded IRQs.  This
	requires that i8259_init() be called with the real address where PCI
	interrupt-acknowledge transactions will be generated.

	--------------------------------------------------------------
	Fix building of CONFIG_XMON && !CONFIG_MAGIC_SYSRQ


<vandrove@vc.cvut.cz>
	--------------------------------------------------------------
	[PATCH] NLS: Invalid koi8-ru return values
	
	During my lurking around NLS code I found that KOI8-RU returns character
	code instead of length of character for two characters.
	
						Petr Vandrovec

	--------------------------------------------------------------
	[PATCH] NLS: Allow user to select 1:1 mapping
	
	This allows user to select 'default' encoding, which has defined mapping
	for each of 255 byte values, so one can use it as a fallback when it
	finds filesystem with unknown encoding (EBCDIC for example) just to get
	characters through filesystem.
	
					Petr Vandrovec


<vojtech@twilight.ucw.cz>
	--------------------------------------------------------------
	Fix for the previous fix. hid->name is 128 bytes, not 64 bytes long.

	--------------------------------------------------------------
	This fixes a possible buffer overflow in hid-core.c in case a
	device would have very long string descriptors (vendor and device
	name.)


<zippel@linux-m68k.org>
	--------------------------------------------------------------
	[PATCH] m68k: atari updates [2/20]
	
	Some compile fixes.

	--------------------------------------------------------------
	[PATCH] m68k: AFFS update [1/20]
	
	- sizeof changes from Kernel Janitor Project
	- several bug fixes found with fsx

	--------------------------------------------------------------
	[PATCH] m68k: bitops update [3/20]
	
	Add __clear_bit/__ffs/sched_find_first_bit.

	--------------------------------------------------------------
	[PATCH] m68k: add cacheflush.h [4/20]
	
	This moves several cache flush function into cacheflush.h.

	--------------------------------------------------------------
	[PATCH] m68k: config.in update [5/20]
	
	Update to the latest config.in.

	--------------------------------------------------------------
	[PATCH] m68k: license updates [7/20]
	
	Add missing license tags.

	--------------------------------------------------------------
	[PATCH] m68k: hp300 update [8/20]
	
	compile fix

	--------------------------------------------------------------
	[PATCH] m68k: idle update [10/20]
	
	Fix idle functions.

	--------------------------------------------------------------
	[PATCH] m68k: remove hwclk_time/gettod [9/20]
	
	- replace hwclk_time with rtc_time
	- use hwclk instead of gettod to set initial time

	--------------------------------------------------------------
	[PATCH] m68k: add missing include [11/20]
	
	Add missing include files.

	--------------------------------------------------------------
	[PATCH] m68k: Rename KTHREAD_SIZE [12/20]
	
	This patch renames KTHREAD_SIZE into THREAD_SIZE, similiar to all other archs.

	--------------------------------------------------------------
	[PATCH] m68k: math-emu updates [13/20]
	
	Compile fixes

	--------------------------------------------------------------
	[PATCH] m68k: rename p_pptr [14/20]
	
	Rename p_pptr into parent.

	--------------------------------------------------------------
	[PATCH] m68k: readd lost proc functions [15/20]
	
	These function were removed by a "cleanup", but they are still used.

	--------------------------------------------------------------
	[PATCH] m68k: rlimits update [16/20]
	
	Update INIT_RLIMITS.

	--------------------------------------------------------------
	[PATCH] m68k: seq_file fixes [17/20]
	
	update some proc functions to use the seq_file interface

	--------------------------------------------------------------
	[PATCH] m68k: add tlbflush.h [18/20]
	
	Move several tlb functions into tlbflush.h.

	--------------------------------------------------------------
	[PATCH] m68k: add show_trace/show_trace_task [19/20]
	
	extract show_trace()/show_trace_task() out of dump_stack().

	--------------------------------------------------------------
	[PATCH] m68k: zorro updates [20/20]
	
	- small compile fixes
	- id update
	- add asm-ppc/zorro.h

	--------------------------------------------------------------
	[PATCH] m68k: driver updates [6/20]
	
	- kdev_t fixes
	- bio fixes
	- other cleanups and compile fixes



[-- Attachment #2: fmtcl.pl --]
[-- Type: application/x-perl, Size: 1478 bytes --]

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13  1:56     ` Linus Torvalds
@ 2002-05-13  9:31       ` Matthias Andree
  2002-05-13  8:52         ` Greg KH
  2002-05-13 10:12       ` Tomas Szepe
  1 sibling, 1 reply; 75+ messages in thread
From: Matthias Andree @ 2002-05-13  9:31 UTC (permalink / raw)
  To: linux-kernel

On Sun, 12 May 2002, Linus Torvalds wrote:

> As an example, if the long version looks like this:
> 
> 	<jsimmons@heisenberg.transvirtual.com>
> 	        A bunch of fixes.
> 
> 	<jsimmons@heisenberg.transvirtual.com>
> 	        Pmac updates
> 
...
> 	<rmk@arm.linux.org.uk>
> 	        [PATCH] 2.5.13: vmalloc link failure
> 
> 	        The following patch fixes this, and also fixes the similar problem in
> 	        scsi_debug.c:
> 	...
> 
> The short version could look like
> 
> 	jsimmons@heisenberg.transvirtual.com:
> 		A bunch of fixes.
> 		Pmac updates
...
> 	rmk@arm.linux.org.uk:
> 		[PATCH] 2.5.13: vmalloc link failure
> 
> 	...
> 
> ie only take the first line, and merge entries with the same author.
> 
> Perl people, stand up.

I sent a first version of a Perl program to Linus, a copy of the program
is available at
http://mandree.home.pages.de/linux/kernel/lk-changelog.pl
(Yes I know the first $Log:$ entry is missing.)

It does the above, plus it has a built-in table to write a name along
with the e-mail address, so it writes something like this:

James Simmons <jsimmons@heisenberg.transvirtual.com>:
        A bunch of fixes.
        Pmac updates
        Some more small fixes.

Russell King <rmk@arm.linux.org.uk>:
        [PATCH] 2.5.13: vmalloc link failure

Of course, if BK ChangeLogs started with a 60 character summary line as
has been suggested, that'd be very useful. Something for the
BK-with-linux-kernel-HOWTO perhaps?

I can imagine letting the script look up the addresses by means of
Roland Rosenfeld's Little Brother's Data Base at a later time.
(http://www.spinnaker.de/lbdb/)

-- 
Matthias Andree

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-12 20:06 ` Linus Torvalds
                     ` (4 preceding siblings ...)
  2002-05-12 21:17   ` Florian Weimer
@ 2002-05-13  8:57   ` jw schultz
  2002-05-13  8:06     ` Greg KH
  5 siblings, 1 reply; 75+ messages in thread
From: jw schultz @ 2002-05-13  8:57 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

On Sun, May 12, 2002 at 08:06:39PM +0000, Linus Torvalds wrote:
> In article <20020512010709.7a973fac.spyro@armlinux.org>,
> Ian Molton  <spyro@armlinux.org> wrote:
> >
> >I dont know who to write to about this, but the changelogs for
> >2.4.19-pre on kernel.org are COMPLETELY illegible.
> 
> Hmm..
> 
> You're definitely right about the BK version numbers, since those are
> meaningless anyway (they are only meaningful within one BK tree, and
> they change over time when you merge different trees together.
> 
> The 2.4.x changelogs seem to be done with my "release" scripts, but
> additionally they don't have the same kind of detailed information that
> the 2.5.x kernels have, and yes, the result is fairly ugly.
> 
> What are peoples opinion about the "full" changelog format that v2.5.x
> kernels have? Should we sort that too by author?
> 
> Perl is the obvious choice for doing transformations like these.  Is
> anybody willing to write a perl script that does the "sort by author"
> thing?
> 
> I'll remove the date/BK ID thing, so that my unsorted changelogs would
> look like the appended thing.  But yes, sorting (and merging) by author
> would probably be a good thing. (My BK changelog scripts can also add
> markers around the actual log message, to make parsing easier).
> 
> 		Linus
> 

Rather than sort by author i, and i suspect others, would
prefer the top-level sort be by subsystem or a recognizable
aspect (ext2fs, VM, sched, cleanup, etc).  That way we could
quickly scan for the patches that relate to areas of
interest.  I am aware that currently many patches aren't
even labled suitably but if we start doing this then
eventually it will get better.

Also where a set of patches are included it would be nice if
they could be merged like so:

|<bigenius@northpole.org>
|	[devicefs] blah blah blah [1/6]
|	
|	fixed the whosit
|
|<bigenius@northpole.org>
|	[devicefs] blah blah blah [2/6]
|
|	improved error report
|
|<bigenius@northpole.org>
|	[devicefs] blah blah blah [4/6]
|
|	move locking down a layer (requires 1)


Might become

|	** devicefs **
|<bigenius@northpole.org>
|	[devicefs] blah blah blah [1,2,4/6]
|	
|	fixed the whosit
|
|	improved error report
|
|	move locking down a layer (requires 1)

Of course this would be further down the line.

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13  9:31       ` Matthias Andree
@ 2002-05-13  8:52         ` Greg KH
  2002-05-13 10:41           ` Matthias Andree
  0 siblings, 1 reply; 75+ messages in thread
From: Greg KH @ 2002-05-13  8:52 UTC (permalink / raw)
  To: linux-kernel

On Mon, May 13, 2002 at 11:31:42AM +0200, Matthias Andree wrote:
> 
> I sent a first version of a Perl program to Linus, a copy of the program
> is available at
> http://mandree.home.pages.de/linux/kernel/lk-changelog.pl
> (Yes I know the first $Log:$ entry is missing.)

Please make the following change to the patch, otherwise email address
(or other things within a <>) in the body of the change message are
improperly picked up.

Other than that minor problem, looks very nice.

thanks,

greg k-h

--- lk-changelog.pl~	Mon May 13 02:56:07 2002
+++ lk-changelog.pl	Mon May 13 02:59:05 2002
@@ -81,7 +81,7 @@
 
 while(<>) {
   chomp;
-  if (/<(.*?)>/) {
+  if (/^<(.*?)>/) {
     $author = $1;
     $first = 1;
   } elsif ($first) {

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13  8:57   ` jw schultz
@ 2002-05-13  8:06     ` Greg KH
  0 siblings, 0 replies; 75+ messages in thread
From: Greg KH @ 2002-05-13  8:06 UTC (permalink / raw)
  To: jw schultz, linux-kernel

On Mon, May 13, 2002 at 01:57:24AM -0700, jw schultz wrote:
> 
> Rather than sort by author i, and i suspect others, would
> prefer the top-level sort be by subsystem or a recognizable
> aspect (ext2fs, VM, sched, cleanup, etc).  That way we could
> quickly scan for the patches that relate to areas of
> interest.  I am aware that currently many patches aren't
> even labled suitably but if we start doing this then
> eventually it will get better.

Some of us already state what subsystem/driver the changeset is for on
the first line of the change entry for this very reason :)

greg k-h

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-12 21:42     ` Marcus Alanen
  2002-05-12 22:12       ` Tomas Szepe
@ 2002-05-13  7:34       ` Kristian Peters
  1 sibling, 0 replies; 75+ messages in thread
From: Kristian Peters @ 2002-05-13  7:34 UTC (permalink / raw)
  To: Marcus Alanen; +Cc: Weimer, linux-kernel, torvalds

Hello.

I changed your perl-script int that way that it only gives out the first line of the patch. This makes the changelog less verbose but you can read the changes very quickly and if you're interested in a certain patch, you can grep the verbose one.
That makes more sense. IMHO I like it better that way. Most people want to see a little overview and are only really interested in the parts they're working on.

This is now the output:

[...]
<hch@infradead.org>
        - remove global_bufferlist_lock
        - fix config.in syntax errors.
        - architecture-independand si_meminfo

<jsimmons@heisenberg.transvirtual.com>
        - A bunch of fixes.
        - Pmac updates
        - Some more small fixes.

<maxk@qualcomm.com>
        - Bluetooth subsystem sync up
[...]

*Kristian



#!/usr/bin/perl -w

use strict;

my %people = ();
my $addr = "";
my @cur = ();
my $comment = 0;

sub append_item() {
	if (!$addr) {
		return;
	}
	if (!$people{$addr}) {
		@{$people{$addr}} = ();
	}
	push @{$people{$addr}}, [@cur];

	@cur = ();
}

while (<>) {
	# Match address
	if (/^\s*<([^>]+)>/) {
		# Add old item (if any) before beginning new
		append_item();
		$addr = $1;
		$comment = 1;
	} elsif ($addr) {
		# Add line to patch
		s/^\s*(.*)\s*$/- $1/;
		$_ =~ s/\[PATCH\] //g;
		$_ =~ s/\s*PATCH //g;
		if ($comment == 1) {
			push @cur, "\t$_\n";
			$comment = 0;
		}
	} else {
		# Header information
		print;
	}
}

sub print_items($) {
	my @items = @{$people{$_[0]}};
	# Vain attempt to sort patches from one address
	@items = sort @items;
	while ($_ = shift @items) {
		print @$_;
	}
}

append_item();
foreach $addr (sort keys %people) {
	print "<$addr>\n";
	print_items($addr);
	print "\n";
}





  :... [snd.science] ...:
 ::                             _o)
 :: http://www.korseby.net      /\\
 :: http://gsmp.sf.net         _\_V
  :.........................:

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13  5:10       ` Jeff Garzik
@ 2002-05-13  5:17         ` Larry McVoy
  2002-05-13 10:37         ` Helge Hafting
  1 sibling, 0 replies; 75+ messages in thread
From: Larry McVoy @ 2002-05-13  5:17 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: Linus Torvalds, linux-kernel

On Mon, May 13, 2002 at 01:10:06AM -0400, Jeff Garzik wrote:
> (speaking more to the crowd...)
> Changeset comments need to be written as if they stand alone, without 
> any other context -- including the author.  A reader should not need to 
> know that (for examples) James Simmons hacks on fbdev stuff.

100% agreed.

Part of the design of citool was an attempt to guide people towards
doing that.  We encourage people to do the detailed stuff on the file
comments and the logical level comment on the changeset.  Think of file
as the "how" and the changeset as the "what".

The good news is that people do tend to get better once they realize
that other people read this stuff.
-- 
---
Larry McVoy            	 lm at bitmover.com           http://www.bitmover.com/lm 

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-13  2:01     ` Linus Torvalds
@ 2002-05-13  5:10       ` Jeff Garzik
  2002-05-13  5:17         ` Larry McVoy
  2002-05-13 10:37         ` Helge Hafting
  0 siblings, 2 replies; 75+ messages in thread
From: Jeff Garzik @ 2002-05-13  5:10 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

Linus Torvalds wrote:

>
> 	jsimmons@heisenberg.transvirtual.com:
>		A bunch of fixes.
>		Pmac updates
>		Some more small fixes.
>	rmk@arm.linux.org.uk:
>		2.5.13: vmalloc link failure
>
>	trond.myklebust@fys.uio.no:
>		in_ntoa link failure
>
>	viro@math.psu.edu:
>		change_floppy() fix
>


Picking on your examples, the first IMO needs more context.

(speaking more to the crowd...)
Changeset comments need to be written as if they stand alone, without 
any other context -- including the author.  A reader should not need to 
know that (for examples) James Simmons hacks on fbdev stuff.

    Jeff




^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-12 21:17   ` Florian Weimer
  2002-05-12 21:42     ` Marcus Alanen
  2002-05-12 21:51     ` Ian Molton
@ 2002-05-13  2:01     ` Linus Torvalds
  2002-05-13  5:10       ` Jeff Garzik
  2 siblings, 1 reply; 75+ messages in thread
From: Linus Torvalds @ 2002-05-13  2:01 UTC (permalink / raw)
  To: linux-kernel

In article <873cwx2hi4.fsf@CERT.Uni-Stuttgart.DE>,
Florian Weimer  <Weimer@CERT.Uni-Stuttgart.DE> wrote:
>
>For your example, the result is:
>
><jsimmons@heisenberg.transvirtual.com>
>        A bunch of fixes.
>
>        Pmac updates
>
>        Some more small fixes.
>
><rmk@arm.linux.org.uk>
>        [PATCH] 2.5.13: vmalloc link failure
>        
>        The following patch fixes this, and also fixes the similar problem in
>        scsi_debug.c:
>
><trond.myklebust@fys.uio.no>
>        [PATCH] in_ntoa link failure
>        
>        Nothing serious. Whoever it was that did that global replacemissed a
>        spot is all...
>
><viro@math.psu.edu>
>        [PATCH] change_floppy() fix
>        
>        Needed both in 2.4 and 2.5
>
>
>IMHO, it doesn't make much sense.

It doesn't make much sense that way, but if you also made the
descriptions shorter (first line only) _and_ then packed them, it would
give a much denser overview. Oh, and remove any [PATCH] marker: I just
use them to keep track of which were imported as email-patches vs which
were done "natively" with BK..

So you'd have something like:

	jsimmons@heisenberg.transvirtual.com:
		A bunch of fixes.
		Pmac updates
		Some more small fixes.

	rmk@arm.linux.org.uk:
		2.5.13: vmalloc link failure

	trond.myklebust@fys.uio.no:
		in_ntoa link failure

	viro@math.psu.edu:
		change_floppy() fix

which I could more easily post to linux-kernel (possibly after some
minor hand-editing) because it wouldn't end up being 20kB worth of text
that not everybody is interested in reading. 

Hmm?

		Linus

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-12 20:31   ` Dr. David Alan Gilbert
  2002-05-12 20:41     ` Arnaldo Carvalho de Melo
@ 2002-05-13  1:56     ` Linus Torvalds
  2002-05-13  9:31       ` Matthias Andree
  2002-05-13 10:12       ` Tomas Szepe
  1 sibling, 2 replies; 75+ messages in thread
From: Linus Torvalds @ 2002-05-13  1:56 UTC (permalink / raw)
  To: Dr. David Alan Gilbert; +Cc: linux-kernel



On Sun, 12 May 2002, Dr. David Alan Gilbert wrote:
>
> I used to read the hand written changelogs, they only used to be a half
> page or so; neatly summerising stuff into one line; I can't be bothered
> with the full changelogs  - they are obviously useful; but the hand
> written half pages are still a lot easier at a quick glance to see if
> there is anything that affects you.

Yeah, I know. Some people like the long ones, though, and they _are_
useful if you want to get a more detailed view.

I definitely don't want to maintain a separate set of short logs, but the
answer may be to just do both: have the existing long log (with no merging
of changesets, so that people see the actual commit boundaries), and a
separate "short" version that also merges the thing.

As an example, if the long version looks like this:

	<jsimmons@heisenberg.transvirtual.com>
	        A bunch of fixes.

	<jsimmons@heisenberg.transvirtual.com>
	        Pmac updates

	<jsimmons@heisenberg.transvirtual.com>
	        Some more small fixes.

	<rmk@arm.linux.org.uk>
	        [PATCH] 2.5.13: vmalloc link failure

	        The following patch fixes this, and also fixes the similar problem in
	        scsi_debug.c:
	...

The short version could look like

	jsimmons@heisenberg.transvirtual.com:
		A bunch of fixes.
		Pmac updates
		Some more small fixes.

	rmk@arm.linux.org.uk:
		[PATCH] 2.5.13: vmalloc link failure

	...

ie only take the first line, and merge entries with the same author.

Perl people, stand up.

		Linus


^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-12 10:05     ` Johnny Mnemonic
@ 2002-05-13  0:46       ` Rik van Riel
  2002-05-13 11:52         ` Marcus Alanen
  2002-05-13 11:58         ` Tomas Szepe
  0 siblings, 2 replies; 75+ messages in thread
From: Rik van Riel @ 2002-05-13  0:46 UTC (permalink / raw)
  To: Johnny Mnemonic; +Cc: linux-kernel

On Sun, 12 May 2002, Johnny Mnemonic wrote:
> On Sunday 12 May 2002 07:05, Brian C. Huffman wrote:
> > Generally the defense that "no one else is saying anything" is not a
> > good one - especially b/c it opens up a huge space for others to agree
> > with the original argument.  And yes, they are illegible.
> >
>
> I agree. If developers need that changelog style it's fine, but on kernel.org
> homepage there should the old changelog format, so everyone can read it.
> The best changelog i've ever seen is the one used around ~2.4.9 release
>
>  - changedescription                         (author)

So, is there anybody willing to put together the scripts to
generate this changelog format automatically ?

Rik
-- 
Bravely reimplemented by the knights who say "NIH".

http://www.surriel.com/		http://distro.conectiva.com/


^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-12 21:47       ` Florian Weimer
@ 2002-05-12 23:50         ` Sven.Riedel
  0 siblings, 0 replies; 75+ messages in thread
From: Sven.Riedel @ 2002-05-12 23:50 UTC (permalink / raw)
  To: Florian Weimer; +Cc: Ian Molton, linux-kernel

On Sun, May 12, 2002 at 11:47:40PM +0200, Florian Weimer wrote:
> > pull out the whitespace and put a bullet point in front of each entry.
> And that adds more sense? ;-)

It makes it more legible.

> Do you guys really think that "small fixes" is enough?  Don't you want
> to know what is actually fixed?
Well, yes and no. 
A short, pertinent _overview_ of the changelog in front of a more
detailed changelog is a nice thing to have. I love Alan Cox' changelog
style, I don't even bother with the 2.4.x-format anymore. It takes ages
due to ugly formating and it's way too detailed. (I asked the people at
our LUG meeting once, they all agreed with my above assessment).

Regs,
Sven
-- 
Sven Riedel                      sr@gimp.org
Osteroeder Str. 6 / App. 13      sven.riedel@tu-clausthal.de
38678 Clausthal                  "Python is merely Perl for those who
                                  prefer Pascal to C" (anon)

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-12 21:42     ` Marcus Alanen
@ 2002-05-12 22:12       ` Tomas Szepe
  2002-05-13 10:32         ` Helge Hafting
  2002-05-13  7:34       ` Kristian Peters
  1 sibling, 1 reply; 75+ messages in thread
From: Tomas Szepe @ 2002-05-12 22:12 UTC (permalink / raw)
  To: Marcus Alanen; +Cc: linux-kernel

> [Marcus Alanen <marcus@infa.abo.fi>, May-13 2002, Mon, 00:42 +0300]
> In mailing-lists.linux-kernel, you wrote:
> >torvalds@transmeta.com (Linus Torvalds) writes:
> >
> >> Perl is the obvious choice for doing transformations like these. Is
> >> anybody willing to write a perl script that does the "sort by author"
> >> thing?
>
> [snip]
> Basically the same, this treats each patch separately:

I took the liberty of kicking it up another notch :)

	- allow whitespace at the beginning of email line (strip it, though)

	- remove whitespace at the beginning and the end of "content"
	lines and print everything out with a single tab in front

T.


Will process horrible mess like:
--
 <jsimmons@heisenberg.transvirtual.com> asfd
     A bunch of fixes.

<jsimmons@heisenberg.transvirtual.com>	
	    Pmac updates

<jsimmons@heisenberg.transvirtual.com>	   mmmm
   Some more small fixes.

<rmk@arm.linux.org.uk>
	      [PATCH] 2.5.13: vmalloc link failure

	The following patch fixes this, and also fixes the similar problem in
	 scsi_debug.c:

<trond.myklebust@fys.uio.no>
	[PATCH] in_ntoa link failure

	Nothing serious. Whoever it was that did that global replacemissed a
	spot is all...

<viro@math.psu.edu>
	[PATCH] change_floppy() fix

	Needed both in 2.4 and 2.5

-- into: --

<jsimmons@heisenberg.transvirtual.com>
	--------------------------------------------------------------
	A bunch of fixes.

	--------------------------------------------------------------
	Pmac updates

	--------------------------------------------------------------
	Some more small fixes.


<rmk@arm.linux.org.uk>
	--------------------------------------------------------------
	[PATCH] 2.5.13: vmalloc link failure

	The following patch fixes this, and also fixes the similar problem in
	scsi_debug.c:


<trond.myklebust@fys.uio.no>
	--------------------------------------------------------------
	[PATCH] in_ntoa link failure

	Nothing serious. Whoever it was that did that global replacemissed a
	spot is all...


<viro@math.psu.edu>
	--------------------------------------------------------------
	[PATCH] change_floppy() fix

	Needed both in 2.4 and 2.5

--

#!/usr/bin/perl -w

use strict;

my %people = ();
my $addr = "";
my @cur = ();

sub append_item() {
	if (!$addr) { return; }
	if (!$people{$addr}) { @{$people{$addr}} = (); }
	push @{$people{$addr}}, [@cur];

	@cur = ();
}

while (<>) {
	# Match address
	if (/^\s*<([^>]+)>/) {
		# Add old item (if any) before beginning new
		append_item();
		$addr = $1;
	} elsif ($addr) {
		# Add line to patch
		s/^\s*(.*)\s*$/$1/;
		push @cur, "\t$_\n";
	} else {
		# Header information
		print;
	}
}


sub print_items($) {
	my @items = @{$people{$_[0]}};
	# Vain attempt to sort patches from one address
	@items = sort @items;
	while ($_ = shift @items) {
		# Item separator
		print "\t--------------------------------------------------------------\n";
		print @$_;
	}
}

append_item();
foreach $addr (sort keys %people) {
	print "<$addr>\n";
	print_items($addr);
	print "\n";
}

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-12 21:17   ` Florian Weimer
  2002-05-12 21:42     ` Marcus Alanen
@ 2002-05-12 21:51     ` Ian Molton
  2002-05-12 21:47       ` Florian Weimer
  2002-05-13  2:01     ` Linus Torvalds
  2 siblings, 1 reply; 75+ messages in thread
From: Ian Molton @ 2002-05-12 21:51 UTC (permalink / raw)
  To: Florian Weimer; +Cc: linux-kernel

On Sun, 12 May 2002 23:17:23 +0200
Florian Weimer <Weimer@CERT.Uni-Stuttgart.DE> wrote:

> IMHO, it doesn't make much sense.

pull out the whitespace and put a bullet point in front of each entry.

Hm.

Geez, Im starting to sound like management... All I need now is a
whiteboard and some indellible non-indellible marker pens :-)

I really dont care that much. I just like to read changelogs, not decode
them.

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-12 21:51     ` Ian Molton
@ 2002-05-12 21:47       ` Florian Weimer
  2002-05-12 23:50         ` Sven.Riedel
  0 siblings, 1 reply; 75+ messages in thread
From: Florian Weimer @ 2002-05-12 21:47 UTC (permalink / raw)
  To: Ian Molton; +Cc: linux-kernel

Ian Molton <spyro@armlinux.org> writes:

> On Sun, 12 May 2002 23:17:23 +0200
> Florian Weimer <Weimer@CERT.Uni-Stuttgart.DE> wrote:
>
>> IMHO, it doesn't make much sense.
>
> pull out the whitespace and put a bullet point in front of each entry.
>
> Hm.

And that adds more sense? ;-)

Do you guys really think that "small fixes" is enough?  Don't you want
to know what is actually fixed?

-- 
Florian Weimer 	                  Weimer@CERT.Uni-Stuttgart.DE
University of Stuttgart           http://CERT.Uni-Stuttgart.DE/people/fw/
RUS-CERT                          +49-711-685-5973/fax +49-711-685-5898

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-12 21:17   ` Florian Weimer
@ 2002-05-12 21:42     ` Marcus Alanen
  2002-05-12 22:12       ` Tomas Szepe
  2002-05-13  7:34       ` Kristian Peters
  2002-05-12 21:51     ` Ian Molton
  2002-05-13  2:01     ` Linus Torvalds
  2 siblings, 2 replies; 75+ messages in thread
From: Marcus Alanen @ 2002-05-12 21:42 UTC (permalink / raw)
  To: Weimer, linux-kernel

In mailing-lists.linux-kernel, you wrote:
>torvalds@transmeta.com (Linus Torvalds) writes:
>
>> Perl is the obvious choice for doing transformations like these.  Is
>> anybody willing to write a perl script that does the "sort by author"
>> thing?

[snip]
Basically the same, this treats each patch separately:

#!/usr/bin/perl

use strict;

my %people = ();
my $addr = "";
my @cur = ();

sub append_item() {
	if (!$addr) { return; }
	if (!$people{$addr}) { @{$people{$addr}} = (); }
	push @{$people{$addr}}, [@cur];

	@cur = ();
}

while (<>) {
	# Match address
	if (/^<(.+)>/) {
		# Add old item (if any) before beginning new
		append_item();
		$addr = $1;
	} elsif ($addr) {
		# Add line to patch
		push @cur, $_;
	} else {
		# Header information
		print
	}
}


sub print_items($) {
	my @items = @{$people{$_[0]}};
	# Vain attempt to sort patches from one address
	@items = sort @items;
	while ($_ = shift @items) {
		# Item separator
		print "        --------------------------------------------------------------\n";
		print @$_;
	}
}

append_item();
foreach $addr (sort keys %people) {
	print "<$addr>\n";
	print_items($addr);
	print "\n";
}


Output:


Summary of changes from v2.5.14 to v2.5.15
============================================

<acme@brinquedo.oo.ps>
        --------------------------------------------------------------
        - remove spurious spaces and tabs at end of lines
        - make sure if, while, for, switch has a space before the opening '('
        - make sure no line has more than 80 chars
        - move initializations to the declaration line where possible
        - bitwise, logical and arithmetic operators have spaces before and after,
          improving readability of complex expressions
        - remove uneeded () in returns
        - other minor cleanups


<acme@conectiva.com.br>
        --------------------------------------------------------------
        net/ipv4/arp.c:
        - htons cleanups
        - remove duplicated code
        - apply CodingStyle

...
...
<davej@suse.de>
        --------------------------------------------------------------
        [PATCH] capabilities for mtrr driver.


        --------------------------------------------------------------
        [PATCH] region handling cleanup

        Done by William Stinson.
        Adds error handling to request_region() calls,
        and converts some old check_region() calls too.

        --------------------------------------------------------------
        [PATCH] region handling cleanup

        Done by William Stinson.
        Adds error handling to request_region() calls,
        and converts some old check_region() calls too.
...
...




-- 
Marcus Alanen
maalanen@abo.fi

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-12 20:06 ` Linus Torvalds
                     ` (3 preceding siblings ...)
  2002-05-12 20:35   ` Anton Altaparmakov
@ 2002-05-12 21:17   ` Florian Weimer
  2002-05-12 21:42     ` Marcus Alanen
                       ` (2 more replies)
  2002-05-13  8:57   ` jw schultz
  5 siblings, 3 replies; 75+ messages in thread
From: Florian Weimer @ 2002-05-12 21:17 UTC (permalink / raw)
  To: linux-kernel

torvalds@transmeta.com (Linus Torvalds) writes:

> Perl is the obvious choice for doing transformations like these.  Is
> anybody willing to write a perl script that does the "sort by author"
> thing?

#!/usr/bin/perl -w
# Reformat 2.4 ChangeLog

use strict;

my %authors = ();
my $current;

while (<>) {
    chomp;
    if (/^</) {
	if (exists $authors{$_}) {
	    $current = $authors{$_};
	} else {
	    $current = $authors{$_} = [];
	}
    } else {
	die "illegal format" unless defined $current;
	push @$current, $_;
    }
}

my $author;
foreach $author (sort keys %authors) {
    print "$author\n";
    $_ = join "\n", @{$authors{$author}};
    # Add empty line before next author.    
    s/\n*$/\n\n/;
    print;
}

For your example, the result is:

<jsimmons@heisenberg.transvirtual.com>
        A bunch of fixes.

        Pmac updates

        Some more small fixes.

<rmk@arm.linux.org.uk>
        [PATCH] 2.5.13: vmalloc link failure
        
        The following patch fixes this, and also fixes the similar problem in
        scsi_debug.c:

<trond.myklebust@fys.uio.no>
        [PATCH] in_ntoa link failure
        
        Nothing serious. Whoever it was that did that global replacemissed a
        spot is all...

<viro@math.psu.edu>
        [PATCH] change_floppy() fix
        
        Needed both in 2.4 and 2.5


IMHO, it doesn't make much sense.

-- 
Florian Weimer 	                  Weimer@CERT.Uni-Stuttgart.DE
University of Stuttgart           http://CERT.Uni-Stuttgart.DE/people/fw/
RUS-CERT                          +49-711-685-5973/fax +49-711-685-5898

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-12 20:31   ` Dr. David Alan Gilbert
@ 2002-05-12 20:41     ` Arnaldo Carvalho de Melo
  2002-05-13 20:57       ` Linus Torvalds
  2002-05-13  1:56     ` Linus Torvalds
  1 sibling, 1 reply; 75+ messages in thread
From: Arnaldo Carvalho de Melo @ 2002-05-12 20:41 UTC (permalink / raw)
  To: Dr. David Alan Gilbert; +Cc: Linus Torvalds, linux-kernel

Em Sun, May 12, 2002 at 09:31:03PM +0100, Dr. David Alan Gilbert escreveu:
> Perhaps insisting that each check in message includes a single line (sub
> 60 chars) description; could turn those into description : name and
> remove dupes?

That'd be nice indeed, like %{summary} and %{description} in rpm spec files 8)

A simple script would just get the line with '^Summary:' and generate the
one page "executive" summary...

Now to wait for the non auto part of the story: discipline of kernel hackers,
erm, it seems we'll need an human doing the summary... ;(

- Arnaldo

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-12 20:06 ` Linus Torvalds
                     ` (2 preceding siblings ...)
  2002-05-12 20:31   ` Matthew D. Pitts
@ 2002-05-12 20:35   ` Anton Altaparmakov
  2002-05-12 21:17   ` Florian Weimer
  2002-05-13  8:57   ` jw schultz
  5 siblings, 0 replies; 75+ messages in thread
From: Anton Altaparmakov @ 2002-05-12 20:35 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

At 21:06 12/05/02, Linus Torvalds wrote:
>In article <20020512010709.7a973fac.spyro@armlinux.org>,
>Ian Molton  <spyro@armlinux.org> wrote:
> >
> >I dont know who to write to about this, but the changelogs for
> >2.4.19-pre on kernel.org are COMPLETELY illegible.
>
>Hmm..
>
>You're definitely right about the BK version numbers, since those are
>meaningless anyway (they are only meaningful within one BK tree, and
>they change over time when you merge different trees together.
>
>The 2.4.x changelogs seem to be done with my "release" scripts, but
>additionally they don't have the same kind of detailed information that
>the 2.5.x kernels have, and yes, the result is fairly ugly.
>
>What are peoples opinion about the "full" changelog format that v2.5.x
>kernels have? Should we sort that too by author?

I like the current 2.5.x format. It gives a quick overview so I can choose 
which changesets interest me and I usually go into bk revtool afterwards 
and have a look at the actual code in the changesets of interest...

And I agree that the cut down 2.4.x changelog is not very useful... I 
always have to do a bk changes on the 2.4.x tree to get the full details.

Best regards,

Anton


>Perl is the obvious choice for doing transformations like these.  Is
>anybody willing to write a perl script that does the "sort by author"
>thing?
>
>I'll remove the date/BK ID thing, so that my unsorted changelogs would
>look like the appended thing.  But yes, sorting (and merging) by author
>would probably be a good thing. (My BK changelog scripts can also add
>markers around the actual log message, to make parsing easier).
>
>                 Linus
>
>-----
>
>Summary of changes from v2.5.13 to v2.5.14
>============================================
>
><jsimmons@heisenberg.transvirtual.com>
>         A bunch of fixes.
>
><jsimmons@heisenberg.transvirtual.com>
>         Pmac updates
>
><jsimmons@heisenberg.transvirtual.com>
>         Some more small fixes.
>
><rmk@arm.linux.org.uk>
>         [PATCH] 2.5.13: vmalloc link failure
>
>         The following patch fixes this, and also fixes the similar problem in
>         scsi_debug.c:
>
><trond.myklebust@fys.uio.no>
>         [PATCH] in_ntoa link failure
>
>         Nothing serious. Whoever it was that did that global replacemissed a
>         spot is all...
>
><viro@math.psu.edu>
>         [PATCH] change_floppy() fix
>
>         Needed both in 2.4 and 2.5
>...
>-
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/

-- 
   "I've not lost my mind. It's backed up on tape somewhere." - Unknown
-- 
Anton Altaparmakov <aia21 at cantab.net> (replace at with @)
Linux NTFS Maintainer / IRC: #ntfs on irc.openprojects.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/


^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-12 20:06 ` Linus Torvalds
  2002-05-12 20:20   ` Jeff Garzik
  2002-05-12 20:31   ` Dr. David Alan Gilbert
@ 2002-05-12 20:31   ` Matthew D. Pitts
  2002-05-12 20:35   ` Anton Altaparmakov
                     ` (2 subsequent siblings)
  5 siblings, 0 replies; 75+ messages in thread
From: Matthew D. Pitts @ 2002-05-12 20:31 UTC (permalink / raw)
  To: linux-kernel, Linus Torvalds

Linus,

It would help if the some of the people that used BK would bother to be more
descriptive about the stuff they send.

I will have some patches for 2.5.x from my personal stash as soon as i get
the bugs worked out of them...

Matthew D. Pitts.

----- Original Message -----
From: "Linus Torvalds" <torvalds@transmeta.com>
To: <linux-kernel@vger.kernel.org>
Sent: Sunday, May 12, 2002 4:06 PM
Subject: Re: Changelogs on kernel.org


> In article <20020512010709.7a973fac.spyro@armlinux.org>,
> Ian Molton  <spyro@armlinux.org> wrote:
> >
> >I dont know who to write to about this, but the changelogs for
> >2.4.19-pre on kernel.org are COMPLETELY illegible.
>
> Hmm..
>
> You're definitely right about the BK version numbers, since those are
> meaningless anyway (they are only meaningful within one BK tree, and
> they change over time when you merge different trees together.
>
> The 2.4.x changelogs seem to be done with my "release" scripts, but
> additionally they don't have the same kind of detailed information that
> the 2.5.x kernels have, and yes, the result is fairly ugly.
>
> What are peoples opinion about the "full" changelog format that v2.5.x
> kernels have? Should we sort that too by author?
>
> Perl is the obvious choice for doing transformations like these.  Is
> anybody willing to write a perl script that does the "sort by author"
> thing?
>
> I'll remove the date/BK ID thing, so that my unsorted changelogs would
> look like the appended thing.  But yes, sorting (and merging) by author
> would probably be a good thing. (My BK changelog scripts can also add
> markers around the actual log message, to make parsing easier).
>
> Linus
>
> -----
>
> Summary of changes from v2.5.13 to v2.5.14
> ============================================
>
> <jsimmons@heisenberg.transvirtual.com>
>         A bunch of fixes.
>
> <jsimmons@heisenberg.transvirtual.com>
>         Pmac updates
>
> <jsimmons@heisenberg.transvirtual.com>
>         Some more small fixes.
>
> <rmk@arm.linux.org.uk>
>         [PATCH] 2.5.13: vmalloc link failure
>
>         The following patch fixes this, and also fixes the similar problem
in
>         scsi_debug.c:
>
> <trond.myklebust@fys.uio.no>
>         [PATCH] in_ntoa link failure
>
>         Nothing serious. Whoever it was that did that global replacemissed
a
>         spot is all...
>
> <viro@math.psu.edu>
>         [PATCH] change_floppy() fix
>
>         Needed both in 2.4 and 2.5
> ...
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-12 20:06 ` Linus Torvalds
  2002-05-12 20:20   ` Jeff Garzik
@ 2002-05-12 20:31   ` Dr. David Alan Gilbert
  2002-05-12 20:41     ` Arnaldo Carvalho de Melo
  2002-05-13  1:56     ` Linus Torvalds
  2002-05-12 20:31   ` Matthew D. Pitts
                     ` (3 subsequent siblings)
  5 siblings, 2 replies; 75+ messages in thread
From: Dr. David Alan Gilbert @ 2002-05-12 20:31 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

* Linus Torvalds (torvalds@transmeta.com) wrote:
> 

<snip>

> What are peoples opinion about the "full" changelog format that v2.5.x
> kernels have? Should we sort that too by author?

I used to read the hand written changelogs, they only used to be a half
page or so; neatly summerising stuff into one line; I can't be bothered
with the full changelogs  - they are obviously useful; but the hand
written half pages are still a lot easier at a quick glance to see if
there is anything that affects you.

Perhaps insisting that each check in message includes a single line (sub
60 chars) description; could turn those into description : name and
remove dupes?

Dave
 ---------------- Have a happy GNU millennium! ----------------------   
/ Dr. David Alan Gilbert    | Running GNU/Linux on Alpha,68K| Happy  \ 
\ gro.gilbert @ treblig.org | MIPS,x86,ARM, SPARC and HP-PA | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-12 20:06 ` Linus Torvalds
@ 2002-05-12 20:20   ` Jeff Garzik
  2002-05-12 20:31   ` Dr. David Alan Gilbert
                     ` (4 subsequent siblings)
  5 siblings, 0 replies; 75+ messages in thread
From: Jeff Garzik @ 2002-05-12 20:20 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

Linus Torvalds wrote:

>The 2.4.x changelogs seem to be done with my "release" scripts, but
>additionally they don't have the same kind of detailed information that
>the 2.5.x kernels have, and yes, the result is fairly ugly.
>
>What are peoples opinion about the "full" changelog format that v2.5.x
>kernels have? Should we sort that too by author?
>

Sorting might help a tiny bit...

I thought about this, when I saw the 2.4.x changelogs.  Typical GNU 
projects seem to have a pretty decent system going -- there is a 
detailed ChangeLog, and an abbreviated high level summary NEWS, for each 
release.

So IMO a good solution would not be to change the format of the BK 
changelogs, but to supplement them with the type of summary that looks 
like the "old Linus" changelogs, i.e. a summary generated by a human:

    Martin Dalecki - IDE updates
    Al Viro - VFS updates
    Andi Kleen - x86-64 update
    ...

The central complaint about BK changelogs seems to be that they are too 
verbose for a quick scan of what a new kernel version contains.  (while 
at the same time lauding the additional information BK provides over the 
old changelogs)

Marcelo gave it a good shot, by (it appears) generating a summary by 
taking the first line of each cset.  The better solution would be a 
human-generated NEWS file.

    Jeff




^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-12  0:07 Ian Molton
  2002-05-12  0:48 ` Diego Calleja
  2002-05-12  1:09 ` john slee
@ 2002-05-12 20:06 ` Linus Torvalds
  2002-05-12 20:20   ` Jeff Garzik
                     ` (5 more replies)
  2 siblings, 6 replies; 75+ messages in thread
From: Linus Torvalds @ 2002-05-12 20:06 UTC (permalink / raw)
  To: linux-kernel

In article <20020512010709.7a973fac.spyro@armlinux.org>,
Ian Molton  <spyro@armlinux.org> wrote:
>
>I dont know who to write to about this, but the changelogs for
>2.4.19-pre on kernel.org are COMPLETELY illegible.

Hmm..

You're definitely right about the BK version numbers, since those are
meaningless anyway (they are only meaningful within one BK tree, and
they change over time when you merge different trees together.

The 2.4.x changelogs seem to be done with my "release" scripts, but
additionally they don't have the same kind of detailed information that
the 2.5.x kernels have, and yes, the result is fairly ugly.

What are peoples opinion about the "full" changelog format that v2.5.x
kernels have? Should we sort that too by author?

Perl is the obvious choice for doing transformations like these.  Is
anybody willing to write a perl script that does the "sort by author"
thing?

I'll remove the date/BK ID thing, so that my unsorted changelogs would
look like the appended thing.  But yes, sorting (and merging) by author
would probably be a good thing. (My BK changelog scripts can also add
markers around the actual log message, to make parsing easier).

		Linus

-----

Summary of changes from v2.5.13 to v2.5.14
============================================

<jsimmons@heisenberg.transvirtual.com>
        A bunch of fixes.

<jsimmons@heisenberg.transvirtual.com>
        Pmac updates

<jsimmons@heisenberg.transvirtual.com>
        Some more small fixes.

<rmk@arm.linux.org.uk>
        [PATCH] 2.5.13: vmalloc link failure
        
        The following patch fixes this, and also fixes the similar problem in
        scsi_debug.c:

<trond.myklebust@fys.uio.no>
        [PATCH] in_ntoa link failure
        
        Nothing serious. Whoever it was that did that global replacemissed a
        spot is all...

<viro@math.psu.edu>
        [PATCH] change_floppy() fix
        
        Needed both in 2.4 and 2.5
...

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-12  5:05   ` Brian C. Huffman
@ 2002-05-12 10:05     ` Johnny Mnemonic
  2002-05-13  0:46       ` Rik van Riel
  0 siblings, 1 reply; 75+ messages in thread
From: Johnny Mnemonic @ 2002-05-12 10:05 UTC (permalink / raw)
  To: linux-kernel

On Sunday 12 May 2002 07:05, Brian C. Huffman wrote:
> Generally the defense that "no one else is saying anything" is not a
> good one - especially b/c it opens up a huge space for others to agree
> with the original argument.  And yes, they are illegible.
>

I agree. If developers need that changelog style it's fine, but on kernel.org 
homepage there should the old changelog format, so everyone can read it.
The best changelog i've ever seen is the one used around ~2.4.9 release

 - changedescription                         (author)

Regards

-- 
Johnny

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-12  1:09 ` john slee
  2002-05-12  1:14   ` john slee
  2002-05-12  5:05   ` Brian C. Huffman
@ 2002-05-12  9:14   ` Trever L. Adams
  2 siblings, 0 replies; 75+ messages in thread
From: Trever L. Adams @ 2002-05-12  9:14 UTC (permalink / raw)
  To: john slee; +Cc: Ian Molton, Linux Kernel Mailing List

On Sat, 2002-05-11 at 18:09, john slee wrote:
> On Sun, May 12, 2002 at 01:07:09AM +0100, Ian Molton wrote:
> > I dont know who to write to about this, but the changelogs for
> > 2.4.19-pre on kernel.org are COMPLETELY illegible.
> 
> you seem to be the only one publicly complaining.  go write a procmail
> recipe to fix them up.
> 
> j.

It seems to me that there is one positive change that could be made. 
The directory of the change should be named (since multiple files could
be affected, directories are probably fewer in number).

Trever

--


^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-12  1:09 ` john slee
  2002-05-12  1:14   ` john slee
@ 2002-05-12  5:05   ` Brian C. Huffman
  2002-05-12 10:05     ` Johnny Mnemonic
  2002-05-12  9:14   ` Trever L. Adams
  2 siblings, 1 reply; 75+ messages in thread
From: Brian C. Huffman @ 2002-05-12  5:05 UTC (permalink / raw)
  To: john slee; +Cc: Ian Molton, linux-kernel

Generally the defense that "no one else is saying anything" is not a
good one - especially b/c it opens up a huge space for others to agree
with the original argument.  And yes, they are illegible.  

In fact, I believe that when things originally moved to BK, there was
some discussion that although it was a step in the right direction, it
needed to be cleaned up a little bit.

-Brian

On Sat, 2002-05-11 at 21:09, john slee wrote:
> On Sun, May 12, 2002 at 01:07:09AM +0100, Ian Molton wrote:
> > I dont know who to write to about this, but the changelogs for
> > 2.4.19-pre on kernel.org are COMPLETELY illegible.
> 
> you seem to be the only one publicly complaining.  go write a procmail
> recipe to fix them up.
> 



^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-12  1:09 ` john slee
@ 2002-05-12  1:14   ` john slee
  2002-05-12  5:05   ` Brian C. Huffman
  2002-05-12  9:14   ` Trever L. Adams
  2 siblings, 0 replies; 75+ messages in thread
From: john slee @ 2002-05-12  1:14 UTC (permalink / raw)
  To: Ian Molton; +Cc: linux-kernel

On Sun, May 12, 2002 at 11:09:59AM +1000, john slee wrote:
> On Sun, May 12, 2002 at 01:07:09AM +0100, Ian Molton wrote:
> > I dont know who to write to about this, but the changelogs for
> > 2.4.19-pre on kernel.org are COMPLETELY illegible.
> 
> you seem to be the only one publicly complaining.  go write a procmail
> recipe to fix them up.

duh, that was a bit of a thinko.  of course you could apply the same to
a shell script.  :-)

i suspect that some people sufficiently "one with BK" might want the
version-number-looking-things for each item in the changelog, not just
per person.

j.

-- 
R N G G   "Well, there it goes again... And we just sit 
 I G G G   here without opposable thumbs." -- gary larson

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-12  0:07 Ian Molton
  2002-05-12  0:48 ` Diego Calleja
@ 2002-05-12  1:09 ` john slee
  2002-05-12  1:14   ` john slee
                     ` (2 more replies)
  2002-05-12 20:06 ` Linus Torvalds
  2 siblings, 3 replies; 75+ messages in thread
From: john slee @ 2002-05-12  1:09 UTC (permalink / raw)
  To: Ian Molton; +Cc: linux-kernel

On Sun, May 12, 2002 at 01:07:09AM +0100, Ian Molton wrote:
> I dont know who to write to about this, but the changelogs for
> 2.4.19-pre on kernel.org are COMPLETELY illegible.

you seem to be the only one publicly complaining.  go write a procmail
recipe to fix them up.

j.

-- 
R N G G   "Well, there it goes again... And we just sit 
 I G G G   here without opposable thumbs." -- gary larson

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Re: Changelogs on kernel.org
  2002-05-12  0:07 Ian Molton
@ 2002-05-12  0:48 ` Diego Calleja
  2002-05-12  1:09 ` john slee
  2002-05-12 20:06 ` Linus Torvalds
  2 siblings, 0 replies; 75+ messages in thread
From: Diego Calleja @ 2002-05-12  0:48 UTC (permalink / raw)
  To: Ian Molton; +Cc: linux-kernel

On Sun, 12 May 2002 01:07:09 +0100
Ian Molton <spyro@armlinux.org> escribió:

> 
> Hi.
> 
> I dont know who to write to about this, but the changelogs for
> 2.4.19-pre on kernel.org are COMPLETELY illegible.
> 
> Can we 'tweak' them so that instead of:
> 
> <stelian@popies.net> (02/04/17 1.383.12.1)
> 	Fix meye driver request_irq bug.

Well, why not having the date -02/04/17 in that case-?
What I'd really like to know is "1.383.12.1". I suposse it's bitkeeper info.
¿It's really useful?

^ permalink raw reply	[flat|nested] 75+ messages in thread

* Changelogs on kernel.org
@ 2002-05-12  0:07 Ian Molton
  2002-05-12  0:48 ` Diego Calleja
                   ` (2 more replies)
  0 siblings, 3 replies; 75+ messages in thread
From: Ian Molton @ 2002-05-12  0:07 UTC (permalink / raw)
  To: linux-kernel


Hi.

I dont know who to write to about this, but the changelogs for
2.4.19-pre on kernel.org are COMPLETELY illegible.

Can we 'tweak' them so that instead of:

<stelian@popies.net> (02/04/17 1.383.12.1)
	Fix meye driver request_irq bug.

<stelian@popies.net> (02/04/17 1.383.12.2)
	Enable the meye driver to get parameters on the kernel command line.

<akpm@zip.com.au> (02/04/17 1.383.13.1)
	[PATCH] add __LINE__ to out_of_line_bug()

<alan@lxorguk.ukuu.org.uk> (02/04/17 1.383.13.2)
	[PATCH] PATCH: some configure.help updates

<alan@lxorguk.ukuu.org.uk> (02/04/17 1.383.13.3)
	[PATCH] PATCH: more configure.help

<alan@lxorguk.ukuu.org.uk> (02/04/17 1.383.13.4)
	[PATCH] PATCH: More configure.help

<alan@lxorguk.ukuu.org.uk> (02/04/17 1.383.13.5)
	[PATCH] PATCH: more Configure.help

<alan@lxorguk.ukuu.org.uk> (02/04/17 1.383.13.6)
	[PATCH] PATCH: maintainers update

<alan@lxorguk.ukuu.org.uk> (02/04/17 1.383.13.7)
	[PATCH] PATCH: make cpu names clearer for new VIA


We get something nice like:

<stelian@popies.net>
   Fix meye driver request_irq bug.
   Enable the meye driver to get parameters on the kernel command line.

<akpm@zip.com.au>
   [PATCH] add __LINE__ to out_of_line_bug()

<alan@lxorguk.ukuu.org.uk>
   [PATCH] PATCH: some configure.help updates
   [PATCH] PATCH: more configure.help
   ... above repeated 2 times
   [PATCH] PATCH: maintainers update
   [PATCH] PATCH: make cpu names clearer for new VIA



^ permalink raw reply	[flat|nested] 75+ messages in thread

end of thread, other threads:[~2002-05-16  6:59 UTC | newest]

Thread overview: 75+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-05-15 21:38 Changelogs on kernel.org James Bottomley
     [not found] <30386.1021456050@redhat.com>
2002-05-15 16:39 ` Linus Torvalds
2002-05-15 18:07   ` David Woodhouse
2002-05-15 19:20   ` Larry McVoy
2002-05-15 20:03     ` David Woodhouse
2002-05-15 20:08       ` Larry McVoy
2002-05-15 20:15         ` David Woodhouse
2002-05-15 20:34           ` Larry McVoy
2002-05-15 21:03           ` Kenneth Johansson
2002-05-15 22:30             ` Larry McVoy
2002-05-15 22:56               ` Kai Germaschewski
2002-05-15 22:59                 ` Larry McVoy
2002-05-16  2:26                   ` Horst von Brand
2002-05-16  7:02           ` Rusty Russell
  -- strict thread matches above, loose matches on Subject: below --
2002-05-12  0:07 Ian Molton
2002-05-12  0:48 ` Diego Calleja
2002-05-12  1:09 ` john slee
2002-05-12  1:14   ` john slee
2002-05-12  5:05   ` Brian C. Huffman
2002-05-12 10:05     ` Johnny Mnemonic
2002-05-13  0:46       ` Rik van Riel
2002-05-13 11:52         ` Marcus Alanen
2002-05-13 12:09           ` Tomas Szepe
2002-05-13 13:08             ` Marcus Alanen
2002-05-13 14:08               ` Tomas Szepe
2002-05-13 14:45                 ` Tomas Szepe
2002-05-13 14:06                   ` Greg KH
2002-05-13 15:11                     ` Tomas Szepe
2002-05-13 14:51                       ` Greg KH
2002-05-13 15:58                         ` Matthias Andree
2002-05-13 15:21                     ` Matthias Andree
2002-05-13 22:05                   ` Robinson Maureira Castillo
2002-05-13 23:41                     ` Tomas Szepe
2002-05-14  8:44                       ` Matthias Andree
2002-05-14  8:43                     ` Matthias Andree
2002-05-14  9:23                       ` Tomas Szepe
2002-05-13 11:58         ` Tomas Szepe
2002-05-13 12:39           ` Dave Gilbert (Home)
2002-05-13 13:01             ` Russell King
2002-05-13 13:27               ` Tomas Szepe
2002-05-13 13:42                 ` Russell King
2002-05-13 15:12                 ` Larry McVoy
2002-05-13 15:29                   ` Tomas Szepe
2002-05-13 15:37                     ` Larry McVoy
2002-05-12  9:14   ` Trever L. Adams
2002-05-12 20:06 ` Linus Torvalds
2002-05-12 20:20   ` Jeff Garzik
2002-05-12 20:31   ` Dr. David Alan Gilbert
2002-05-12 20:41     ` Arnaldo Carvalho de Melo
2002-05-13 20:57       ` Linus Torvalds
2002-05-14  0:29         ` Arnaldo Carvalho de Melo
2002-05-13  1:56     ` Linus Torvalds
2002-05-13  9:31       ` Matthias Andree
2002-05-13  8:52         ` Greg KH
2002-05-13 10:41           ` Matthias Andree
2002-05-13 10:12       ` Tomas Szepe
2002-05-13 10:17         ` Tomas Szepe
2002-05-13 13:00         ` Ian Molton
2002-05-12 20:31   ` Matthew D. Pitts
2002-05-12 20:35   ` Anton Altaparmakov
2002-05-12 21:17   ` Florian Weimer
2002-05-12 21:42     ` Marcus Alanen
2002-05-12 22:12       ` Tomas Szepe
2002-05-13 10:32         ` Helge Hafting
2002-05-13  7:34       ` Kristian Peters
2002-05-12 21:51     ` Ian Molton
2002-05-12 21:47       ` Florian Weimer
2002-05-12 23:50         ` Sven.Riedel
2002-05-13  2:01     ` Linus Torvalds
2002-05-13  5:10       ` Jeff Garzik
2002-05-13  5:17         ` Larry McVoy
2002-05-13 10:37         ` Helge Hafting
2002-05-13 19:00           ` Jeff Garzik
2002-05-13  8:57   ` jw schultz
2002-05-13  8:06     ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).