* [PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey
@ 2017-11-06 14:35 Gustavo A. R. Silva
2017-11-07 6:31 ` Yuval Shaia
2017-11-07 8:25 ` Leon Romanovsky
0 siblings, 2 replies; 13+ messages in thread
From: Gustavo A. R. Silva @ 2017-11-06 14:35 UTC (permalink / raw)
To: Selvin Xavier, Devesh Sharma, Doug Ledford
Cc: linux-rdma, linux-kernel, Gustavo A. R. Silva
Check on return value and goto label mbx_err are unnecessary.
Addresses-Coverity-ID: 1268780
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
index f8c14c7..db02bbb 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
@@ -1956,9 +1956,7 @@ int ocrdma_mbx_dealloc_lkey(struct ocrdma_dev *dev, int fr_mr, u32 lkey)
cmd->lkey = lkey;
cmd->rsvd_frmr = fr_mr ? 1 : 0;
status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd);
- if (status)
- goto mbx_err;
-mbx_err:
+
kfree(cmd);
return status;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey
2017-11-06 14:35 [PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey Gustavo A. R. Silva
@ 2017-11-07 6:31 ` Yuval Shaia
2017-11-07 14:27 ` Gustavo A. R. Silva
2017-11-07 8:25 ` Leon Romanovsky
1 sibling, 1 reply; 13+ messages in thread
From: Yuval Shaia @ 2017-11-07 6:31 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Selvin Xavier, Devesh Sharma, Doug Ledford, linux-rdma, linux-kernel
On Mon, Nov 06, 2017 at 08:35:14AM -0600, Gustavo A. R. Silva wrote:
> Check on return value and goto label mbx_err are unnecessary.
>
> Addresses-Coverity-ID: 1268780
What's that?
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> index f8c14c7..db02bbb 100644
> --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> @@ -1956,9 +1956,7 @@ int ocrdma_mbx_dealloc_lkey(struct ocrdma_dev *dev, int fr_mr, u32 lkey)
> cmd->lkey = lkey;
> cmd->rsvd_frmr = fr_mr ? 1 : 0;
> status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd);
> - if (status)
> - goto mbx_err;
> -mbx_err:
> +
> kfree(cmd);
> return status;
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
> }
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey
2017-11-06 14:35 [PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey Gustavo A. R. Silva
2017-11-07 6:31 ` Yuval Shaia
@ 2017-11-07 8:25 ` Leon Romanovsky
2017-11-07 14:30 ` Gustavo A. R. Silva
1 sibling, 1 reply; 13+ messages in thread
From: Leon Romanovsky @ 2017-11-07 8:25 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Selvin Xavier, Devesh Sharma, Doug Ledford, linux-rdma, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 990 bytes --]
On Mon, Nov 06, 2017 at 08:35:14AM -0600, Gustavo A. R. Silva wrote:
> Check on return value and goto label mbx_err are unnecessary.
>
> Addresses-Coverity-ID: 1268780
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> index f8c14c7..db02bbb 100644
> --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> @@ -1956,9 +1956,7 @@ int ocrdma_mbx_dealloc_lkey(struct ocrdma_dev *dev, int fr_mr, u32 lkey)
> cmd->lkey = lkey;
> cmd->rsvd_frmr = fr_mr ? 1 : 0;
> status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd);
> - if (status)
> - goto mbx_err;
> -mbx_err:
> +
Can you please remove assignment from "int status = -ENOMEM"?
It produces warning too.
Thanks
> kfree(cmd);
> return status;
> }
> --
> 2.7.4
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey
2017-11-07 6:31 ` Yuval Shaia
@ 2017-11-07 14:27 ` Gustavo A. R. Silva
0 siblings, 0 replies; 13+ messages in thread
From: Gustavo A. R. Silva @ 2017-11-07 14:27 UTC (permalink / raw)
To: Yuval Shaia
Cc: Selvin Xavier, Devesh Sharma, Doug Ledford, linux-rdma, linux-kernel
Hi Yuval,
Quoting Yuval Shaia <yuval.shaia@oracle.com>:
> On Mon, Nov 06, 2017 at 08:35:14AM -0600, Gustavo A. R. Silva wrote:
>> Check on return value and goto label mbx_err are unnecessary.
>>
>> Addresses-Coverity-ID: 1268780
>
> What's that?
>
Coverity is a static code analyzer.
I am fixing Coverity issues and that is the ID Coverity assigned to
this particular issue.
>> ---
>> drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
>> b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
>> index f8c14c7..db02bbb 100644
>> --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
>> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
>> @@ -1956,9 +1956,7 @@ int ocrdma_mbx_dealloc_lkey(struct ocrdma_dev
>> *dev, int fr_mr, u32 lkey)
>> cmd->lkey = lkey;
>> cmd->rsvd_frmr = fr_mr ? 1 : 0;
>> status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd);
>> - if (status)
>> - goto mbx_err;
>> -mbx_err:
>> +
>> kfree(cmd);
>> return status;
>
> Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
>
Thank you
--
Gustavo A. R. Silva
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey
2017-11-07 8:25 ` Leon Romanovsky
@ 2017-11-07 14:30 ` Gustavo A. R. Silva
2017-11-07 14:44 ` Leon Romanovsky
2017-11-07 14:45 ` [PATCH v2] " Gustavo A. R. Silva
0 siblings, 2 replies; 13+ messages in thread
From: Gustavo A. R. Silva @ 2017-11-07 14:30 UTC (permalink / raw)
To: Leon Romanovsky
Cc: Selvin Xavier, Devesh Sharma, Doug Ledford, linux-rdma, linux-kernel
Hi Leon,
Quoting Leon Romanovsky <leon@kernel.org>:
> On Mon, Nov 06, 2017 at 08:35:14AM -0600, Gustavo A. R. Silva wrote:
>> Check on return value and goto label mbx_err are unnecessary.
>>
>> Addresses-Coverity-ID: 1268780
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> ---
>> drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
>> b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
>> index f8c14c7..db02bbb 100644
>> --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
>> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
>> @@ -1956,9 +1956,7 @@ int ocrdma_mbx_dealloc_lkey(struct ocrdma_dev
>> *dev, int fr_mr, u32 lkey)
>> cmd->lkey = lkey;
>> cmd->rsvd_frmr = fr_mr ? 1 : 0;
>> status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd);
>> - if (status)
>> - goto mbx_err;
>> -mbx_err:
>> +
>
> Can you please remove assignment from "int status = -ENOMEM"?
> It produces warning too.
>
OK. Will do.
By the way, which compiler triggers that warning?
I'm using GCC 7.2.0 and I don't see it.
Thanks
--
Gustavo A. R. Silva
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey
2017-11-07 14:30 ` Gustavo A. R. Silva
@ 2017-11-07 14:44 ` Leon Romanovsky
2017-11-07 14:45 ` [PATCH v2] " Gustavo A. R. Silva
1 sibling, 0 replies; 13+ messages in thread
From: Leon Romanovsky @ 2017-11-07 14:44 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Selvin Xavier, Devesh Sharma, Doug Ledford, linux-rdma, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1411 bytes --]
On Tue, Nov 07, 2017 at 08:30:22AM -0600, Gustavo A. R. Silva wrote:
> Hi Leon,
>
> Quoting Leon Romanovsky <leon@kernel.org>:
>
> > On Mon, Nov 06, 2017 at 08:35:14AM -0600, Gustavo A. R. Silva wrote:
> > > Check on return value and goto label mbx_err are unnecessary.
> > >
> > > Addresses-Coverity-ID: 1268780
> > > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> > > ---
> > > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 4 +---
> > > 1 file changed, 1 insertion(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> > > b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> > > index f8c14c7..db02bbb 100644
> > > --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> > > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> > > @@ -1956,9 +1956,7 @@ int ocrdma_mbx_dealloc_lkey(struct ocrdma_dev
> > > *dev, int fr_mr, u32 lkey)
> > > cmd->lkey = lkey;
> > > cmd->rsvd_frmr = fr_mr ? 1 : 0;
> > > status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd);
> > > - if (status)
> > > - goto mbx_err;
> > > -mbx_err:
> > > +
> >
> > Can you please remove assignment from "int status = -ENOMEM"?
> > It produces warning too.
> >
>
> OK. Will do.
>
> By the way, which compiler triggers that warning?
Honestly, I don't remember, one of my building bots complained about it.
Thanks
>
> I'm using GCC 7.2.0 and I don't see it.
>
> Thanks
> --
> Gustavo A. R. Silva
>
>
>
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey
2017-11-07 14:30 ` Gustavo A. R. Silva
2017-11-07 14:44 ` Leon Romanovsky
@ 2017-11-07 14:45 ` Gustavo A. R. Silva
2017-11-07 14:50 ` Leon Romanovsky
2017-11-13 21:19 ` Doug Ledford
1 sibling, 2 replies; 13+ messages in thread
From: Gustavo A. R. Silva @ 2017-11-07 14:45 UTC (permalink / raw)
To: Selvin Xavier, Devesh Sharma, Doug Ledford, Yuval Shaia, Leon Romanovsky
Cc: linux-rdma, linux-kernel, Gustavo A. R. Silva
Check on return value and goto label mbx_err are unnecessary.
Addresses-Coverity-ID: 1268780
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
---
Changes in v2:
Remove assignment from "int status = -ENOMEM" as suggested by Leon Romanovsky.
drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
index f8c14c7..0ba695a 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
@@ -1947,7 +1947,7 @@ int ocrdma_mbx_alloc_lkey(struct ocrdma_dev *dev, struct ocrdma_hw_mr *hwmr,
int ocrdma_mbx_dealloc_lkey(struct ocrdma_dev *dev, int fr_mr, u32 lkey)
{
- int status = -ENOMEM;
+ int status;
struct ocrdma_dealloc_lkey *cmd;
cmd = ocrdma_init_emb_mqe(OCRDMA_CMD_DEALLOC_LKEY, sizeof(*cmd));
@@ -1956,9 +1956,7 @@ int ocrdma_mbx_dealloc_lkey(struct ocrdma_dev *dev, int fr_mr, u32 lkey)
cmd->lkey = lkey;
cmd->rsvd_frmr = fr_mr ? 1 : 0;
status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd);
- if (status)
- goto mbx_err;
-mbx_err:
+
kfree(cmd);
return status;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v2] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey
2017-11-07 14:45 ` [PATCH v2] " Gustavo A. R. Silva
@ 2017-11-07 14:50 ` Leon Romanovsky
2017-11-07 14:56 ` Gustavo A. R. Silva
2017-11-13 21:19 ` Doug Ledford
1 sibling, 1 reply; 13+ messages in thread
From: Leon Romanovsky @ 2017-11-07 14:50 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Selvin Xavier, Devesh Sharma, Doug Ledford, Yuval Shaia,
linux-rdma, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 634 bytes --]
On Tue, Nov 07, 2017 at 08:45:17AM -0600, Gustavo A. R. Silva wrote:
> Check on return value and goto label mbx_err are unnecessary.
>
> Addresses-Coverity-ID: 1268780
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
> ---
> Changes in v2:
> Remove assignment from "int status = -ENOMEM" as suggested by Leon Romanovsky.
>
> drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Please use git send-email to send patches and not reply to the conversation.
Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey
2017-11-07 14:50 ` Leon Romanovsky
@ 2017-11-07 14:56 ` Gustavo A. R. Silva
2017-11-07 16:28 ` Leon Romanovsky
0 siblings, 1 reply; 13+ messages in thread
From: Gustavo A. R. Silva @ 2017-11-07 14:56 UTC (permalink / raw)
To: Leon Romanovsky
Cc: Selvin Xavier, Devesh Sharma, Doug Ledford, Yuval Shaia,
linux-rdma, linux-kernel
Quoting Leon Romanovsky <leon@kernel.org>:
> On Tue, Nov 07, 2017 at 08:45:17AM -0600, Gustavo A. R. Silva wrote:
>> Check on return value and goto label mbx_err are unnecessary.
>>
>> Addresses-Coverity-ID: 1268780
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
>> ---
>> Changes in v2:
>> Remove assignment from "int status = -ENOMEM" as suggested by Leon
>> Romanovsky.
>>
>> drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> Please use git send-email to send patches and not reply to the conversation.
>
I'm using mutt.
What would be the advantage of using git send-email in this case?
> Thanks,
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Thank you
--
Gustavo A. R. Silva
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey
2017-11-07 14:56 ` Gustavo A. R. Silva
@ 2017-11-07 16:28 ` Leon Romanovsky
2017-11-08 20:16 ` Gustavo A. R. Silva
0 siblings, 1 reply; 13+ messages in thread
From: Leon Romanovsky @ 2017-11-07 16:28 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Selvin Xavier, Devesh Sharma, Doug Ledford, Yuval Shaia,
linux-rdma, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]
On Tue, Nov 07, 2017 at 08:56:37AM -0600, Gustavo A. R. Silva wrote:
>
> Quoting Leon Romanovsky <leon@kernel.org>:
>
> > On Tue, Nov 07, 2017 at 08:45:17AM -0600, Gustavo A. R. Silva wrote:
> > > Check on return value and goto label mbx_err are unnecessary.
> > >
> > > Addresses-Coverity-ID: 1268780
> > > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> > > Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
> > > ---
> > > Changes in v2:
> > > Remove assignment from "int status = -ENOMEM" as suggested by Leon
> > > Romanovsky.
> > >
> > > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 6 ++----
> > > 1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > Please use git send-email to send patches and not reply to the conversation.
> >
>
> I'm using mutt.
> What would be the advantage of using git send-email in this case?
New mail headers, so it won't appear as Reply-To and will be presented
correctly in mutt's threaded mode.
You can do it with mutt too.
>
> > Thanks,
> > Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
>
> Thank you
> --
> Gustavo A. R. Silva
>
>
>
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey
2017-11-07 16:28 ` Leon Romanovsky
@ 2017-11-08 20:16 ` Gustavo A. R. Silva
2017-11-09 8:28 ` Leon Romanovsky
0 siblings, 1 reply; 13+ messages in thread
From: Gustavo A. R. Silva @ 2017-11-08 20:16 UTC (permalink / raw)
To: Leon Romanovsky
Cc: Selvin Xavier, Devesh Sharma, Doug Ledford, Yuval Shaia,
linux-rdma, linux-kernel
Quoting Leon Romanovsky <leon@kernel.org>:
> On Tue, Nov 07, 2017 at 08:56:37AM -0600, Gustavo A. R. Silva wrote:
>>
>> Quoting Leon Romanovsky <leon@kernel.org>:
>>
>> > On Tue, Nov 07, 2017 at 08:45:17AM -0600, Gustavo A. R. Silva wrote:
>> > > Check on return value and goto label mbx_err are unnecessary.
>> > >
>> > > Addresses-Coverity-ID: 1268780
>> > > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> > > Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
>> > > ---
>> > > Changes in v2:
>> > > Remove assignment from "int status = -ENOMEM" as suggested by Leon
>> > > Romanovsky.
>> > >
>> > > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 6 ++----
>> > > 1 file changed, 2 insertions(+), 4 deletions(-)
>> >
>> > Please use git send-email to send patches and not reply to the
>> conversation.
>> >
>>
>> I'm using mutt.
>> What would be the advantage of using git send-email in this case?
>
> New mail headers, so it won't appear as Reply-To and will be presented
> correctly in mutt's threaded mode.
>
Oh I actually did that on purpose.
So the preferred way to do this is to send the vN of the patch as a
reply to the first patch?
or as a new thread?
Thanks
--
Gustavo A. R. Silva
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey
2017-11-08 20:16 ` Gustavo A. R. Silva
@ 2017-11-09 8:28 ` Leon Romanovsky
0 siblings, 0 replies; 13+ messages in thread
From: Leon Romanovsky @ 2017-11-09 8:28 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Selvin Xavier, Devesh Sharma, Doug Ledford, Yuval Shaia,
linux-rdma, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1807 bytes --]
On Wed, Nov 08, 2017 at 02:16:25PM -0600, Gustavo A. R. Silva wrote:
>
> Quoting Leon Romanovsky <leon@kernel.org>:
>
> > On Tue, Nov 07, 2017 at 08:56:37AM -0600, Gustavo A. R. Silva wrote:
> > >
> > > Quoting Leon Romanovsky <leon@kernel.org>:
> > >
> > > > On Tue, Nov 07, 2017 at 08:45:17AM -0600, Gustavo A. R. Silva wrote:
> > > > > Check on return value and goto label mbx_err are unnecessary.
> > > > >
> > > > > Addresses-Coverity-ID: 1268780
> > > > > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> > > > > Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
> > > > > ---
> > > > > Changes in v2:
> > > > > Remove assignment from "int status = -ENOMEM" as suggested by Leon
> > > > > Romanovsky.
> > > > >
> > > > > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 6 ++----
> > > > > 1 file changed, 2 insertions(+), 4 deletions(-)
> > > >
> > > > Please use git send-email to send patches and not reply to the
> > > conversation.
> > > >
> > >
> > > I'm using mutt.
> > > What would be the advantage of using git send-email in this case?
> >
> > New mail headers, so it won't appear as Reply-To and will be presented
> > correctly in mutt's threaded mode.
> >
>
> Oh I actually did that on purpose.
>
> So the preferred way to do this is to send the vN of the patch as a reply to
> the first patch?
> or as a new thread?
As a new thread, please. It gives numerous advantages: nice view in mutt,
easy followed links in web archives and maintainer's acceptance email as
a response to actual vN patch and not to initial patch.
Thanks
>
> Thanks
> --
> Gustavo A. R. Silva
>
>
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey
2017-11-07 14:45 ` [PATCH v2] " Gustavo A. R. Silva
2017-11-07 14:50 ` Leon Romanovsky
@ 2017-11-13 21:19 ` Doug Ledford
1 sibling, 0 replies; 13+ messages in thread
From: Doug Ledford @ 2017-11-13 21:19 UTC (permalink / raw)
To: Gustavo A. R. Silva, Selvin Xavier, Devesh Sharma, Yuval Shaia,
Leon Romanovsky
Cc: linux-rdma, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 451 bytes --]
On Tue, 2017-11-07 at 08:45 -0600, Gustavo A. R. Silva wrote:
> Check on return value and goto label mbx_err are unnecessary.
>
> Addresses-Coverity-ID: 1268780
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
Thanks, applied.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2017-11-13 21:19 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-06 14:35 [PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey Gustavo A. R. Silva
2017-11-07 6:31 ` Yuval Shaia
2017-11-07 14:27 ` Gustavo A. R. Silva
2017-11-07 8:25 ` Leon Romanovsky
2017-11-07 14:30 ` Gustavo A. R. Silva
2017-11-07 14:44 ` Leon Romanovsky
2017-11-07 14:45 ` [PATCH v2] " Gustavo A. R. Silva
2017-11-07 14:50 ` Leon Romanovsky
2017-11-07 14:56 ` Gustavo A. R. Silva
2017-11-07 16:28 ` Leon Romanovsky
2017-11-08 20:16 ` Gustavo A. R. Silva
2017-11-09 8:28 ` Leon Romanovsky
2017-11-13 21:19 ` Doug Ledford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).