From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jonathan Bakker <xc-racer2@live.ca>
Cc: kgene@kernel.org, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>
Subject: Re: [PATCH 06/13] arm: dts: s5pv210: aries: Add support for more devices
Date: Fri, 1 May 2020 15:31:00 +0200 [thread overview]
Message-ID: <20200501133100.GB5154@kozik-lap> (raw)
In-Reply-To: <BN6PR04MB0660776A38353DBDF0E2E3F9A3AC0@BN6PR04MB0660.namprd04.prod.outlook.com>
On Tue, Apr 28, 2020 at 04:32:56PM -0700, Jonathan Bakker wrote:
> Hi Krzysztof,
>
> On 2020-04-28 3:20 a.m., Krzysztof Kozlowski wrote:
> > On Sun, Apr 26, 2020 at 11:35:57AM -0700, Jonathan Bakker wrote:
> >> Add support for following devices:
> >> - touchkeys connected over i2c-gpio
> >> - s6e63m0 panel connected over spi-gpio
> >> - fsa9480 microusb switch over i2c-gpio
> >> - wm8994 over i2c-gpio (no machine driver yet)
> >> - all common i2c-gpio devices
> >
> > Please split it per functionality, e.g.:
> > 1. Add sound,
> > 2. Add panel,
> > 3. Add touchkeys (unless part of panel),
> > 4. The remaining i2c-gpio devices without bindings could go as one.
>
> Ok, will do.
>
> >
> >>
> >> Signed-off-by: Jonathan Bakker <xc-racer2@live.ca>
> >> Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
> >> ---
> >> arch/arm/boot/dts/s5pv210-aries.dtsi | 282 ++++++++++++++++++++--
> >> arch/arm/boot/dts/s5pv210-fascinate4g.dts | 6 +
> >> 2 files changed, 270 insertions(+), 18 deletions(-)
> >>
> >> diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi
> >> index f83df426f2b6..ef966d13d83d 100644
> >> --- a/arch/arm/boot/dts/s5pv210-aries.dtsi
> >> +++ b/arch/arm/boot/dts/s5pv210-aries.dtsi
> >> @@ -12,8 +12,14 @@
> >> compatible = "samsung,aries", "samsung,s5pv210";
> >>
> >> aliases {
> >> + i2c4 = &i2c_sound;
> >> + i2c5 = &i2c_accel;
> >> i2c6 = &i2c_pmic;
> >> + i2c7 = &i2c_musb;
> >> i2c9 = &i2c_fuel;
> >> + i2c10 = &i2c_touchkey;
> >> + i2c11 = &i2c_prox;
> >> + i2c12 = &i2c_magnetometer;
> >> };
> >>
> >> memory@30000000 {
> >> @@ -48,6 +54,18 @@
> >> gpio = <&gpj1 1 GPIO_ACTIVE_HIGH>;
> >> };
> >>
> >> + touchkey_vdd: regulator-fixed-1 {
> >> + compatible = "regulator-fixed";
> >> + regulator-name = "VTOUCH_3.3V";
> >> + regulator-min-microvolt = <3300000>;
> >> + regulator-max-microvolt = <3300000>;
> >> + enable-active-high;
> >> + gpio = <&gpj3 2 GPIO_ACTIVE_HIGH>;
> >> +
> >> + pinctrl-names = "default";
> >> + pinctrl-0 = <&touchkey_vdd_ena>;
> >> + };
> >> +
> >> wifi_pwrseq: wifi-pwrseq {
> >> compatible = "mmc-pwrseq-simple";
> >> reset-gpios = <&gpg1 2 GPIO_ACTIVE_LOW>;
> >> @@ -57,7 +75,69 @@
> >> power-off-delay-us = <500>;
> >> };
> >>
> >> - i2c_pmic: i2c-gpio-0 {
> >> + i2c_sound: i2c-gpio-0 {
> >> + compatible = "i2c-gpio";
> >> + sda-gpios = <&mp05 3 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> >> + scl-gpios = <&mp05 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> >> + i2c-gpio,delay-us = <2>;
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> +
> >> + pinctrl-names = "default";
> >> + pinctrl-0 = <&sound_i2c_pins>;
> >> +
> >> + wm8994: wm8994@1a {
> >> + compatible = "wlf,wm8994";
> >> + reg = <0x1a>;
> >> +
> >> + #sound-dai-cells = <0>;
> >> +
> >> + gpio-controller;
> >> + #gpio-cells = <2>;
> >> +
> >> + clocks = <&clocks MOUT_CLKOUT>;
> >> + clock-names = "MCLK1";
> >> +
> >> + AVDD2-supply = <&buck3_reg>;
> >> + DBVDD-supply = <&buck3_reg>;
> >
> > No such supply, check the bindings.
> >
>
> Well, it may not be in the bindings, but the driver definitely requires it :) See drivers/mfd/wm8994-core.c
>
> What's the best way of dealing with this situation?
I'll send a patch fixing the bindings. However don't you miss the
AVDD1-supply in such case? Driver should report error.
>
> >> + CPVDD-supply = <&buck3_reg>;
> >> + SPKVDD1-supply = <&buck3_reg>;
> >> + SPKVDD2-supply = <&buck3_reg>;
> >> +
> >> + wlf,gpio-cfg = <0xa101 0x8100 0x0100 0x0100 0x8100
> >> + 0xa101 0x0100 0x8100 0x0100 0x0100
> >> + 0x0100>;
> >> +
> >> + wlf,ldo1ena = <&gpf3 4 GPIO_ACTIVE_HIGH>;
> >> + wlf,ldo2ena = <&gpf3 4 GPIO_ACTIVE_HIGH>;
> >> +
> >> + wlf,lineout1-se;
> >> + wlf,lineout2-se;
> >> +
> >> + assigned-clocks = <&clocks MOUT_CLKOUT>;
> >> + assigned-clock-rates = <0>;
> >> + assigned-clock-parents = <&xusbxti>;
> >> +
> >> + pinctrl-names = "default";
> >> + pinctrl-0 = <&codec_ldo>;
> >> + };
> >> + };
> >> +
> >> + i2c_accel: i2c-gpio-1 {
> >> + compatible = "i2c-gpio";
> >> + sda-gpios = <&gpj3 6 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> >> + scl-gpios = <&gpj3 7 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> >> + i2c-gpio,delay-us = <2>;
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> +
> >> + pinctrl-names = "default";
> >> + pinctrl-0 = <&accel_i2c_pins>;
> >> +
> >> + /* bma023 accelerometer, no mainline binding */
> >
> > status disabled ... unless you need it for user-space I2C tools?
> >
>
> Nope, but wanted to add them all in due to adding the si4709 in galaxys. I was having
> issues with accidentally overwriting previously named nodes (ie having i2c-gpio-0 in
> both the common dtsi and the device specific dts) so I wanted to get the numbers
> nailed down.
So add them with status disabled. This will document the HW without
enabling empty I2C GPIO bus.
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-05-01 13:31 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200426183604.28494-1-xc-racer2@live.ca>
2020-04-26 18:35 ` [PATCH 01/13] arm: dts: s5pv210: Add helper define for sleep gpio config Jonathan Bakker
2020-04-26 18:35 ` [PATCH 02/13] arm: dts: s5pv210: fascinate4g: Add sleep GPIO configuration Jonathan Bakker
2020-04-28 10:02 ` Krzysztof Kozlowski
2020-04-28 23:49 ` Jonathan Bakker
2020-05-01 13:10 ` Krzysztof Kozlowski
2020-04-26 18:35 ` [PATCH 03/13] arm: dts: s5pv210: galaxys: " Jonathan Bakker
2020-04-26 18:35 ` [PATCH 04/13] arm: dts: s5pv210: aries: Set keep-power-in-suspend for SDHCI1 Jonathan Bakker
2020-04-26 18:35 ` [PATCH 05/13] arm: dts: s5pv210: aries: Disable pulls on GPIO i2c adapters Jonathan Bakker
2020-04-26 18:35 ` [PATCH 06/13] arm: dts: s5pv210: aries: Add support for more devices Jonathan Bakker
2020-04-28 10:20 ` Krzysztof Kozlowski
2020-04-28 23:32 ` Jonathan Bakker
2020-05-01 13:31 ` Krzysztof Kozlowski [this message]
2020-05-01 19:43 ` Jonathan Bakker
2020-04-26 18:35 ` [PATCH 07/13] arm: dts: s5pv210: galaxys: Add si470x fmradio Jonathan Bakker
2020-04-26 18:35 ` [PATCH 08/13] arm: dts: s5pv210: aries: Disable pull for vibrator ena GPIO Jonathan Bakker
2020-04-26 18:36 ` [PATCH 09/13] arm: dts: s5pv210: Add an ADC node Jonathan Bakker
2020-04-28 10:26 ` Krzysztof Kozlowski
2020-04-28 22:27 ` Jonathan Bakker
2020-04-26 18:36 ` [PATCH 10/13] arm: dts: s5pv210: aries: Enable " Jonathan Bakker
2020-04-28 10:29 ` Krzysztof Kozlowski
2020-04-28 22:26 ` Jonathan Bakker
2020-04-26 18:36 ` [PATCH 11/13] arm: dts: s5pv210: Assign clocks to MMC devices Jonathan Bakker
2020-04-26 18:36 ` [PATCH 12/13] arm: dts: s5pv210: Correct FIMC definitions Jonathan Bakker
2020-04-28 10:32 ` Krzysztof Kozlowski
2020-04-28 22:31 ` Jonathan Bakker
2020-04-26 18:36 ` [PATCH 13/13] arm: dts: s5pv210: aries: Set MAX8998 GPIO pulls Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 00/18] S5PV210 and Aries DTS improvements Jonathan Bakker
2020-05-04 15:15 ` Krzysztof Kozlowski
[not found] ` <20200501235019.24022-1-xc-racer2@live.ca>
2020-05-01 23:50 ` [PATCH v2 01/18] ARM: dts: s5pv210: Add helper define for sleep gpio config Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 02/18] ARM: dts: s5pv210: Add sleep GPIO configuration for fascinate4g Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 03/18] ARM: dts: s5pv210: Add sleep GPIO configuration for galaxys Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 04/18] ARM: dts: s5pv210: Set keep-power-in-suspend for SDHCI1 on aries Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 05/18] ARM: dts: s5pv210: Disable pulls on GPIO i2c adapters for aries Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 06/18] ARM: dts: s5pv210: Add WM8994 support to aries boards Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 07/18] ARM: dts: s5pv210: Add FSA9480 support to Aries boards Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 08/18] ARM: dts: s5pv210: Add touchkey support to aries boards Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 09/18] ARM: dts: s5pv210: Add panel " Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 10/18] ARM: dts: s5pv210: Add remaining i2c-gpio adapters to aries Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 11/18] ARM: dts: s5pv210: Add si470x fmradio to galaxys Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 12/18] ARM: dts: s5pv210: Disable pull for vibrator ena GPIO on aries Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 13/18] ARM: dts: s5pv210: Add an ADC node Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 14/18] ARM: dts: s5pv210: Enable ADC on aries boards Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 15/18] ARM: dts: s5pv210: Assign clocks to MMC devices on aries Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 16/18] ARM: dts: s5pv210: Correct FIMC definitions Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 17/18] ARM: dts: s5pv210: Set MAX8998 GPIO pulls on aries Jonathan Bakker
2020-05-01 23:50 ` [PATCH v2 18/18] ARM: dts: s5pv210: Correct gpi gpio node name Jonathan Bakker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501133100.GB5154@kozik-lap \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pawel.mikolaj.chmiel@gmail.com \
--cc=robh+dt@kernel.org \
--cc=xc-racer2@live.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).