From: Lukasz Luba <lukasz.luba@arm.com>
To: linux-kernel@vger.kernel.org
Cc: Chris.Redpath@arm.com, lukasz.luba@arm.com,
dietmar.eggemann@arm.com, morten.rasmussen@arm.com,
qperret@google.com, linux-pm@vger.kernel.org,
peterz@infradead.org, rjw@rjwysocki.net, viresh.kumar@linaro.org,
vincent.guittot@linaro.org, mingo@redhat.com,
juri.lelli@redhat.com, rostedt@goodmis.org, segall@google.com,
mgorman@suse.de, bristot@redhat.com, CCj.Yeh@mediatek.com
Subject: [PATCH 2/3] PM: EM: Make em_cpu_energy() able to return bigger values
Date: Fri, 25 Jun 2021 16:26:02 +0100 [thread overview]
Message-ID: <20210625152603.25960-3-lukasz.luba@arm.com> (raw)
In-Reply-To: <20210625152603.25960-1-lukasz.luba@arm.com>
The Energy Model (EM) em_cpu_energy() is responsible for providing good
estimation regarding CPUs energy. It contains proper data structures which
are then used during calculation. The values stored in there are in
milli-Watts precision (or in abstract scale) smaller that 0xffff, which use
sufficient unsigned long even on 32-bit machines. There are scenarios where
we would like to provide calculated estimations in a better precision and
the values might be 1000 times bigger. This patch makes possible to use
quite big values for also 32-bit machines.
Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
---
include/linux/energy_model.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/energy_model.h b/include/linux/energy_model.h
index 3f221dbf5f95..2016f5a706e0 100644
--- a/include/linux/energy_model.h
+++ b/include/linux/energy_model.h
@@ -101,7 +101,7 @@ void em_dev_unregister_perf_domain(struct device *dev);
* Return: the sum of the energy consumed by the CPUs of the domain assuming
* a capacity state satisfying the max utilization of the domain.
*/
-static inline unsigned long em_cpu_energy(struct em_perf_domain *pd,
+static inline u64 em_cpu_energy(struct em_perf_domain *pd,
unsigned long max_util, unsigned long sum_util,
unsigned long allowed_cpu_cap)
{
@@ -180,7 +180,7 @@ static inline unsigned long em_cpu_energy(struct em_perf_domain *pd,
* pd_nrg = ------------------------ (4)
* scale_cpu
*/
- return ps->cost * sum_util / scale_cpu;
+ return div_u64((u64)ps->cost * sum_util, scale_cpu);
}
/**
@@ -217,7 +217,7 @@ static inline struct em_perf_domain *em_pd_get(struct device *dev)
{
return NULL;
}
-static inline unsigned long em_cpu_energy(struct em_perf_domain *pd,
+static inline u64 em_cpu_energy(struct em_perf_domain *pd,
unsigned long max_util, unsigned long sum_util,
unsigned long allowed_cpu_cap)
{
--
2.17.1
next prev parent reply other threads:[~2021-06-25 15:26 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 15:26 [PATCH 0/3] Improve EAS energy estimation and increase precision Lukasz Luba
2021-06-25 15:26 ` [PATCH 1/3] sched/fair: Prepare variables for increased precision of EAS estimated energy Lukasz Luba
2021-06-30 17:01 ` Rafael J. Wysocki
2021-06-30 17:28 ` Lukasz Luba
2021-07-02 19:07 ` Lukasz Luba
2021-07-07 7:07 ` Vincent Guittot
2021-07-07 7:49 ` Lukasz Luba
2021-07-07 8:00 ` Vincent Guittot
2021-07-07 8:23 ` Lukasz Luba
2021-07-07 9:37 ` Vincent Guittot
2021-07-07 9:48 ` Lukasz Luba
2021-07-07 9:56 ` Vincent Guittot
2021-07-07 10:06 ` Lukasz Luba
2021-07-07 10:11 ` Vincent Guittot
2021-07-07 10:29 ` Lukasz Luba
2021-07-07 10:32 ` Vincent Guittot
2021-07-07 10:41 ` Lukasz Luba
2021-07-07 10:50 ` Vincent Guittot
2021-07-07 11:02 ` Lukasz Luba
2021-07-07 13:53 ` Vincent Guittot
2021-07-07 14:25 ` Lukasz Luba
2021-07-07 9:45 ` Dietmar Eggemann
2021-07-07 9:54 ` Lukasz Luba
2021-06-25 15:26 ` Lukasz Luba [this message]
2021-07-05 12:44 ` [PATCH 2/3] PM: EM: Make em_cpu_energy() able to return bigger values Dietmar Eggemann
2021-07-06 19:44 ` Lukasz Luba
2021-07-07 7:07 ` Peter Zijlstra
2021-07-07 8:09 ` Lukasz Luba
2021-07-07 10:01 ` Peter Zijlstra
2021-07-07 10:23 ` Lukasz Luba
2021-06-25 15:26 ` [PATCH 3/3] PM: EM: Increase energy calculation precision Lukasz Luba
2021-07-05 12:45 ` Dietmar Eggemann
2021-07-06 19:51 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210625152603.25960-3-lukasz.luba@arm.com \
--to=lukasz.luba@arm.com \
--cc=CCj.Yeh@mediatek.com \
--cc=Chris.Redpath@arm.com \
--cc=bristot@redhat.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=rjw@rjwysocki.net \
--cc=rostedt@goodmis.org \
--cc=segall@google.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).