From: Lukasz Luba <lukasz.luba@arm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, Chris.Redpath@arm.com,
dietmar.eggemann@arm.com, morten.rasmussen@arm.com,
qperret@google.com, linux-pm@vger.kernel.org, rjw@rjwysocki.net,
viresh.kumar@linaro.org, vincent.guittot@linaro.org,
mingo@redhat.com, juri.lelli@redhat.com, rostedt@goodmis.org,
segall@google.com, mgorman@suse.de, bristot@redhat.com,
CCj.Yeh@mediatek.com
Subject: Re: [PATCH 2/3] PM: EM: Make em_cpu_energy() able to return bigger values
Date: Wed, 7 Jul 2021 11:23:51 +0100 [thread overview]
Message-ID: <c7603e2f-5830-0731-cc2c-e42d5f6283be@arm.com> (raw)
In-Reply-To: <YOV7gt67DyYXtBkF@hirez.programming.kicks-ass.net>
On 7/7/21 11:01 AM, Peter Zijlstra wrote:
> On Wed, Jul 07, 2021 at 09:09:08AM +0100, Lukasz Luba wrote:
>> For now we would live with this simple code which improves
>> all recent 64bit platforms and is easy to take it into Android
>> common kernel. The next step would be more scattered across
>> other subsystems, so harder to backport to Android 5.4 and others.
>
> Ah, you *do* only care about 64bit :-) So one option is to only increase
> precision for 64BIT builds, just like we do for scale_load() and
> friends.
>
Your suggestion is potentially a good compromise :-)
We could leave the 32bit alone and they would have old code and
precision.
Thank you for the comments. Let me discuss this internally with my team.
next prev parent reply other threads:[~2021-07-07 10:23 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 15:26 [PATCH 0/3] Improve EAS energy estimation and increase precision Lukasz Luba
2021-06-25 15:26 ` [PATCH 1/3] sched/fair: Prepare variables for increased precision of EAS estimated energy Lukasz Luba
2021-06-30 17:01 ` Rafael J. Wysocki
2021-06-30 17:28 ` Lukasz Luba
2021-07-02 19:07 ` Lukasz Luba
2021-07-07 7:07 ` Vincent Guittot
2021-07-07 7:49 ` Lukasz Luba
2021-07-07 8:00 ` Vincent Guittot
2021-07-07 8:23 ` Lukasz Luba
2021-07-07 9:37 ` Vincent Guittot
2021-07-07 9:48 ` Lukasz Luba
2021-07-07 9:56 ` Vincent Guittot
2021-07-07 10:06 ` Lukasz Luba
2021-07-07 10:11 ` Vincent Guittot
2021-07-07 10:29 ` Lukasz Luba
2021-07-07 10:32 ` Vincent Guittot
2021-07-07 10:41 ` Lukasz Luba
2021-07-07 10:50 ` Vincent Guittot
2021-07-07 11:02 ` Lukasz Luba
2021-07-07 13:53 ` Vincent Guittot
2021-07-07 14:25 ` Lukasz Luba
2021-07-07 9:45 ` Dietmar Eggemann
2021-07-07 9:54 ` Lukasz Luba
2021-06-25 15:26 ` [PATCH 2/3] PM: EM: Make em_cpu_energy() able to return bigger values Lukasz Luba
2021-07-05 12:44 ` Dietmar Eggemann
2021-07-06 19:44 ` Lukasz Luba
2021-07-07 7:07 ` Peter Zijlstra
2021-07-07 8:09 ` Lukasz Luba
2021-07-07 10:01 ` Peter Zijlstra
2021-07-07 10:23 ` Lukasz Luba [this message]
2021-06-25 15:26 ` [PATCH 3/3] PM: EM: Increase energy calculation precision Lukasz Luba
2021-07-05 12:45 ` Dietmar Eggemann
2021-07-06 19:51 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7603e2f-5830-0731-cc2c-e42d5f6283be@arm.com \
--to=lukasz.luba@arm.com \
--cc=CCj.Yeh@mediatek.com \
--cc=Chris.Redpath@arm.com \
--cc=bristot@redhat.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=rjw@rjwysocki.net \
--cc=rostedt@goodmis.org \
--cc=segall@google.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).