linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lukasz Luba <lukasz.luba@arm.com>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Chris Redpath <Chris.Redpath@arm.com>,
	Morten Rasmussen <morten.rasmussen@arm.com>,
	Quentin Perret <qperret@google.com>,
	"open list:THERMAL" <linux-pm@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Ingo Molnar <mingo@redhat.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	segall@google.com, Mel Gorman <mgorman@suse.de>,
	Daniel Bristot de Oliveira <bristot@redhat.com>,
	CCj.Yeh@mediatek.com
Subject: Re: [PATCH 1/3] sched/fair: Prepare variables for increased precision of EAS estimated energy
Date: Wed, 7 Jul 2021 10:54:16 +0100	[thread overview]
Message-ID: <730a57b2-e36f-6b69-5e9d-c27e8a3003bb@arm.com> (raw)
In-Reply-To: <9b0ea7bc-934a-43bd-7dd8-9fe33dec97bc@arm.com>



On 7/7/21 10:45 AM, Dietmar Eggemann wrote:
> On 07/07/2021 10:23, Lukasz Luba wrote:
>>   
>> On 7/7/21 9:00 AM, Vincent Guittot wrote:
>>> On Wed, 7 Jul 2021 at 09:49, Lukasz Luba <lukasz.luba@arm.com> wrote:
>>>>
>>>>
>>>>
>>>> On 7/7/21 8:07 AM, Vincent Guittot wrote:
>>>>> On Fri, 25 Jun 2021 at 17:26, Lukasz Luba <lukasz.luba@arm.com> wrote:
> 
> [...]
> 
>>>>> Could you explain why 32bits results are not enough and you need to
>>>>> move to 64bits ?
>>>>>
>>>>> Right now the result is in the range [0..2^32[ mW. If you need more
>>>>> precision and you want to return uW instead, you will have a result in
>>>>> the range  [0..4kW[ which seems to be still enough
>>>>>
>>>>
>>>> Currently we have the max value limit for 'power' in EM which is
>>>> EM_MAX_POWER 0xffff (64k - 1). We allow to register such big power
>>>> values ~64k mW (~64Watts) for an OPP. Then based on 'power' we
>>>> pre-calculate 'cost' fields:
>>>> cost[i] = power[i] * freq_max / freq[i]
>>>> So, for max freq the cost == power. Let's use that in the example.
>>>>
>>>> Then the em_cpu_energy() calculates as follow:
>>>> cost * sum_util / scale_cpu
>>>> We are interested in the first part - the value of multiplication.
>>>
>>> But all these are internal computations of the energy model. At the
>>> end, the computed energy that is returned by compute_energy() and
>>> em_cpu_energy(), fits in a long
>>
>> Let's take a look at existing *10000 precision for x CPUs:
>> cost * sum_util / scale_cpu =
>> (64k *10000) * (x * 800) / 1024
>> which is:
>> x * ~500mln
>>
>> So to be close to overflowing u32 the 'x' has to be > (?=) 8
>> (depends on sum_util).
> 
> I assume the worst case is `x * 1024` (max return value of
> effective_cpu_util = effective_cpu_util()) so x ~ 6.7.
> 
> I'm not aware of any arm32 b.L. systems with > 4 CPUs in a PD.
> 

True, arm32 didn't support bigger number than 4 CPUs in the cluster.
We would be safe for them, but I don't want to break with this
assumption any other 32bit platform from competitors, which might
create such 32bit 16cores clusters.

If Peter, Vincent and you are OK to put this assumption about
max safe CPUs number, then we can get rid of patch 1/3.

But the temporary division of u64 must stay, because there is
arm32 platform which need it. So returning also u64 is not a big
harm and looks more consistent.

  reply	other threads:[~2021-07-07  9:54 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25 15:26 [PATCH 0/3] Improve EAS energy estimation and increase precision Lukasz Luba
2021-06-25 15:26 ` [PATCH 1/3] sched/fair: Prepare variables for increased precision of EAS estimated energy Lukasz Luba
2021-06-30 17:01   ` Rafael J. Wysocki
2021-06-30 17:28     ` Lukasz Luba
2021-07-02 19:07       ` Lukasz Luba
2021-07-07  7:07   ` Vincent Guittot
2021-07-07  7:49     ` Lukasz Luba
2021-07-07  8:00       ` Vincent Guittot
2021-07-07  8:23         ` Lukasz Luba
2021-07-07  9:37           ` Vincent Guittot
2021-07-07  9:48             ` Lukasz Luba
2021-07-07  9:56               ` Vincent Guittot
2021-07-07 10:06                 ` Lukasz Luba
2021-07-07 10:11                   ` Vincent Guittot
2021-07-07 10:29                     ` Lukasz Luba
2021-07-07 10:32                       ` Vincent Guittot
2021-07-07 10:41                         ` Lukasz Luba
2021-07-07 10:50                           ` Vincent Guittot
2021-07-07 11:02                             ` Lukasz Luba
2021-07-07 13:53                               ` Vincent Guittot
2021-07-07 14:25                                 ` Lukasz Luba
2021-07-07  9:45           ` Dietmar Eggemann
2021-07-07  9:54             ` Lukasz Luba [this message]
2021-06-25 15:26 ` [PATCH 2/3] PM: EM: Make em_cpu_energy() able to return bigger values Lukasz Luba
2021-07-05 12:44   ` Dietmar Eggemann
2021-07-06 19:44     ` Lukasz Luba
2021-07-07  7:07   ` Peter Zijlstra
2021-07-07  8:09     ` Lukasz Luba
2021-07-07 10:01       ` Peter Zijlstra
2021-07-07 10:23         ` Lukasz Luba
2021-06-25 15:26 ` [PATCH 3/3] PM: EM: Increase energy calculation precision Lukasz Luba
2021-07-05 12:45   ` Dietmar Eggemann
2021-07-06 19:51     ` Lukasz Luba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=730a57b2-e36f-6b69-5e9d-c27e8a3003bb@arm.com \
    --to=lukasz.luba@arm.com \
    --cc=CCj.Yeh@mediatek.com \
    --cc=Chris.Redpath@arm.com \
    --cc=bristot@redhat.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=morten.rasmussen@arm.com \
    --cc=peterz@infradead.org \
    --cc=qperret@google.com \
    --cc=rjw@rjwysocki.net \
    --cc=rostedt@goodmis.org \
    --cc=segall@google.com \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    --subject='Re: [PATCH 1/3] sched/fair: Prepare variables for increased precision of EAS estimated energy' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).