[PATCH 0/2] spi: meson: Add Amlogic GXBB compatible

[PATCH 0/2] spi: meson: Add Amlogic GXBB compatible

[Neil Armstrong]

This patchset adds a specific compatible string in the Meson SPIFC driver for
the Amlogic Meson GXBB SoC.

This patchset is SPI-only respin from Jerome Brunet patchset at [1].

[1] http://lkml.kernel.org/r/1473261223-15412-1-git-send-email-jbrunet@baylibre.com

Neil Armstrong (2):
  dt-bindings: spi-meson: Add GXBB Compatible string
  spi: meson: Add GXBB compatible

 Documentation/devicetree/bindings/spi/spi-meson.txt | 2 +-
 drivers/spi/spi-meson-spifc.c                       | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

-- 
1.9.1

[PATCH 1/2] dt-bindings: spi-meson: Add GXBB Compatible string

[Neil Armstrong]

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 Documentation/devicetree/bindings/spi/spi-meson.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/spi/spi-meson.txt b/Documentation/devicetree/bindings/spi/spi-meson.txt
index bb52a86..dc6d031 100644
--- a/Documentation/devicetree/bindings/spi/spi-meson.txt
+++ b/Documentation/devicetree/bindings/spi/spi-meson.txt
@@ -7,7 +7,7 @@ NOR memories, without DMA support and a 64-byte unified transmit /
 receive buffer.
 
 Required properties:
- - compatible: should be "amlogic,meson6-spifc"
+ - compatible: should be "amlogic,meson6-spifc" or "amlogic,meson-gxbb-spifc"
  - reg: physical base address and length of the controller registers
  - clocks: phandle of the input clock for the baud rate generator
  - #address-cells: should be 1
-- 
1.9.1

Re: [PATCH 1/2] dt-bindings: spi-meson: Add GXBB Compatible string

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

On Thu, Sep 08, 2016 at 09:53:25AM +0200, Neil Armstrong wrote:
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

Please use subject lines matching the style for the subsystem.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH 1/2] dt-bindings: spi-meson: Add GXBB Compatible string

[Rob Herring]

On Thu, Sep 08, 2016 at 09:53:25AM +0200, Neil Armstrong wrote:
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  Documentation/devicetree/bindings/spi/spi-meson.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi-meson.txt b/Documentation/devicetree/bindings/spi/spi-meson.txt
> index bb52a86..dc6d031 100644
> --- a/Documentation/devicetree/bindings/spi/spi-meson.txt
> +++ b/Documentation/devicetree/bindings/spi/spi-meson.txt
> @@ -7,7 +7,7 @@ NOR memories, without DMA support and a 64-byte unified transmit /
>  receive buffer.
>  
>  Required properties:
> - - compatible: should be "amlogic,meson6-spifc"
> + - compatible: should be "amlogic,meson6-spifc" or "amlogic,meson-gxbb-spifc"

If you are going to use both, make sure the order is clear (most 
specific, best match first). Sometimes the chip names make that clear, 
but not here.

>   - reg: physical base address and length of the controller registers
>   - clocks: phandle of the input clock for the baud rate generator
>   - #address-cells: should be 1
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] spi: meson: Add GXBB compatible

[Neil Armstrong]

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 drivers/spi/spi-meson-spifc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-meson-spifc.c b/drivers/spi/spi-meson-spifc.c
index 2465259..616566e 100644
--- a/drivers/spi/spi-meson-spifc.c
+++ b/drivers/spi/spi-meson-spifc.c
@@ -442,6 +442,7 @@ static const struct dev_pm_ops meson_spifc_pm_ops = {
 
 static const struct of_device_id meson_spifc_dt_match[] = {
 	{ .compatible = "amlogic,meson6-spifc", },
+	{ .compatible = "amlogic,meson-gxbb-spifc", },
 	{ },
 };
 MODULE_DEVICE_TABLE(of, meson_spifc_dt_match);
-- 
1.9.1

Re: [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible

[Andreas Färber]

Am 08.09.2016 um 09:53 schrieb Neil Armstrong:
> This patchset adds a specific compatible string in the Meson SPIFC driver for
> the Amlogic Meson GXBB SoC.

Any particular reason? We could just reuse the meson6 one since there
appear to be no code changes so far.

Regards,
Andreas

> This patchset is SPI-only respin from Jerome Brunet patchset at [1].
> 
> [1] http://lkml.kernel.org/r/1473261223-15412-1-git-send-email-jbrunet@baylibre.com
> 
> Neil Armstrong (2):
>   dt-bindings: spi-meson: Add GXBB Compatible string
>   spi: meson: Add GXBB compatible
> 
>  Documentation/devicetree/bindings/spi/spi-meson.txt | 2 +-
>  drivers/spi/spi-meson-spifc.c                       | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

Re: [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible

[Andreas Färber]

Am 08.09.2016 um 14:04 schrieb Andreas Färber:
> Am 08.09.2016 um 09:53 schrieb Neil Armstrong:
>> This patchset adds a specific compatible string in the Meson SPIFC driver for
>> the Amlogic Meson GXBB SoC.
> 
> Any particular reason? We could just reuse the meson6 one since there
> appear to be no code changes so far.

So Neil is essentially telling me they don't know whether there are any
differences in the IP block, so a separate compatible string was chosen.

No objection from my side, but a general clarification from device tree
maintainers when and when not to would be appreciated. (+ devicetree)

Cheers,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

Re: [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible

[Ben Dooks]

On 08/09/16 13:50, Andreas Färber wrote:
> Am 08.09.2016 um 14:04 schrieb Andreas Färber:
>> Am 08.09.2016 um 09:53 schrieb Neil Armstrong:
>>> This patchset adds a specific compatible string in the Meson SPIFC driver for
>>> the Amlogic Meson GXBB SoC.
>>
>> Any particular reason? We could just reuse the meson6 one since there
>> appear to be no code changes so far.
>
> So Neil is essentially telling me they don't know whether there are any
> differences in the IP block, so a separate compatible string was chosen.
>
> No objection from my side, but a general clarification from device tree
> maintainers when and when not to would be appreciated. (+ devicetree)

I prefer to add both the device-tree itself, so if there are differences
found later then it can be dealt with without rebuilding both the DT
and kernel.

It is nice to have the new ones added to the driver so that you know the
hardware choices in play.

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

Re: [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible

[Kevin Hilman]

Andreas Färber <afaerber@suse.de> writes:

> Am 08.09.2016 um 14:04 schrieb Andreas Färber:
>> Am 08.09.2016 um 09:53 schrieb Neil Armstrong:
>>> This patchset adds a specific compatible string in the Meson SPIFC driver for
>>> the Amlogic Meson GXBB SoC.
>> 
>> Any particular reason? We could just reuse the meson6 one since there
>> appear to be no code changes so far.
>
> So Neil is essentially telling me they don't know whether there are any
> differences in the IP block, so a separate compatible string was chosen.
>
> No objection from my side, but a general clarification from device tree
> maintainers when and when not to would be appreciated. (+ devicetree)

I'm not sure what the "right" way is (Rob?) but I think the usual way is
to add new compatibles when needed.

Kevin

Re: [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible

[Rob Herring]

On Thu, Sep 08, 2016 at 02:50:37PM +0200, Andreas Färber wrote:
> Am 08.09.2016 um 14:04 schrieb Andreas Färber:
> > Am 08.09.2016 um 09:53 schrieb Neil Armstrong:
> >> This patchset adds a specific compatible string in the Meson SPIFC driver for
> >> the Amlogic Meson GXBB SoC.
> > 
> > Any particular reason? We could just reuse the meson6 one since there
> > appear to be no code changes so far.
> 
> So Neil is essentially telling me they don't know whether there are any
> differences in the IP block, so a separate compatible string was chosen.
> 
> No objection from my side, but a general clarification from device tree
> maintainers when and when not to would be appreciated. (+ devicetree)

New chip, always define a new compatible. If you think they are the same 
or are close enough to function with the existing driver, then put both 
compatible strings in the DT.

Rob

Re: [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible

[Kevin Hilman]

Neil Armstrong <narmstrong@baylibre.com> writes:

> This patchset adds a specific compatible string in the Meson SPIFC driver for
> the Amlogic Meson GXBB SoC.
>
> This patchset is SPI-only respin from Jerome Brunet patchset at [1].
>
> [1] http://lkml.kernel.org/r/1473261223-15412-1-git-send-email-jbrunet@baylibre.com
>
> Neil Armstrong (2):
>   dt-bindings: spi-meson: Add GXBB Compatible string
>   spi: meson: Add GXBB compatible

Acked-by: Kevin Hilman <khilman@baylibre.com>

Mark, with your ack, I could take these through the amlogic tree also.
Let me know.

Kevin