From: Randy Dunlap <rdunlap@infradead.org>
To: Andra Paraschiv <andraprs@amazon.com>, linux-kernel@vger.kernel.org
Cc: Anthony Liguori <aliguori@amazon.com>,
Benjamin Herrenschmidt <benh@amazon.com>,
Colm MacCarthaigh <colmmacc@amazon.com>,
Bjoern Doebel <doebel@amazon.de>,
David Woodhouse <dwmw@amazon.co.uk>,
Frank van der Linden <fllinden@amazon.com>,
Alexander Graf <graf@amazon.de>,
Martin Pohlack <mpohlack@amazon.de>, Matt Wilson <msw@amazon.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Balbir Singh <sblbir@amazon.com>,
Stewart Smith <trawets@amazon.com>,
Uwe Dannowski <uwed@amazon.de>,
kvm@vger.kernel.org, ne-devel-upstream@amazon.com
Subject: Re: [PATCH v1 01/15] nitro_enclaves: Add ioctl interface definition
Date: Tue, 21 Apr 2020 11:47:56 -0700 [thread overview]
Message-ID: <7e0cb729-60ca-3b2e-909b-8883b24908a8@infradead.org> (raw)
In-Reply-To: <20200421184150.68011-2-andraprs@amazon.com>
Hi--
On 4/21/20 11:41 AM, Andra Paraschiv wrote:
> The Nitro Enclaves driver handles the enclave lifetime management. This
> includes enclave creation, termination and setting up its resources such
> as memory and CPU.
>
> An enclave runs alongside the VM that spawned it. It is abstracted as a
> process running in the VM that launched it. The process interacts with
> the NE driver, that exposes an ioctl interface for creating an enclave
> and setting up its resources.
>
> Include the KVM API as part of the provided ioctl interface, with an
> additional ENCLAVE_START ioctl command that triggers the enclave run.
>
> Signed-off-by: Alexandru Vasile <lexnv@amazon.com>
> Signed-off-by: Andra Paraschiv <andraprs@amazon.com>
> ---
> include/linux/nitro_enclaves.h | 23 +++++++++++++
> include/uapi/linux/nitro_enclaves.h | 52 +++++++++++++++++++++++++++++
> 2 files changed, 75 insertions(+)
> create mode 100644 include/linux/nitro_enclaves.h
> create mode 100644 include/uapi/linux/nitro_enclaves.h
>
> diff --git a/include/uapi/linux/nitro_enclaves.h b/include/uapi/linux/nitro_enclaves.h
> new file mode 100644
> index 000000000000..b90dfcf6253a
> --- /dev/null
> +++ b/include/uapi/linux/nitro_enclaves.h
> @@ -0,0 +1,52 @@
> +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
> +/*
> + * Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights Reserved.
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms and conditions of the GNU General Public License,
> + * version 2, as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#ifndef _UAPI_LINUX_NITRO_ENCLAVES_H_
> +#define _UAPI_LINUX_NITRO_ENCLAVES_H_
> +
> +#include <linux/kvm.h>
> +#include <linux/types.h>
> +
> +/* Nitro Enclaves (NE) Kernel Driver Interface */
> +
> +/**
> + * The command is used to trigger enclave start after the enclave resources,
> + * such as memory and CPU, have been set.
> + *
> + * The enclave start metadata is an in / out data structure. It includes
> + * provided info by the caller - enclave cid and flags - and returns the
> + * slot uid and the cid (if input cid is 0).
> + */
> +#define NE_ENCLAVE_START _IOWR('B', 0x1, struct enclave_start_metadata)
Please document ioctl major ('B' in this case) and range used in
Documentation/userspace-api/ioctl/ioctl-number.rst.
> +
> +/* Setup metadata necessary for enclave start. */
> +struct enclave_start_metadata {
> + /* Flags for the enclave to start with (e.g. debug mode) (in). */
> + __u64 flags;
> +
> + /**
> + * Context ID (CID) for the enclave vsock device. If 0 as input, the
> + * CID is autogenerated by the hypervisor and returned back as output
> + * by the driver (in/out).
> + */
> + __u64 enclave_cid;
> +
> + /* Slot unique id mapped to the enclave to start (out). */
> + __u64 slot_uid;
> +};
> +
> +#endif /* _UAPI_LINUX_NITRO_ENCLAVES_H_ */
>
thanks.
--
~Randy
next prev parent reply other threads:[~2020-04-21 18:48 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 18:41 [PATCH v1 00/15] Add support for Nitro Enclaves Andra Paraschiv
2020-04-21 18:41 ` [PATCH v1 01/15] nitro_enclaves: Add ioctl interface definition Andra Paraschiv
2020-04-21 18:47 ` Randy Dunlap [this message]
2020-04-21 21:45 ` Paolo Bonzini
2020-04-22 15:49 ` Paraschiv, Andra-Irina
2020-04-21 18:41 ` [PATCH v1 02/15] nitro_enclaves: Define the PCI device interface Andra Paraschiv
2020-04-21 21:22 ` Paolo Bonzini
2020-04-23 13:37 ` Paraschiv, Andra-Irina
2020-04-24 15:10 ` Paraschiv, Andra-Irina
2020-04-21 18:41 ` [PATCH v1 03/15] nitro_enclaves: Define enclave info for internal bookkeeping Andra Paraschiv
2020-04-21 18:41 ` [PATCH v1 04/15] nitro_enclaves: Init PCI device driver Andra Paraschiv
2020-04-25 14:25 ` Liran Alon
2020-04-29 16:31 ` Paraschiv, Andra-Irina
2020-04-21 18:41 ` [PATCH v1 05/15] nitro_enclaves: Handle PCI device command requests Andra Paraschiv
2020-04-25 14:52 ` Liran Alon
2020-04-29 17:00 ` Paraschiv, Andra-Irina
2020-04-21 18:41 ` [PATCH v1 06/15] nitro_enclaves: Handle out-of-band PCI device events Andra Paraschiv
2020-04-21 18:41 ` [PATCH v1 07/15] nitro_enclaves: Init misc device providing the ioctl interface Andra Paraschiv
2020-04-21 18:41 ` [PATCH v1 08/15] nitro_enclaves: Add logic for enclave vm creation Andra Paraschiv
2020-04-21 18:41 ` [PATCH v1 09/15] nitro_enclaves: Add logic for enclave vcpu creation Andra Paraschiv
2020-04-21 18:41 ` [PATCH v1 10/15] nitro_enclaves: Add logic for enclave memory region set Andra Paraschiv
2020-04-21 18:41 ` [PATCH v1 11/15] nitro_enclaves: Add logic for enclave start Andra Paraschiv
2020-04-21 18:41 ` [PATCH v1 12/15] nitro_enclaves: Add logic for enclave termination Andra Paraschiv
2020-04-21 18:41 ` [PATCH v1 13/15] nitro_enclaves: Add Kconfig for the Nitro Enclaves driver Andra Paraschiv
2020-04-21 18:50 ` Randy Dunlap
2020-04-22 14:35 ` Paraschiv, Andra-Irina
2020-04-21 18:41 ` [PATCH v1 14/15] nitro_enclaves: Add Makefile " Andra Paraschiv
2020-04-23 8:12 ` kbuild test robot
2020-04-24 17:00 ` Paraschiv, Andra-Irina
2020-04-23 8:43 ` kbuild test robot
2020-04-24 15:27 ` Paraschiv, Andra-Irina
2020-04-21 18:41 ` [PATCH v1 15/15] MAINTAINERS: Add entry " Andra Paraschiv
2020-04-21 21:46 ` [PATCH v1 00/15] Add support for Nitro Enclaves Paolo Bonzini
2020-04-23 13:19 ` Paraschiv, Andra-Irina
2020-04-23 13:42 ` Paolo Bonzini
2020-04-23 17:42 ` Paraschiv, Andra-Irina
2020-04-23 17:51 ` Paolo Bonzini
2020-04-23 20:56 ` Alexander Graf
2020-04-23 21:18 ` Paolo Bonzini
2020-04-24 12:56 ` Alexander Graf
2020-04-24 16:27 ` Paolo Bonzini
2020-04-24 19:11 ` Alexander Graf
2020-04-25 16:05 ` Paolo Bonzini
2020-04-27 9:15 ` Paraschiv, Andra-Irina
2020-04-27 9:22 ` Paraschiv, Andra-Irina
2020-04-27 9:46 ` Paolo Bonzini
2020-04-27 10:00 ` Paraschiv, Andra-Irina
2020-04-28 15:07 ` Alexander Graf
2020-04-29 13:20 ` Paolo Bonzini
2020-04-30 13:59 ` Paraschiv, Andra-Irina
2020-04-30 10:34 ` Paolo Bonzini
2020-04-30 11:21 ` Alexander Graf
2020-04-30 11:38 ` Paolo Bonzini
2020-04-30 11:47 ` Alexander Graf
2020-04-30 11:58 ` Paolo Bonzini
2020-04-30 12:19 ` Alexander Graf
2020-05-07 17:44 ` Pavel Machek
2020-05-08 7:00 ` Paraschiv, Andra-Irina
2020-05-09 19:21 ` Pavel Machek
2020-05-10 11:02 ` Herrenschmidt, Benjamin
2020-05-11 10:49 ` Paraschiv, Andra-Irina
2020-05-11 13:49 ` Stefan Hajnoczi
2020-04-24 3:04 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2020-04-24 8:19 ` Paraschiv, Andra-Irina
2020-04-24 9:54 ` Paraschiv, Andra-Irina
2020-04-26 1:55 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2020-04-27 18:39 ` Paraschiv, Andra-Irina
2020-04-24 9:59 ` Tian, Kevin
2020-04-24 13:59 ` Paraschiv, Andra-Irina
2020-04-26 8:16 ` Tian, Kevin
2020-04-27 19:05 ` Paraschiv, Andra-Irina
[not found] ` <CAKXe6SLonLQLAOY9Q_2AzTeg4uJxiknsAWnJpTF0hMcXEG5Tew@mail.gmail.com>
2020-05-11 12:05 ` Paraschiv, Andra-Irina
2020-04-25 15:25 ` Liran Alon
2020-04-27 7:56 ` Paraschiv, Andra-Irina
2020-04-27 11:44 ` Liran Alon
2020-04-28 15:25 ` Alexander Graf
2020-04-28 16:01 ` Liran Alon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e0cb729-60ca-3b2e-909b-8883b24908a8@infradead.org \
--to=rdunlap@infradead.org \
--cc=aliguori@amazon.com \
--cc=andraprs@amazon.com \
--cc=benh@amazon.com \
--cc=colmmacc@amazon.com \
--cc=doebel@amazon.de \
--cc=dwmw@amazon.co.uk \
--cc=fllinden@amazon.com \
--cc=graf@amazon.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpohlack@amazon.de \
--cc=msw@amazon.com \
--cc=ne-devel-upstream@amazon.com \
--cc=pbonzini@redhat.com \
--cc=sblbir@amazon.com \
--cc=trawets@amazon.com \
--cc=uwed@amazon.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).