From: Richard Henderson <richard.henderson@linaro.org>
To: remi.denis.courmont@huawei.com, qemu-arm@nongnu.org
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 1/3] target/arm: keep translation start level unsigned
Date: Wed, 30 Dec 2020 14:38:14 -0800 [thread overview]
Message-ID: <002743e6-10d3-88b3-961a-8571efb4d1ed@linaro.org> (raw)
In-Reply-To: <c2af03a8-9f56-fb43-485c-91ec0fbdef31@linaro.org>
On 12/30/20 2:10 PM, Richard Henderson wrote:
> On 12/18/20 6:33 AM, remi.denis.courmont@huawei.com wrote:
>> From: Rémi Denis-Courmont <remi.denis.courmont@huawei.com>
>>
>> Signed-off-by: Rémi Denis-Courmont <remi.denis.courmont@huawei.com>
>> ---
>> target/arm/helper.c | 14 ++++++--------
>> 1 file changed, 6 insertions(+), 8 deletions(-)
>
> The patch does more than what is described above.
>
>>
>> diff --git a/target/arm/helper.c b/target/arm/helper.c
>> index df195c314c..b927e53ab0 100644
>> --- a/target/arm/helper.c
>> +++ b/target/arm/helper.c
>> @@ -10821,17 +10821,12 @@ do_fault:
>> * Returns true if the suggested S2 translation parameters are OK and
>> * false otherwise.
>> */
>> -static bool check_s2_mmu_setup(ARMCPU *cpu, bool is_aa64, int level,
>> +static bool check_s2_mmu_setup(ARMCPU *cpu, bool is_aa64, uint32_t level,
>> int inputsize, int stride)
>> {
>> const int grainsize = stride + 3;
>> int startsizecheck;
>>
>> - /* Negative levels are never allowed. */
>> - if (level < 0) {
>> - return false;
>> - }
>> -
>
> I would expect this to be the only hunk from the patch description. Probably
> changing this negative check to a >= 3 check.
Having read the next patch, I think you should drop this type change.
>> @@ -11203,7 +11201,7 @@ static bool get_phys_addr_lpae(CPUARMState *env, uint64_t address,
>>
>> if (!aarch64 || stride == 9) {
>> /* AArch32 or 4KB pages */
>> - startlevel = 2 - sl0;
>> + startlevel = (2 - sl0) & 3;
This hunk belongs with the next patch, implementing TTST, and should be
conditional. I.e.
if (stride == 9) {
startlevel = 2 - sl0;
if (aarch64 &&
cpu_isar_feature(aa64_st, env_archcpu(env)) {
startlevel &= 3;
}
...
r~
next prev parent reply other threads:[~2020-12-30 22:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 14:32 [RFC][PATCH 0/3] ARMv8.4-TTST extension Rémi Denis-Courmont
2020-12-18 14:33 ` [PATCH 1/3] target/arm: keep translation start level unsigned remi.denis.courmont
2020-12-30 22:10 ` Richard Henderson
2020-12-30 22:38 ` Richard Henderson [this message]
2020-12-31 9:59 ` Rémi Denis-Courmont
2020-12-31 16:43 ` Richard Henderson
2021-01-07 19:55 ` Peter Maydell
2020-12-31 9:55 ` Rémi Denis-Courmont
2020-12-31 16:54 ` Richard Henderson
2020-12-18 14:33 ` [PATCH 2/3] target/arm: ARMv8.4-TTST extension remi.denis.courmont
2020-12-30 22:36 ` Richard Henderson
2020-12-18 14:33 ` [PATCH 3/3] target/arm: enable Small Translation tables in max CPU remi.denis.courmont
2020-12-30 22:37 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=002743e6-10d3-88b3-961a-8571efb4d1ed@linaro.org \
--to=richard.henderson@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=remi.denis.courmont@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).