From: Richard Henderson <richard.henderson@linaro.org>
To: "Rémi Denis-Courmont" <remi@remlab.net>, qemu-arm@nongnu.org
Cc: qemu-devel@nongnu.org, remi.denis.courmont@huawei.com
Subject: Re: [PATCH 1/3] target/arm: keep translation start level unsigned
Date: Thu, 31 Dec 2020 08:54:04 -0800 [thread overview]
Message-ID: <78facaff-d2b8-fcb0-bec9-537a84a3c3b5@linaro.org> (raw)
In-Reply-To: <3026104.eZJBrJkB2l@philogene>
On 12/31/20 1:55 AM, Rémi Denis-Courmont wrote:
> Le jeudi 31 décembre 2020, 00:10:09 EET Richard Henderson a écrit :
>> On 12/18/20 6:33 AM, remi.denis.courmont@huawei.com wrote:
>>> From: Rémi Denis-Courmont <remi.denis.courmont@huawei.com>
>>>
>>> Signed-off-by: Rémi Denis-Courmont <remi.denis.courmont@huawei.com>
>>> ---
>>>
>>> target/arm/helper.c | 14 ++++++--------
>>> 1 file changed, 6 insertions(+), 8 deletions(-)
>>
>> The patch does more than what is described above.
>
> No? It removes generating negative values, and handling them, for translation
> levels.
But the removal of generating negative values, i.e. the mask with 3, is clearly
tied to TTST and makes no sense by itself.
Maybe the whole thing is clearer all squashed together...
r~
next prev parent reply other threads:[~2020-12-31 16:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 14:32 [RFC][PATCH 0/3] ARMv8.4-TTST extension Rémi Denis-Courmont
2020-12-18 14:33 ` [PATCH 1/3] target/arm: keep translation start level unsigned remi.denis.courmont
2020-12-30 22:10 ` Richard Henderson
2020-12-30 22:38 ` Richard Henderson
2020-12-31 9:59 ` Rémi Denis-Courmont
2020-12-31 16:43 ` Richard Henderson
2021-01-07 19:55 ` Peter Maydell
2020-12-31 9:55 ` Rémi Denis-Courmont
2020-12-31 16:54 ` Richard Henderson [this message]
2020-12-18 14:33 ` [PATCH 2/3] target/arm: ARMv8.4-TTST extension remi.denis.courmont
2020-12-30 22:36 ` Richard Henderson
2020-12-18 14:33 ` [PATCH 3/3] target/arm: enable Small Translation tables in max CPU remi.denis.courmont
2020-12-30 22:37 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78facaff-d2b8-fcb0-bec9-537a84a3c3b5@linaro.org \
--to=richard.henderson@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=remi.denis.courmont@huawei.com \
--cc=remi@remlab.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).