Re: [PATCH v2 15/23] sunxi: Remove non-DM I2C clock/pin setup from U-Boot

From: Andre Przywara <andre.przywara@arm.com>
To: Samuel Holland <samuel@sholland.org>
Cc: u-boot@lists.denx.de, Jagan Teki <jagan@amarulasolutions.com>,
	Sean Anderson <seanga2@gmail.com>, Simon Glass <sjg@chromium.org>,
	Heinrich Schuchardt <heinrich.schuchardt@canonical.com>,
	Heiko Schocher <hs@denx.de>,
	Joe Hershberger <joe.hershberger@ni.com>
Subject: Re: [PATCH v2 15/23] sunxi: Remove non-DM I2C clock/pin setup from U-Boot
Date: Fri, 1 Apr 2022 00:20:32 +0100	[thread overview]
Message-ID: <20220401002032.3224fcac@slackpad.lan> (raw)
In-Reply-To: <20220318035420.15058-16-samuel@sholland.org>

On Thu, 17 Mar 2022 22:54:12 -0500
Samuel Holland <samuel@sholland.org> wrote:

> This is now handled automatically by the clock and pinctrl drivers.
> 
> SPL still calls this function because it needes the non-DM code.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>

Looks good, but needs some testing to see if really cover all the
clocks already.

Anyway:
Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

> ---
> 
> (no changes since v1)
> 
>  board/sunxi/board.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/board/sunxi/board.c b/board/sunxi/board.c
> index 05249d47eb..77ceefdb46 100644
> --- a/board/sunxi/board.c
> +++ b/board/sunxi/board.c
> @@ -241,14 +241,6 @@ int board_init(void)
>  		}
>  	}
>  
> -#if CONFIG_IS_ENABLED(DM_I2C)
> -	/*
> -	 * Temporary workaround for enabling I2C clocks until proper sunxi DM
> -	 * clk, reset and pinctrl drivers land.
> -	 */
> -	i2c_init_board();
> -#endif
> -
>  #ifdef CONFIG_DM_MMC
>  	/*
>  	 * Temporary workaround for enabling MMC clocks until a sunxi DM