From: Corneliu ZUZU <czuzu@bitdefender.com> To: Tamas K Lengyel <tamas@tklengyel.com> Cc: Kevin Tian <kevin.tian@intel.com>, Jan Beulich <jbeulich@suse.com>, Razvan Cojocaru <rcojocaru@bitdefender.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Xen-devel <xen-devel@lists.xen.org>, Jun Nakajima <jun.nakajima@intel.com> Subject: Re: [PATCH 4/7] vm-event/x86: use vm_event_vcpu_enter properly Date: Fri, 17 Jun 2016 12:24:38 +0300 [thread overview] Message-ID: <4e5a3117-3321-e2ea-89fe-d42632c68aa1@bitdefender.com> (raw) In-Reply-To: <CABfawhn7b5+g4WyeD+Dr=UnP0mj2fTiRoCYzAO03bxf3imho+A@mail.gmail.com> On 6/16/2016 7:27 PM, Tamas K Lengyel wrote: >> diff --git a/xen/arch/x86/monitor.c b/xen/arch/x86/monitor.c >> index 1fec412..1e5445f 100644 >> --- a/xen/arch/x86/monitor.c >> +++ b/xen/arch/x86/monitor.c >> @@ -20,7 +20,6 @@ >> */ >> >> #include <asm/monitor.h> >> -#include <public/vm_event.h> >> >> int arch_monitor_domctl_event(struct domain *d, >> struct xen_domctl_monitor_op *mop) >> @@ -62,14 +61,6 @@ int arch_monitor_domctl_event(struct domain *d, >> else >> ad->monitor.write_ctrlreg_enabled &= ~ctrlreg_bitmask; >> >> - if ( VM_EVENT_X86_CR3 == mop->u.mov_to_cr.index ) >> - { >> - struct vcpu *v; >> - /* Latches new CR3 mask through CR0 code. */ >> - for_each_vcpu ( d, v ) >> - hvm_update_guest_cr(v, 0); >> - } >> - > So this block is not really getting relocated as the commit message > suggests as much as being completely reworked at a different location? > It would be better for it to be it's own separate patch as the changes > are not trivial. That's actually not reworked, it's completely removed since there's no need for it anymore. That is: "latching of CR3 mask" is not done "through CR0" anymore but rather through the vm_event_vcpu_enter function instead and you don't have to do anything more here in arch_monitor_domctl_event for that to happen. >> domain_unpause(d); >> >> break; > Thanks, > Tamas > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-17 9:24 UTC|newest] Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-16 14:04 [PATCH 0/7] vm-event: Implement ARM support for control-register writes Corneliu ZUZU 2016-06-16 14:06 ` [PATCH 1/7] minor (formatting) fixes Corneliu ZUZU 2016-06-16 14:24 ` Jan Beulich 2016-06-16 19:19 ` Corneliu ZUZU 2016-06-17 7:06 ` Jan Beulich 2016-06-17 10:46 ` Corneliu ZUZU 2016-06-16 16:02 ` Tamas K Lengyel 2016-06-17 8:33 ` Corneliu ZUZU 2016-06-17 8:36 ` Razvan Cojocaru 2016-06-17 9:29 ` Andrew Cooper 2016-06-17 9:35 ` Jan Beulich 2016-06-17 9:33 ` Jan Beulich 2016-06-17 9:36 ` Razvan Cojocaru 2016-06-17 9:40 ` Jan Beulich 2016-06-17 9:42 ` Razvan Cojocaru 2016-06-17 19:05 ` Tamas K Lengyel 2016-06-16 14:07 ` [PATCH 2/7] vm-event: VM_EVENT_FLAG_DENY requires VM_EVENT_FLAG_VCPU_PAUSED Corneliu ZUZU 2016-06-16 16:11 ` Tamas K Lengyel 2016-06-17 8:43 ` Corneliu ZUZU 2016-06-21 11:26 ` Corneliu ZUZU 2016-06-21 15:09 ` Tamas K Lengyel 2016-06-22 8:34 ` Corneliu ZUZU 2016-06-16 14:08 ` [PATCH 3/7] vm-event: introduce vm_event_vcpu_enter Corneliu ZUZU 2016-06-16 14:51 ` Jan Beulich 2016-06-16 20:10 ` Corneliu ZUZU 2016-06-16 20:33 ` Razvan Cojocaru 2016-06-17 10:41 ` Corneliu ZUZU 2016-06-17 7:17 ` Jan Beulich 2016-06-17 11:13 ` Corneliu ZUZU 2016-06-17 11:27 ` Jan Beulich 2016-06-17 12:13 ` Corneliu ZUZU 2016-06-16 16:17 ` Tamas K Lengyel 2016-06-17 9:19 ` Corneliu ZUZU 2016-06-17 8:55 ` Julien Grall 2016-06-17 11:40 ` Corneliu ZUZU 2016-06-17 13:22 ` Julien Grall 2016-06-16 14:09 ` [PATCH 4/7] vm-event/x86: use vm_event_vcpu_enter properly Corneliu ZUZU 2016-06-16 15:00 ` Jan Beulich 2016-06-16 20:20 ` Corneliu ZUZU 2016-06-17 7:20 ` Jan Beulich 2016-06-17 11:23 ` Corneliu ZUZU 2016-06-16 16:27 ` Tamas K Lengyel 2016-06-17 9:24 ` Corneliu ZUZU [this message] 2016-06-16 14:10 ` [PATCH 5/7] x86: replace monitor_write_data.do_write with enum Corneliu ZUZU 2016-06-16 14:12 ` [PATCH 6/7] vm-event/arm: move hvm_event_cr->common vm_event_monitor_cr Corneliu ZUZU 2016-06-16 15:16 ` Jan Beulich 2016-06-17 8:25 ` Corneliu ZUZU 2016-06-17 8:38 ` Jan Beulich 2016-06-17 11:31 ` Corneliu ZUZU 2016-06-21 7:08 ` Corneliu ZUZU 2016-06-21 7:20 ` Jan Beulich 2016-06-21 15:22 ` Tamas K Lengyel 2016-06-22 6:33 ` Jan Beulich 2016-06-16 16:55 ` Tamas K Lengyel 2016-06-17 10:37 ` Corneliu ZUZU 2016-06-16 14:13 ` [PATCH 7/7] vm-event/arm: implement support for control-register write vm-events Corneliu ZUZU 2016-06-16 14:26 ` Julien Grall 2016-06-16 19:24 ` Corneliu ZUZU 2016-06-16 21:28 ` Julien Grall 2016-06-17 11:46 ` Corneliu ZUZU 2016-06-16 16:49 ` Julien Grall 2016-06-17 10:36 ` Corneliu ZUZU 2016-06-17 13:18 ` Julien Grall 2016-06-22 16:35 ` Corneliu ZUZU 2016-06-22 17:17 ` Julien Grall 2016-06-22 18:39 ` Corneliu ZUZU 2016-06-22 19:37 ` Corneliu ZUZU 2016-06-22 19:41 ` Julien Grall 2016-06-23 5:31 ` Corneliu ZUZU 2016-06-23 5:49 ` Corneliu ZUZU 2016-06-23 11:11 ` Julien Grall 2016-06-24 9:32 ` Corneliu ZUZU 2016-06-23 11:00 ` Julien Grall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4e5a3117-3321-e2ea-89fe-d42632c68aa1@bitdefender.com \ --to=czuzu@bitdefender.com \ --cc=andrew.cooper3@citrix.com \ --cc=jbeulich@suse.com \ --cc=jun.nakajima@intel.com \ --cc=kevin.tian@intel.com \ --cc=rcojocaru@bitdefender.com \ --cc=tamas@tklengyel.com \ --cc=xen-devel@lists.xen.org \ --subject='Re: [PATCH 4/7] vm-event/x86: use vm_event_vcpu_enter properly' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).