From: "Jan Beulich" <JBeulich@suse.com> To: Corneliu ZUZU <czuzu@bitdefender.com> Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Tamas K Lengyel <tamas@tklengyel.com>, Razvan Cojocaru <rcojocaru@bitdefender.com>, xen-devel@lists.xen.org Subject: Re: [PATCH 6/7] vm-event/arm: move hvm_event_cr->common vm_event_monitor_cr Date: Fri, 17 Jun 2016 02:38:06 -0600 [thread overview] Message-ID: <5763D30E02000078000F5F43@prv-mh.provo.novell.com> (raw) In-Reply-To: <d280cc91-46cf-a97d-4707-0c63980b6fbf@bitdefender.com> >>> On 17.06.16 at 10:25, <czuzu@bitdefender.com> wrote: > On 6/16/2016 6:16 PM, Jan Beulich wrote: >> And looking at all the uses of this variable I get the impression that >> you really want a shorthand for &d->arch.monitor (if any such >> helper variable is worthwhile to have here in the first place). > > Well, this was a simple cut-paste operation, not very old content aware :) > Personally I prefer the current shorthand (ad) (seems more intuitive and > is consistent with the other XEN_DOMCTL_MONITOR_EVENT_* cases), but if > you prefer I'll change that shorthand to am = &d->arch.monitor? I'd prefer either no shorthand, or one eliminating the longest common prefix across all uses. >>> --- a/xen/include/asm-x86/monitor.h >>> +++ b/xen/include/asm-x86/monitor.h >>> @@ -24,8 +24,6 @@ >>> >>> #include <xen/sched.h> >>> >>> -#define monitor_ctrlreg_bitmask(ctrlreg_index) (1U << (ctrlreg_index)) >>> - >>> static inline >>> int arch_monitor_domctl_op(struct domain *d, struct xen_domctl_monitor_op *mop) >>> { >>> --- a/xen/include/xen/monitor.h >>> +++ b/xen/include/xen/monitor.h >>> @@ -25,6 +25,10 @@ >>> struct domain; >>> struct xen_domctl_monitor_op; >>> >>> +#if CONFIG_X86 >>> +#define monitor_ctrlreg_bitmask(ctrlreg_index) (1U << (ctrlreg_index)) >>> +#endif >> What's the point in removing this from the x86 header if then it >> needs to be put in such a conditional? If the conditional gets >> dropped in the next patch, then I think you have two options: >> Leave it where it is here, and move it there. Or move it here, >> but omit the conditional right away - I can't see this definition >> being present to harm the ARM build in any way. > > Meld comment above. I don't follow - having split the patches for reviewability was a good idea. I merely commented on some oddities resulting from that split, which - afaict - could be easily corrected without folding the patches together. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-17 8:38 UTC|newest] Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-16 14:04 [PATCH 0/7] vm-event: Implement ARM support for control-register writes Corneliu ZUZU 2016-06-16 14:06 ` [PATCH 1/7] minor (formatting) fixes Corneliu ZUZU 2016-06-16 14:24 ` Jan Beulich 2016-06-16 19:19 ` Corneliu ZUZU 2016-06-17 7:06 ` Jan Beulich 2016-06-17 10:46 ` Corneliu ZUZU 2016-06-16 16:02 ` Tamas K Lengyel 2016-06-17 8:33 ` Corneliu ZUZU 2016-06-17 8:36 ` Razvan Cojocaru 2016-06-17 9:29 ` Andrew Cooper 2016-06-17 9:35 ` Jan Beulich 2016-06-17 9:33 ` Jan Beulich 2016-06-17 9:36 ` Razvan Cojocaru 2016-06-17 9:40 ` Jan Beulich 2016-06-17 9:42 ` Razvan Cojocaru 2016-06-17 19:05 ` Tamas K Lengyel 2016-06-16 14:07 ` [PATCH 2/7] vm-event: VM_EVENT_FLAG_DENY requires VM_EVENT_FLAG_VCPU_PAUSED Corneliu ZUZU 2016-06-16 16:11 ` Tamas K Lengyel 2016-06-17 8:43 ` Corneliu ZUZU 2016-06-21 11:26 ` Corneliu ZUZU 2016-06-21 15:09 ` Tamas K Lengyel 2016-06-22 8:34 ` Corneliu ZUZU 2016-06-16 14:08 ` [PATCH 3/7] vm-event: introduce vm_event_vcpu_enter Corneliu ZUZU 2016-06-16 14:51 ` Jan Beulich 2016-06-16 20:10 ` Corneliu ZUZU 2016-06-16 20:33 ` Razvan Cojocaru 2016-06-17 10:41 ` Corneliu ZUZU 2016-06-17 7:17 ` Jan Beulich 2016-06-17 11:13 ` Corneliu ZUZU 2016-06-17 11:27 ` Jan Beulich 2016-06-17 12:13 ` Corneliu ZUZU 2016-06-16 16:17 ` Tamas K Lengyel 2016-06-17 9:19 ` Corneliu ZUZU 2016-06-17 8:55 ` Julien Grall 2016-06-17 11:40 ` Corneliu ZUZU 2016-06-17 13:22 ` Julien Grall 2016-06-16 14:09 ` [PATCH 4/7] vm-event/x86: use vm_event_vcpu_enter properly Corneliu ZUZU 2016-06-16 15:00 ` Jan Beulich 2016-06-16 20:20 ` Corneliu ZUZU 2016-06-17 7:20 ` Jan Beulich 2016-06-17 11:23 ` Corneliu ZUZU 2016-06-16 16:27 ` Tamas K Lengyel 2016-06-17 9:24 ` Corneliu ZUZU 2016-06-16 14:10 ` [PATCH 5/7] x86: replace monitor_write_data.do_write with enum Corneliu ZUZU 2016-06-16 14:12 ` [PATCH 6/7] vm-event/arm: move hvm_event_cr->common vm_event_monitor_cr Corneliu ZUZU 2016-06-16 15:16 ` Jan Beulich 2016-06-17 8:25 ` Corneliu ZUZU 2016-06-17 8:38 ` Jan Beulich [this message] 2016-06-17 11:31 ` Corneliu ZUZU 2016-06-21 7:08 ` Corneliu ZUZU 2016-06-21 7:20 ` Jan Beulich 2016-06-21 15:22 ` Tamas K Lengyel 2016-06-22 6:33 ` Jan Beulich 2016-06-16 16:55 ` Tamas K Lengyel 2016-06-17 10:37 ` Corneliu ZUZU 2016-06-16 14:13 ` [PATCH 7/7] vm-event/arm: implement support for control-register write vm-events Corneliu ZUZU 2016-06-16 14:26 ` Julien Grall 2016-06-16 19:24 ` Corneliu ZUZU 2016-06-16 21:28 ` Julien Grall 2016-06-17 11:46 ` Corneliu ZUZU 2016-06-16 16:49 ` Julien Grall 2016-06-17 10:36 ` Corneliu ZUZU 2016-06-17 13:18 ` Julien Grall 2016-06-22 16:35 ` Corneliu ZUZU 2016-06-22 17:17 ` Julien Grall 2016-06-22 18:39 ` Corneliu ZUZU 2016-06-22 19:37 ` Corneliu ZUZU 2016-06-22 19:41 ` Julien Grall 2016-06-23 5:31 ` Corneliu ZUZU 2016-06-23 5:49 ` Corneliu ZUZU 2016-06-23 11:11 ` Julien Grall 2016-06-24 9:32 ` Corneliu ZUZU 2016-06-23 11:00 ` Julien Grall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5763D30E02000078000F5F43@prv-mh.provo.novell.com \ --to=jbeulich@suse.com \ --cc=andrew.cooper3@citrix.com \ --cc=czuzu@bitdefender.com \ --cc=rcojocaru@bitdefender.com \ --cc=tamas@tklengyel.com \ --cc=xen-devel@lists.xen.org \ --subject='Re: [PATCH 6/7] vm-event/arm: move hvm_event_cr->common vm_event_monitor_cr' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).