From: Geert Uytterhoeven <geert@linux-m68k.org> To: Conor Dooley <Conor.Dooley@microchip.com> Cc: Prabhakar Lad <prabhakar.csengg@gmail.com>, "Lad, Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Anup Patel <anup@brainfault.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, linux-riscv <linux-riscv@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Biju Das <biju.das.jz@bp.renesas.com>, Samuel Holland <samuel@sholland.org> Subject: Re: [PATCH v2 4/8] RISC-V: Kconfig.socs: Add Renesas RZ/Five SoC kconfig option Date: Fri, 19 Aug 2022 09:35:40 +0200 [thread overview] Message-ID: <CAMuHMdUPzukO8Cqk86NbPU-ytidr--Qumg6KzVcUqE4GWmumaQ@mail.gmail.com> (raw) In-Reply-To: <eeadea8e-a6bc-0965-1246-82b0042838e4@microchip.com> Hi Conor, On Thu, Aug 18, 2022 at 8:54 PM <Conor.Dooley@microchip.com> wrote: > On 18/08/2022 19:19, Lad, Prabhakar wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Thu, Aug 18, 2022 at 4:16 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > >> On Mon, Aug 15, 2022 at 5:16 PM Lad Prabhakar > >> <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > >>> Introduce SOC_RENESAS_RZFIVE config option to enable Renesas RZ/Five > >>> (R9A07G043) SoC, along side also add ARCH_RENESAS config option as most > >>> of the Renesas drivers depend on this config option. > >>> > >>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > >> > >> Thanks for your patch! > >> > >> The technical part LGTM, so > >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > >> > >>> --- a/arch/riscv/Kconfig.socs > >>> +++ b/arch/riscv/Kconfig.socs > >>> @@ -80,4 +80,18 @@ config SOC_CANAAN_K210_DTB_SOURCE > >>> > >>> endif # SOC_CANAAN > >>> > >>> +config ARCH_RENESAS > >> > >> We definitely want ARCH_RENESAS, as it serves as a gatekeeper for > >> Kconfig options for IP cores found on Renesas ARM and RISC-V SoCs. > >> > > Agreed, or else we will end up touching too many Kconfig files. > > > >>> + bool > >>> + select GPIOLIB > >>> + select PINCTRL > >>> + select SOC_BUS > >>> + > >>> +config SOC_RENESAS_RZFIVE > >> > >> Do we need this symbol? You could as well make ARCH_RENESAS above > >> visible, and defer the actual SoC selection to ARCH_R9A07G043 in > >> drivers/soc/renesas/Kconfig[1]. > >> > > I think we could drop it and just defer the actual SoC selection to > > ARCH_R9A07G043 as you said. > > > >> I don't know what is the policy on RISC-V. ARM64 has a "single-symbol > >> in arch/arm64/Kconfig.platforms"-policy, so we handle SoC selection > >> in drivers/soc/renesas/Kconfig, and that is fine, as it avoids merge > >> conflicts. > >> > > Agreed. > > > > @Conor - Does the above sound OK? > > It's not my decision to be honest - Palmer's the boss :) > > I would rather have a single symbol & a single approach so that we are > all doing the same thing here. As of now, we have all basically done > different things for each SOC that was added - there's SOC_SIFIVE & > SOC_MICROCHIP_POLARFIRE which are obviously not doing the same thing > for starters & then how the symbol is used: selects vs depends + default > all varies between the symbols. > > I tried to make some changes to the PolarFire one a few months ago to > add some peripherals but Palmer was not too keen on the changes. We had > a conversation on IRC, the upshot of which was deciding to talk about it > at Plumbers (which is in 3 weeks) as none of them follow his original > intent: > <quote> > the original idea behind Kconfig.socs was to provide an easy place for > users to say "I want all the support for SOC X", and then just have one > Kconfig to turn that on > <\quote> For whatever definition of "all"? Does this include e.g. all multi-media stuff? For Renesas ARM SoCs, we make sure to select the critical core parts, cfr. the selects above, and in drivers/soc/renesas/Kconfig. These selects do not include optional drivers, including the serial port (cfr. your confusion about adding CONFIG_SERIAL_SH_SCI=y to the defconfig). All the rest is handled by the defconfigs (shmobile_defconfig on arm32, single defconfig on arm64, and out-of-tree renesas_defconfig in my renesas-devel tree). > In theory, that's lovely but not really maintainable & none of us were > doing it anyway. Hopefully we can come up with a plan at Plumbers - so > feel free to chime in (or maybe it gets sorted out here and I don't > have to do any public speaking 😍). Ah, there is my good reason for registering for LPC ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org> To: Conor Dooley <Conor.Dooley@microchip.com> Cc: Prabhakar Lad <prabhakar.csengg@gmail.com>, "Lad, Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Anup Patel <anup@brainfault.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, linux-riscv <linux-riscv@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Biju Das <biju.das.jz@bp.renesas.com>, Samuel Holland <samuel@sholland.org> Subject: Re: [PATCH v2 4/8] RISC-V: Kconfig.socs: Add Renesas RZ/Five SoC kconfig option Date: Fri, 19 Aug 2022 09:35:40 +0200 [thread overview] Message-ID: <CAMuHMdUPzukO8Cqk86NbPU-ytidr--Qumg6KzVcUqE4GWmumaQ@mail.gmail.com> (raw) In-Reply-To: <eeadea8e-a6bc-0965-1246-82b0042838e4@microchip.com> Hi Conor, On Thu, Aug 18, 2022 at 8:54 PM <Conor.Dooley@microchip.com> wrote: > On 18/08/2022 19:19, Lad, Prabhakar wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Thu, Aug 18, 2022 at 4:16 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > >> On Mon, Aug 15, 2022 at 5:16 PM Lad Prabhakar > >> <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > >>> Introduce SOC_RENESAS_RZFIVE config option to enable Renesas RZ/Five > >>> (R9A07G043) SoC, along side also add ARCH_RENESAS config option as most > >>> of the Renesas drivers depend on this config option. > >>> > >>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > >> > >> Thanks for your patch! > >> > >> The technical part LGTM, so > >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > >> > >>> --- a/arch/riscv/Kconfig.socs > >>> +++ b/arch/riscv/Kconfig.socs > >>> @@ -80,4 +80,18 @@ config SOC_CANAAN_K210_DTB_SOURCE > >>> > >>> endif # SOC_CANAAN > >>> > >>> +config ARCH_RENESAS > >> > >> We definitely want ARCH_RENESAS, as it serves as a gatekeeper for > >> Kconfig options for IP cores found on Renesas ARM and RISC-V SoCs. > >> > > Agreed, or else we will end up touching too many Kconfig files. > > > >>> + bool > >>> + select GPIOLIB > >>> + select PINCTRL > >>> + select SOC_BUS > >>> + > >>> +config SOC_RENESAS_RZFIVE > >> > >> Do we need this symbol? You could as well make ARCH_RENESAS above > >> visible, and defer the actual SoC selection to ARCH_R9A07G043 in > >> drivers/soc/renesas/Kconfig[1]. > >> > > I think we could drop it and just defer the actual SoC selection to > > ARCH_R9A07G043 as you said. > > > >> I don't know what is the policy on RISC-V. ARM64 has a "single-symbol > >> in arch/arm64/Kconfig.platforms"-policy, so we handle SoC selection > >> in drivers/soc/renesas/Kconfig, and that is fine, as it avoids merge > >> conflicts. > >> > > Agreed. > > > > @Conor - Does the above sound OK? > > It's not my decision to be honest - Palmer's the boss :) > > I would rather have a single symbol & a single approach so that we are > all doing the same thing here. As of now, we have all basically done > different things for each SOC that was added - there's SOC_SIFIVE & > SOC_MICROCHIP_POLARFIRE which are obviously not doing the same thing > for starters & then how the symbol is used: selects vs depends + default > all varies between the symbols. > > I tried to make some changes to the PolarFire one a few months ago to > add some peripherals but Palmer was not too keen on the changes. We had > a conversation on IRC, the upshot of which was deciding to talk about it > at Plumbers (which is in 3 weeks) as none of them follow his original > intent: > <quote> > the original idea behind Kconfig.socs was to provide an easy place for > users to say "I want all the support for SOC X", and then just have one > Kconfig to turn that on > <\quote> For whatever definition of "all"? Does this include e.g. all multi-media stuff? For Renesas ARM SoCs, we make sure to select the critical core parts, cfr. the selects above, and in drivers/soc/renesas/Kconfig. These selects do not include optional drivers, including the serial port (cfr. your confusion about adding CONFIG_SERIAL_SH_SCI=y to the defconfig). All the rest is handled by the defconfigs (shmobile_defconfig on arm32, single defconfig on arm64, and out-of-tree renesas_defconfig in my renesas-devel tree). > In theory, that's lovely but not really maintainable & none of us were > doing it anyway. Hopefully we can come up with a plan at Plumbers - so > feel free to chime in (or maybe it gets sorted out here and I don't > have to do any public speaking 😍). Ah, there is my good reason for registering for LPC ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-08-19 7:36 UTC|newest] Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-15 15:14 [PATCH v2 0/8] Add support for Renesas RZ/Five SoC Lad Prabhakar 2022-08-15 15:14 ` Lad Prabhakar 2022-08-15 15:14 ` [PATCH v2 1/8] dt-bindings: riscv: Sort the CPU core list alphabetically Lad Prabhakar 2022-08-15 15:14 ` Lad Prabhakar 2022-08-15 19:11 ` Conor.Dooley 2022-08-15 19:11 ` Conor.Dooley 2022-08-18 13:00 ` Geert Uytterhoeven 2022-08-18 13:00 ` Geert Uytterhoeven 2022-08-18 13:00 ` Geert Uytterhoeven 2022-08-18 13:00 ` Geert Uytterhoeven 2022-08-15 15:14 ` [PATCH v2 2/8] dt-bindings: riscv: Add Andes AX45MP core to the list Lad Prabhakar 2022-08-15 15:14 ` Lad Prabhakar 2022-08-18 14:55 ` Geert Uytterhoeven 2022-08-18 14:55 ` Geert Uytterhoeven 2022-08-15 15:14 ` [PATCH v2 3/8] dt-bindings: soc: renesas: renesas.yaml: Document Renesas RZ/Five SoC Lad Prabhakar 2022-08-15 15:14 ` Lad Prabhakar 2022-08-15 19:14 ` Conor.Dooley 2022-08-15 19:14 ` Conor.Dooley 2022-08-15 19:40 ` Lad, Prabhakar 2022-08-15 19:40 ` Lad, Prabhakar 2022-08-15 19:42 ` Conor.Dooley 2022-08-15 19:42 ` Conor.Dooley 2022-08-16 7:52 ` Krzysztof Kozlowski 2022-08-16 7:52 ` Krzysztof Kozlowski 2022-08-18 15:00 ` Geert Uytterhoeven 2022-08-18 15:00 ` Geert Uytterhoeven 2022-08-18 18:14 ` Lad, Prabhakar 2022-08-18 18:14 ` Lad, Prabhakar 2022-08-15 15:14 ` [PATCH v2 4/8] RISC-V: Kconfig.socs: Add Renesas RZ/Five SoC kconfig option Lad Prabhakar 2022-08-15 15:14 ` Lad Prabhakar 2022-08-15 19:10 ` Conor.Dooley 2022-08-15 19:10 ` Conor.Dooley 2022-08-15 19:57 ` Lad, Prabhakar 2022-08-15 19:57 ` Lad, Prabhakar 2022-08-15 20:05 ` Conor.Dooley 2022-08-15 20:05 ` Conor.Dooley 2022-08-15 21:44 ` Lad, Prabhakar 2022-08-15 21:44 ` Lad, Prabhakar 2022-08-18 15:16 ` Geert Uytterhoeven 2022-08-18 15:16 ` Geert Uytterhoeven 2022-08-18 18:19 ` Lad, Prabhakar 2022-08-18 18:19 ` Lad, Prabhakar 2022-08-18 18:53 ` Conor.Dooley 2022-08-18 18:53 ` Conor.Dooley 2022-08-19 7:35 ` Geert Uytterhoeven [this message] 2022-08-19 7:35 ` Geert Uytterhoeven 2022-08-19 7:59 ` Conor.Dooley 2022-08-19 7:59 ` Conor.Dooley 2022-08-15 15:14 ` [PATCH v2 5/8] riscv: dts: renesas: Add initial devicetree for Renesas RZ/Five SoC Lad Prabhakar 2022-08-15 15:14 ` Lad Prabhakar 2022-08-19 8:04 ` Geert Uytterhoeven 2022-08-19 8:04 ` Geert Uytterhoeven 2022-08-19 11:42 ` Lad, Prabhakar 2022-08-19 11:42 ` Lad, Prabhakar 2022-08-19 18:40 ` Conor.Dooley 2022-08-19 18:40 ` Conor.Dooley 2022-08-20 8:45 ` Geert Uytterhoeven 2022-08-20 8:45 ` Geert Uytterhoeven 2022-08-20 8:49 ` Conor.Dooley 2022-08-20 8:49 ` Conor.Dooley 2022-08-20 12:07 ` Geert Uytterhoeven 2022-08-20 12:07 ` Geert Uytterhoeven 2022-08-15 15:14 ` [PATCH v2 6/8] riscv: dts: renesas: Add minimal DTS for Renesas RZ/Five SMARC EVK Lad Prabhakar 2022-08-15 15:14 ` Lad Prabhakar 2022-08-15 19:00 ` Conor.Dooley 2022-08-15 19:00 ` Conor.Dooley 2022-08-15 20:16 ` Lad, Prabhakar 2022-08-15 20:16 ` Lad, Prabhakar 2022-08-19 8:25 ` Geert Uytterhoeven 2022-08-19 8:25 ` Geert Uytterhoeven 2022-08-19 11:39 ` Lad, Prabhakar 2022-08-19 11:39 ` Lad, Prabhakar 2022-08-19 18:15 ` Conor.Dooley 2022-08-19 18:15 ` Conor.Dooley 2022-08-19 8:11 ` Geert Uytterhoeven 2022-08-19 8:11 ` Geert Uytterhoeven 2022-08-15 15:14 ` [PATCH v2 7/8] MAINTAINERS: Add entry for Renesas RISC-V architecture Lad Prabhakar 2022-08-15 15:14 ` Lad Prabhakar 2022-08-19 8:42 ` Geert Uytterhoeven 2022-08-19 8:42 ` Geert Uytterhoeven 2022-08-19 9:08 ` Lad, Prabhakar 2022-08-19 9:08 ` Lad, Prabhakar 2022-08-15 15:14 ` [PATCH v2 8/8] RISC-V: configs: defconfig: Enable Renesas RZ/Five SoC Lad Prabhakar 2022-08-15 15:14 ` Lad Prabhakar 2022-08-15 18:52 ` Conor.Dooley 2022-08-15 18:52 ` Conor.Dooley 2022-08-15 19:44 ` Lad, Prabhakar 2022-08-15 19:44 ` Lad, Prabhakar 2022-08-15 19:49 ` Conor.Dooley 2022-08-15 19:49 ` Conor.Dooley 2022-08-19 8:46 ` Geert Uytterhoeven 2022-08-19 8:46 ` Geert Uytterhoeven
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAMuHMdUPzukO8Cqk86NbPU-ytidr--Qumg6KzVcUqE4GWmumaQ@mail.gmail.com \ --to=geert@linux-m68k.org \ --cc=Conor.Dooley@microchip.com \ --cc=anup@brainfault.org \ --cc=aou@eecs.berkeley.edu \ --cc=biju.das.jz@bp.renesas.com \ --cc=devicetree@vger.kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=prabhakar.csengg@gmail.com \ --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \ --cc=robh+dt@kernel.org \ --cc=samuel@sholland.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.