All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: Han Xu <han.xu@nxp.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Bough Chen <haibo.chen@nxp.com>,
	ashish.kumar@nxp.com, yogeshgaur.83@gmail.com,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	singh.kuldeep87k@gmail.com, tudor.ambarus@microchip.com,
	p.yadav@ti.com, miquel.raynal@bootlin.com, richard@nod.at,
	vigneshr@ti.com, shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, linux-spi@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-mtd@lists.infradead.org, festevam@gmail.com,
	dl-linux-imx <linux-imx@nxp.com>,
	linux-arm-kernel@lists.infradead.org, zhengxunli@mxic.com.tw
Subject: Re: [PATCH 07/11] dt-bindings: spi: spi-nxp-fspi: add a new property nxp,fspi-dll-slvdly
Date: Tue, 5 Jul 2022 16:07:27 +0100	[thread overview]
Message-ID: <YsRTryAlyJjm9A9+@sirena.org.uk> (raw)
In-Reply-To: <d4a69511eea5195b2ee7726bda5a8a33@walle.cc>


[-- Attachment #1.1: Type: text/plain, Size: 787 bytes --]

On Tue, Jul 05, 2022 at 04:58:40PM +0200, Michael Walle wrote:
> Am 2022-07-05 16:52, schrieb Han Xu:

> > IMO, use the unit "-degrees" makes it more complicate. Personaly I would
> > calculate how many clock cycle delay needed, such as 1/4 clock cycle or
> > half
> > clock cycle. Using degree brings extra calculation.

> What is the extra calculation here? For hardware engineer who has to
> specify this, it is easier to give the delay in clock phase (in degrees)
> rather than reading the documentation and transform that into a value
> given in 1/32 part of a clock, that should be part of the driver.

IME if it's a hardware engineer specifying things by the time they get
as far as a software engineer they'll often have been turned into "write
these values to these registers".

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: Han Xu <han.xu@nxp.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Bough Chen <haibo.chen@nxp.com>,
	ashish.kumar@nxp.com, yogeshgaur.83@gmail.com,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	singh.kuldeep87k@gmail.com, tudor.ambarus@microchip.com,
	p.yadav@ti.com, miquel.raynal@bootlin.com, richard@nod.at,
	vigneshr@ti.com, shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, linux-spi@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-mtd@lists.infradead.org, festevam@gmail.com,
	dl-linux-imx <linux-imx@nxp.com>,
	linux-arm-kernel@lists.infradead.org, zhengxunli@mxic.com.tw
Subject: Re: [PATCH 07/11] dt-bindings: spi: spi-nxp-fspi: add a new property nxp,fspi-dll-slvdly
Date: Tue, 5 Jul 2022 16:07:27 +0100	[thread overview]
Message-ID: <YsRTryAlyJjm9A9+@sirena.org.uk> (raw)
In-Reply-To: <d4a69511eea5195b2ee7726bda5a8a33@walle.cc>


[-- Attachment #1.1: Type: text/plain, Size: 787 bytes --]

On Tue, Jul 05, 2022 at 04:58:40PM +0200, Michael Walle wrote:
> Am 2022-07-05 16:52, schrieb Han Xu:

> > IMO, use the unit "-degrees" makes it more complicate. Personaly I would
> > calculate how many clock cycle delay needed, such as 1/4 clock cycle or
> > half
> > clock cycle. Using degree brings extra calculation.

> What is the extra calculation here? For hardware engineer who has to
> specify this, it is easier to give the delay in clock phase (in degrees)
> rather than reading the documentation and transform that into a value
> given in 1/32 part of a clock, that should be part of the driver.

IME if it's a hardware engineer specifying things by the time they get
as far as a software engineer they'll often have been turned into "write
these values to these registers".

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: Han Xu <han.xu@nxp.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Bough Chen <haibo.chen@nxp.com>,
	ashish.kumar@nxp.com, yogeshgaur.83@gmail.com,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	singh.kuldeep87k@gmail.com, tudor.ambarus@microchip.com,
	p.yadav@ti.com, miquel.raynal@bootlin.com, richard@nod.at,
	vigneshr@ti.com, shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, linux-spi@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-mtd@lists.infradead.org, festevam@gmail.com,
	dl-linux-imx <linux-imx@nxp.com>,
	linux-arm-kernel@lists.infradead.org, zhengxunli@mxic.com.tw
Subject: Re: [PATCH 07/11] dt-bindings: spi: spi-nxp-fspi: add a new property nxp,fspi-dll-slvdly
Date: Tue, 5 Jul 2022 16:07:27 +0100	[thread overview]
Message-ID: <YsRTryAlyJjm9A9+@sirena.org.uk> (raw)
In-Reply-To: <d4a69511eea5195b2ee7726bda5a8a33@walle.cc>

[-- Attachment #1: Type: text/plain, Size: 787 bytes --]

On Tue, Jul 05, 2022 at 04:58:40PM +0200, Michael Walle wrote:
> Am 2022-07-05 16:52, schrieb Han Xu:

> > IMO, use the unit "-degrees" makes it more complicate. Personaly I would
> > calculate how many clock cycle delay needed, such as 1/4 clock cycle or
> > half
> > clock cycle. Using degree brings extra calculation.

> What is the extra calculation here? For hardware engineer who has to
> specify this, it is easier to give the delay in clock phase (in degrees)
> rather than reading the documentation and transform that into a value
> given in 1/32 part of a clock, that should be part of the driver.

IME if it's a hardware engineer specifying things by the time they get
as far as a software engineer they'll often have been turned into "write
these values to these registers".

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2022-07-05 15:07 UTC|newest]

Thread overview: 99+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-05  9:11 [PATCH 01/11] spi: spi-nxp-fspi: enable runtime pm for fspi haibo.chen
2022-07-05  9:11 ` haibo.chen
2022-07-05  9:11 ` haibo.chen
2022-07-05  9:11 ` [PATCH 02/11] spi: spi-nxp-fspi: change the default lut index haibo.chen
2022-07-05  9:11   ` haibo.chen
2022-07-05  9:11   ` haibo.chen
2022-07-05  9:11 ` [PATCH 03/11] spi: spi-nxp-fspi: add DTR mode support haibo.chen
2022-07-05  9:11   ` haibo.chen
2022-07-05  9:11   ` haibo.chen
2022-07-05  9:11 ` [PATCH 04/11] spi: spi-nxp-fspi: add function to select sample clock source for flash reading haibo.chen
2022-07-05  9:11   ` haibo.chen
2022-07-05  9:11   ` haibo.chen
2022-07-06 21:02   ` Michael Walle
2022-07-06 21:02     ` Michael Walle
2022-07-06 21:02     ` Michael Walle
2022-07-05  9:11 ` [PATCH 05/11] spi: spi-nxp-fspi: Add quirk to disable DTR support haibo.chen
2022-07-05  9:11   ` haibo.chen
2022-07-05  9:11   ` haibo.chen
2022-07-05 13:50   ` Michael Walle
2022-07-05 13:50     ` Michael Walle
2022-07-05 13:50     ` Michael Walle
2022-07-05  9:11 ` [PATCH 06/11] spi: spi-nxp-fspi: enable octal ddr for iMX8QM/QXP/DXL haibo.chen
2022-07-05  9:11   ` haibo.chen
2022-07-05  9:11   ` haibo.chen
2022-07-05  9:11 ` [PATCH 07/11] dt-bindings: spi: spi-nxp-fspi: add a new property nxp,fspi-dll-slvdly haibo.chen
2022-07-05  9:11   ` haibo.chen
2022-07-05  9:11   ` haibo.chen
2022-07-05  9:48   ` Krzysztof Kozlowski
2022-07-05  9:48     ` Krzysztof Kozlowski
2022-07-05  9:48     ` Krzysztof Kozlowski
2022-07-05 10:28     ` Bough Chen
2022-07-05 10:28       ` Bough Chen
2022-07-05 10:28       ` Bough Chen
2022-07-05 10:36       ` Krzysztof Kozlowski
2022-07-05 10:36         ` Krzysztof Kozlowski
2022-07-05 10:36         ` Krzysztof Kozlowski
2022-07-05 13:19         ` Han Xu
2022-07-05 13:19           ` Han Xu
2022-07-05 13:19           ` Han Xu
2022-07-05 13:29           ` Krzysztof Kozlowski
2022-07-05 13:29             ` Krzysztof Kozlowski
2022-07-05 13:29             ` Krzysztof Kozlowski
2022-07-05 14:00             ` Han Xu
2022-07-05 14:00               ` Han Xu
2022-07-05 14:00               ` Han Xu
2022-07-05 14:03               ` Krzysztof Kozlowski
2022-07-05 14:03                 ` Krzysztof Kozlowski
2022-07-05 14:03                 ` Krzysztof Kozlowski
2022-07-05 14:31                 ` Han Xu
2022-07-05 14:31                   ` Han Xu
2022-07-05 14:31                   ` Han Xu
2022-07-05 14:06               ` Michael Walle
2022-07-05 14:06                 ` Michael Walle
2022-07-05 14:06                 ` Michael Walle
2022-07-05 14:12                 ` Krzysztof Kozlowski
2022-07-05 14:12                   ` Krzysztof Kozlowski
2022-07-05 14:12                   ` Krzysztof Kozlowski
2022-07-05 14:52                   ` Han Xu
2022-07-05 14:52                     ` Han Xu
2022-07-05 14:52                     ` Han Xu
2022-07-05 14:58                     ` Michael Walle
2022-07-05 14:58                       ` Michael Walle
2022-07-05 14:58                       ` Michael Walle
2022-07-05 15:07                       ` Mark Brown [this message]
2022-07-05 15:07                         ` Mark Brown
2022-07-05 15:07                         ` Mark Brown
2022-07-05 15:38                     ` Krzysztof Kozlowski
2022-07-05 15:38                       ` Krzysztof Kozlowski
2022-07-05 15:38                       ` Krzysztof Kozlowski
2022-07-05 15:50                       ` Han Xu
2022-07-05 15:50                         ` Han Xu
2022-07-05 15:50                         ` Han Xu
2022-07-06 16:11                         ` Rob Herring
2022-07-06 16:11                           ` Rob Herring
2022-07-06 16:11                           ` Rob Herring
2022-07-06 20:59                           ` Michael Walle
2022-07-06 20:59                             ` Michael Walle
2022-07-06 20:59                             ` Michael Walle
2022-07-05  9:11 ` [PATCH 08/11] mtd: spi-nor: macronix: add support for Macronix octaflash haibo.chen
2022-07-05  9:11   ` haibo.chen
2022-07-05  9:11   ` haibo.chen
2022-07-05  9:11 ` [PATCH 09/11] mtd: spi-nor: macronix: add mx25uw51345g OPI mode support haibo.chen
2022-07-05  9:11   ` haibo.chen
2022-07-05  9:11   ` haibo.chen
2022-07-18  6:57   ` Michael Walle
2022-07-18  6:57     ` Michael Walle
2022-07-18  6:57     ` Michael Walle
2022-07-05  9:11 ` [PATCH 10/11] arm64: dts: imx8ulp: add flexspi support haibo.chen
2022-07-05  9:11   ` haibo.chen
2022-07-05  9:11   ` haibo.chen
2022-07-05  9:11 ` [PATCH 11/11] arm64: dts: imx8qm/imx8qxp: " haibo.chen
2022-07-05  9:11   ` haibo.chen
2022-07-05  9:11   ` haibo.chen
2022-07-05 14:01 ` [PATCH 01/11] spi: spi-nxp-fspi: enable runtime pm for fspi Michael Walle
2022-07-05 14:01   ` Michael Walle
2022-07-05 14:01   ` Michael Walle
2022-07-05 23:06   ` Han Xu
2022-07-05 23:06     ` Han Xu
2022-07-05 23:06     ` Han Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YsRTryAlyJjm9A9+@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=ashish.kumar@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=haibo.chen@nxp.com \
    --cc=han.xu@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=michael@walle.cc \
    --cc=miquel.raynal@bootlin.com \
    --cc=p.yadav@ti.com \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=singh.kuldeep87k@gmail.com \
    --cc=tudor.ambarus@microchip.com \
    --cc=vigneshr@ti.com \
    --cc=yogeshgaur.83@gmail.com \
    --cc=zhengxunli@mxic.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.