From: Auger Eric <eric.auger@redhat.com> To: Alexandru Elisei <alexandru.elisei@arm.com>, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, drjones@redhat.com Cc: andre.przywara@arm.com Subject: Re: [kvm-unit-tests PATCH 08/10] arm/arm64: gic: Split check_acked() into two functions Date: Wed, 16 Dec 2020 13:37:21 +0100 [thread overview] Message-ID: <08ba32cf-0a6f-79d9-fb53-a84205cae4b1@redhat.com> (raw) In-Reply-To: <a01f61cf-d174-87b7-4db1-32b62a2c3e8a@arm.com> Hi Alexandru, On 12/16/20 12:40 PM, Alexandru Elisei wrote: > Hi Eric, > > On 12/15/20 1:58 PM, Auger Eric wrote: >> Hi Alexandru, >> >> On 12/10/20 3:45 PM, Alexandru Elisei wrote: >>> Hi Eric, >>> >>> On 12/3/20 1:39 PM, Auger Eric wrote: >>>> [..] >>>> >>>> static void check_spurious(void) >>>> @@ -300,7 +318,8 @@ static void ipi_test_self(void) >>>> cpumask_clear(&mask); >>>> cpumask_set_cpu(smp_processor_id(), &mask); >>>> gic->ipi.send_self(); >>>> - check_acked("IPI: self", &mask); >>>> + wait_for_interrupts(&mask); >>>> + report(check_acked(&mask), "Interrupts received"); >>>> report_prefix_pop(); >>>> } >>>> >>>> @@ -315,7 +334,8 @@ static void ipi_test_smp(void) >>>> for (i = smp_processor_id() & 1; i < nr_cpus; i += 2) >>>> cpumask_clear_cpu(i, &mask); >>>> gic_ipi_send_mask(IPI_IRQ, &mask); >>>> - check_acked("IPI: directed", &mask); >>>> + wait_for_interrupts(&mask); >>>> + report(check_acked(&mask), "Interrupts received"); >>>> both ipi_test_smp and ipi_test_self are called from the same test so >>>> better to use different error messages like it was done originally. >>> I used the same error message because the tests have a different prefix >>> ("target-list" versus "broadcast"). Do you think there are cases where that's not >>> enough? >> I think in "ipi" test, >> ipi_test -> ipi_send -> ipi_test_self, ipi_test_smp > > I'm afraid I don't understand what you are trying to say. This is the log for the > gicv3-ipi test: > > $ cat logs/gicv3-ipi.log > timeout -k 1s --foreground 90s /usr/bin/qemu-system-aarch64 -nodefaults -machine > virt,gic-version=host,accel=kvm -cpu host -device virtio-serial-device -device > virtconsole,chardev=ctd -chardev testdev,id=ctd -device pci-testdev -display none > -serial stdio -kernel arm/gic.flat -smp 6 -machine gic-version=3 -append ipi # > -initrd /tmp/tmp.trk6aAcaZx > WARNING: early print support may not work. Found uart at 0x9000000, but early base > is 0x3f8. > PASS: gicv3: ipi: self: Interrupts received > PASS: gicv3: ipi: target-list: Interrupts received > PASS: gicv3: ipi: broadcast: Interrupts received > SUMMARY: 3 tests > > The warning is because I forgot to reconfigure the tests with --vmm=qemu. > > Would you mind pointing out what you think is ambiguous? Hum sorry I did not pay attention to the report_prefix_push() within ipi_test_self & ipi_test_smp. I had in mind those were only in the main(). Forgive me for the noise Eric > > Thanks, > > Alex >
WARNING: multiple messages have this Message-ID (diff)
From: Auger Eric <eric.auger@redhat.com> To: Alexandru Elisei <alexandru.elisei@arm.com>, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, drjones@redhat.com Cc: andre.przywara@arm.com Subject: Re: [kvm-unit-tests PATCH 08/10] arm/arm64: gic: Split check_acked() into two functions Date: Wed, 16 Dec 2020 13:37:21 +0100 [thread overview] Message-ID: <08ba32cf-0a6f-79d9-fb53-a84205cae4b1@redhat.com> (raw) In-Reply-To: <a01f61cf-d174-87b7-4db1-32b62a2c3e8a@arm.com> Hi Alexandru, On 12/16/20 12:40 PM, Alexandru Elisei wrote: > Hi Eric, > > On 12/15/20 1:58 PM, Auger Eric wrote: >> Hi Alexandru, >> >> On 12/10/20 3:45 PM, Alexandru Elisei wrote: >>> Hi Eric, >>> >>> On 12/3/20 1:39 PM, Auger Eric wrote: >>>> [..] >>>> >>>> static void check_spurious(void) >>>> @@ -300,7 +318,8 @@ static void ipi_test_self(void) >>>> cpumask_clear(&mask); >>>> cpumask_set_cpu(smp_processor_id(), &mask); >>>> gic->ipi.send_self(); >>>> - check_acked("IPI: self", &mask); >>>> + wait_for_interrupts(&mask); >>>> + report(check_acked(&mask), "Interrupts received"); >>>> report_prefix_pop(); >>>> } >>>> >>>> @@ -315,7 +334,8 @@ static void ipi_test_smp(void) >>>> for (i = smp_processor_id() & 1; i < nr_cpus; i += 2) >>>> cpumask_clear_cpu(i, &mask); >>>> gic_ipi_send_mask(IPI_IRQ, &mask); >>>> - check_acked("IPI: directed", &mask); >>>> + wait_for_interrupts(&mask); >>>> + report(check_acked(&mask), "Interrupts received"); >>>> both ipi_test_smp and ipi_test_self are called from the same test so >>>> better to use different error messages like it was done originally. >>> I used the same error message because the tests have a different prefix >>> ("target-list" versus "broadcast"). Do you think there are cases where that's not >>> enough? >> I think in "ipi" test, >> ipi_test -> ipi_send -> ipi_test_self, ipi_test_smp > > I'm afraid I don't understand what you are trying to say. This is the log for the > gicv3-ipi test: > > $ cat logs/gicv3-ipi.log > timeout -k 1s --foreground 90s /usr/bin/qemu-system-aarch64 -nodefaults -machine > virt,gic-version=host,accel=kvm -cpu host -device virtio-serial-device -device > virtconsole,chardev=ctd -chardev testdev,id=ctd -device pci-testdev -display none > -serial stdio -kernel arm/gic.flat -smp 6 -machine gic-version=3 -append ipi # > -initrd /tmp/tmp.trk6aAcaZx > WARNING: early print support may not work. Found uart at 0x9000000, but early base > is 0x3f8. > PASS: gicv3: ipi: self: Interrupts received > PASS: gicv3: ipi: target-list: Interrupts received > PASS: gicv3: ipi: broadcast: Interrupts received > SUMMARY: 3 tests > > The warning is because I forgot to reconfigure the tests with --vmm=qemu. > > Would you mind pointing out what you think is ambiguous? Hum sorry I did not pay attention to the report_prefix_push() within ipi_test_self & ipi_test_smp. I had in mind those were only in the main(). Forgive me for the noise Eric > > Thanks, > > Alex > _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2020-12-16 12:39 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-25 15:51 [kvm-unit-tests PATCH 00/10] GIC fixes and improvements Alexandru Elisei 2020-11-25 15:51 ` Alexandru Elisei 2020-11-25 15:51 ` [kvm-unit-tests PATCH 01/10] lib: arm/arm64: gicv3: Add missing barrier when sending IPIs Alexandru Elisei 2020-11-25 15:51 ` Alexandru Elisei 2020-12-01 16:37 ` Auger Eric 2020-12-01 16:37 ` Auger Eric 2020-12-01 17:37 ` Alexandru Elisei 2020-12-01 17:37 ` Alexandru Elisei 2020-11-25 15:51 ` [kvm-unit-tests PATCH 02/10] lib: arm/arm64: gicv2: " Alexandru Elisei 2020-11-25 15:51 ` Alexandru Elisei 2020-12-01 16:37 ` Auger Eric 2020-12-01 16:37 ` Auger Eric 2020-11-25 15:51 ` [kvm-unit-tests PATCH 03/10] arm/arm64: gic: Remove memory synchronization from ipi_clear_active_handler() Alexandru Elisei 2020-11-25 15:51 ` Alexandru Elisei 2020-12-01 16:37 ` Auger Eric 2020-12-01 16:37 ` Auger Eric 2020-12-02 14:02 ` Alexandru Elisei 2020-12-02 14:02 ` Alexandru Elisei 2020-12-02 14:14 ` Alexandru Elisei 2020-12-02 14:14 ` Alexandru Elisei 2020-12-03 9:41 ` Auger Eric 2020-12-03 9:41 ` Auger Eric 2020-11-25 15:51 ` [kvm-unit-tests PATCH 04/10] arm/arm64: gic: Remove unnecessary synchronization with stats_reset() Alexandru Elisei 2020-11-25 15:51 ` Alexandru Elisei 2020-12-01 16:48 ` Auger Eric 2020-12-01 16:48 ` Auger Eric 2020-12-02 14:06 ` Alexandru Elisei 2020-12-02 14:06 ` Alexandru Elisei 2020-12-03 13:10 ` Auger Eric 2020-12-03 13:10 ` Auger Eric 2020-11-25 15:51 ` [kvm-unit-tests PATCH 05/10] arm/arm64: gic: Use correct memory ordering for the IPI test Alexandru Elisei 2020-11-25 15:51 ` Alexandru Elisei 2020-12-03 13:10 ` Auger Eric 2020-12-03 13:10 ` Auger Eric 2020-12-03 13:21 ` Alexandru Elisei 2020-12-03 13:21 ` Alexandru Elisei 2020-11-25 15:51 ` [kvm-unit-tests PATCH 06/10] arm/arm64: gic: Check spurious and bad_sender in the active test Alexandru Elisei 2020-11-25 15:51 ` Alexandru Elisei 2020-12-03 13:10 ` Auger Eric 2020-12-03 13:10 ` Auger Eric 2020-11-25 15:51 ` [kvm-unit-tests PATCH 07/10] arm/arm64: gic: Wait for writes to acked or spurious to complete Alexandru Elisei 2020-11-25 15:51 ` Alexandru Elisei 2020-12-03 13:21 ` Auger Eric 2020-12-03 13:21 ` Auger Eric 2020-11-25 15:51 ` [kvm-unit-tests PATCH 08/10] arm/arm64: gic: Split check_acked() into two functions Alexandru Elisei 2020-11-25 15:51 ` Alexandru Elisei 2020-12-03 13:39 ` Auger Eric 2020-12-03 13:39 ` Auger Eric 2020-12-10 14:45 ` Alexandru Elisei 2020-12-10 14:45 ` Alexandru Elisei 2020-12-15 13:58 ` Auger Eric 2020-12-15 13:58 ` Auger Eric 2020-12-16 11:40 ` Alexandru Elisei 2020-12-16 11:40 ` Alexandru Elisei 2020-12-16 12:37 ` Auger Eric [this message] 2020-12-16 12:37 ` Auger Eric 2020-11-25 15:51 ` [kvm-unit-tests PATCH 09/10] arm/arm64: gic: Make check_acked() more generic Alexandru Elisei 2020-11-25 15:51 ` Alexandru Elisei 2020-12-03 14:59 ` Auger Eric 2020-12-03 14:59 ` Auger Eric 2020-11-25 15:51 ` [kvm-unit-tests PATCH 10/10] arm64: gic: Use IPI test checking for the LPI tests Alexandru Elisei 2020-11-25 15:51 ` Alexandru Elisei 2020-11-26 9:30 ` Zenghui Yu 2020-11-26 9:30 ` Zenghui Yu 2020-11-27 14:50 ` Alexandru Elisei 2020-11-27 14:50 ` Alexandru Elisei 2020-11-30 13:59 ` Zenghui Yu 2020-11-30 13:59 ` Zenghui Yu 2020-11-30 14:19 ` Alexandru Elisei 2020-11-30 14:19 ` Alexandru Elisei 2020-12-01 15:09 ` Alexandru Elisei 2020-12-01 15:09 ` Alexandru Elisei 2020-11-30 17:48 ` Auger Eric 2020-11-30 17:48 ` Auger Eric 2020-12-03 14:59 ` Auger Eric 2020-12-03 14:59 ` Auger Eric 2020-12-09 10:29 ` Alexandru Elisei 2020-12-09 10:29 ` Alexandru Elisei
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=08ba32cf-0a6f-79d9-fb53-a84205cae4b1@redhat.com \ --to=eric.auger@redhat.com \ --cc=alexandru.elisei@arm.com \ --cc=andre.przywara@arm.com \ --cc=drjones@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.