From: Toshi Kani <toshi.kani@hp.com> To: Dan Williams <dan.j.williams@intel.com> Cc: linux-nvdimm@lists.01.org, Neil Brown <neilb@suse.de>, Greg KH <gregkh@linuxfoundation.org>, "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>, Robert Moore <robert.moore@intel.com>, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [Linux-nvdimm] [PATCH v2 05/20] libnd, nd_acpi: dimm/memory-devices Date: Fri, 01 May 2015 11:48:13 -0600 [thread overview] Message-ID: <1430502493.23761.145.camel@misato.fc.hp.com> (raw) In-Reply-To: <20150428182439.35812.81191.stgit@dwillia2-desk3.amr.corp.intel.com> On Tue, 2015-04-28 at 14:24 -0400, Dan Williams wrote: > Register the memory devices described in the nfit as libnd 'dimm' > devices on an nd bus. The kernel assigned device id for dimms is > dynamic. If userspace needs a more static identifier it should consult > a provider-specific attribute. In the case where NFIT is the provider, > the 'nmemX/nfit/handle' or 'nmemX/nfit/serial' attributes may be used > for this purpose. : > + > +static int nd_acpi_register_dimms(struct acpi_nfit_desc *acpi_desc) > +{ > + struct nfit_mem *nfit_mem; > + > + list_for_each_entry(nfit_mem, &acpi_desc->dimms, list) { > + struct nd_dimm *nd_dimm; > + unsigned long flags = 0; > + u32 nfit_handle; > + > + nfit_handle = __to_nfit_memdev(nfit_mem)->nfit_handle; > + nd_dimm = nd_acpi_dimm_by_handle(acpi_desc, nfit_handle); > + if (nd_dimm) { > + /* > + * If for some reason we find multiple DCRs the > + * first one wins > + */ > + dev_err(acpi_desc->dev, "duplicate DCR detected: %s\n", > + nd_dimm_name(nd_dimm)); > + continue; > + } > + > + if (nfit_mem->bdw && nfit_mem->memdev_pmem) > + flags |= NDD_ALIASING; Does this check work for a NVDIMM card which has multiple pmem regions with label info, but does not have any bdw region configured? The code assumes that namespace_pmem (NDD_ALIASING) and namespace_blk have label info. There may be an NVDIMM card with a single blk region without label info. Instead of using the namespace types to assume the label info, how about adding a flag to indicate the presence of the label info? This avoids the separation of namespace_io and namespace_pmem for the same pmem driver. Thanks, -Toshi
WARNING: multiple messages have this Message-ID (diff)
From: Toshi Kani <toshi.kani@hp.com> To: Dan Williams <dan.j.williams@intel.com> Cc: linux-nvdimm@ml01.01.org, Neil Brown <neilb@suse.de>, Greg KH <gregkh@linuxfoundation.org>, "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>, Robert Moore <robert.moore@intel.com>, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [Linux-nvdimm] [PATCH v2 05/20] libnd, nd_acpi: dimm/memory-devices Date: Fri, 01 May 2015 11:48:13 -0600 [thread overview] Message-ID: <1430502493.23761.145.camel@misato.fc.hp.com> (raw) In-Reply-To: <20150428182439.35812.81191.stgit@dwillia2-desk3.amr.corp.intel.com> On Tue, 2015-04-28 at 14:24 -0400, Dan Williams wrote: > Register the memory devices described in the nfit as libnd 'dimm' > devices on an nd bus. The kernel assigned device id for dimms is > dynamic. If userspace needs a more static identifier it should consult > a provider-specific attribute. In the case where NFIT is the provider, > the 'nmemX/nfit/handle' or 'nmemX/nfit/serial' attributes may be used > for this purpose. : > + > +static int nd_acpi_register_dimms(struct acpi_nfit_desc *acpi_desc) > +{ > + struct nfit_mem *nfit_mem; > + > + list_for_each_entry(nfit_mem, &acpi_desc->dimms, list) { > + struct nd_dimm *nd_dimm; > + unsigned long flags = 0; > + u32 nfit_handle; > + > + nfit_handle = __to_nfit_memdev(nfit_mem)->nfit_handle; > + nd_dimm = nd_acpi_dimm_by_handle(acpi_desc, nfit_handle); > + if (nd_dimm) { > + /* > + * If for some reason we find multiple DCRs the > + * first one wins > + */ > + dev_err(acpi_desc->dev, "duplicate DCR detected: %s\n", > + nd_dimm_name(nd_dimm)); > + continue; > + } > + > + if (nfit_mem->bdw && nfit_mem->memdev_pmem) > + flags |= NDD_ALIASING; Does this check work for a NVDIMM card which has multiple pmem regions with label info, but does not have any bdw region configured? The code assumes that namespace_pmem (NDD_ALIASING) and namespace_blk have label info. There may be an NVDIMM card with a single blk region without label info. Instead of using the namespace types to assume the label info, how about adding a flag to indicate the presence of the label info? This avoids the separation of namespace_io and namespace_pmem for the same pmem driver. Thanks, -Toshi
next prev parent reply other threads:[~2015-05-01 17:48 UTC|newest] Thread overview: 179+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-04-28 18:24 [PATCH v2 00/20] libnd: non-volatile memory device support Dan Williams 2015-04-28 18:24 ` Dan Williams 2015-04-28 18:24 ` [PATCH v2 01/20] e820, efi: add ACPI 6.0 persistent memory types Dan Williams 2015-04-28 18:24 ` Dan Williams 2015-04-28 20:49 ` Andy Lutomirski 2015-04-28 20:49 ` Andy Lutomirski 2015-04-28 20:57 ` Dan Williams 2015-04-28 20:57 ` Dan Williams 2015-04-28 21:05 ` Andy Lutomirski 2015-04-28 21:05 ` Andy Lutomirski 2015-05-15 15:43 ` [Linux-nvdimm] " Jeff Moyer 2015-05-15 15:48 ` Dan Williams 2015-05-18 19:28 ` Andy Lutomirski 2015-04-28 18:24 ` [PATCH v2 02/20] libnd, nd_acpi: initial libnd infrastructure and NFIT support Dan Williams 2015-04-28 18:24 ` Dan Williams 2015-04-30 23:23 ` Rafael J. Wysocki 2015-04-30 23:23 ` Rafael J. Wysocki 2015-05-01 0:39 ` Dan Williams 2015-05-01 0:39 ` Dan Williams 2015-05-01 1:21 ` Rafael J. Wysocki 2015-05-01 1:21 ` Rafael J. Wysocki 2015-05-01 16:23 ` Dan Williams 2015-05-01 16:23 ` Dan Williams 2015-05-04 23:58 ` Rafael J. Wysocki 2015-05-04 23:58 ` Rafael J. Wysocki 2015-05-04 23:46 ` Dan Williams 2015-05-04 23:46 ` Dan Williams 2015-05-15 19:44 ` [Linux-nvdimm] " Jeff Moyer 2015-05-15 20:41 ` Dan Williams 2015-04-28 18:24 ` [PATCH v2 03/20] nd_acpi, nfit-test: manufactured NFITs for interface development Dan Williams 2015-04-28 18:24 ` Dan Williams 2015-05-15 20:25 ` [Linux-nvdimm] " Jeff Moyer 2015-05-15 20:50 ` Dan Williams 2015-04-28 18:24 ` [PATCH v2 04/20] libnd: ndctl class device, and nd bus attributes Dan Williams 2015-04-28 18:24 ` Dan Williams 2015-05-15 21:00 ` [Linux-nvdimm] " Jeff Moyer 2015-04-28 18:24 ` [PATCH v2 05/20] libnd, nd_acpi: dimm/memory-devices Dan Williams 2015-04-28 18:24 ` Dan Williams 2015-05-01 17:48 ` Toshi Kani [this message] 2015-05-01 17:48 ` [Linux-nvdimm] " Toshi Kani 2015-05-01 18:22 ` Dan Williams 2015-05-01 18:22 ` Dan Williams 2015-05-01 18:19 ` Toshi Kani 2015-05-01 18:19 ` Toshi Kani 2015-05-01 18:43 ` Dan Williams 2015-05-01 18:43 ` Dan Williams 2015-05-01 19:15 ` Toshi Kani 2015-05-01 19:15 ` Toshi Kani 2015-05-01 19:38 ` Dan Williams 2015-05-01 19:38 ` Dan Williams 2015-05-01 20:08 ` Toshi Kani 2015-05-01 20:08 ` Toshi Kani 2015-04-28 18:24 ` [PATCH v2 06/20] libnd: ndctl.h, the nd ioctl abi Dan Williams 2015-04-28 18:24 ` Dan Williams 2015-04-28 18:24 ` [PATCH v2 07/20] libnd, nd_dimm: dimm driver and base libnd device-driver infrastructure Dan Williams 2015-04-28 18:24 ` Dan Williams 2015-05-20 16:59 ` [Linux-nvdimm] " Elliott, Robert (Server Storage) 2015-05-20 16:59 ` Elliott, Robert (Server Storage) 2015-05-20 17:02 ` Dan Williams 2015-05-20 17:02 ` Dan Williams 2015-04-28 18:24 ` [PATCH v2 08/20] libnd, nd_acpi: regions (block-data-window, persistent memory, volatile memory) Dan Williams 2015-04-28 18:24 ` Dan Williams 2015-04-29 15:53 ` [Linux-nvdimm] " Elliott, Robert (Server Storage) 2015-04-29 15:53 ` Elliott, Robert (Server Storage) 2015-04-29 15:59 ` Dan Williams 2015-04-29 15:59 ` Dan Williams 2015-05-04 20:26 ` Toshi Kani 2015-05-04 20:26 ` Toshi Kani 2015-05-09 23:55 ` Dan Williams 2015-05-09 23:55 ` Dan Williams 2015-05-28 18:36 ` Toshi Kani 2015-05-28 18:36 ` Toshi Kani 2015-05-28 19:59 ` Dan Williams 2015-05-28 19:59 ` Dan Williams 2015-05-28 20:51 ` Linda Knippers 2015-05-28 20:51 ` Linda Knippers 2015-05-28 20:58 ` Dan Williams 2015-05-28 20:58 ` Dan Williams 2015-04-28 18:25 ` [PATCH v2 09/20] libnd: support for legacy (non-aliasing) nvdimms Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-04-28 18:25 ` [PATCH v2 10/20] pmem: use ida Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-04-29 18:25 ` [Linux-nvdimm] " Toshi Kani 2015-04-29 18:25 ` Toshi Kani 2015-04-29 18:59 ` Dan Williams 2015-04-29 18:59 ` Dan Williams 2015-04-29 18:53 ` Toshi Kani 2015-04-29 18:53 ` Toshi Kani 2015-04-29 20:49 ` Linda Knippers 2015-04-29 20:49 ` Linda Knippers 2015-04-29 21:36 ` Dan Williams 2015-04-29 21:36 ` Dan Williams 2015-04-28 18:25 ` [PATCH v2 11/20] libnd, nd_pmem: add libnd support to the pmem driver Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-04-28 21:04 ` Andy Lutomirski 2015-04-28 21:04 ` Andy Lutomirski 2015-04-28 22:21 ` [Linux-nvdimm] " Phil Pokorny 2015-04-28 22:21 ` Phil Pokorny 2015-04-28 22:58 ` Andy Lutomirski 2015-04-28 22:58 ` Andy Lutomirski 2015-04-29 0:17 ` Phil Pokorny 2015-04-29 0:17 ` Phil Pokorny 2015-04-29 0:28 ` Andy Lutomirski 2015-04-29 0:28 ` Andy Lutomirski 2015-04-29 15:55 ` Dan Williams 2015-04-29 15:55 ` Dan Williams 2015-04-29 18:36 ` Andy Lutomirski 2015-04-29 18:36 ` Andy Lutomirski 2015-04-28 18:25 ` [PATCH v2 12/20] libnd, nd_acpi: add interleave-set state-tracking infrastructure Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-04-28 18:25 ` [PATCH v2 13/20] libnd: namespace indices: read and validate Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-04-28 18:25 ` [PATCH v2 14/20] libnd: pmem label sets and namespace instantiation Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-04-28 18:25 ` [PATCH v2 15/20] libnd: blk labels " Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-04-28 18:25 ` [PATCH v2 16/20] libnd: write pmem label set Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-04-28 18:25 ` [PATCH v2 17/20] libnd: write blk " Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-04-28 18:25 ` [PATCH v2 18/20] libnd: infrastructure for btt devices Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-05-12 16:33 ` [Linux-nvdimm] " Toshi Kani 2015-05-12 16:33 ` Toshi Kani 2015-05-15 0:41 ` Dan Williams 2015-05-15 0:41 ` Dan Williams 2015-05-15 4:25 ` Elliott, Robert (Server Storage) 2015-05-15 4:25 ` Elliott, Robert (Server Storage) 2015-04-28 18:25 ` [PATCH v2 19/20] nd_btt: atomic sector updates Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-05-17 1:19 ` [Linux-nvdimm] " Elliott, Robert (Server Storage) 2015-05-17 1:19 ` Elliott, Robert (Server Storage) 2015-05-17 3:22 ` Dan Williams 2015-05-17 3:22 ` Dan Williams 2015-05-20 17:20 ` Elliott, Robert (Server Storage) 2015-05-20 17:20 ` Elliott, Robert (Server Storage) 2015-05-18 22:38 ` Verma, Vishal L 2015-05-18 22:38 ` Verma, Vishal L 2015-04-28 18:26 ` [PATCH v2 20/20] libnd, nd_acpi, nd_blk: driver for BLK-mode access persistent memory Dan Williams 2015-04-28 18:26 ` Dan Williams 2015-04-28 21:10 ` Andy Lutomirski 2015-04-28 21:10 ` Andy Lutomirski 2015-04-28 22:30 ` Dan Williams 2015-04-28 22:30 ` Dan Williams 2015-04-28 23:06 ` Andy Lutomirski 2015-04-28 23:06 ` Andy Lutomirski 2015-04-29 17:10 ` Dan Williams 2015-04-29 17:10 ` Dan Williams 2015-04-29 19:28 ` Andy Lutomirski 2015-04-29 19:28 ` Andy Lutomirski 2015-04-28 20:52 ` [PATCH v2 00/20] libnd: non-volatile memory device support Andy Lutomirski 2015-04-28 20:52 ` Andy Lutomirski 2015-04-28 20:59 ` Dan Williams 2015-04-28 20:59 ` Dan Williams 2015-04-28 21:06 ` Andy Lutomirski 2015-04-28 21:06 ` Andy Lutomirski 2015-04-28 22:28 ` Dan Williams 2015-04-28 22:28 ` Dan Williams 2015-04-28 23:05 ` Andy Lutomirski 2015-04-28 23:05 ` Andy Lutomirski 2015-04-30 20:56 ` Ross Zwisler 2015-04-30 20:56 ` Ross Zwisler 2015-04-28 21:24 ` [Linux-nvdimm] " Elliott, Robert (Server Storage) 2015-04-28 21:24 ` Elliott, Robert (Server Storage) 2015-04-28 22:15 ` Dan Williams 2015-04-28 22:15 ` Dan Williams 2015-05-07 7:29 ` Christoph Hellwig 2015-05-07 7:29 ` Christoph Hellwig 2015-04-29 0:25 ` Rafael J. Wysocki 2015-04-29 0:25 ` Rafael J. Wysocki 2015-04-29 1:22 ` Dan Williams 2015-04-29 1:22 ` Dan Williams 2015-04-29 1:22 ` Dan Williams 2015-05-05 0:06 ` Rafael J. Wysocki 2015-05-05 0:06 ` Rafael J. Wysocki 2015-05-05 0:06 ` Rafael J. Wysocki 2015-05-08 6:31 ` Williams, Dan J 2015-05-08 6:31 ` Williams, Dan J 2015-05-08 6:31 ` Williams, Dan J
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1430502493.23761.145.camel@misato.fc.hp.com \ --to=toshi.kani@hp.com \ --cc=dan.j.williams@intel.com \ --cc=gregkh@linuxfoundation.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ --cc=neilb@suse.de \ --cc=rafael.j.wysocki@intel.com \ --cc=robert.moore@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.