From: Andy Lutomirski <luto@amacapital.net> To: Dan Williams <dan.j.williams@intel.com> Cc: linux-nvdimm <linux-nvdimm@lists.01.org>, Ingo Molnar <mingo@kernel.org>, Boaz Harrosh <boaz@plexistor.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Jens Axboe <axboe@fb.com>, "H. Peter Anvin" <hpa@zytor.com>, Christoph Hellwig <hch@lst.de> Subject: Re: [PATCH v2 11/20] libnd, nd_pmem: add libnd support to the pmem driver Date: Tue, 28 Apr 2015 14:04:06 -0700 [thread overview] Message-ID: <CALCETrVLoJj6f72MraEZ3dUA9Mgr8fK17Yw-ACT7pvfB9nZ4MA@mail.gmail.com> (raw) In-Reply-To: <20150428182514.35812.12126.stgit@dwillia2-desk3.amr.corp.intel.com> On Tue, Apr 28, 2015 at 11:25 AM, Dan Williams <dan.j.williams@intel.com> wrote: > nd_pmem attaches to persistent memory regions and namespaces emitted by > the nd subsystem, and, same as the original pmem driver, presents the > system-physical-address range as a block device. > > The existing e820-type-12 to pmem setup is converted to a full libnd bus > that emits an nd_namespace_io device. Now that I think I understand what's going on, can I propose alternate help-text wording? [reordered the quotes] > +config BLK_DEV_PMEM > + tristate "PMEM: Persistent memory block device support" > + depends on LIBND > + default LIBND > + help > + Memory ranges for PMEM are described by either an NFIT > + (NVDIMM Firmware Interface Table, see CONFIG_NFIT_ACPI), a > + non-standard OEM-specific E820 memory type (type-12, see > + CONFIG_X86_PMEM_LEGACY), or it is manually specified by the > + 'memmap=nn[KMG]!ss[KMG]' kernel command line (see > + Documentation/kernel-parameters.txt). This driver converts > + these persistent memory ranges into block devices that are > + capable of DAX (direct-access) file system mappings. See > + Documentation/blockdev/nd.txt for more details. How about something like: "This driver exposes memory devices that expose byte-addressable nonvolatile storage as block devices. This type of block device supports direct access (i.e. DAX) if an appropriate filesystem is used. This driver requires a libnd driver that supports the memory device being used." Then there would be a sub-menu with the legacy and NFIT drivers. (Or, if this isn't actually configurable that way, then there could be a reference to what needs to be configured to make this work.) > +config ND_E820 > + tristate "E820: Support the E820-type-12 PMEM convention" > + depends on X86_PMEM_LEGACY > + default m if X86_PMEM_LEGACY > + select LIBND > + help > + Prior to ACPI 6 some platforms advertised peristent memory > + via type-12 e820 memory ranges. Create a libnd bus and > + attach an instance of the pmem driver to these ranges. > + How about something like: "This driver allows libnd to work with legacy, pre-ACPI 6 NVDIMMs. This enables such devices to be exposed as block devices using PMEM. The legacy NVDIMM interface is problematic. This driver will not work if you boot using UEFI, and some NVDIMMs and motherboards that work with this driver may require proprietary code in order to work reliably." --Andy
WARNING: multiple messages have this Message-ID (diff)
From: Andy Lutomirski <luto@amacapital.net> To: Dan Williams <dan.j.williams@intel.com> Cc: linux-nvdimm <linux-nvdimm@ml01.01.org>, Ingo Molnar <mingo@kernel.org>, Boaz Harrosh <boaz@plexistor.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Jens Axboe <axboe@fb.com>, "H. Peter Anvin" <hpa@zytor.com>, Christoph Hellwig <hch@lst.de> Subject: Re: [PATCH v2 11/20] libnd, nd_pmem: add libnd support to the pmem driver Date: Tue, 28 Apr 2015 14:04:06 -0700 [thread overview] Message-ID: <CALCETrVLoJj6f72MraEZ3dUA9Mgr8fK17Yw-ACT7pvfB9nZ4MA@mail.gmail.com> (raw) In-Reply-To: <20150428182514.35812.12126.stgit@dwillia2-desk3.amr.corp.intel.com> On Tue, Apr 28, 2015 at 11:25 AM, Dan Williams <dan.j.williams@intel.com> wrote: > nd_pmem attaches to persistent memory regions and namespaces emitted by > the nd subsystem, and, same as the original pmem driver, presents the > system-physical-address range as a block device. > > The existing e820-type-12 to pmem setup is converted to a full libnd bus > that emits an nd_namespace_io device. Now that I think I understand what's going on, can I propose alternate help-text wording? [reordered the quotes] > +config BLK_DEV_PMEM > + tristate "PMEM: Persistent memory block device support" > + depends on LIBND > + default LIBND > + help > + Memory ranges for PMEM are described by either an NFIT > + (NVDIMM Firmware Interface Table, see CONFIG_NFIT_ACPI), a > + non-standard OEM-specific E820 memory type (type-12, see > + CONFIG_X86_PMEM_LEGACY), or it is manually specified by the > + 'memmap=nn[KMG]!ss[KMG]' kernel command line (see > + Documentation/kernel-parameters.txt). This driver converts > + these persistent memory ranges into block devices that are > + capable of DAX (direct-access) file system mappings. See > + Documentation/blockdev/nd.txt for more details. How about something like: "This driver exposes memory devices that expose byte-addressable nonvolatile storage as block devices. This type of block device supports direct access (i.e. DAX) if an appropriate filesystem is used. This driver requires a libnd driver that supports the memory device being used." Then there would be a sub-menu with the legacy and NFIT drivers. (Or, if this isn't actually configurable that way, then there could be a reference to what needs to be configured to make this work.) > +config ND_E820 > + tristate "E820: Support the E820-type-12 PMEM convention" > + depends on X86_PMEM_LEGACY > + default m if X86_PMEM_LEGACY > + select LIBND > + help > + Prior to ACPI 6 some platforms advertised peristent memory > + via type-12 e820 memory ranges. Create a libnd bus and > + attach an instance of the pmem driver to these ranges. > + How about something like: "This driver allows libnd to work with legacy, pre-ACPI 6 NVDIMMs. This enables such devices to be exposed as block devices using PMEM. The legacy NVDIMM interface is problematic. This driver will not work if you boot using UEFI, and some NVDIMMs and motherboards that work with this driver may require proprietary code in order to work reliably." --Andy
next prev parent reply other threads:[~2015-04-28 21:04 UTC|newest] Thread overview: 179+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-04-28 18:24 [PATCH v2 00/20] libnd: non-volatile memory device support Dan Williams 2015-04-28 18:24 ` Dan Williams 2015-04-28 18:24 ` [PATCH v2 01/20] e820, efi: add ACPI 6.0 persistent memory types Dan Williams 2015-04-28 18:24 ` Dan Williams 2015-04-28 20:49 ` Andy Lutomirski 2015-04-28 20:49 ` Andy Lutomirski 2015-04-28 20:57 ` Dan Williams 2015-04-28 20:57 ` Dan Williams 2015-04-28 21:05 ` Andy Lutomirski 2015-04-28 21:05 ` Andy Lutomirski 2015-05-15 15:43 ` [Linux-nvdimm] " Jeff Moyer 2015-05-15 15:48 ` Dan Williams 2015-05-18 19:28 ` Andy Lutomirski 2015-04-28 18:24 ` [PATCH v2 02/20] libnd, nd_acpi: initial libnd infrastructure and NFIT support Dan Williams 2015-04-28 18:24 ` Dan Williams 2015-04-30 23:23 ` Rafael J. Wysocki 2015-04-30 23:23 ` Rafael J. Wysocki 2015-05-01 0:39 ` Dan Williams 2015-05-01 0:39 ` Dan Williams 2015-05-01 1:21 ` Rafael J. Wysocki 2015-05-01 1:21 ` Rafael J. Wysocki 2015-05-01 16:23 ` Dan Williams 2015-05-01 16:23 ` Dan Williams 2015-05-04 23:58 ` Rafael J. Wysocki 2015-05-04 23:58 ` Rafael J. Wysocki 2015-05-04 23:46 ` Dan Williams 2015-05-04 23:46 ` Dan Williams 2015-05-15 19:44 ` [Linux-nvdimm] " Jeff Moyer 2015-05-15 20:41 ` Dan Williams 2015-04-28 18:24 ` [PATCH v2 03/20] nd_acpi, nfit-test: manufactured NFITs for interface development Dan Williams 2015-04-28 18:24 ` Dan Williams 2015-05-15 20:25 ` [Linux-nvdimm] " Jeff Moyer 2015-05-15 20:50 ` Dan Williams 2015-04-28 18:24 ` [PATCH v2 04/20] libnd: ndctl class device, and nd bus attributes Dan Williams 2015-04-28 18:24 ` Dan Williams 2015-05-15 21:00 ` [Linux-nvdimm] " Jeff Moyer 2015-04-28 18:24 ` [PATCH v2 05/20] libnd, nd_acpi: dimm/memory-devices Dan Williams 2015-04-28 18:24 ` Dan Williams 2015-05-01 17:48 ` [Linux-nvdimm] " Toshi Kani 2015-05-01 17:48 ` Toshi Kani 2015-05-01 18:22 ` Dan Williams 2015-05-01 18:22 ` Dan Williams 2015-05-01 18:19 ` Toshi Kani 2015-05-01 18:19 ` Toshi Kani 2015-05-01 18:43 ` Dan Williams 2015-05-01 18:43 ` Dan Williams 2015-05-01 19:15 ` Toshi Kani 2015-05-01 19:15 ` Toshi Kani 2015-05-01 19:38 ` Dan Williams 2015-05-01 19:38 ` Dan Williams 2015-05-01 20:08 ` Toshi Kani 2015-05-01 20:08 ` Toshi Kani 2015-04-28 18:24 ` [PATCH v2 06/20] libnd: ndctl.h, the nd ioctl abi Dan Williams 2015-04-28 18:24 ` Dan Williams 2015-04-28 18:24 ` [PATCH v2 07/20] libnd, nd_dimm: dimm driver and base libnd device-driver infrastructure Dan Williams 2015-04-28 18:24 ` Dan Williams 2015-05-20 16:59 ` [Linux-nvdimm] " Elliott, Robert (Server Storage) 2015-05-20 16:59 ` Elliott, Robert (Server Storage) 2015-05-20 17:02 ` Dan Williams 2015-05-20 17:02 ` Dan Williams 2015-04-28 18:24 ` [PATCH v2 08/20] libnd, nd_acpi: regions (block-data-window, persistent memory, volatile memory) Dan Williams 2015-04-28 18:24 ` Dan Williams 2015-04-29 15:53 ` [Linux-nvdimm] " Elliott, Robert (Server Storage) 2015-04-29 15:53 ` Elliott, Robert (Server Storage) 2015-04-29 15:59 ` Dan Williams 2015-04-29 15:59 ` Dan Williams 2015-05-04 20:26 ` Toshi Kani 2015-05-04 20:26 ` Toshi Kani 2015-05-09 23:55 ` Dan Williams 2015-05-09 23:55 ` Dan Williams 2015-05-28 18:36 ` Toshi Kani 2015-05-28 18:36 ` Toshi Kani 2015-05-28 19:59 ` Dan Williams 2015-05-28 19:59 ` Dan Williams 2015-05-28 20:51 ` Linda Knippers 2015-05-28 20:51 ` Linda Knippers 2015-05-28 20:58 ` Dan Williams 2015-05-28 20:58 ` Dan Williams 2015-04-28 18:25 ` [PATCH v2 09/20] libnd: support for legacy (non-aliasing) nvdimms Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-04-28 18:25 ` [PATCH v2 10/20] pmem: use ida Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-04-29 18:25 ` [Linux-nvdimm] " Toshi Kani 2015-04-29 18:25 ` Toshi Kani 2015-04-29 18:59 ` Dan Williams 2015-04-29 18:59 ` Dan Williams 2015-04-29 18:53 ` Toshi Kani 2015-04-29 18:53 ` Toshi Kani 2015-04-29 20:49 ` Linda Knippers 2015-04-29 20:49 ` Linda Knippers 2015-04-29 21:36 ` Dan Williams 2015-04-29 21:36 ` Dan Williams 2015-04-28 18:25 ` [PATCH v2 11/20] libnd, nd_pmem: add libnd support to the pmem driver Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-04-28 21:04 ` Andy Lutomirski [this message] 2015-04-28 21:04 ` Andy Lutomirski 2015-04-28 22:21 ` [Linux-nvdimm] " Phil Pokorny 2015-04-28 22:21 ` Phil Pokorny 2015-04-28 22:58 ` Andy Lutomirski 2015-04-28 22:58 ` Andy Lutomirski 2015-04-29 0:17 ` Phil Pokorny 2015-04-29 0:17 ` Phil Pokorny 2015-04-29 0:28 ` Andy Lutomirski 2015-04-29 0:28 ` Andy Lutomirski 2015-04-29 15:55 ` Dan Williams 2015-04-29 15:55 ` Dan Williams 2015-04-29 18:36 ` Andy Lutomirski 2015-04-29 18:36 ` Andy Lutomirski 2015-04-28 18:25 ` [PATCH v2 12/20] libnd, nd_acpi: add interleave-set state-tracking infrastructure Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-04-28 18:25 ` [PATCH v2 13/20] libnd: namespace indices: read and validate Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-04-28 18:25 ` [PATCH v2 14/20] libnd: pmem label sets and namespace instantiation Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-04-28 18:25 ` [PATCH v2 15/20] libnd: blk labels " Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-04-28 18:25 ` [PATCH v2 16/20] libnd: write pmem label set Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-04-28 18:25 ` [PATCH v2 17/20] libnd: write blk " Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-04-28 18:25 ` [PATCH v2 18/20] libnd: infrastructure for btt devices Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-05-12 16:33 ` [Linux-nvdimm] " Toshi Kani 2015-05-12 16:33 ` Toshi Kani 2015-05-15 0:41 ` Dan Williams 2015-05-15 0:41 ` Dan Williams 2015-05-15 4:25 ` Elliott, Robert (Server Storage) 2015-05-15 4:25 ` Elliott, Robert (Server Storage) 2015-04-28 18:25 ` [PATCH v2 19/20] nd_btt: atomic sector updates Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-05-17 1:19 ` [Linux-nvdimm] " Elliott, Robert (Server Storage) 2015-05-17 1:19 ` Elliott, Robert (Server Storage) 2015-05-17 3:22 ` Dan Williams 2015-05-17 3:22 ` Dan Williams 2015-05-20 17:20 ` Elliott, Robert (Server Storage) 2015-05-20 17:20 ` Elliott, Robert (Server Storage) 2015-05-18 22:38 ` Verma, Vishal L 2015-05-18 22:38 ` Verma, Vishal L 2015-04-28 18:26 ` [PATCH v2 20/20] libnd, nd_acpi, nd_blk: driver for BLK-mode access persistent memory Dan Williams 2015-04-28 18:26 ` Dan Williams 2015-04-28 21:10 ` Andy Lutomirski 2015-04-28 21:10 ` Andy Lutomirski 2015-04-28 22:30 ` Dan Williams 2015-04-28 22:30 ` Dan Williams 2015-04-28 23:06 ` Andy Lutomirski 2015-04-28 23:06 ` Andy Lutomirski 2015-04-29 17:10 ` Dan Williams 2015-04-29 17:10 ` Dan Williams 2015-04-29 19:28 ` Andy Lutomirski 2015-04-29 19:28 ` Andy Lutomirski 2015-04-28 20:52 ` [PATCH v2 00/20] libnd: non-volatile memory device support Andy Lutomirski 2015-04-28 20:52 ` Andy Lutomirski 2015-04-28 20:59 ` Dan Williams 2015-04-28 20:59 ` Dan Williams 2015-04-28 21:06 ` Andy Lutomirski 2015-04-28 21:06 ` Andy Lutomirski 2015-04-28 22:28 ` Dan Williams 2015-04-28 22:28 ` Dan Williams 2015-04-28 23:05 ` Andy Lutomirski 2015-04-28 23:05 ` Andy Lutomirski 2015-04-30 20:56 ` Ross Zwisler 2015-04-30 20:56 ` Ross Zwisler 2015-04-28 21:24 ` [Linux-nvdimm] " Elliott, Robert (Server Storage) 2015-04-28 21:24 ` Elliott, Robert (Server Storage) 2015-04-28 22:15 ` Dan Williams 2015-04-28 22:15 ` Dan Williams 2015-05-07 7:29 ` Christoph Hellwig 2015-05-07 7:29 ` Christoph Hellwig 2015-04-29 0:25 ` Rafael J. Wysocki 2015-04-29 0:25 ` Rafael J. Wysocki 2015-04-29 1:22 ` Dan Williams 2015-04-29 1:22 ` Dan Williams 2015-04-29 1:22 ` Dan Williams 2015-05-05 0:06 ` Rafael J. Wysocki 2015-05-05 0:06 ` Rafael J. Wysocki 2015-05-05 0:06 ` Rafael J. Wysocki 2015-05-08 6:31 ` Williams, Dan J 2015-05-08 6:31 ` Williams, Dan J 2015-05-08 6:31 ` Williams, Dan J
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CALCETrVLoJj6f72MraEZ3dUA9Mgr8fK17Yw-ACT7pvfB9nZ4MA@mail.gmail.com \ --to=luto@amacapital.net \ --cc=axboe@fb.com \ --cc=boaz@plexistor.com \ --cc=dan.j.williams@intel.com \ --cc=hch@lst.de \ --cc=hpa@zytor.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ --cc=mingo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.