From: Dan Williams <dan.j.williams@intel.com> To: Andy Lutomirski <luto@amacapital.net> Cc: linux-nvdimm <linux-nvdimm@lists.01.org>, Ingo Molnar <mingo@kernel.org>, Boaz Harrosh <boaz@plexistor.com>, Andrew Morton <akpm@linux-foundation.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@fb.com>, Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>, Matthew Wilcox <willy@linux.intel.com>, Thomas Gleixner <tglx@linutronix.de>, Linus Torvalds <torvalds@linux-foundation.org>, Ross Zwisler <ross.zwisler@linux.intel.com> Subject: Re: [PATCH v2 01/20] e820, efi: add ACPI 6.0 persistent memory types Date: Tue, 28 Apr 2015 13:57:25 -0700 [thread overview] Message-ID: <CAPcyv4h3w2V6iNDbwddQzrV+jdT06m28O1_H6cj7y2B9i1gZTA@mail.gmail.com> (raw) In-Reply-To: <CALCETrWq4NYqYomAVDZB6NBheLp-zA6yJXmcN244skYweAGaBg@mail.gmail.com> On Tue, Apr 28, 2015 at 1:49 PM, Andy Lutomirski <luto@amacapital.net> wrote: > On Tue, Apr 28, 2015 at 11:24 AM, Dan Williams <dan.j.williams@intel.com> wrote: >> diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c >> index 11cc7d54ec3f..d38b53a7e9b2 100644 >> --- a/arch/x86/kernel/e820.c >> +++ b/arch/x86/kernel/e820.c >> @@ -149,6 +149,7 @@ static void __init e820_print_type(u32 type) >> case E820_UNUSABLE: >> printk(KERN_CONT "unusable"); >> break; >> + case E820_PMEM: >> case E820_PRAM: >> printk(KERN_CONT "persistent (type %u)", type); >> break; > > I'd kind of like to make it more clear what's going on here. It > doesn't help that the spec chose poor names. > > How about "NVDIMM physical aperture" for E820_PMEM and "legacy > persistent RAM" for E820_PRAM? The term "aperture" to me implies this BLK (mmio-windowed) mode of accessing persistent media that the NFIT specification introduces. In fact, those ranges are mapped E820_RESERVED. E820_PMEM really is a memory range that happens to be persistent. > Otherwise this looks generaly sensible, although I don't really > understand why e820_type_to_string and e820_print_type are different. e820_type_to_string() appears in /proc/iomem and seems to afford being more descriptive than e820_print_type() that just scrolls by in dmesg, but I'm just guessing.
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com> To: Andy Lutomirski <luto@amacapital.net> Cc: linux-nvdimm <linux-nvdimm@ml01.01.org>, Ingo Molnar <mingo@kernel.org>, Boaz Harrosh <boaz@plexistor.com>, Andrew Morton <akpm@linux-foundation.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@fb.com>, Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>, Matthew Wilcox <willy@linux.intel.com>, Thomas Gleixner <tglx@linutronix.de>, Linus Torvalds <torvalds@linux-foundation.org>, Ross Zwisler <ross.zwisler@linux.intel.com> Subject: Re: [PATCH v2 01/20] e820, efi: add ACPI 6.0 persistent memory types Date: Tue, 28 Apr 2015 13:57:25 -0700 [thread overview] Message-ID: <CAPcyv4h3w2V6iNDbwddQzrV+jdT06m28O1_H6cj7y2B9i1gZTA@mail.gmail.com> (raw) In-Reply-To: <CALCETrWq4NYqYomAVDZB6NBheLp-zA6yJXmcN244skYweAGaBg@mail.gmail.com> On Tue, Apr 28, 2015 at 1:49 PM, Andy Lutomirski <luto@amacapital.net> wrote: > On Tue, Apr 28, 2015 at 11:24 AM, Dan Williams <dan.j.williams@intel.com> wrote: >> diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c >> index 11cc7d54ec3f..d38b53a7e9b2 100644 >> --- a/arch/x86/kernel/e820.c >> +++ b/arch/x86/kernel/e820.c >> @@ -149,6 +149,7 @@ static void __init e820_print_type(u32 type) >> case E820_UNUSABLE: >> printk(KERN_CONT "unusable"); >> break; >> + case E820_PMEM: >> case E820_PRAM: >> printk(KERN_CONT "persistent (type %u)", type); >> break; > > I'd kind of like to make it more clear what's going on here. It > doesn't help that the spec chose poor names. > > How about "NVDIMM physical aperture" for E820_PMEM and "legacy > persistent RAM" for E820_PRAM? The term "aperture" to me implies this BLK (mmio-windowed) mode of accessing persistent media that the NFIT specification introduces. In fact, those ranges are mapped E820_RESERVED. E820_PMEM really is a memory range that happens to be persistent. > Otherwise this looks generaly sensible, although I don't really > understand why e820_type_to_string and e820_print_type are different. e820_type_to_string() appears in /proc/iomem and seems to afford being more descriptive than e820_print_type() that just scrolls by in dmesg, but I'm just guessing.
next prev parent reply other threads:[~2015-04-28 20:57 UTC|newest] Thread overview: 179+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-04-28 18:24 [PATCH v2 00/20] libnd: non-volatile memory device support Dan Williams 2015-04-28 18:24 ` Dan Williams 2015-04-28 18:24 ` [PATCH v2 01/20] e820, efi: add ACPI 6.0 persistent memory types Dan Williams 2015-04-28 18:24 ` Dan Williams 2015-04-28 20:49 ` Andy Lutomirski 2015-04-28 20:49 ` Andy Lutomirski 2015-04-28 20:57 ` Dan Williams [this message] 2015-04-28 20:57 ` Dan Williams 2015-04-28 21:05 ` Andy Lutomirski 2015-04-28 21:05 ` Andy Lutomirski 2015-05-15 15:43 ` [Linux-nvdimm] " Jeff Moyer 2015-05-15 15:48 ` Dan Williams 2015-05-18 19:28 ` Andy Lutomirski 2015-04-28 18:24 ` [PATCH v2 02/20] libnd, nd_acpi: initial libnd infrastructure and NFIT support Dan Williams 2015-04-28 18:24 ` Dan Williams 2015-04-30 23:23 ` Rafael J. Wysocki 2015-04-30 23:23 ` Rafael J. Wysocki 2015-05-01 0:39 ` Dan Williams 2015-05-01 0:39 ` Dan Williams 2015-05-01 1:21 ` Rafael J. Wysocki 2015-05-01 1:21 ` Rafael J. Wysocki 2015-05-01 16:23 ` Dan Williams 2015-05-01 16:23 ` Dan Williams 2015-05-04 23:58 ` Rafael J. Wysocki 2015-05-04 23:58 ` Rafael J. Wysocki 2015-05-04 23:46 ` Dan Williams 2015-05-04 23:46 ` Dan Williams 2015-05-15 19:44 ` [Linux-nvdimm] " Jeff Moyer 2015-05-15 20:41 ` Dan Williams 2015-04-28 18:24 ` [PATCH v2 03/20] nd_acpi, nfit-test: manufactured NFITs for interface development Dan Williams 2015-04-28 18:24 ` Dan Williams 2015-05-15 20:25 ` [Linux-nvdimm] " Jeff Moyer 2015-05-15 20:50 ` Dan Williams 2015-04-28 18:24 ` [PATCH v2 04/20] libnd: ndctl class device, and nd bus attributes Dan Williams 2015-04-28 18:24 ` Dan Williams 2015-05-15 21:00 ` [Linux-nvdimm] " Jeff Moyer 2015-04-28 18:24 ` [PATCH v2 05/20] libnd, nd_acpi: dimm/memory-devices Dan Williams 2015-04-28 18:24 ` Dan Williams 2015-05-01 17:48 ` [Linux-nvdimm] " Toshi Kani 2015-05-01 17:48 ` Toshi Kani 2015-05-01 18:22 ` Dan Williams 2015-05-01 18:22 ` Dan Williams 2015-05-01 18:19 ` Toshi Kani 2015-05-01 18:19 ` Toshi Kani 2015-05-01 18:43 ` Dan Williams 2015-05-01 18:43 ` Dan Williams 2015-05-01 19:15 ` Toshi Kani 2015-05-01 19:15 ` Toshi Kani 2015-05-01 19:38 ` Dan Williams 2015-05-01 19:38 ` Dan Williams 2015-05-01 20:08 ` Toshi Kani 2015-05-01 20:08 ` Toshi Kani 2015-04-28 18:24 ` [PATCH v2 06/20] libnd: ndctl.h, the nd ioctl abi Dan Williams 2015-04-28 18:24 ` Dan Williams 2015-04-28 18:24 ` [PATCH v2 07/20] libnd, nd_dimm: dimm driver and base libnd device-driver infrastructure Dan Williams 2015-04-28 18:24 ` Dan Williams 2015-05-20 16:59 ` [Linux-nvdimm] " Elliott, Robert (Server Storage) 2015-05-20 16:59 ` Elliott, Robert (Server Storage) 2015-05-20 17:02 ` Dan Williams 2015-05-20 17:02 ` Dan Williams 2015-04-28 18:24 ` [PATCH v2 08/20] libnd, nd_acpi: regions (block-data-window, persistent memory, volatile memory) Dan Williams 2015-04-28 18:24 ` Dan Williams 2015-04-29 15:53 ` [Linux-nvdimm] " Elliott, Robert (Server Storage) 2015-04-29 15:53 ` Elliott, Robert (Server Storage) 2015-04-29 15:59 ` Dan Williams 2015-04-29 15:59 ` Dan Williams 2015-05-04 20:26 ` Toshi Kani 2015-05-04 20:26 ` Toshi Kani 2015-05-09 23:55 ` Dan Williams 2015-05-09 23:55 ` Dan Williams 2015-05-28 18:36 ` Toshi Kani 2015-05-28 18:36 ` Toshi Kani 2015-05-28 19:59 ` Dan Williams 2015-05-28 19:59 ` Dan Williams 2015-05-28 20:51 ` Linda Knippers 2015-05-28 20:51 ` Linda Knippers 2015-05-28 20:58 ` Dan Williams 2015-05-28 20:58 ` Dan Williams 2015-04-28 18:25 ` [PATCH v2 09/20] libnd: support for legacy (non-aliasing) nvdimms Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-04-28 18:25 ` [PATCH v2 10/20] pmem: use ida Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-04-29 18:25 ` [Linux-nvdimm] " Toshi Kani 2015-04-29 18:25 ` Toshi Kani 2015-04-29 18:59 ` Dan Williams 2015-04-29 18:59 ` Dan Williams 2015-04-29 18:53 ` Toshi Kani 2015-04-29 18:53 ` Toshi Kani 2015-04-29 20:49 ` Linda Knippers 2015-04-29 20:49 ` Linda Knippers 2015-04-29 21:36 ` Dan Williams 2015-04-29 21:36 ` Dan Williams 2015-04-28 18:25 ` [PATCH v2 11/20] libnd, nd_pmem: add libnd support to the pmem driver Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-04-28 21:04 ` Andy Lutomirski 2015-04-28 21:04 ` Andy Lutomirski 2015-04-28 22:21 ` [Linux-nvdimm] " Phil Pokorny 2015-04-28 22:21 ` Phil Pokorny 2015-04-28 22:58 ` Andy Lutomirski 2015-04-28 22:58 ` Andy Lutomirski 2015-04-29 0:17 ` Phil Pokorny 2015-04-29 0:17 ` Phil Pokorny 2015-04-29 0:28 ` Andy Lutomirski 2015-04-29 0:28 ` Andy Lutomirski 2015-04-29 15:55 ` Dan Williams 2015-04-29 15:55 ` Dan Williams 2015-04-29 18:36 ` Andy Lutomirski 2015-04-29 18:36 ` Andy Lutomirski 2015-04-28 18:25 ` [PATCH v2 12/20] libnd, nd_acpi: add interleave-set state-tracking infrastructure Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-04-28 18:25 ` [PATCH v2 13/20] libnd: namespace indices: read and validate Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-04-28 18:25 ` [PATCH v2 14/20] libnd: pmem label sets and namespace instantiation Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-04-28 18:25 ` [PATCH v2 15/20] libnd: blk labels " Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-04-28 18:25 ` [PATCH v2 16/20] libnd: write pmem label set Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-04-28 18:25 ` [PATCH v2 17/20] libnd: write blk " Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-04-28 18:25 ` [PATCH v2 18/20] libnd: infrastructure for btt devices Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-05-12 16:33 ` [Linux-nvdimm] " Toshi Kani 2015-05-12 16:33 ` Toshi Kani 2015-05-15 0:41 ` Dan Williams 2015-05-15 0:41 ` Dan Williams 2015-05-15 4:25 ` Elliott, Robert (Server Storage) 2015-05-15 4:25 ` Elliott, Robert (Server Storage) 2015-04-28 18:25 ` [PATCH v2 19/20] nd_btt: atomic sector updates Dan Williams 2015-04-28 18:25 ` Dan Williams 2015-05-17 1:19 ` [Linux-nvdimm] " Elliott, Robert (Server Storage) 2015-05-17 1:19 ` Elliott, Robert (Server Storage) 2015-05-17 3:22 ` Dan Williams 2015-05-17 3:22 ` Dan Williams 2015-05-20 17:20 ` Elliott, Robert (Server Storage) 2015-05-20 17:20 ` Elliott, Robert (Server Storage) 2015-05-18 22:38 ` Verma, Vishal L 2015-05-18 22:38 ` Verma, Vishal L 2015-04-28 18:26 ` [PATCH v2 20/20] libnd, nd_acpi, nd_blk: driver for BLK-mode access persistent memory Dan Williams 2015-04-28 18:26 ` Dan Williams 2015-04-28 21:10 ` Andy Lutomirski 2015-04-28 21:10 ` Andy Lutomirski 2015-04-28 22:30 ` Dan Williams 2015-04-28 22:30 ` Dan Williams 2015-04-28 23:06 ` Andy Lutomirski 2015-04-28 23:06 ` Andy Lutomirski 2015-04-29 17:10 ` Dan Williams 2015-04-29 17:10 ` Dan Williams 2015-04-29 19:28 ` Andy Lutomirski 2015-04-29 19:28 ` Andy Lutomirski 2015-04-28 20:52 ` [PATCH v2 00/20] libnd: non-volatile memory device support Andy Lutomirski 2015-04-28 20:52 ` Andy Lutomirski 2015-04-28 20:59 ` Dan Williams 2015-04-28 20:59 ` Dan Williams 2015-04-28 21:06 ` Andy Lutomirski 2015-04-28 21:06 ` Andy Lutomirski 2015-04-28 22:28 ` Dan Williams 2015-04-28 22:28 ` Dan Williams 2015-04-28 23:05 ` Andy Lutomirski 2015-04-28 23:05 ` Andy Lutomirski 2015-04-30 20:56 ` Ross Zwisler 2015-04-30 20:56 ` Ross Zwisler 2015-04-28 21:24 ` [Linux-nvdimm] " Elliott, Robert (Server Storage) 2015-04-28 21:24 ` Elliott, Robert (Server Storage) 2015-04-28 22:15 ` Dan Williams 2015-04-28 22:15 ` Dan Williams 2015-05-07 7:29 ` Christoph Hellwig 2015-05-07 7:29 ` Christoph Hellwig 2015-04-29 0:25 ` Rafael J. Wysocki 2015-04-29 0:25 ` Rafael J. Wysocki 2015-04-29 1:22 ` Dan Williams 2015-04-29 1:22 ` Dan Williams 2015-04-29 1:22 ` Dan Williams 2015-05-05 0:06 ` Rafael J. Wysocki 2015-05-05 0:06 ` Rafael J. Wysocki 2015-05-05 0:06 ` Rafael J. Wysocki 2015-05-08 6:31 ` Williams, Dan J 2015-05-08 6:31 ` Williams, Dan J 2015-05-08 6:31 ` Williams, Dan J
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAPcyv4h3w2V6iNDbwddQzrV+jdT06m28O1_H6cj7y2B9i1gZTA@mail.gmail.com \ --to=dan.j.williams@intel.com \ --cc=akpm@linux-foundation.org \ --cc=axboe@fb.com \ --cc=boaz@plexistor.com \ --cc=bp@alien8.de \ --cc=hch@lst.de \ --cc=hpa@zytor.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ --cc=luto@amacapital.net \ --cc=mingo@kernel.org \ --cc=ross.zwisler@linux.intel.com \ --cc=tglx@linutronix.de \ --cc=torvalds@linux-foundation.org \ --cc=willy@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.