All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] Add support for Mini2440
@ 2012-04-16 17:46 Gabriel Huau
  2012-04-17 20:09 ` [U-Boot] [PATCH V2] " Gabriel Huau
  2012-04-19 19:25 ` [U-Boot] [PATCH v3] " Gabriel Huau
  0 siblings, 2 replies; 42+ messages in thread
From: Gabriel Huau @ 2012-04-16 17:46 UTC (permalink / raw)
  To: u-boot

Hi all,

This is a first patch to introduce the support of the Mini2440. It's a
board based on the S3C2440, arm920t. I based the support on the code of
BusError (old version of u-boot).

I have a few work to do again, like some clean up in the configuration
file. Currently, with this patch, we can boot from NOR and the network
is available (tftp, dhcp, ...). Boot from NAND will be the next step
(and laters MMC). 

Best regards,

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot]  [PATCH V2] Add support for Mini2440
  2012-04-16 17:46 [U-Boot] Add support for Mini2440 Gabriel Huau
@ 2012-04-17 20:09 ` Gabriel Huau
       [not found]   ` <1334694802-4881-1-git-send-email-contact@huau-gabriel.fr>
  2012-04-19 19:25 ` [U-Boot] [PATCH v3] " Gabriel Huau
  1 sibling, 1 reply; 42+ messages in thread
From: Gabriel Huau @ 2012-04-17 20:09 UTC (permalink / raw)
  To: u-boot

A little review of my first patch. As you can see, I removed some
unnecessary modifications that I did in arm920t directory ... (I don't
really remember why I did it), and some modifications on drivers (nand
and i2c) that was unnecessary because I am not currently supporting
theses features.

I forget to say in my first mail that is a porting from an old version
of u-boot patched by BusError (Michel Pollet). 

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v2] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
       [not found]   ` <1334694802-4881-1-git-send-email-contact@huau-gabriel.fr>
@ 2012-04-17 20:45     ` Marek Vasut
  0 siblings, 0 replies; 42+ messages in thread
From: Marek Vasut @ 2012-04-17 20:45 UTC (permalink / raw)
  To: u-boot

Dear Gabriel Huau,

> ---
> Changes for v2:
> 	- Coding style cleanup
> 	- Remove unnecessary files modification
> 	- Remove unnecessary board configuration set
> ---
>  arch/arm/include/asm/arch-s3c24x0/s3c24x0.h |   51 +-----
>  board/friendlyarm/mini2440/Makefile         |   45 +++++
>  board/friendlyarm/mini2440/lowlevel_init.S  |  177 +++++++++++++++++
>  board/friendlyarm/mini2440/mini2440.c       |  283
> +++++++++++++++++++++++++++ boards.cfg                                  | 
>   1 +
>  include/configs/mini2440.h                  |  203 +++++++++++++++++++
>  6 files changed, 710 insertions(+), 50 deletions(-)
>  create mode 100644 board/friendlyarm/mini2440/Makefile
>  create mode 100644 board/friendlyarm/mini2440/lowlevel_init.S
>  create mode 100644 board/friendlyarm/mini2440/mini2440.c
>  create mode 100644 include/configs/mini2440.h
> 
> diff --git a/arch/arm/include/asm/arch-s3c24x0/s3c24x0.h
> b/arch/arm/include/asm/arch-s3c24x0/s3c24x0.h index ca978c9..96e623b
> 100644
> --- a/arch/arm/include/asm/arch-s3c24x0/s3c24x0.h
> +++ b/arch/arm/include/asm/arch-s3c24x0/s3c24x0.h
> @@ -416,7 +416,7 @@ struct s3c24x0_gpio {
>  	u32	misccr;
>  	u32	extint;
>  #endif
> -#ifdef CONFIG_S3C2410
> +#if defined(CONFIG_S3C2410) || defined(CONFIG_S3C2440)
>  	u32	gpacon;
>  	u32	gpadat;
>  	u32	res1[2];
> @@ -467,55 +467,6 @@ struct s3c24x0_gpio {
>  	u32	gstatus4;
>  #endif
>  #if defined(CONFIG_S3C2440)
> -	u32	gpacon;
> -	u32	gpadat;
> -	u32	res1[2];
> -	u32	gpbcon;
> -	u32	gpbdat;
> -	u32	gpbup;
> -	u32	res2;
> -	u32	gpccon;
> -	u32	gpcdat;
> -	u32	gpcup;
> -	u32	res3;
> -	u32	gpdcon;
> -	u32	gpddat;
> -	u32	gpdup;
> -	u32	res4;
> -	u32	gpecon;
> -	u32	gpedat;
> -	u32	gpeup;
> -	u32	res5;
> -	u32	gpfcon;
> -	u32	gpfdat;
> -	u32	gpfup;
> -	u32	res6;
> -	u32	gpgcon;
> -	u32	gpgdat;
> -	u32	gpgup;
> -	u32	res7;
> -	u32	gphcon;
> -	u32	gphdat;
> -	u32	gphup;
> -	u32	res8;
> -
> -	u32	misccr;
> -	u32	dclkcon;
> -	u32	extint0;
> -	u32	extint1;
> -	u32	extint2;
> -	u32	eintflt0;
> -	u32	eintflt1;
> -	u32	eintflt2;
> -	u32	eintflt3;
> -	u32	eintmask;
> -	u32	eintpend;
> -	u32	gstatus0;
> -	u32	gstatus1;
> -	u32	gstatus2;
> -	u32	gstatus3;
> -	u32	gstatus4;
> -

Why did you drop this? Also, put this in a separate patch please ...

>  	u32	res9;
>  	u32	dsc0;
>  	u32	dsc1;
> diff --git a/board/friendlyarm/mini2440/Makefile
> b/board/friendlyarm/mini2440/Makefile new file mode 100644
> index 0000000..065f1db
> --- /dev/null
> +++ b/board/friendlyarm/mini2440/Makefile
> @@ -0,0 +1,45 @@
> +#
> +# (C) Copyright 2000-2006

2012 ;-)

> +# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
> +#
> +# See file CREDITS for list of people who contributed to this
> +# project.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation; either version 2 of
> +# the License, or (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write to the Free Software
> +# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> +# MA 02111-1307 USA
> +#
> +
> +include $(TOPDIR)/config.mk
> +
> +LIB	= $(obj)lib$(BOARD).o
> +
> +COBJS	:= mini2440.o
> +SOBJS	:= lowlevel_init.o
> +
> +SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
> +OBJS	:= $(addprefix $(obj),$(COBJS))
> +SOBJS	:= $(addprefix $(obj),$(SOBJS))
> +
> +$(LIB):	$(obj).depend $(OBJS) $(SOBJS)
> +	$(call cmd_link_o_target, $(OBJS) $(SOBJS))
> +
> +#########################################################################
> +
> +# defines $(obj).depend target
> +include $(SRCTREE)/rules.mk
> +
> +sinclude $(obj).depend
> +
> +#########################################################################
> diff --git a/board/friendlyarm/mini2440/lowlevel_init.S
> b/board/friendlyarm/mini2440/lowlevel_init.S new file mode 100644
> index 0000000..2a057ea
> --- /dev/null
> +++ b/board/friendlyarm/mini2440/lowlevel_init.S
> @@ -0,0 +1,177 @@
> +/*
> + * Memory Setup stuff - taken from blob memsetup.S
> + *
> + * Copyright (C) 1999 2000 2001 Erik Mouw (J.A.K.Mouw at its.tudelft.nl) and
> + *                     Jan-Derk Bakker (J.D.Bakker at its.tudelft.nl)
> + *
> + * Modified for the Samsung SMDK2410 by
> + * (C) Copyright 2002
> + * David Mueller, ELSOFT AG, <d.mueller@elsoft.ch>

Your name is missing

> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#include <config.h>
> +#include <version.h>
> +
> +/*
> + * Taken from linux/arch/arm/boot/compressed/head-s3c2410.S
> + * Copyright (C) 2002 Samsung Electronics SW.LEE 
> <hitchcar@sec.samsung.com> + */
> +
> +#define BWSCON      0x48000000
> +#define INTMSK      0x4A000008	/* Interupt-Controller base addresses */
> +#define INTSUBMSK   0x4A00001C
> +
> +/* BWSCON */
> +#define DW8			(0x0)
> +#define DW16		(0x1)
> +#define DW32		(0x2)
> +#define WAIT		(0x1<<2)
> +#define UBLB		(0x1<<3)
> +
> +#define B1_BWSCON		(DW32)
> +#define B2_BWSCON		(DW16)
> +#define B3_BWSCON		(DW16 + WAIT + UBLB)
> +#define B4_BWSCON		(DW16 + WAIT + UBLB)
> +#define B5_BWSCON		(DW16)
> +#define B6_BWSCON		(DW32)
> +#define B7_BWSCON		(DW32)
> +
> +/* BANK0CON */
> +#define B0_Tacs			0x0	/*  0clk */
> +#define B0_Tcos			0x0	/*  0clk */
> +#define B0_Tacc			0x7	/* 14clk */
> +#define B0_Tcoh			0x0	/*  0clk */
> +#define B0_Tah			0x0	/*  0clk */
> +#define B0_Tacp			0x0
> +#define B0_PMC			0x0	/* normal */
> +
> +/* BANK1CON */
> +#define B1_Tacs			0x0	/*  0clk */
> +#define B1_Tcos			0x0	/*  0clk */
> +#define B1_Tacc			0x7	/* 14clk */
> +#define B1_Tcoh			0x0	/*  0clk */
> +#define B1_Tah			0x0	/*  0clk */
> +#define B1_Tacp			0x0
> +#define B1_PMC			0x0
> +
> +#define B2_Tacs			0x0
> +#define B2_Tcos			0x0
> +#define B2_Tacc			0x7
> +#define B2_Tcoh			0x0
> +#define B2_Tah			0x0
> +#define B2_Tacp			0x0
> +#define B2_PMC			0x0
> +
> +#define B3_Tacs			0x0	/*  0clk */
> +#define B3_Tcos			0x3	/*  4clk */
> +#define B3_Tacc			0x7	/* 14clk */
> +#define B3_Tcoh			0x1	/*  1clk */
> +#define B3_Tah			0x3	/*  4clk */
> +#define B3_Tacp			0x0 /*  2clk */
> +#define B3_PMC			0x0	/* normal */
> +
> +#define B4_Tacs			0x0
> +#define B4_Tcos			0x3
> +#define B4_Tacc			0x7
> +#define B4_Tcoh			0x1
> +#define B4_Tah			0x3
> +#define B4_Tacp			0x0
> +#define B4_PMC			0x0
> +
> +#define B5_Tacs			0x0	/*  0clk */
> +#define B5_Tcos			0x0	/*  0clk */
> +#define B5_Tacc			0x7	/* 14clk */
> +#define B5_Tcoh			0x0	/*  0clk */
> +#define B5_Tah			0x0	/*  0clk */
> +#define B5_Tacp			0x0
> +#define B5_PMC			0x0	/* normal */
> +
> +#define SDRAM_MT		0x3	/* SDRAM */
> +#define SDRAM_Trcd		0x0	/* 2clk */
> +#define SDRAM_SCAN_9		0x1	/* 9bit */
> +#define SDRAM_SCAN_10		0x2	/* 10bit */
> +
> +#define SDRAM_128MB	((SDRAM_MT<<15)+(SDRAM_Trcd<<2)+(SDRAM_SCAN_10))
> +#define SDRAM_64MB	((SDRAM_MT<<15)+(SDRAM_Trcd<<2)+(SDRAM_SCAN_9))
> +
> +/* REFRESH parameter */
> +#define REFEN			0x1	/* Refresh enable */
> +#define TREFMD			0x0	/* CBR(CAS before RAS)/Auto 
refresh */
> +#define Trp			0x1	/* 3clk */
> +#define Trc			0x3	/* 7clk */
> +#define Tchr			0x0	/* unused */
> +
> +#define REFCNT			1012	/* period=10.37us, HCLK=100Mhz, 
(2048+1-10.37*100)

Either move this to header or make this start.S generic.

> */ +
> +_TEXT_BASE:
> +	.word	CONFIG_SYS_TEXT_BASE
> +
> +.globl lowlevel_init
> +lowlevel_init:
> +	// disable all interupts

The gas can crunch such c++ comments?

> +	mov	r1, #0xffffffff
> +	ldr	r0, =INTMSK
> +	str	r1, [r0]
> +
> +	ldr	r1, =0x7fff
> +	ldr	r0, =INTSUBMSK
> +	str	r1, [r0]
> +
> +	/* memory control configuration */
> +	/* make r0 relative the current location so that it */
> +	/* reads SMRDATA out of FLASH rather than memory ! */
> +	ldr     r0, =SMRDATA
> +	ldr	r1, _TEXT_BASE
> +	sub	r0, r0, r1
> +	ldr	r1, =BWSCON	/* Bus Width Status Controller */
> +	add     r2, r0, #13*4
> +0:
> +	ldr     r3, [r0], #4
> +	str     r3, [r1], #4
> +	cmp     r2, r0
> +	bne     0b
> +
> +	/*
> +	 * SDRAM configuration for 64MB
> +	 */
> +	ldr	r1, =BWSCON+(7*4)
> +	ldr	r0, =SDRAM_64MB
> +	str	r0, [r1], #4
> +	str	r0, [r1]
> +return:
> +	/* everything is fine now */
> +	mov	pc, lr
> +
> +	.ltorg
> +SMRDATA:
> +    .word
> (0+(B1_BWSCON<<4)+(B2_BWSCON<<8)+(B3_BWSCON<<12)+(B4_BWSCON<<16)+(B5_BWSCO
> N<<20)+(B6_BWSCON<<24)+(B7_BWSCON<<28)) +    .word
> ((B0_Tacs<<13)+(B0_Tcos<<11)+(B0_Tacc<<8)+(B0_Tcoh<<6)+(B0_Tah<<4)+(B0_Tac
> p<<2)+(B0_PMC)) +    .word
> ((B1_Tacs<<13)+(B1_Tcos<<11)+(B1_Tacc<<8)+(B1_Tcoh<<6)+(B1_Tah<<4)+(B1_Tac
> p<<2)+(B1_PMC)) +    .word
> ((B2_Tacs<<13)+(B2_Tcos<<11)+(B2_Tacc<<8)+(B2_Tcoh<<6)+(B2_Tah<<4)+(B2_Tac
> p<<2)+(B2_PMC)) +    .word
> ((B3_Tacs<<13)+(B3_Tcos<<11)+(B3_Tacc<<8)+(B3_Tcoh<<6)+(B3_Tah<<4)+(B3_Tac
> p<<2)+(B3_PMC)) +    .word
> ((B4_Tacs<<13)+(B4_Tcos<<11)+(B4_Tacc<<8)+(B4_Tcoh<<6)+(B4_Tah<<4)+(B4_Tac
> p<<2)+(B4_PMC)) +    .word
> ((B5_Tacs<<13)+(B5_Tcos<<11)+(B5_Tacc<<8)+(B5_Tcoh<<6)+(B5_Tah<<4)+(B5_Tac
> p<<2)+(B5_PMC)) +    .word SDRAM_128MB
> +    .word SDRAM_128MB

SDRAM128? You had SDRAM64 there before ...

> +    .word ((REFEN<<23)+(TREFMD<<22)+(Trp<<20)+(Trc<<18)+(Tchr<<16)+REFCNT)
> +    .word 0xb2 /* enable burst */
> +    .word 0x30
> +    .word 0x30
> diff --git a/board/friendlyarm/mini2440/mini2440.c
> b/board/friendlyarm/mini2440/mini2440.c new file mode 100644
> index 0000000..ecfb519
> --- /dev/null
> +++ b/board/friendlyarm/mini2440/mini2440.c
> @@ -0,0 +1,283 @@
> +/*
> + * (C) Copyright 2002
> + * Sysgo Real-Time Solutions, GmbH <www.elinos.com>
> + * Marius Groeger <mgroeger@sysgo.de>
> + *
> + * (C) Copyright 2002
> + * David Mueller, ELSOFT AG, <d.mueller@elsoft.ch>
> + *
> + * (C) Copyright 2009
> + * Michel Pollet <buserror@gmail.com>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#include <common.h>
> +#include <asm/arch/s3c2440.h>
> +#include <video_fb.h>
> +
> +#ifdef CONFIG_DRIVER_DM9000
> +#include <netdev.h>
> +#endif
> +
> +DECLARE_GLOBAL_DATA_PTR;
> +
> +/* FCLK = 405 MHz, HCLK = 101 MHz, PCLK = 50 MHz, UCLK = 48 MHz */
> +#define CLKDIVN_VAL	7
> +#define M_MDIV		0x7f
> +#define M_PDIV		0x2
> +#define M_SDIV		0x1
> +
> +#define U_M_MDIV	0x38
> +#define U_M_PDIV	0x2
> +#define U_M_SDIV	0x2
> +
> +#define MVAL		(0)
> +#define MVAL_USED	(0)		//0=each frame   1=rate by MVAL
> +#define INVVDEN		(1)		//0=normal       1=inverted
> +#define BSWP		(0)		//Byte swap control
> +#define HWSWP		(1)		//Half word swap control

C++ comments, move this stuff to separate define too ?

> +
> +//TFT 240320
> +#define LCD_XSIZE_TFT_240320	(240)
> +#define LCD_YSIZE_TFT_240320	(320)
> +
> +//TFT240320
> +#define HOZVAL_TFT_240320	(LCD_XSIZE_TFT_240320-1)
> +#define LINEVAL_TFT_240320	(LCD_YSIZE_TFT_240320-1)
> +
> +//Timing parameter for NEC3.5"
> +#define VBPD_240320		(3)
> +#define VFPD_240320		(10)
> +#define VSPW_240320		(1)
> +
> +#define HBPD_240320		(5)
> +#define HFPD_240320		(2)
> +#define HSPW_240320		(36)
> +
> +#define CLKVAL_TFT_240320	(3)
> +
> +static inline void delay (unsigned long loops)
> +{
> +	__asm__ volatile ("1:\n"
> +			"subs %0, %1, #1\n"
> +			"bne 1b":"=r" (loops):"0" (loops));

Why do you need this?

> +}
> +
> +int arch_cpu_init (void)
> +{
> +	struct s3c24x0_clock_power * const clk_power =
> s3c24x0_get_base_clock_power(); +	int i;
> +
> +	/* to reduce PLL lock time, adjust the LOCKTIME register */
> +	clk_power->locktime = 0xFFFFFF;
> +	clk_power->clkdivn = CLKDIVN_VAL;
> +
> +	/* configure UPLL */
> +	clk_power->upllcon = ((U_M_MDIV << 12) + (U_M_PDIV << 4) + U_M_SDIV);
> +	/* some delay between MPLL and UPLL */
> +	for(i = 0; i < 100000; i++);

This will be opt-out by GCC under certain conditions, unless you put membarrier 
here ... which is not what you want to do -- just add simple udelay() here ?

> +
> +	/* configure MPLL */
> +	clk_power->mpllcon = ((M_MDIV << 12) + (M_PDIV << 4) + M_SDIV);
> +
> +	/* some delay between MPLL and UPLL */
> +	for(i = 0; i < 500000; i++);
> +
> +	return 0;
> +}
> +
> +/*
> + * Miscellaneous platform dependent initialisations
> + */
> +int board_init (void)
> +{
> +	struct s3c24x0_clock_power * const clk_power =
> s3c24x0_get_base_clock_power(); +	struct s3c24x0_gpio * const gpio =
> s3c24x0_get_base_gpio();
> +
> +	/* to reduce PLL lock time, adjust the LOCKTIME register */
> +	clk_power->locktime = 0xFFFFFF;
> +	clk_power->clkdivn = CLKDIVN_VAL;
> +
> +	/* configure UPLL */
> +	clk_power->upllcon = ((U_M_MDIV << 12) + (U_M_PDIV << 4) + U_M_SDIV);
> +	/* some delay between MPLL and UPLL */
> +	delay (10);
> +	/* configure MPLL */
> +	clk_power->mpllcon = ((M_MDIV << 12) + (M_PDIV << 4) + M_SDIV);
> +
> +	/* some delay between MPLL and UPLL */
> +	delay (8000);
> +
> +	gpio->gpacon = 0x007FFFFF;	/* Port A is all "special" */
> +	// port B outputs reconfigured
> +	gpio->gpbcon =
> +		(0x1 <<  0) | // GPB0	OUT	TOUT0		PWM Buzzer
> +		(0x2 <<  2) | // GPB1	OUT	TOUT1		LCD Backlight
> +		(0x1 <<  4) | // GPB2	OUT	L3MODE
> +		(0x1 <<  6) | // GBP3	OUT	L3DATA
> +		(0x1 <<  8) | // GBP4	OUT	L3CLOCK
> +		(0x1 << 10) | // GBP5	OUT	LED1
> +		(0x1 << 12) | // GBP6	OUT	LED2
> +		(0x1 << 14) | // GBP7	OUT	LED3
> +		(0x1 << 16) | // GBP8	OUT	LED4
> +		(0x2 << 18) | // GBP9	---	nXDACK0		CON5 EBI
> +		(0x2 << 20) | // GBP10	---	nXDREQ0		CON5 EBI
> +		0;
> +	gpio->gpbup	= (1 << 10) - 1; // disable pullup on all 10 pins
> +	gpio->gpbdat	=
> +		(0 << 5) | /* turn LED 1 on */
> +		(1 << 6) | /* turn LED 1 off */
> +		(1 << 7) | /* turn LED 1 off */
> +		(1 << 8) | /* turn LED 1 off */
> +		0;
> +
> +	// lcd signals on C and D

Did you run this through ./tools/checkpatch.pl ?

> +	gpio->gpccon	= (0xAAAAAAAA &	/* all default IN but ... */
> +			~(0x3 << 10)) |	/* not pin 5 ... */
> +		(0x1 << 10);	/* that is output (USBD) */
> +	gpio->gpcup	= 0xFFFFFFFF;
> +	gpio->gpcdat	= 0;
> +
> +	gpio->gpdcon	= 0xAAAAAAAA;
> +	gpio->gpdup	= 0xFFFFFFFF;
> +	// port E is set for all it's special functions (i2c, spi etc)
> +	gpio->gpecon	= 0xAAAAAAAA;
> +	gpio->gpeup	= 0x0000FFFF;
> +
> +	gpio->gpfcon	=
> +		(0x1 <<  0) | // GPG0	EINT0	OUT
> +		(0x1 <<  2) | // GPG1	EINT1	OUT
> +		(0x1 <<  4) | // GPG2	EINT2	OUT
> +		(0x1 <<  6) | // GPG3	EINT3	OUT
> +		(0x1 <<  8) | // GPG4	EINT4	OUT
> +		(0x1 << 10) | // GPG5	EINT5	OUT
> +		(0x1 << 12) | // GPG6	EINT6	OUT
> +		(0x0 << 14) | // GPG7	EINT7	IN	DM9000
> +		0;
> +	gpio->gpfdat	= 0;
> +	gpio->gpfup	=
> +		((1 << 7) - 1) // all disabled
> +		& ~( 1 << 7 ) // but for the ethernet one, we need it.
> +		;

Friendship is magic, that's true ... but magic doesn't make good friendship ;-D

> +	gpio->gpgcon	=
> +		(0x0 <<  0) | // GPG0	EINT8	IN	Key1
> +		(0x1 <<  2) | // GPG1	EINT9	OUT		Con5
> +		(0x1 <<  4) | // GPG2	EINT10	OUT
> +		(0x0 <<  6) | // GPG3	EINT11	IN	Key2
> +		(0x0 <<  8) | // GPG4	EINT12	IN	Smart Screen Interrupt
> +		(0x0 << 10) | // GPG5	EINT13	IN	Key3
> +		(0x0 << 12) | // GPG6	EINT14	IN	Key4
> +		(0x0 << 14) | // GPG7	EINT15	IN	Key5
> +		(0x1 << 16) | // GPG8	EINT16	OUT	nCD_SD
> +		(0x1 << 18) | // GPG9	EINT17	OUT
> +		(0x1 << 20) | // GPG10	EINT18	OUT
> +		(0x0 << 22) | // GPG11	EINT19	IN	Key6
> +		(0x0 << 24) | // GPG12	EINT18	IN	// GPG[12..15] need to 
be inputs
> +		(0x0 << 26) | // GPG13	EINT18	IN	// hard pullups
> +		(0x0 << 28) | // GPG14	EINT18	IN
> +		(0x0 << 30) | // GPG15	EINT18	IN
> +		0;
> +	gpio->gpgup = (1 << 15) -1;	// disable pullups for all pins
> +
> +	gpio->gphcon =
> +		(0x2 <<  0) | // GPH0	nCTS0			---
> +		(0x2 <<  2) | // GPH1	nRTS0			---
> +		(0x2 <<  4) | // GPH2	TXD0			---
> +		(0x2 <<  6) | // GPH3	RXD0			---
> +		(0x2 <<  8) | // GPH4	TXD1			---
> +		(0x2 << 10) | // GPH5	RXD1			---
> +		(0x2 << 12) | // GPH6	[TXD2]	nRTS1
> +		(0x2 << 14) | // GPH7	[RXD2]	nCTS1
> +		(0x1 << 16) | // GPH8	UEXTCLK			OUT
> +		(0x1 << 18) | // GPH9	CLKOUT0			OUT
> +		(0x1 << 20) | // GPH10	CLKOUT1			OUT
> +		0;
> +	gpio->gphup = (1 << 10) - 1; // disable pullups for all pins
> +
> +	gpio->extint0=0x22222222;
> +	gpio->extint1=0x22222222;
> +	gpio->extint2=0x22222222;
> +
> +	/* USB Device Part */
> +	/* GPC5 is reset for USB Device */
> +	gpio->gpcdat |= ( 1 << 5) ;
> +	udelay(20000);
> +	gpio->gpcdat &= ~( 1 << 5) ;
> +	udelay(20000);
> +	gpio->gpcdat |= ( 1 << 5) ;

Drop the magic bloat, replace with #defined stuff in header files.

> +
> +	/* arch number from kernel post 2.6.28 */
> +#ifndef MACH_TYPE_MINI2440
> +#define MACH_TYPE_MINI2440 1999
> +#endif

#define MACH_TYPE ... see eg. include/configs/m28evk.h and arch/arm/lib/board.c, 
you can drop it all.

> +	gd->bd->bi_arch_number = MACH_TYPE_MINI2440;
> +
> +	/* adress of boot parameters */
> +	gd->bd->bi_boot_params = 0x30000100;
> +
> +	return 0;
> +}
> +
> +void board_video_init(GraphicDevice *pGD)
> +{
> +	struct s3c24x0_lcd * const lcd = s3c24x0_get_base_lcd();
> +
> +	/* FIXME: select LCM type by env variable */
> +	/* Configuration for GTA01 LCM on QT2410 */
> +	lcd->lcdcon1 = 0x00000378; /* CLKVAL=4, BPPMODE=16bpp, TFT, ENVID=0 */
> +	lcd->lcdcon5 = 0x00000f09;
> +
> +	lcd->lcdcon2 =
> (VBPD_240320<<24)|(LINEVAL_TFT_240320<<14)|(VFPD_240320<<6)|(VSPW_240320);
> +	lcd->lcdcon3 = (HBPD_240320<<19)|(HOZVAL_TFT_240320<<8)|(HFPD_240320);
> +	lcd->lcdcon4 = (MVAL<<8)|(HSPW_240320);
> +
> +	lcd->lpcsel  = 0x00000000;
> +}
> +
> +void dram_init_banksize (void)
> +{
> +	struct s3c24x0_memctl * const mem = s3c24x0_get_base_memctl();
> +	gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
> +	/* if the early bootloader found 128MB, lets tell the kernel */
> +	if ((mem->bankcon[6] & 0x3) == 0x2)
> +		gd->bd->bi_dram[0].size = 128*1024*1024;
> +	else
> +		gd->bd->bi_dram[0].size = 64*1024*1024;

Magic bloat, fix.

> +}
> +
> +int dram_init (void)
> +{
> +	gd->ram_size = 64*1024*1024;
> +	return 0;
> +}
> +
> +int board_eth_init(bd_t *bis)
> +{
> +#ifdef CONFIG_DRIVER_DM9000
> +	return dm9000_initialize(bis);
> +#else
> +	return 0;
> +#endif
> +}
> +
> +/* The sum of all part_size[]s must equal to the NAND size, i.e.,
> 0x4000000 */ +unsigned int dynpart_size[] = { 0x40000, 0x20000, 0x500000,
> 0xffffffff, 0 }; +char *dynpart_names[] = { "u-boot", "u-boot_env",
> "kernel", "rootfs", NULL }; diff --git a/boards.cfg b/boards.cfg
> index 3cf75c3..93eeb3c 100644
> --- a/boards.cfg
> +++ b/boards.cfg
> @@ -61,6 +61,7 @@ mx1ads                       arm         arm920t     -   
>                - scb9328                      arm         arm920t     -   
>                -              imx cm4008                       arm        
> arm920t     -                   -              ks8695 cm41xx              
>         arm         arm920t     -                   -              ks8695
> +mini2440                     arm         arm920t     mini2440           
> friendlyarm    s3c24x0 VCMA9                        arm         arm920t   
>  vcma9               mpl            s3c24x0 smdk2410                    
> arm         arm920t     -                   samsung        s3c24x0
> omap1510inn                  arm         arm925t     -                  
> ti diff --git a/include/configs/mini2440.h b/include/configs/mini2440.h
> new file mode 100644
> index 0000000..8b04a76
> --- /dev/null
> +++ b/include/configs/mini2440.h
> @@ -0,0 +1,203 @@
> +/*
> + * (C) Copyright 2002
> + * Sysgo Real-Time Solutions, GmbH <www.elinos.com>
> + * Marius Groeger <mgroeger@sysgo.de>
> + * Gary Jennejohn <gj@denx.de>
> + * David Mueller <d.mueller@elsoft.ch>
> + *
> + * (C) Copyright 2009-2010
> + * Michel Pollet <buserror@gmail.com>
> + *
> + * (C) Copyright 2012
> + * Gabriel Huau <contact@huau-gabriel.fr>
> + *
> + * Configuation settings for the MINI2440 board.
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#ifndef __CONFIG_H
> +#define __CONFIG_H
> +
> +#define CONFIG_SYS_TEXT_BASE 0x0
> +
> +/*
> + * High Level Configuration Options
> + */
> +#define CONFIG_ARM920T		1	/* This is an ARM920T Core	
*/
> +#define	CONFIG_S3C24X0		1	/* in a SAMSUNG S3C2440 SoC     
*/
> +#define	CONFIG_S3C2440		1	/* in a SAMSUNG S3C2440 SoC    

Indent here is inconsistent!

> */
> +#define CONFIG_MINI2440		1	/* on a MIN2440 Board  */
> +
> +/*
> + * It is possible to have u-boot save it's environment in NOR, however,
> + * reember it is incompatible with booting from NAND as the NOR is not
> + * available at that point. So use this only if you use nand as storage
> + * and will never boot from it
> + */
> +#define CONFIG_MINI2440_NOR_ENV	1
> +#define CONFIG_MINI2440_OVERCLOCK 1	/* allow use of frequencies over
> 405Mhz */ +
> +/*
> + * input clock of PLL
> + */
> +#define CONFIG_SYS_CLK_FREQ	12000000	/* MINI2440 has 12.0000MHz input
> clock */ +#define CONFIG_ARCH_CPU_INIT 1 /* for the initialization of PLL
> */ +
> +#define USE_920T_MMU		1
> +#define CONFIG_BAUDRATE		115200
> +
> +/*
> + * Size of malloc() pool
> + */
> +#define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + 2048*1024)
> +#define CONFIG_GBL_DATA_SIZE	128	/* size in bytes reserved for initial
> data */ +
> +/*
> + * Hardware drivers
> + */
> +#define CONFIG_DRIVER_DM9000		1
> +#define CONFIG_DRIVER_DM9000_NO_EEPROM	1
> +#define CONFIG_DM9000_BASE		0x20000300
> +#define DM9000_IO			CONFIG_DM9000_BASE
> +#define DM9000_DATA			(CONFIG_DM9000_BASE+4)
> +
> +/*
> + * select serial console configuration
> + */
> +#define CONFIG_S3C24X0_SERIAL
> +#define CONFIG_SERIAL1          1	/* we use SERIAL 1 on MINI2440 */
> +
> +/*
> + * allow to overwrite serial and ethaddr
> + */
> +#define CONFIG_ENV_OVERWRITE
> +
> +/*
> + * Command definition
> + */
> +#include <config_cmd_default.h>
> +
> +#define CONFIG_CMD_DHCP
> +#define CONFIG_CMD_PORTIO
> +#define CONFIG_CMD_REGINFO
> +#define CONFIG_CMD_SAVES
> +
> +/*
> + * Miscellaneous configurable options
> + */
> +#define	CONFIG_LONGHELP				/* undef to save memory		
*/
> +#define	CONFIG_SYS_PROMPT		"MINI2440 # "	/* Monitor

Make this "=> "

> Command Prompt	*/
> +#define	CONFIG_SYS_CBSIZE		256		/* Console I/O 
Buffer Size	*/
> +#define	CONFIG_SYS_PBSIZE 
(CONFIG_SYS_CBSIZE+sizeof(CONFIG_SYS_PROMPT)+16)
> /* Print Buffer Size */ +#define	CONFIG_SYS_MAXARGS		32		
/* max number of
> command args	*/
> +#define CONFIG_SYS_BARGSIZE		CONFIG_SYS_CBSIZE	/* Boot Argument 
Buffer
> Size	*/ +
> +#define CONFIG_SYS_MEMTEST_START	0x30000000	/* memtest works on	
*/
> +#define CONFIG_SYS_MEMTEST_END		0x34000000	/* 64 MB in DRAM	
*/
> +
> +#undef  CONFIG_CLKS_IN_HZ		/* everything, incl board info, in Hz */
> +
> +#define	CONFIG_SYS_LOAD_ADDR		0x32000000	/* default load 
address	*/
> +
> +/*
> + * the PWM TImer 4 uses a counter of 15625 for 10 ms, so we need
> + * it to wrap 100 times (total 1562500) to get 1 sec.
> + */
> +#define	CONFIG_SYS_HZ			1562500
> +
> +/*
> + * valid baudrates
> + */
> +#define CONFIG_SYS_BAUDRATE_TABLE	{ 9600, 19200, 38400, 57600, 115200 }
> +
> +/*
> + * Stack sizes
> + * The stack sizes are set up in start.S using the settings below
> + */
> +#define CONFIG_STACKSIZE	(128*1024)	/* regular stack */
> +#ifdef CONFIG_USE_IRQ
> +#define CONFIG_STACKSIZE_IRQ	(8*1024)	/* IRQ stack */
> +#define CONFIG_STACKSIZE_FIQ	(4*1024)	/* FIQ stack */
> +#endif
> +
> +/*
> + * Physical Memory Map
> + */
> +#define CONFIG_NR_DRAM_BANKS        1          /* we have 1 bank of DRAM
> */ +#define PHYS_SDRAM_1                0x30000000 /* SDRAM Bank #1 */
> +#define CONFIG_SYS_SDRAM_BASE       PHYS_SDRAM_1
> +#define CONFIG_SYS_INIT_SP_ADDR		(CONFIG_SYS_SDRAM_BASE + 
0x100000 - \
> +					 GENERATED_GBL_DATA_SIZE)
> +
> +/*
> + * When booting from NAND, it is impossible to access the lowest addresses
> + * due to the SteppingStone being in the way. Luckily the NOR doesn't
> really + * care about the highest 16 bits of address, so we set the
> controlers + * registers to go and poke over there, instead.
> + */
> +#define PHYS_FLASH_1 0x0
> +#define CONFIG_SYS_FLASH_BASE		0x0
> +
> +/*
> + * NOR FLASH organization
> + * Now uses the standard CFI interface
> + * FLASH and environment organization
> + */
> +#define CONFIG_SYS_FLASH_CFI 1
> +#define CONFIG_FLASH_CFI_DRIVER	1
> +#define CONFIG_SYS_FLASH_CFI_WIDTH	FLASH_CFI_16BIT
> +#define CONFIG_SYS_MONITOR_BASE	0x0
> +#define CONFIG_SYS_MAX_FLASH_BANKS	1	/* max number of memory banks */
> +#define CONFIG_SYS_MAX_FLASH_SECT	512	/* 512 * 4096 sectors, or 32 * 
64k
> blocks */ +#define CONFIG_FLASH_SHOW_PROGRESS	1
> +
> +/*
> + * u-boot environmnent
> + */
> +#define CONFIG_BOOTDELAY	3
> +#define CONFIG_BOOTARGS		"root=/dev/mtdblock3 rootfstype=jffs2
> console=ttySAC0,115200" +#define CONFIG_ETHADDR	        
08:08:11:18:12:27
> +#define CONFIG_NETMASK          255.255.255.0
> +#define CONFIG_IPADDR		192.168.0.2
> +#define CONFIG_SERVERIP		192.168.0.1

Remove, NAK.

> +#define CONFIG_DOS_PARTITION	1
> +#define CONFIG_BOOTCOMMAND "tftp 0x32000000 uImage;setenv bootargs
> console=ttySAC0,115200 mem=16M noinitrd mini2440=5tb ip=dhcp;bootm" +
> +#ifndef CONFIG_MINI2440_NOR_ENV
> +	#define	CONFIG_ENV_IS_IN_NAND	1
> +	#define CONFIG_ENV_OFFSET_OOB	1	// dont define for 
CONFIG_ENV_IS_IN_FLASH
> +	/* This size must be the size of a common denominator for the NAND erase
> block */ +	#define CONFIG_ENV_SIZE		0x20000		/* 128k Total 
Size of
> Environment Sector */ +#else
> +	#define CONFIG_ENV_IS_IN_FLASH	1
> +	#define CONFIG_MY_ENV_OFFSET	0x40000
> +	#define CONFIG_ENV_ADDR		(PHYS_FLASH_1 + CONFIG_MY_ENV_OFFSET) /* 
addr of
> environment */ +	#define CONFIG_ENV_SIZE		0x4000		/* 16k 
Total Size of
> Environment Sector */ +#endif
> +#define CONFIG_PREBOOT_OVERRIDE	1
> +
> +/* ATAG configuration */
> +#define CONFIG_INITRD_TAG		1
> +#define CONFIG_SETUP_MEMORY_TAGS	1
> +#define CONFIG_CMDLINE_TAG		1
> +#define CONFIG_CMDLINE_EDITING		1
> +#define CONFIG_AUTO_COMPLETE		1
> +
> +#endif	/* __CONFIG_H */

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-16 17:46 [U-Boot] Add support for Mini2440 Gabriel Huau
  2012-04-17 20:09 ` [U-Boot] [PATCH V2] " Gabriel Huau
@ 2012-04-19 19:25 ` Gabriel Huau
  2012-04-19 20:08   ` Marek Vasut
  2012-04-19 22:22   ` Graeme Russ
  1 sibling, 2 replies; 42+ messages in thread
From: Gabriel Huau @ 2012-04-19 19:25 UTC (permalink / raw)
  To: u-boot

---
Changes for v2:
	- Coding style cleanup
	- Remove unnecessary files modification
	- Remove unnecessary board configuration set

Changes for v3:
	- Coding style cleanup
	- Move some macro definition from lowlevel_init.S
	to a new header
	- Remove some "magic bloat" with I/O board initialization
	- Add a pll_delay and replace loop by it
	- Somme cleanup in the configuration file
	- Cancel modifications on an SoC specific header
	- Add my name to copyright
---
 board/friendlyarm/mini2440/Makefile        |   45 ++++++
 board/friendlyarm/mini2440/lowlevel_init.S |   76 ++++++++++
 board/friendlyarm/mini2440/mini2440.c      |  139 ++++++++++++++++++
 board/friendlyarm/mini2440/mini2440.h      |  104 ++++++++++++++
 boards.cfg                                 |    1 +
 include/configs/mini2440.h                 |  215 ++++++++++++++++++++++++++++
 6 files changed, 580 insertions(+)
 create mode 100644 board/friendlyarm/mini2440/Makefile
 create mode 100644 board/friendlyarm/mini2440/lowlevel_init.S
 create mode 100644 board/friendlyarm/mini2440/mini2440.c
 create mode 100644 board/friendlyarm/mini2440/mini2440.h
 create mode 100644 include/configs/mini2440.h

diff --git a/board/friendlyarm/mini2440/Makefile b/board/friendlyarm/mini2440/Makefile
new file mode 100644
index 0000000..e8d68cb
--- /dev/null
+++ b/board/friendlyarm/mini2440/Makefile
@@ -0,0 +1,45 @@
+#
+# (C) Copyright 2012
+# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+include $(TOPDIR)/config.mk
+
+LIB	= $(obj)lib$(BOARD).o
+
+COBJS	:= mini2440.o
+SOBJS	:= lowlevel_init.o
+
+SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
+OBJS	:= $(addprefix $(obj),$(COBJS))
+SOBJS	:= $(addprefix $(obj),$(SOBJS))
+
+$(LIB):	$(obj).depend $(OBJS) $(SOBJS)
+	$(call cmd_link_o_target, $(OBJS) $(SOBJS))
+
+#########################################################################
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#########################################################################
diff --git a/board/friendlyarm/mini2440/lowlevel_init.S b/board/friendlyarm/mini2440/lowlevel_init.S
new file mode 100644
index 0000000..f69a08c
--- /dev/null
+++ b/board/friendlyarm/mini2440/lowlevel_init.S
@@ -0,0 +1,76 @@
+/*
+ * Memory Setup stuff - taken from blob memsetup.S
+ *
+ * Copyright (C) 1999 2000 2001 Erik Mouw (J.A.K.Mouw at its.tudelft.nl) and
+ *                     Jan-Derk Bakker (J.D.Bakker at its.tudelft.nl)
+ *
+ * Modified for the Samsung SMDK2410 by
+ * (C) Copyright 2002
+ * David Mueller, ELSOFT AG, <d.mueller@elsoft.ch>
+ *
+ * (C) Copyright 2012
+ * Gabriel Huau <contact@huau-gabriel.fr>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <config.h>
+#include <version.h>
+#include "mini2440.h"
+
+_TEXT_BASE:
+	.word	CONFIG_SYS_TEXT_BASE
+
+.globl lowlevel_init
+lowlevel_init:
+	/* memory control configuration */
+	/* make r0 relative the current location so that it */
+	/* reads SMRDATA out of FLASH rather than memory ! */
+	ldr     r0, =SMRDATA
+	ldr	r1, _TEXT_BASE
+	sub	r0, r0, r1
+	ldr	r1, =BWSCON	/* Bus Width Status Controller */
+	add     r2, r0, #13*4
+0:
+	ldr     r3, [r0], #4
+	str     r3, [r1], #4
+	cmp     r2, r0
+	bne     0b
+
+	/* everything is fine now */
+	mov	pc, lr
+
+	.ltorg
+/* the literal pools origin */
+
+SMRDATA:
+    .word (0+(B1_BWSCON<<4)+(B2_BWSCON<<8)+(B3_BWSCON<<12)+(B4_BWSCON<<16)+(B5_BWSCON<<20)+(B6_BWSCON<<24)+(B7_BWSCON<<28))
+    .word ((B0_Tacs<<13)+(B0_Tcos<<11)+(B0_Tacc<<8)+(B0_Tcoh<<6)+(B0_Tah<<4)+(B0_Tacp<<2)+(B0_PMC))
+    .word ((B1_Tacs<<13)+(B1_Tcos<<11)+(B1_Tacc<<8)+(B1_Tcoh<<6)+(B1_Tah<<4)+(B1_Tacp<<2)+(B1_PMC))
+    .word ((B2_Tacs<<13)+(B2_Tcos<<11)+(B2_Tacc<<8)+(B2_Tcoh<<6)+(B2_Tah<<4)+(B2_Tacp<<2)+(B2_PMC))
+    .word ((B3_Tacs<<13)+(B3_Tcos<<11)+(B3_Tacc<<8)+(B3_Tcoh<<6)+(B3_Tah<<4)+(B3_Tacp<<2)+(B3_PMC))
+    .word ((B4_Tacs<<13)+(B4_Tcos<<11)+(B4_Tacc<<8)+(B4_Tcoh<<6)+(B4_Tah<<4)+(B4_Tacp<<2)+(B4_PMC))
+    .word ((B5_Tacs<<13)+(B5_Tcos<<11)+(B5_Tacc<<8)+(B5_Tcoh<<6)+(B5_Tah<<4)+(B5_Tacp<<2)+(B5_PMC))
+
+    .word ((B6_MT<<15)+(B6_Trcd<<2)+(B6_SCAN))
+    .word ((B7_MT<<15)+(B7_Trcd<<2)+(B7_SCAN))
+    .word ((REFEN<<23)+(TREFMD<<22)+(Trp<<20)+(Trc<<18)+(Tchr<<16)+REFCNT)
+    .word 0x32
+    .word 0x30
+    .word 0x30
diff --git a/board/friendlyarm/mini2440/mini2440.c b/board/friendlyarm/mini2440/mini2440.c
new file mode 100644
index 0000000..9ba8d39
--- /dev/null
+++ b/board/friendlyarm/mini2440/mini2440.c
@@ -0,0 +1,139 @@
+/*
+ * (C) Copyright 2002
+ * Sysgo Real-Time Solutions, GmbH <www.elinos.com>
+ * Marius Groeger <mgroeger@sysgo.de>
+ *
+ * (C) Copyright 2002
+ * David Mueller, ELSOFT AG, <d.mueller@elsoft.ch>
+ *
+ * (C) Copyright 2009
+ * Michel Pollet <buserror@gmail.com>
+ *
+ * (C) Copyright 2012
+ * Gabriel Huau <contact@huau-gabriel.fr>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <common.h>
+#include <asm/arch/s3c2440.h>
+#include <asm/io.h>
+#include <video_fb.h>
+#include "mini2440.h"
+
+#ifdef CONFIG_DRIVER_DM9000
+#include <netdev.h>
+#endif
+
+DECLARE_GLOBAL_DATA_PTR;
+
+static inline void pll_delay(unsigned long loops)
+{
+	__asm__ volatile ("1:\n"
+	  "subs %0, %1, #1\n"
+	  "bne 1b" : "=r" (loops) : "0" (loops));
+}
+
+int arch_cpu_init(void)
+{
+	struct s3c24x0_clock_power * const clk_power =
+					s3c24x0_get_base_clock_power();
+
+	/* to reduce PLL lock time, adjust the LOCKTIME register */
+	clk_power->locktime = 0xFFFFFF;
+	clk_power->clkdivn = CLKDIVN_VAL;
+
+	/* configure UPLL */
+	clk_power->upllcon = ((U_M_MDIV << 12) + (U_M_PDIV << 4) + U_M_SDIV);
+	/* some delay between MPLL and UPLL */
+	pll_delay(100000);
+
+	/* configure MPLL */
+	clk_power->mpllcon = ((M_MDIV << 12) + (M_PDIV << 4) + M_SDIV);
+
+	/* some delay between MPLL and UPLL */
+	pll_delay(500000);
+
+	return 0;
+}
+
+/*
+ * Miscellaneous platform dependent initialisations
+ */
+int board_init(void)
+{
+	struct s3c24x0_clock_power * const clk_power =
+					s3c24x0_get_base_clock_power();
+	struct s3c24x0_gpio * const gpio = s3c24x0_get_base_gpio();
+
+	/* to reduce PLL lock time, adjust the LOCKTIME register */
+	clk_power->locktime = 0xFFFFFF;
+	clk_power->clkdivn = CLKDIVN_VAL;
+
+	/* configure UPLL */
+	clk_power->upllcon = ((U_M_MDIV << 12) + (U_M_PDIV << 4) + U_M_SDIV);
+	/* some delay between MPLL and UPLL */
+	udelay(10);
+	/* configure MPLL */
+	clk_power->mpllcon = ((M_MDIV << 12) + (M_PDIV << 4) + M_SDIV);
+
+	/* some delay between MPLL and UPLL */
+	udelay(8000);
+
+	/* set up the I/O ports */
+	writel(0x007FFFFF, &gpio->gpacon);
+	writel(0x00044555, &gpio->gpbcon);
+	writel(0x000007FF, &gpio->gpbup);
+	writel(0xAAAAAAAA, &gpio->gpccon);
+	writel(0x0000FFFF, &gpio->gpcup);
+	writel(0xAAAAAAAA, &gpio->gpdcon);
+	writel(0x0000FFFF, &gpio->gpdup);
+	writel(0xAAAAAAAA, &gpio->gpecon);
+	writel(0x0000FFFF, &gpio->gpeup);
+	writel(0x000055AA, &gpio->gpfcon);
+	writel(0x000000FF, &gpio->gpfup);
+	writel(0xFF95FFBA, &gpio->gpgcon);
+	writel(0x0000FFFF, &gpio->gpgup);
+	writel(0x002AFAAA, &gpio->gphcon);
+	writel(0x000007FF, &gpio->gphup);
+
+	/* adress of boot parameters */
+	gd->bd->bi_boot_params = CONFIG_BOOT_PARAM_ADDR;
+
+	return 0;
+}
+
+int dram_init(void)
+{
+	gd->ram_size = PHYS_SDRAM_1_SIZE;
+	return 0;
+}
+
+int board_eth_init(bd_t *bis)
+{
+#ifdef CONFIG_DRIVER_DM9000
+	return dm9000_initialize(bis);
+#else
+	return 0;
+#endif
+}
+
+/* The sum of all part_size[]s must equal to the NAND size, i.e., 0x4000000 */
+unsigned int dynpart_size[] = { 0x40000, 0x20000, 0x500000, 0xffffffff, 0 };
+char *dynpart_names[] = { "u-boot", "u-boot_env", "kernel", "rootfs", NULL };
diff --git a/board/friendlyarm/mini2440/mini2440.h b/board/friendlyarm/mini2440/mini2440.h
new file mode 100644
index 0000000..02197c8
--- /dev/null
+++ b/board/friendlyarm/mini2440/mini2440.h
@@ -0,0 +1,104 @@
+/*
+ * Taken from linux/arch/arm/boot/compressed/head-s3c2410.S
+ * Copyright (C) 2002 Samsung Electronics SW.LEE  <hitchcar@sec.samsung.com>
+ */
+
+#ifndef BOARD_LL_MINI2440_H
+#define BOARD_LL_MINI2440_H
+
+/*
+ * PLL/Clock configuration
+ */
+/* FCLK = 405 MHz, HCLK = 101 MHz, PCLK = 50 MHz, UCLK = 48 MHz */
+#define CLKDIVN_VAL	7
+#define M_MDIV		0x7f
+#define M_PDIV		0x2
+#define M_SDIV		0x1
+
+#define U_M_MDIV	0x38
+#define U_M_PDIV	0x2
+#define U_M_SDIV	0x2
+
+/* BWSCON */
+#define BWSCON	0x48000000
+#define DW8		(0x0)
+#define DW16	(0x1)
+#define DW32	(0x2)
+#define WAIT	(0x1<<2)
+#define UBLB	(0x1<<3)
+
+#define B1_BWSCON		(DW32)
+#define B2_BWSCON		(DW16)
+#define B3_BWSCON		(DW16 + WAIT + UBLB)
+#define B4_BWSCON		(DW16)
+#define B5_BWSCON		(DW16)
+#define B6_BWSCON		(DW32)
+#define B7_BWSCON		(DW32)
+
+/* BANK0CON */
+#define B0_Tacs		0x0	/*  0clk */
+#define B0_Tcos		0x0	/*  0clk */
+#define B0_Tacc		0x7	/* 14clk */
+#define B0_Tcoh		0x0	/*  0clk */
+#define B0_Tah		0x0	/*  0clk */
+#define B0_Tacp		0x0
+#define B0_PMC		0x0	/* normal */
+
+/* BANK1CON */
+#define B1_Tacs		0x0	/*  0clk */
+#define B1_Tcos		0x0	/*  0clk */
+#define B1_Tacc		0x7	/* 14clk */
+#define B1_Tcoh		0x0	/*  0clk */
+#define B1_Tah		0x0	/*  0clk */
+#define B1_Tacp		0x0
+#define B1_PMC		0x0
+
+#define B2_Tacs		0x0
+#define B2_Tcos		0x0
+#define B2_Tacc		0x7
+#define B2_Tcoh		0x0
+#define B2_Tah		0x0
+#define B2_Tacp		0x0
+#define B2_PMC		0x0
+
+#define B3_Tacs		0x0	/*  0clk */
+#define B3_Tcos		0x3	/*  4clk */
+#define B3_Tacc		0x7	/* 14clk */
+#define B3_Tcoh		0x1	/*  1clk */
+#define B3_Tah		0x0	/*  0clk */
+#define B3_Tacp		0x3     /*  6clk */
+#define B3_PMC		0x0	/* normal */
+
+#define B4_Tacs		0x0	/*  0clk */
+#define B4_Tcos		0x0	/*  0clk */
+#define B4_Tacc		0x7	/* 14clk */
+#define B4_Tcoh		0x0	/*  0clk */
+#define B4_Tah		0x0	/*  0clk */
+#define B4_Tacp		0x0
+#define B4_PMC		0x0	/* normal */
+
+#define B5_Tacs		0x0	/*  0clk */
+#define B5_Tcos		0x0	/*  0clk */
+#define B5_Tacc		0x7	/* 14clk */
+#define B5_Tcoh		0x0	/*  0clk */
+#define B5_Tah		0x0	/*  0clk */
+#define B5_Tacp		0x0
+#define B5_PMC		0x0	/* normal */
+
+#define B6_MT		0x3	/* SDRAM */
+#define B6_Trcd		0x1
+#define B6_SCAN		0x1	/* 9bit */
+
+#define B7_MT		0x3	/* SDRAM */
+#define B7_Trcd		0x1	/* 3clk */
+#define B7_SCAN		0x1	/* 9bit */
+
+/* REFRESH parameter */
+#define REFEN		0x1	/* Refresh enable */
+#define TREFMD		0x0	/* CBR(CAS before RAS)/Auto refresh */
+#define Trp			0x0	/* 2clk */
+#define Trc			0x3	/* 7clk */
+#define Tchr		0x2	/* 3clk */
+#define REFCNT		1113	/* period=15.6us, HCLK=60Mhz */
+
+#endif
diff --git a/boards.cfg b/boards.cfg
index 3cf75c3..93eeb3c 100644
--- a/boards.cfg
+++ b/boards.cfg
@@ -61,6 +61,7 @@ mx1ads                       arm         arm920t     -                   -
 scb9328                      arm         arm920t     -                   -              imx
 cm4008                       arm         arm920t     -                   -              ks8695
 cm41xx                       arm         arm920t     -                   -              ks8695
+mini2440                     arm         arm920t     mini2440            friendlyarm    s3c24x0
 VCMA9                        arm         arm920t     vcma9               mpl            s3c24x0
 smdk2410                     arm         arm920t     -                   samsung        s3c24x0
 omap1510inn                  arm         arm925t     -                   ti
diff --git a/include/configs/mini2440.h b/include/configs/mini2440.h
new file mode 100644
index 0000000..a3f06d0
--- /dev/null
+++ b/include/configs/mini2440.h
@@ -0,0 +1,215 @@
+/*
+ * (C) Copyright 2002
+ * Sysgo Real-Time Solutions, GmbH <www.elinos.com>
+ * Marius Groeger <mgroeger@sysgo.de>
+ * Gary Jennejohn <gj@denx.de>
+ * David Mueller <d.mueller@elsoft.ch>
+ *
+ * (C) Copyright 2009-2010
+ * Michel Pollet <buserror@gmail.com>
+ *
+ * (C) Copyright 2012
+ * Gabriel Huau <contact@huau-gabriel.fr>
+ *
+ * Configuation settings for the MINI2440 board.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#ifndef __CONFIG_H
+#define __CONFIG_H
+
+#define CONFIG_SYS_TEXT_BASE 0x0
+
+/*
+ * High Level Configuration Options
+ */
+#define CONFIG_ARM920T		1	/* This is an ARM920T Core	*/
+#define CONFIG_S3C24X0		1	/* in a SAMSUNG S3C2440 SoC */
+#define CONFIG_S3C2440		1	/* in a SAMSUNG S3C2440 SoC */
+#define CONFIG_MINI2440		1	/* on a MIN2440 Board       */
+
+#define	MACH_TYPE_MINI2440	1999
+#define	CONFIG_MACH_TYPE	MACH_TYPE_MINI2440
+
+/*
+ * It is possible to have u-boot save it's environment in NOR, however,
+ * reember it is incompatible with booting from NAND as the NOR is not
+ * available at that point. So use this only if you use nand as storage
+ * and will never boot from it
+ */
+#define CONFIG_MINI2440_NOR_ENV	1
+/* allow use of frequencies over 405Mhz */
+#define CONFIG_MINI2440_OVERCLOCK 1
+
+/*
+ * input clock of PLL
+ */
+/* MINI2440 has 12.0000MHz input clock */
+#define CONFIG_SYS_CLK_FREQ	12000000
+#define CONFIG_ARCH_CPU_INIT 1 /* for the initialization of PLL */
+
+#define USE_920T_MMU		1
+#define CONFIG_BAUDRATE		115200
+
+/*
+ * Size of malloc() pool
+ */
+#define CONFIG_SYS_MALLOC_LEN	(CONFIG_ENV_SIZE + 2048*1024)
+/* size in bytes reserved for initial data */
+#define CONFIG_GBL_DATA_SIZE	128
+
+/*
+ * Hardware drivers
+ */
+#define CONFIG_DRIVER_DM9000			1
+#define CONFIG_DRIVER_DM9000_NO_EEPROM	1
+#define CONFIG_DM9000_BASE				0x20000300
+#define DM9000_IO		CONFIG_DM9000_BASE
+#define DM9000_DATA		(CONFIG_DM9000_BASE+4)
+
+/*
+ * select serial console configuration
+ */
+#define CONFIG_S3C24X0_SERIAL
+#define CONFIG_SERIAL1			1
+
+/*
+ * allow to overwrite serial and ethaddr
+ */
+#define CONFIG_ENV_OVERWRITE
+
+/*
+ * Command definition
+ */
+#include <config_cmd_default.h>
+
+#define CONFIG_CMD_DHCP
+#define CONFIG_CMD_PORTIO
+#define CONFIG_CMD_REGINFO
+#define CONFIG_CMD_SAVES
+
+/*
+ * Miscellaneous configurable options
+ */
+#define	CONFIG_LONGHELP
+#define	CONFIG_SYS_PROMPT		"MINI2440 => "
+#define	CONFIG_SYS_CBSIZE		256
+#define	CONFIG_SYS_PBSIZE	(CONFIG_SYS_CBSIZE+sizeof(CONFIG_SYS_PROMPT)+16)
+#define	CONFIG_SYS_MAXARGS		32
+#define CONFIG_SYS_BARGSIZE		CONFIG_SYS_CBSIZE
+
+#define CONFIG_SYS_MEMTEST_START	0x30000000
+#define CONFIG_SYS_MEMTEST_END		0x34000000	/* 64MB in DRAM	*/
+
+/* everything, incl board info, in Hz */
+#undef  CONFIG_CLKS_IN_HZ
+
+/* default load address	*/
+#define	CONFIG_SYS_LOAD_ADDR		0x32000000
+
+/* boot parameters address */
+#define	CONFIG_BOOT_PARAM_ADDR		0x30000100
+
+/*
+ * the PWM TImer 4 uses a counter of 15625 for 10 ms, so we need
+ * it to wrap 100 times (total 1562500) to get 1 sec.
+ */
+#define	CONFIG_SYS_HZ			1562500
+
+/*
+ * valid baudrates
+ */
+#define CONFIG_SYS_BAUDRATE_TABLE	{ 9600, 19200, 38400, 57600, 115200 }
+
+/*
+ * Stack sizes
+ * The stack sizes are set up in start.S using the settings below
+ */
+#define CONFIG_STACKSIZE	(128*1024)	/* regular stack */
+#ifdef CONFIG_USE_IRQ
+#define CONFIG_STACKSIZE_IRQ	(8*1024)	/* IRQ stack */
+#define CONFIG_STACKSIZE_FIQ	(4*1024)	/* FIQ stack */
+#endif
+
+/*
+ * Physical Memory Map
+ */
+#define CONFIG_NR_DRAM_BANKS        1          /* we have 1 bank of DRAM */
+#define PHYS_SDRAM_1                0x30000000 /* SDRAM Bank #1 */
+#define PHYS_SDRAM_1_SIZE           (64*1024*1024) /* 64MB of DRAM */
+#define CONFIG_SYS_SDRAM_BASE       PHYS_SDRAM_1
+#define CONFIG_SYS_INIT_SP_ADDR		(CONFIG_SYS_SDRAM_BASE + 0x1000 - \
+							GENERATED_GBL_DATA_SIZE)
+
+/*
+ * When booting from NAND, it is impossible to access the lowest addresses
+ * due to the SteppingStone being in the way. Luckily the NOR doesn't really
+ * care about the highest 16 bits of address, so we set the controlers
+ * registers to go and poke over there, instead.
+ */
+#define PHYS_FLASH_1			0x0
+#define CONFIG_SYS_FLASH_BASE	0x0
+
+/*
+ * NOR FLASH organization
+ * Now uses the standard CFI interface
+ * FLASH and environment organization
+ */
+#define CONFIG_SYS_FLASH_CFI		1
+#define CONFIG_FLASH_CFI_DRIVER		1
+#define CONFIG_SYS_FLASH_CFI_WIDTH	FLASH_CFI_16BIT
+#define CONFIG_SYS_MONITOR_BASE		0x0
+/* max number of memory banks */
+#define CONFIG_SYS_MAX_FLASH_BANKS	1
+/* 512 * 4096 sectors, or 32 * 64k blocks */
+#define CONFIG_SYS_MAX_FLASH_SECT	512
+#define CONFIG_FLASH_SHOW_PROGRESS	1
+
+/*
+ * u-boot environmnent
+ */
+#define CONFIG_BOOTDELAY	3
+#define CONFIG_BOOTARGS		"root=/dev/sdb1 console=ttySAC0,115200"
+#define CONFIG_NETMASK      255.255.255.0
+#define CONFIG_IPADDR		192.168.0.2
+#define CONFIG_SERVERIP		192.168.0.1
+#define CONFIG_DOS_PARTITION	1
+#define CONFIG_BOOTCOMMAND "tftp 0x32000000 uImage;bootm"
+
+/*
+ * Config for NOR flash
+ */
+#define CONFIG_ENV_IS_IN_FLASH	1
+#define CONFIG_MY_ENV_OFFSET	0x40000
+/* addr of environment */
+#define CONFIG_ENV_ADDR		(PHYS_FLASH_1 + CONFIG_MY_ENV_OFFSET)
+/* 16k Total Size of Environment Sector */
+#define CONFIG_ENV_SIZE		0x4000
+
+#define CONFIG_PREBOOT_OVERRIDE	1
+
+/* ATAG configuration */
+#define CONFIG_INITRD_TAG			1
+#define CONFIG_SETUP_MEMORY_TAGS	1
+#define CONFIG_CMDLINE_TAG			1
+#define CONFIG_CMDLINE_EDITING		1
+#define CONFIG_AUTO_COMPLETE		1
+
+#endif	/* __CONFIG_H */
-- 
1.7.9.5

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-19 19:25 ` [U-Boot] [PATCH v3] " Gabriel Huau
@ 2012-04-19 20:08   ` Marek Vasut
  2012-04-19 20:16     ` Gabriel Huau
  2012-04-19 22:22   ` Graeme Russ
  1 sibling, 1 reply; 42+ messages in thread
From: Marek Vasut @ 2012-04-19 20:08 UTC (permalink / raw)
  To: u-boot

Dear Gabriel Huau,

> ---
> Changes for v2:
> 	- Coding style cleanup
> 	- Remove unnecessary files modification
> 	- Remove unnecessary board configuration set
> 
> Changes for v3:
> 	- Coding style cleanup
> 	- Move some macro definition from lowlevel_init.S
> 	to a new header
> 	- Remove some "magic bloat" with I/O board initialization
> 	- Add a pll_delay and replace loop by it
> 	- Somme cleanup in the configuration file
> 	- Cancel modifications on an SoC specific header
> 	- Add my name to copyright
> ---
>  board/friendlyarm/mini2440/Makefile        |   45 ++++++
>  board/friendlyarm/mini2440/lowlevel_init.S |   76 ++++++++++
>  board/friendlyarm/mini2440/mini2440.c      |  139 ++++++++++++++++++
>  board/friendlyarm/mini2440/mini2440.h      |  104 ++++++++++++++
>  boards.cfg                                 |    1 +
>  include/configs/mini2440.h                 |  215
> ++++++++++++++++++++++++++++ 6 files changed, 580 insertions(+)
>  create mode 100644 board/friendlyarm/mini2440/Makefile
>  create mode 100644 board/friendlyarm/mini2440/lowlevel_init.S
>  create mode 100644 board/friendlyarm/mini2440/mini2440.c
>  create mode 100644 board/friendlyarm/mini2440/mini2440.h
>  create mode 100644 include/configs/mini2440.h
> 
> diff --git a/board/friendlyarm/mini2440/Makefile
> b/board/friendlyarm/mini2440/Makefile new file mode 100644
> index 0000000..e8d68cb
> --- /dev/null
> +++ b/board/friendlyarm/mini2440/Makefile
> @@ -0,0 +1,45 @@
> +#
> +# (C) Copyright 2012
> +# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
> +#
> +# See file CREDITS for list of people who contributed to this
> +# project.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation; either version 2 of
> +# the License, or (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write to the Free Software
> +# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> +# MA 02111-1307 USA
> +#
> +
> +include $(TOPDIR)/config.mk
> +
> +LIB	= $(obj)lib$(BOARD).o
> +
> +COBJS	:= mini2440.o
> +SOBJS	:= lowlevel_init.o
> +
> +SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
> +OBJS	:= $(addprefix $(obj),$(COBJS))
> +SOBJS	:= $(addprefix $(obj),$(SOBJS))
> +
> +$(LIB):	$(obj).depend $(OBJS) $(SOBJS)
> +	$(call cmd_link_o_target, $(OBJS) $(SOBJS))
> +
> +#########################################################################
> +
> +# defines $(obj).depend target
> +include $(SRCTREE)/rules.mk
> +
> +sinclude $(obj).depend
> +
> +#########################################################################
> diff --git a/board/friendlyarm/mini2440/lowlevel_init.S
> b/board/friendlyarm/mini2440/lowlevel_init.S new file mode 100644
> index 0000000..f69a08c
> --- /dev/null
> +++ b/board/friendlyarm/mini2440/lowlevel_init.S
> @@ -0,0 +1,76 @@
> +/*
> + * Memory Setup stuff - taken from blob memsetup.S
> + *
> + * Copyright (C) 1999 2000 2001 Erik Mouw (J.A.K.Mouw at its.tudelft.nl) and
> + *                     Jan-Derk Bakker (J.D.Bakker at its.tudelft.nl)
> + *
> + * Modified for the Samsung SMDK2410 by
> + * (C) Copyright 2002
> + * David Mueller, ELSOFT AG, <d.mueller@elsoft.ch>
> + *
> + * (C) Copyright 2012
> + * Gabriel Huau <contact@huau-gabriel.fr>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#include <config.h>
> +#include <version.h>
> +#include "mini2440.h"
> +
> +_TEXT_BASE:
> +	.word	CONFIG_SYS_TEXT_BASE
> +
> +.globl lowlevel_init
> +lowlevel_init:
> +	/* memory control configuration */
> +	/* make r0 relative the current location so that it */
> +	/* reads SMRDATA out of FLASH rather than memory ! */
> +	ldr     r0, =SMRDATA
> +	ldr	r1, _TEXT_BASE
> +	sub	r0, r0, r1
> +	ldr	r1, =BWSCON	/* Bus Width Status Controller */
> +	add     r2, r0, #13*4
> +0:
> +	ldr     r3, [r0], #4
> +	str     r3, [r1], #4
> +	cmp     r2, r0
> +	bne     0b
> +
> +	/* everything is fine now */
> +	mov	pc, lr
> +
> +	.ltorg
> +/* the literal pools origin */
> +
> +SMRDATA:
> +    .word
> (0+(B1_BWSCON<<4)+(B2_BWSCON<<8)+(B3_BWSCON<<12)+(B4_BWSCON<<16)+(B5_BWSCO
> N<<20)+(B6_BWSCON<<24)+(B7_BWSCON<<28)) +    .word
> ((B0_Tacs<<13)+(B0_Tcos<<11)+(B0_Tacc<<8)+(B0_Tcoh<<6)+(B0_Tah<<4)+(B0_Tac
> p<<2)+(B0_PMC)) +    .word
> ((B1_Tacs<<13)+(B1_Tcos<<11)+(B1_Tacc<<8)+(B1_Tcoh<<6)+(B1_Tah<<4)+(B1_Tac
> p<<2)+(B1_PMC)) +    .word
> ((B2_Tacs<<13)+(B2_Tcos<<11)+(B2_Tacc<<8)+(B2_Tcoh<<6)+(B2_Tah<<4)+(B2_Tac
> p<<2)+(B2_PMC)) +    .word
> ((B3_Tacs<<13)+(B3_Tcos<<11)+(B3_Tacc<<8)+(B3_Tcoh<<6)+(B3_Tah<<4)+(B3_Tac
> p<<2)+(B3_PMC)) +    .word
> ((B4_Tacs<<13)+(B4_Tcos<<11)+(B4_Tacc<<8)+(B4_Tcoh<<6)+(B4_Tah<<4)+(B4_Tac
> p<<2)+(B4_PMC)) +    .word
> ((B5_Tacs<<13)+(B5_Tcos<<11)+(B5_Tacc<<8)+(B5_Tcoh<<6)+(B5_Tah<<4)+(B5_Tac
> p<<2)+(B5_PMC)) +
> +    .word ((B6_MT<<15)+(B6_Trcd<<2)+(B6_SCAN))
> +    .word ((B7_MT<<15)+(B7_Trcd<<2)+(B7_SCAN))
> +    .word ((REFEN<<23)+(TREFMD<<22)+(Trp<<20)+(Trc<<18)+(Tchr<<16)+REFCNT)
> +    .word 0x32
> +    .word 0x30
> +    .word 0x30

What this undocumented stuff?

> diff --git a/board/friendlyarm/mini2440/mini2440.c
> b/board/friendlyarm/mini2440/mini2440.c new file mode 100644
> index 0000000..9ba8d39
> --- /dev/null
> +++ b/board/friendlyarm/mini2440/mini2440.c
> @@ -0,0 +1,139 @@
> +/*
> + * (C) Copyright 2002
> + * Sysgo Real-Time Solutions, GmbH <www.elinos.com>
> + * Marius Groeger <mgroeger@sysgo.de>
> + *
> + * (C) Copyright 2002
> + * David Mueller, ELSOFT AG, <d.mueller@elsoft.ch>
> + *
> + * (C) Copyright 2009
> + * Michel Pollet <buserror@gmail.com>
> + *
> + * (C) Copyright 2012
> + * Gabriel Huau <contact@huau-gabriel.fr>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#include <common.h>
> +#include <asm/arch/s3c2440.h>
> +#include <asm/io.h>
> +#include <video_fb.h>
> +#include "mini2440.h"
> +
> +#ifdef CONFIG_DRIVER_DM9000
> +#include <netdev.h>
> +#endif
> +
> +DECLARE_GLOBAL_DATA_PTR;
> +
> +static inline void pll_delay(unsigned long loops)
> +{
> +	__asm__ volatile ("1:\n"
> +	  "subs %0, %1, #1\n"
> +	  "bne 1b" : "=r" (loops) : "0" (loops));
> +}
> +
> +int arch_cpu_init(void)
> +{
> +	struct s3c24x0_clock_power * const clk_power =
> +					s3c24x0_get_base_clock_power();
> +
> +	/* to reduce PLL lock time, adjust the LOCKTIME register */
> +	clk_power->locktime = 0xFFFFFF;
> +	clk_power->clkdivn = CLKDIVN_VAL;
> +
> +	/* configure UPLL */
> +	clk_power->upllcon = ((U_M_MDIV << 12) + (U_M_PDIV << 4) + U_M_SDIV);
> +	/* some delay between MPLL and UPLL */
> +	pll_delay(100000);
> +
> +	/* configure MPLL */
> +	clk_power->mpllcon = ((M_MDIV << 12) + (M_PDIV << 4) + M_SDIV);
> +
> +	/* some delay between MPLL and UPLL */
> +	pll_delay(500000);

You use udelay() below, do you need pll_delay() at all?

> +
> +	return 0;
> +}
> +
> +/*
> + * Miscellaneous platform dependent initialisations
> + */
> +int board_init(void)
> +{
> +	struct s3c24x0_clock_power * const clk_power =
> +					s3c24x0_get_base_clock_power();
> +	struct s3c24x0_gpio * const gpio = s3c24x0_get_base_gpio();
> +
> +	/* to reduce PLL lock time, adjust the LOCKTIME register */
> +	clk_power->locktime = 0xFFFFFF;
> +	clk_power->clkdivn = CLKDIVN_VAL;
> +
> +	/* configure UPLL */
> +	clk_power->upllcon = ((U_M_MDIV << 12) + (U_M_PDIV << 4) + U_M_SDIV);
> +	/* some delay between MPLL and UPLL */
> +	udelay(10);
> +	/* configure MPLL */
> +	clk_power->mpllcon = ((M_MDIV << 12) + (M_PDIV << 4) + M_SDIV);
> +
> +	/* some delay between MPLL and UPLL */
> +	udelay(8000);
> +
> +	/* set up the I/O ports */
> +	writel(0x007FFFFF, &gpio->gpacon);
> +	writel(0x00044555, &gpio->gpbcon);
> +	writel(0x000007FF, &gpio->gpbup);
> +	writel(0xAAAAAAAA, &gpio->gpccon);
> +	writel(0x0000FFFF, &gpio->gpcup);
> +	writel(0xAAAAAAAA, &gpio->gpdcon);
> +	writel(0x0000FFFF, &gpio->gpdup);
> +	writel(0xAAAAAAAA, &gpio->gpecon);
> +	writel(0x0000FFFF, &gpio->gpeup);
> +	writel(0x000055AA, &gpio->gpfcon);
> +	writel(0x000000FF, &gpio->gpfup);
> +	writel(0xFF95FFBA, &gpio->gpgcon);
> +	writel(0x0000FFFF, &gpio->gpgup);
> +	writel(0x002AFAAA, &gpio->gphcon);
> +	writel(0x000007FF, &gpio->gphup);
> +
> +	/* adress of boot parameters */
> +	gd->bd->bi_boot_params = CONFIG_BOOT_PARAM_ADDR;
> +
> +	return 0;
> +}
> +
> +int dram_init(void)
> +{
> +	gd->ram_size = PHYS_SDRAM_1_SIZE;
> +	return 0;
> +}
> +
> +int board_eth_init(bd_t *bis)
> +{
> +#ifdef CONFIG_DRIVER_DM9000
> +	return dm9000_initialize(bis);
> +#else
> +	return 0;
> +#endif
> +}
> +
> +/* The sum of all part_size[]s must equal to the NAND size, i.e.,
> 0x4000000 */ +unsigned int dynpart_size[] = { 0x40000, 0x20000, 0x500000,
> 0xffffffff, 0 }; +char *dynpart_names[] = { "u-boot", "u-boot_env",
> "kernel", "rootfs", NULL }; diff --git
> a/board/friendlyarm/mini2440/mini2440.h
> b/board/friendlyarm/mini2440/mini2440.h new file mode 100644
> index 0000000..02197c8
> --- /dev/null
> +++ b/board/friendlyarm/mini2440/mini2440.h
> @@ -0,0 +1,104 @@
> +/*
> + * Taken from linux/arch/arm/boot/compressed/head-s3c2410.S
> + * Copyright (C) 2002 Samsung Electronics SW.LEE 
> <hitchcar@sec.samsung.com> + */
> +
> +#ifndef BOARD_LL_MINI2440_H
> +#define BOARD_LL_MINI2440_H
> +
> +/*
> + * PLL/Clock configuration
> + */
> +/* FCLK = 405 MHz, HCLK = 101 MHz, PCLK = 50 MHz, UCLK = 48 MHz */
> +#define CLKDIVN_VAL	7
> +#define M_MDIV		0x7f
> +#define M_PDIV		0x2
> +#define M_SDIV		0x1
> +
> +#define U_M_MDIV	0x38
> +#define U_M_PDIV	0x2
> +#define U_M_SDIV	0x2
> +
> +/* BWSCON */
> +#define BWSCON	0x48000000
> +#define DW8		(0x0)
> +#define DW16	(0x1)
> +#define DW32	(0x2)
> +#define WAIT	(0x1<<2)
> +#define UBLB	(0x1<<3)
> +
> +#define B1_BWSCON		(DW32)
> +#define B2_BWSCON		(DW16)
> +#define B3_BWSCON		(DW16 + WAIT + UBLB)
> +#define B4_BWSCON		(DW16)
> +#define B5_BWSCON		(DW16)
> +#define B6_BWSCON		(DW32)
> +#define B7_BWSCON		(DW32)
> +
> +/* BANK0CON */
> +#define B0_Tacs		0x0	/*  0clk */
> +#define B0_Tcos		0x0	/*  0clk */
> +#define B0_Tacc		0x7	/* 14clk */
> +#define B0_Tcoh		0x0	/*  0clk */
> +#define B0_Tah		0x0	/*  0clk */
> +#define B0_Tacp		0x0
> +#define B0_PMC		0x0	/* normal */
> +
> +/* BANK1CON */
> +#define B1_Tacs		0x0	/*  0clk */
> +#define B1_Tcos		0x0	/*  0clk */
> +#define B1_Tacc		0x7	/* 14clk */
> +#define B1_Tcoh		0x0	/*  0clk */
> +#define B1_Tah		0x0	/*  0clk */
> +#define B1_Tacp		0x0
> +#define B1_PMC		0x0
> +
> +#define B2_Tacs		0x0
> +#define B2_Tcos		0x0
> +#define B2_Tacc		0x7
> +#define B2_Tcoh		0x0
> +#define B2_Tah		0x0
> +#define B2_Tacp		0x0
> +#define B2_PMC		0x0
> +
> +#define B3_Tacs		0x0	/*  0clk */
> +#define B3_Tcos		0x3	/*  4clk */
> +#define B3_Tacc		0x7	/* 14clk */
> +#define B3_Tcoh		0x1	/*  1clk */
> +#define B3_Tah		0x0	/*  0clk */
> +#define B3_Tacp		0x3     /*  6clk */
> +#define B3_PMC		0x0	/* normal */
> +
> +#define B4_Tacs		0x0	/*  0clk */
> +#define B4_Tcos		0x0	/*  0clk */
> +#define B4_Tacc		0x7	/* 14clk */
> +#define B4_Tcoh		0x0	/*  0clk */
> +#define B4_Tah		0x0	/*  0clk */
> +#define B4_Tacp		0x0
> +#define B4_PMC		0x0	/* normal */
> +
> +#define B5_Tacs		0x0	/*  0clk */
> +#define B5_Tcos		0x0	/*  0clk */
> +#define B5_Tacc		0x7	/* 14clk */
> +#define B5_Tcoh		0x0	/*  0clk */
> +#define B5_Tah		0x0	/*  0clk */
> +#define B5_Tacp		0x0
> +#define B5_PMC		0x0	/* normal */
> +
> +#define B6_MT		0x3	/* SDRAM */
> +#define B6_Trcd		0x1
> +#define B6_SCAN		0x1	/* 9bit */
> +
> +#define B7_MT		0x3	/* SDRAM */
> +#define B7_Trcd		0x1	/* 3clk */
> +#define B7_SCAN		0x1	/* 9bit */
> +
> +/* REFRESH parameter */
> +#define REFEN		0x1	/* Refresh enable */
> +#define TREFMD		0x0	/* CBR(CAS before RAS)/Auto refresh */
> +#define Trp			0x0	/* 2clk */
> +#define Trc			0x3	/* 7clk */
> +#define Tchr		0x2	/* 3clk */
> +#define REFCNT		1113	/* period=15.6us, HCLK=60Mhz */
> +
> +#endif
> diff --git a/boards.cfg b/boards.cfg
> index 3cf75c3..93eeb3c 100644
> --- a/boards.cfg
> +++ b/boards.cfg
> @@ -61,6 +61,7 @@ mx1ads                       arm         arm920t     -   
>                - scb9328                      arm         arm920t     -   
>                -              imx cm4008                       arm        
> arm920t     -                   -              ks8695 cm41xx              
>         arm         arm920t     -                   -              ks8695
> +mini2440                     arm         arm920t     mini2440           
> friendlyarm    s3c24x0 VCMA9                        arm         arm920t   
>  vcma9               mpl            s3c24x0 smdk2410                    
> arm         arm920t     -                   samsung        s3c24x0
> omap1510inn                  arm         arm925t     -                  
> ti diff --git a/include/configs/mini2440.h b/include/configs/mini2440.h
> new file mode 100644
> index 0000000..a3f06d0
> --- /dev/null
> +++ b/include/configs/mini2440.h
> @@ -0,0 +1,215 @@
> +/*
> + * (C) Copyright 2002
> + * Sysgo Real-Time Solutions, GmbH <www.elinos.com>
> + * Marius Groeger <mgroeger@sysgo.de>
> + * Gary Jennejohn <gj@denx.de>
> + * David Mueller <d.mueller@elsoft.ch>
> + *
> + * (C) Copyright 2009-2010
> + * Michel Pollet <buserror@gmail.com>
> + *
> + * (C) Copyright 2012
> + * Gabriel Huau <contact@huau-gabriel.fr>
> + *
> + * Configuation settings for the MINI2440 board.
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#ifndef __CONFIG_H
> +#define __CONFIG_H
> +
> +#define CONFIG_SYS_TEXT_BASE 0x0
> +
> +/*
> + * High Level Configuration Options
> + */
> +#define CONFIG_ARM920T		1	/* This is an ARM920T Core	
*/
> +#define CONFIG_S3C24X0		1	/* in a SAMSUNG S3C2440 SoC */
> +#define CONFIG_S3C2440		1	/* in a SAMSUNG S3C2440 SoC */
> +#define CONFIG_MINI2440		1	/* on a MIN2440 Board       */
> +
> +#define	MACH_TYPE_MINI2440	1999
> +#define	CONFIG_MACH_TYPE	MACH_TYPE_MINI2440
> +
> +/*
> + * It is possible to have u-boot save it's environment in NOR, however,
> + * reember it is incompatible with booting from NAND as the NOR is not
> + * available at that point. So use this only if you use nand as storage
> + * and will never boot from it
> + */
> +#define CONFIG_MINI2440_NOR_ENV	1
> +/* allow use of frequencies over 405Mhz */
> +#define CONFIG_MINI2440_OVERCLOCK 1
> +
> +/*
> + * input clock of PLL
> + */
> +/* MINI2440 has 12.0000MHz input clock */
> +#define CONFIG_SYS_CLK_FREQ	12000000
> +#define CONFIG_ARCH_CPU_INIT 1 /* for the initialization of PLL */
> +
> +#define USE_920T_MMU		1
> +#define CONFIG_BAUDRATE		115200
> +
> +/*
> + * Size of malloc() pool
> + */
> +#define CONFIG_SYS_MALLOC_LEN	(CONFIG_ENV_SIZE + 2048*1024)
> +/* size in bytes reserved for initial data */
> +#define CONFIG_GBL_DATA_SIZE	128
> +
> +/*
> + * Hardware drivers
> + */
> +#define CONFIG_DRIVER_DM9000			1
> +#define CONFIG_DRIVER_DM9000_NO_EEPROM	1
> +#define CONFIG_DM9000_BASE				0x20000300
> +#define DM9000_IO		CONFIG_DM9000_BASE
> +#define DM9000_DATA		(CONFIG_DM9000_BASE+4)
> +
> +/*
> + * select serial console configuration
> + */
> +#define CONFIG_S3C24X0_SERIAL
> +#define CONFIG_SERIAL1			1
> +
> +/*
> + * allow to overwrite serial and ethaddr
> + */
> +#define CONFIG_ENV_OVERWRITE
> +
> +/*
> + * Command definition
> + */
> +#include <config_cmd_default.h>
> +
> +#define CONFIG_CMD_DHCP
> +#define CONFIG_CMD_PORTIO
> +#define CONFIG_CMD_REGINFO
> +#define CONFIG_CMD_SAVES
> +
> +/*
> + * Miscellaneous configurable options
> + */
> +#define	CONFIG_LONGHELP
> +#define	CONFIG_SYS_PROMPT		"MINI2440 => "
> +#define	CONFIG_SYS_CBSIZE		256
> +#define	CONFIG_SYS_PBSIZE	
(CONFIG_SYS_CBSIZE+sizeof(CONFIG_SYS_PROMPT)+16)
> +#define	CONFIG_SYS_MAXARGS		32
> +#define CONFIG_SYS_BARGSIZE		CONFIG_SYS_CBSIZE
> +
> +#define CONFIG_SYS_MEMTEST_START	0x30000000
> +#define CONFIG_SYS_MEMTEST_END		0x34000000	/* 64MB in DRAM	
*/
> +
> +/* everything, incl board info, in Hz */
> +#undef  CONFIG_CLKS_IN_HZ
> +
> +/* default load address	*/
> +#define	CONFIG_SYS_LOAD_ADDR		0x32000000
> +
> +/* boot parameters address */
> +#define	CONFIG_BOOT_PARAM_ADDR		0x30000100
> +
> +/*
> + * the PWM TImer 4 uses a counter of 15625 for 10 ms, so we need
> + * it to wrap 100 times (total 1562500) to get 1 sec.
> + */
> +#define	CONFIG_SYS_HZ			1562500
> +
> +/*
> + * valid baudrates
> + */
> +#define CONFIG_SYS_BAUDRATE_TABLE	{ 9600, 19200, 38400, 57600, 115200 }
> +
> +/*
> + * Stack sizes
> + * The stack sizes are set up in start.S using the settings below
> + */
> +#define CONFIG_STACKSIZE	(128*1024)	/* regular stack */
> +#ifdef CONFIG_USE_IRQ
> +#define CONFIG_STACKSIZE_IRQ	(8*1024)	/* IRQ stack */
> +#define CONFIG_STACKSIZE_FIQ	(4*1024)	/* FIQ stack */
> +#endif
> +
> +/*
> + * Physical Memory Map
> + */
> +#define CONFIG_NR_DRAM_BANKS        1          /* we have 1 bank of DRAM
> */ +#define PHYS_SDRAM_1                0x30000000 /* SDRAM Bank #1 */
> +#define PHYS_SDRAM_1_SIZE           (64*1024*1024) /* 64MB of DRAM */
> +#define CONFIG_SYS_SDRAM_BASE       PHYS_SDRAM_1
> +#define CONFIG_SYS_INIT_SP_ADDR		(CONFIG_SYS_SDRAM_BASE + 0x1000 
- \
> +							GENERATED_GBL_DATA_SIZE)
> +
> +/*
> + * When booting from NAND, it is impossible to access the lowest addresses
> + * due to the SteppingStone being in the way. Luckily the NOR doesn't
> really + * care about the highest 16 bits of address, so we set the
> controlers + * registers to go and poke over there, instead.
> + */
> +#define PHYS_FLASH_1			0x0
> +#define CONFIG_SYS_FLASH_BASE	0x0
> +
> +/*
> + * NOR FLASH organization
> + * Now uses the standard CFI interface
> + * FLASH and environment organization
> + */
> +#define CONFIG_SYS_FLASH_CFI		1
> +#define CONFIG_FLASH_CFI_DRIVER		1
> +#define CONFIG_SYS_FLASH_CFI_WIDTH	FLASH_CFI_16BIT
> +#define CONFIG_SYS_MONITOR_BASE		0x0
> +/* max number of memory banks */
> +#define CONFIG_SYS_MAX_FLASH_BANKS	1
> +/* 512 * 4096 sectors, or 32 * 64k blocks */
> +#define CONFIG_SYS_MAX_FLASH_SECT	512
> +#define CONFIG_FLASH_SHOW_PROGRESS	1
> +
> +/*
> + * u-boot environmnent
> + */
> +#define CONFIG_BOOTDELAY	3
> +#define CONFIG_BOOTARGS		"root=/dev/sdb1 console=ttySAC0,115200"
> +#define CONFIG_NETMASK      255.255.255.0
> +#define CONFIG_IPADDR		192.168.0.2
> +#define CONFIG_SERVERIP		192.168.0.1
> +#define CONFIG_DOS_PARTITION	1
> +#define CONFIG_BOOTCOMMAND "tftp 0x32000000 uImage;bootm"

DROP THIS!

> +
> +/*
> + * Config for NOR flash
> + */
> +#define CONFIG_ENV_IS_IN_FLASH	1
> +#define CONFIG_MY_ENV_OFFSET	0x40000
> +/* addr of environment */
> +#define CONFIG_ENV_ADDR		(PHYS_FLASH_1 + CONFIG_MY_ENV_OFFSET)
> +/* 16k Total Size of Environment Sector */
> +#define CONFIG_ENV_SIZE		0x4000
> +
> +#define CONFIG_PREBOOT_OVERRIDE	1
> +
> +/* ATAG configuration */
> +#define CONFIG_INITRD_TAG			1
> +#define CONFIG_SETUP_MEMORY_TAGS	1
> +#define CONFIG_CMDLINE_TAG			1
> +#define CONFIG_CMDLINE_EDITING		1
> +#define CONFIG_AUTO_COMPLETE		1
> +
> +#endif	/* __CONFIG_H */

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-19 20:08   ` Marek Vasut
@ 2012-04-19 20:16     ` Gabriel Huau
  2012-04-19 20:45       ` Marek Vasut
  0 siblings, 1 reply; 42+ messages in thread
From: Gabriel Huau @ 2012-04-19 20:16 UTC (permalink / raw)
  To: u-boot

On Thu, Apr 19, 2012 at 10:08:47PM +0200, Marek Vasut wrote:
> Dear Gabriel Huau,
> 
> > ---
> > Changes for v2:
> > 	- Coding style cleanup
> > 	- Remove unnecessary files modification
> > 	- Remove unnecessary board configuration set
> > 
> > Changes for v3:
> > 	- Coding style cleanup
> > 	- Move some macro definition from lowlevel_init.S
> > 	to a new header
> > 	- Remove some "magic bloat" with I/O board initialization
> > 	- Add a pll_delay and replace loop by it
> > 	- Somme cleanup in the configuration file
> > 	- Cancel modifications on an SoC specific header
> > 	- Add my name to copyright
> > ---
> >  board/friendlyarm/mini2440/Makefile        |   45 ++++++
> >  board/friendlyarm/mini2440/lowlevel_init.S |   76 ++++++++++
> >  board/friendlyarm/mini2440/mini2440.c      |  139 ++++++++++++++++++
> >  board/friendlyarm/mini2440/mini2440.h      |  104 ++++++++++++++
> >  boards.cfg                                 |    1 +
> >  include/configs/mini2440.h                 |  215
> > ++++++++++++++++++++++++++++ 6 files changed, 580 insertions(+)
> >  create mode 100644 board/friendlyarm/mini2440/Makefile
> >  create mode 100644 board/friendlyarm/mini2440/lowlevel_init.S
> >  create mode 100644 board/friendlyarm/mini2440/mini2440.c
> >  create mode 100644 board/friendlyarm/mini2440/mini2440.h
> >  create mode 100644 include/configs/mini2440.h
> > 
> > diff --git a/board/friendlyarm/mini2440/Makefile
> > b/board/friendlyarm/mini2440/Makefile new file mode 100644
> > index 0000000..e8d68cb
> > --- /dev/null
> > +++ b/board/friendlyarm/mini2440/Makefile
> > @@ -0,0 +1,45 @@
> > +#
> > +# (C) Copyright 2012
> > +# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
> > +#
> > +# See file CREDITS for list of people who contributed to this
> > +# project.
> > +#
> > +# This program is free software; you can redistribute it and/or
> > +# modify it under the terms of the GNU General Public License as
> > +# published by the Free Software Foundation; either version 2 of
> > +# the License, or (at your option) any later version.
> > +#
> > +# This program is distributed in the hope that it will be useful,
> > +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > +# GNU General Public License for more details.
> > +#
> > +# You should have received a copy of the GNU General Public License
> > +# along with this program; if not, write to the Free Software
> > +# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > +# MA 02111-1307 USA
> > +#
> > +
> > +include $(TOPDIR)/config.mk
> > +
> > +LIB	= $(obj)lib$(BOARD).o
> > +
> > +COBJS	:= mini2440.o
> > +SOBJS	:= lowlevel_init.o
> > +
> > +SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
> > +OBJS	:= $(addprefix $(obj),$(COBJS))
> > +SOBJS	:= $(addprefix $(obj),$(SOBJS))
> > +
> > +$(LIB):	$(obj).depend $(OBJS) $(SOBJS)
> > +	$(call cmd_link_o_target, $(OBJS) $(SOBJS))
> > +
> > +#########################################################################
> > +
> > +# defines $(obj).depend target
> > +include $(SRCTREE)/rules.mk
> > +
> > +sinclude $(obj).depend
> > +
> > +#########################################################################
> > diff --git a/board/friendlyarm/mini2440/lowlevel_init.S
> > b/board/friendlyarm/mini2440/lowlevel_init.S new file mode 100644
> > index 0000000..f69a08c
> > --- /dev/null
> > +++ b/board/friendlyarm/mini2440/lowlevel_init.S
> > @@ -0,0 +1,76 @@
> > +/*
> > + * Memory Setup stuff - taken from blob memsetup.S
> > + *
> > + * Copyright (C) 1999 2000 2001 Erik Mouw (J.A.K.Mouw at its.tudelft.nl) and
> > + *                     Jan-Derk Bakker (J.D.Bakker at its.tudelft.nl)
> > + *
> > + * Modified for the Samsung SMDK2410 by
> > + * (C) Copyright 2002
> > + * David Mueller, ELSOFT AG, <d.mueller@elsoft.ch>
> > + *
> > + * (C) Copyright 2012
> > + * Gabriel Huau <contact@huau-gabriel.fr>
> > + *
> > + * See file CREDITS for list of people who contributed to this
> > + * project.
> > + *
> > + * This program is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License as
> > + * published by the Free Software Foundation; either version 2 of
> > + * the License, or (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + *
> > + * You should have received a copy of the GNU General Public License
> > + * along with this program; if not, write to the Free Software
> > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > + * MA 02111-1307 USA
> > + */
> > +
> > +#include <config.h>
> > +#include <version.h>
> > +#include "mini2440.h"
> > +
> > +_TEXT_BASE:
> > +	.word	CONFIG_SYS_TEXT_BASE
> > +
> > +.globl lowlevel_init
> > +lowlevel_init:
> > +	/* memory control configuration */
> > +	/* make r0 relative the current location so that it */
> > +	/* reads SMRDATA out of FLASH rather than memory ! */
> > +	ldr     r0, =SMRDATA
> > +	ldr	r1, _TEXT_BASE
> > +	sub	r0, r0, r1
> > +	ldr	r1, =BWSCON	/* Bus Width Status Controller */
> > +	add     r2, r0, #13*4
> > +0:
> > +	ldr     r3, [r0], #4
> > +	str     r3, [r1], #4
> > +	cmp     r2, r0
> > +	bne     0b
> > +
> > +	/* everything is fine now */
> > +	mov	pc, lr
> > +
> > +	.ltorg
> > +/* the literal pools origin */
> > +
> > +SMRDATA:
> > +    .word
> > (0+(B1_BWSCON<<4)+(B2_BWSCON<<8)+(B3_BWSCON<<12)+(B4_BWSCON<<16)+(B5_BWSCO
> > N<<20)+(B6_BWSCON<<24)+(B7_BWSCON<<28)) +    .word
> > ((B0_Tacs<<13)+(B0_Tcos<<11)+(B0_Tacc<<8)+(B0_Tcoh<<6)+(B0_Tah<<4)+(B0_Tac
> > p<<2)+(B0_PMC)) +    .word
> > ((B1_Tacs<<13)+(B1_Tcos<<11)+(B1_Tacc<<8)+(B1_Tcoh<<6)+(B1_Tah<<4)+(B1_Tac
> > p<<2)+(B1_PMC)) +    .word
> > ((B2_Tacs<<13)+(B2_Tcos<<11)+(B2_Tacc<<8)+(B2_Tcoh<<6)+(B2_Tah<<4)+(B2_Tac
> > p<<2)+(B2_PMC)) +    .word
> > ((B3_Tacs<<13)+(B3_Tcos<<11)+(B3_Tacc<<8)+(B3_Tcoh<<6)+(B3_Tah<<4)+(B3_Tac
> > p<<2)+(B3_PMC)) +    .word
> > ((B4_Tacs<<13)+(B4_Tcos<<11)+(B4_Tacc<<8)+(B4_Tcoh<<6)+(B4_Tah<<4)+(B4_Tac
> > p<<2)+(B4_PMC)) +    .word
> > ((B5_Tacs<<13)+(B5_Tcos<<11)+(B5_Tacc<<8)+(B5_Tcoh<<6)+(B5_Tah<<4)+(B5_Tac
> > p<<2)+(B5_PMC)) +
> > +    .word ((B6_MT<<15)+(B6_Trcd<<2)+(B6_SCAN))
> > +    .word ((B7_MT<<15)+(B7_Trcd<<2)+(B7_SCAN))
> > +    .word ((REFEN<<23)+(TREFMD<<22)+(Trp<<20)+(Trc<<18)+(Tchr<<16)+REFCNT)
> > +    .word 0x32
> > +    .word 0x30
> > +    .word 0x30
> 
> What this undocumented stuff?

SoC specific, I pasted it from smdk2410, it's for initialize the DRAM.

> 
> > diff --git a/board/friendlyarm/mini2440/mini2440.c
> > b/board/friendlyarm/mini2440/mini2440.c new file mode 100644
> > index 0000000..9ba8d39
> > --- /dev/null
> > +++ b/board/friendlyarm/mini2440/mini2440.c
> > @@ -0,0 +1,139 @@
> > +/*
> > + * (C) Copyright 2002
> > + * Sysgo Real-Time Solutions, GmbH <www.elinos.com>
> > + * Marius Groeger <mgroeger@sysgo.de>
> > + *
> > + * (C) Copyright 2002
> > + * David Mueller, ELSOFT AG, <d.mueller@elsoft.ch>
> > + *
> > + * (C) Copyright 2009
> > + * Michel Pollet <buserror@gmail.com>
> > + *
> > + * (C) Copyright 2012
> > + * Gabriel Huau <contact@huau-gabriel.fr>
> > + *
> > + * See file CREDITS for list of people who contributed to this
> > + * project.
> > + *
> > + * This program is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License as
> > + * published by the Free Software Foundation; either version 2 of
> > + * the License, or (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + *
> > + * You should have received a copy of the GNU General Public License
> > + * along with this program; if not, write to the Free Software
> > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > + * MA 02111-1307 USA
> > + */
> > +
> > +#include <common.h>
> > +#include <asm/arch/s3c2440.h>
> > +#include <asm/io.h>
> > +#include <video_fb.h>
> > +#include "mini2440.h"
> > +
> > +#ifdef CONFIG_DRIVER_DM9000
> > +#include <netdev.h>
> > +#endif
> > +
> > +DECLARE_GLOBAL_DATA_PTR;
> > +
> > +static inline void pll_delay(unsigned long loops)
> > +{
> > +	__asm__ volatile ("1:\n"
> > +	  "subs %0, %1, #1\n"
> > +	  "bne 1b" : "=r" (loops) : "0" (loops));
> > +}
> > +
> > +int arch_cpu_init(void)
> > +{
> > +	struct s3c24x0_clock_power * const clk_power =
> > +					s3c24x0_get_base_clock_power();
> > +
> > +	/* to reduce PLL lock time, adjust the LOCKTIME register */
> > +	clk_power->locktime = 0xFFFFFF;
> > +	clk_power->clkdivn = CLKDIVN_VAL;
> > +
> > +	/* configure UPLL */
> > +	clk_power->upllcon = ((U_M_MDIV << 12) + (U_M_PDIV << 4) + U_M_SDIV);
> > +	/* some delay between MPLL and UPLL */
> > +	pll_delay(100000);
> > +
> > +	/* configure MPLL */
> > +	clk_power->mpllcon = ((M_MDIV << 12) + (M_PDIV << 4) + M_SDIV);
> > +
> > +	/* some delay between MPLL and UPLL */
> > +	pll_delay(500000);
> 
> You use udelay() below, do you need pll_delay() at all?

Yes, because initialisation of PLL is done before timer_init(), so we
can't use udelay().

> 
> > +
> > +	return 0;
> > +}
> > +
> > +/*
> > + * Miscellaneous platform dependent initialisations
> > + */
> > +int board_init(void)
> > +{
> > +	struct s3c24x0_clock_power * const clk_power =
> > +					s3c24x0_get_base_clock_power();
> > +	struct s3c24x0_gpio * const gpio = s3c24x0_get_base_gpio();
> > +
> > +	/* to reduce PLL lock time, adjust the LOCKTIME register */
> > +	clk_power->locktime = 0xFFFFFF;
> > +	clk_power->clkdivn = CLKDIVN_VAL;
> > +
> > +	/* configure UPLL */
> > +	clk_power->upllcon = ((U_M_MDIV << 12) + (U_M_PDIV << 4) + U_M_SDIV);
> > +	/* some delay between MPLL and UPLL */
> > +	udelay(10);
> > +	/* configure MPLL */
> > +	clk_power->mpllcon = ((M_MDIV << 12) + (M_PDIV << 4) + M_SDIV);
> > +
> > +	/* some delay between MPLL and UPLL */
> > +	udelay(8000);
> > +
> > +	/* set up the I/O ports */
> > +	writel(0x007FFFFF, &gpio->gpacon);
> > +	writel(0x00044555, &gpio->gpbcon);
> > +	writel(0x000007FF, &gpio->gpbup);
> > +	writel(0xAAAAAAAA, &gpio->gpccon);
> > +	writel(0x0000FFFF, &gpio->gpcup);
> > +	writel(0xAAAAAAAA, &gpio->gpdcon);
> > +	writel(0x0000FFFF, &gpio->gpdup);
> > +	writel(0xAAAAAAAA, &gpio->gpecon);
> > +	writel(0x0000FFFF, &gpio->gpeup);
> > +	writel(0x000055AA, &gpio->gpfcon);
> > +	writel(0x000000FF, &gpio->gpfup);
> > +	writel(0xFF95FFBA, &gpio->gpgcon);
> > +	writel(0x0000FFFF, &gpio->gpgup);
> > +	writel(0x002AFAAA, &gpio->gphcon);
> > +	writel(0x000007FF, &gpio->gphup);
> > +
> > +	/* adress of boot parameters */
> > +	gd->bd->bi_boot_params = CONFIG_BOOT_PARAM_ADDR;
> > +
> > +	return 0;
> > +}
> > +
> > +int dram_init(void)
> > +{
> > +	gd->ram_size = PHYS_SDRAM_1_SIZE;
> > +	return 0;
> > +}
> > +
> > +int board_eth_init(bd_t *bis)
> > +{
> > +#ifdef CONFIG_DRIVER_DM9000
> > +	return dm9000_initialize(bis);
> > +#else
> > +	return 0;
> > +#endif
> > +}
> > +
> > +/* The sum of all part_size[]s must equal to the NAND size, i.e.,
> > 0x4000000 */ +unsigned int dynpart_size[] = { 0x40000, 0x20000, 0x500000,
> > 0xffffffff, 0 }; +char *dynpart_names[] = { "u-boot", "u-boot_env",
> > "kernel", "rootfs", NULL }; diff --git
> > a/board/friendlyarm/mini2440/mini2440.h
> > b/board/friendlyarm/mini2440/mini2440.h new file mode 100644
> > index 0000000..02197c8
> > --- /dev/null
> > +++ b/board/friendlyarm/mini2440/mini2440.h
> > @@ -0,0 +1,104 @@
> > +/*
> > + * Taken from linux/arch/arm/boot/compressed/head-s3c2410.S
> > + * Copyright (C) 2002 Samsung Electronics SW.LEE 
> > <hitchcar@sec.samsung.com> + */
> > +
> > +#ifndef BOARD_LL_MINI2440_H
> > +#define BOARD_LL_MINI2440_H
> > +
> > +/*
> > + * PLL/Clock configuration
> > + */
> > +/* FCLK = 405 MHz, HCLK = 101 MHz, PCLK = 50 MHz, UCLK = 48 MHz */
> > +#define CLKDIVN_VAL	7
> > +#define M_MDIV		0x7f
> > +#define M_PDIV		0x2
> > +#define M_SDIV		0x1
> > +
> > +#define U_M_MDIV	0x38
> > +#define U_M_PDIV	0x2
> > +#define U_M_SDIV	0x2
> > +
> > +/* BWSCON */
> > +#define BWSCON	0x48000000
> > +#define DW8		(0x0)
> > +#define DW16	(0x1)
> > +#define DW32	(0x2)
> > +#define WAIT	(0x1<<2)
> > +#define UBLB	(0x1<<3)
> > +
> > +#define B1_BWSCON		(DW32)
> > +#define B2_BWSCON		(DW16)
> > +#define B3_BWSCON		(DW16 + WAIT + UBLB)
> > +#define B4_BWSCON		(DW16)
> > +#define B5_BWSCON		(DW16)
> > +#define B6_BWSCON		(DW32)
> > +#define B7_BWSCON		(DW32)
> > +
> > +/* BANK0CON */
> > +#define B0_Tacs		0x0	/*  0clk */
> > +#define B0_Tcos		0x0	/*  0clk */
> > +#define B0_Tacc		0x7	/* 14clk */
> > +#define B0_Tcoh		0x0	/*  0clk */
> > +#define B0_Tah		0x0	/*  0clk */
> > +#define B0_Tacp		0x0
> > +#define B0_PMC		0x0	/* normal */
> > +
> > +/* BANK1CON */
> > +#define B1_Tacs		0x0	/*  0clk */
> > +#define B1_Tcos		0x0	/*  0clk */
> > +#define B1_Tacc		0x7	/* 14clk */
> > +#define B1_Tcoh		0x0	/*  0clk */
> > +#define B1_Tah		0x0	/*  0clk */
> > +#define B1_Tacp		0x0
> > +#define B1_PMC		0x0
> > +
> > +#define B2_Tacs		0x0
> > +#define B2_Tcos		0x0
> > +#define B2_Tacc		0x7
> > +#define B2_Tcoh		0x0
> > +#define B2_Tah		0x0
> > +#define B2_Tacp		0x0
> > +#define B2_PMC		0x0
> > +
> > +#define B3_Tacs		0x0	/*  0clk */
> > +#define B3_Tcos		0x3	/*  4clk */
> > +#define B3_Tacc		0x7	/* 14clk */
> > +#define B3_Tcoh		0x1	/*  1clk */
> > +#define B3_Tah		0x0	/*  0clk */
> > +#define B3_Tacp		0x3     /*  6clk */
> > +#define B3_PMC		0x0	/* normal */
> > +
> > +#define B4_Tacs		0x0	/*  0clk */
> > +#define B4_Tcos		0x0	/*  0clk */
> > +#define B4_Tacc		0x7	/* 14clk */
> > +#define B4_Tcoh		0x0	/*  0clk */
> > +#define B4_Tah		0x0	/*  0clk */
> > +#define B4_Tacp		0x0
> > +#define B4_PMC		0x0	/* normal */
> > +
> > +#define B5_Tacs		0x0	/*  0clk */
> > +#define B5_Tcos		0x0	/*  0clk */
> > +#define B5_Tacc		0x7	/* 14clk */
> > +#define B5_Tcoh		0x0	/*  0clk */
> > +#define B5_Tah		0x0	/*  0clk */
> > +#define B5_Tacp		0x0
> > +#define B5_PMC		0x0	/* normal */
> > +
> > +#define B6_MT		0x3	/* SDRAM */
> > +#define B6_Trcd		0x1
> > +#define B6_SCAN		0x1	/* 9bit */
> > +
> > +#define B7_MT		0x3	/* SDRAM */
> > +#define B7_Trcd		0x1	/* 3clk */
> > +#define B7_SCAN		0x1	/* 9bit */
> > +
> > +/* REFRESH parameter */
> > +#define REFEN		0x1	/* Refresh enable */
> > +#define TREFMD		0x0	/* CBR(CAS before RAS)/Auto refresh */
> > +#define Trp			0x0	/* 2clk */
> > +#define Trc			0x3	/* 7clk */
> > +#define Tchr		0x2	/* 3clk */
> > +#define REFCNT		1113	/* period=15.6us, HCLK=60Mhz */
> > +
> > +#endif
> > diff --git a/boards.cfg b/boards.cfg
> > index 3cf75c3..93eeb3c 100644
> > --- a/boards.cfg
> > +++ b/boards.cfg
> > @@ -61,6 +61,7 @@ mx1ads                       arm         arm920t     -   
> >                - scb9328                      arm         arm920t     -   
> >                -              imx cm4008                       arm        
> > arm920t     -                   -              ks8695 cm41xx              
> >         arm         arm920t     -                   -              ks8695
> > +mini2440                     arm         arm920t     mini2440           
> > friendlyarm    s3c24x0 VCMA9                        arm         arm920t   
> >  vcma9               mpl            s3c24x0 smdk2410                    
> > arm         arm920t     -                   samsung        s3c24x0
> > omap1510inn                  arm         arm925t     -                  
> > ti diff --git a/include/configs/mini2440.h b/include/configs/mini2440.h
> > new file mode 100644
> > index 0000000..a3f06d0
> > --- /dev/null
> > +++ b/include/configs/mini2440.h
> > @@ -0,0 +1,215 @@
> > +/*
> > + * (C) Copyright 2002
> > + * Sysgo Real-Time Solutions, GmbH <www.elinos.com>
> > + * Marius Groeger <mgroeger@sysgo.de>
> > + * Gary Jennejohn <gj@denx.de>
> > + * David Mueller <d.mueller@elsoft.ch>
> > + *
> > + * (C) Copyright 2009-2010
> > + * Michel Pollet <buserror@gmail.com>
> > + *
> > + * (C) Copyright 2012
> > + * Gabriel Huau <contact@huau-gabriel.fr>
> > + *
> > + * Configuation settings for the MINI2440 board.
> > + *
> > + * See file CREDITS for list of people who contributed to this
> > + * project.
> > + *
> > + * This program is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License as
> > + * published by the Free Software Foundation; either version 2 of
> > + * the License, or (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + *
> > + * You should have received a copy of the GNU General Public License
> > + * along with this program; if not, write to the Free Software
> > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > + * MA 02111-1307 USA
> > + */
> > +
> > +#ifndef __CONFIG_H
> > +#define __CONFIG_H
> > +
> > +#define CONFIG_SYS_TEXT_BASE 0x0
> > +
> > +/*
> > + * High Level Configuration Options
> > + */
> > +#define CONFIG_ARM920T		1	/* This is an ARM920T Core	
> */
> > +#define CONFIG_S3C24X0		1	/* in a SAMSUNG S3C2440 SoC */
> > +#define CONFIG_S3C2440		1	/* in a SAMSUNG S3C2440 SoC */
> > +#define CONFIG_MINI2440		1	/* on a MIN2440 Board       */
> > +
> > +#define	MACH_TYPE_MINI2440	1999
> > +#define	CONFIG_MACH_TYPE	MACH_TYPE_MINI2440
> > +
> > +/*
> > + * It is possible to have u-boot save it's environment in NOR, however,
> > + * reember it is incompatible with booting from NAND as the NOR is not
> > + * available at that point. So use this only if you use nand as storage
> > + * and will never boot from it
> > + */
> > +#define CONFIG_MINI2440_NOR_ENV	1
> > +/* allow use of frequencies over 405Mhz */
> > +#define CONFIG_MINI2440_OVERCLOCK 1
> > +
> > +/*
> > + * input clock of PLL
> > + */
> > +/* MINI2440 has 12.0000MHz input clock */
> > +#define CONFIG_SYS_CLK_FREQ	12000000
> > +#define CONFIG_ARCH_CPU_INIT 1 /* for the initialization of PLL */
> > +
> > +#define USE_920T_MMU		1
> > +#define CONFIG_BAUDRATE		115200
> > +
> > +/*
> > + * Size of malloc() pool
> > + */
> > +#define CONFIG_SYS_MALLOC_LEN	(CONFIG_ENV_SIZE + 2048*1024)
> > +/* size in bytes reserved for initial data */
> > +#define CONFIG_GBL_DATA_SIZE	128
> > +
> > +/*
> > + * Hardware drivers
> > + */
> > +#define CONFIG_DRIVER_DM9000			1
> > +#define CONFIG_DRIVER_DM9000_NO_EEPROM	1
> > +#define CONFIG_DM9000_BASE				0x20000300
> > +#define DM9000_IO		CONFIG_DM9000_BASE
> > +#define DM9000_DATA		(CONFIG_DM9000_BASE+4)
> > +
> > +/*
> > + * select serial console configuration
> > + */
> > +#define CONFIG_S3C24X0_SERIAL
> > +#define CONFIG_SERIAL1			1
> > +
> > +/*
> > + * allow to overwrite serial and ethaddr
> > + */
> > +#define CONFIG_ENV_OVERWRITE
> > +
> > +/*
> > + * Command definition
> > + */
> > +#include <config_cmd_default.h>
> > +
> > +#define CONFIG_CMD_DHCP
> > +#define CONFIG_CMD_PORTIO
> > +#define CONFIG_CMD_REGINFO
> > +#define CONFIG_CMD_SAVES
> > +
> > +/*
> > + * Miscellaneous configurable options
> > + */
> > +#define	CONFIG_LONGHELP
> > +#define	CONFIG_SYS_PROMPT		"MINI2440 => "
> > +#define	CONFIG_SYS_CBSIZE		256
> > +#define	CONFIG_SYS_PBSIZE	
> (CONFIG_SYS_CBSIZE+sizeof(CONFIG_SYS_PROMPT)+16)
> > +#define	CONFIG_SYS_MAXARGS		32
> > +#define CONFIG_SYS_BARGSIZE		CONFIG_SYS_CBSIZE
> > +
> > +#define CONFIG_SYS_MEMTEST_START	0x30000000
> > +#define CONFIG_SYS_MEMTEST_END		0x34000000	/* 64MB in DRAM	
> */
> > +
> > +/* everything, incl board info, in Hz */
> > +#undef  CONFIG_CLKS_IN_HZ
> > +
> > +/* default load address	*/
> > +#define	CONFIG_SYS_LOAD_ADDR		0x32000000
> > +
> > +/* boot parameters address */
> > +#define	CONFIG_BOOT_PARAM_ADDR		0x30000100
> > +
> > +/*
> > + * the PWM TImer 4 uses a counter of 15625 for 10 ms, so we need
> > + * it to wrap 100 times (total 1562500) to get 1 sec.
> > + */
> > +#define	CONFIG_SYS_HZ			1562500
> > +
> > +/*
> > + * valid baudrates
> > + */
> > +#define CONFIG_SYS_BAUDRATE_TABLE	{ 9600, 19200, 38400, 57600, 115200 }
> > +
> > +/*
> > + * Stack sizes
> > + * The stack sizes are set up in start.S using the settings below
> > + */
> > +#define CONFIG_STACKSIZE	(128*1024)	/* regular stack */
> > +#ifdef CONFIG_USE_IRQ
> > +#define CONFIG_STACKSIZE_IRQ	(8*1024)	/* IRQ stack */
> > +#define CONFIG_STACKSIZE_FIQ	(4*1024)	/* FIQ stack */
> > +#endif
> > +
> > +/*
> > + * Physical Memory Map
> > + */
> > +#define CONFIG_NR_DRAM_BANKS        1          /* we have 1 bank of DRAM
> > */ +#define PHYS_SDRAM_1                0x30000000 /* SDRAM Bank #1 */
> > +#define PHYS_SDRAM_1_SIZE           (64*1024*1024) /* 64MB of DRAM */
> > +#define CONFIG_SYS_SDRAM_BASE       PHYS_SDRAM_1
> > +#define CONFIG_SYS_INIT_SP_ADDR		(CONFIG_SYS_SDRAM_BASE + 0x1000 
> - \
> > +							GENERATED_GBL_DATA_SIZE)
> > +
> > +/*
> > + * When booting from NAND, it is impossible to access the lowest addresses
> > + * due to the SteppingStone being in the way. Luckily the NOR doesn't
> > really + * care about the highest 16 bits of address, so we set the
> > controlers + * registers to go and poke over there, instead.
> > + */
> > +#define PHYS_FLASH_1			0x0
> > +#define CONFIG_SYS_FLASH_BASE	0x0
> > +
> > +/*
> > + * NOR FLASH organization
> > + * Now uses the standard CFI interface
> > + * FLASH and environment organization
> > + */
> > +#define CONFIG_SYS_FLASH_CFI		1
> > +#define CONFIG_FLASH_CFI_DRIVER		1
> > +#define CONFIG_SYS_FLASH_CFI_WIDTH	FLASH_CFI_16BIT
> > +#define CONFIG_SYS_MONITOR_BASE		0x0
> > +/* max number of memory banks */
> > +#define CONFIG_SYS_MAX_FLASH_BANKS	1
> > +/* 512 * 4096 sectors, or 32 * 64k blocks */
> > +#define CONFIG_SYS_MAX_FLASH_SECT	512
> > +#define CONFIG_FLASH_SHOW_PROGRESS	1
> > +
> > +/*
> > + * u-boot environmnent
> > + */
> > +#define CONFIG_BOOTDELAY	3
> > +#define CONFIG_BOOTARGS		"root=/dev/sdb1 console=ttySAC0,115200"
> > +#define CONFIG_NETMASK      255.255.255.0
> > +#define CONFIG_IPADDR		192.168.0.2
> > +#define CONFIG_SERVERIP		192.168.0.1
> > +#define CONFIG_DOS_PARTITION	1
> > +#define CONFIG_BOOTCOMMAND "tftp 0x32000000 uImage;bootm"
> 
> DROP THIS!
> 

ok :-)

> > +
> > +/*
> > + * Config for NOR flash
> > + */
> > +#define CONFIG_ENV_IS_IN_FLASH	1
> > +#define CONFIG_MY_ENV_OFFSET	0x40000
> > +/* addr of environment */
> > +#define CONFIG_ENV_ADDR		(PHYS_FLASH_1 + CONFIG_MY_ENV_OFFSET)
> > +/* 16k Total Size of Environment Sector */
> > +#define CONFIG_ENV_SIZE		0x4000
> > +
> > +#define CONFIG_PREBOOT_OVERRIDE	1
> > +
> > +/* ATAG configuration */
> > +#define CONFIG_INITRD_TAG			1
> > +#define CONFIG_SETUP_MEMORY_TAGS	1
> > +#define CONFIG_CMDLINE_TAG			1
> > +#define CONFIG_CMDLINE_EDITING		1
> > +#define CONFIG_AUTO_COMPLETE		1
> > +
> > +#endif	/* __CONFIG_H */

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-19 20:16     ` Gabriel Huau
@ 2012-04-19 20:45       ` Marek Vasut
  2012-04-19 21:33         ` Gabriel Huau
  2012-04-19 21:37         ` Ilya Averyanov
  0 siblings, 2 replies; 42+ messages in thread
From: Marek Vasut @ 2012-04-19 20:45 UTC (permalink / raw)
  To: u-boot

Dear Gabriel Huau,

> On Thu, Apr 19, 2012 at 10:08:47PM +0200, Marek Vasut wrote:
> > Dear Gabriel Huau,
> > 
> > > ---
> > > 
> > > Changes for v2:
> > > 	- Coding style cleanup
> > > 	- Remove unnecessary files modification
> > > 	- Remove unnecessary board configuration set
> > > 
> > > Changes for v3:
> > > 	- Coding style cleanup
> > > 	- Move some macro definition from lowlevel_init.S
> > > 	to a new header
> > > 	- Remove some "magic bloat" with I/O board initialization
> > > 	- Add a pll_delay and replace loop by it
> > > 	- Somme cleanup in the configuration file
> > > 	- Cancel modifications on an SoC specific header
> > > 	- Add my name to copyright
> > > 
> > > ---
> > > 
> > >  board/friendlyarm/mini2440/Makefile        |   45 ++++++
> > >  board/friendlyarm/mini2440/lowlevel_init.S |   76 ++++++++++
> > >  board/friendlyarm/mini2440/mini2440.c      |  139 ++++++++++++++++++
> > >  board/friendlyarm/mini2440/mini2440.h      |  104 ++++++++++++++
> > >  boards.cfg                                 |    1 +
> > >  include/configs/mini2440.h                 |  215
> > > 
> > > ++++++++++++++++++++++++++++ 6 files changed, 580 insertions(+)
> > > 
> > >  create mode 100644 board/friendlyarm/mini2440/Makefile
> > >  create mode 100644 board/friendlyarm/mini2440/lowlevel_init.S
> > >  create mode 100644 board/friendlyarm/mini2440/mini2440.c
> > >  create mode 100644 board/friendlyarm/mini2440/mini2440.h
> > >  create mode 100644 include/configs/mini2440.h
> > > 
> > > diff --git a/board/friendlyarm/mini2440/Makefile
> > > b/board/friendlyarm/mini2440/Makefile new file mode 100644
> > > index 0000000..e8d68cb
> > > --- /dev/null
> > > +++ b/board/friendlyarm/mini2440/Makefile
> > > @@ -0,0 +1,45 @@
> > > +#
> > > +# (C) Copyright 2012
> > > +# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
> > > +#
> > > +# See file CREDITS for list of people who contributed to this
> > > +# project.
> > > +#
> > > +# This program is free software; you can redistribute it and/or
> > > +# modify it under the terms of the GNU General Public License as
> > > +# published by the Free Software Foundation; either version 2 of
> > > +# the License, or (at your option) any later version.
> > > +#
> > > +# This program is distributed in the hope that it will be useful,
> > > +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > +# GNU General Public License for more details.
> > > +#
> > > +# You should have received a copy of the GNU General Public License
> > > +# along with this program; if not, write to the Free Software
> > > +# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > > +# MA 02111-1307 USA
> > > +#
> > > +
> > > +include $(TOPDIR)/config.mk
> > > +
> > > +LIB	= $(obj)lib$(BOARD).o
> > > +
> > > +COBJS	:= mini2440.o
> > > +SOBJS	:= lowlevel_init.o
> > > +
> > > +SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
> > > +OBJS	:= $(addprefix $(obj),$(COBJS))
> > > +SOBJS	:= $(addprefix $(obj),$(SOBJS))
> > > +
> > > +$(LIB):	$(obj).depend $(OBJS) $(SOBJS)
> > > +	$(call cmd_link_o_target, $(OBJS) $(SOBJS))
> > > +
> > > +######################################################################
> > > ### +
> > > +# defines $(obj).depend target
> > > +include $(SRCTREE)/rules.mk
> > > +
> > > +sinclude $(obj).depend
> > > +
> > > +######################################################################
> > > ### diff --git a/board/friendlyarm/mini2440/lowlevel_init.S
> > > b/board/friendlyarm/mini2440/lowlevel_init.S new file mode 100644
> > > index 0000000..f69a08c
> > > --- /dev/null
> > > +++ b/board/friendlyarm/mini2440/lowlevel_init.S
> > > @@ -0,0 +1,76 @@
> > > +/*
> > > + * Memory Setup stuff - taken from blob memsetup.S
> > > + *
> > > + * Copyright (C) 1999 2000 2001 Erik Mouw (J.A.K.Mouw at its.tudelft.nl)
> > > and + *                     Jan-Derk Bakker
> > > (J.D.Bakker at its.tudelft.nl) + *
> > > + * Modified for the Samsung SMDK2410 by
> > > + * (C) Copyright 2002
> > > + * David Mueller, ELSOFT AG, <d.mueller@elsoft.ch>
> > > + *
> > > + * (C) Copyright 2012
> > > + * Gabriel Huau <contact@huau-gabriel.fr>
> > > + *
> > > + * See file CREDITS for list of people who contributed to this
> > > + * project.
> > > + *
> > > + * This program is free software; you can redistribute it and/or
> > > + * modify it under the terms of the GNU General Public License as
> > > + * published by the Free Software Foundation; either version 2 of
> > > + * the License, or (at your option) any later version.
> > > + *
> > > + * This program is distributed in the hope that it will be useful,
> > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > + * GNU General Public License for more details.
> > > + *
> > > + * You should have received a copy of the GNU General Public License
> > > + * along with this program; if not, write to the Free Software
> > > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > > + * MA 02111-1307 USA
> > > + */
> > > +
> > > +#include <config.h>
> > > +#include <version.h>
> > > +#include "mini2440.h"
> > > +
> > > +_TEXT_BASE:
> > > +	.word	CONFIG_SYS_TEXT_BASE
> > > +
> > > +.globl lowlevel_init
> > > +lowlevel_init:
> > > +	/* memory control configuration */
> > > +	/* make r0 relative the current location so that it */
> > > +	/* reads SMRDATA out of FLASH rather than memory ! */
> > > +	ldr     r0, =SMRDATA
> > > +	ldr	r1, _TEXT_BASE
> > > +	sub	r0, r0, r1
> > > +	ldr	r1, =BWSCON	/* Bus Width Status Controller */
> > > +	add     r2, r0, #13*4
> > > +0:
> > > +	ldr     r3, [r0], #4
> > > +	str     r3, [r1], #4
> > > +	cmp     r2, r0
> > > +	bne     0b
> > > +
> > > +	/* everything is fine now */
> > > +	mov	pc, lr
> > > +
> > > +	.ltorg
> > > +/* the literal pools origin */
> > > +
> > > +SMRDATA:
> > > +    .word
> > > (0+(B1_BWSCON<<4)+(B2_BWSCON<<8)+(B3_BWSCON<<12)+(B4_BWSCON<<16)+(B5_BW
> > > SCO N<<20)+(B6_BWSCON<<24)+(B7_BWSCON<<28)) +    .word
> > > ((B0_Tacs<<13)+(B0_Tcos<<11)+(B0_Tacc<<8)+(B0_Tcoh<<6)+(B0_Tah<<4)+(B0_
> > > Tac p<<2)+(B0_PMC)) +    .word
> > > ((B1_Tacs<<13)+(B1_Tcos<<11)+(B1_Tacc<<8)+(B1_Tcoh<<6)+(B1_Tah<<4)+(B1_
> > > Tac p<<2)+(B1_PMC)) +    .word
> > > ((B2_Tacs<<13)+(B2_Tcos<<11)+(B2_Tacc<<8)+(B2_Tcoh<<6)+(B2_Tah<<4)+(B2_
> > > Tac p<<2)+(B2_PMC)) +    .word
> > > ((B3_Tacs<<13)+(B3_Tcos<<11)+(B3_Tacc<<8)+(B3_Tcoh<<6)+(B3_Tah<<4)+(B3_
> > > Tac p<<2)+(B3_PMC)) +    .word
> > > ((B4_Tacs<<13)+(B4_Tcos<<11)+(B4_Tacc<<8)+(B4_Tcoh<<6)+(B4_Tah<<4)+(B4_
> > > Tac p<<2)+(B4_PMC)) +    .word
> > > ((B5_Tacs<<13)+(B5_Tcos<<11)+(B5_Tacc<<8)+(B5_Tcoh<<6)+(B5_Tah<<4)+(B5_
> > > Tac p<<2)+(B5_PMC)) +
> > > +    .word ((B6_MT<<15)+(B6_Trcd<<2)+(B6_SCAN))
> > > +    .word ((B7_MT<<15)+(B7_Trcd<<2)+(B7_SCAN))
> > > +    .word
> > > ((REFEN<<23)+(TREFMD<<22)+(Trp<<20)+(Trc<<18)+(Tchr<<16)+REFCNT) +   
> > > .word 0x32
> > > +    .word 0x30
> > > +    .word 0x30
> > 
> > What this undocumented stuff?
> 
> SoC specific, I pasted it from smdk2410, it's for initialize the DRAM.

Can't you init DRAM in some more fitting place? Also document this?

> > > diff --git a/board/friendlyarm/mini2440/mini2440.c
> > > b/board/friendlyarm/mini2440/mini2440.c new file mode 100644
> > > index 0000000..9ba8d39
> > > --- /dev/null
> > > +++ b/board/friendlyarm/mini2440/mini2440.c
> > > @@ -0,0 +1,139 @@
> > > +/*
> > > + * (C) Copyright 2002
> > > + * Sysgo Real-Time Solutions, GmbH <www.elinos.com>
> > > + * Marius Groeger <mgroeger@sysgo.de>
> > > + *
> > > + * (C) Copyright 2002
> > > + * David Mueller, ELSOFT AG, <d.mueller@elsoft.ch>
> > > + *
> > > + * (C) Copyright 2009
> > > + * Michel Pollet <buserror@gmail.com>
> > > + *
> > > + * (C) Copyright 2012
> > > + * Gabriel Huau <contact@huau-gabriel.fr>
> > > + *
> > > + * See file CREDITS for list of people who contributed to this
> > > + * project.
> > > + *
> > > + * This program is free software; you can redistribute it and/or
> > > + * modify it under the terms of the GNU General Public License as
> > > + * published by the Free Software Foundation; either version 2 of
> > > + * the License, or (at your option) any later version.
> > > + *
> > > + * This program is distributed in the hope that it will be useful,
> > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > + * GNU General Public License for more details.
> > > + *
> > > + * You should have received a copy of the GNU General Public License
> > > + * along with this program; if not, write to the Free Software
> > > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > > + * MA 02111-1307 USA
> > > + */
> > > +
> > > +#include <common.h>
> > > +#include <asm/arch/s3c2440.h>
> > > +#include <asm/io.h>
> > > +#include <video_fb.h>
> > > +#include "mini2440.h"
> > > +
> > > +#ifdef CONFIG_DRIVER_DM9000
> > > +#include <netdev.h>
> > > +#endif
> > > +
> > > +DECLARE_GLOBAL_DATA_PTR;
> > > +
> > > +static inline void pll_delay(unsigned long loops)
> > > +{
> > > +	__asm__ volatile ("1:\n"
> > > +	  "subs %0, %1, #1\n"
> > > +	  "bne 1b" : "=r" (loops) : "0" (loops));
> > > +}
> > > +
> > > +int arch_cpu_init(void)
> > > +{
> > > +	struct s3c24x0_clock_power * const clk_power =
> > > +					s3c24x0_get_base_clock_power();
> > > +
> > > +	/* to reduce PLL lock time, adjust the LOCKTIME register */
> > > +	clk_power->locktime = 0xFFFFFF;
> > > +	clk_power->clkdivn = CLKDIVN_VAL;
> > > +
> > > +	/* configure UPLL */
> > > +	clk_power->upllcon = ((U_M_MDIV << 12) + (U_M_PDIV << 4) + U_M_SDIV);
> > > +	/* some delay between MPLL and UPLL */
> > > +	pll_delay(100000);
> > > +
> > > +	/* configure MPLL */
> > > +	clk_power->mpllcon = ((M_MDIV << 12) + (M_PDIV << 4) + M_SDIV);
> > > +
> > > +	/* some delay between MPLL and UPLL */
> > > +	pll_delay(500000);
> > 
> > You use udelay() below, do you need pll_delay() at all?
> 
> Yes, because initialisation of PLL is done before timer_init(), so we
> can't use udelay().

Maybe fix the timer driver?

> > > +
> > > +	return 0;
> > > +}
> > > +
> > > +/*
> > > + * Miscellaneous platform dependent initialisations
> > > + */
> > > +int board_init(void)
> > > +{
> > > +	struct s3c24x0_clock_power * const clk_power =
> > > +					s3c24x0_get_base_clock_power();
> > > +	struct s3c24x0_gpio * const gpio = s3c24x0_get_base_gpio();
> > > +
> > > +	/* to reduce PLL lock time, adjust the LOCKTIME register */
> > > +	clk_power->locktime = 0xFFFFFF;
> > > +	clk_power->clkdivn = CLKDIVN_VAL;
> > > +
> > > +	/* configure UPLL */
> > > +	clk_power->upllcon = ((U_M_MDIV << 12) + (U_M_PDIV << 4) + U_M_SDIV);
> > > +	/* some delay between MPLL and UPLL */
> > > +	udelay(10);
> > > +	/* configure MPLL */
> > > +	clk_power->mpllcon = ((M_MDIV << 12) + (M_PDIV << 4) + M_SDIV);
> > > +
> > > +	/* some delay between MPLL and UPLL */
> > > +	udelay(8000);
> > > +
> > > +	/* set up the I/O ports */
> > > +	writel(0x007FFFFF, &gpio->gpacon);
> > > +	writel(0x00044555, &gpio->gpbcon);
> > > +	writel(0x000007FF, &gpio->gpbup);
> > > +	writel(0xAAAAAAAA, &gpio->gpccon);
> > > +	writel(0x0000FFFF, &gpio->gpcup);
> > > +	writel(0xAAAAAAAA, &gpio->gpdcon);
> > > +	writel(0x0000FFFF, &gpio->gpdup);
> > > +	writel(0xAAAAAAAA, &gpio->gpecon);
> > > +	writel(0x0000FFFF, &gpio->gpeup);
> > > +	writel(0x000055AA, &gpio->gpfcon);
> > > +	writel(0x000000FF, &gpio->gpfup);
> > > +	writel(0xFF95FFBA, &gpio->gpgcon);
> > > +	writel(0x0000FFFF, &gpio->gpgup);
> > > +	writel(0x002AFAAA, &gpio->gphcon);
> > > +	writel(0x000007FF, &gpio->gphup);
> > > +
> > > +	/* adress of boot parameters */
> > > +	gd->bd->bi_boot_params = CONFIG_BOOT_PARAM_ADDR;
> > > +
> > > +	return 0;
> > > +}
> > > +
> > > +int dram_init(void)
> > > +{
> > > +	gd->ram_size = PHYS_SDRAM_1_SIZE;
> > > +	return 0;
> > > +}
> > > +
> > > +int board_eth_init(bd_t *bis)
> > > +{
> > > +#ifdef CONFIG_DRIVER_DM9000
> > > +	return dm9000_initialize(bis);
> > > +#else
> > > +	return 0;
> > > +#endif
> > > +}
> > > +
> > > +/* The sum of all part_size[]s must equal to the NAND size, i.e.,
> > > 0x4000000 */ +unsigned int dynpart_size[] = { 0x40000, 0x20000,
> > > 0x500000, 0xffffffff, 0 }; +char *dynpart_names[] = { "u-boot",
> > > "u-boot_env", "kernel", "rootfs", NULL }; diff --git
> > > a/board/friendlyarm/mini2440/mini2440.h
> > > b/board/friendlyarm/mini2440/mini2440.h new file mode 100644
> > > index 0000000..02197c8
> > > --- /dev/null
> > > +++ b/board/friendlyarm/mini2440/mini2440.h
> > > @@ -0,0 +1,104 @@
> > > +/*
> > > + * Taken from linux/arch/arm/boot/compressed/head-s3c2410.S
> > > + * Copyright (C) 2002 Samsung Electronics SW.LEE
> > > <hitchcar@sec.samsung.com> + */
> > > +
> > > +#ifndef BOARD_LL_MINI2440_H
> > > +#define BOARD_LL_MINI2440_H
> > > +
> > > +/*
> > > + * PLL/Clock configuration
> > > + */
> > > +/* FCLK = 405 MHz, HCLK = 101 MHz, PCLK = 50 MHz, UCLK = 48 MHz */
> > > +#define CLKDIVN_VAL	7
> > > +#define M_MDIV		0x7f
> > > +#define M_PDIV		0x2
> > > +#define M_SDIV		0x1
> > > +
> > > +#define U_M_MDIV	0x38
> > > +#define U_M_PDIV	0x2
> > > +#define U_M_SDIV	0x2
> > > +
> > > +/* BWSCON */
> > > +#define BWSCON	0x48000000
> > > +#define DW8		(0x0)
> > > +#define DW16	(0x1)
> > > +#define DW32	(0x2)
> > > +#define WAIT	(0x1<<2)
> > > +#define UBLB	(0x1<<3)
> > > +
> > > +#define B1_BWSCON		(DW32)
> > > +#define B2_BWSCON		(DW16)
> > > +#define B3_BWSCON		(DW16 + WAIT + UBLB)
> > > +#define B4_BWSCON		(DW16)
> > > +#define B5_BWSCON		(DW16)
> > > +#define B6_BWSCON		(DW32)
> > > +#define B7_BWSCON		(DW32)
> > > +
> > > +/* BANK0CON */
> > > +#define B0_Tacs		0x0	/*  0clk */
> > > +#define B0_Tcos		0x0	/*  0clk */
> > > +#define B0_Tacc		0x7	/* 14clk */
> > > +#define B0_Tcoh		0x0	/*  0clk */
> > > +#define B0_Tah		0x0	/*  0clk */
> > > +#define B0_Tacp		0x0
> > > +#define B0_PMC		0x0	/* normal */
> > > +
> > > +/* BANK1CON */
> > > +#define B1_Tacs		0x0	/*  0clk */
> > > +#define B1_Tcos		0x0	/*  0clk */
> > > +#define B1_Tacc		0x7	/* 14clk */
> > > +#define B1_Tcoh		0x0	/*  0clk */
> > > +#define B1_Tah		0x0	/*  0clk */
> > > +#define B1_Tacp		0x0
> > > +#define B1_PMC		0x0
> > > +
> > > +#define B2_Tacs		0x0
> > > +#define B2_Tcos		0x0
> > > +#define B2_Tacc		0x7
> > > +#define B2_Tcoh		0x0
> > > +#define B2_Tah		0x0
> > > +#define B2_Tacp		0x0
> > > +#define B2_PMC		0x0
> > > +
> > > +#define B3_Tacs		0x0	/*  0clk */
> > > +#define B3_Tcos		0x3	/*  4clk */
> > > +#define B3_Tacc		0x7	/* 14clk */
> > > +#define B3_Tcoh		0x1	/*  1clk */
> > > +#define B3_Tah		0x0	/*  0clk */
> > > +#define B3_Tacp		0x3     /*  6clk */
> > > +#define B3_PMC		0x0	/* normal */
> > > +
> > > +#define B4_Tacs		0x0	/*  0clk */
> > > +#define B4_Tcos		0x0	/*  0clk */
> > > +#define B4_Tacc		0x7	/* 14clk */
> > > +#define B4_Tcoh		0x0	/*  0clk */
> > > +#define B4_Tah		0x0	/*  0clk */
> > > +#define B4_Tacp		0x0
> > > +#define B4_PMC		0x0	/* normal */
> > > +
> > > +#define B5_Tacs		0x0	/*  0clk */
> > > +#define B5_Tcos		0x0	/*  0clk */
> > > +#define B5_Tacc		0x7	/* 14clk */
> > > +#define B5_Tcoh		0x0	/*  0clk */
> > > +#define B5_Tah		0x0	/*  0clk */
> > > +#define B5_Tacp		0x0
> > > +#define B5_PMC		0x0	/* normal */
> > > +
> > > +#define B6_MT		0x3	/* SDRAM */
> > > +#define B6_Trcd		0x1
> > > +#define B6_SCAN		0x1	/* 9bit */
> > > +
> > > +#define B7_MT		0x3	/* SDRAM */
> > > +#define B7_Trcd		0x1	/* 3clk */
> > > +#define B7_SCAN		0x1	/* 9bit */
> > > +
> > > +/* REFRESH parameter */
> > > +#define REFEN		0x1	/* Refresh enable */
> > > +#define TREFMD		0x0	/* CBR(CAS before RAS)/Auto refresh */
> > > +#define Trp			0x0	/* 2clk */
> > > +#define Trc			0x3	/* 7clk */
> > > +#define Tchr		0x2	/* 3clk */
> > > +#define REFCNT		1113	/* period=15.6us, HCLK=60Mhz */
> > > +
> > > +#endif
> > > diff --git a/boards.cfg b/boards.cfg
> > > index 3cf75c3..93eeb3c 100644
> > > --- a/boards.cfg
> > > +++ b/boards.cfg
> > > @@ -61,6 +61,7 @@ mx1ads                       arm         arm920t    
> > > -
> > > 
> > >                - scb9328                      arm         arm920t     -
> > >                -              imx cm4008                       arm
> > > 
> > > arm920t     -                   -              ks8695 cm41xx
> > > 
> > >         arm         arm920t     -                   -             
> > >         ks8695
> > > 
> > > +mini2440                     arm         arm920t     mini2440
> > > friendlyarm    s3c24x0 VCMA9                        arm         arm920t
> > > 
> > >  vcma9               mpl            s3c24x0 smdk2410
> > > 
> > > arm         arm920t     -                   samsung        s3c24x0
> > > omap1510inn                  arm         arm925t     -
> > > ti diff --git a/include/configs/mini2440.h b/include/configs/mini2440.h
> > > new file mode 100644
> > > index 0000000..a3f06d0
> > > --- /dev/null
> > > +++ b/include/configs/mini2440.h
> > > @@ -0,0 +1,215 @@
> > > +/*
> > > + * (C) Copyright 2002
> > > + * Sysgo Real-Time Solutions, GmbH <www.elinos.com>
> > > + * Marius Groeger <mgroeger@sysgo.de>
> > > + * Gary Jennejohn <gj@denx.de>
> > > + * David Mueller <d.mueller@elsoft.ch>
> > > + *
> > > + * (C) Copyright 2009-2010
> > > + * Michel Pollet <buserror@gmail.com>
> > > + *
> > > + * (C) Copyright 2012
> > > + * Gabriel Huau <contact@huau-gabriel.fr>
> > > + *
> > > + * Configuation settings for the MINI2440 board.
> > > + *
> > > + * See file CREDITS for list of people who contributed to this
> > > + * project.
> > > + *
> > > + * This program is free software; you can redistribute it and/or
> > > + * modify it under the terms of the GNU General Public License as
> > > + * published by the Free Software Foundation; either version 2 of
> > > + * the License, or (at your option) any later version.
> > > + *
> > > + * This program is distributed in the hope that it will be useful,
> > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > + * GNU General Public License for more details.
> > > + *
> > > + * You should have received a copy of the GNU General Public License
> > > + * along with this program; if not, write to the Free Software
> > > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > > + * MA 02111-1307 USA
> > > + */
> > > +
> > > +#ifndef __CONFIG_H
> > > +#define __CONFIG_H
> > > +
> > > +#define CONFIG_SYS_TEXT_BASE 0x0
> > > +
> > > +/*
> > > + * High Level Configuration Options
> > > + */
> > > +#define CONFIG_ARM920T		1	/* This is an ARM920T Core
> > 
> > */
> > 
> > > +#define CONFIG_S3C24X0		1	/* in a SAMSUNG S3C2440 SoC */
> > > +#define CONFIG_S3C2440		1	/* in a SAMSUNG S3C2440 SoC */
> > > +#define CONFIG_MINI2440		1	/* on a MIN2440 Board       */
> > > +
> > > +#define	MACH_TYPE_MINI2440	1999
> > > +#define	CONFIG_MACH_TYPE	MACH_TYPE_MINI2440
> > > +
> > > +/*
> > > + * It is possible to have u-boot save it's environment in NOR,
> > > however, + * reember it is incompatible with booting from NAND as the
> > > NOR is not + * available at that point. So use this only if you use
> > > nand as storage + * and will never boot from it
> > > + */
> > > +#define CONFIG_MINI2440_NOR_ENV	1
> > > +/* allow use of frequencies over 405Mhz */
> > > +#define CONFIG_MINI2440_OVERCLOCK 1
> > > +
> > > +/*
> > > + * input clock of PLL
> > > + */
> > > +/* MINI2440 has 12.0000MHz input clock */
> > > +#define CONFIG_SYS_CLK_FREQ	12000000
> > > +#define CONFIG_ARCH_CPU_INIT 1 /* for the initialization of PLL */
> > > +
> > > +#define USE_920T_MMU		1
> > > +#define CONFIG_BAUDRATE		115200
> > > +
> > > +/*
> > > + * Size of malloc() pool
> > > + */
> > > +#define CONFIG_SYS_MALLOC_LEN	(CONFIG_ENV_SIZE + 2048*1024)
> > > +/* size in bytes reserved for initial data */
> > > +#define CONFIG_GBL_DATA_SIZE	128
> > > +
> > > +/*
> > > + * Hardware drivers
> > > + */
> > > +#define CONFIG_DRIVER_DM9000			1
> > > +#define CONFIG_DRIVER_DM9000_NO_EEPROM	1
> > > +#define CONFIG_DM9000_BASE				0x20000300
> > > +#define DM9000_IO		CONFIG_DM9000_BASE
> > > +#define DM9000_DATA		(CONFIG_DM9000_BASE+4)
> > > +
> > > +/*
> > > + * select serial console configuration
> > > + */
> > > +#define CONFIG_S3C24X0_SERIAL
> > > +#define CONFIG_SERIAL1			1
> > > +
> > > +/*
> > > + * allow to overwrite serial and ethaddr
> > > + */
> > > +#define CONFIG_ENV_OVERWRITE
> > > +
> > > +/*
> > > + * Command definition
> > > + */
> > > +#include <config_cmd_default.h>
> > > +
> > > +#define CONFIG_CMD_DHCP
> > > +#define CONFIG_CMD_PORTIO
> > > +#define CONFIG_CMD_REGINFO
> > > +#define CONFIG_CMD_SAVES
> > > +
> > > +/*
> > > + * Miscellaneous configurable options
> > > + */
> > > +#define	CONFIG_LONGHELP
> > > +#define	CONFIG_SYS_PROMPT		"MINI2440 => "
> > > +#define	CONFIG_SYS_CBSIZE		256
> > > +#define	CONFIG_SYS_PBSIZE
> > 
> > (CONFIG_SYS_CBSIZE+sizeof(CONFIG_SYS_PROMPT)+16)
> > 
> > > +#define	CONFIG_SYS_MAXARGS		32
> > > +#define CONFIG_SYS_BARGSIZE		CONFIG_SYS_CBSIZE
> > > +
> > > +#define CONFIG_SYS_MEMTEST_START	0x30000000
> > > +#define CONFIG_SYS_MEMTEST_END		0x34000000	/* 64MB in DRAM
> > 
> > */
> > 
> > > +
> > > +/* everything, incl board info, in Hz */
> > > +#undef  CONFIG_CLKS_IN_HZ
> > > +
> > > +/* default load address	*/
> > > +#define	CONFIG_SYS_LOAD_ADDR		0x32000000
> > > +
> > > +/* boot parameters address */
> > > +#define	CONFIG_BOOT_PARAM_ADDR		0x30000100
> > > +
> > > +/*
> > > + * the PWM TImer 4 uses a counter of 15625 for 10 ms, so we need
> > > + * it to wrap 100 times (total 1562500) to get 1 sec.
> > > + */
> > > +#define	CONFIG_SYS_HZ			1562500
> > > +
> > > +/*
> > > + * valid baudrates
> > > + */
> > > +#define CONFIG_SYS_BAUDRATE_TABLE	{ 9600, 19200, 38400, 57600, 
115200
> > > } +
> > > +/*
> > > + * Stack sizes
> > > + * The stack sizes are set up in start.S using the settings below
> > > + */
> > > +#define CONFIG_STACKSIZE	(128*1024)	/* regular stack */
> > > +#ifdef CONFIG_USE_IRQ
> > > +#define CONFIG_STACKSIZE_IRQ	(8*1024)	/* IRQ stack */
> > > +#define CONFIG_STACKSIZE_FIQ	(4*1024)	/* FIQ stack */
> > > +#endif
> > > +
> > > +/*
> > > + * Physical Memory Map
> > > + */
> > > +#define CONFIG_NR_DRAM_BANKS        1          /* we have 1 bank of
> > > DRAM */ +#define PHYS_SDRAM_1                0x30000000 /* SDRAM Bank
> > > #1 */ +#define PHYS_SDRAM_1_SIZE           (64*1024*1024) /* 64MB of
> > > DRAM */ +#define CONFIG_SYS_SDRAM_BASE       PHYS_SDRAM_1
> > > +#define CONFIG_SYS_INIT_SP_ADDR		(CONFIG_SYS_SDRAM_BASE + 0x1000
> > 
> > - \
> > 
> > > +							GENERATED_GBL_DATA_SIZE)
> > > +
> > > +/*
> > > + * When booting from NAND, it is impossible to access the lowest
> > > addresses + * due to the SteppingStone being in the way. Luckily the
> > > NOR doesn't really + * care about the highest 16 bits of address, so
> > > we set the controlers + * registers to go and poke over there,
> > > instead.
> > > + */
> > > +#define PHYS_FLASH_1			0x0
> > > +#define CONFIG_SYS_FLASH_BASE	0x0
> > > +
> > > +/*
> > > + * NOR FLASH organization
> > > + * Now uses the standard CFI interface
> > > + * FLASH and environment organization
> > > + */
> > > +#define CONFIG_SYS_FLASH_CFI		1
> > > +#define CONFIG_FLASH_CFI_DRIVER		1
> > > +#define CONFIG_SYS_FLASH_CFI_WIDTH	FLASH_CFI_16BIT
> > > +#define CONFIG_SYS_MONITOR_BASE		0x0
> > > +/* max number of memory banks */
> > > +#define CONFIG_SYS_MAX_FLASH_BANKS	1
> > > +/* 512 * 4096 sectors, or 32 * 64k blocks */
> > > +#define CONFIG_SYS_MAX_FLASH_SECT	512
> > > +#define CONFIG_FLASH_SHOW_PROGRESS	1
> > > +
> > > +/*
> > > + * u-boot environmnent
> > > + */
> > > +#define CONFIG_BOOTDELAY	3
> > > +#define CONFIG_BOOTARGS		"root=/dev/sdb1 console=ttySAC0,115200"
> > > +#define CONFIG_NETMASK      255.255.255.0
> > > +#define CONFIG_IPADDR		192.168.0.2
> > > +#define CONFIG_SERVERIP		192.168.0.1
> > > +#define CONFIG_DOS_PARTITION	1
> > > +#define CONFIG_BOOTCOMMAND "tftp 0x32000000 uImage;bootm"
> > 
> > DROP THIS!
> 
> ok :-)
> 
> > > +
> > > +/*
> > > + * Config for NOR flash
> > > + */
> > > +#define CONFIG_ENV_IS_IN_FLASH	1
> > > +#define CONFIG_MY_ENV_OFFSET	0x40000
> > > +/* addr of environment */
> > > +#define CONFIG_ENV_ADDR		(PHYS_FLASH_1 + CONFIG_MY_ENV_OFFSET)
> > > +/* 16k Total Size of Environment Sector */
> > > +#define CONFIG_ENV_SIZE		0x4000
> > > +
> > > +#define CONFIG_PREBOOT_OVERRIDE	1
> > > +
> > > +/* ATAG configuration */
> > > +#define CONFIG_INITRD_TAG			1
> > > +#define CONFIG_SETUP_MEMORY_TAGS	1
> > > +#define CONFIG_CMDLINE_TAG			1
> > > +#define CONFIG_CMDLINE_EDITING		1
> > > +#define CONFIG_AUTO_COMPLETE		1
> > > +
> > > +#endif	/* __CONFIG_H */

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-19 20:45       ` Marek Vasut
@ 2012-04-19 21:33         ` Gabriel Huau
  2012-04-19 22:22           ` Marek Vasut
  2012-04-19 21:37         ` Ilya Averyanov
  1 sibling, 1 reply; 42+ messages in thread
From: Gabriel Huau @ 2012-04-19 21:33 UTC (permalink / raw)
  To: u-boot

On Thu, Apr 19, 2012 at 10:45:21PM +0200, Marek Vasut wrote:
> Dear Gabriel Huau,
> 
> > On Thu, Apr 19, 2012 at 10:08:47PM +0200, Marek Vasut wrote:
> > > Dear Gabriel Huau,
> > > 
> > > > ---
> > > > 
> > > > Changes for v2:
> > > > 	- Coding style cleanup
> > > > 	- Remove unnecessary files modification
> > > > 	- Remove unnecessary board configuration set
> > > > 
> > > > Changes for v3:
> > > > 	- Coding style cleanup
> > > > 	- Move some macro definition from lowlevel_init.S
> > > > 	to a new header
> > > > 	- Remove some "magic bloat" with I/O board initialization
> > > > 	- Add a pll_delay and replace loop by it
> > > > 	- Somme cleanup in the configuration file
> > > > 	- Cancel modifications on an SoC specific header
> > > > 	- Add my name to copyright
> > > > 
> > > > ---
> > > > 
> > > >  board/friendlyarm/mini2440/Makefile        |   45 ++++++
> > > >  board/friendlyarm/mini2440/lowlevel_init.S |   76 ++++++++++
> > > >  board/friendlyarm/mini2440/mini2440.c      |  139 ++++++++++++++++++
> > > >  board/friendlyarm/mini2440/mini2440.h      |  104 ++++++++++++++
> > > >  boards.cfg                                 |    1 +
> > > >  include/configs/mini2440.h                 |  215
> > > > 
> > > > ++++++++++++++++++++++++++++ 6 files changed, 580 insertions(+)
> > > > 
> > > >  create mode 100644 board/friendlyarm/mini2440/Makefile
> > > >  create mode 100644 board/friendlyarm/mini2440/lowlevel_init.S
> > > >  create mode 100644 board/friendlyarm/mini2440/mini2440.c
> > > >  create mode 100644 board/friendlyarm/mini2440/mini2440.h
> > > >  create mode 100644 include/configs/mini2440.h
> > > > 
> > > > diff --git a/board/friendlyarm/mini2440/Makefile
> > > > b/board/friendlyarm/mini2440/Makefile new file mode 100644
> > > > index 0000000..e8d68cb
> > > > --- /dev/null
> > > > +++ b/board/friendlyarm/mini2440/Makefile
> > > > @@ -0,0 +1,45 @@
> > > > +#
> > > > +# (C) Copyright 2012
> > > > +# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
> > > > +#
> > > > +# See file CREDITS for list of people who contributed to this
> > > > +# project.
> > > > +#
> > > > +# This program is free software; you can redistribute it and/or
> > > > +# modify it under the terms of the GNU General Public License as
> > > > +# published by the Free Software Foundation; either version 2 of
> > > > +# the License, or (at your option) any later version.
> > > > +#
> > > > +# This program is distributed in the hope that it will be useful,
> > > > +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > > +# GNU General Public License for more details.
> > > > +#
> > > > +# You should have received a copy of the GNU General Public License
> > > > +# along with this program; if not, write to the Free Software
> > > > +# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > > > +# MA 02111-1307 USA
> > > > +#
> > > > +
> > > > +include $(TOPDIR)/config.mk
> > > > +
> > > > +LIB	= $(obj)lib$(BOARD).o
> > > > +
> > > > +COBJS	:= mini2440.o
> > > > +SOBJS	:= lowlevel_init.o
> > > > +
> > > > +SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
> > > > +OBJS	:= $(addprefix $(obj),$(COBJS))
> > > > +SOBJS	:= $(addprefix $(obj),$(SOBJS))
> > > > +
> > > > +$(LIB):	$(obj).depend $(OBJS) $(SOBJS)
> > > > +	$(call cmd_link_o_target, $(OBJS) $(SOBJS))
> > > > +
> > > > +######################################################################
> > > > ### +
> > > > +# defines $(obj).depend target
> > > > +include $(SRCTREE)/rules.mk
> > > > +
> > > > +sinclude $(obj).depend
> > > > +
> > > > +######################################################################
> > > > ### diff --git a/board/friendlyarm/mini2440/lowlevel_init.S
> > > > b/board/friendlyarm/mini2440/lowlevel_init.S new file mode 100644
> > > > index 0000000..f69a08c
> > > > --- /dev/null
> > > > +++ b/board/friendlyarm/mini2440/lowlevel_init.S
> > > > @@ -0,0 +1,76 @@
> > > > +/*
> > > > + * Memory Setup stuff - taken from blob memsetup.S
> > > > + *
> > > > + * Copyright (C) 1999 2000 2001 Erik Mouw (J.A.K.Mouw at its.tudelft.nl)
> > > > and + *                     Jan-Derk Bakker
> > > > (J.D.Bakker at its.tudelft.nl) + *
> > > > + * Modified for the Samsung SMDK2410 by
> > > > + * (C) Copyright 2002
> > > > + * David Mueller, ELSOFT AG, <d.mueller@elsoft.ch>
> > > > + *
> > > > + * (C) Copyright 2012
> > > > + * Gabriel Huau <contact@huau-gabriel.fr>
> > > > + *
> > > > + * See file CREDITS for list of people who contributed to this
> > > > + * project.
> > > > + *
> > > > + * This program is free software; you can redistribute it and/or
> > > > + * modify it under the terms of the GNU General Public License as
> > > > + * published by the Free Software Foundation; either version 2 of
> > > > + * the License, or (at your option) any later version.
> > > > + *
> > > > + * This program is distributed in the hope that it will be useful,
> > > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > > + * GNU General Public License for more details.
> > > > + *
> > > > + * You should have received a copy of the GNU General Public License
> > > > + * along with this program; if not, write to the Free Software
> > > > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > > > + * MA 02111-1307 USA
> > > > + */
> > > > +
> > > > +#include <config.h>
> > > > +#include <version.h>
> > > > +#include "mini2440.h"
> > > > +
> > > > +_TEXT_BASE:
> > > > +	.word	CONFIG_SYS_TEXT_BASE
> > > > +
> > > > +.globl lowlevel_init
> > > > +lowlevel_init:
> > > > +	/* memory control configuration */
> > > > +	/* make r0 relative the current location so that it */
> > > > +	/* reads SMRDATA out of FLASH rather than memory ! */
> > > > +	ldr     r0, =SMRDATA
> > > > +	ldr	r1, _TEXT_BASE
> > > > +	sub	r0, r0, r1
> > > > +	ldr	r1, =BWSCON	/* Bus Width Status Controller */
> > > > +	add     r2, r0, #13*4
> > > > +0:
> > > > +	ldr     r3, [r0], #4
> > > > +	str     r3, [r1], #4
> > > > +	cmp     r2, r0
> > > > +	bne     0b
> > > > +
> > > > +	/* everything is fine now */
> > > > +	mov	pc, lr
> > > > +
> > > > +	.ltorg
> > > > +/* the literal pools origin */
> > > > +
> > > > +SMRDATA:
> > > > +    .word
> > > > (0+(B1_BWSCON<<4)+(B2_BWSCON<<8)+(B3_BWSCON<<12)+(B4_BWSCON<<16)+(B5_BW
> > > > SCO N<<20)+(B6_BWSCON<<24)+(B7_BWSCON<<28)) +    .word
> > > > ((B0_Tacs<<13)+(B0_Tcos<<11)+(B0_Tacc<<8)+(B0_Tcoh<<6)+(B0_Tah<<4)+(B0_
> > > > Tac p<<2)+(B0_PMC)) +    .word
> > > > ((B1_Tacs<<13)+(B1_Tcos<<11)+(B1_Tacc<<8)+(B1_Tcoh<<6)+(B1_Tah<<4)+(B1_
> > > > Tac p<<2)+(B1_PMC)) +    .word
> > > > ((B2_Tacs<<13)+(B2_Tcos<<11)+(B2_Tacc<<8)+(B2_Tcoh<<6)+(B2_Tah<<4)+(B2_
> > > > Tac p<<2)+(B2_PMC)) +    .word
> > > > ((B3_Tacs<<13)+(B3_Tcos<<11)+(B3_Tacc<<8)+(B3_Tcoh<<6)+(B3_Tah<<4)+(B3_
> > > > Tac p<<2)+(B3_PMC)) +    .word
> > > > ((B4_Tacs<<13)+(B4_Tcos<<11)+(B4_Tacc<<8)+(B4_Tcoh<<6)+(B4_Tah<<4)+(B4_
> > > > Tac p<<2)+(B4_PMC)) +    .word
> > > > ((B5_Tacs<<13)+(B5_Tcos<<11)+(B5_Tacc<<8)+(B5_Tcoh<<6)+(B5_Tah<<4)+(B5_
> > > > Tac p<<2)+(B5_PMC)) +
> > > > +    .word ((B6_MT<<15)+(B6_Trcd<<2)+(B6_SCAN))
> > > > +    .word ((B7_MT<<15)+(B7_Trcd<<2)+(B7_SCAN))
> > > > +    .word
> > > > ((REFEN<<23)+(TREFMD<<22)+(Trp<<20)+(Trc<<18)+(Tchr<<16)+REFCNT) +   
> > > > .word 0x32
> > > > +    .word 0x30
> > > > +    .word 0x30
> > > 
> > > What this undocumented stuff?
> > 
> > SoC specific, I pasted it from smdk2410, it's for initialize the DRAM.
> 
> Can't you init DRAM in some more fitting place? Also document this?
> 

I don't know, this part is a bit difficult for me, but I'm going to try
to document it with the help of the SoC documentation.

For the place, should I move it to mini2440.c in arch_cpu_init() or
board_early_init_f() ? I don't really know the difference.

> > > > diff --git a/board/friendlyarm/mini2440/mini2440.c
> > > > b/board/friendlyarm/mini2440/mini2440.c new file mode 100644
> > > > index 0000000..9ba8d39
> > > > --- /dev/null
> > > > +++ b/board/friendlyarm/mini2440/mini2440.c
> > > > @@ -0,0 +1,139 @@
> > > > +/*
> > > > + * (C) Copyright 2002
> > > > + * Sysgo Real-Time Solutions, GmbH <www.elinos.com>
> > > > + * Marius Groeger <mgroeger@sysgo.de>
> > > > + *
> > > > + * (C) Copyright 2002
> > > > + * David Mueller, ELSOFT AG, <d.mueller@elsoft.ch>
> > > > + *
> > > > + * (C) Copyright 2009
> > > > + * Michel Pollet <buserror@gmail.com>
> > > > + *
> > > > + * (C) Copyright 2012
> > > > + * Gabriel Huau <contact@huau-gabriel.fr>
> > > > + *
> > > > + * See file CREDITS for list of people who contributed to this
> > > > + * project.
> > > > + *
> > > > + * This program is free software; you can redistribute it and/or
> > > > + * modify it under the terms of the GNU General Public License as
> > > > + * published by the Free Software Foundation; either version 2 of
> > > > + * the License, or (at your option) any later version.
> > > > + *
> > > > + * This program is distributed in the hope that it will be useful,
> > > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > > + * GNU General Public License for more details.
> > > > + *
> > > > + * You should have received a copy of the GNU General Public License
> > > > + * along with this program; if not, write to the Free Software
> > > > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > > > + * MA 02111-1307 USA
> > > > + */
> > > > +
> > > > +#include <common.h>
> > > > +#include <asm/arch/s3c2440.h>
> > > > +#include <asm/io.h>
> > > > +#include <video_fb.h>
> > > > +#include "mini2440.h"
> > > > +
> > > > +#ifdef CONFIG_DRIVER_DM9000
> > > > +#include <netdev.h>
> > > > +#endif
> > > > +
> > > > +DECLARE_GLOBAL_DATA_PTR;
> > > > +
> > > > +static inline void pll_delay(unsigned long loops)
> > > > +{
> > > > +	__asm__ volatile ("1:\n"
> > > > +	  "subs %0, %1, #1\n"
> > > > +	  "bne 1b" : "=r" (loops) : "0" (loops));
> > > > +}
> > > > +
> > > > +int arch_cpu_init(void)
> > > > +{
> > > > +	struct s3c24x0_clock_power * const clk_power =
> > > > +					s3c24x0_get_base_clock_power();
> > > > +
> > > > +	/* to reduce PLL lock time, adjust the LOCKTIME register */
> > > > +	clk_power->locktime = 0xFFFFFF;
> > > > +	clk_power->clkdivn = CLKDIVN_VAL;
> > > > +
> > > > +	/* configure UPLL */
> > > > +	clk_power->upllcon = ((U_M_MDIV << 12) + (U_M_PDIV << 4) + U_M_SDIV);
> > > > +	/* some delay between MPLL and UPLL */
> > > > +	pll_delay(100000);
> > > > +
> > > > +	/* configure MPLL */
> > > > +	clk_power->mpllcon = ((M_MDIV << 12) + (M_PDIV << 4) + M_SDIV);
> > > > +
> > > > +	/* some delay between MPLL and UPLL */
> > > > +	pll_delay(500000);
> > > 
> > > You use udelay() below, do you need pll_delay() at all?
> > 
> > Yes, because initialisation of PLL is done before timer_init(), so we
> > can't use udelay().
> 
> Maybe fix the timer driver?
> 

As PLL initialization is SoC specific, should I move it to
arch/arch/cpu/arm920t/s3c24x0/timer.c in timer_init() ?

With this modification, I will have to patch all board based 
on s3c24x0, because they are all using this "hack". Should this
modification be part of another patch ? (for me, yes ...)

> > > > +
> > > > +	return 0;
> > > > +}
> > > > +
> > > > +/*
> > > > + * Miscellaneous platform dependent initialisations
> > > > + */
> > > > +int board_init(void)
> > > > +{
> > > > +	struct s3c24x0_clock_power * const clk_power =
> > > > +					s3c24x0_get_base_clock_power();
> > > > +	struct s3c24x0_gpio * const gpio = s3c24x0_get_base_gpio();
> > > > +
> > > > +	/* to reduce PLL lock time, adjust the LOCKTIME register */
> > > > +	clk_power->locktime = 0xFFFFFF;
> > > > +	clk_power->clkdivn = CLKDIVN_VAL;
> > > > +
> > > > +	/* configure UPLL */
> > > > +	clk_power->upllcon = ((U_M_MDIV << 12) + (U_M_PDIV << 4) + U_M_SDIV);
> > > > +	/* some delay between MPLL and UPLL */
> > > > +	udelay(10);
> > > > +	/* configure MPLL */
> > > > +	clk_power->mpllcon = ((M_MDIV << 12) + (M_PDIV << 4) + M_SDIV);
> > > > +
> > > > +	/* some delay between MPLL and UPLL */
> > > > +	udelay(8000);
> > > > +
> > > > +	/* set up the I/O ports */
> > > > +	writel(0x007FFFFF, &gpio->gpacon);
> > > > +	writel(0x00044555, &gpio->gpbcon);
> > > > +	writel(0x000007FF, &gpio->gpbup);
> > > > +	writel(0xAAAAAAAA, &gpio->gpccon);
> > > > +	writel(0x0000FFFF, &gpio->gpcup);
> > > > +	writel(0xAAAAAAAA, &gpio->gpdcon);
> > > > +	writel(0x0000FFFF, &gpio->gpdup);
> > > > +	writel(0xAAAAAAAA, &gpio->gpecon);
> > > > +	writel(0x0000FFFF, &gpio->gpeup);
> > > > +	writel(0x000055AA, &gpio->gpfcon);
> > > > +	writel(0x000000FF, &gpio->gpfup);
> > > > +	writel(0xFF95FFBA, &gpio->gpgcon);
> > > > +	writel(0x0000FFFF, &gpio->gpgup);
> > > > +	writel(0x002AFAAA, &gpio->gphcon);
> > > > +	writel(0x000007FF, &gpio->gphup);
> > > > +
> > > > +	/* adress of boot parameters */
> > > > +	gd->bd->bi_boot_params = CONFIG_BOOT_PARAM_ADDR;
> > > > +
> > > > +	return 0;
> > > > +}
> > > > +
> > > > +int dram_init(void)
> > > > +{
> > > > +	gd->ram_size = PHYS_SDRAM_1_SIZE;
> > > > +	return 0;
> > > > +}
> > > > +
> > > > +int board_eth_init(bd_t *bis)
> > > > +{
> > > > +#ifdef CONFIG_DRIVER_DM9000
> > > > +	return dm9000_initialize(bis);
> > > > +#else
> > > > +	return 0;
> > > > +#endif
> > > > +}
> > > > +
> > > > +/* The sum of all part_size[]s must equal to the NAND size, i.e.,
> > > > 0x4000000 */ +unsigned int dynpart_size[] = { 0x40000, 0x20000,
> > > > 0x500000, 0xffffffff, 0 }; +char *dynpart_names[] = { "u-boot",
> > > > "u-boot_env", "kernel", "rootfs", NULL }; diff --git
> > > > a/board/friendlyarm/mini2440/mini2440.h
> > > > b/board/friendlyarm/mini2440/mini2440.h new file mode 100644
> > > > index 0000000..02197c8
> > > > --- /dev/null
> > > > +++ b/board/friendlyarm/mini2440/mini2440.h
> > > > @@ -0,0 +1,104 @@
> > > > +/*
> > > > + * Taken from linux/arch/arm/boot/compressed/head-s3c2410.S
> > > > + * Copyright (C) 2002 Samsung Electronics SW.LEE
> > > > <hitchcar@sec.samsung.com> + */
> > > > +
> > > > +#ifndef BOARD_LL_MINI2440_H
> > > > +#define BOARD_LL_MINI2440_H
> > > > +
> > > > +/*
> > > > + * PLL/Clock configuration
> > > > + */
> > > > +/* FCLK = 405 MHz, HCLK = 101 MHz, PCLK = 50 MHz, UCLK = 48 MHz */
> > > > +#define CLKDIVN_VAL	7
> > > > +#define M_MDIV		0x7f
> > > > +#define M_PDIV		0x2
> > > > +#define M_SDIV		0x1
> > > > +
> > > > +#define U_M_MDIV	0x38
> > > > +#define U_M_PDIV	0x2
> > > > +#define U_M_SDIV	0x2
> > > > +
> > > > +/* BWSCON */
> > > > +#define BWSCON	0x48000000
> > > > +#define DW8		(0x0)
> > > > +#define DW16	(0x1)
> > > > +#define DW32	(0x2)
> > > > +#define WAIT	(0x1<<2)
> > > > +#define UBLB	(0x1<<3)
> > > > +
> > > > +#define B1_BWSCON		(DW32)
> > > > +#define B2_BWSCON		(DW16)
> > > > +#define B3_BWSCON		(DW16 + WAIT + UBLB)
> > > > +#define B4_BWSCON		(DW16)
> > > > +#define B5_BWSCON		(DW16)
> > > > +#define B6_BWSCON		(DW32)
> > > > +#define B7_BWSCON		(DW32)
> > > > +
> > > > +/* BANK0CON */
> > > > +#define B0_Tacs		0x0	/*  0clk */
> > > > +#define B0_Tcos		0x0	/*  0clk */
> > > > +#define B0_Tacc		0x7	/* 14clk */
> > > > +#define B0_Tcoh		0x0	/*  0clk */
> > > > +#define B0_Tah		0x0	/*  0clk */
> > > > +#define B0_Tacp		0x0
> > > > +#define B0_PMC		0x0	/* normal */
> > > > +
> > > > +/* BANK1CON */
> > > > +#define B1_Tacs		0x0	/*  0clk */
> > > > +#define B1_Tcos		0x0	/*  0clk */
> > > > +#define B1_Tacc		0x7	/* 14clk */
> > > > +#define B1_Tcoh		0x0	/*  0clk */
> > > > +#define B1_Tah		0x0	/*  0clk */
> > > > +#define B1_Tacp		0x0
> > > > +#define B1_PMC		0x0
> > > > +
> > > > +#define B2_Tacs		0x0
> > > > +#define B2_Tcos		0x0
> > > > +#define B2_Tacc		0x7
> > > > +#define B2_Tcoh		0x0
> > > > +#define B2_Tah		0x0
> > > > +#define B2_Tacp		0x0
> > > > +#define B2_PMC		0x0
> > > > +
> > > > +#define B3_Tacs		0x0	/*  0clk */
> > > > +#define B3_Tcos		0x3	/*  4clk */
> > > > +#define B3_Tacc		0x7	/* 14clk */
> > > > +#define B3_Tcoh		0x1	/*  1clk */
> > > > +#define B3_Tah		0x0	/*  0clk */
> > > > +#define B3_Tacp		0x3     /*  6clk */
> > > > +#define B3_PMC		0x0	/* normal */
> > > > +
> > > > +#define B4_Tacs		0x0	/*  0clk */
> > > > +#define B4_Tcos		0x0	/*  0clk */
> > > > +#define B4_Tacc		0x7	/* 14clk */
> > > > +#define B4_Tcoh		0x0	/*  0clk */
> > > > +#define B4_Tah		0x0	/*  0clk */
> > > > +#define B4_Tacp		0x0
> > > > +#define B4_PMC		0x0	/* normal */
> > > > +
> > > > +#define B5_Tacs		0x0	/*  0clk */
> > > > +#define B5_Tcos		0x0	/*  0clk */
> > > > +#define B5_Tacc		0x7	/* 14clk */
> > > > +#define B5_Tcoh		0x0	/*  0clk */
> > > > +#define B5_Tah		0x0	/*  0clk */
> > > > +#define B5_Tacp		0x0
> > > > +#define B5_PMC		0x0	/* normal */
> > > > +
> > > > +#define B6_MT		0x3	/* SDRAM */
> > > > +#define B6_Trcd		0x1
> > > > +#define B6_SCAN		0x1	/* 9bit */
> > > > +
> > > > +#define B7_MT		0x3	/* SDRAM */
> > > > +#define B7_Trcd		0x1	/* 3clk */
> > > > +#define B7_SCAN		0x1	/* 9bit */
> > > > +
> > > > +/* REFRESH parameter */
> > > > +#define REFEN		0x1	/* Refresh enable */
> > > > +#define TREFMD		0x0	/* CBR(CAS before RAS)/Auto refresh */
> > > > +#define Trp			0x0	/* 2clk */
> > > > +#define Trc			0x3	/* 7clk */
> > > > +#define Tchr		0x2	/* 3clk */
> > > > +#define REFCNT		1113	/* period=15.6us, HCLK=60Mhz */
> > > > +
> > > > +#endif
> > > > diff --git a/boards.cfg b/boards.cfg
> > > > index 3cf75c3..93eeb3c 100644
> > > > --- a/boards.cfg
> > > > +++ b/boards.cfg
> > > > @@ -61,6 +61,7 @@ mx1ads                       arm         arm920t    
> > > > -
> > > > 
> > > >                - scb9328                      arm         arm920t     -
> > > >                -              imx cm4008                       arm
> > > > 
> > > > arm920t     -                   -              ks8695 cm41xx
> > > > 
> > > >         arm         arm920t     -                   -             
> > > >         ks8695
> > > > 
> > > > +mini2440                     arm         arm920t     mini2440
> > > > friendlyarm    s3c24x0 VCMA9                        arm         arm920t
> > > > 
> > > >  vcma9               mpl            s3c24x0 smdk2410
> > > > 
> > > > arm         arm920t     -                   samsung        s3c24x0
> > > > omap1510inn                  arm         arm925t     -
> > > > ti diff --git a/include/configs/mini2440.h b/include/configs/mini2440.h
> > > > new file mode 100644
> > > > index 0000000..a3f06d0
> > > > --- /dev/null
> > > > +++ b/include/configs/mini2440.h
> > > > @@ -0,0 +1,215 @@
> > > > +/*
> > > > + * (C) Copyright 2002
> > > > + * Sysgo Real-Time Solutions, GmbH <www.elinos.com>
> > > > + * Marius Groeger <mgroeger@sysgo.de>
> > > > + * Gary Jennejohn <gj@denx.de>
> > > > + * David Mueller <d.mueller@elsoft.ch>
> > > > + *
> > > > + * (C) Copyright 2009-2010
> > > > + * Michel Pollet <buserror@gmail.com>
> > > > + *
> > > > + * (C) Copyright 2012
> > > > + * Gabriel Huau <contact@huau-gabriel.fr>
> > > > + *
> > > > + * Configuation settings for the MINI2440 board.
> > > > + *
> > > > + * See file CREDITS for list of people who contributed to this
> > > > + * project.
> > > > + *
> > > > + * This program is free software; you can redistribute it and/or
> > > > + * modify it under the terms of the GNU General Public License as
> > > > + * published by the Free Software Foundation; either version 2 of
> > > > + * the License, or (at your option) any later version.
> > > > + *
> > > > + * This program is distributed in the hope that it will be useful,
> > > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > > + * GNU General Public License for more details.
> > > > + *
> > > > + * You should have received a copy of the GNU General Public License
> > > > + * along with this program; if not, write to the Free Software
> > > > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > > > + * MA 02111-1307 USA
> > > > + */
> > > > +
> > > > +#ifndef __CONFIG_H
> > > > +#define __CONFIG_H
> > > > +
> > > > +#define CONFIG_SYS_TEXT_BASE 0x0
> > > > +
> > > > +/*
> > > > + * High Level Configuration Options
> > > > + */
> > > > +#define CONFIG_ARM920T		1	/* This is an ARM920T Core
> > > 
> > > */
> > > 
> > > > +#define CONFIG_S3C24X0		1	/* in a SAMSUNG S3C2440 SoC */
> > > > +#define CONFIG_S3C2440		1	/* in a SAMSUNG S3C2440 SoC */
> > > > +#define CONFIG_MINI2440		1	/* on a MIN2440 Board       */
> > > > +
> > > > +#define	MACH_TYPE_MINI2440	1999
> > > > +#define	CONFIG_MACH_TYPE	MACH_TYPE_MINI2440
> > > > +
> > > > +/*
> > > > + * It is possible to have u-boot save it's environment in NOR,
> > > > however, + * reember it is incompatible with booting from NAND as the
> > > > NOR is not + * available at that point. So use this only if you use
> > > > nand as storage + * and will never boot from it
> > > > + */
> > > > +#define CONFIG_MINI2440_NOR_ENV	1
> > > > +/* allow use of frequencies over 405Mhz */
> > > > +#define CONFIG_MINI2440_OVERCLOCK 1
> > > > +
> > > > +/*
> > > > + * input clock of PLL
> > > > + */
> > > > +/* MINI2440 has 12.0000MHz input clock */
> > > > +#define CONFIG_SYS_CLK_FREQ	12000000
> > > > +#define CONFIG_ARCH_CPU_INIT 1 /* for the initialization of PLL */
> > > > +
> > > > +#define USE_920T_MMU		1
> > > > +#define CONFIG_BAUDRATE		115200
> > > > +
> > > > +/*
> > > > + * Size of malloc() pool
> > > > + */
> > > > +#define CONFIG_SYS_MALLOC_LEN	(CONFIG_ENV_SIZE + 2048*1024)
> > > > +/* size in bytes reserved for initial data */
> > > > +#define CONFIG_GBL_DATA_SIZE	128
> > > > +
> > > > +/*
> > > > + * Hardware drivers
> > > > + */
> > > > +#define CONFIG_DRIVER_DM9000			1
> > > > +#define CONFIG_DRIVER_DM9000_NO_EEPROM	1
> > > > +#define CONFIG_DM9000_BASE				0x20000300
> > > > +#define DM9000_IO		CONFIG_DM9000_BASE
> > > > +#define DM9000_DATA		(CONFIG_DM9000_BASE+4)
> > > > +
> > > > +/*
> > > > + * select serial console configuration
> > > > + */
> > > > +#define CONFIG_S3C24X0_SERIAL
> > > > +#define CONFIG_SERIAL1			1
> > > > +
> > > > +/*
> > > > + * allow to overwrite serial and ethaddr
> > > > + */
> > > > +#define CONFIG_ENV_OVERWRITE
> > > > +
> > > > +/*
> > > > + * Command definition
> > > > + */
> > > > +#include <config_cmd_default.h>
> > > > +
> > > > +#define CONFIG_CMD_DHCP
> > > > +#define CONFIG_CMD_PORTIO
> > > > +#define CONFIG_CMD_REGINFO
> > > > +#define CONFIG_CMD_SAVES
> > > > +
> > > > +/*
> > > > + * Miscellaneous configurable options
> > > > + */
> > > > +#define	CONFIG_LONGHELP
> > > > +#define	CONFIG_SYS_PROMPT		"MINI2440 => "
> > > > +#define	CONFIG_SYS_CBSIZE		256
> > > > +#define	CONFIG_SYS_PBSIZE
> > > 
> > > (CONFIG_SYS_CBSIZE+sizeof(CONFIG_SYS_PROMPT)+16)
> > > 
> > > > +#define	CONFIG_SYS_MAXARGS		32
> > > > +#define CONFIG_SYS_BARGSIZE		CONFIG_SYS_CBSIZE
> > > > +
> > > > +#define CONFIG_SYS_MEMTEST_START	0x30000000
> > > > +#define CONFIG_SYS_MEMTEST_END		0x34000000	/* 64MB in DRAM
> > > 
> > > */
> > > 
> > > > +
> > > > +/* everything, incl board info, in Hz */
> > > > +#undef  CONFIG_CLKS_IN_HZ
> > > > +
> > > > +/* default load address	*/
> > > > +#define	CONFIG_SYS_LOAD_ADDR		0x32000000
> > > > +
> > > > +/* boot parameters address */
> > > > +#define	CONFIG_BOOT_PARAM_ADDR		0x30000100
> > > > +
> > > > +/*
> > > > + * the PWM TImer 4 uses a counter of 15625 for 10 ms, so we need
> > > > + * it to wrap 100 times (total 1562500) to get 1 sec.
> > > > + */
> > > > +#define	CONFIG_SYS_HZ			1562500
> > > > +
> > > > +/*
> > > > + * valid baudrates
> > > > + */
> > > > +#define CONFIG_SYS_BAUDRATE_TABLE	{ 9600, 19200, 38400, 57600, 
> 115200
> > > > } +
> > > > +/*
> > > > + * Stack sizes
> > > > + * The stack sizes are set up in start.S using the settings below
> > > > + */
> > > > +#define CONFIG_STACKSIZE	(128*1024)	/* regular stack */
> > > > +#ifdef CONFIG_USE_IRQ
> > > > +#define CONFIG_STACKSIZE_IRQ	(8*1024)	/* IRQ stack */
> > > > +#define CONFIG_STACKSIZE_FIQ	(4*1024)	/* FIQ stack */
> > > > +#endif
> > > > +
> > > > +/*
> > > > + * Physical Memory Map
> > > > + */
> > > > +#define CONFIG_NR_DRAM_BANKS        1          /* we have 1 bank of
> > > > DRAM */ +#define PHYS_SDRAM_1                0x30000000 /* SDRAM Bank
> > > > #1 */ +#define PHYS_SDRAM_1_SIZE           (64*1024*1024) /* 64MB of
> > > > DRAM */ +#define CONFIG_SYS_SDRAM_BASE       PHYS_SDRAM_1
> > > > +#define CONFIG_SYS_INIT_SP_ADDR		(CONFIG_SYS_SDRAM_BASE + 0x1000
> > > 
> > > - \
> > > 
> > > > +							GENERATED_GBL_DATA_SIZE)
> > > > +
> > > > +/*
> > > > + * When booting from NAND, it is impossible to access the lowest
> > > > addresses + * due to the SteppingStone being in the way. Luckily the
> > > > NOR doesn't really + * care about the highest 16 bits of address, so
> > > > we set the controlers + * registers to go and poke over there,
> > > > instead.
> > > > + */
> > > > +#define PHYS_FLASH_1			0x0
> > > > +#define CONFIG_SYS_FLASH_BASE	0x0
> > > > +
> > > > +/*
> > > > + * NOR FLASH organization
> > > > + * Now uses the standard CFI interface
> > > > + * FLASH and environment organization
> > > > + */
> > > > +#define CONFIG_SYS_FLASH_CFI		1
> > > > +#define CONFIG_FLASH_CFI_DRIVER		1
> > > > +#define CONFIG_SYS_FLASH_CFI_WIDTH	FLASH_CFI_16BIT
> > > > +#define CONFIG_SYS_MONITOR_BASE		0x0
> > > > +/* max number of memory banks */
> > > > +#define CONFIG_SYS_MAX_FLASH_BANKS	1
> > > > +/* 512 * 4096 sectors, or 32 * 64k blocks */
> > > > +#define CONFIG_SYS_MAX_FLASH_SECT	512
> > > > +#define CONFIG_FLASH_SHOW_PROGRESS	1
> > > > +
> > > > +/*
> > > > + * u-boot environmnent
> > > > + */
> > > > +#define CONFIG_BOOTDELAY	3
> > > > +#define CONFIG_BOOTARGS		"root=/dev/sdb1 console=ttySAC0,115200"
> > > > +#define CONFIG_NETMASK      255.255.255.0
> > > > +#define CONFIG_IPADDR		192.168.0.2
> > > > +#define CONFIG_SERVERIP		192.168.0.1
> > > > +#define CONFIG_DOS_PARTITION	1
> > > > +#define CONFIG_BOOTCOMMAND "tftp 0x32000000 uImage;bootm"
> > > 
> > > DROP THIS!
> > 
> > ok :-)
> > 
> > > > +
> > > > +/*
> > > > + * Config for NOR flash
> > > > + */
> > > > +#define CONFIG_ENV_IS_IN_FLASH	1
> > > > +#define CONFIG_MY_ENV_OFFSET	0x40000
> > > > +/* addr of environment */
> > > > +#define CONFIG_ENV_ADDR		(PHYS_FLASH_1 + CONFIG_MY_ENV_OFFSET)
> > > > +/* 16k Total Size of Environment Sector */
> > > > +#define CONFIG_ENV_SIZE		0x4000
> > > > +
> > > > +#define CONFIG_PREBOOT_OVERRIDE	1
> > > > +
> > > > +/* ATAG configuration */
> > > > +#define CONFIG_INITRD_TAG			1
> > > > +#define CONFIG_SETUP_MEMORY_TAGS	1
> > > > +#define CONFIG_CMDLINE_TAG			1
> > > > +#define CONFIG_CMDLINE_EDITING		1
> > > > +#define CONFIG_AUTO_COMPLETE		1
> > > > +
> > > > +#endif	/* __CONFIG_H */

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-19 20:45       ` Marek Vasut
  2012-04-19 21:33         ` Gabriel Huau
@ 2012-04-19 21:37         ` Ilya Averyanov
  2012-04-19 22:23           ` Marek Vasut
  1 sibling, 1 reply; 42+ messages in thread
From: Ilya Averyanov @ 2012-04-19 21:37 UTC (permalink / raw)
  To: u-boot

2012/4/20 Marek Vasut <marex@denx.de>

> Dear Gabriel Huau,
>
> > On Thu, Apr 19, 2012 at 10:08:47PM +0200, Marek Vasut wrote:
> > > Dear Gabriel Huau,
> > >
> > > > ---
> > > >
> > > > Changes for v2:
> > > >   - Coding style cleanup
> > > >   - Remove unnecessary files modification
> > > >   - Remove unnecessary board configuration set
> > > >
> > > > Changes for v3:
> > > >   - Coding style cleanup
> > > >   - Move some macro definition from lowlevel_init.S
> > > >   to a new header
> > > >   - Remove some "magic bloat" with I/O board initialization
> > > >   - Add a pll_delay and replace loop by it
> > > >   - Somme cleanup in the configuration file
> > > >   - Cancel modifications on an SoC specific header
> > > >   - Add my name to copyright
> > > >
> > > > ---
> > > >
> > > >  board/friendlyarm/mini2440/Makefile        |   45 ++++++
> > > >  board/friendlyarm/mini2440/lowlevel_init.S |   76 ++++++++++
> > > >  board/friendlyarm/mini2440/mini2440.c      |  139 ++++++++++++++++++
> > > >  board/friendlyarm/mini2440/mini2440.h      |  104 ++++++++++++++
> > > >  boards.cfg                                 |    1 +
> > > >  include/configs/mini2440.h                 |  215
> > > >
> > > > ++++++++++++++++++++++++++++ 6 files changed, 580 insertions(+)
> > > >
> > > >  create mode 100644 board/friendlyarm/mini2440/Makefile
> > > >  create mode 100644 board/friendlyarm/mini2440/lowlevel_init.S
> > > >  create mode 100644 board/friendlyarm/mini2440/mini2440.c
> > > >  create mode 100644 board/friendlyarm/mini2440/mini2440.h
> > > >  create mode 100644 include/configs/mini2440.h
> > > >
> > > > diff --git a/board/friendlyarm/mini2440/Makefile
> > > > b/board/friendlyarm/mini2440/Makefile new file mode 100644
> > > > index 0000000..e8d68cb
> > > > --- /dev/null
> > > > +++ b/board/friendlyarm/mini2440/Makefile
> > > > @@ -0,0 +1,45 @@
> > > > +#
> > > > +# (C) Copyright 2012
> > > > +# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
> > > > +#
> > > > +# See file CREDITS for list of people who contributed to this
> > > > +# project.
> > > > +#
> > > > +# This program is free software; you can redistribute it and/or
> > > > +# modify it under the terms of the GNU General Public License as
> > > > +# published by the Free Software Foundation; either version 2 of
> > > > +# the License, or (at your option) any later version.
> > > > +#
> > > > +# This program is distributed in the hope that it will be useful,
> > > > +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > > +# GNU General Public License for more details.
> > > > +#
> > > > +# You should have received a copy of the GNU General Public License
> > > > +# along with this program; if not, write to the Free Software
> > > > +# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > > > +# MA 02111-1307 USA
> > > > +#
> > > > +
> > > > +include $(TOPDIR)/config.mk
> > > > +
> > > > +LIB      = $(obj)lib$(BOARD).o
> > > > +
> > > > +COBJS    := mini2440.o
> > > > +SOBJS    := lowlevel_init.o
> > > > +
> > > > +SRCS     := $(SOBJS:.o=.S) $(COBJS:.o=.c)
> > > > +OBJS     := $(addprefix $(obj),$(COBJS))
> > > > +SOBJS    := $(addprefix $(obj),$(SOBJS))
> > > > +
> > > > +$(LIB):  $(obj).depend $(OBJS) $(SOBJS)
> > > > + $(call cmd_link_o_target, $(OBJS) $(SOBJS))
> > > > +
> > > >
> +######################################################################
> > > > ### +
> > > > +# defines $(obj).depend target
> > > > +include $(SRCTREE)/rules.mk
> > > > +
> > > > +sinclude $(obj).depend
> > > > +
> > > >
> +######################################################################
> > > > ### diff --git a/board/friendlyarm/mini2440/lowlevel_init.S
> > > > b/board/friendlyarm/mini2440/lowlevel_init.S new file mode 100644
> > > > index 0000000..f69a08c
> > > > --- /dev/null
> > > > +++ b/board/friendlyarm/mini2440/lowlevel_init.S
> > > > @@ -0,0 +1,76 @@
> > > > +/*
> > > > + * Memory Setup stuff - taken from blob memsetup.S
> > > > + *
> > > > + * Copyright (C) 1999 2000 2001 Erik Mouw (
> J.A.K.Mouw at its.tudelft.nl)
> > > > and + *                     Jan-Derk Bakker
> > > > (J.D.Bakker at its.tudelft.nl) + *
> > > > + * Modified for the Samsung SMDK2410 by
> > > > + * (C) Copyright 2002
> > > > + * David Mueller, ELSOFT AG, <d.mueller@elsoft.ch>
> > > > + *
> > > > + * (C) Copyright 2012
> > > > + * Gabriel Huau <contact@huau-gabriel.fr>
> > > > + *
> > > > + * See file CREDITS for list of people who contributed to this
> > > > + * project.
> > > > + *
> > > > + * This program is free software; you can redistribute it and/or
> > > > + * modify it under the terms of the GNU General Public License as
> > > > + * published by the Free Software Foundation; either version 2 of
> > > > + * the License, or (at your option) any later version.
> > > > + *
> > > > + * This program is distributed in the hope that it will be useful,
> > > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > > + * GNU General Public License for more details.
> > > > + *
> > > > + * You should have received a copy of the GNU General Public License
> > > > + * along with this program; if not, write to the Free Software
> > > > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > > > + * MA 02111-1307 USA
> > > > + */
> > > > +
> > > > +#include <config.h>
> > > > +#include <version.h>
> > > > +#include "mini2440.h"
> > > > +
> > > > +_TEXT_BASE:
> > > > + .word   CONFIG_SYS_TEXT_BASE
> > > > +
> > > > +.globl lowlevel_init
> > > > +lowlevel_init:
> > > > + /* memory control configuration */
> > > > + /* make r0 relative the current location so that it */
> > > > + /* reads SMRDATA out of FLASH rather than memory ! */
> > > > + ldr     r0, =SMRDATA
> > > > + ldr     r1, _TEXT_BASE
> > > > + sub     r0, r0, r1
> > > > + ldr     r1, =BWSCON     /* Bus Width Status Controller */
> > > > + add     r2, r0, #13*4
> > > > +0:
> > > > + ldr     r3, [r0], #4
> > > > + str     r3, [r1], #4
> > > > + cmp     r2, r0
> > > > + bne     0b
> > > > +
> > > > + /* everything is fine now */
> > > > + mov     pc, lr
> > > > +
> > > > + .ltorg
> > > > +/* the literal pools origin */
> > > > +
> > > > +SMRDATA:
> > > > +    .word
> > > >
> (0+(B1_BWSCON<<4)+(B2_BWSCON<<8)+(B3_BWSCON<<12)+(B4_BWSCON<<16)+(B5_BW
> > > > SCO N<<20)+(B6_BWSCON<<24)+(B7_BWSCON<<28)) +    .word
> > > >
> ((B0_Tacs<<13)+(B0_Tcos<<11)+(B0_Tacc<<8)+(B0_Tcoh<<6)+(B0_Tah<<4)+(B0_
> > > > Tac p<<2)+(B0_PMC)) +    .word
> > > >
> ((B1_Tacs<<13)+(B1_Tcos<<11)+(B1_Tacc<<8)+(B1_Tcoh<<6)+(B1_Tah<<4)+(B1_
> > > > Tac p<<2)+(B1_PMC)) +    .word
> > > >
> ((B2_Tacs<<13)+(B2_Tcos<<11)+(B2_Tacc<<8)+(B2_Tcoh<<6)+(B2_Tah<<4)+(B2_
> > > > Tac p<<2)+(B2_PMC)) +    .word
> > > >
> ((B3_Tacs<<13)+(B3_Tcos<<11)+(B3_Tacc<<8)+(B3_Tcoh<<6)+(B3_Tah<<4)+(B3_
> > > > Tac p<<2)+(B3_PMC)) +    .word
> > > >
> ((B4_Tacs<<13)+(B4_Tcos<<11)+(B4_Tacc<<8)+(B4_Tcoh<<6)+(B4_Tah<<4)+(B4_
> > > > Tac p<<2)+(B4_PMC)) +    .word
> > > >
> ((B5_Tacs<<13)+(B5_Tcos<<11)+(B5_Tacc<<8)+(B5_Tcoh<<6)+(B5_Tah<<4)+(B5_
> > > > Tac p<<2)+(B5_PMC)) +
> > > > +    .word ((B6_MT<<15)+(B6_Trcd<<2)+(B6_SCAN))
> > > > +    .word ((B7_MT<<15)+(B7_Trcd<<2)+(B7_SCAN))
> > > > +    .word
> > > > ((REFEN<<23)+(TREFMD<<22)+(Trp<<20)+(Trc<<18)+(Tchr<<16)+REFCNT) +
> > > > .word 0x32
> > > > +    .word 0x30
> > > > +    .word 0x30
> > >
> > > What this undocumented stuff?
> >
> > SoC specific, I pasted it from smdk2410, it's for initialize the DRAM.
>
> Can't you init DRAM in some more fitting place? Also document this?
>
> > > > diff --git a/board/friendlyarm/mini2440/mini2440.c
> > > > b/board/friendlyarm/mini2440/mini2440.c new file mode 100644
> > > > index 0000000..9ba8d39
> > > > --- /dev/null
> > > > +++ b/board/friendlyarm/mini2440/mini2440.c
> > > > @@ -0,0 +1,139 @@
> > > > +/*
> > > > + * (C) Copyright 2002
> > > > + * Sysgo Real-Time Solutions, GmbH <www.elinos.com>
> > > > + * Marius Groeger <mgroeger@sysgo.de>
> > > > + *
> > > > + * (C) Copyright 2002
> > > > + * David Mueller, ELSOFT AG, <d.mueller@elsoft.ch>
> > > > + *
> > > > + * (C) Copyright 2009
> > > > + * Michel Pollet <buserror@gmail.com>
> > > > + *
> > > > + * (C) Copyright 2012
> > > > + * Gabriel Huau <contact@huau-gabriel.fr>
> > > > + *
> > > > + * See file CREDITS for list of people who contributed to this
> > > > + * project.
> > > > + *
> > > > + * This program is free software; you can redistribute it and/or
> > > > + * modify it under the terms of the GNU General Public License as
> > > > + * published by the Free Software Foundation; either version 2 of
> > > > + * the License, or (at your option) any later version.
> > > > + *
> > > > + * This program is distributed in the hope that it will be useful,
> > > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > > + * GNU General Public License for more details.
> > > > + *
> > > > + * You should have received a copy of the GNU General Public License
> > > > + * along with this program; if not, write to the Free Software
> > > > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > > > + * MA 02111-1307 USA
> > > > + */
> > > > +
> > > > +#include <common.h>
> > > > +#include <asm/arch/s3c2440.h>
> > > > +#include <asm/io.h>
> > > > +#include <video_fb.h>
> > > > +#include "mini2440.h"
> > > > +
> > > > +#ifdef CONFIG_DRIVER_DM9000
> > > > +#include <netdev.h>
> > > > +#endif
> > > > +
> > > > +DECLARE_GLOBAL_DATA_PTR;
> > > > +
> > > > +static inline void pll_delay(unsigned long loops)
> > > > +{
> > > > + __asm__ volatile ("1:\n"
> > > > +   "subs %0, %1, #1\n"
> > > > +   "bne 1b" : "=r" (loops) : "0" (loops));
> > > > +}
> > > > +
> > > > +int arch_cpu_init(void)
> > > > +{
> > > > + struct s3c24x0_clock_power * const clk_power =
> > > > +                                 s3c24x0_get_base_clock_power();
> > > > +
> > > > + /* to reduce PLL lock time, adjust the LOCKTIME register */
> > > > + clk_power->locktime = 0xFFFFFF;
> > > > + clk_power->clkdivn = CLKDIVN_VAL;
> > > > +
> > > > + /* configure UPLL */
> > > > + clk_power->upllcon = ((U_M_MDIV << 12) + (U_M_PDIV << 4) +
> U_M_SDIV);
> > > > + /* some delay between MPLL and UPLL */
> > > > + pll_delay(100000);
> > > > +
> > > > + /* configure MPLL */
> > > > + clk_power->mpllcon = ((M_MDIV << 12) + (M_PDIV << 4) + M_SDIV);
> > > > +
> > > > + /* some delay between MPLL and UPLL */
> > > > + pll_delay(500000);
> > >
> > > You use udelay() below, do you need pll_delay() at all?
> >
> > Yes, because initialisation of PLL is done before timer_init(), so we
> > can't use udelay().
>
> Maybe fix the timer driver?
>

How fix timer driver if arch_cpu_init(void) call befor timer_init in
\arch\arm\lib\board.c:227 init_fnc_t *init_sequence[] = {

>
> > > > +
> > > > + return 0;
> > > > +}
> > > > +
> > > > +/*
> > > > + * Miscellaneous platform dependent initialisations
> > > > + */
> > > > +int board_init(void)
> > > > +{
> > > > + struct s3c24x0_clock_power * const clk_power =
> > > > +                                 s3c24x0_get_base_clock_power();
> > > > + struct s3c24x0_gpio * const gpio = s3c24x0_get_base_gpio();
> > > > +
> > > > + /* to reduce PLL lock time, adjust the LOCKTIME register */
> > > > + clk_power->locktime = 0xFFFFFF;
> > > > + clk_power->clkdivn = CLKDIVN_VAL;
> > > > +
> > > > + /* configure UPLL */
> > > > + clk_power->upllcon = ((U_M_MDIV << 12) + (U_M_PDIV << 4) +
> U_M_SDIV);
> > > > + /* some delay between MPLL and UPLL */
> > > > + udelay(10);
> > > > + /* configure MPLL */
> > > > + clk_power->mpllcon = ((M_MDIV << 12) + (M_PDIV << 4) + M_SDIV);
> > > > +
> > > > + /* some delay between MPLL and UPLL */
> > > > + udelay(8000);
> > > > +
> > > > + /* set up the I/O ports */
> > > > + writel(0x007FFFFF, &gpio->gpacon);
> > > > + writel(0x00044555, &gpio->gpbcon);
> > > > + writel(0x000007FF, &gpio->gpbup);
> > > > + writel(0xAAAAAAAA, &gpio->gpccon);
> > > > + writel(0x0000FFFF, &gpio->gpcup);
> > > > + writel(0xAAAAAAAA, &gpio->gpdcon);
> > > > + writel(0x0000FFFF, &gpio->gpdup);
> > > > + writel(0xAAAAAAAA, &gpio->gpecon);
> > > > + writel(0x0000FFFF, &gpio->gpeup);
> > > > + writel(0x000055AA, &gpio->gpfcon);
> > > > + writel(0x000000FF, &gpio->gpfup);
> > > > + writel(0xFF95FFBA, &gpio->gpgcon);
> > > > + writel(0x0000FFFF, &gpio->gpgup);
> > > > + writel(0x002AFAAA, &gpio->gphcon);
> > > > + writel(0x000007FF, &gpio->gphup);
> > > > +
> > > > + /* adress of boot parameters */
> > > > + gd->bd->bi_boot_params = CONFIG_BOOT_PARAM_ADDR;
> > > > +
> > > > + return 0;
> > > > +}
> > > > +
> > > > +int dram_init(void)
> > > > +{
> > > > + gd->ram_size = PHYS_SDRAM_1_SIZE;
> > > > + return 0;
> > > > +}
> > > > +
> > > > +int board_eth_init(bd_t *bis)
> > > > +{
> > > > +#ifdef CONFIG_DRIVER_DM9000
> > > > + return dm9000_initialize(bis);
> > > > +#else
> > > > + return 0;
> > > > +#endif
> > > > +}
> > > > +
> > > > +/* The sum of all part_size[]s must equal to the NAND size, i.e.,
> > > > 0x4000000 */ +unsigned int dynpart_size[] = { 0x40000, 0x20000,
> > > > 0x500000, 0xffffffff, 0 }; +char *dynpart_names[] = { "u-boot",
> > > > "u-boot_env", "kernel", "rootfs", NULL }; diff --git
> > > > a/board/friendlyarm/mini2440/mini2440.h
> > > > b/board/friendlyarm/mini2440/mini2440.h new file mode 100644
> > > > index 0000000..02197c8
> > > > --- /dev/null
> > > > +++ b/board/friendlyarm/mini2440/mini2440.h
> > > > @@ -0,0 +1,104 @@
> > > > +/*
> > > > + * Taken from linux/arch/arm/boot/compressed/head-s3c2410.S
> > > > + * Copyright (C) 2002 Samsung Electronics SW.LEE
> > > > <hitchcar@sec.samsung.com> + */
> > > > +
> > > > +#ifndef BOARD_LL_MINI2440_H
> > > > +#define BOARD_LL_MINI2440_H
> > > > +
> > > > +/*
> > > > + * PLL/Clock configuration
> > > > + */
> > > > +/* FCLK = 405 MHz, HCLK = 101 MHz, PCLK = 50 MHz, UCLK = 48 MHz */
> > > > +#define CLKDIVN_VAL      7
> > > > +#define M_MDIV           0x7f
> > > > +#define M_PDIV           0x2
> > > > +#define M_SDIV           0x1
> > > > +
> > > > +#define U_M_MDIV 0x38
> > > > +#define U_M_PDIV 0x2
> > > > +#define U_M_SDIV 0x2
> > > > +
> > > > +/* BWSCON */
> > > > +#define BWSCON   0x48000000
> > > > +#define DW8              (0x0)
> > > > +#define DW16     (0x1)
> > > > +#define DW32     (0x2)
> > > > +#define WAIT     (0x1<<2)
> > > > +#define UBLB     (0x1<<3)
> > > > +
> > > > +#define B1_BWSCON                (DW32)
> > > > +#define B2_BWSCON                (DW16)
> > > > +#define B3_BWSCON                (DW16 + WAIT + UBLB)
> > > > +#define B4_BWSCON                (DW16)
> > > > +#define B5_BWSCON                (DW16)
> > > > +#define B6_BWSCON                (DW32)
> > > > +#define B7_BWSCON                (DW32)
> > > > +
> > > > +/* BANK0CON */
> > > > +#define B0_Tacs          0x0     /*  0clk */
> > > > +#define B0_Tcos          0x0     /*  0clk */
> > > > +#define B0_Tacc          0x7     /* 14clk */
> > > > +#define B0_Tcoh          0x0     /*  0clk */
> > > > +#define B0_Tah           0x0     /*  0clk */
> > > > +#define B0_Tacp          0x0
> > > > +#define B0_PMC           0x0     /* normal */
> > > > +
> > > > +/* BANK1CON */
> > > > +#define B1_Tacs          0x0     /*  0clk */
> > > > +#define B1_Tcos          0x0     /*  0clk */
> > > > +#define B1_Tacc          0x7     /* 14clk */
> > > > +#define B1_Tcoh          0x0     /*  0clk */
> > > > +#define B1_Tah           0x0     /*  0clk */
> > > > +#define B1_Tacp          0x0
> > > > +#define B1_PMC           0x0
> > > > +
> > > > +#define B2_Tacs          0x0
> > > > +#define B2_Tcos          0x0
> > > > +#define B2_Tacc          0x7
> > > > +#define B2_Tcoh          0x0
> > > > +#define B2_Tah           0x0
> > > > +#define B2_Tacp          0x0
> > > > +#define B2_PMC           0x0
> > > > +
> > > > +#define B3_Tacs          0x0     /*  0clk */
> > > > +#define B3_Tcos          0x3     /*  4clk */
> > > > +#define B3_Tacc          0x7     /* 14clk */
> > > > +#define B3_Tcoh          0x1     /*  1clk */
> > > > +#define B3_Tah           0x0     /*  0clk */
> > > > +#define B3_Tacp          0x3     /*  6clk */
> > > > +#define B3_PMC           0x0     /* normal */
> > > > +
> > > > +#define B4_Tacs          0x0     /*  0clk */
> > > > +#define B4_Tcos          0x0     /*  0clk */
> > > > +#define B4_Tacc          0x7     /* 14clk */
> > > > +#define B4_Tcoh          0x0     /*  0clk */
> > > > +#define B4_Tah           0x0     /*  0clk */
> > > > +#define B4_Tacp          0x0
> > > > +#define B4_PMC           0x0     /* normal */
> > > > +
> > > > +#define B5_Tacs          0x0     /*  0clk */
> > > > +#define B5_Tcos          0x0     /*  0clk */
> > > > +#define B5_Tacc          0x7     /* 14clk */
> > > > +#define B5_Tcoh          0x0     /*  0clk */
> > > > +#define B5_Tah           0x0     /*  0clk */
> > > > +#define B5_Tacp          0x0
> > > > +#define B5_PMC           0x0     /* normal */
> > > > +
> > > > +#define B6_MT            0x3     /* SDRAM */
> > > > +#define B6_Trcd          0x1
> > > > +#define B6_SCAN          0x1     /* 9bit */
> > > > +
> > > > +#define B7_MT            0x3     /* SDRAM */
> > > > +#define B7_Trcd          0x1     /* 3clk */
> > > > +#define B7_SCAN          0x1     /* 9bit */
> > > > +
> > > > +/* REFRESH parameter */
> > > > +#define REFEN            0x1     /* Refresh enable */
> > > > +#define TREFMD           0x0     /* CBR(CAS before RAS)/Auto
> refresh */
> > > > +#define Trp                      0x0     /* 2clk */
> > > > +#define Trc                      0x3     /* 7clk */
> > > > +#define Tchr             0x2     /* 3clk */
> > > > +#define REFCNT           1113    /* period=15.6us, HCLK=60Mhz */
> > > > +
> > > > +#endif
> > > > diff --git a/boards.cfg b/boards.cfg
> > > > index 3cf75c3..93eeb3c 100644
> > > > --- a/boards.cfg
> > > > +++ b/boards.cfg
> > > > @@ -61,6 +61,7 @@ mx1ads                       arm         arm920t
> > > > -
> > > >
> > > >                - scb9328                      arm         arm920t
>   -
> > > >                -              imx cm4008                       arm
> > > >
> > > > arm920t     -                   -              ks8695 cm41xx
> > > >
> > > >         arm         arm920t     -                   -
> > > >         ks8695
> > > >
> > > > +mini2440                     arm         arm920t     mini2440
> > > > friendlyarm    s3c24x0 VCMA9                        arm
> arm920t
> > > >
> > > >  vcma9               mpl            s3c24x0 smdk2410
> > > >
> > > > arm         arm920t     -                   samsung        s3c24x0
> > > > omap1510inn                  arm         arm925t     -
> > > > ti diff --git a/include/configs/mini2440.h
> b/include/configs/mini2440.h
> > > > new file mode 100644
> > > > index 0000000..a3f06d0
> > > > --- /dev/null
> > > > +++ b/include/configs/mini2440.h
> > > > @@ -0,0 +1,215 @@
> > > > +/*
> > > > + * (C) Copyright 2002
> > > > + * Sysgo Real-Time Solutions, GmbH <www.elinos.com>
> > > > + * Marius Groeger <mgroeger@sysgo.de>
> > > > + * Gary Jennejohn <gj@denx.de>
> > > > + * David Mueller <d.mueller@elsoft.ch>
> > > > + *
> > > > + * (C) Copyright 2009-2010
> > > > + * Michel Pollet <buserror@gmail.com>
> > > > + *
> > > > + * (C) Copyright 2012
> > > > + * Gabriel Huau <contact@huau-gabriel.fr>
> > > > + *
> > > > + * Configuation settings for the MINI2440 board.
> > > > + *
> > > > + * See file CREDITS for list of people who contributed to this
> > > > + * project.
> > > > + *
> > > > + * This program is free software; you can redistribute it and/or
> > > > + * modify it under the terms of the GNU General Public License as
> > > > + * published by the Free Software Foundation; either version 2 of
> > > > + * the License, or (at your option) any later version.
> > > > + *
> > > > + * This program is distributed in the hope that it will be useful,
> > > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > > + * GNU General Public License for more details.
> > > > + *
> > > > + * You should have received a copy of the GNU General Public License
> > > > + * along with this program; if not, write to the Free Software
> > > > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > > > + * MA 02111-1307 USA
> > > > + */
> > > > +
> > > > +#ifndef __CONFIG_H
> > > > +#define __CONFIG_H
> > > > +
> > > > +#define CONFIG_SYS_TEXT_BASE 0x0
> > > > +
> > > > +/*
> > > > + * High Level Configuration Options
> > > > + */
> > > > +#define CONFIG_ARM920T           1       /* This is an ARM920T Core
> > >
> > > */
> > >
> > > > +#define CONFIG_S3C24X0           1       /* in a SAMSUNG S3C2440
> SoC */
> > > > +#define CONFIG_S3C2440           1       /* in a SAMSUNG S3C2440
> SoC */
> > > > +#define CONFIG_MINI2440          1       /* on a MIN2440 Board
>   */
> > > > +
> > > > +#define  MACH_TYPE_MINI2440      1999
> > > > +#define  CONFIG_MACH_TYPE        MACH_TYPE_MINI2440
> > > > +
> > > > +/*
> > > > + * It is possible to have u-boot save it's environment in NOR,
> > > > however, + * reember it is incompatible with booting from NAND as the
> > > > NOR is not + * available at that point. So use this only if you use
> > > > nand as storage + * and will never boot from it
> > > > + */
> > > > +#define CONFIG_MINI2440_NOR_ENV  1
> > > > +/* allow use of frequencies over 405Mhz */
> > > > +#define CONFIG_MINI2440_OVERCLOCK 1
> > > > +
> > > > +/*
> > > > + * input clock of PLL
> > > > + */
> > > > +/* MINI2440 has 12.0000MHz input clock */
> > > > +#define CONFIG_SYS_CLK_FREQ      12000000
> > > > +#define CONFIG_ARCH_CPU_INIT 1 /* for the initialization of PLL */
> > > > +
> > > > +#define USE_920T_MMU             1
> > > > +#define CONFIG_BAUDRATE          115200
> > > > +
> > > > +/*
> > > > + * Size of malloc() pool
> > > > + */
> > > > +#define CONFIG_SYS_MALLOC_LEN    (CONFIG_ENV_SIZE + 2048*1024)
> > > > +/* size in bytes reserved for initial data */
> > > > +#define CONFIG_GBL_DATA_SIZE     128
> > > > +
> > > > +/*
> > > > + * Hardware drivers
> > > > + */
> > > > +#define CONFIG_DRIVER_DM9000                     1
> > > > +#define CONFIG_DRIVER_DM9000_NO_EEPROM   1
> > > > +#define CONFIG_DM9000_BASE                               0x20000300
> > > > +#define DM9000_IO                CONFIG_DM9000_BASE
> > > > +#define DM9000_DATA              (CONFIG_DM9000_BASE+4)
> > > > +
> > > > +/*
> > > > + * select serial console configuration
> > > > + */
> > > > +#define CONFIG_S3C24X0_SERIAL
> > > > +#define CONFIG_SERIAL1                   1
> > > > +
> > > > +/*
> > > > + * allow to overwrite serial and ethaddr
> > > > + */
> > > > +#define CONFIG_ENV_OVERWRITE
> > > > +
> > > > +/*
> > > > + * Command definition
> > > > + */
> > > > +#include <config_cmd_default.h>
> > > > +
> > > > +#define CONFIG_CMD_DHCP
> > > > +#define CONFIG_CMD_PORTIO
> > > > +#define CONFIG_CMD_REGINFO
> > > > +#define CONFIG_CMD_SAVES
> > > > +
> > > > +/*
> > > > + * Miscellaneous configurable options
> > > > + */
> > > > +#define  CONFIG_LONGHELP
> > > > +#define  CONFIG_SYS_PROMPT               "MINI2440 => "
> > > > +#define  CONFIG_SYS_CBSIZE               256
> > > > +#define  CONFIG_SYS_PBSIZE
> > >
> > > (CONFIG_SYS_CBSIZE+sizeof(CONFIG_SYS_PROMPT)+16)
> > >
> > > > +#define  CONFIG_SYS_MAXARGS              32
> > > > +#define CONFIG_SYS_BARGSIZE              CONFIG_SYS_CBSIZE
> > > > +
> > > > +#define CONFIG_SYS_MEMTEST_START 0x30000000
> > > > +#define CONFIG_SYS_MEMTEST_END           0x34000000      /* 64MB in
> DRAM
> > >
> > > */
> > >
> > > > +
> > > > +/* everything, incl board info, in Hz */
> > > > +#undef  CONFIG_CLKS_IN_HZ
> > > > +
> > > > +/* default load address  */
> > > > +#define  CONFIG_SYS_LOAD_ADDR            0x32000000
> > > > +
> > > > +/* boot parameters address */
> > > > +#define  CONFIG_BOOT_PARAM_ADDR          0x30000100
> > > > +
> > > > +/*
> > > > + * the PWM TImer 4 uses a counter of 15625 for 10 ms, so we need
> > > > + * it to wrap 100 times (total 1562500) to get 1 sec.
> > > > + */
> > > > +#define  CONFIG_SYS_HZ                   1562500
> > > > +
> > > > +/*
> > > > + * valid baudrates
> > > > + */
> > > > +#define CONFIG_SYS_BAUDRATE_TABLE        { 9600, 19200, 38400,
> 57600,
> 115200
> > > > } +
> > > > +/*
> > > > + * Stack sizes
> > > > + * The stack sizes are set up in start.S using the settings below
> > > > + */
> > > > +#define CONFIG_STACKSIZE (128*1024)      /* regular stack */
> > > > +#ifdef CONFIG_USE_IRQ
> > > > +#define CONFIG_STACKSIZE_IRQ     (8*1024)        /* IRQ stack */
> > > > +#define CONFIG_STACKSIZE_FIQ     (4*1024)        /* FIQ stack */
> > > > +#endif
> > > > +
> > > > +/*
> > > > + * Physical Memory Map
> > > > + */
> > > > +#define CONFIG_NR_DRAM_BANKS        1          /* we have 1 bank of
> > > > DRAM */ +#define PHYS_SDRAM_1                0x30000000 /* SDRAM Bank
> > > > #1 */ +#define PHYS_SDRAM_1_SIZE           (64*1024*1024) /* 64MB of
> > > > DRAM */ +#define CONFIG_SYS_SDRAM_BASE       PHYS_SDRAM_1
> > > > +#define CONFIG_SYS_INIT_SP_ADDR          (CONFIG_SYS_SDRAM_BASE +
> 0x1000
> > >
> > > - \
> > >
> > > > +
> GENERATED_GBL_DATA_SIZE)
> > > > +
> > > > +/*
> > > > + * When booting from NAND, it is impossible to access the lowest
> > > > addresses + * due to the SteppingStone being in the way. Luckily the
> > > > NOR doesn't really + * care about the highest 16 bits of address, so
> > > > we set the controlers + * registers to go and poke over there,
> > > > instead.
> > > > + */
> > > > +#define PHYS_FLASH_1                     0x0
> > > > +#define CONFIG_SYS_FLASH_BASE    0x0
> > > > +
> > > > +/*
> > > > + * NOR FLASH organization
> > > > + * Now uses the standard CFI interface
> > > > + * FLASH and environment organization
> > > > + */
> > > > +#define CONFIG_SYS_FLASH_CFI             1
> > > > +#define CONFIG_FLASH_CFI_DRIVER          1
> > > > +#define CONFIG_SYS_FLASH_CFI_WIDTH       FLASH_CFI_16BIT
> > > > +#define CONFIG_SYS_MONITOR_BASE          0x0
> > > > +/* max number of memory banks */
> > > > +#define CONFIG_SYS_MAX_FLASH_BANKS       1
> > > > +/* 512 * 4096 sectors, or 32 * 64k blocks */
> > > > +#define CONFIG_SYS_MAX_FLASH_SECT        512
> > > > +#define CONFIG_FLASH_SHOW_PROGRESS       1
> > > > +
> > > > +/*
> > > > + * u-boot environmnent
> > > > + */
> > > > +#define CONFIG_BOOTDELAY 3
> > > > +#define CONFIG_BOOTARGS          "root=/dev/sdb1
> console=ttySAC0,115200"
> > > > +#define CONFIG_NETMASK      255.255.255.0
> > > > +#define CONFIG_IPADDR            192.168.0.2
> > > > +#define CONFIG_SERVERIP          192.168.0.1
> > > > +#define CONFIG_DOS_PARTITION     1
> > > > +#define CONFIG_BOOTCOMMAND "tftp 0x32000000 uImage;bootm"
> > >
> > > DROP THIS!
> >
> > ok :-)
> >
> > > > +
> > > > +/*
> > > > + * Config for NOR flash
> > > > + */
> > > > +#define CONFIG_ENV_IS_IN_FLASH   1
> > > > +#define CONFIG_MY_ENV_OFFSET     0x40000
> > > > +/* addr of environment */
> > > > +#define CONFIG_ENV_ADDR          (PHYS_FLASH_1 +
> CONFIG_MY_ENV_OFFSET)
> > > > +/* 16k Total Size of Environment Sector */
> > > > +#define CONFIG_ENV_SIZE          0x4000
> > > > +
> > > > +#define CONFIG_PREBOOT_OVERRIDE  1
> > > > +
> > > > +/* ATAG configuration */
> > > > +#define CONFIG_INITRD_TAG                        1
> > > > +#define CONFIG_SETUP_MEMORY_TAGS 1
> > > > +#define CONFIG_CMDLINE_TAG                       1
> > > > +#define CONFIG_CMDLINE_EDITING           1
> > > > +#define CONFIG_AUTO_COMPLETE             1
> > > > +
> > > > +#endif   /* __CONFIG_H */
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-19 19:25 ` [U-Boot] [PATCH v3] " Gabriel Huau
  2012-04-19 20:08   ` Marek Vasut
@ 2012-04-19 22:22   ` Graeme Russ
  1 sibling, 0 replies; 42+ messages in thread
From: Graeme Russ @ 2012-04-19 22:22 UTC (permalink / raw)
  To: u-boot

Gabriel,

Can you please trim the subject by removing the 'Documentation about ...'
bit. This information belongs in the source code files or, better yet,
in doc/README.MINI2440

Regards,

Graeme

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-19 21:33         ` Gabriel Huau
@ 2012-04-19 22:22           ` Marek Vasut
  2012-04-20  7:19             ` Ilya Averyanov
  0 siblings, 1 reply; 42+ messages in thread
From: Marek Vasut @ 2012-04-19 22:22 UTC (permalink / raw)
  To: u-boot

Dear Gabriel Huau,

> On Thu, Apr 19, 2012 at 10:45:21PM +0200, Marek Vasut wrote:
> > Dear Gabriel Huau,
> > 
> > > On Thu, Apr 19, 2012 at 10:08:47PM +0200, Marek Vasut wrote:
> > > > Dear Gabriel Huau,
> > > > 
> > > > > ---
> > > > > 
> > > > > Changes for v2:
> > > > > 	- Coding style cleanup
> > > > > 	- Remove unnecessary files modification
> > > > > 	- Remove unnecessary board configuration set
> > > > > 
> > > > > Changes for v3:
> > > > > 	- Coding style cleanup
> > > > > 	- Move some macro definition from lowlevel_init.S
> > > > > 	to a new header
> > > > > 	- Remove some "magic bloat" with I/O board initialization
> > > > > 	- Add a pll_delay and replace loop by it
> > > > > 	- Somme cleanup in the configuration file
> > > > > 	- Cancel modifications on an SoC specific header
> > > > > 	- Add my name to copyright
> > > > > 
> > > > > ---
> > > > > 
> > > > >  board/friendlyarm/mini2440/Makefile        |   45 ++++++
> > > > >  board/friendlyarm/mini2440/lowlevel_init.S |   76 ++++++++++
> > > > >  board/friendlyarm/mini2440/mini2440.c      |  139
> > > > >  ++++++++++++++++++ board/friendlyarm/mini2440/mini2440.h      | 
> > > > >  104 ++++++++++++++ boards.cfg                                 |  
> > > > >   1 +
> > > > >  include/configs/mini2440.h                 |  215
> > > > > 
> > > > > ++++++++++++++++++++++++++++ 6 files changed, 580 insertions(+)
> > > > > 
> > > > >  create mode 100644 board/friendlyarm/mini2440/Makefile
> > > > >  create mode 100644 board/friendlyarm/mini2440/lowlevel_init.S
> > > > >  create mode 100644 board/friendlyarm/mini2440/mini2440.c
> > > > >  create mode 100644 board/friendlyarm/mini2440/mini2440.h
> > > > >  create mode 100644 include/configs/mini2440.h
> > > > > 
> > > > > diff --git a/board/friendlyarm/mini2440/Makefile
> > > > > b/board/friendlyarm/mini2440/Makefile new file mode 100644
> > > > > index 0000000..e8d68cb
> > > > > --- /dev/null
> > > > > +++ b/board/friendlyarm/mini2440/Makefile
> > > > > @@ -0,0 +1,45 @@
> > > > > +#
> > > > > +# (C) Copyright 2012
> > > > > +# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
> > > > > +#
> > > > > +# See file CREDITS for list of people who contributed to this
> > > > > +# project.
> > > > > +#
> > > > > +# This program is free software; you can redistribute it and/or
> > > > > +# modify it under the terms of the GNU General Public License as
> > > > > +# published by the Free Software Foundation; either version 2 of
> > > > > +# the License, or (at your option) any later version.
> > > > > +#
> > > > > +# This program is distributed in the hope that it will be useful,
> > > > > +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > > > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > > > +# GNU General Public License for more details.
> > > > > +#
> > > > > +# You should have received a copy of the GNU General Public
> > > > > License +# along with this program; if not, write to the Free
> > > > > Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > > > > +# MA 02111-1307 USA
> > > > > +#
> > > > > +
> > > > > +include $(TOPDIR)/config.mk
> > > > > +
> > > > > +LIB	= $(obj)lib$(BOARD).o
> > > > > +
> > > > > +COBJS	:= mini2440.o
> > > > > +SOBJS	:= lowlevel_init.o
> > > > > +
> > > > > +SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
> > > > > +OBJS	:= $(addprefix $(obj),$(COBJS))
> > > > > +SOBJS	:= $(addprefix $(obj),$(SOBJS))
> > > > > +
> > > > > +$(LIB):	$(obj).depend $(OBJS) $(SOBJS)
> > > > > +	$(call cmd_link_o_target, $(OBJS) $(SOBJS))
> > > > > +
> > > > > +##################################################################
> > > > > #### ### +
> > > > > +# defines $(obj).depend target
> > > > > +include $(SRCTREE)/rules.mk
> > > > > +
> > > > > +sinclude $(obj).depend
> > > > > +
> > > > > +##################################################################
> > > > > #### ### diff --git a/board/friendlyarm/mini2440/lowlevel_init.S
> > > > > b/board/friendlyarm/mini2440/lowlevel_init.S new file mode 100644
> > > > > index 0000000..f69a08c
> > > > > --- /dev/null
> > > > > +++ b/board/friendlyarm/mini2440/lowlevel_init.S
> > > > > @@ -0,0 +1,76 @@
> > > > > +/*
> > > > > + * Memory Setup stuff - taken from blob memsetup.S
> > > > > + *
> > > > > + * Copyright (C) 1999 2000 2001 Erik Mouw
> > > > > (J.A.K.Mouw at its.tudelft.nl) and + *                     Jan-Derk
> > > > > Bakker
> > > > > (J.D.Bakker at its.tudelft.nl) + *
> > > > > + * Modified for the Samsung SMDK2410 by
> > > > > + * (C) Copyright 2002
> > > > > + * David Mueller, ELSOFT AG, <d.mueller@elsoft.ch>
> > > > > + *
> > > > > + * (C) Copyright 2012
> > > > > + * Gabriel Huau <contact@huau-gabriel.fr>
> > > > > + *
> > > > > + * See file CREDITS for list of people who contributed to this
> > > > > + * project.
> > > > > + *
> > > > > + * This program is free software; you can redistribute it and/or
> > > > > + * modify it under the terms of the GNU General Public License as
> > > > > + * published by the Free Software Foundation; either version 2 of
> > > > > + * the License, or (at your option) any later version.
> > > > > + *
> > > > > + * This program is distributed in the hope that it will be useful,
> > > > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > > > + * GNU General Public License for more details.
> > > > > + *
> > > > > + * You should have received a copy of the GNU General Public
> > > > > License + * along with this program; if not, write to the Free
> > > > > Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > > > > + * MA 02111-1307 USA
> > > > > + */
> > > > > +
> > > > > +#include <config.h>
> > > > > +#include <version.h>
> > > > > +#include "mini2440.h"
> > > > > +
> > > > > +_TEXT_BASE:
> > > > > +	.word	CONFIG_SYS_TEXT_BASE
> > > > > +
> > > > > +.globl lowlevel_init
> > > > > +lowlevel_init:
> > > > > +	/* memory control configuration */
> > > > > +	/* make r0 relative the current location so that it */
> > > > > +	/* reads SMRDATA out of FLASH rather than memory ! */
> > > > > +	ldr     r0, =SMRDATA
> > > > > +	ldr	r1, _TEXT_BASE
> > > > > +	sub	r0, r0, r1
> > > > > +	ldr	r1, =BWSCON	/* Bus Width Status Controller */
> > > > > +	add     r2, r0, #13*4
> > > > > +0:
> > > > > +	ldr     r3, [r0], #4
> > > > > +	str     r3, [r1], #4
> > > > > +	cmp     r2, r0
> > > > > +	bne     0b
> > > > > +
> > > > > +	/* everything is fine now */
> > > > > +	mov	pc, lr
> > > > > +
> > > > > +	.ltorg
> > > > > +/* the literal pools origin */
> > > > > +
> > > > > +SMRDATA:
> > > > > +    .word
> > > > > (0+(B1_BWSCON<<4)+(B2_BWSCON<<8)+(B3_BWSCON<<12)+(B4_BWSCON<<16)+(B
> > > > > 5_BW SCO N<<20)+(B6_BWSCON<<24)+(B7_BWSCON<<28)) +    .word
> > > > > ((B0_Tacs<<13)+(B0_Tcos<<11)+(B0_Tacc<<8)+(B0_Tcoh<<6)+(B0_Tah<<4)+
> > > > > (B0_ Tac p<<2)+(B0_PMC)) +    .word
> > > > > ((B1_Tacs<<13)+(B1_Tcos<<11)+(B1_Tacc<<8)+(B1_Tcoh<<6)+(B1_Tah<<4)+
> > > > > (B1_ Tac p<<2)+(B1_PMC)) +    .word
> > > > > ((B2_Tacs<<13)+(B2_Tcos<<11)+(B2_Tacc<<8)+(B2_Tcoh<<6)+(B2_Tah<<4)+
> > > > > (B2_ Tac p<<2)+(B2_PMC)) +    .word
> > > > > ((B3_Tacs<<13)+(B3_Tcos<<11)+(B3_Tacc<<8)+(B3_Tcoh<<6)+(B3_Tah<<4)+
> > > > > (B3_ Tac p<<2)+(B3_PMC)) +    .word
> > > > > ((B4_Tacs<<13)+(B4_Tcos<<11)+(B4_Tacc<<8)+(B4_Tcoh<<6)+(B4_Tah<<4)+
> > > > > (B4_ Tac p<<2)+(B4_PMC)) +    .word
> > > > > ((B5_Tacs<<13)+(B5_Tcos<<11)+(B5_Tacc<<8)+(B5_Tcoh<<6)+(B5_Tah<<4)+
> > > > > (B5_ Tac p<<2)+(B5_PMC)) +
> > > > > +    .word ((B6_MT<<15)+(B6_Trcd<<2)+(B6_SCAN))
> > > > > +    .word ((B7_MT<<15)+(B7_Trcd<<2)+(B7_SCAN))
> > > > > +    .word
> > > > > ((REFEN<<23)+(TREFMD<<22)+(Trp<<20)+(Trc<<18)+(Tchr<<16)+REFCNT) +
> > > > > .word 0x32
> > > > > +    .word 0x30
> > > > > +    .word 0x30
> > > > 
> > > > What this undocumented stuff?
> > > 
> > > SoC specific, I pasted it from smdk2410, it's for initialize the DRAM.
> > 
> > Can't you init DRAM in some more fitting place? Also document this?
> 
> I don't know, this part is a bit difficult for me, but I'm going to try
> to document it with the help of the SoC documentation.
> 
> For the place, should I move it to mini2440.c in arch_cpu_init() or
> board_early_init_f() ? I don't really know the difference.

dram_init() maybe ?

> 
> > > > > diff --git a/board/friendlyarm/mini2440/mini2440.c
> > > > > b/board/friendlyarm/mini2440/mini2440.c new file mode 100644
> > > > > index 0000000..9ba8d39
> > > > > --- /dev/null
> > > > > +++ b/board/friendlyarm/mini2440/mini2440.c
> > > > > @@ -0,0 +1,139 @@
> > > > > +/*
> > > > > + * (C) Copyright 2002
> > > > > + * Sysgo Real-Time Solutions, GmbH <www.elinos.com>
> > > > > + * Marius Groeger <mgroeger@sysgo.de>
> > > > > + *
> > > > > + * (C) Copyright 2002
> > > > > + * David Mueller, ELSOFT AG, <d.mueller@elsoft.ch>
> > > > > + *
> > > > > + * (C) Copyright 2009
> > > > > + * Michel Pollet <buserror@gmail.com>
> > > > > + *
> > > > > + * (C) Copyright 2012
> > > > > + * Gabriel Huau <contact@huau-gabriel.fr>
> > > > > + *
> > > > > + * See file CREDITS for list of people who contributed to this
> > > > > + * project.
> > > > > + *
> > > > > + * This program is free software; you can redistribute it and/or
> > > > > + * modify it under the terms of the GNU General Public License as
> > > > > + * published by the Free Software Foundation; either version 2 of
> > > > > + * the License, or (at your option) any later version.
> > > > > + *
> > > > > + * This program is distributed in the hope that it will be useful,
> > > > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > > > + * GNU General Public License for more details.
> > > > > + *
> > > > > + * You should have received a copy of the GNU General Public
> > > > > License + * along with this program; if not, write to the Free
> > > > > Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > > > > + * MA 02111-1307 USA
> > > > > + */
> > > > > +
> > > > > +#include <common.h>
> > > > > +#include <asm/arch/s3c2440.h>
> > > > > +#include <asm/io.h>
> > > > > +#include <video_fb.h>
> > > > > +#include "mini2440.h"
> > > > > +
> > > > > +#ifdef CONFIG_DRIVER_DM9000
> > > > > +#include <netdev.h>
> > > > > +#endif
> > > > > +
> > > > > +DECLARE_GLOBAL_DATA_PTR;
> > > > > +
> > > > > +static inline void pll_delay(unsigned long loops)
> > > > > +{
> > > > > +	__asm__ volatile ("1:\n"
> > > > > +	  "subs %0, %1, #1\n"
> > > > > +	  "bne 1b" : "=r" (loops) : "0" (loops));
> > > > > +}
> > > > > +
> > > > > +int arch_cpu_init(void)
> > > > > +{
> > > > > +	struct s3c24x0_clock_power * const clk_power =
> > > > > +					s3c24x0_get_base_clock_power();
> > > > > +
> > > > > +	/* to reduce PLL lock time, adjust the LOCKTIME register */
> > > > > +	clk_power->locktime = 0xFFFFFF;
> > > > > +	clk_power->clkdivn = CLKDIVN_VAL;
> > > > > +
> > > > > +	/* configure UPLL */
> > > > > +	clk_power->upllcon = ((U_M_MDIV << 12) + (U_M_PDIV << 4) +
> > > > > U_M_SDIV); +	/* some delay between MPLL and UPLL */
> > > > > +	pll_delay(100000);
> > > > > +
> > > > > +	/* configure MPLL */
> > > > > +	clk_power->mpllcon = ((M_MDIV << 12) + (M_PDIV << 4) + M_SDIV);
> > > > > +
> > > > > +	/* some delay between MPLL and UPLL */
> > > > > +	pll_delay(500000);
> > > > 
> > > > You use udelay() below, do you need pll_delay() at all?
> > > 
> > > Yes, because initialisation of PLL is done before timer_init(), so we
> > > can't use udelay().
> > 
> > Maybe fix the timer driver?
> 
> As PLL initialization is SoC specific, should I move it to
> arch/arch/cpu/arm920t/s3c24x0/timer.c in timer_init() ?

Yes

> With this modification, I will have to patch all board based
> on s3c24x0, because they are all using this "hack". Should this
> modification be part of another patch ? (for me, yes ...)

Yes

...

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-19 21:37         ` Ilya Averyanov
@ 2012-04-19 22:23           ` Marek Vasut
  2012-04-19 22:30             ` Graeme Russ
  0 siblings, 1 reply; 42+ messages in thread
From: Marek Vasut @ 2012-04-19 22:23 UTC (permalink / raw)
  To: u-boot

Dear Ilya Averyanov,

> 2012/4/20 Marek Vasut <marex@denx.de>
> 
> > Dear Gabriel Huau,
> > 
> > > On Thu, Apr 19, 2012 at 10:08:47PM +0200, Marek Vasut wrote:
> > > > Dear Gabriel Huau,
> > > > 
> > > > > ---
> > > > > 
> > > > > Changes for v2:
> > > > >   - Coding style cleanup
> > > > >   - Remove unnecessary files modification
> > > > >   - Remove unnecessary board configuration set
> > > > > 
> > > > > Changes for v3:
> > > > >   - Coding style cleanup
> > > > >   - Move some macro definition from lowlevel_init.S
> > > > >   to a new header
> > > > >   - Remove some "magic bloat" with I/O board initialization
> > > > >   - Add a pll_delay and replace loop by it
> > > > >   - Somme cleanup in the configuration file
> > > > >   - Cancel modifications on an SoC specific header
> > > > >   - Add my name to copyright
> > > > > 
> > > > > ---
> > > > > 
> > > > >  board/friendlyarm/mini2440/Makefile        |   45 ++++++
> > > > >  board/friendlyarm/mini2440/lowlevel_init.S |   76 ++++++++++
> > > > >  board/friendlyarm/mini2440/mini2440.c      |  139
> > > > >  ++++++++++++++++++ board/friendlyarm/mini2440/mini2440.h      | 
> > > > >  104 ++++++++++++++ boards.cfg                                 |  
> > > > >   1 +
> > > > >  include/configs/mini2440.h                 |  215
> > > > > 
> > > > > ++++++++++++++++++++++++++++ 6 files changed, 580 insertions(+)
> > > > > 
> > > > >  create mode 100644 board/friendlyarm/mini2440/Makefile
> > > > >  create mode 100644 board/friendlyarm/mini2440/lowlevel_init.S
> > > > >  create mode 100644 board/friendlyarm/mini2440/mini2440.c
> > > > >  create mode 100644 board/friendlyarm/mini2440/mini2440.h
> > > > >  create mode 100644 include/configs/mini2440.h
> > > > > 
> > > > > diff --git a/board/friendlyarm/mini2440/Makefile
> > > > > b/board/friendlyarm/mini2440/Makefile new file mode 100644
> > > > > index 0000000..e8d68cb
> > > > > --- /dev/null
> > > > > +++ b/board/friendlyarm/mini2440/Makefile
> > > > > @@ -0,0 +1,45 @@
> > > > > +#
> > > > > +# (C) Copyright 2012
> > > > > +# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
> > > > > +#
> > > > > +# See file CREDITS for list of people who contributed to this
> > > > > +# project.
> > > > > +#
> > > > > +# This program is free software; you can redistribute it and/or
> > > > > +# modify it under the terms of the GNU General Public License as
> > > > > +# published by the Free Software Foundation; either version 2 of
> > > > > +# the License, or (at your option) any later version.
> > > > > +#
> > > > > +# This program is distributed in the hope that it will be useful,
> > > > > +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > > > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > > > +# GNU General Public License for more details.
> > > > > +#
> > > > > +# You should have received a copy of the GNU General Public
> > > > > License +# along with this program; if not, write to the Free
> > > > > Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > > > > +# MA 02111-1307 USA
> > > > > +#
> > > > > +
> > > > > +include $(TOPDIR)/config.mk
> > > > > +
> > > > > +LIB      = $(obj)lib$(BOARD).o
> > > > > +
> > > > > +COBJS    := mini2440.o
> > > > > +SOBJS    := lowlevel_init.o
> > > > > +
> > > > > +SRCS     := $(SOBJS:.o=.S) $(COBJS:.o=.c)
> > > > > +OBJS     := $(addprefix $(obj),$(COBJS))
> > > > > +SOBJS    := $(addprefix $(obj),$(SOBJS))
> > > > > +
> > > > > +$(LIB):  $(obj).depend $(OBJS) $(SOBJS)
> > > > > + $(call cmd_link_o_target, $(OBJS) $(SOBJS))
> > > > > +
> > 
> > +######################################################################
> > 
> > > > > ### +
> > > > > +# defines $(obj).depend target
> > > > > +include $(SRCTREE)/rules.mk
> > > > > +
> > > > > +sinclude $(obj).depend
> > > > > +
> > 
> > +######################################################################
> > 
> > > > > ### diff --git a/board/friendlyarm/mini2440/lowlevel_init.S
> > > > > b/board/friendlyarm/mini2440/lowlevel_init.S new file mode 100644
> > > > > index 0000000..f69a08c
> > > > > --- /dev/null
> > > > > +++ b/board/friendlyarm/mini2440/lowlevel_init.S
> > > > > @@ -0,0 +1,76 @@
> > > > > +/*
> > > > > + * Memory Setup stuff - taken from blob memsetup.S
> > > > > + *
> > > > > + * Copyright (C) 1999 2000 2001 Erik Mouw (
> > 
> > J.A.K.Mouw at its.tudelft.nl)
> > 
> > > > > and + *                     Jan-Derk Bakker
> > > > > (J.D.Bakker at its.tudelft.nl) + *
> > > > > + * Modified for the Samsung SMDK2410 by
> > > > > + * (C) Copyright 2002
> > > > > + * David Mueller, ELSOFT AG, <d.mueller@elsoft.ch>
> > > > > + *
> > > > > + * (C) Copyright 2012
> > > > > + * Gabriel Huau <contact@huau-gabriel.fr>
> > > > > + *
> > > > > + * See file CREDITS for list of people who contributed to this
> > > > > + * project.
> > > > > + *
> > > > > + * This program is free software; you can redistribute it and/or
> > > > > + * modify it under the terms of the GNU General Public License as
> > > > > + * published by the Free Software Foundation; either version 2 of
> > > > > + * the License, or (at your option) any later version.
> > > > > + *
> > > > > + * This program is distributed in the hope that it will be useful,
> > > > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > > > + * GNU General Public License for more details.
> > > > > + *
> > > > > + * You should have received a copy of the GNU General Public
> > > > > License + * along with this program; if not, write to the Free
> > > > > Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > > > > + * MA 02111-1307 USA
> > > > > + */
> > > > > +
> > > > > +#include <config.h>
> > > > > +#include <version.h>
> > > > > +#include "mini2440.h"
> > > > > +
> > > > > +_TEXT_BASE:
> > > > > + .word   CONFIG_SYS_TEXT_BASE
> > > > > +
> > > > > +.globl lowlevel_init
> > > > > +lowlevel_init:
> > > > > + /* memory control configuration */
> > > > > + /* make r0 relative the current location so that it */
> > > > > + /* reads SMRDATA out of FLASH rather than memory ! */
> > > > > + ldr     r0, =SMRDATA
> > > > > + ldr     r1, _TEXT_BASE
> > > > > + sub     r0, r0, r1
> > > > > + ldr     r1, =BWSCON     /* Bus Width Status Controller */
> > > > > + add     r2, r0, #13*4
> > > > > +0:
> > > > > + ldr     r3, [r0], #4
> > > > > + str     r3, [r1], #4
> > > > > + cmp     r2, r0
> > > > > + bne     0b
> > > > > +
> > > > > + /* everything is fine now */
> > > > > + mov     pc, lr
> > > > > +
> > > > > + .ltorg
> > > > > +/* the literal pools origin */
> > > > > +
> > > > > +SMRDATA:
> > > > > +    .word
> > 
> > (0+(B1_BWSCON<<4)+(B2_BWSCON<<8)+(B3_BWSCON<<12)+(B4_BWSCON<<16)+(B5_BW
> > 
> > > > > SCO N<<20)+(B6_BWSCON<<24)+(B7_BWSCON<<28)) +    .word
> > 
> > ((B0_Tacs<<13)+(B0_Tcos<<11)+(B0_Tacc<<8)+(B0_Tcoh<<6)+(B0_Tah<<4)+(B0_
> > 
> > > > > Tac p<<2)+(B0_PMC)) +    .word
> > 
> > ((B1_Tacs<<13)+(B1_Tcos<<11)+(B1_Tacc<<8)+(B1_Tcoh<<6)+(B1_Tah<<4)+(B1_
> > 
> > > > > Tac p<<2)+(B1_PMC)) +    .word
> > 
> > ((B2_Tacs<<13)+(B2_Tcos<<11)+(B2_Tacc<<8)+(B2_Tcoh<<6)+(B2_Tah<<4)+(B2_
> > 
> > > > > Tac p<<2)+(B2_PMC)) +    .word
> > 
> > ((B3_Tacs<<13)+(B3_Tcos<<11)+(B3_Tacc<<8)+(B3_Tcoh<<6)+(B3_Tah<<4)+(B3_
> > 
> > > > > Tac p<<2)+(B3_PMC)) +    .word
> > 
> > ((B4_Tacs<<13)+(B4_Tcos<<11)+(B4_Tacc<<8)+(B4_Tcoh<<6)+(B4_Tah<<4)+(B4_
> > 
> > > > > Tac p<<2)+(B4_PMC)) +    .word
> > 
> > ((B5_Tacs<<13)+(B5_Tcos<<11)+(B5_Tacc<<8)+(B5_Tcoh<<6)+(B5_Tah<<4)+(B5_
> > 
> > > > > Tac p<<2)+(B5_PMC)) +
> > > > > +    .word ((B6_MT<<15)+(B6_Trcd<<2)+(B6_SCAN))
> > > > > +    .word ((B7_MT<<15)+(B7_Trcd<<2)+(B7_SCAN))
> > > > > +    .word
> > > > > ((REFEN<<23)+(TREFMD<<22)+(Trp<<20)+(Trc<<18)+(Tchr<<16)+REFCNT) +
> > > > > .word 0x32
> > > > > +    .word 0x30
> > > > > +    .word 0x30
> > > > 
> > > > What this undocumented stuff?
> > > 
> > > SoC specific, I pasted it from smdk2410, it's for initialize the DRAM.
> > 
> > Can't you init DRAM in some more fitting place? Also document this?
> > 
> > > > > diff --git a/board/friendlyarm/mini2440/mini2440.c
> > > > > b/board/friendlyarm/mini2440/mini2440.c new file mode 100644
> > > > > index 0000000..9ba8d39
> > > > > --- /dev/null
> > > > > +++ b/board/friendlyarm/mini2440/mini2440.c
> > > > > @@ -0,0 +1,139 @@
> > > > > +/*
> > > > > + * (C) Copyright 2002
> > > > > + * Sysgo Real-Time Solutions, GmbH <www.elinos.com>
> > > > > + * Marius Groeger <mgroeger@sysgo.de>
> > > > > + *
> > > > > + * (C) Copyright 2002
> > > > > + * David Mueller, ELSOFT AG, <d.mueller@elsoft.ch>
> > > > > + *
> > > > > + * (C) Copyright 2009
> > > > > + * Michel Pollet <buserror@gmail.com>
> > > > > + *
> > > > > + * (C) Copyright 2012
> > > > > + * Gabriel Huau <contact@huau-gabriel.fr>
> > > > > + *
> > > > > + * See file CREDITS for list of people who contributed to this
> > > > > + * project.
> > > > > + *
> > > > > + * This program is free software; you can redistribute it and/or
> > > > > + * modify it under the terms of the GNU General Public License as
> > > > > + * published by the Free Software Foundation; either version 2 of
> > > > > + * the License, or (at your option) any later version.
> > > > > + *
> > > > > + * This program is distributed in the hope that it will be useful,
> > > > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > > > + * GNU General Public License for more details.
> > > > > + *
> > > > > + * You should have received a copy of the GNU General Public
> > > > > License + * along with this program; if not, write to the Free
> > > > > Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > > > > + * MA 02111-1307 USA
> > > > > + */
> > > > > +
> > > > > +#include <common.h>
> > > > > +#include <asm/arch/s3c2440.h>
> > > > > +#include <asm/io.h>
> > > > > +#include <video_fb.h>
> > > > > +#include "mini2440.h"
> > > > > +
> > > > > +#ifdef CONFIG_DRIVER_DM9000
> > > > > +#include <netdev.h>
> > > > > +#endif
> > > > > +
> > > > > +DECLARE_GLOBAL_DATA_PTR;
> > > > > +
> > > > > +static inline void pll_delay(unsigned long loops)
> > > > > +{
> > > > > + __asm__ volatile ("1:\n"
> > > > > +   "subs %0, %1, #1\n"
> > > > > +   "bne 1b" : "=r" (loops) : "0" (loops));
> > > > > +}
> > > > > +
> > > > > +int arch_cpu_init(void)
> > > > > +{
> > > > > + struct s3c24x0_clock_power * const clk_power =
> > > > > +                                 s3c24x0_get_base_clock_power();
> > > > > +
> > > > > + /* to reduce PLL lock time, adjust the LOCKTIME register */
> > > > > + clk_power->locktime = 0xFFFFFF;
> > > > > + clk_power->clkdivn = CLKDIVN_VAL;
> > > > > +
> > > > > + /* configure UPLL */
> > > > > + clk_power->upllcon = ((U_M_MDIV << 12) + (U_M_PDIV << 4) +
> > 
> > U_M_SDIV);
> > 
> > > > > + /* some delay between MPLL and UPLL */
> > > > > + pll_delay(100000);
> > > > > +
> > > > > + /* configure MPLL */
> > > > > + clk_power->mpllcon = ((M_MDIV << 12) + (M_PDIV << 4) + M_SDIV);
> > > > > +
> > > > > + /* some delay between MPLL and UPLL */
> > > > > + pll_delay(500000);
> > > > 
> > > > You use udelay() below, do you need pll_delay() at all?
> > > 
> > > Yes, because initialisation of PLL is done before timer_init(), so we
> > > can't use udelay().
> > 
> > Maybe fix the timer driver?
> 
> How fix timer driver if arch_cpu_init(void) call befor timer_init in
> \arch\arm\lib\board.c:227 init_fnc_t *init_sequence[] = {

Where did you get such a weird path? \arch\arm... ?

btw you can always check some bit, if the timer is enabled, behave one way, 
otherwise, behave other way.

> > > > > +
> > > > > + return 0;
> > > > > +}
> > > > > +
> > > > > +/*
> > > > > + * Miscellaneous platform dependent initialisations
> > > > > + */
> > > > > +int board_init(void)
> > > > > +{
> > > > > + struct s3c24x0_clock_power * const clk_power =
> > > > > +                                 s3c24x0_get_base_clock_power();
> > > > > + struct s3c24x0_gpio * const gpio = s3c24x0_get_base_gpio();
> > > > > +
> > > > > + /* to reduce PLL lock time, adjust the LOCKTIME register */
> > > > > + clk_power->locktime = 0xFFFFFF;
> > > > > + clk_power->clkdivn = CLKDIVN_VAL;
> > > > > +
> > > > > + /* configure UPLL */
> > > > > + clk_power->upllcon = ((U_M_MDIV << 12) + (U_M_PDIV << 4) +
> > 
> > U_M_SDIV);
> > 
> > > > > + /* some delay between MPLL and UPLL */
> > > > > + udelay(10);
> > > > > + /* configure MPLL */
> > > > > + clk_power->mpllcon = ((M_MDIV << 12) + (M_PDIV << 4) + M_SDIV);
> > > > > +
> > > > > + /* some delay between MPLL and UPLL */
> > > > > + udelay(8000);
> > > > > +
> > > > > + /* set up the I/O ports */
> > > > > + writel(0x007FFFFF, &gpio->gpacon);
> > > > > + writel(0x00044555, &gpio->gpbcon);
> > > > > + writel(0x000007FF, &gpio->gpbup);
> > > > > + writel(0xAAAAAAAA, &gpio->gpccon);
> > > > > + writel(0x0000FFFF, &gpio->gpcup);
> > > > > + writel(0xAAAAAAAA, &gpio->gpdcon);
> > > > > + writel(0x0000FFFF, &gpio->gpdup);
> > > > > + writel(0xAAAAAAAA, &gpio->gpecon);
> > > > > + writel(0x0000FFFF, &gpio->gpeup);
> > > > > + writel(0x000055AA, &gpio->gpfcon);
> > > > > + writel(0x000000FF, &gpio->gpfup);
> > > > > + writel(0xFF95FFBA, &gpio->gpgcon);
> > > > > + writel(0x0000FFFF, &gpio->gpgup);
> > > > > + writel(0x002AFAAA, &gpio->gphcon);
> > > > > + writel(0x000007FF, &gpio->gphup);
> > > > > +
> > > > > + /* adress of boot parameters */
> > > > > + gd->bd->bi_boot_params = CONFIG_BOOT_PARAM_ADDR;
> > > > > +
> > > > > + return 0;
> > > > > +}
> > > > > +
> > > > > +int dram_init(void)
> > > > > +{
> > > > > + gd->ram_size = PHYS_SDRAM_1_SIZE;
> > > > > + return 0;
> > > > > +}
> > > > > +
> > > > > +int board_eth_init(bd_t *bis)
> > > > > +{
> > > > > +#ifdef CONFIG_DRIVER_DM9000
> > > > > + return dm9000_initialize(bis);
> > > > > +#else
> > > > > + return 0;
> > > > > +#endif
> > > > > +}
> > > > > +
> > > > > +/* The sum of all part_size[]s must equal to the NAND size, i.e.,
> > > > > 0x4000000 */ +unsigned int dynpart_size[] = { 0x40000, 0x20000,
> > > > > 0x500000, 0xffffffff, 0 }; +char *dynpart_names[] = { "u-boot",
> > > > > "u-boot_env", "kernel", "rootfs", NULL }; diff --git
> > > > > a/board/friendlyarm/mini2440/mini2440.h
> > > > > b/board/friendlyarm/mini2440/mini2440.h new file mode 100644
> > > > > index 0000000..02197c8
> > > > > --- /dev/null
> > > > > +++ b/board/friendlyarm/mini2440/mini2440.h
> > > > > @@ -0,0 +1,104 @@
> > > > > +/*
> > > > > + * Taken from linux/arch/arm/boot/compressed/head-s3c2410.S
> > > > > + * Copyright (C) 2002 Samsung Electronics SW.LEE
> > > > > <hitchcar@sec.samsung.com> + */
> > > > > +
> > > > > +#ifndef BOARD_LL_MINI2440_H
> > > > > +#define BOARD_LL_MINI2440_H
> > > > > +
> > > > > +/*
> > > > > + * PLL/Clock configuration
> > > > > + */
> > > > > +/* FCLK = 405 MHz, HCLK = 101 MHz, PCLK = 50 MHz, UCLK = 48 MHz */
> > > > > +#define CLKDIVN_VAL      7
> > > > > +#define M_MDIV           0x7f
> > > > > +#define M_PDIV           0x2
> > > > > +#define M_SDIV           0x1
> > > > > +
> > > > > +#define U_M_MDIV 0x38
> > > > > +#define U_M_PDIV 0x2
> > > > > +#define U_M_SDIV 0x2
> > > > > +
> > > > > +/* BWSCON */
> > > > > +#define BWSCON   0x48000000
> > > > > +#define DW8              (0x0)
> > > > > +#define DW16     (0x1)
> > > > > +#define DW32     (0x2)
> > > > > +#define WAIT     (0x1<<2)
> > > > > +#define UBLB     (0x1<<3)
> > > > > +
> > > > > +#define B1_BWSCON                (DW32)
> > > > > +#define B2_BWSCON                (DW16)
> > > > > +#define B3_BWSCON                (DW16 + WAIT + UBLB)
> > > > > +#define B4_BWSCON                (DW16)
> > > > > +#define B5_BWSCON                (DW16)
> > > > > +#define B6_BWSCON                (DW32)
> > > > > +#define B7_BWSCON                (DW32)
> > > > > +
> > > > > +/* BANK0CON */
> > > > > +#define B0_Tacs          0x0     /*  0clk */
> > > > > +#define B0_Tcos          0x0     /*  0clk */
> > > > > +#define B0_Tacc          0x7     /* 14clk */
> > > > > +#define B0_Tcoh          0x0     /*  0clk */
> > > > > +#define B0_Tah           0x0     /*  0clk */
> > > > > +#define B0_Tacp          0x0
> > > > > +#define B0_PMC           0x0     /* normal */
> > > > > +
> > > > > +/* BANK1CON */
> > > > > +#define B1_Tacs          0x0     /*  0clk */
> > > > > +#define B1_Tcos          0x0     /*  0clk */
> > > > > +#define B1_Tacc          0x7     /* 14clk */
> > > > > +#define B1_Tcoh          0x0     /*  0clk */
> > > > > +#define B1_Tah           0x0     /*  0clk */
> > > > > +#define B1_Tacp          0x0
> > > > > +#define B1_PMC           0x0
> > > > > +
> > > > > +#define B2_Tacs          0x0
> > > > > +#define B2_Tcos          0x0
> > > > > +#define B2_Tacc          0x7
> > > > > +#define B2_Tcoh          0x0
> > > > > +#define B2_Tah           0x0
> > > > > +#define B2_Tacp          0x0
> > > > > +#define B2_PMC           0x0
> > > > > +
> > > > > +#define B3_Tacs          0x0     /*  0clk */
> > > > > +#define B3_Tcos          0x3     /*  4clk */
> > > > > +#define B3_Tacc          0x7     /* 14clk */
> > > > > +#define B3_Tcoh          0x1     /*  1clk */
> > > > > +#define B3_Tah           0x0     /*  0clk */
> > > > > +#define B3_Tacp          0x3     /*  6clk */
> > > > > +#define B3_PMC           0x0     /* normal */
> > > > > +
> > > > > +#define B4_Tacs          0x0     /*  0clk */
> > > > > +#define B4_Tcos          0x0     /*  0clk */
> > > > > +#define B4_Tacc          0x7     /* 14clk */
> > > > > +#define B4_Tcoh          0x0     /*  0clk */
> > > > > +#define B4_Tah           0x0     /*  0clk */
> > > > > +#define B4_Tacp          0x0
> > > > > +#define B4_PMC           0x0     /* normal */
> > > > > +
> > > > > +#define B5_Tacs          0x0     /*  0clk */
> > > > > +#define B5_Tcos          0x0     /*  0clk */
> > > > > +#define B5_Tacc          0x7     /* 14clk */
> > > > > +#define B5_Tcoh          0x0     /*  0clk */
> > > > > +#define B5_Tah           0x0     /*  0clk */
> > > > > +#define B5_Tacp          0x0
> > > > > +#define B5_PMC           0x0     /* normal */
> > > > > +
> > > > > +#define B6_MT            0x3     /* SDRAM */
> > > > > +#define B6_Trcd          0x1
> > > > > +#define B6_SCAN          0x1     /* 9bit */
> > > > > +
> > > > > +#define B7_MT            0x3     /* SDRAM */
> > > > > +#define B7_Trcd          0x1     /* 3clk */
> > > > > +#define B7_SCAN          0x1     /* 9bit */
> > > > > +
> > > > > +/* REFRESH parameter */
> > > > > +#define REFEN            0x1     /* Refresh enable */
> > > > > +#define TREFMD           0x0     /* CBR(CAS before RAS)/Auto
> > 
> > refresh */
> > 
> > > > > +#define Trp                      0x0     /* 2clk */
> > > > > +#define Trc                      0x3     /* 7clk */
> > > > > +#define Tchr             0x2     /* 3clk */
> > > > > +#define REFCNT           1113    /* period=15.6us, HCLK=60Mhz */
> > > > > +
> > > > > +#endif
> > > > > diff --git a/boards.cfg b/boards.cfg
> > > > > index 3cf75c3..93eeb3c 100644
> > > > > --- a/boards.cfg
> > > > > +++ b/boards.cfg
> > > > > @@ -61,6 +61,7 @@ mx1ads                       arm         arm920t
> > > > > -
> > > > > 
> > > > >                - scb9328                      arm         arm920t
> >   
> >   -
> >   
> > > > >                -              imx cm4008                       arm
> > > > > 
> > > > > arm920t     -                   -              ks8695 cm41xx
> > > > > 
> > > > >         arm         arm920t     -                   -
> > > > >         ks8695
> > > > > 
> > > > > +mini2440                     arm         arm920t     mini2440
> > > > > friendlyarm    s3c24x0 VCMA9                        arm
> > 
> > arm920t
> > 
> > > > >  vcma9               mpl            s3c24x0 smdk2410
> > > > > 
> > > > > arm         arm920t     -                   samsung        s3c24x0
> > > > > omap1510inn                  arm         arm925t     -
> > > > > ti diff --git a/include/configs/mini2440.h
> > 
> > b/include/configs/mini2440.h
> > 
> > > > > new file mode 100644
> > > > > index 0000000..a3f06d0
> > > > > --- /dev/null
> > > > > +++ b/include/configs/mini2440.h
> > > > > @@ -0,0 +1,215 @@
> > > > > +/*
> > > > > + * (C) Copyright 2002
> > > > > + * Sysgo Real-Time Solutions, GmbH <www.elinos.com>
> > > > > + * Marius Groeger <mgroeger@sysgo.de>
> > > > > + * Gary Jennejohn <gj@denx.de>
> > > > > + * David Mueller <d.mueller@elsoft.ch>
> > > > > + *
> > > > > + * (C) Copyright 2009-2010
> > > > > + * Michel Pollet <buserror@gmail.com>
> > > > > + *
> > > > > + * (C) Copyright 2012
> > > > > + * Gabriel Huau <contact@huau-gabriel.fr>
> > > > > + *
> > > > > + * Configuation settings for the MINI2440 board.
> > > > > + *
> > > > > + * See file CREDITS for list of people who contributed to this
> > > > > + * project.
> > > > > + *
> > > > > + * This program is free software; you can redistribute it and/or
> > > > > + * modify it under the terms of the GNU General Public License as
> > > > > + * published by the Free Software Foundation; either version 2 of
> > > > > + * the License, or (at your option) any later version.
> > > > > + *
> > > > > + * This program is distributed in the hope that it will be useful,
> > > > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > > > + * GNU General Public License for more details.
> > > > > + *
> > > > > + * You should have received a copy of the GNU General Public
> > > > > License + * along with this program; if not, write to the Free
> > > > > Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > > > > + * MA 02111-1307 USA
> > > > > + */
> > > > > +
> > > > > +#ifndef __CONFIG_H
> > > > > +#define __CONFIG_H
> > > > > +
> > > > > +#define CONFIG_SYS_TEXT_BASE 0x0
> > > > > +
> > > > > +/*
> > > > > + * High Level Configuration Options
> > > > > + */
> > > > > +#define CONFIG_ARM920T           1       /* This is an ARM920T
> > > > > Core
> > > > 
> > > > */
> > > > 
> > > > > +#define CONFIG_S3C24X0           1       /* in a SAMSUNG S3C2440
> > 
> > SoC */
> > 
> > > > > +#define CONFIG_S3C2440           1       /* in a SAMSUNG S3C2440
> > 
> > SoC */
> > 
> > > > > +#define CONFIG_MINI2440          1       /* on a MIN2440 Board
> >   
> >   */
> >   
> > > > > +
> > > > > +#define  MACH_TYPE_MINI2440      1999
> > > > > +#define  CONFIG_MACH_TYPE        MACH_TYPE_MINI2440
> > > > > +
> > > > > +/*
> > > > > + * It is possible to have u-boot save it's environment in NOR,
> > > > > however, + * reember it is incompatible with booting from NAND as
> > > > > the NOR is not + * available at that point. So use this only if
> > > > > you use nand as storage + * and will never boot from it
> > > > > + */
> > > > > +#define CONFIG_MINI2440_NOR_ENV  1
> > > > > +/* allow use of frequencies over 405Mhz */
> > > > > +#define CONFIG_MINI2440_OVERCLOCK 1
> > > > > +
> > > > > +/*
> > > > > + * input clock of PLL
> > > > > + */
> > > > > +/* MINI2440 has 12.0000MHz input clock */
> > > > > +#define CONFIG_SYS_CLK_FREQ      12000000
> > > > > +#define CONFIG_ARCH_CPU_INIT 1 /* for the initialization of PLL */
> > > > > +
> > > > > +#define USE_920T_MMU             1
> > > > > +#define CONFIG_BAUDRATE          115200
> > > > > +
> > > > > +/*
> > > > > + * Size of malloc() pool
> > > > > + */
> > > > > +#define CONFIG_SYS_MALLOC_LEN    (CONFIG_ENV_SIZE + 2048*1024)
> > > > > +/* size in bytes reserved for initial data */
> > > > > +#define CONFIG_GBL_DATA_SIZE     128
> > > > > +
> > > > > +/*
> > > > > + * Hardware drivers
> > > > > + */
> > > > > +#define CONFIG_DRIVER_DM9000                     1
> > > > > +#define CONFIG_DRIVER_DM9000_NO_EEPROM   1
> > > > > +#define CONFIG_DM9000_BASE                              
> > > > > 0x20000300 +#define DM9000_IO                CONFIG_DM9000_BASE
> > > > > +#define DM9000_DATA              (CONFIG_DM9000_BASE+4)
> > > > > +
> > > > > +/*
> > > > > + * select serial console configuration
> > > > > + */
> > > > > +#define CONFIG_S3C24X0_SERIAL
> > > > > +#define CONFIG_SERIAL1                   1
> > > > > +
> > > > > +/*
> > > > > + * allow to overwrite serial and ethaddr
> > > > > + */
> > > > > +#define CONFIG_ENV_OVERWRITE
> > > > > +
> > > > > +/*
> > > > > + * Command definition
> > > > > + */
> > > > > +#include <config_cmd_default.h>
> > > > > +
> > > > > +#define CONFIG_CMD_DHCP
> > > > > +#define CONFIG_CMD_PORTIO
> > > > > +#define CONFIG_CMD_REGINFO
> > > > > +#define CONFIG_CMD_SAVES
> > > > > +
> > > > > +/*
> > > > > + * Miscellaneous configurable options
> > > > > + */
> > > > > +#define  CONFIG_LONGHELP
> > > > > +#define  CONFIG_SYS_PROMPT               "MINI2440 => "
> > > > > +#define  CONFIG_SYS_CBSIZE               256
> > > > > +#define  CONFIG_SYS_PBSIZE
> > > > 
> > > > (CONFIG_SYS_CBSIZE+sizeof(CONFIG_SYS_PROMPT)+16)
> > > > 
> > > > > +#define  CONFIG_SYS_MAXARGS              32
> > > > > +#define CONFIG_SYS_BARGSIZE              CONFIG_SYS_CBSIZE
> > > > > +
> > > > > +#define CONFIG_SYS_MEMTEST_START 0x30000000
> > > > > +#define CONFIG_SYS_MEMTEST_END           0x34000000      /* 64MB
> > > > > in
> > 
> > DRAM
> > 
> > > > */
> > > > 
> > > > > +
> > > > > +/* everything, incl board info, in Hz */
> > > > > +#undef  CONFIG_CLKS_IN_HZ
> > > > > +
> > > > > +/* default load address  */
> > > > > +#define  CONFIG_SYS_LOAD_ADDR            0x32000000
> > > > > +
> > > > > +/* boot parameters address */
> > > > > +#define  CONFIG_BOOT_PARAM_ADDR          0x30000100
> > > > > +
> > > > > +/*
> > > > > + * the PWM TImer 4 uses a counter of 15625 for 10 ms, so we need
> > > > > + * it to wrap 100 times (total 1562500) to get 1 sec.
> > > > > + */
> > > > > +#define  CONFIG_SYS_HZ                   1562500
> > > > > +
> > > > > +/*
> > > > > + * valid baudrates
> > > > > + */
> > > > > +#define CONFIG_SYS_BAUDRATE_TABLE        { 9600, 19200, 38400,
> > 
> > 57600,
> > 115200
> > 
> > > > > } +
> > > > > +/*
> > > > > + * Stack sizes
> > > > > + * The stack sizes are set up in start.S using the settings below
> > > > > + */
> > > > > +#define CONFIG_STACKSIZE (128*1024)      /* regular stack */
> > > > > +#ifdef CONFIG_USE_IRQ
> > > > > +#define CONFIG_STACKSIZE_IRQ     (8*1024)        /* IRQ stack */
> > > > > +#define CONFIG_STACKSIZE_FIQ     (4*1024)        /* FIQ stack */
> > > > > +#endif
> > > > > +
> > > > > +/*
> > > > > + * Physical Memory Map
> > > > > + */
> > > > > +#define CONFIG_NR_DRAM_BANKS        1          /* we have 1 bank
> > > > > of DRAM */ +#define PHYS_SDRAM_1                0x30000000 /*
> > > > > SDRAM Bank #1 */ +#define PHYS_SDRAM_1_SIZE          
> > > > > (64*1024*1024) /* 64MB of DRAM */ +#define CONFIG_SYS_SDRAM_BASE  
> > > > >     PHYS_SDRAM_1
> > > > > +#define CONFIG_SYS_INIT_SP_ADDR          (CONFIG_SYS_SDRAM_BASE +
> > 
> > 0x1000
> > 
> > > > - \
> > > > 
> > > > > +
> > 
> > GENERATED_GBL_DATA_SIZE)
> > 
> > > > > +
> > > > > +/*
> > > > > + * When booting from NAND, it is impossible to access the lowest
> > > > > addresses + * due to the SteppingStone being in the way. Luckily
> > > > > the NOR doesn't really + * care about the highest 16 bits of
> > > > > address, so we set the controlers + * registers to go and poke
> > > > > over there, instead.
> > > > > + */
> > > > > +#define PHYS_FLASH_1                     0x0
> > > > > +#define CONFIG_SYS_FLASH_BASE    0x0
> > > > > +
> > > > > +/*
> > > > > + * NOR FLASH organization
> > > > > + * Now uses the standard CFI interface
> > > > > + * FLASH and environment organization
> > > > > + */
> > > > > +#define CONFIG_SYS_FLASH_CFI             1
> > > > > +#define CONFIG_FLASH_CFI_DRIVER          1
> > > > > +#define CONFIG_SYS_FLASH_CFI_WIDTH       FLASH_CFI_16BIT
> > > > > +#define CONFIG_SYS_MONITOR_BASE          0x0
> > > > > +/* max number of memory banks */
> > > > > +#define CONFIG_SYS_MAX_FLASH_BANKS       1
> > > > > +/* 512 * 4096 sectors, or 32 * 64k blocks */
> > > > > +#define CONFIG_SYS_MAX_FLASH_SECT        512
> > > > > +#define CONFIG_FLASH_SHOW_PROGRESS       1
> > > > > +
> > > > > +/*
> > > > > + * u-boot environmnent
> > > > > + */
> > > > > +#define CONFIG_BOOTDELAY 3
> > > > > +#define CONFIG_BOOTARGS          "root=/dev/sdb1
> > 
> > console=ttySAC0,115200"
> > 
> > > > > +#define CONFIG_NETMASK      255.255.255.0
> > > > > +#define CONFIG_IPADDR            192.168.0.2
> > > > > +#define CONFIG_SERVERIP          192.168.0.1
> > > > > +#define CONFIG_DOS_PARTITION     1
> > > > > +#define CONFIG_BOOTCOMMAND "tftp 0x32000000 uImage;bootm"
> > > > 
> > > > DROP THIS!
> > > 
> > > ok :-)
> > > 
> > > > > +
> > > > > +/*
> > > > > + * Config for NOR flash
> > > > > + */
> > > > > +#define CONFIG_ENV_IS_IN_FLASH   1
> > > > > +#define CONFIG_MY_ENV_OFFSET     0x40000
> > > > > +/* addr of environment */
> > > > > +#define CONFIG_ENV_ADDR          (PHYS_FLASH_1 +
> > 
> > CONFIG_MY_ENV_OFFSET)
> > 
> > > > > +/* 16k Total Size of Environment Sector */
> > > > > +#define CONFIG_ENV_SIZE          0x4000
> > > > > +
> > > > > +#define CONFIG_PREBOOT_OVERRIDE  1
> > > > > +
> > > > > +/* ATAG configuration */
> > > > > +#define CONFIG_INITRD_TAG                        1
> > > > > +#define CONFIG_SETUP_MEMORY_TAGS 1
> > > > > +#define CONFIG_CMDLINE_TAG                       1
> > > > > +#define CONFIG_CMDLINE_EDITING           1
> > > > > +#define CONFIG_AUTO_COMPLETE             1
> > > > > +
> > > > > +#endif   /* __CONFIG_H */
> > 
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot at lists.denx.de
> > http://lists.denx.de/mailman/listinfo/u-boot

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-19 22:23           ` Marek Vasut
@ 2012-04-19 22:30             ` Graeme Russ
  0 siblings, 0 replies; 42+ messages in thread
From: Graeme Russ @ 2012-04-19 22:30 UTC (permalink / raw)
  To: u-boot

Hi Marek,

On Fri, Apr 20, 2012 at 8:23 AM, Marek Vasut <marex@denx.de> wrote:
> Dear Ilya Averyanov,
>
>> 2012/4/20 Marek Vasut <marex@denx.de>
>>
>> > Dear Gabriel Huau,
>> >
>> > > On Thu, Apr 19, 2012 at 10:08:47PM +0200, Marek Vasut wrote:
>> > > > Dear Gabriel Huau,
>> > > >
>> > > > > ---
>> > > > >

>> > > > > + /* some delay between MPLL and UPLL */
>> > > > > + pll_delay(500000);
>> > > >
>> > > > You use udelay() below, do you need pll_delay() at all?
>> > >
>> > > Yes, because initialisation of PLL is done before timer_init(), so we
>> > > can't use udelay().
>> >
>> > Maybe fix the timer driver?
>>
>> How fix timer driver if arch_cpu_init(void) call befor timer_init in
>> \arch\arm\lib\board.c:227 init_fnc_t *init_sequence[] = {
>
> Where did you get such a weird path? \arch\arm... ?
>
> btw you can always check some bit, if the timer is enabled, behave one way,
> otherwise, behave other way.

There is plenty of room in gd->flags - Pick a bit in the high-order 16-bits

It will be clear at startup and when you initialise the timer, you can set
the bit. udelay() can do a simple test on the bit and call the appropriate
function

Regards,

Graeme

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-19 22:22           ` Marek Vasut
@ 2012-04-20  7:19             ` Ilya Averyanov
  2012-04-20  9:11               ` Marek Vasut
  0 siblings, 1 reply; 42+ messages in thread
From: Ilya Averyanov @ 2012-04-20  7:19 UTC (permalink / raw)
  To: u-boot

2012/4/20 Marek Vasut <marex@denx.de>

> Dear Gabriel Huau,
>
> > On Thu, Apr 19, 2012 at 10:45:21PM +0200, Marek Vasut wrote:
> > > Dear Gabriel Huau,
> > >
> > > > On Thu, Apr 19, 2012 at 10:08:47PM +0200, Marek Vasut wrote:
> > > > > Dear Gabriel Huau,
> > > > >
> > > > > > ---
> > > > > >
> > > > > > Changes for v2:
> > > > > >       - Coding style cleanup
> > > > > >       - Remove unnecessary files modification
> > > > > >       - Remove unnecessary board configuration set
> > > > > >
> > > > > > Changes for v3:
> > > > > >       - Coding style cleanup
> > > > > >       - Move some macro definition from lowlevel_init.S
> > > > > >       to a new header
> > > > > >       - Remove some "magic bloat" with I/O board initialization
> > > > > >       - Add a pll_delay and replace loop by it
> > > > > >       - Somme cleanup in the configuration file
> > > > > >       - Cancel modifications on an SoC specific header
> > > > > >       - Add my name to copyright
> > > > > >
> > > > > > ---
> > > > > >
> > > > > >  board/friendlyarm/mini2440/Makefile        |   45 ++++++
> > > > > >  board/friendlyarm/mini2440/lowlevel_init.S |   76 ++++++++++
> > > > > >  board/friendlyarm/mini2440/mini2440.c      |  139
> > > > > >  ++++++++++++++++++ board/friendlyarm/mini2440/mini2440.h      |
> > > > > >  104 ++++++++++++++ boards.cfg                                 |
> > > > > >   1 +
> > > > > >  include/configs/mini2440.h                 |  215
> > > > > >
> > > > > > ++++++++++++++++++++++++++++ 6 files changed, 580 insertions(+)
> > > > > >
> > > > > >  create mode 100644 board/friendlyarm/mini2440/Makefile
> > > > > >  create mode 100644 board/friendlyarm/mini2440/lowlevel_init.S
> > > > > >  create mode 100644 board/friendlyarm/mini2440/mini2440.c
> > > > > >  create mode 100644 board/friendlyarm/mini2440/mini2440.h
> > > > > >  create mode 100644 include/configs/mini2440.h
> > > > > >
> > > > > > diff --git a/board/friendlyarm/mini2440/Makefile
> > > > > > b/board/friendlyarm/mini2440/Makefile new file mode 100644
> > > > > > index 0000000..e8d68cb
> > > > > > --- /dev/null
> > > > > > +++ b/board/friendlyarm/mini2440/Makefile
> > > > > > @@ -0,0 +1,45 @@
> > > > > > +#
> > > > > > +# (C) Copyright 2012
> > > > > > +# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
> > > > > > +#
> > > > > > +# See file CREDITS for list of people who contributed to this
> > > > > > +# project.
> > > > > > +#
> > > > > > +# This program is free software; you can redistribute it and/or
> > > > > > +# modify it under the terms of the GNU General Public License as
> > > > > > +# published by the Free Software Foundation; either version 2 of
> > > > > > +# the License, or (at your option) any later version.
> > > > > > +#
> > > > > > +# This program is distributed in the hope that it will be
> useful,
> > > > > > +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > > > > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > > > > +# GNU General Public License for more details.
> > > > > > +#
> > > > > > +# You should have received a copy of the GNU General Public
> > > > > > License +# along with this program; if not, write to the Free
> > > > > > Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> > > > > > +# MA 02111-1307 USA
> > > > > > +#
> > > > > > +
> > > > > > +include $(TOPDIR)/config.mk
> > > > > > +
> > > > > > +LIB  = $(obj)lib$(BOARD).o
> > > > > > +
> > > > > > +COBJS        := mini2440.o
> > > > > > +SOBJS        := lowlevel_init.o
> > > > > > +
> > > > > > +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c)
> > > > > > +OBJS := $(addprefix $(obj),$(COBJS))
> > > > > > +SOBJS        := $(addprefix $(obj),$(SOBJS))
> > > > > > +
> > > > > > +$(LIB):      $(obj).depend $(OBJS) $(SOBJS)
> > > > > > +     $(call cmd_link_o_target, $(OBJS) $(SOBJS))
> > > > > > +
> > > > > >
> +##################################################################
> > > > > > #### ### +
> > > > > > +# defines $(obj).depend target
> > > > > > +include $(SRCTREE)/rules.mk
> > > > > > +
> > > > > > +sinclude $(obj).depend
> > > > > > +
> > > > > >
> +##################################################################
> > > > > > #### ### diff --git a/board/friendlyarm/mini2440/lowlevel_init.S
> > > > > > b/board/friendlyarm/mini2440/lowlevel_init.S new file mode 100644
> > > > > > index 0000000..f69a08c
> > > > > > --- /dev/null
> > > > > > +++ b/board/friendlyarm/mini2440/lowlevel_init.S
> > > > > > @@ -0,0 +1,76 @@
> > > > > > +/*
> > > > > > + * Memory Setup stuff - taken from blob memsetup.S
> > > > > > + *
> > > > > > + * Copyright (C) 1999 2000 2001 Erik Mouw
> > > > > > (J.A.K.Mouw at its.tudelft.nl) and + *                     Jan-Derk
> > > > > > Bakker
> > > > > > (J.D.Bakker at its.tudelft.nl) + *
> > > > > > + * Modified for the Samsung SMDK2410 by
> > > > > > + * (C) Copyright 2002
> > > > > > + * David Mueller, ELSOFT AG, <d.mueller@elsoft.ch>
> > > > > > + *
> > > > > > + * (C) Copyright 2012
> > > > > > + * Gabriel Huau <contact@huau-gabriel.fr>
> > > > > > + *
> > > > > > + * See file CREDITS for list of people who contributed to this
> > > > > > + * project.
> > > > > > + *
> > > > > > + * This program is free software; you can redistribute it and/or
> > > > > > + * modify it under the terms of the GNU General Public License
> as
> > > > > > + * published by the Free Software Foundation; either version 2
> of
> > > > > > + * the License, or (at your option) any later version.
> > > > > > + *
> > > > > > + * This program is distributed in the hope that it will be
> useful,
> > > > > > + * but WITHOUT ANY WARRANTY; without even the implied warranty
> of
> > > > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > > > > + * GNU General Public License for more details.
> > > > > > + *
> > > > > > + * You should have received a copy of the GNU General Public
> > > > > > License + * along with this program; if not, write to the Free
> > > > > > Software + * Foundation, Inc., 59 Temple Place, Suite 330,
> Boston,
> > > > > > + * MA 02111-1307 USA
> > > > > > + */
> > > > > > +
> > > > > > +#include <config.h>
> > > > > > +#include <version.h>
> > > > > > +#include "mini2440.h"
> > > > > > +
> > > > > > +_TEXT_BASE:
> > > > > > +     .word   CONFIG_SYS_TEXT_BASE
> > > > > > +
> > > > > > +.globl lowlevel_init
> > > > > > +lowlevel_init:
> > > > > > +     /* memory control configuration */
> > > > > > +     /* make r0 relative the current location so that it */
> > > > > > +     /* reads SMRDATA out of FLASH rather than memory ! */
> > > > > > +     ldr     r0, =SMRDATA
> > > > > > +     ldr     r1, _TEXT_BASE
> > > > > > +     sub     r0, r0, r1
> > > > > > +     ldr     r1, =BWSCON     /* Bus Width Status Controller */
> > > > > > +     add     r2, r0, #13*4
> > > > > > +0:
> > > > > > +     ldr     r3, [r0], #4
> > > > > > +     str     r3, [r1], #4
> > > > > > +     cmp     r2, r0
> > > > > > +     bne     0b
> > > > > > +
> > > > > > +     /* everything is fine now */
> > > > > > +     mov     pc, lr
> > > > > > +
> > > > > > +     .ltorg
> > > > > > +/* the literal pools origin */
> > > > > > +
> > > > > > +SMRDATA:
> > > > > > +    .word
> > > > > >
> (0+(B1_BWSCON<<4)+(B2_BWSCON<<8)+(B3_BWSCON<<12)+(B4_BWSCON<<16)+(B
> > > > > > 5_BW SCO N<<20)+(B6_BWSCON<<24)+(B7_BWSCON<<28)) +    .word
> > > > > >
> ((B0_Tacs<<13)+(B0_Tcos<<11)+(B0_Tacc<<8)+(B0_Tcoh<<6)+(B0_Tah<<4)+
> > > > > > (B0_ Tac p<<2)+(B0_PMC)) +    .word
> > > > > >
> ((B1_Tacs<<13)+(B1_Tcos<<11)+(B1_Tacc<<8)+(B1_Tcoh<<6)+(B1_Tah<<4)+
> > > > > > (B1_ Tac p<<2)+(B1_PMC)) +    .word
> > > > > >
> ((B2_Tacs<<13)+(B2_Tcos<<11)+(B2_Tacc<<8)+(B2_Tcoh<<6)+(B2_Tah<<4)+
> > > > > > (B2_ Tac p<<2)+(B2_PMC)) +    .word
> > > > > >
> ((B3_Tacs<<13)+(B3_Tcos<<11)+(B3_Tacc<<8)+(B3_Tcoh<<6)+(B3_Tah<<4)+
> > > > > > (B3_ Tac p<<2)+(B3_PMC)) +    .word
> > > > > >
> ((B4_Tacs<<13)+(B4_Tcos<<11)+(B4_Tacc<<8)+(B4_Tcoh<<6)+(B4_Tah<<4)+
> > > > > > (B4_ Tac p<<2)+(B4_PMC)) +    .word
> > > > > >
> ((B5_Tacs<<13)+(B5_Tcos<<11)+(B5_Tacc<<8)+(B5_Tcoh<<6)+(B5_Tah<<4)+
> > > > > > (B5_ Tac p<<2)+(B5_PMC)) +
> > > > > > +    .word ((B6_MT<<15)+(B6_Trcd<<2)+(B6_SCAN))
> > > > > > +    .word ((B7_MT<<15)+(B7_Trcd<<2)+(B7_SCAN))
> > > > > > +    .word
> > > > > > ((REFEN<<23)+(TREFMD<<22)+(Trp<<20)+(Trc<<18)+(Tchr<<16)+REFCNT)
> +
> > > > > > .word 0x32
> > > > > > +    .word 0x30
> > > > > > +    .word 0x30
> > > > >
> > > > > What this undocumented stuff?
> > > >
> > > > SoC specific, I pasted it from smdk2410, it's for initialize the
> DRAM.
> > >
> > > Can't you init DRAM in some more fitting place? Also document this?
> >
> > I don't know, this part is a bit difficult for me, but I'm going to try
> > to document it with the help of the SoC documentation.
> >
> > For the place, should I move it to mini2440.c in arch_cpu_init() or
> > board_early_init_f() ? I don't really know the difference.
>
> dram_init() maybe ?
>
You propose to initialize the SDRAM controller in dram_init ()?

>
> >
> > > > > > diff --git a/board/friendlyarm/mini2440/mini2440.c
> > > > > > b/board/friendlyarm/mini2440/mini2440.c new file mode 100644
> > > > > > index 0000000..9ba8d39
> > > > > > --- /dev/null
> > > > > > +++ b/board/friendlyarm/mini2440/mini2440.c
> > > > > > @@ -0,0 +1,139 @@
> > > > > > +/*
> > > > > > + * (C) Copyright 2002
> > > > > > + * Sysgo Real-Time Solutions, GmbH <www.elinos.com>
> > > > > > + * Marius Groeger <mgroeger@sysgo.de>
> > > > > > + *
> > > > > > + * (C) Copyright 2002
> > > > > > + * David Mueller, ELSOFT AG, <d.mueller@elsoft.ch>
> > > > > > + *
> > > > > > + * (C) Copyright 2009
> > > > > > + * Michel Pollet <buserror@gmail.com>
> > > > > > + *
> > > > > > + * (C) Copyright 2012
> > > > > > + * Gabriel Huau <contact@huau-gabriel.fr>
> > > > > > + *
> > > > > > + * See file CREDITS for list of people who contributed to this
> > > > > > + * project.
> > > > > > + *
> > > > > > + * This program is free software; you can redistribute it and/or
> > > > > > + * modify it under the terms of the GNU General Public License
> as
> > > > > > + * published by the Free Software Foundation; either version 2
> of
> > > > > > + * the License, or (at your option) any later version.
> > > > > > + *
> > > > > > + * This program is distributed in the hope that it will be
> useful,
> > > > > > + * but WITHOUT ANY WARRANTY; without even the implied warranty
> of
> > > > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > > > > + * GNU General Public License for more details.
> > > > > > + *
> > > > > > + * You should have received a copy of the GNU General Public
> > > > > > License + * along with this program; if not, write to the Free
> > > > > > Software + * Foundation, Inc., 59 Temple Place, Suite 330,
> Boston,
> > > > > > + * MA 02111-1307 USA
> > > > > > + */
> > > > > > +
> > > > > > +#include <common.h>
> > > > > > +#include <asm/arch/s3c2440.h>
> > > > > > +#include <asm/io.h>
> > > > > > +#include <video_fb.h>
> > > > > > +#include "mini2440.h"
> > > > > > +
> > > > > > +#ifdef CONFIG_DRIVER_DM9000
> > > > > > +#include <netdev.h>
> > > > > > +#endif
> > > > > > +
> > > > > > +DECLARE_GLOBAL_DATA_PTR;
> > > > > > +
> > > > > > +static inline void pll_delay(unsigned long loops)
> > > > > > +{
> > > > > > +     __asm__ volatile ("1:\n"
> > > > > > +       "subs %0, %1, #1\n"
> > > > > > +       "bne 1b" : "=r" (loops) : "0" (loops));
> > > > > > +}
> > > > > > +
> > > > > > +int arch_cpu_init(void)
> > > > > > +{
> > > > > > +     struct s3c24x0_clock_power * const clk_power =
> > > > > > +
> s3c24x0_get_base_clock_power();
> > > > > > +
> > > > > > +     /* to reduce PLL lock time, adjust the LOCKTIME register */
> > > > > > +     clk_power->locktime = 0xFFFFFF;
> > > > > > +     clk_power->clkdivn = CLKDIVN_VAL;
> > > > > > +
> > > > > > +     /* configure UPLL */
> > > > > > +     clk_power->upllcon = ((U_M_MDIV << 12) + (U_M_PDIV << 4) +
> > > > > > U_M_SDIV); +  /* some delay between MPLL and UPLL */
> > > > > > +     pll_delay(100000);
> > > > > > +
> > > > > > +     /* configure MPLL */
> > > > > > +     clk_power->mpllcon = ((M_MDIV << 12) + (M_PDIV << 4) +
> M_SDIV);
> > > > > > +
> > > > > > +     /* some delay between MPLL and UPLL */
> > > > > > +     pll_delay(500000);
> > > > >
> > > > > You use udelay() below, do you need pll_delay() at all?
> > > >
> > > > Yes, because initialisation of PLL is done before timer_init(), so we
> > > > can't use udelay().
> > >
> > > Maybe fix the timer driver?
> >
> > As PLL initialization is SoC specific, should I move it to
> > arch/arch/cpu/arm920t/s3c24x0/timer.c in timer_init() ?
>
> Yes
>
> > With this modification, I will have to patch all board based
> > on s3c24x0, because they are all using this "hack". Should this
> > modification be part of another patch ? (for me, yes ...)
>
> Yes
>
> ...
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-20  7:19             ` Ilya Averyanov
@ 2012-04-20  9:11               ` Marek Vasut
  2012-04-20 13:35                 ` Ilya Averyanov
  0 siblings, 1 reply; 42+ messages in thread
From: Marek Vasut @ 2012-04-20  9:11 UTC (permalink / raw)
  To: u-boot

Dear Ilya Averyanov,

[...]

> > > > > > > .word 0x32
> > > > > > > +    .word 0x30
> > > > > > > +    .word 0x30
> > > > > > 
> > > > > > What this undocumented stuff?
> > > > > 
> > > > > SoC specific, I pasted it from smdk2410, it's for initialize the
> > 
> > DRAM.
> > 
> > > > Can't you init DRAM in some more fitting place? Also document this?
> > > 
> > > I don't know, this part is a bit difficult for me, but I'm going to try
> > > to document it with the help of the SoC documentation.
> > > 
> > > For the place, should I move it to mini2440.c in arch_cpu_init() or
> > > board_early_init_f() ? I don't really know the difference.
> > 
> > dram_init() maybe ?
> 
> You propose to initialize the SDRAM controller in dram_init ()?

Well yes, ain't it more fitting ?

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-20  9:11               ` Marek Vasut
@ 2012-04-20 13:35                 ` Ilya Averyanov
  2012-04-20 14:08                   ` Marek Vasut
  0 siblings, 1 reply; 42+ messages in thread
From: Ilya Averyanov @ 2012-04-20 13:35 UTC (permalink / raw)
  To: u-boot

2012/4/20 Marek Vasut <marex@denx.de>

> Dear Ilya Averyanov,
>
> [...]
>
> > > > > > > > .word 0x32
> > > > > > > > +    .word 0x30
> > > > > > > > +    .word 0x30
> > > > > > >
> > > > > > > What this undocumented stuff?
> > > > > >
> > > > > > SoC specific, I pasted it from smdk2410, it's for initialize the
> > >
> > > DRAM.
> > >
> > > > > Can't you init DRAM in some more fitting place? Also document this?
> > > >
> > > > I don't know, this part is a bit difficult for me, but I'm going to
> try
> > > > to document it with the help of the SoC documentation.
> > > >
> > > > For the place, should I move it to mini2440.c in arch_cpu_init() or
> > > > board_early_init_f() ? I don't really know the difference.
> > >
> > > dram_init() maybe ?
> >
> > You propose to initialize the SDRAM controller in dram_init ()?
>
> Well yes, ain't it more fitting ?
>
> Best regards,
> Marek Vasut
>
No. We have to two reasons why this is not the case.
1) Open u-boot/arch/arm/cpu/arm920t/start.S:328
cpu_init_crit
......
line 346
    /*
     * before relocating, we have to setup RAM timing
     * because memory timing is board-dependend, you will
     * find a lowlevel_init.S in your board directory.
     */
2) NAND controller must be initialized before C code run.

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-20 13:35                 ` Ilya Averyanov
@ 2012-04-20 14:08                   ` Marek Vasut
  2012-04-20 14:30                     ` Ilya Averyanov
  0 siblings, 1 reply; 42+ messages in thread
From: Marek Vasut @ 2012-04-20 14:08 UTC (permalink / raw)
  To: u-boot

Dear Ilya Averyanov,

> 2012/4/20 Marek Vasut <marex@denx.de>
> 
> > Dear Ilya Averyanov,
> > 
> > [...]
> > 
> > > > > > > > > .word 0x32
> > > > > > > > > +    .word 0x30
> > > > > > > > > +    .word 0x30
> > > > > > > > 
> > > > > > > > What this undocumented stuff?
> > > > > > > 
> > > > > > > SoC specific, I pasted it from smdk2410, it's for initialize
> > > > > > > the
> > > > 
> > > > DRAM.
> > > > 
> > > > > > Can't you init DRAM in some more fitting place? Also document
> > > > > > this?
> > > > > 
> > > > > I don't know, this part is a bit difficult for me, but I'm going to
> > 
> > try
> > 
> > > > > to document it with the help of the SoC documentation.
> > > > > 
> > > > > For the place, should I move it to mini2440.c in arch_cpu_init() or
> > > > > board_early_init_f() ? I don't really know the difference.
> > > > 
> > > > dram_init() maybe ?
> > > 
> > > You propose to initialize the SDRAM controller in dram_init ()?
> > 
> > Well yes, ain't it more fitting ?
> > 
> > Best regards,
> > Marek Vasut
> 
> No. We have to two reasons why this is not the case.
> 1) Open u-boot/arch/arm/cpu/arm920t/start.S:328
> cpu_init_crit
> ......
> line 346
>     /*
>      * before relocating, we have to setup RAM timing
>      * because memory timing is board-dependend, you will
>      * find a lowlevel_init.S in your board directory.
>      */

Well don't setup run in lowlevel_init.S then ?

> 2) NAND controller must be initialized before C code run.

Why?

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-20 14:08                   ` Marek Vasut
@ 2012-04-20 14:30                     ` Ilya Averyanov
  2012-04-20 14:35                       ` Ilya Averyanov
  2012-04-20 16:16                       ` Marek Vasut
  0 siblings, 2 replies; 42+ messages in thread
From: Ilya Averyanov @ 2012-04-20 14:30 UTC (permalink / raw)
  To: u-boot

2012/4/20 Marek Vasut <marex@denx.de>

> Dear Ilya Averyanov,
>
> > 2012/4/20 Marek Vasut <marex@denx.de>
> >
> > > Dear Ilya Averyanov,
> > >
> > > [...]
> > >
> > > > > > > > > > .word 0x32
> > > > > > > > > > +    .word 0x30
> > > > > > > > > > +    .word 0x30
> > > > > > > > >
> > > > > > > > > What this undocumented stuff?
> > > > > > > >
> > > > > > > > SoC specific, I pasted it from smdk2410, it's for initialize
> > > > > > > > the
> > > > >
> > > > > DRAM.
> > > > >
> > > > > > > Can't you init DRAM in some more fitting place? Also document
> > > > > > > this?
> > > > > >
> > > > > > I don't know, this part is a bit difficult for me, but I'm going
> to
> > >
> > > try
> > >
> > > > > > to document it with the help of the SoC documentation.
> > > > > >
> > > > > > For the place, should I move it to mini2440.c in arch_cpu_init()
> or
> > > > > > board_early_init_f() ? I don't really know the difference.
> > > > >
> > > > > dram_init() maybe ?
> > > >
> > > > You propose to initialize the SDRAM controller in dram_init ()?
> > >
> > > Well yes, ain't it more fitting ?
> > >
> > > Best regards,
> > > Marek Vasut
> >
> > No. We have to two reasons why this is not the case.
> > 1) Open u-boot/arch/arm/cpu/arm920t/start.S:328
> > cpu_init_crit
> > ......
> > line 346
> >     /*
> >      * before relocating, we have to setup RAM timing
> >      * because memory timing is board-dependend, you will
> >      * find a lowlevel_init.S in your board directory.
> >      */
>
> Well don't setup run in lowlevel_init.S then ?
>
> > 2) NAND controller must be initialized before C code run.
>
> Why?
>
> Best regards,
> Marek Vasut
>
mmm...
Because we need a stack.
The stack is in RAM.

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-20 14:30                     ` Ilya Averyanov
@ 2012-04-20 14:35                       ` Ilya Averyanov
  2012-04-20 16:17                         ` Marek Vasut
  2012-04-20 16:16                       ` Marek Vasut
  1 sibling, 1 reply; 42+ messages in thread
From: Ilya Averyanov @ 2012-04-20 14:35 UTC (permalink / raw)
  To: u-boot

2012/4/20 Ilya Averyanov <averyanovin+uboot@gmail.com>

>
>
> 2012/4/20 Marek Vasut <marex@denx.de>
>
>> Dear Ilya Averyanov,
>>
>> > 2012/4/20 Marek Vasut <marex@denx.de>
>> >
>> > > Dear Ilya Averyanov,
>> > >
>> > > [...]
>> > >
>> > > > > > > > > > .word 0x32
>> > > > > > > > > > +    .word 0x30
>> > > > > > > > > > +    .word 0x30
>> > > > > > > > >
>> > > > > > > > > What this undocumented stuff?
>> > > > > > > >
>> > > > > > > > SoC specific, I pasted it from smdk2410, it's for initialize
>> > > > > > > > the
>> > > > >
>> > > > > DRAM.
>> > > > >
>> > > > > > > Can't you init DRAM in some more fitting place? Also document
>> > > > > > > this?
>> > > > > >
>> > > > > > I don't know, this part is a bit difficult for me, but I'm
>> going to
>> > >
>> > > try
>> > >
>> > > > > > to document it with the help of the SoC documentation.
>> > > > > >
>> > > > > > For the place, should I move it to mini2440.c in
>> arch_cpu_init() or
>> > > > > > board_early_init_f() ? I don't really know the difference.
>> > > > >
>> > > > > dram_init() maybe ?
>> > > >
>> > > > You propose to initialize the SDRAM controller in dram_init ()?
>> > >
>> > > Well yes, ain't it more fitting ?
>> > >
>> > > Best regards,
>> > > Marek Vasut
>> >
>> > No. We have to two reasons why this is not the case.
>> > 1) Open u-boot/arch/arm/cpu/arm920t/start.S:328
>> > cpu_init_crit
>> > ......
>> > line 346
>> >     /*
>> >      * before relocating, we have to setup RAM timing
>> >      * because memory timing is board-dependend, you will
>> >      * find a lowlevel_init.S in your board directory.
>> >      */
>>
>> Well don't setup run in lowlevel_init.S then ?
>>
>> > 2) NAND controller must be initialized before C code run.
>>
>> Why?
>>
>> Best regards,
>> Marek Vasut
>>
> mmm...
> Because we need a stack.
> The stack is in RAM.
>
>2) NAND controller must be initialized before C code run.
Sorry made ??a mistake. SDRAM! Not NAND!

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-20 14:30                     ` Ilya Averyanov
  2012-04-20 14:35                       ` Ilya Averyanov
@ 2012-04-20 16:16                       ` Marek Vasut
  1 sibling, 0 replies; 42+ messages in thread
From: Marek Vasut @ 2012-04-20 16:16 UTC (permalink / raw)
  To: u-boot

Dear Ilya Averyanov,

> 2012/4/20 Marek Vasut <marex@denx.de>
> 
> > Dear Ilya Averyanov,
> > 
> > > 2012/4/20 Marek Vasut <marex@denx.de>
> > > 
> > > > Dear Ilya Averyanov,
> > > > 
> > > > [...]
> > > > 
> > > > > > > > > > > .word 0x32
> > > > > > > > > > > +    .word 0x30
> > > > > > > > > > > +    .word 0x30
> > > > > > > > > > 
> > > > > > > > > > What this undocumented stuff?
> > > > > > > > > 
> > > > > > > > > SoC specific, I pasted it from smdk2410, it's for
> > > > > > > > > initialize the
> > > > > > 
> > > > > > DRAM.
> > > > > > 
> > > > > > > > Can't you init DRAM in some more fitting place? Also document
> > > > > > > > this?
> > > > > > > 
> > > > > > > I don't know, this part is a bit difficult for me, but I'm
> > > > > > > going
> > 
> > to
> > 
> > > > try
> > > > 
> > > > > > > to document it with the help of the SoC documentation.
> > > > > > > 
> > > > > > > For the place, should I move it to mini2440.c in
> > > > > > > arch_cpu_init()
> > 
> > or
> > 
> > > > > > > board_early_init_f() ? I don't really know the difference.
> > > > > > 
> > > > > > dram_init() maybe ?
> > > > > 
> > > > > You propose to initialize the SDRAM controller in dram_init ()?
> > > > 
> > > > Well yes, ain't it more fitting ?
> > > > 
> > > > Best regards,
> > > > Marek Vasut
> > > 
> > > No. We have to two reasons why this is not the case.
> > > 1) Open u-boot/arch/arm/cpu/arm920t/start.S:328
> > > cpu_init_crit
> > > ......
> > > line 346
> > > 
> > >     /*
> > >     
> > >      * before relocating, we have to setup RAM timing
> > >      * because memory timing is board-dependend, you will
> > >      * find a lowlevel_init.S in your board directory.
> > >      */
> > 
> > Well don't setup run in lowlevel_init.S then ?
> > 
> > > 2) NAND controller must be initialized before C code run.
> > 
> > Why?
> > 
> > Best regards,
> > Marek Vasut
> 
> mmm...
> Because we need a stack.
> The stack is in RAM.

mmm...
You can lock cache entries to create space for stack in cache. That's how it's 
done on PXA, check it.

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-20 14:35                       ` Ilya Averyanov
@ 2012-04-20 16:17                         ` Marek Vasut
  2012-04-20 17:17                           ` Ilya Averyanov
  2012-04-20 19:18                           ` Vasily Khoruzhick
  0 siblings, 2 replies; 42+ messages in thread
From: Marek Vasut @ 2012-04-20 16:17 UTC (permalink / raw)
  To: u-boot

Dear Ilya Averyanov,

> 2012/4/20 Ilya Averyanov <averyanovin+uboot@gmail.com>
> 
> > 2012/4/20 Marek Vasut <marex@denx.de>
> > 
> >> Dear Ilya Averyanov,
> >> 
> >> > 2012/4/20 Marek Vasut <marex@denx.de>
> >> > 
> >> > > Dear Ilya Averyanov,
> >> > > 
> >> > > [...]
> >> > > 
> >> > > > > > > > > > .word 0x32
> >> > > > > > > > > > +    .word 0x30
> >> > > > > > > > > > +    .word 0x30
> >> > > > > > > > > 
> >> > > > > > > > > What this undocumented stuff?
> >> > > > > > > > 
> >> > > > > > > > SoC specific, I pasted it from smdk2410, it's for
> >> > > > > > > > initialize the
> >> > > > > 
> >> > > > > DRAM.
> >> > > > > 
> >> > > > > > > Can't you init DRAM in some more fitting place? Also
> >> > > > > > > document this?
> >> > > > > > 
> >> > > > > > I don't know, this part is a bit difficult for me, but I'm
> >> 
> >> going to
> >> 
> >> > > try
> >> > > 
> >> > > > > > to document it with the help of the SoC documentation.
> >> > > > > > 
> >> > > > > > For the place, should I move it to mini2440.c in
> >> 
> >> arch_cpu_init() or
> >> 
> >> > > > > > board_early_init_f() ? I don't really know the difference.
> >> > > > > 
> >> > > > > dram_init() maybe ?
> >> > > > 
> >> > > > You propose to initialize the SDRAM controller in dram_init ()?
> >> > > 
> >> > > Well yes, ain't it more fitting ?
> >> > > 
> >> > > Best regards,
> >> > > Marek Vasut
> >> > 
> >> > No. We have to two reasons why this is not the case.
> >> > 1) Open u-boot/arch/arm/cpu/arm920t/start.S:328
> >> > cpu_init_crit
> >> > ......
> >> > line 346
> >> > 
> >> >     /*
> >> >     
> >> >      * before relocating, we have to setup RAM timing
> >> >      * because memory timing is board-dependend, you will
> >> >      * find a lowlevel_init.S in your board directory.
> >> >      */
> >> 
> >> Well don't setup run in lowlevel_init.S then ?
> >> 
> >> > 2) NAND controller must be initialized before C code run.
> >> 
> >> Why?
> >> 
> >> Best regards,
> >> Marek Vasut
> > 
> > mmm...
> > Because we need a stack.
> > The stack is in RAM.
> >
> >2) NAND controller must be initialized before C code run.
> 
> Sorry made ??a mistake. SDRAM! Not NAND!

Which doesn't matter, either way you need stack ... and you can have the stack 
in cache ;-)

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-20 16:17                         ` Marek Vasut
@ 2012-04-20 17:17                           ` Ilya Averyanov
  2012-04-20 19:11                             ` Marek Vasut
  2012-04-23 20:36                             ` Wolfgang Denk
  2012-04-20 19:18                           ` Vasily Khoruzhick
  1 sibling, 2 replies; 42+ messages in thread
From: Ilya Averyanov @ 2012-04-20 17:17 UTC (permalink / raw)
  To: u-boot

2012/4/20 Marek Vasut <marex@denx.de>

> Dear Ilya Averyanov,
>
> > 2012/4/20 Ilya Averyanov <averyanovin+uboot@gmail.com>
> >
> > > 2012/4/20 Marek Vasut <marex@denx.de>
> > >
> > >> Dear Ilya Averyanov,
> > >>
> > >> > 2012/4/20 Marek Vasut <marex@denx.de>
> > >> >
> > >> > > Dear Ilya Averyanov,
> > >> > >
> > >> > > [...]
> > >> > >
> > >> > > > > > > > > > .word 0x32
> > >> > > > > > > > > > +    .word 0x30
> > >> > > > > > > > > > +    .word 0x30
> > >> > > > > > > > >
> > >> > > > > > > > > What this undocumented stuff?
> > >> > > > > > > >
> > >> > > > > > > > SoC specific, I pasted it from smdk2410, it's for
> > >> > > > > > > > initialize the
> > >> > > > >
> > >> > > > > DRAM.
> > >> > > > >
> > >> > > > > > > Can't you init DRAM in some more fitting place? Also
> > >> > > > > > > document this?
> > >> > > > > >
> > >> > > > > > I don't know, this part is a bit difficult for me, but I'm
> > >>
> > >> going to
> > >>
> > >> > > try
> > >> > >
> > >> > > > > > to document it with the help of the SoC documentation.
> > >> > > > > >
> > >> > > > > > For the place, should I move it to mini2440.c in
> > >>
> > >> arch_cpu_init() or
> > >>
> > >> > > > > > board_early_init_f() ? I don't really know the difference.
> > >> > > > >
> > >> > > > > dram_init() maybe ?
> > >> > > >
> > >> > > > You propose to initialize the SDRAM controller in dram_init ()?
> > >> > >
> > >> > > Well yes, ain't it more fitting ?
> > >> > >
> > >> > > Best regards,
> > >> > > Marek Vasut
> > >> >
> > >> > No. We have to two reasons why this is not the case.
> > >> > 1) Open u-boot/arch/arm/cpu/arm920t/start.S:328
> > >> > cpu_init_crit
> > >> > ......
> > >> > line 346
> > >> >
> > >> >     /*
> > >> >
> > >> >      * before relocating, we have to setup RAM timing
> > >> >      * because memory timing is board-dependend, you will
> > >> >      * find a lowlevel_init.S in your board directory.
> > >> >      */
> > >>
> > >> Well don't setup run in lowlevel_init.S then ?
> > >>
> > >> > 2) NAND controller must be initialized before C code run.
> > >>
> > >> Why?
> > >>
> > >> Best regards,
> > >> Marek Vasut
> > >
> > > mmm...
> > > Because we need a stack.
> > > The stack is in RAM.
> > >
> > >2) NAND controller must be initialized before C code run.
> >
> > Sorry made a mistake. SDRAM! Not NAND!
>
> Which doesn't matter, either way you need stack ... and you can have the
> stack
> in cache ;-)
>
> Best regards,
> Marek Vasut
>
Why do you insist on sdram initialization code in C?
If you simply do as done in the other boards on this architecture?

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-20 17:17                           ` Ilya Averyanov
@ 2012-04-20 19:11                             ` Marek Vasut
  2012-04-23 20:36                             ` Wolfgang Denk
  1 sibling, 0 replies; 42+ messages in thread
From: Marek Vasut @ 2012-04-20 19:11 UTC (permalink / raw)
  To: u-boot

Dear Ilya Averyanov,

> 2012/4/20 Marek Vasut <marex@denx.de>
> 
> > Dear Ilya Averyanov,
> > 
> > > 2012/4/20 Ilya Averyanov <averyanovin+uboot@gmail.com>
> > > 
> > > > 2012/4/20 Marek Vasut <marex@denx.de>
> > > > 
> > > >> Dear Ilya Averyanov,
> > > >> 
> > > >> > 2012/4/20 Marek Vasut <marex@denx.de>
> > > >> > 
> > > >> > > Dear Ilya Averyanov,
> > > >> > > 
> > > >> > > [...]
> > > >> > > 
> > > >> > > > > > > > > > .word 0x32
> > > >> > > > > > > > > > +    .word 0x30
> > > >> > > > > > > > > > +    .word 0x30
> > > >> > > > > > > > > 
> > > >> > > > > > > > > What this undocumented stuff?
> > > >> > > > > > > > 
> > > >> > > > > > > > SoC specific, I pasted it from smdk2410, it's for
> > > >> > > > > > > > initialize the
> > > >> > > > > 
> > > >> > > > > DRAM.
> > > >> > > > > 
> > > >> > > > > > > Can't you init DRAM in some more fitting place? Also
> > > >> > > > > > > document this?
> > > >> > > > > > 
> > > >> > > > > > I don't know, this part is a bit difficult for me, but I'm
> > > >> 
> > > >> going to
> > > >> 
> > > >> > > try
> > > >> > > 
> > > >> > > > > > to document it with the help of the SoC documentation.
> > > >> > > > > > 
> > > >> > > > > > For the place, should I move it to mini2440.c in
> > > >> 
> > > >> arch_cpu_init() or
> > > >> 
> > > >> > > > > > board_early_init_f() ? I don't really know the difference.
> > > >> > > > > 
> > > >> > > > > dram_init() maybe ?
> > > >> > > > 
> > > >> > > > You propose to initialize the SDRAM controller in dram_init
> > > >> > > > ()?
> > > >> > > 
> > > >> > > Well yes, ain't it more fitting ?
> > > >> > > 
> > > >> > > Best regards,
> > > >> > > Marek Vasut
> > > >> > 
> > > >> > No. We have to two reasons why this is not the case.
> > > >> > 1) Open u-boot/arch/arm/cpu/arm920t/start.S:328
> > > >> > cpu_init_crit
> > > >> > ......
> > > >> > line 346
> > > >> > 
> > > >> >     /*
> > > >> >     
> > > >> >      * before relocating, we have to setup RAM timing
> > > >> >      * because memory timing is board-dependend, you will
> > > >> >      * find a lowlevel_init.S in your board directory.
> > > >> >      */
> > > >> 
> > > >> Well don't setup run in lowlevel_init.S then ?
> > > >> 
> > > >> > 2) NAND controller must be initialized before C code run.
> > > >> 
> > > >> Why?
> > > >> 
> > > >> Best regards,
> > > >> Marek Vasut
> > > > 
> > > > mmm...
> > > > Because we need a stack.
> > > > The stack is in RAM.
> > > >
> > > >2) NAND controller must be initialized before C code run.
> > > 
> > > Sorry made a mistake. SDRAM! Not NAND!
> > 
> > Which doesn't matter, either way you need stack ... and you can have the
> > stack
> > in cache ;-)
> > 
> > Best regards,
> > Marek Vasut
> 
> Why do you insist on sdram initialization code in C?

That's how the init sequence was designed.

> If you simply do as done in the other boards on this architecture?

Other boards on arm architecture do init DRAM in proper place.

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-20 16:17                         ` Marek Vasut
  2012-04-20 17:17                           ` Ilya Averyanov
@ 2012-04-20 19:18                           ` Vasily Khoruzhick
  2012-04-20 20:03                             ` Marek Vasut
  2012-04-23 20:39                             ` Wolfgang Denk
  1 sibling, 2 replies; 42+ messages in thread
From: Vasily Khoruzhick @ 2012-04-20 19:18 UTC (permalink / raw)
  To: u-boot

2012/4/20 Marek Vasut <marex@denx.de>:

> Which doesn't matter, either way you need stack ... and you can have the stack
> in cache ;-)

s3c24xx has 4kb of SRAM (steppingstone), you can use it for stack

Btw, using cache for stack looks like awful hack to me.

Regards
Vasily

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-20 19:18                           ` Vasily Khoruzhick
@ 2012-04-20 20:03                             ` Marek Vasut
  2012-04-20 22:51                               ` Ilya Averyanov
  2012-04-23 20:39                             ` Wolfgang Denk
  1 sibling, 1 reply; 42+ messages in thread
From: Marek Vasut @ 2012-04-20 20:03 UTC (permalink / raw)
  To: u-boot

Dear Vasily Khoruzhick,

> 2012/4/20 Marek Vasut <marex@denx.de>:
> > Which doesn't matter, either way you need stack ... and you can have the
> > stack in cache ;-)
> 
> s3c24xx has 4kb of SRAM (steppingstone), you can use it for stack

Oh, I didn't know that ... so there's no longer any problem.

> Btw, using cache for stack looks like awful hack to me.

It's fairy normal.

> Regards
> Vasily

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-20 20:03                             ` Marek Vasut
@ 2012-04-20 22:51                               ` Ilya Averyanov
  2012-04-20 23:07                                 ` Marek Vasut
                                                   ` (2 more replies)
  0 siblings, 3 replies; 42+ messages in thread
From: Ilya Averyanov @ 2012-04-20 22:51 UTC (permalink / raw)
  To: u-boot

2012/4/21 Marek Vasut <marex@denx.de>

> Dear Vasily Khoruzhick,
>
> > 2012/4/20 Marek Vasut <marex@denx.de>:
> > > Which doesn't matter, either way you need stack ... and you can have
> the
> > > stack in cache ;-)
> >
> > s3c24xx has 4kb of SRAM (steppingstone), you can use it for stack
>
> Oh, I didn't know that ... so there's no longer any problem.
>
No have problem.
Available only if you boot from NOR flash.
If you boot from the NAND 4kb of SRAM (steppingstone) not available.

>
> > Btw, using cache for stack looks like awful hack to me.
>
> It's fairy normal.
>
 I agree with Vasily Khoruzhick, it looks like a hack

>
> > Regards
> > Vasily
>
> Best regards,
> Marek Vasut
>

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-20 22:51                               ` Ilya Averyanov
@ 2012-04-20 23:07                                 ` Marek Vasut
  2012-04-21  7:35                                   ` Vasily Khoruzhick
  2012-04-20 23:30                                 ` [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440) Gabriel Huau
  2012-04-21  7:42                                 ` [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440 Vasily Khoruzhick
  2 siblings, 1 reply; 42+ messages in thread
From: Marek Vasut @ 2012-04-20 23:07 UTC (permalink / raw)
  To: u-boot

Dear Ilya Averyanov,

> 2012/4/21 Marek Vasut <marex@denx.de>
> 
> > Dear Vasily Khoruzhick,
> > 
> > > 2012/4/20 Marek Vasut <marex@denx.de>:
> > > > Which doesn't matter, either way you need stack ... and you can have
> > 
> > the
> > 
> > > > stack in cache ;-)
> > > 
> > > s3c24xx has 4kb of SRAM (steppingstone), you can use it for stack
> > 
> > Oh, I didn't know that ... so there's no longer any problem.
> 
> No have problem.
> Available only if you boot from NOR flash.
> If you boot from the NAND 4kb of SRAM (steppingstone) not available.

So you'll have to lock cache lines then. If you dig in the ML archive, you'll 
find a lot of discussion on this memory matter, esp. /wrt relocation support.

> > > Btw, using cache for stack looks like awful hack to me.
> > 
> > It's fairy normal.
> 
>  I agree with Vasily Khoruzhick, it looks like a hack

Please, bother to read the CPU manual and also the ARM Architecture reference 
manual before you start with such a wild accusations.

> 
> > > Regards
> > > Vasily
> > 
> > Best regards,
> > Marek Vasut

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440)
  2012-04-20 22:51                               ` Ilya Averyanov
  2012-04-20 23:07                                 ` Marek Vasut
@ 2012-04-20 23:30                                 ` Gabriel Huau
  2012-04-21  4:09                                   ` Ilya Averyanov
  2012-04-21  9:00                                   ` Vasily Khoruzhick
  2012-04-21  7:42                                 ` [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440 Vasily Khoruzhick
  2 siblings, 2 replies; 42+ messages in thread
From: Gabriel Huau @ 2012-04-20 23:30 UTC (permalink / raw)
  To: u-boot

On Sat, Apr 21, 2012 at 02:51:46AM +0400, Ilya Averyanov wrote:
> 2012/4/21 Marek Vasut <marex@denx.de>
> 
> > Dear Vasily Khoruzhick,
> >
> > > 2012/4/20 Marek Vasut <marex@denx.de>:
> > > > Which doesn't matter, either way you need stack ... and you can have
> > the
> > > > stack in cache ;-)
> > >
> > > s3c24xx has 4kb of SRAM (steppingstone), you can use it for stack
> >
> > Oh, I didn't know that ... so there's no longer any problem.
> >
> No have problem.
> Available only if you boot from NOR flash.
> If you boot from the NAND 4kb of SRAM (steppingstone) not available.
> 

SteppingStone is available ONLY in NAND boot :) and not available in
NOR boot.

> >
> > > Btw, using cache for stack looks like awful hack to me.
> >
> > It's fairy normal.
> >
>  I agree with Vasily Khoruzhick, it looks like a hack
> 
> >
> > > Regards
> > > Vasily
> >
> > Best regards,
> > Marek Vasut
> >

> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440)
  2012-04-20 23:30                                 ` [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440) Gabriel Huau
@ 2012-04-21  4:09                                   ` Ilya Averyanov
  2012-04-21  9:00                                   ` Vasily Khoruzhick
  1 sibling, 0 replies; 42+ messages in thread
From: Ilya Averyanov @ 2012-04-21  4:09 UTC (permalink / raw)
  To: u-boot

2012/4/21 Gabriel Huau <contact@huau-gabriel.fr>

> On Sat, Apr 21, 2012 at 02:51:46AM +0400, Ilya Averyanov wrote:
> > 2012/4/21 Marek Vasut <marex@denx.de>
> >
> > > Dear Vasily Khoruzhick,
> > >
> > > > 2012/4/20 Marek Vasut <marex@denx.de>:
> > > > > Which doesn't matter, either way you need stack ... and you can
> have
> > > the
> > > > > stack in cache ;-)
> > > >
> > > > s3c24xx has 4kb of SRAM (steppingstone), you can use it for stack
> > >
> > > Oh, I didn't know that ... so there's no longer any problem.
> > >
> > No have problem.
> > Available only if you boot from NOR flash.
> > If you boot from the NAND 4kb of SRAM (steppingstone) not available.
> >
>
> SteppingStone is available ONLY in NAND boot :) and not available in
> NOR boot.
>
> I meant is available as an internal RAM.

> > >
> > > > Btw, using cache for stack looks like awful hack to me.
> > >
> > > It's fairy normal.
> > >
> >  I agree with Vasily Khoruzhick, it looks like a hack
> >
> > >
> > > > Regards
> > > > Vasily
> > >
> > > Best regards,
> > > Marek Vasut
> > >
>
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot at lists.denx.de
> > http://lists.denx.de/mailman/listinfo/u-boot
>
>

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-20 23:07                                 ` Marek Vasut
@ 2012-04-21  7:35                                   ` Vasily Khoruzhick
  2012-04-23 20:43                                     ` Wolfgang Denk
  0 siblings, 1 reply; 42+ messages in thread
From: Vasily Khoruzhick @ 2012-04-21  7:35 UTC (permalink / raw)
  To: u-boot

2012/4/21 Marek Vasut <marex@denx.de>:

>> ?I agree with Vasily Khoruzhick, it looks like a hack
>
> Please, bother to read the CPU manual and also the ARM Architecture reference
> manual before you start with such a wild accusations.

Let me explain my point of view.

Doing SDRAM init very early (even in assembly code) is obvious and simple.
Just few simple writes into RAM controller registers.

But to use cache as RAM you need to program and enable MMU (again
assembly, right?). And then
one needs to program SDRAM controller (ok, this part is in C code, but
I don't see any advantage).
It's not as simple as previous solution, isn't it? And looks
overengineered to me. I prefer to keep
such low-level things simple.

Regards
Vasily

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-20 22:51                               ` Ilya Averyanov
  2012-04-20 23:07                                 ` Marek Vasut
  2012-04-20 23:30                                 ` [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440) Gabriel Huau
@ 2012-04-21  7:42                                 ` Vasily Khoruzhick
  2012-04-21 10:39                                   ` Marek Vasut
  2012-04-21 12:33                                   ` Ilya Averyanov
  2 siblings, 2 replies; 42+ messages in thread
From: Vasily Khoruzhick @ 2012-04-21  7:42 UTC (permalink / raw)
  To: u-boot

2012/4/21 Ilya Averyanov <averyanovin+uboot@gmail.com>:
>
> No have problem.
> Available only if you boot from NOR flash.
> If you boot from the NAND 4kb of SRAM (steppingstone) not available.

For NAND boot it's mapped at 0x0
For NOR boot it's mapped at 0x40000000

NAND controller uses it for booting purpose, but anyway for SPL we
should fit code into
4k (hardware limitation), so I think using assembly here for SDRAM init is OK.

Regards
Vasily

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440)
  2012-04-20 23:30                                 ` [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440) Gabriel Huau
  2012-04-21  4:09                                   ` Ilya Averyanov
@ 2012-04-21  9:00                                   ` Vasily Khoruzhick
  1 sibling, 0 replies; 42+ messages in thread
From: Vasily Khoruzhick @ 2012-04-21  9:00 UTC (permalink / raw)
  To: u-boot

2012/4/21 Gabriel Huau <contact@huau-gabriel.fr>:
> SteppingStone is available ONLY in NAND boot :) and not available in
> NOR boot.

It's available at 0x40000000 for NOR boot. Check datasheet ;)

Regards
Vasily

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-21  7:42                                 ` [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440 Vasily Khoruzhick
@ 2012-04-21 10:39                                   ` Marek Vasut
  2012-04-21 12:33                                   ` Ilya Averyanov
  1 sibling, 0 replies; 42+ messages in thread
From: Marek Vasut @ 2012-04-21 10:39 UTC (permalink / raw)
  To: u-boot

Dear Vasily Khoruzhick,

> 2012/4/21 Ilya Averyanov <averyanovin+uboot@gmail.com>:
> > No have problem.
> > Available only if you boot from NOR flash.
> > If you boot from the NAND 4kb of SRAM (steppingstone) not available.
> 
> For NAND boot it's mapped at 0x0
> For NOR boot it's mapped at 0x40000000
> 
> NAND controller uses it for booting purpose, but anyway for SPL we
> should fit code into
> 4k (hardware limitation), so I think using assembly here for SDRAM init is
> OK.

Now you claim that you can use SRAM for stack in all possible cases damnit. So 
there is not even a need for locking cache lines. So use the SRAM and be done 
with it.

> Regards
> Vasily

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-21  7:42                                 ` [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440 Vasily Khoruzhick
  2012-04-21 10:39                                   ` Marek Vasut
@ 2012-04-21 12:33                                   ` Ilya Averyanov
  2012-04-21 13:19                                     ` Marek Vasut
  1 sibling, 1 reply; 42+ messages in thread
From: Ilya Averyanov @ 2012-04-21 12:33 UTC (permalink / raw)
  To: u-boot

2012/4/21 Vasily Khoruzhick <anarsoul@gmail.com>

> 2012/4/21 Ilya Averyanov <averyanovin+uboot@gmail.com>:
> >
> > No have problem.
> > Available only if you boot from NOR flash.
> > If you boot from the NAND 4kb of SRAM (steppingstone) not available.
>
> For NAND boot it's mapped at 0x0
> For NOR boot it's mapped at 0x40000000
>
> NAND controller uses it for booting purpose, but anyway for SPL we
> should fit code into
> 4k (hardware limitation), so I think using assembly here for SDRAM init is
> OK.
>
> And how will you use the internal SRAM when you boot from NAND, if the SoC
writes in the SDRAM read data from NAND, and your data will be overwritten.

> Regards
> Vasily
>

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-21 12:33                                   ` Ilya Averyanov
@ 2012-04-21 13:19                                     ` Marek Vasut
  2012-04-23 13:40                                       ` Ilya Averyanov
  0 siblings, 1 reply; 42+ messages in thread
From: Marek Vasut @ 2012-04-21 13:19 UTC (permalink / raw)
  To: u-boot

Dear Ilya Averyanov,

> 2012/4/21 Vasily Khoruzhick <anarsoul@gmail.com>
> 
> > 2012/4/21 Ilya Averyanov <averyanovin+uboot@gmail.com>:
> > > No have problem.
> > > Available only if you boot from NOR flash.
> > > If you boot from the NAND 4kb of SRAM (steppingstone) not available.
> > 
> > For NAND boot it's mapped at 0x0
> > For NOR boot it's mapped at 0x40000000
> > 
> > NAND controller uses it for booting purpose, but anyway for SPL we
> > should fit code into
> > 4k (hardware limitation), so I think using assembly here for SDRAM init
> > is OK.
> > 
> > And how will you use the internal SRAM when you boot from NAND, if the
> > SoC
> 
> writes in the SDRAM read data from NAND, and your data will be overwritten.

Why? You'll load SPL into SRAM, then in SPL you'll copy the rest of uboot from 
NAND to - then already inited - SDRAM and execute it. We even have ready-to-use 
NAND SPL.

> 
> > Regards
> > Vasily

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-21 13:19                                     ` Marek Vasut
@ 2012-04-23 13:40                                       ` Ilya Averyanov
  2012-04-23 14:07                                         ` Marek Vasut
  0 siblings, 1 reply; 42+ messages in thread
From: Ilya Averyanov @ 2012-04-23 13:40 UTC (permalink / raw)
  To: u-boot

Dear Marek Vasut,

Would you please explain, why do you want to initialize the sdram has been in
C code.
If for provide this feature should be written assembly code. And it would
sometimes even harder than the initialization code sdram?

2012/4/21 Marek Vasut <marex@denx.de>

> Dear Ilya Averyanov,
>
> > 2012/4/21 Vasily Khoruzhick <anarsoul@gmail.com>
> >
> > > 2012/4/21 Ilya Averyanov <averyanovin+uboot@gmail.com>:
> > > > No have problem.
> > > > Available only if you boot from NOR flash.
> > > > If you boot from the NAND 4kb of SRAM (steppingstone) not available.
> > >
> > > For NAND boot it's mapped at 0x0
> > > For NOR boot it's mapped at 0x40000000
> > >
> > > NAND controller uses it for booting purpose, but anyway for SPL we
> > > should fit code into
> > > 4k (hardware limitation), so I think using assembly here for SDRAM init
> > > is OK.
> > >
> > > And how will you use the internal SRAM when you boot from NAND, if the
> > > SoC
> >
> > writes in the SDRAM read data from NAND, and your data will be
> overwritten.
>
> Why? You'll load SPL into SRAM, then in SPL you'll copy the rest of uboot
> from
> NAND to - then already inited - SDRAM and execute it. We even have
> ready-to-use
> NAND SPL.
>
> >
> > > Regards
> > > Vasily
>
> Best regards,
> Marek Vasut
>

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-23 13:40                                       ` Ilya Averyanov
@ 2012-04-23 14:07                                         ` Marek Vasut
  2012-04-23 14:27                                           ` Ilya Averyanov
  0 siblings, 1 reply; 42+ messages in thread
From: Marek Vasut @ 2012-04-23 14:07 UTC (permalink / raw)
  To: u-boot

Dear Ilya Averyanov,

> Dear Marek Vasut,
> 
> Would you please explain, why do you want to initialize the sdram has been
> in C code.

Ok, no problem:
- You'll be able to call get_ram_size() to scan for ram size as any other board
- SDRAM driver will fit properly into the driver model once it's in place (WIP, 
wanna volunteer for review process?)
- It's much cleaner

> If for provide this feature should be written assembly code. And it would
> sometimes even harder than the initialization code sdram?

What do you mean?

Ah yes, just a remark, please don't top-post. Notice how other people don't do 
it -- I know gmail does it out-of-the-box, but that doesn't mean it's correct.

> 2012/4/21 Marek Vasut <marex@denx.de>
> 
> > Dear Ilya Averyanov,
> > 
> > > 2012/4/21 Vasily Khoruzhick <anarsoul@gmail.com>
> > > 
> > > > 2012/4/21 Ilya Averyanov <averyanovin+uboot@gmail.com>:
> > > > > No have problem.
> > > > > Available only if you boot from NOR flash.
> > > > > If you boot from the NAND 4kb of SRAM (steppingstone) not
> > > > > available.
> > > > 
> > > > For NAND boot it's mapped at 0x0
> > > > For NOR boot it's mapped at 0x40000000
> > > > 
> > > > NAND controller uses it for booting purpose, but anyway for SPL we
> > > > should fit code into
> > > > 4k (hardware limitation), so I think using assembly here for SDRAM
> > > > init is OK.
> > > > 
> > > > And how will you use the internal SRAM when you boot from NAND, if
> > > > the SoC
> > > 
> > > writes in the SDRAM read data from NAND, and your data will be
> > 
> > overwritten.
> > 
> > Why? You'll load SPL into SRAM, then in SPL you'll copy the rest of uboot
> > from
> > NAND to - then already inited - SDRAM and execute it. We even have
> > ready-to-use
> > NAND SPL.
> > 
> > > > Regards
> > > > Vasily
> > 
> > Best regards,
> > Marek Vasut

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-23 14:07                                         ` Marek Vasut
@ 2012-04-23 14:27                                           ` Ilya Averyanov
  2012-04-23 15:25                                             ` Marek Vasut
  0 siblings, 1 reply; 42+ messages in thread
From: Ilya Averyanov @ 2012-04-23 14:27 UTC (permalink / raw)
  To: u-boot

2012/4/23 Marek Vasut <marex@denx.de>

> Dear Ilya Averyanov,
>
> > Dear Marek Vasut,
> >
> > Would you please explain, why do you want to initialize the sdram has
> been
> > in C code.
>
> Ok, no problem:
> - You'll be able to call get_ram_size() to scan for ram size as any other
> board
> - SDRAM driver will fit properly into the driver model once it's in place
> (WIP,
> wanna volunteer for review process?)
> - It's much cleaner
>
> > If for provide this feature should be written assembly code. And it would
> > sometimes even harder than the initialization code sdram?
>
> What do you mean?
>
 If we use 4kb of SRAM (steppingstone), then at least need to edit
u-boot/arch/arm/cpu/arm920t/start.S, to add a test from there was a boot
(NAND or NOR). Edit the address stack. etc ...
Use the MMU cache for the stack, even a little better, but it is more
difficult.

>
> Ah yes, just a remark, please don't top-post. Notice how other people
> don't do
> it -- I know gmail does it out-of-the-box, but that doesn't mean it's
> correct.
>
> Ok.

> > 2012/4/21 Marek Vasut <marex@denx.de>
> >
> > > Dear Ilya Averyanov,
> > >
> > > > 2012/4/21 Vasily Khoruzhick <anarsoul@gmail.com>
> > > >
> > > > > 2012/4/21 Ilya Averyanov <averyanovin+uboot@gmail.com>:
> > > > > > No have problem.
> > > > > > Available only if you boot from NOR flash.
> > > > > > If you boot from the NAND 4kb of SRAM (steppingstone) not
> > > > > > available.
> > > > >
> > > > > For NAND boot it's mapped at 0x0
> > > > > For NOR boot it's mapped at 0x40000000
> > > > >
> > > > > NAND controller uses it for booting purpose, but anyway for SPL we
> > > > > should fit code into
> > > > > 4k (hardware limitation), so I think using assembly here for SDRAM
> > > > > init is OK.
> > > > >
> > > > > And how will you use the internal SRAM when you boot from NAND, if
> > > > > the SoC
> > > >
> > > > writes in the SDRAM read data from NAND, and your data will be
> > >
> > > overwritten.
> > >
> > > Why? You'll load SPL into SRAM, then in SPL you'll copy the rest of
> uboot
> > > from
> > > NAND to - then already inited - SDRAM and execute it. We even have
> > > ready-to-use
> > > NAND SPL.
> > >
> > > > > Regards
> > > > > Vasily
> > >
> > > Best regards,
> > > Marek Vasut
>
> Best regards,
> Marek Vasut
>

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-23 14:27                                           ` Ilya Averyanov
@ 2012-04-23 15:25                                             ` Marek Vasut
  0 siblings, 0 replies; 42+ messages in thread
From: Marek Vasut @ 2012-04-23 15:25 UTC (permalink / raw)
  To: u-boot

Dear Ilya Averyanov,

> 2012/4/23 Marek Vasut <marex@denx.de>
> 
> > Dear Ilya Averyanov,
> > 
> > > Dear Marek Vasut,
> > > 
> > > Would you please explain, why do you want to initialize the sdram has
> > 
> > been
> > 
> > > in C code.
> > 
> > Ok, no problem:
> > - You'll be able to call get_ram_size() to scan for ram size as any other
> > board
> > - SDRAM driver will fit properly into the driver model once it's in place
> > (WIP,
> > wanna volunteer for review process?)
> > - It's much cleaner
> > 
> > > If for provide this feature should be written assembly code. And it
> > > would sometimes even harder than the initialization code sdram?
> > 
> > What do you mean?
> 
>  If we use 4kb of SRAM (steppingstone), then at least need to edit
> u-boot/arch/arm/cpu/arm920t/start.S, to add a test from there was a boot
> (NAND or NOR). Edit the address stack. etc ...
> Use the MMU cache for the stack, even a little better, but it is more
> difficult.

Just check where you have SRAM and adjust SP accordingly, it's easy :-)

> 
> > Ah yes, just a remark, please don't top-post. Notice how other people
> > don't do
> > it -- I know gmail does it out-of-the-box, but that doesn't mean it's
> > correct.
> > 
> > Ok.
> > 
> > > 2012/4/21 Marek Vasut <marex@denx.de>
> > > 
> > > > Dear Ilya Averyanov,
> > > > 
> > > > > 2012/4/21 Vasily Khoruzhick <anarsoul@gmail.com>
> > > > > 
> > > > > > 2012/4/21 Ilya Averyanov <averyanovin+uboot@gmail.com>:
> > > > > > > No have problem.
> > > > > > > Available only if you boot from NOR flash.
> > > > > > > If you boot from the NAND 4kb of SRAM (steppingstone) not
> > > > > > > available.
> > > > > > 
> > > > > > For NAND boot it's mapped at 0x0
> > > > > > For NOR boot it's mapped at 0x40000000
> > > > > > 
> > > > > > NAND controller uses it for booting purpose, but anyway for SPL
> > > > > > we should fit code into
> > > > > > 4k (hardware limitation), so I think using assembly here for
> > > > > > SDRAM init is OK.
> > > > > > 
> > > > > > And how will you use the internal SRAM when you boot from NAND,
> > > > > > if the SoC
> > > > > 
> > > > > writes in the SDRAM read data from NAND, and your data will be
> > > > 
> > > > overwritten.
> > > > 
> > > > Why? You'll load SPL into SRAM, then in SPL you'll copy the rest of
> > 
> > uboot
> > 
> > > > from
> > > > NAND to - then already inited - SDRAM and execute it. We even have
> > > > ready-to-use
> > > > NAND SPL.
> > > > 
> > > > > > Regards
> > > > > > Vasily
> > > > 
> > > > Best regards,
> > > > Marek Vasut
> > 
> > Best regards,
> > Marek Vasut

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-20 17:17                           ` Ilya Averyanov
  2012-04-20 19:11                             ` Marek Vasut
@ 2012-04-23 20:36                             ` Wolfgang Denk
  1 sibling, 0 replies; 42+ messages in thread
From: Wolfgang Denk @ 2012-04-23 20:36 UTC (permalink / raw)
  To: u-boot

Dear Ilya Averyanov,

In message <CABi8O6aBPyYFPbzJETJFyx4fL4y1EHYpWJx8Ew4Ki-AHpLA=Mw@mail.gmail.com> you wrote:
>
> Why do you insist on sdram initialization code in C?
> If you simply do as done in the other boards on this architecture?

We want to simplify code by usiing the same approach everywhere.  And
this means that we first set up a system that can run C code, and then
use this to insitialize the RAM.  This includes using get_ram_size()
to auto-detect (and verify) the actual RAM size.  And get_ram_size() 
is a C function as well.

The "other boards" are still old-style and should not be used as
examples.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
How many QA engineers does it take to screw in a lightbulb? 3:  1  to
screw it in and 2 to say "I told you so" when it doesn't work.

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-20 19:18                           ` Vasily Khoruzhick
  2012-04-20 20:03                             ` Marek Vasut
@ 2012-04-23 20:39                             ` Wolfgang Denk
  1 sibling, 0 replies; 42+ messages in thread
From: Wolfgang Denk @ 2012-04-23 20:39 UTC (permalink / raw)
  To: u-boot

Dear Vasily Khoruzhick,

In message <CA+E=qVdyJB3R8vwwFmZsU-0Yh1ah+ZyherrHnN3jx=xTY=tsWg@mail.gmail.com> you wrote:
> 
> Btw, using cache for stack looks like awful hack to me.

No, why?  Cache is pretty fast RAM, so why not use it as such?

Hey, there are people who boot the whole Linux system (kernel + RAM
disk) in cache (actully already on the die, before the chip even has
seen a casing, far from thinking about a board...

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"One planet is all you get."

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
  2012-04-21  7:35                                   ` Vasily Khoruzhick
@ 2012-04-23 20:43                                     ` Wolfgang Denk
  0 siblings, 0 replies; 42+ messages in thread
From: Wolfgang Denk @ 2012-04-23 20:43 UTC (permalink / raw)
  To: u-boot

Dear Vasily Khoruzhick,

In message <CA+E=qVeXE0wUtN4nb6k-zAH7uqVF4J0umd33+GXkQb3yPvTW+A@mail.gmail.com> you wrote:
> 
> Doing SDRAM init very early (even in assembly code) is obvious and simple.
> Just few simple writes into RAM controller registers.

This is a misconception.

Experience on this very mailing list has shown that an extremely high
number of issues is cause by incomplete and/or incorrect memory
initialization.  This is why U-Boot (be design!) makes sure we have a
full C environment when doing this taks, where we can use printf() and
friends for useful output etc.

> It's not as simple as previous solution, isn't it? And looks

No, it's not so simple, but far more convenient.  And over time, much
more time-saving.

> overengineered to me. I prefer to keep
> such low-level things simple.

We respect your personal preferences.  But in this case we ask you to
stick with the U-Boot design andimplement as requested. Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
1 1 was a race-horse, 2 2 was 1 2. When 1 1 1 1 race, 2 2 1 1 2.

^ permalink raw reply	[flat|nested] 42+ messages in thread

end of thread, other threads:[~2012-04-23 20:43 UTC | newest]

Thread overview: 42+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-16 17:46 [U-Boot] Add support for Mini2440 Gabriel Huau
2012-04-17 20:09 ` [U-Boot] [PATCH V2] " Gabriel Huau
     [not found]   ` <1334694802-4881-1-git-send-email-contact@huau-gabriel.fr>
2012-04-17 20:45     ` [U-Boot] [PATCH v2] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440 Marek Vasut
2012-04-19 19:25 ` [U-Boot] [PATCH v3] " Gabriel Huau
2012-04-19 20:08   ` Marek Vasut
2012-04-19 20:16     ` Gabriel Huau
2012-04-19 20:45       ` Marek Vasut
2012-04-19 21:33         ` Gabriel Huau
2012-04-19 22:22           ` Marek Vasut
2012-04-20  7:19             ` Ilya Averyanov
2012-04-20  9:11               ` Marek Vasut
2012-04-20 13:35                 ` Ilya Averyanov
2012-04-20 14:08                   ` Marek Vasut
2012-04-20 14:30                     ` Ilya Averyanov
2012-04-20 14:35                       ` Ilya Averyanov
2012-04-20 16:17                         ` Marek Vasut
2012-04-20 17:17                           ` Ilya Averyanov
2012-04-20 19:11                             ` Marek Vasut
2012-04-23 20:36                             ` Wolfgang Denk
2012-04-20 19:18                           ` Vasily Khoruzhick
2012-04-20 20:03                             ` Marek Vasut
2012-04-20 22:51                               ` Ilya Averyanov
2012-04-20 23:07                                 ` Marek Vasut
2012-04-21  7:35                                   ` Vasily Khoruzhick
2012-04-23 20:43                                     ` Wolfgang Denk
2012-04-20 23:30                                 ` [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440) Gabriel Huau
2012-04-21  4:09                                   ` Ilya Averyanov
2012-04-21  9:00                                   ` Vasily Khoruzhick
2012-04-21  7:42                                 ` [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440 Vasily Khoruzhick
2012-04-21 10:39                                   ` Marek Vasut
2012-04-21 12:33                                   ` Ilya Averyanov
2012-04-21 13:19                                     ` Marek Vasut
2012-04-23 13:40                                       ` Ilya Averyanov
2012-04-23 14:07                                         ` Marek Vasut
2012-04-23 14:27                                           ` Ilya Averyanov
2012-04-23 15:25                                             ` Marek Vasut
2012-04-23 20:39                             ` Wolfgang Denk
2012-04-20 16:16                       ` Marek Vasut
2012-04-19 21:37         ` Ilya Averyanov
2012-04-19 22:23           ` Marek Vasut
2012-04-19 22:30             ` Graeme Russ
2012-04-19 22:22   ` Graeme Russ

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.