All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Arnd Bergmann <arnd.bergmann@linaro.org>
Subject: Re: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+
Date: Thu, 15 Aug 2013 11:39:04 -0700	[thread overview]
Message-ID: <20130815183904.GA4067@roeck-us.net> (raw)
In-Reply-To: <CAFEAcA_MyJPwo6Gd_dxeWM5q5-7MYqR6-rrePusFzYaGGckWJQ@mail.gmail.com>

On Thu, Aug 15, 2013 at 07:05:22PM +0100, Peter Maydell wrote:
> On 15 August 2013 18:54, Guenter Roeck <linux@roeck-us.net> wrote:
> > On Thu, Aug 15, 2013 at 05:45:42PM +0100, Peter Maydell wrote:
> >> On 13 August 2013 04:40, Guenter Roeck <linux@roeck-us.net> wrote:
> >> > Patch tested and working with qemu 1.5.2, using the configuration file
> >> > from the yocto project. Patch applied on top of kernel version 3.11-rc5.
> >>
> >> OK, I tested this on PB926+PCI backplane hardware, and it is
> >> definitely better than current mainline, in that the test USB
> >> card that I have no longer causes the kernel to generate this sort of
> >> backtrace:
> >>
> > Do you mean my patch fixes the traceback below as a side effect ?
> > Would be great ... it would be one more reason to get it applied.
> 
> Yes, exactly -- the kernel currently has the wrong irq mapping,
> which causes the traceback (ie h/w asserts irq 93 but the kernel
> is listening on something else). That the patch fixes this confirms
> that it is the behaviour of hardware as well as of QEMU.
> 
> >> However it still doesn't seem to reliably detect the USB harddisk
> >> plugged into the card, so I think there may be further issues, possibly
> >> some subset of those Arnd identified and fixed with this patch:
> >> http://permalink.gmane.org/gmane.linux.ports.arm.kernel/93397
> >>
> > Does it get better if you apply Arnd's patch ?
> 
> Arnd's patch is ancient and won't apply as is (due to intervening
> changes and also because some of the things it fixes were fixed
> in later patches); I'm currently trying to extract the relevant parts.
> 
> If you want you can confirm that I/O port PCI access is broken on
> QEMU too -- disable CONFIG_SCSI_SYM53C8XX_MMIO so
> the driver uses PCI IO rather than MMIO and you'll see QEMU's
> SCSI device doesn't work any more.
> 
> >> so I'd like to continue testing.
> >>
> >> The other thing this patch should (IMHO) have is the
> >> line in pci_versatile_setup() which tells QEMU that the
> >> kernel really does expect hardware-like behaviour:
> 
> >> (Without this line QEMU will guess whether the kernel is broken
> >> or not and will get it right most but not necessarily all of the time.)
> >>
> > Might make sense, but I think it should be a separate patch.
> 
> It needs to go in the same patch, because a kernel with the fixed
> irq remapping must also tell QEMU it is fixed; if you split the
> two then at the point between the two patches the kernel is
> broken for bisection purposes.
> 
> > If I understand correctly, my patch fixes the SCSI problem.
> > Is that correct ? If so, can we get it applied to mainline ?
> 
> I'd rather get to a point where I have the hardware definitely
> completely working first. There's no real hurry, this has been
> broken for months and months.
> 
Ok with me, if it doesn't get lost.

Until it gets fixed, arm status on 3.10 kernels will show as "failed"
for qemu test runs.

Thanks,
Guenter

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	Arnd Bergmann <arnd.bergmann@linaro.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+
Date: Thu, 15 Aug 2013 11:39:04 -0700	[thread overview]
Message-ID: <20130815183904.GA4067@roeck-us.net> (raw)
In-Reply-To: <CAFEAcA_MyJPwo6Gd_dxeWM5q5-7MYqR6-rrePusFzYaGGckWJQ@mail.gmail.com>

On Thu, Aug 15, 2013 at 07:05:22PM +0100, Peter Maydell wrote:
> On 15 August 2013 18:54, Guenter Roeck <linux@roeck-us.net> wrote:
> > On Thu, Aug 15, 2013 at 05:45:42PM +0100, Peter Maydell wrote:
> >> On 13 August 2013 04:40, Guenter Roeck <linux@roeck-us.net> wrote:
> >> > Patch tested and working with qemu 1.5.2, using the configuration file
> >> > from the yocto project. Patch applied on top of kernel version 3.11-rc5.
> >>
> >> OK, I tested this on PB926+PCI backplane hardware, and it is
> >> definitely better than current mainline, in that the test USB
> >> card that I have no longer causes the kernel to generate this sort of
> >> backtrace:
> >>
> > Do you mean my patch fixes the traceback below as a side effect ?
> > Would be great ... it would be one more reason to get it applied.
> 
> Yes, exactly -- the kernel currently has the wrong irq mapping,
> which causes the traceback (ie h/w asserts irq 93 but the kernel
> is listening on something else). That the patch fixes this confirms
> that it is the behaviour of hardware as well as of QEMU.
> 
> >> However it still doesn't seem to reliably detect the USB harddisk
> >> plugged into the card, so I think there may be further issues, possibly
> >> some subset of those Arnd identified and fixed with this patch:
> >> http://permalink.gmane.org/gmane.linux.ports.arm.kernel/93397
> >>
> > Does it get better if you apply Arnd's patch ?
> 
> Arnd's patch is ancient and won't apply as is (due to intervening
> changes and also because some of the things it fixes were fixed
> in later patches); I'm currently trying to extract the relevant parts.
> 
> If you want you can confirm that I/O port PCI access is broken on
> QEMU too -- disable CONFIG_SCSI_SYM53C8XX_MMIO so
> the driver uses PCI IO rather than MMIO and you'll see QEMU's
> SCSI device doesn't work any more.
> 
> >> so I'd like to continue testing.
> >>
> >> The other thing this patch should (IMHO) have is the
> >> line in pci_versatile_setup() which tells QEMU that the
> >> kernel really does expect hardware-like behaviour:
> 
> >> (Without this line QEMU will guess whether the kernel is broken
> >> or not and will get it right most but not necessarily all of the time.)
> >>
> > Might make sense, but I think it should be a separate patch.
> 
> It needs to go in the same patch, because a kernel with the fixed
> irq remapping must also tell QEMU it is fixed; if you split the
> two then at the point between the two patches the kernel is
> broken for bisection purposes.
> 
> > If I understand correctly, my patch fixes the SCSI problem.
> > Is that correct ? If so, can we get it applied to mainline ?
> 
> I'd rather get to a point where I have the hardware definitely
> completely working first. There's no real hurry, this has been
> broken for months and months.
> 
Ok with me, if it doesn't get lost.

Until it gets fixed, arm status on 3.10 kernels will show as "failed"
for qemu test runs.

Thanks,
Guenter

WARNING: multiple messages have this Message-ID (diff)
From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+
Date: Thu, 15 Aug 2013 11:39:04 -0700	[thread overview]
Message-ID: <20130815183904.GA4067@roeck-us.net> (raw)
In-Reply-To: <CAFEAcA_MyJPwo6Gd_dxeWM5q5-7MYqR6-rrePusFzYaGGckWJQ@mail.gmail.com>

On Thu, Aug 15, 2013 at 07:05:22PM +0100, Peter Maydell wrote:
> On 15 August 2013 18:54, Guenter Roeck <linux@roeck-us.net> wrote:
> > On Thu, Aug 15, 2013 at 05:45:42PM +0100, Peter Maydell wrote:
> >> On 13 August 2013 04:40, Guenter Roeck <linux@roeck-us.net> wrote:
> >> > Patch tested and working with qemu 1.5.2, using the configuration file
> >> > from the yocto project. Patch applied on top of kernel version 3.11-rc5.
> >>
> >> OK, I tested this on PB926+PCI backplane hardware, and it is
> >> definitely better than current mainline, in that the test USB
> >> card that I have no longer causes the kernel to generate this sort of
> >> backtrace:
> >>
> > Do you mean my patch fixes the traceback below as a side effect ?
> > Would be great ... it would be one more reason to get it applied.
> 
> Yes, exactly -- the kernel currently has the wrong irq mapping,
> which causes the traceback (ie h/w asserts irq 93 but the kernel
> is listening on something else). That the patch fixes this confirms
> that it is the behaviour of hardware as well as of QEMU.
> 
> >> However it still doesn't seem to reliably detect the USB harddisk
> >> plugged into the card, so I think there may be further issues, possibly
> >> some subset of those Arnd identified and fixed with this patch:
> >> http://permalink.gmane.org/gmane.linux.ports.arm.kernel/93397
> >>
> > Does it get better if you apply Arnd's patch ?
> 
> Arnd's patch is ancient and won't apply as is (due to intervening
> changes and also because some of the things it fixes were fixed
> in later patches); I'm currently trying to extract the relevant parts.
> 
> If you want you can confirm that I/O port PCI access is broken on
> QEMU too -- disable CONFIG_SCSI_SYM53C8XX_MMIO so
> the driver uses PCI IO rather than MMIO and you'll see QEMU's
> SCSI device doesn't work any more.
> 
> >> so I'd like to continue testing.
> >>
> >> The other thing this patch should (IMHO) have is the
> >> line in pci_versatile_setup() which tells QEMU that the
> >> kernel really does expect hardware-like behaviour:
> 
> >> (Without this line QEMU will guess whether the kernel is broken
> >> or not and will get it right most but not necessarily all of the time.)
> >>
> > Might make sense, but I think it should be a separate patch.
> 
> It needs to go in the same patch, because a kernel with the fixed
> irq remapping must also tell QEMU it is fixed; if you split the
> two then at the point between the two patches the kernel is
> broken for bisection purposes.
> 
> > If I understand correctly, my patch fixes the SCSI problem.
> > Is that correct ? If so, can we get it applied to mainline ?
> 
> I'd rather get to a point where I have the hardware definitely
> completely working first. There's no real hurry, this has been
> broken for months and months.
> 
Ok with me, if it doesn't get lost.

Until it gets fixed, arm status on 3.10 kernels will show as "failed"
for qemu test runs.

Thanks,
Guenter

  reply	other threads:[~2013-08-15 18:39 UTC|newest]

Thread overview: 104+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-11 15:54 SCSI bus failures with qemu-arm in kernel 3.8+ Guenter Roeck
2013-08-11 15:54 ` Guenter Roeck
2013-08-11 22:04 ` Russell King - ARM Linux
2013-08-11 22:04   ` Russell King - ARM Linux
2013-08-12  0:40   ` Guenter Roeck
2013-08-12  0:40     ` Guenter Roeck
2013-08-12  0:40     ` [Qemu-devel] " Guenter Roeck
2013-08-12 16:24     ` Peter Maydell
2013-08-12 16:24       ` Peter Maydell
2013-08-12 16:24       ` Peter Maydell
2013-08-12 16:45       ` Russell King - ARM Linux
2013-08-12 16:45         ` Russell King - ARM Linux
2013-08-12 16:45         ` Russell King - ARM Linux
2013-08-12 17:33         ` Peter Maydell
2013-08-12 17:33           ` Peter Maydell
2013-08-12 17:33           ` Peter Maydell
2013-08-12 20:06           ` Russell King - ARM Linux
2013-08-12 20:06             ` Russell King - ARM Linux
2013-08-12 20:06             ` Russell King - ARM Linux
2013-08-12 20:49             ` Peter Maydell
2013-08-12 20:49               ` Peter Maydell
2013-08-12 20:49               ` Peter Maydell
2013-08-12 21:21               ` Russell King - ARM Linux
2013-08-12 21:21                 ` Russell King - ARM Linux
2013-08-12 21:21                 ` Russell King - ARM Linux
2013-08-12 21:36                 ` Peter Maydell
2013-08-12 21:36                   ` Peter Maydell
2013-08-12 21:36                   ` Peter Maydell
2013-08-12 22:12                   ` Russell King - ARM Linux
2013-08-12 22:12                     ` Russell King - ARM Linux
2013-08-12 22:12                     ` Russell King - ARM Linux
2013-08-12 22:48                     ` Guenter Roeck
2013-08-12 22:48                       ` Guenter Roeck
2013-08-12 22:48                       ` Guenter Roeck
2013-08-12 23:04                     ` Guenter Roeck
2013-08-12 23:04                       ` Guenter Roeck
2013-08-12 23:04                       ` Guenter Roeck
2013-08-14 10:33                       ` Russell King - ARM Linux
2013-08-14 10:33                         ` Russell King - ARM Linux
2013-08-14 10:33                         ` Russell King - ARM Linux
2013-08-14 12:44                         ` Peter Maydell
2013-08-14 12:44                           ` Peter Maydell
2013-08-14 12:44                           ` Peter Maydell
2013-08-14 12:49                           ` Russell King - ARM Linux
2013-08-14 12:49                             ` Russell King - ARM Linux
2013-08-14 12:49                             ` Russell King - ARM Linux
2013-08-14 12:56                             ` Peter Maydell
2013-08-14 12:56                               ` Peter Maydell
2013-08-14 12:56                               ` Peter Maydell
2013-08-14 14:41                           ` Guenter Roeck
2013-08-14 14:41                             ` Guenter Roeck
2013-08-14 14:41                             ` Guenter Roeck
2013-08-14 15:26                             ` [Qemu-devel] memory reads and writes Herbei Dacian
2013-08-12 17:48         ` [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+ Peter Maydell
2013-08-12 17:48           ` Peter Maydell
2013-08-12 17:48           ` Peter Maydell
2013-08-13  8:37         ` Rob Landley
2013-08-13  8:37           ` Rob Landley
2013-08-13  8:37           ` Rob Landley
2013-08-13  9:12           ` Peter Maydell
2013-08-13  9:12             ` Peter Maydell
2013-08-13  9:12             ` Peter Maydell
2013-08-13 11:30           ` Russell King - ARM Linux
2013-08-13 11:30             ` Russell King - ARM Linux
2013-08-13 11:30             ` Russell King - ARM Linux
2013-08-13  3:40       ` Guenter Roeck
2013-08-13  3:40         ` Guenter Roeck
2013-08-13  3:40         ` Guenter Roeck
2013-08-15 16:45         ` Peter Maydell
2013-08-15 16:45           ` Peter Maydell
2013-08-15 16:45           ` Peter Maydell
2013-08-15 17:54           ` Guenter Roeck
2013-08-15 17:54             ` Guenter Roeck
2013-08-15 17:54             ` Guenter Roeck
2013-08-15 18:05             ` Peter Maydell
2013-08-15 18:05               ` Peter Maydell
2013-08-15 18:05               ` Peter Maydell
2013-08-15 18:39               ` Guenter Roeck [this message]
2013-08-15 18:39                 ` Guenter Roeck
2013-08-15 18:39                 ` Guenter Roeck
2013-08-15 20:50               ` Guenter Roeck
2013-08-15 20:50                 ` Guenter Roeck
2013-08-15 20:50                 ` Guenter Roeck
2013-08-15 21:49                 ` Peter Maydell
2013-08-15 21:49                   ` Peter Maydell
2013-08-15 21:49                   ` Peter Maydell
2013-08-15 22:18                   ` Guenter Roeck
2013-08-15 22:18                     ` Guenter Roeck
2013-08-15 22:18                     ` Guenter Roeck
2013-08-15 22:23                     ` Peter Maydell
2013-08-15 22:23                       ` Peter Maydell
2013-08-15 22:23                       ` Peter Maydell
2013-08-15 23:25                       ` Guenter Roeck
2013-08-15 23:25                         ` Guenter Roeck
2013-08-15 23:25                         ` Guenter Roeck
2013-08-19 15:26                       ` Guenter Roeck
2013-08-19 15:26                         ` Guenter Roeck
2013-08-19 15:26                         ` Guenter Roeck
2013-08-12 19:02     ` Paul Gortmaker
2013-08-12 19:02       ` Paul Gortmaker
2013-08-12 19:02       ` [Qemu-devel] " Paul Gortmaker
2013-08-12 20:58       ` Peter Maydell
2013-08-12 20:58         ` Peter Maydell
2013-08-12 20:58         ` [Qemu-devel] " Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130815183904.GA4067@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=arnd.bergmann@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=paul.gortmaker@windriver.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.