From: Boris Brezillon <boris.brezillon@bootlin.com> To: Eugen Hristev <eugen.hristev@microchip.com> Cc: Peter Rosin <peda@axentia.se>, Tudor Ambarus <tudor.ambarus@microchip.com>, Nicolas Ferre <nicolas.ferre@microchip.com>, Ludovic Desroches <ludovic.desroches@microchip.com>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Marek Vasut <marek.vasut@gmail.com>, Josh Wu <rainyfeeling@outlook.com>, Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>, <linux-kernel@vger.kernel.org>, <linux-mtd@lists.infradead.org>, Richard Weinberger <richard@nod.at>, Brian Norris <computersforpeace@gmail.com>, David Woodhouse <dwmw2@infradead.org>, <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma Date: Tue, 29 May 2018 16:49:11 +0200 [thread overview] Message-ID: <20180529164911.29820e07@bbrezillon> (raw) In-Reply-To: <19d68279-072e-7646-6fdd-8649578229ea@microchip.com> Hi Eugen, On Tue, 29 May 2018 09:30:54 +0300 Eugen Hristev <eugen.hristev@microchip.com> wrote: > On 28.05.2018 13:10, Peter Rosin wrote: > > On 2018-05-28 00:11, Peter Rosin wrote: > >> On 2018-05-27 11:18, Peter Rosin wrote: > >>> On 2018-05-25 16:51, Tudor Ambarus wrote: > >>>> We think the best way is to keep LCD on DDR Ports 2 and 3 (8th and 9th > >>>> slaves), to have maximum bandwidth and to use DMA on DDR port 1 for NAND > >>>> (7th slave). > >>> > >>> Exactly how do I accomplish that? > >>> > >>> I can see how I can move the LCD between slave DDR port 2 and 3 by > >>> selecting LCDC DMA master 8 or 9 (but according to the above it should > >>> not matter). The big question is how I control what slave the NAND flash > >>> is going to use? I find nothing in the datasheet, and the code is also > >>> non-transparent enough for me to figure it out by myself without > >>> throwing out this question first... > > >> [...] > > >> and the output is > >> > >> atmel-nand-controller 10000000.ebi:nand-controller: using dma0chan5 for DMA transfers > >> > >> So, DMA controller 0 is in use. I still don't know if IF0, IF1 or IF2 is used > >> or how to find out. I guess IF2 is not in use since that does not allow any > >> DDR2 port as slave... > > Hello Peter, > > Thank you for all the information, I will chip in to help a little bit. > The Master/channel is described in the device tree. The channel has a > controller, a mem/periph interface and a periph ID, plus a FIFO > configuration. > > The dma chan number reported in the dmesg is just software. Here is an > example from DT: > dmas = <&dma0 2 AT91_DMA_CFG_PER_ID(1)>, > <&dma0 2 AT91_DMA_CFG_PER_ID(2)>; > > you can match this with the help from > Documentation/devicetree/bindings/dma/atmel-dma.txt: > > 1. A phandle pointing to the DMA controller. > > 2. The memory interface (16 most significant bits), the peripheral > interface > (16 less significant bits). > > 3. Parameters for the at91 DMA configuration register which are device > > dependent: > > - bit 7-0: peripheral identifier for the hardware handshaking > interface. The > identifier can be different for tx and rx. > > - bit 11-8: FIFO configuration. 0 for half FIFO, 1 for ALAP, 2 for ASAP. > > > So , what was Tudor asking for, is your DT for the ebi node (if you are > using ebi), or, your NFC SRAM (Nand Flash Controller SRAM) DMA > devicetree chunk, so, we can figure out which type of DMA are you using. I think you're missing something here. We use the DMA engine in memcpy mode (SRAM -> DRAM), not in device mode (dev -> DRAM or DRAM -> dev). So there's no dmas prop defined in the DT and there should not be. Regards, Boris > > Normally, the ebi should be connected to both DMA0 and DMA1 on those > interfaces specified in DT. Which ones you want to use, depends on your > setup (and contention on the bus/accesses, like in your case, the HLCDC) > > Thats why we have multiple choices, to pick the right one for each case. > In our vanilla DT sama5d3.dtsi we do not have DMA described for ebi > interface. > > Eugen > > >> [...]
WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@bootlin.com (Boris Brezillon) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma Date: Tue, 29 May 2018 16:49:11 +0200 [thread overview] Message-ID: <20180529164911.29820e07@bbrezillon> (raw) In-Reply-To: <19d68279-072e-7646-6fdd-8649578229ea@microchip.com> Hi Eugen, On Tue, 29 May 2018 09:30:54 +0300 Eugen Hristev <eugen.hristev@microchip.com> wrote: > On 28.05.2018 13:10, Peter Rosin wrote: > > On 2018-05-28 00:11, Peter Rosin wrote: > >> On 2018-05-27 11:18, Peter Rosin wrote: > >>> On 2018-05-25 16:51, Tudor Ambarus wrote: > >>>> We think the best way is to keep LCD on DDR Ports 2 and 3 (8th and 9th > >>>> slaves), to have maximum bandwidth and to use DMA on DDR port 1 for NAND > >>>> (7th slave). > >>> > >>> Exactly how do I accomplish that? > >>> > >>> I can see how I can move the LCD between slave DDR port 2 and 3 by > >>> selecting LCDC DMA master 8 or 9 (but according to the above it should > >>> not matter). The big question is how I control what slave the NAND flash > >>> is going to use? I find nothing in the datasheet, and the code is also > >>> non-transparent enough for me to figure it out by myself without > >>> throwing out this question first... > > >> [...] > > >> and the output is > >> > >> atmel-nand-controller 10000000.ebi:nand-controller: using dma0chan5 for DMA transfers > >> > >> So, DMA controller 0 is in use. I still don't know if IF0, IF1 or IF2 is used > >> or how to find out. I guess IF2 is not in use since that does not allow any > >> DDR2 port as slave... > > Hello Peter, > > Thank you for all the information, I will chip in to help a little bit. > The Master/channel is described in the device tree. The channel has a > controller, a mem/periph interface and a periph ID, plus a FIFO > configuration. > > The dma chan number reported in the dmesg is just software. Here is an > example from DT: > dmas = <&dma0 2 AT91_DMA_CFG_PER_ID(1)>, > <&dma0 2 AT91_DMA_CFG_PER_ID(2)>; > > you can match this with the help from > Documentation/devicetree/bindings/dma/atmel-dma.txt: > > 1. A phandle pointing to the DMA controller. > > 2. The memory interface (16 most significant bits), the peripheral > interface > (16 less significant bits). > > 3. Parameters for the at91 DMA configuration register which are device > > dependent: > > - bit 7-0: peripheral identifier for the hardware handshaking > interface. The > identifier can be different for tx and rx. > > - bit 11-8: FIFO configuration. 0 for half FIFO, 1 for ALAP, 2 for ASAP. > > > So , what was Tudor asking for, is your DT for the ebi node (if you are > using ebi), or, your NFC SRAM (Nand Flash Controller SRAM) DMA > devicetree chunk, so, we can figure out which type of DMA are you using. I think you're missing something here. We use the DMA engine in memcpy mode (SRAM -> DRAM), not in device mode (dev -> DRAM or DRAM -> dev). So there's no dmas prop defined in the DT and there should not be. Regards, Boris > > Normally, the ebi should be connected to both DMA0 and DMA1 on those > interfaces specified in DT. Which ones you want to use, depends on your > setup (and contention on the bus/accesses, like in your case, the HLCDC) > > Thats why we have multiple choices, to pick the right one for each case. > In our vanilla DT sama5d3.dtsi we do not have DMA described for ebi > interface. > > Eugen > > >> [...]
next prev parent reply other threads:[~2018-05-29 14:49 UTC|newest] Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-29 13:10 [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma Peter Rosin 2018-03-29 13:10 ` Peter Rosin 2018-03-29 13:33 ` Boris Brezillon 2018-03-29 13:33 ` Boris Brezillon 2018-03-29 13:37 ` Peter Rosin 2018-03-29 13:37 ` Peter Rosin 2018-03-29 13:44 ` Boris Brezillon 2018-03-29 13:44 ` Boris Brezillon 2018-03-29 14:27 ` Peter Rosin 2018-03-29 14:27 ` Peter Rosin 2018-03-30 21:43 ` Peter Rosin 2018-03-30 21:43 ` Peter Rosin 2018-04-02 12:22 ` Boris Brezillon 2018-04-02 12:22 ` Boris Brezillon 2018-04-02 17:59 ` Peter Rosin 2018-04-02 17:59 ` Peter Rosin 2018-04-02 19:28 ` Boris Brezillon 2018-04-02 19:28 ` Boris Brezillon 2018-04-02 20:20 ` Boris Brezillon 2018-04-02 20:20 ` Boris Brezillon 2018-04-02 20:32 ` Boris Brezillon 2018-04-02 20:32 ` Boris Brezillon 2018-04-03 6:11 ` Peter Rosin 2018-04-03 6:11 ` Peter Rosin 2018-04-03 7:18 ` Boris Brezillon 2018-04-03 7:18 ` Boris Brezillon 2018-04-11 14:44 ` Peter Rosin 2018-04-11 14:44 ` Peter Rosin 2018-04-11 14:59 ` Boris Brezillon 2018-04-11 14:59 ` Boris Brezillon 2018-04-11 15:10 ` Peter Rosin 2018-04-11 15:10 ` Peter Rosin 2018-04-11 15:34 ` Boris Brezillon 2018-04-11 15:34 ` Boris Brezillon 2018-04-11 15:34 ` Nicolas Ferre 2018-04-11 15:34 ` Nicolas Ferre 2018-04-12 7:18 ` Peter Rosin 2018-04-12 7:18 ` Peter Rosin 2018-05-22 18:03 ` Peter Rosin 2018-05-22 18:03 ` Peter Rosin 2018-05-23 10:42 ` Boris Brezillon 2018-05-23 10:42 ` Boris Brezillon 2018-05-25 14:51 ` Tudor Ambarus 2018-05-25 14:51 ` Tudor Ambarus 2018-05-26 17:40 ` Peter Rosin 2018-05-26 17:40 ` Peter Rosin 2018-05-27 9:18 ` Peter Rosin 2018-05-27 9:18 ` Peter Rosin 2018-05-27 22:11 ` Peter Rosin 2018-05-27 22:11 ` Peter Rosin 2018-05-28 10:10 ` Peter Rosin 2018-05-28 10:10 ` Peter Rosin 2018-05-28 14:27 ` Boris Brezillon 2018-05-28 14:27 ` Boris Brezillon 2018-05-28 15:52 ` Peter Rosin 2018-05-28 15:52 ` Peter Rosin 2018-05-28 16:09 ` Boris Brezillon 2018-05-28 16:09 ` Boris Brezillon 2018-05-28 16:09 ` Nicolas Ferre 2018-05-28 16:09 ` Nicolas Ferre 2018-05-29 6:30 ` Eugen Hristev 2018-05-29 6:30 ` Eugen Hristev 2018-05-29 7:10 ` Peter Rosin 2018-05-29 7:10 ` Peter Rosin 2018-05-29 7:25 ` Eugen Hristev 2018-05-29 7:25 ` Eugen Hristev 2018-05-29 14:49 ` Boris Brezillon [this message] 2018-05-29 14:49 ` Boris Brezillon 2018-05-29 15:01 ` Eugen Hristev 2018-05-29 15:01 ` Eugen Hristev 2018-05-29 15:15 ` Boris Brezillon 2018-05-29 15:15 ` Boris Brezillon 2018-05-29 15:21 ` Eugen Hristev 2018-05-29 15:21 ` Eugen Hristev 2018-05-29 15:46 ` Boris Brezillon 2018-05-29 15:46 ` Boris Brezillon 2018-05-29 17:57 ` Boris Brezillon 2018-05-29 17:57 ` Boris Brezillon 2018-05-29 21:37 ` Peter Rosin 2018-05-29 21:37 ` Peter Rosin 2018-06-04 15:46 ` Tudor Ambarus 2018-06-04 15:46 ` Tudor Ambarus 2018-06-04 16:03 ` Boris Brezillon 2018-06-04 16:03 ` Boris Brezillon 2022-06-16 15:54 ` SAMA5D3 Display FIFO underflow (Was: Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma) Ahmad Fatoum 2022-07-25 14:17 ` Ahmad Fatoum 2022-07-28 8:03 ` Tudor.Ambarus 2018-04-03 6:51 ` [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma Peter Rosin 2018-04-03 6:51 ` Peter Rosin 2018-04-03 7:15 ` Boris Brezillon 2018-04-03 7:15 ` Boris Brezillon 2018-04-03 7:32 ` Boris Brezillon 2018-04-03 7:32 ` Boris Brezillon 2018-04-03 8:14 ` Peter Rosin 2018-04-03 8:14 ` Peter Rosin 2018-04-03 8:30 ` Boris Brezillon 2018-04-03 8:30 ` Boris Brezillon 2018-04-02 20:23 ` Peter Rosin 2018-04-02 20:23 ` Peter Rosin 2018-04-02 20:35 ` Boris Brezillon 2018-04-02 20:35 ` Boris Brezillon 2018-04-03 7:18 ` Alexandre Belloni 2018-04-03 7:18 ` Alexandre Belloni 2018-04-03 8:37 ` Peter Rosin 2018-04-03 8:37 ` Peter Rosin 2018-03-29 14:20 ` Nicolas Ferre 2018-03-29 14:20 ` Nicolas Ferre 2018-03-29 14:23 ` Peter Rosin 2018-03-29 14:23 ` Peter Rosin 2018-03-29 14:29 ` Boris Brezillon 2018-03-29 14:29 ` Boris Brezillon 2018-06-18 8:39 ` Boris Brezillon 2018-06-18 8:39 ` Boris Brezillon 2018-06-18 14:00 ` Miquel Raynal 2018-06-18 14:00 ` Miquel Raynal 2018-06-25 12:31 ` Miquel Raynal 2018-06-25 12:31 ` Miquel Raynal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180529164911.29820e07@bbrezillon \ --to=boris.brezillon@bootlin.com \ --cc=alexandre.belloni@bootlin.com \ --cc=computersforpeace@gmail.com \ --cc=cyrille.pitchen@wedev4u.fr \ --cc=dwmw2@infradead.org \ --cc=eugen.hristev@microchip.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=ludovic.desroches@microchip.com \ --cc=marek.vasut@gmail.com \ --cc=nicolas.ferre@microchip.com \ --cc=peda@axentia.se \ --cc=rainyfeeling@outlook.com \ --cc=richard@nod.at \ --cc=tudor.ambarus@microchip.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.