All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/icl: Fix clockgating issue when using scalars
@ 2019-03-15 22:18 Radhakrishna Sripada
  2019-03-15 22:23 ` Chris Wilson
                   ` (23 more replies)
  0 siblings, 24 replies; 43+ messages in thread
From: Radhakrishna Sripada @ 2019-03-15 22:18 UTC (permalink / raw)
  To: intel-gfx

Fixes the clock-gating issue when pipe scaling is enabled.
(Lineage #2006604312)

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: Aditya Swarup <aditya.swarup@intel.com>
Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
---
 drivers/gpu/drm/i915/intel_display.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 61acbaf2af75..97344cca89c4 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -5193,9 +5193,17 @@ static int skl_update_scaler_plane(struct intel_crtc_state *crtc_state,
 static void skylake_scaler_disable(struct intel_crtc *crtc)
 {
 	int i;
+	struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
+	i915_reg_t reg = CLKGATE_DIS_PSL(crtc->pipe);
 
 	for (i = 0; i < crtc->num_scalers; i++)
 		skl_detach_scaler(crtc, i);
+
+	/*
+	 * Wa_2006604312:icl
+	 */
+	if (IS_ICELAKE(dev_priv))
+		I915_WRITE(reg, I915_READ(reg) & ~DPFR_GATING_DIS);
 }
 
 static void skylake_pfit_enable(const struct intel_crtc_state *crtc_state)
@@ -5205,6 +5213,7 @@ static void skylake_pfit_enable(const struct intel_crtc_state *crtc_state)
 	enum pipe pipe = crtc->pipe;
 	const struct intel_crtc_scaler_state *scaler_state =
 		&crtc_state->scaler_state;
+	i915_reg_t reg = CLKGATE_DIS_PSL(pipe);
 
 	if (crtc_state->pch_pfit.enabled) {
 		u16 uv_rgb_hphase, uv_rgb_vphase;
@@ -5232,6 +5241,12 @@ static void skylake_pfit_enable(const struct intel_crtc_state *crtc_state)
 			      PS_Y_PHASE(0) | PS_UV_RGB_PHASE(uv_rgb_hphase));
 		I915_WRITE(SKL_PS_WIN_POS(pipe, id), crtc_state->pch_pfit.pos);
 		I915_WRITE(SKL_PS_WIN_SZ(pipe, id), crtc_state->pch_pfit.size);
+
+		/*
+		 * Wa_2006604312:icl
+		*/
+		if (IS_ICELAKE(dev_priv))
+			I915_WRITE(reg, I915_READ(reg) | DPFR_GATING_DIS);
 	}
 }
 
@@ -5972,7 +5987,7 @@ static void haswell_crtc_enable(struct intel_crtc_state *pipe_config,
 
 	/* Display WA #1180: WaDisableScalarClockGating: glk, cnl */
 	psl_clkgate_wa = (IS_GEMINILAKE(dev_priv) || IS_CANNONLAKE(dev_priv)) &&
-			 pipe_config->pch_pfit.enabled;
+			  pipe_config->pch_pfit.enabled;
 	if (psl_clkgate_wa)
 		glk_pipe_scaler_clock_gating_wa(dev_priv, pipe, true);
 
-- 
2.20.0.rc2.7.g965798d1f299

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 43+ messages in thread
end of thread, other threads:[~2019-04-23 18:38 UTC | newest]

Thread overview: 43+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-15 22:18 [PATCH] drm/i915/icl: Fix clockgating issue when using scalars Radhakrishna Sripada
2019-03-15 22:23 ` Chris Wilson
2019-03-18 21:19   ` Sripada, Radhakrishna
2019-03-18 21:22     ` Chris Wilson
2019-03-18 22:37       ` Sripada, Radhakrishna
2019-03-15 23:10 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-03-16  7:07 ` ✓ Fi.CI.IGT: " Patchwork
2019-03-18 13:30 ` [PATCH] " Ville Syrjälä
2019-03-18 22:32   ` Sripada, Radhakrishna
2019-03-21  1:00 ` [PATCH v2] drm/i915/icl: Fix clockgating issue when using scalers Radhakrishna Sripada
2019-03-21  1:33 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/icl: Fix clockgating issue when using scalars (rev2) Patchwork
2019-03-21  2:07 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-03-21 21:44 ` [PATCH v3] drm/i915/icl: Fix clockgating issue when using scalers Radhakrishna Sripada
2019-03-22 13:14   ` Ville Syrjälä
2019-03-25 19:45     ` Sripada, Radhakrishna
2019-03-22  1:10 ` ✓ Fi.CI.BAT: success for drm/i915/icl: Fix clockgating issue when using scalars (rev3) Patchwork
2019-03-22 18:21 ` ✓ Fi.CI.IGT: " Patchwork
2019-03-28 17:35 ` [PATCH v4] drm/i915/icl: Fix clockgating issue when using scalers Radhakrishna Sripada
2019-03-29 18:39   ` Ville Syrjälä
2019-03-29 23:20     ` Sripada, Radhakrishna
2019-03-28 18:01 ` ✓ Fi.CI.BAT: success for drm/i915/icl: Fix clockgating issue when using scalars (rev4) Patchwork
2019-03-29  4:14 ` ✓ Fi.CI.IGT: " Patchwork
2019-03-30  1:19 ` [PATCH v5 1/3] drm/i915: Rename skl_wa_clkgating to the actual WA Radhakrishna Sripada
2019-03-30  1:19 ` [PATCH v5 2/3] drm/i915: Fix the inconsistent RMW in WA 827 Radhakrishna Sripada
2019-03-30  1:19 ` [PATCH v5 3/3] drm/i915/icl: Fix clockgating issue when using scalers Radhakrishna Sripada
2019-04-05 15:07   ` Ville Syrjälä
2019-04-05 21:14     ` [PATCH v6] " Radhakrishna Sripada
2019-04-11 21:41       ` Souza, Jose
2019-04-11 23:29         ` Sripada, Radhakrishna
2019-04-12  7:25       ` Ville Syrjälä
2019-04-15 22:55         ` [PATCH v7] " Radhakrishna Sripada
2019-04-16 14:14           ` Ville Syrjälä
2019-04-16 15:50             ` Sripada, Radhakrishna
2019-04-17 18:59             ` [PATCH v8] " Radhakrishna Sripada
2019-04-23 18:38               ` Ville Syrjälä
2019-03-30  2:16 ` ✓ Fi.CI.BAT: success for drm/i915/icl: Fix clockgating issue when using scalars (rev5) Patchwork
2019-03-30  5:55 ` ✓ Fi.CI.IGT: " Patchwork
2019-04-05 22:51 ` ✓ Fi.CI.BAT: success for drm/i915/icl: Fix clockgating issue when using scalars (rev6) Patchwork
2019-04-06 22:08 ` ✓ Fi.CI.IGT: " Patchwork
2019-04-16  0:13 ` ✓ Fi.CI.BAT: success for drm/i915/icl: Fix clockgating issue when using scalars (rev7) Patchwork
2019-04-16  1:11 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-04-17 19:46 ` ✓ Fi.CI.BAT: success for drm/i915/icl: Fix clockgating issue when using scalars (rev8) Patchwork
2019-04-18  3:31 ` ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.