All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: "Ramuthevar,Vadivel MuruganX" 
	<vadivel.muruganx.ramuthevar@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
	vigneshr@ti.com, mark.rutland@arm.com, robh+dt@kernel.org,
	devicetree@vger.kernel.org, dan.carpenter@oracle.com,
	cheol.yong.kim@intel.com, qi-ming.wu@intel.com
Subject: Re: [PATCH v9 1/2] dt-bindings: spi: Add schema for Cadence QSPI Controller driver
Date: Fri, 14 Feb 2020 14:08:44 +0000	[thread overview]
Message-ID: <20200214140844.GL4827@sirena.org.uk> (raw)
In-Reply-To: <20200214114618.29704-2-vadivel.muruganx.ramuthevar@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 660 bytes --]

On Fri, Feb 14, 2020 at 07:46:17PM +0800, Ramuthevar,Vadivel MuruganX wrote:

> +  - compatible : should be one of the following:
> +        Generic default - "cdns,qspi-nor".
> +        For TI 66AK2G SoC - "ti,k2g-qspi", "cdns,qspi-nor".
> +        For TI AM654 SoC  - "ti,am654-ospi", "cdns,qspi-nor".
> +        For Intel LGM SoC - "intel,lgm-qspi", "cdns,qspi-nor".

There are already existing bindings for several of these compatibles,
we should not be adding a second binding for something which already has
a binding but rather continuing to use the same binding.  This is the
whole point of documenting a binding that's separate to the implementation.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: "Ramuthevar,Vadivel MuruganX"
	<vadivel.muruganx.ramuthevar-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	vigneshr-l0cyMroinI0@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
	cheol.yong.kim-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	qi-ming.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH v9 1/2] dt-bindings: spi: Add schema for Cadence QSPI Controller driver
Date: Fri, 14 Feb 2020 14:08:44 +0000	[thread overview]
Message-ID: <20200214140844.GL4827@sirena.org.uk> (raw)
In-Reply-To: <20200214114618.29704-2-vadivel.muruganx.ramuthevar-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 660 bytes --]

On Fri, Feb 14, 2020 at 07:46:17PM +0800, Ramuthevar,Vadivel MuruganX wrote:

> +  - compatible : should be one of the following:
> +        Generic default - "cdns,qspi-nor".
> +        For TI 66AK2G SoC - "ti,k2g-qspi", "cdns,qspi-nor".
> +        For TI AM654 SoC  - "ti,am654-ospi", "cdns,qspi-nor".
> +        For Intel LGM SoC - "intel,lgm-qspi", "cdns,qspi-nor".

There are already existing bindings for several of these compatibles,
we should not be adding a second binding for something which already has
a binding but rather continuing to use the same binding.  This is the
whole point of documenting a binding that's separate to the implementation.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2020-02-14 14:08 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14 11:46 [PATCH v9 0/2] spi: cadence-quadpsi: Add support for the Cadence QSPI controller Ramuthevar,Vadivel MuruganX
2020-02-14 11:46 ` Ramuthevar,Vadivel MuruganX
2020-02-14 11:46 ` [PATCH v9 1/2] dt-bindings: spi: Add schema for Cadence QSPI Controller driver Ramuthevar,Vadivel MuruganX
2020-02-14 11:46   ` Ramuthevar,Vadivel MuruganX
2020-02-14 14:08   ` Mark Brown [this message]
2020-02-14 14:08     ` Mark Brown
2020-02-14 11:46 ` [PATCH v9 2/2] spi: cadence-quadpsi: Add support for the Cadence QSPI controller Ramuthevar,Vadivel MuruganX
2020-02-14 11:46   ` Ramuthevar,Vadivel MuruganX
2020-02-14 13:09   ` Mark Brown
2020-02-14 13:09     ` Mark Brown
2020-02-17  9:18     ` Ramuthevar, Vadivel MuruganX
2020-02-17  9:18       ` Ramuthevar, Vadivel MuruganX
2020-02-17 17:09       ` Mark Brown
2020-02-17 17:09         ` Mark Brown
2020-02-18  3:17         ` Ramuthevar, Vadivel MuruganX
2020-02-18  3:17           ` Ramuthevar, Vadivel MuruganX
2020-02-14 12:02 ` [PATCH v9 0/2] " Simon Goldschmidt
2020-02-14 12:02   ` Simon Goldschmidt
2020-02-14 12:11   ` Mark Brown
2020-02-14 12:11     ` Mark Brown
2020-02-14 12:50     ` Simon Goldschmidt
2020-02-14 12:50       ` Simon Goldschmidt
2020-02-14 13:15       ` Mark Brown
2020-02-14 13:15         ` Mark Brown
2020-02-14 13:49         ` Simon Goldschmidt
2020-02-14 13:49           ` Simon Goldschmidt
2020-02-14 14:16           ` Mark Brown
2020-02-14 14:16             ` Mark Brown
2020-02-17 10:09     ` Ramuthevar, Vadivel MuruganX
2020-02-17 10:09       ` Ramuthevar, Vadivel MuruganX
     [not found]     ` <4712cdc4-34cd-990b-3d53-3d394ae1250b@linux.intel.com>
2020-02-17 11:52       ` Mark Brown
2020-02-17 11:52         ` Mark Brown
2020-02-17 12:18         ` Vignesh Raghavendra
2020-02-17 12:18           ` Vignesh Raghavendra
2020-02-18  8:56           ` Ramuthevar, Vadivel MuruganX
2020-02-18  8:56             ` Ramuthevar, Vadivel MuruganX
2020-02-17 10:11   ` Ramuthevar, Vadivel MuruganX
2020-02-17 10:11     ` Ramuthevar, Vadivel MuruganX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200214140844.GL4827@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=cheol.yong.kim@intel.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=qi-ming.wu@intel.com \
    --cc=robh+dt@kernel.org \
    --cc=vadivel.muruganx.ramuthevar@linux.intel.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.