From: Mark Brown <broonie@kernel.org>
To: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
Cc: "Ramuthevar,Vadivel MuruganX"
<vadivel.muruganx.ramuthevar@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-spi@vger.kernel.org, Vignesh R <vigneshr@ti.com>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
dan.carpenter@oracle.com, cheol.yong.kim@intel.com,
qi-ming.wu@intel.com
Subject: Re: [PATCH v9 0/2] spi: cadence-quadpsi: Add support for the Cadence QSPI controller
Date: Fri, 14 Feb 2020 14:16:45 +0000 [thread overview]
Message-ID: <20200214141645.GM4827@sirena.org.uk> (raw)
In-Reply-To: <CAAh8qswA0TLY73URB8eUYm+nFK9q08Ep4wamz3rAE_5g3fd51g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1512 bytes --]
On Fri, Feb 14, 2020 at 02:49:48PM +0100, Simon Goldschmidt wrote:
> On Fri, Feb 14, 2020 at 2:15 PM Mark Brown <broonie@kernel.org> wrote:
> > I'm not seeing anything in the driver that removes whatever the current
> > support is? Unless it's just adding a duplicate driver for the same
> > compatible strings which is obviously a bad idea but at least means that
> > unless people enable the driver there's no risk of it colliding with the
> > existing one.
> It does add a duplicate driver for the same compatible strings. The current
> working driver is in 'drivers/mtd/spi-nor/cadence-quadspi.c'.
> In fact, the compatible string "cdns,qspi-nor" copied from the old driver to
> this new driver is *only* used for altera. TI has its own compatible string,
> the new Intel platform adds its own as well.
Oh, that's not good - it's adding a completely new binding for the same
compatibles which isn't OK. We can transition to a new driver using the
same binding but we should be keeping the old binding. If we're moving
the binding document around and/or transitioning to YAML that needs to
be done explicitly rather than adding a new document for the same
compatible.
> As long as that one doesn't get removed, I have nothing against this driver
> here. I'm only concerned that this will get forgotten. And given that I added
> altera guys to the loop in one of the previous versions, I just was surprised
> they aren't on CC in this version.
Yes, like I say it'd be much better to get their review.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Simon Goldschmidt
<simon.k.r.goldschmidt-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "Ramuthevar,Vadivel MuruganX"
<vadivel.muruganx.ramuthevar-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Vignesh R <vigneshr-l0cyMroinI0@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
cheol.yong.kim-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
qi-ming.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH v9 0/2] spi: cadence-quadpsi: Add support for the Cadence QSPI controller
Date: Fri, 14 Feb 2020 14:16:45 +0000 [thread overview]
Message-ID: <20200214141645.GM4827@sirena.org.uk> (raw)
In-Reply-To: <CAAh8qswA0TLY73URB8eUYm+nFK9q08Ep4wamz3rAE_5g3fd51g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1541 bytes --]
On Fri, Feb 14, 2020 at 02:49:48PM +0100, Simon Goldschmidt wrote:
> On Fri, Feb 14, 2020 at 2:15 PM Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> > I'm not seeing anything in the driver that removes whatever the current
> > support is? Unless it's just adding a duplicate driver for the same
> > compatible strings which is obviously a bad idea but at least means that
> > unless people enable the driver there's no risk of it colliding with the
> > existing one.
> It does add a duplicate driver for the same compatible strings. The current
> working driver is in 'drivers/mtd/spi-nor/cadence-quadspi.c'.
> In fact, the compatible string "cdns,qspi-nor" copied from the old driver to
> this new driver is *only* used for altera. TI has its own compatible string,
> the new Intel platform adds its own as well.
Oh, that's not good - it's adding a completely new binding for the same
compatibles which isn't OK. We can transition to a new driver using the
same binding but we should be keeping the old binding. If we're moving
the binding document around and/or transitioning to YAML that needs to
be done explicitly rather than adding a new document for the same
compatible.
> As long as that one doesn't get removed, I have nothing against this driver
> here. I'm only concerned that this will get forgotten. And given that I added
> altera guys to the loop in one of the previous versions, I just was surprised
> they aren't on CC in this version.
Yes, like I say it'd be much better to get their review.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-14 14:16 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 11:46 [PATCH v9 0/2] spi: cadence-quadpsi: Add support for the Cadence QSPI controller Ramuthevar,Vadivel MuruganX
2020-02-14 11:46 ` Ramuthevar,Vadivel MuruganX
2020-02-14 11:46 ` [PATCH v9 1/2] dt-bindings: spi: Add schema for Cadence QSPI Controller driver Ramuthevar,Vadivel MuruganX
2020-02-14 11:46 ` Ramuthevar,Vadivel MuruganX
2020-02-14 14:08 ` Mark Brown
2020-02-14 14:08 ` Mark Brown
2020-02-14 11:46 ` [PATCH v9 2/2] spi: cadence-quadpsi: Add support for the Cadence QSPI controller Ramuthevar,Vadivel MuruganX
2020-02-14 11:46 ` Ramuthevar,Vadivel MuruganX
2020-02-14 13:09 ` Mark Brown
2020-02-14 13:09 ` Mark Brown
2020-02-17 9:18 ` Ramuthevar, Vadivel MuruganX
2020-02-17 9:18 ` Ramuthevar, Vadivel MuruganX
2020-02-17 17:09 ` Mark Brown
2020-02-17 17:09 ` Mark Brown
2020-02-18 3:17 ` Ramuthevar, Vadivel MuruganX
2020-02-18 3:17 ` Ramuthevar, Vadivel MuruganX
2020-02-14 12:02 ` [PATCH v9 0/2] " Simon Goldschmidt
2020-02-14 12:02 ` Simon Goldschmidt
2020-02-14 12:11 ` Mark Brown
2020-02-14 12:11 ` Mark Brown
2020-02-14 12:50 ` Simon Goldschmidt
2020-02-14 12:50 ` Simon Goldschmidt
2020-02-14 13:15 ` Mark Brown
2020-02-14 13:15 ` Mark Brown
2020-02-14 13:49 ` Simon Goldschmidt
2020-02-14 13:49 ` Simon Goldschmidt
2020-02-14 14:16 ` Mark Brown [this message]
2020-02-14 14:16 ` Mark Brown
2020-02-17 10:09 ` Ramuthevar, Vadivel MuruganX
2020-02-17 10:09 ` Ramuthevar, Vadivel MuruganX
[not found] ` <4712cdc4-34cd-990b-3d53-3d394ae1250b@linux.intel.com>
2020-02-17 11:52 ` Mark Brown
2020-02-17 11:52 ` Mark Brown
2020-02-17 12:18 ` Vignesh Raghavendra
2020-02-17 12:18 ` Vignesh Raghavendra
2020-02-18 8:56 ` Ramuthevar, Vadivel MuruganX
2020-02-18 8:56 ` Ramuthevar, Vadivel MuruganX
2020-02-17 10:11 ` Ramuthevar, Vadivel MuruganX
2020-02-17 10:11 ` Ramuthevar, Vadivel MuruganX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214141645.GM4827@sirena.org.uk \
--to=broonie@kernel.org \
--cc=cheol.yong.kim@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=qi-ming.wu@intel.com \
--cc=robh+dt@kernel.org \
--cc=simon.k.r.goldschmidt@gmail.com \
--cc=vadivel.muruganx.ramuthevar@linux.intel.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.