All of lore.kernel.org
 help / color / mirror / Atom feed
From: Han Xu <xhnjupt@gmail.com>
To: Yunhui Cui <B56489@freescale.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	"han.xu@freescale.com" <han.xu@freescale.com>,
	jagannadh.teki@gmail.com, Yunhui Cui <yunhui.cui@nxp.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, Yao Yuan <yao.yuan@nxp.com>
Subject: Re: [PATCH v3 9/9] mtd: fsl-quadspi: add multi flash chip R/W on ls2080a
Date: Wed, 14 Sep 2016 14:49:23 -0500	[thread overview]
Message-ID: <CA+EcR20QhaN1LmNTcHVnCaPf=F3m=PDHdM+ptViMWKmUJJeOOQ@mail.gmail.com> (raw)
In-Reply-To: <1471505884-33996-9-git-send-email-B56489@freescale.com>

On Thu, Aug 18, 2016 at 2:38 AM, Yunhui Cui <B56489@freescale.com> wrote:
> From: Yunhui Cui <yunhui.cui@nxp.com>
>
> There is a hardware feature that qspi_amba_base is added
> internally by SOC design on ls2080a. so memmap_phy need not
> be added in driver. If memmap_phy is added, the flash A1
> addr space is [0, memmap_phy] which far more than flash size.
> The AMBA memory will be divided into four parts and assign to
> every chipselect. Every channel will has two valid chipselects.
>
> Signed-off-by: Yunhui Cui <yunhui.cui@nxp.com>
> ---
>  drivers/mtd/spi-nor/fsl-quadspi.c | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
> index 193e81b..8c9746c 100644
> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
> @@ -736,11 +736,17 @@ static void fsl_qspi_set_map_addr(struct fsl_qspi *q)
>  {
>         int nor_size = q->nor_size;
>         void __iomem *base = q->iobase;
> +       u32 mem_base;
>
> -       qspi_writel(q, nor_size + q->memmap_phy, base + QUADSPI_SFA1AD);
> -       qspi_writel(q, nor_size * 2 + q->memmap_phy, base + QUADSPI_SFA2AD);
> -       qspi_writel(q, nor_size * 3 + q->memmap_phy, base + QUADSPI_SFB1AD);
> -       qspi_writel(q, nor_size * 4 + q->memmap_phy, base + QUADSPI_SFB2AD);
> +       if (has_added_amba_base_internal(q))
> +               mem_base = 0x0;
> +       else
> +               mem_base = q->memmap_phy;
> +
> +       qspi_writel(q, nor_size + mem_base, base + QUADSPI_SFA1AD);
> +       qspi_writel(q, nor_size * 2 + mem_base, base + QUADSPI_SFA2AD);
> +       qspi_writel(q, nor_size * 3 + mem_base, base + QUADSPI_SFB1AD);
> +       qspi_writel(q, nor_size * 4 + mem_base, base + QUADSPI_SFB2AD);
>  }
>
>  /*
> --
> 2.1.0.27.g96db324
>
>
Acked-by: Han xu <han.xu@nxp.com>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/



-- 
Sincerely,

Han XU

WARNING: multiple messages have this Message-ID (diff)
From: xhnjupt@gmail.com (Han Xu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 9/9] mtd: fsl-quadspi: add multi flash chip R/W on ls2080a
Date: Wed, 14 Sep 2016 14:49:23 -0500	[thread overview]
Message-ID: <CA+EcR20QhaN1LmNTcHVnCaPf=F3m=PDHdM+ptViMWKmUJJeOOQ@mail.gmail.com> (raw)
In-Reply-To: <1471505884-33996-9-git-send-email-B56489@freescale.com>

On Thu, Aug 18, 2016 at 2:38 AM, Yunhui Cui <B56489@freescale.com> wrote:
> From: Yunhui Cui <yunhui.cui@nxp.com>
>
> There is a hardware feature that qspi_amba_base is added
> internally by SOC design on ls2080a. so memmap_phy need not
> be added in driver. If memmap_phy is added, the flash A1
> addr space is [0, memmap_phy] which far more than flash size.
> The AMBA memory will be divided into four parts and assign to
> every chipselect. Every channel will has two valid chipselects.
>
> Signed-off-by: Yunhui Cui <yunhui.cui@nxp.com>
> ---
>  drivers/mtd/spi-nor/fsl-quadspi.c | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
> index 193e81b..8c9746c 100644
> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
> @@ -736,11 +736,17 @@ static void fsl_qspi_set_map_addr(struct fsl_qspi *q)
>  {
>         int nor_size = q->nor_size;
>         void __iomem *base = q->iobase;
> +       u32 mem_base;
>
> -       qspi_writel(q, nor_size + q->memmap_phy, base + QUADSPI_SFA1AD);
> -       qspi_writel(q, nor_size * 2 + q->memmap_phy, base + QUADSPI_SFA2AD);
> -       qspi_writel(q, nor_size * 3 + q->memmap_phy, base + QUADSPI_SFB1AD);
> -       qspi_writel(q, nor_size * 4 + q->memmap_phy, base + QUADSPI_SFB2AD);
> +       if (has_added_amba_base_internal(q))
> +               mem_base = 0x0;
> +       else
> +               mem_base = q->memmap_phy;
> +
> +       qspi_writel(q, nor_size + mem_base, base + QUADSPI_SFA1AD);
> +       qspi_writel(q, nor_size * 2 + mem_base, base + QUADSPI_SFA2AD);
> +       qspi_writel(q, nor_size * 3 + mem_base, base + QUADSPI_SFB1AD);
> +       qspi_writel(q, nor_size * 4 + mem_base, base + QUADSPI_SFB2AD);
>  }
>
>  /*
> --
> 2.1.0.27.g96db324
>
>
Acked-by: Han xu <han.xu@nxp.com>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/



-- 
Sincerely,

Han XU

  reply	other threads:[~2016-09-14 19:49 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-18  7:37 [PATCH v3 1/9] mtd:fsl-quadspi:use the property fields of SPI-NOR Yunhui Cui
2016-08-18  7:37 ` Yunhui Cui
2016-08-18  7:37 ` [PATCH v3 2/9] mtd: fsl-quadspi: Rename SEQID_QUAD_READ to SEQID_READ Yunhui Cui
2016-08-18  7:37   ` Yunhui Cui
2016-09-14 19:44   ` Han Xu
2016-09-14 19:44     ` Han Xu
2017-01-27 10:35   ` Cyrille Pitchen
2017-01-27 10:35     ` Cyrille Pitchen
2016-08-18  7:37 ` [PATCH v3 3/9] mtd: spi-nor: fsl-quadspi: add fast-read mode support Yunhui Cui
2016-08-18  7:37   ` Yunhui Cui
2016-09-14 19:45   ` Han Xu
2016-09-14 19:45     ` Han Xu
2016-08-18  7:37 ` [PATCH v3 4/9] mtd: spi-nor: fsl-quadspi: extend support for some special requerment Yunhui Cui
2016-08-18  7:37   ` Yunhui Cui
2016-09-14 19:45   ` Han Xu
2016-09-14 19:45     ` Han Xu
2016-08-18  7:38 ` [PATCH v3 5/9] mtd: spi-nor: fsl-quadspi:Support qspi for ls2080a Yunhui Cui
2016-08-18  7:38   ` Yunhui Cui
2016-09-14 19:46   ` Han Xu
2016-09-14 19:46     ` Han Xu
2016-08-18  7:38 ` [PATCH v3 6/9] mtd: spi-nor: Support R/W for S25FS-S family flash Yunhui Cui
2016-08-18  7:38   ` Yunhui Cui
2016-09-14 19:48   ` Han Xu
2016-09-14 19:48     ` Han Xu
2016-09-15  6:50     ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-09-15  6:50       ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-09-15  6:50       ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-11-16 17:10       ` Han Xu
2016-11-16 17:10         ` Han Xu
2016-11-16 17:10         ` Han Xu
2016-11-17  7:42         ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-11-17  7:42           ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-11-17  7:42           ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-11-17  9:14           ` Yao Yuan
2016-11-17  9:14             ` Yao Yuan
2016-11-17  9:14             ` Yao Yuan
2016-11-17  9:20             ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-11-17  9:20               ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-11-17  9:20               ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-11-18  4:19               ` Yao Yuan
2016-11-18  4:19                 ` Yao Yuan
2016-11-18  4:19                 ` Yao Yuan
2016-11-18 10:59                 ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-11-18 10:59                   ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-11-18 10:59                   ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-11-21  6:27                   ` Yao Yuan
2016-11-21  6:27                     ` Yao Yuan
2016-11-21  6:27                     ` Yao Yuan
2016-11-21  7:14                     ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-11-21  7:14                       ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-11-21  7:14                       ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-11-21  9:18                       ` Yao Yuan
2016-11-21  9:18                         ` Yao Yuan
2016-11-21  9:18                         ` Yao Yuan
2016-11-18  4:30             ` Han Xu
2016-11-18  4:30               ` Han Xu
2016-11-18  4:30               ` Han Xu
2016-11-21  6:30               ` Yao Yuan
2016-11-21  6:30                 ` Yao Yuan
2016-11-21  6:30                 ` Yao Yuan
2016-11-16 17:44   ` Jagan Teki
2016-11-16 17:44     ` Jagan Teki
2016-11-16 17:44     ` Jagan Teki
2016-08-18  7:38 ` [PATCH v3 7/9] mtd: fsl-quadspi: Solve Micron Spansion flash command conflict Yunhui Cui
2016-08-18  7:38   ` Yunhui Cui
2016-09-14 19:48   ` Han Xu
2016-09-14 19:48     ` Han Xu
2016-08-18  7:38 ` [PATCH v3 8/9] mtd: fsl-quadspi: disable AHB buffer prefetch Yunhui Cui
2016-08-18  7:38   ` Yunhui Cui
2016-09-14 19:49   ` Han Xu
2016-09-14 19:49     ` Han Xu
2016-08-18  7:38 ` [PATCH v3 9/9] mtd: fsl-quadspi: add multi flash chip R/W on ls2080a Yunhui Cui
2016-08-18  7:38   ` Yunhui Cui
2016-09-14 19:49   ` Han Xu [this message]
2016-09-14 19:49     ` Han Xu
2016-09-14 19:44 ` [PATCH v3 1/9] mtd:fsl-quadspi:use the property fields of SPI-NOR Han Xu
2016-09-14 19:44   ` Han Xu
2016-09-30 10:04 ` Cyrille Pitchen
2016-09-30 10:04   ` Cyrille Pitchen
2017-01-27 10:27 ` Cyrille Pitchen
2017-01-27 10:27   ` Cyrille Pitchen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+EcR20QhaN1LmNTcHVnCaPf=F3m=PDHdM+ptViMWKmUJJeOOQ@mail.gmail.com' \
    --to=xhnjupt@gmail.com \
    --cc=B56489@freescale.com \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=han.xu@freescale.com \
    --cc=jagannadh.teki@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=yao.yuan@nxp.com \
    --cc=yunhui.cui@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.