All of lore.kernel.org
 help / color / mirror / Atom feed
From: Han Xu <xhnjupt@gmail.com>
To: Yunhui Cui <B56489@freescale.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	"han.xu@freescale.com" <han.xu@freescale.com>,
	jagannadh.teki@gmail.com, Yunhui Cui <yunhui.cui@nxp.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, Yao Yuan <yao.yuan@nxp.com>
Subject: Re: [PATCH v3 3/9] mtd: spi-nor: fsl-quadspi: add fast-read mode support
Date: Wed, 14 Sep 2016 14:45:09 -0500	[thread overview]
Message-ID: <CA+EcR21waWzcPpXvBwBoB7StEQO-iWLcf9P978GuKR0PH2nzxQ@mail.gmail.com> (raw)
In-Reply-To: <1471505884-33996-3-git-send-email-B56489@freescale.com>

On Thu, Aug 18, 2016 at 2:37 AM, Yunhui Cui <B56489@freescale.com> wrote:
> From: Yunhui Cui <yunhui.cui@nxp.com>
>
> The qspi driver add generic fast-read mode for different
> flash venders. There are some different board flash work on
> different mode, such fast-read, quad-mode.
>
> Signed-off-by: Yunhui Cui <yunhui.cui@nxp.com>
> ---
>  drivers/mtd/spi-nor/fsl-quadspi.c | 21 ++++++++++++++++-----
>  1 file changed, 16 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
> index 21c77e8..b0a74b8 100644
> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
> @@ -389,11 +389,21 @@ static void fsl_qspi_init_lut(struct fsl_qspi *q)
>         /* Read */
>         lut_base = SEQID_READ * 4;
>
> -       qspi_writel(q, LUT0(CMD, PAD1, read_op) | LUT1(ADDR, PAD1, addrlen),
> -                       base + QUADSPI_LUT(lut_base));
> -       qspi_writel(q, LUT0(DUMMY, PAD1, read_dm) |
> -                   LUT1(FSL_READ, PAD4, rxfifo),
> -                       base + QUADSPI_LUT(lut_base + 1));
> +       if (nor->flash_read == SPI_NOR_FAST) {
> +               qspi_writel(q, LUT0(CMD, PAD1, read_op) |
> +                           LUT1(ADDR, PAD1, addrlen),
> +                               base + QUADSPI_LUT(lut_base));
> +               qspi_writel(q,  LUT0(DUMMY, PAD1, read_dm) |
> +                           LUT1(FSL_READ, PAD1, rxfifo),
> +                               base + QUADSPI_LUT(lut_base + 1));
> +       } else if (nor->flash_read == SPI_NOR_QUAD) {
> +               qspi_writel(q, LUT0(CMD, PAD1, read_op) |
> +                           LUT1(ADDR, PAD1, addrlen),
> +                               base + QUADSPI_LUT(lut_base));
> +               qspi_writel(q, LUT0(DUMMY, PAD1, read_dm) |
> +                           LUT1(FSL_READ, PAD4, rxfifo),
> +                               base + QUADSPI_LUT(lut_base + 1));
> +       }
>
>         /* Write enable */
>         lut_base = SEQID_WREN * 4;
> @@ -468,6 +478,7 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd)
>  {
>         switch (cmd) {
>         case SPINOR_OP_READ_1_1_4:
> +       case SPINOR_OP_READ_FAST:
>                 return SEQID_READ;
>         case SPINOR_OP_WREN:
>                 return SEQID_WREN;
> --
> 2.1.0.27.g96db324
>
>
Acked-by: Han xu <han.xu@nxp.com>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/



-- 
Sincerely,

Han XU

WARNING: multiple messages have this Message-ID (diff)
From: xhnjupt@gmail.com (Han Xu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/9] mtd: spi-nor: fsl-quadspi: add fast-read mode support
Date: Wed, 14 Sep 2016 14:45:09 -0500	[thread overview]
Message-ID: <CA+EcR21waWzcPpXvBwBoB7StEQO-iWLcf9P978GuKR0PH2nzxQ@mail.gmail.com> (raw)
In-Reply-To: <1471505884-33996-3-git-send-email-B56489@freescale.com>

On Thu, Aug 18, 2016 at 2:37 AM, Yunhui Cui <B56489@freescale.com> wrote:
> From: Yunhui Cui <yunhui.cui@nxp.com>
>
> The qspi driver add generic fast-read mode for different
> flash venders. There are some different board flash work on
> different mode, such fast-read, quad-mode.
>
> Signed-off-by: Yunhui Cui <yunhui.cui@nxp.com>
> ---
>  drivers/mtd/spi-nor/fsl-quadspi.c | 21 ++++++++++++++++-----
>  1 file changed, 16 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
> index 21c77e8..b0a74b8 100644
> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
> @@ -389,11 +389,21 @@ static void fsl_qspi_init_lut(struct fsl_qspi *q)
>         /* Read */
>         lut_base = SEQID_READ * 4;
>
> -       qspi_writel(q, LUT0(CMD, PAD1, read_op) | LUT1(ADDR, PAD1, addrlen),
> -                       base + QUADSPI_LUT(lut_base));
> -       qspi_writel(q, LUT0(DUMMY, PAD1, read_dm) |
> -                   LUT1(FSL_READ, PAD4, rxfifo),
> -                       base + QUADSPI_LUT(lut_base + 1));
> +       if (nor->flash_read == SPI_NOR_FAST) {
> +               qspi_writel(q, LUT0(CMD, PAD1, read_op) |
> +                           LUT1(ADDR, PAD1, addrlen),
> +                               base + QUADSPI_LUT(lut_base));
> +               qspi_writel(q,  LUT0(DUMMY, PAD1, read_dm) |
> +                           LUT1(FSL_READ, PAD1, rxfifo),
> +                               base + QUADSPI_LUT(lut_base + 1));
> +       } else if (nor->flash_read == SPI_NOR_QUAD) {
> +               qspi_writel(q, LUT0(CMD, PAD1, read_op) |
> +                           LUT1(ADDR, PAD1, addrlen),
> +                               base + QUADSPI_LUT(lut_base));
> +               qspi_writel(q, LUT0(DUMMY, PAD1, read_dm) |
> +                           LUT1(FSL_READ, PAD4, rxfifo),
> +                               base + QUADSPI_LUT(lut_base + 1));
> +       }
>
>         /* Write enable */
>         lut_base = SEQID_WREN * 4;
> @@ -468,6 +478,7 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd)
>  {
>         switch (cmd) {
>         case SPINOR_OP_READ_1_1_4:
> +       case SPINOR_OP_READ_FAST:
>                 return SEQID_READ;
>         case SPINOR_OP_WREN:
>                 return SEQID_WREN;
> --
> 2.1.0.27.g96db324
>
>
Acked-by: Han xu <han.xu@nxp.com>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/



-- 
Sincerely,

Han XU

  reply	other threads:[~2016-09-14 19:45 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-18  7:37 [PATCH v3 1/9] mtd:fsl-quadspi:use the property fields of SPI-NOR Yunhui Cui
2016-08-18  7:37 ` Yunhui Cui
2016-08-18  7:37 ` [PATCH v3 2/9] mtd: fsl-quadspi: Rename SEQID_QUAD_READ to SEQID_READ Yunhui Cui
2016-08-18  7:37   ` Yunhui Cui
2016-09-14 19:44   ` Han Xu
2016-09-14 19:44     ` Han Xu
2017-01-27 10:35   ` Cyrille Pitchen
2017-01-27 10:35     ` Cyrille Pitchen
2016-08-18  7:37 ` [PATCH v3 3/9] mtd: spi-nor: fsl-quadspi: add fast-read mode support Yunhui Cui
2016-08-18  7:37   ` Yunhui Cui
2016-09-14 19:45   ` Han Xu [this message]
2016-09-14 19:45     ` Han Xu
2016-08-18  7:37 ` [PATCH v3 4/9] mtd: spi-nor: fsl-quadspi: extend support for some special requerment Yunhui Cui
2016-08-18  7:37   ` Yunhui Cui
2016-09-14 19:45   ` Han Xu
2016-09-14 19:45     ` Han Xu
2016-08-18  7:38 ` [PATCH v3 5/9] mtd: spi-nor: fsl-quadspi:Support qspi for ls2080a Yunhui Cui
2016-08-18  7:38   ` Yunhui Cui
2016-09-14 19:46   ` Han Xu
2016-09-14 19:46     ` Han Xu
2016-08-18  7:38 ` [PATCH v3 6/9] mtd: spi-nor: Support R/W for S25FS-S family flash Yunhui Cui
2016-08-18  7:38   ` Yunhui Cui
2016-09-14 19:48   ` Han Xu
2016-09-14 19:48     ` Han Xu
2016-09-15  6:50     ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-09-15  6:50       ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-09-15  6:50       ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-11-16 17:10       ` Han Xu
2016-11-16 17:10         ` Han Xu
2016-11-16 17:10         ` Han Xu
2016-11-17  7:42         ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-11-17  7:42           ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-11-17  7:42           ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-11-17  9:14           ` Yao Yuan
2016-11-17  9:14             ` Yao Yuan
2016-11-17  9:14             ` Yao Yuan
2016-11-17  9:20             ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-11-17  9:20               ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-11-17  9:20               ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-11-18  4:19               ` Yao Yuan
2016-11-18  4:19                 ` Yao Yuan
2016-11-18  4:19                 ` Yao Yuan
2016-11-18 10:59                 ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-11-18 10:59                   ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-11-18 10:59                   ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-11-21  6:27                   ` Yao Yuan
2016-11-21  6:27                     ` Yao Yuan
2016-11-21  6:27                     ` Yao Yuan
2016-11-21  7:14                     ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-11-21  7:14                       ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-11-21  7:14                       ` Krzeminski, Marcin (Nokia - PL/Wroclaw)
2016-11-21  9:18                       ` Yao Yuan
2016-11-21  9:18                         ` Yao Yuan
2016-11-21  9:18                         ` Yao Yuan
2016-11-18  4:30             ` Han Xu
2016-11-18  4:30               ` Han Xu
2016-11-18  4:30               ` Han Xu
2016-11-21  6:30               ` Yao Yuan
2016-11-21  6:30                 ` Yao Yuan
2016-11-21  6:30                 ` Yao Yuan
2016-11-16 17:44   ` Jagan Teki
2016-11-16 17:44     ` Jagan Teki
2016-11-16 17:44     ` Jagan Teki
2016-08-18  7:38 ` [PATCH v3 7/9] mtd: fsl-quadspi: Solve Micron Spansion flash command conflict Yunhui Cui
2016-08-18  7:38   ` Yunhui Cui
2016-09-14 19:48   ` Han Xu
2016-09-14 19:48     ` Han Xu
2016-08-18  7:38 ` [PATCH v3 8/9] mtd: fsl-quadspi: disable AHB buffer prefetch Yunhui Cui
2016-08-18  7:38   ` Yunhui Cui
2016-09-14 19:49   ` Han Xu
2016-09-14 19:49     ` Han Xu
2016-08-18  7:38 ` [PATCH v3 9/9] mtd: fsl-quadspi: add multi flash chip R/W on ls2080a Yunhui Cui
2016-08-18  7:38   ` Yunhui Cui
2016-09-14 19:49   ` Han Xu
2016-09-14 19:49     ` Han Xu
2016-09-14 19:44 ` [PATCH v3 1/9] mtd:fsl-quadspi:use the property fields of SPI-NOR Han Xu
2016-09-14 19:44   ` Han Xu
2016-09-30 10:04 ` Cyrille Pitchen
2016-09-30 10:04   ` Cyrille Pitchen
2017-01-27 10:27 ` Cyrille Pitchen
2017-01-27 10:27   ` Cyrille Pitchen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+EcR21waWzcPpXvBwBoB7StEQO-iWLcf9P978GuKR0PH2nzxQ@mail.gmail.com \
    --to=xhnjupt@gmail.com \
    --cc=B56489@freescale.com \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=han.xu@freescale.com \
    --cc=jagannadh.teki@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=yao.yuan@nxp.com \
    --cc=yunhui.cui@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.