From: Chen-Yu Tsai <wens@csie.org>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: Quentin Schulz <quentin.schulz@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Jonathan Cameron <jic23@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-iio@vger.kernel.org,
linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [linux-sunxi] Re: [RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in AXP803 DTSI
Date: Mon, 25 Sep 2017 17:19:07 +0800 [thread overview]
Message-ID: <CAGb2v64rBQ33aqhPSksBB88GGQTJsPyeebD0ixT=ehBYA5tSEA@mail.gmail.com> (raw)
In-Reply-To: <D7CAB179-F2AF-434F-82F7-07F146842FCF@aosc.io>
On Mon, Sep 25, 2017 at 5:14 PM, Icenowy Zheng <icenowy@aosc.io> wrote:
>
>
> 于 2017年9月25日 GMT+08:00 下午5:11:57, Quentin Schulz <quentin.schulz@free-electrons.com> 写到:
>>Hi Icenowy,
>>
>>On 20/09/2017 17:18, Icenowy Zheng wrote:
>>> AXP803 PMIC features AC/USB/Battery power supplies.
>>>
>>> As we have now the device tree bindings for them, add device tree
>>> nodes for them.
>>>
>>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>>> ---
>>> arch/arm64/boot/dts/allwinner/axp803.dtsi | 15 +++++++++++++++
>>> 1 file changed, 15 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/allwinner/axp803.dtsi
>>b/arch/arm64/boot/dts/allwinner/axp803.dtsi
>>> index ff8af52743ff..3a8615231b7c 100644
>>> --- a/arch/arm64/boot/dts/allwinner/axp803.dtsi
>>> +++ b/arch/arm64/boot/dts/allwinner/axp803.dtsi
>>> @@ -49,6 +49,16 @@
>>> interrupt-controller;
>>> #interrupt-cells = <1>;
>>>
>>> + ac_power_supply: ac-power-supply {
>>> + compatible = "x-powers,axp221-ac-power-supply";
>>> + status = "disabled";
>>> + };
>>> +
>>> + battery_power_supply: battery-power-supply {
>>> + compatible = "x-powers,axp803-battery-power-supply";
>>> + status = "disabled";
>>> + };
>>> +
>>> regulators {
>>> /* Default work frequency for buck regulators */
>>> x-powers,dcdc-freq = <3000>;
>>> @@ -147,4 +157,9 @@
>>> regulator-name = "rtc-ldo";
>>> };
>>> };
>>> +
>>> + usb_power_supply: usb_power_supply {
>>> + compatible = "x-powers,axp803-usb-power-supply";
>>> + status = "disabled";
>>> + };
>>
>>No. You have added support for the AC and battery power supply drivers
>>in this patchset, not for USB.
>
> But I added its device tree binding.
Please do both at the same time. If you only add the binding without
the driver, how can you be sure the binding would be a proper fit?
Moreover, no one can actually test it.
ChenYu
WARNING: multiple messages have this Message-ID
From: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
To: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
Cc: Quentin Schulz
<quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"open list:THERMAL"
<linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-arm-kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
Subject: Re: Re: [RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in AXP803 DTSI
Date: Mon, 25 Sep 2017 17:19:07 +0800 [thread overview]
Message-ID: <CAGb2v64rBQ33aqhPSksBB88GGQTJsPyeebD0ixT=ehBYA5tSEA@mail.gmail.com> (raw)
In-Reply-To: <D7CAB179-F2AF-434F-82F7-07F146842FCF-h8G6r0blFSE@public.gmane.org>
On Mon, Sep 25, 2017 at 5:14 PM, Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org> wrote:
>
>
> 于 2017年9月25日 GMT+08:00 下午5:11:57, Quentin Schulz <quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 写到:
>>Hi Icenowy,
>>
>>On 20/09/2017 17:18, Icenowy Zheng wrote:
>>> AXP803 PMIC features AC/USB/Battery power supplies.
>>>
>>> As we have now the device tree bindings for them, add device tree
>>> nodes for them.
>>>
>>> Signed-off-by: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
>>> ---
>>> arch/arm64/boot/dts/allwinner/axp803.dtsi | 15 +++++++++++++++
>>> 1 file changed, 15 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/allwinner/axp803.dtsi
>>b/arch/arm64/boot/dts/allwinner/axp803.dtsi
>>> index ff8af52743ff..3a8615231b7c 100644
>>> --- a/arch/arm64/boot/dts/allwinner/axp803.dtsi
>>> +++ b/arch/arm64/boot/dts/allwinner/axp803.dtsi
>>> @@ -49,6 +49,16 @@
>>> interrupt-controller;
>>> #interrupt-cells = <1>;
>>>
>>> + ac_power_supply: ac-power-supply {
>>> + compatible = "x-powers,axp221-ac-power-supply";
>>> + status = "disabled";
>>> + };
>>> +
>>> + battery_power_supply: battery-power-supply {
>>> + compatible = "x-powers,axp803-battery-power-supply";
>>> + status = "disabled";
>>> + };
>>> +
>>> regulators {
>>> /* Default work frequency for buck regulators */
>>> x-powers,dcdc-freq = <3000>;
>>> @@ -147,4 +157,9 @@
>>> regulator-name = "rtc-ldo";
>>> };
>>> };
>>> +
>>> + usb_power_supply: usb_power_supply {
>>> + compatible = "x-powers,axp803-usb-power-supply";
>>> + status = "disabled";
>>> + };
>>
>>No. You have added support for the AC and battery power supply drivers
>>in this patchset, not for USB.
>
> But I added its device tree binding.
Please do both at the same time. If you only add the binding without
the driver, how can you be sure the binding would be a proper fit?
Moreover, no one can actually test it.
ChenYu
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID
From: Chen-Yu Tsai <wens@csie.org>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: Quentin Schulz <quentin.schulz@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Jonathan Cameron <jic23@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-iio@vger.kernel.org,
linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [linux-sunxi] Re: [RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in AXP803 DTSI
Date: Mon, 25 Sep 2017 17:19:07 +0800 [thread overview]
Message-ID: <CAGb2v64rBQ33aqhPSksBB88GGQTJsPyeebD0ixT=ehBYA5tSEA@mail.gmail.com> (raw)
In-Reply-To: <D7CAB179-F2AF-434F-82F7-07F146842FCF@aosc.io>
On Mon, Sep 25, 2017 at 5:14 PM, Icenowy Zheng <icenowy@aosc.io> wrote:
>
>
> =E4=BA=8E 2017=E5=B9=B49=E6=9C=8825=E6=97=A5 GMT+08:00 =E4=B8=8B=E5=8D=88=
5:11:57, Quentin Schulz <quentin.schulz@free-electrons.com> =E5=86=99=E5=88=
=B0:
>>Hi Icenowy,
>>
>>On 20/09/2017 17:18, Icenowy Zheng wrote:
>>> AXP803 PMIC features AC/USB/Battery power supplies.
>>>
>>> As we have now the device tree bindings for them, add device tree
>>> nodes for them.
>>>
>>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>>> ---
>>> arch/arm64/boot/dts/allwinner/axp803.dtsi | 15 +++++++++++++++
>>> 1 file changed, 15 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/allwinner/axp803.dtsi
>>b/arch/arm64/boot/dts/allwinner/axp803.dtsi
>>> index ff8af52743ff..3a8615231b7c 100644
>>> --- a/arch/arm64/boot/dts/allwinner/axp803.dtsi
>>> +++ b/arch/arm64/boot/dts/allwinner/axp803.dtsi
>>> @@ -49,6 +49,16 @@
>>> interrupt-controller;
>>> #interrupt-cells =3D <1>;
>>>
>>> + ac_power_supply: ac-power-supply {
>>> + compatible =3D "x-powers,axp221-ac-power-supply";
>>> + status =3D "disabled";
>>> + };
>>> +
>>> + battery_power_supply: battery-power-supply {
>>> + compatible =3D "x-powers,axp803-battery-power-supply";
>>> + status =3D "disabled";
>>> + };
>>> +
>>> regulators {
>>> /* Default work frequency for buck regulators */
>>> x-powers,dcdc-freq =3D <3000>;
>>> @@ -147,4 +157,9 @@
>>> regulator-name =3D "rtc-ldo";
>>> };
>>> };
>>> +
>>> + usb_power_supply: usb_power_supply {
>>> + compatible =3D "x-powers,axp803-usb-power-supply";
>>> + status =3D "disabled";
>>> + };
>>
>>No. You have added support for the AC and battery power supply drivers
>>in this patchset, not for USB.
>
> But I added its device tree binding.
Please do both at the same time. If you only add the binding without
the driver, how can you be sure the binding would be a proper fit?
Moreover, no one can actually test it.
ChenYu
WARNING: multiple messages have this Message-ID
From: wens@csie.org (Chen-Yu Tsai)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] Re: [RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in AXP803 DTSI
Date: Mon, 25 Sep 2017 17:19:07 +0800 [thread overview]
Message-ID: <CAGb2v64rBQ33aqhPSksBB88GGQTJsPyeebD0ixT=ehBYA5tSEA@mail.gmail.com> (raw)
In-Reply-To: <D7CAB179-F2AF-434F-82F7-07F146842FCF@aosc.io>
On Mon, Sep 25, 2017 at 5:14 PM, Icenowy Zheng <icenowy@aosc.io> wrote:
>
>
> ? 2017?9?25? GMT+08:00 ??5:11:57, Quentin Schulz <quentin.schulz@free-electrons.com> ??:
>>Hi Icenowy,
>>
>>On 20/09/2017 17:18, Icenowy Zheng wrote:
>>> AXP803 PMIC features AC/USB/Battery power supplies.
>>>
>>> As we have now the device tree bindings for them, add device tree
>>> nodes for them.
>>>
>>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>>> ---
>>> arch/arm64/boot/dts/allwinner/axp803.dtsi | 15 +++++++++++++++
>>> 1 file changed, 15 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/allwinner/axp803.dtsi
>>b/arch/arm64/boot/dts/allwinner/axp803.dtsi
>>> index ff8af52743ff..3a8615231b7c 100644
>>> --- a/arch/arm64/boot/dts/allwinner/axp803.dtsi
>>> +++ b/arch/arm64/boot/dts/allwinner/axp803.dtsi
>>> @@ -49,6 +49,16 @@
>>> interrupt-controller;
>>> #interrupt-cells = <1>;
>>>
>>> + ac_power_supply: ac-power-supply {
>>> + compatible = "x-powers,axp221-ac-power-supply";
>>> + status = "disabled";
>>> + };
>>> +
>>> + battery_power_supply: battery-power-supply {
>>> + compatible = "x-powers,axp803-battery-power-supply";
>>> + status = "disabled";
>>> + };
>>> +
>>> regulators {
>>> /* Default work frequency for buck regulators */
>>> x-powers,dcdc-freq = <3000>;
>>> @@ -147,4 +157,9 @@
>>> regulator-name = "rtc-ldo";
>>> };
>>> };
>>> +
>>> + usb_power_supply: usb_power_supply {
>>> + compatible = "x-powers,axp803-usb-power-supply";
>>> + status = "disabled";
>>> + };
>>
>>No. You have added support for the AC and battery power supply drivers
>>in this patchset, not for USB.
>
> But I added its device tree binding.
Please do both at the same time. If you only add the binding without
the driver, how can you be sure the binding would be a proper fit?
Moreover, no one can actually test it.
ChenYu
next prev parent reply other threads:[~2017-09-25 9:19 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 15:18 [RFC PATCH 0/7] AXP803 AC/Battery support Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-20 15:18 ` [RFC PATCH 1/7] dt-bindings: add compatibles for AXP803 Battery/USB power supplies Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-25 9:14 ` Quentin Schulz
2017-09-25 9:14 ` Quentin Schulz
2017-09-25 9:14 ` Quentin Schulz
2017-09-20 15:18 ` [RFC PATCH 2/7] iio: adc: axp20x-adc: allow to skip ADC rate setup now Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-25 7:20 ` Quentin Schulz
2017-09-25 7:20 ` Quentin Schulz
2017-09-20 15:18 ` [RFC PATCH 3/7] iio: adc: axp20x-adc: add support for AXP803 Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-24 14:32 ` Jonathan Cameron
2017-09-24 14:32 ` Jonathan Cameron
2017-09-24 14:32 ` Jonathan Cameron
2017-09-25 8:48 ` Quentin Schulz
2017-09-25 8:48 ` Quentin Schulz
2017-09-25 8:48 ` Quentin Schulz
2017-09-20 15:18 ` [RFC PATCH 4/7] power: supply: axp20x-battery: support AXP803 Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-24 14:34 ` Jonathan Cameron
2017-09-24 14:34 ` Jonathan Cameron
2017-09-24 14:34 ` Jonathan Cameron
2017-09-25 8:58 ` Quentin Schulz
2017-09-25 8:58 ` Quentin Schulz
2017-09-25 8:58 ` Quentin Schulz
2017-09-20 15:18 ` [RFC PATCH 5/7] mfd: axp20x: add cells for AXP803 ADC/AC Power/Battery Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-20 15:18 ` [RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in AXP803 DTSI Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-25 9:11 ` Quentin Schulz
2017-09-25 9:11 ` Quentin Schulz
2017-09-25 9:11 ` Quentin Schulz
2017-09-25 9:14 ` Icenowy Zheng
2017-09-25 9:14 ` Icenowy Zheng
2017-09-25 9:14 ` Icenowy Zheng
2017-09-25 9:19 ` Chen-Yu Tsai [this message]
2017-09-25 9:19 ` [linux-sunxi] " Chen-Yu Tsai
2017-09-25 9:19 ` Chen-Yu Tsai
2017-09-25 9:19 ` Chen-Yu Tsai
2017-09-25 9:24 ` Quentin Schulz
2017-09-25 9:24 ` Quentin Schulz
2017-09-25 9:24 ` Quentin Schulz
2017-09-20 15:18 ` [RFC PATCH 7/7] arm64: allwinner: a64: enable AC and Battery for Pine64 Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-20 15:18 ` Icenowy Zheng
2017-09-21 14:46 ` [RFC PATCH 0/7] AXP803 AC/Battery support Jonathan Cameron
2017-09-21 14:46 ` Jonathan Cameron
2017-09-21 14:46 ` Jonathan Cameron
2017-09-21 15:20 ` Icenowy Zheng
2017-09-21 15:20 ` Icenowy Zheng
2017-09-21 15:20 ` Icenowy Zheng
2017-09-24 14:36 ` Jonathan Cameron
2017-09-24 14:36 ` Jonathan Cameron
2017-09-25 9:22 ` Quentin Schulz
2017-09-25 9:22 ` Quentin Schulz
2017-09-25 9:22 ` Quentin Schulz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGb2v64rBQ33aqhPSksBB88GGQTJsPyeebD0ixT=ehBYA5tSEA@mail.gmail.com' \
--to=wens@csie.org \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=jic23@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=quentin.schulz@free-electrons.com \
--subject='Re: [linux-sunxi] Re: [RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in AXP803 DTSI' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.