* [PATCH v2] board: gateworks: venice: enable DM_SERIAL
@ 2022-04-13 15:47 Tim Harvey
2022-04-13 15:56 ` Michael Nazzareno Trimarchi
2022-04-21 12:27 ` sbabic
0 siblings, 2 replies; 7+ messages in thread
From: Tim Harvey @ 2022-04-13 15:47 UTC (permalink / raw)
To: Stefano Babic, Fabio Estevam, NXP i . MX U-Boot Team, u-boot; +Cc: Tim Harvey
Enable DM_SERIAL.
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
v2: rebase on imx/master
---
configs/imx8mm_venice_defconfig | 2 ++
configs/imx8mn_venice_defconfig | 2 ++
2 files changed, 4 insertions(+)
diff --git a/configs/imx8mm_venice_defconfig b/configs/imx8mm_venice_defconfig
index dd61ec9b70fb..09f7d8a58ca7 100644
--- a/configs/imx8mm_venice_defconfig
+++ b/configs/imx8mm_venice_defconfig
@@ -110,6 +110,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y
CONFIG_DM_REGULATOR=y
CONFIG_DM_REGULATOR_FIXED=y
CONFIG_DM_REGULATOR_GPIO=y
+CONFIG_DM_SERIAL=y
+# CONFIG_SPL_DM_SERIAL is not set
CONFIG_MXC_UART=y
CONFIG_SYSRESET=y
CONFIG_SPL_SYSRESET=y
diff --git a/configs/imx8mn_venice_defconfig b/configs/imx8mn_venice_defconfig
index c3a96a378553..41898da4aecf 100644
--- a/configs/imx8mn_venice_defconfig
+++ b/configs/imx8mn_venice_defconfig
@@ -108,6 +108,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y
CONFIG_DM_REGULATOR=y
CONFIG_DM_REGULATOR_FIXED=y
CONFIG_DM_REGULATOR_GPIO=y
+CONFIG_DM_SERIAL=y
+# CONFIG_SPL_DM_SERIAL is not set
CONFIG_MXC_UART=y
CONFIG_SYSRESET=y
CONFIG_SPL_SYSRESET=y
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] board: gateworks: venice: enable DM_SERIAL
2022-04-13 15:47 [PATCH v2] board: gateworks: venice: enable DM_SERIAL Tim Harvey
@ 2022-04-13 15:56 ` Michael Nazzareno Trimarchi
2022-04-13 16:08 ` Tim Harvey
2022-04-21 12:27 ` sbabic
1 sibling, 1 reply; 7+ messages in thread
From: Michael Nazzareno Trimarchi @ 2022-04-13 15:56 UTC (permalink / raw)
To: Tim Harvey; +Cc: Stefano Babic, Fabio Estevam, NXP i . MX U-Boot Team, u-boot
Hi Tim
On Wed, Apr 13, 2022 at 5:47 PM Tim Harvey <tharvey@gateworks.com> wrote:
>
> Enable DM_SERIAL.
>
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
> v2: rebase on imx/master
> ---
> configs/imx8mm_venice_defconfig | 2 ++
> configs/imx8mn_venice_defconfig | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/configs/imx8mm_venice_defconfig b/configs/imx8mm_venice_defconfig
> index dd61ec9b70fb..09f7d8a58ca7 100644
> --- a/configs/imx8mm_venice_defconfig
> +++ b/configs/imx8mm_venice_defconfig
> @@ -110,6 +110,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y
> CONFIG_DM_REGULATOR=y
> CONFIG_DM_REGULATOR_FIXED=y
> CONFIG_DM_REGULATOR_GPIO=y
> +CONFIG_DM_SERIAL=y
> +# CONFIG_SPL_DM_SERIAL is not set
> CONFIG_MXC_UART=y
> CONFIG_SYSRESET=y
> CONFIG_SPL_SYSRESET=y
> diff --git a/configs/imx8mn_venice_defconfig b/configs/imx8mn_venice_defconfig
> index c3a96a378553..41898da4aecf 100644
> --- a/configs/imx8mn_venice_defconfig
> +++ b/configs/imx8mn_venice_defconfig
> @@ -108,6 +108,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y
> CONFIG_DM_REGULATOR=y
> CONFIG_DM_REGULATOR_FIXED=y
> CONFIG_DM_REGULATOR_GPIO=y
> +CONFIG_DM_SERIAL=y
> +# CONFIG_SPL_DM_SERIAL is not set
> CONFIG_MXC_UART=y
> CONFIG_SYSRESET=y
> CONFIG_SPL_SYSRESET=y
> --
> 2.17.1
>
Should not select in your board kconfig?
Michael
--
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@amarulasolutions.com
__________________________________
Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@amarulasolutions.com
www.amarulasolutions.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] board: gateworks: venice: enable DM_SERIAL
2022-04-13 15:56 ` Michael Nazzareno Trimarchi
@ 2022-04-13 16:08 ` Tim Harvey
2022-04-13 17:20 ` Michael Nazzareno Trimarchi
0 siblings, 1 reply; 7+ messages in thread
From: Tim Harvey @ 2022-04-13 16:08 UTC (permalink / raw)
To: Michael Nazzareno Trimarchi
Cc: Stefano Babic, Fabio Estevam, NXP i . MX U-Boot Team, u-boot
On Wed, Apr 13, 2022 at 8:56 AM Michael Nazzareno Trimarchi
<michael@amarulasolutions.com> wrote:
>
> Hi Tim
>
> On Wed, Apr 13, 2022 at 5:47 PM Tim Harvey <tharvey@gateworks.com> wrote:
> >
> > Enable DM_SERIAL.
> >
> > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > ---
> > v2: rebase on imx/master
> > ---
> > configs/imx8mm_venice_defconfig | 2 ++
> > configs/imx8mn_venice_defconfig | 2 ++
> > 2 files changed, 4 insertions(+)
> >
> > diff --git a/configs/imx8mm_venice_defconfig b/configs/imx8mm_venice_defconfig
> > index dd61ec9b70fb..09f7d8a58ca7 100644
> > --- a/configs/imx8mm_venice_defconfig
> > +++ b/configs/imx8mm_venice_defconfig
> > @@ -110,6 +110,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y
> > CONFIG_DM_REGULATOR=y
> > CONFIG_DM_REGULATOR_FIXED=y
> > CONFIG_DM_REGULATOR_GPIO=y
> > +CONFIG_DM_SERIAL=y
> > +# CONFIG_SPL_DM_SERIAL is not set
> > CONFIG_MXC_UART=y
> > CONFIG_SYSRESET=y
> > CONFIG_SPL_SYSRESET=y
> > diff --git a/configs/imx8mn_venice_defconfig b/configs/imx8mn_venice_defconfig
> > index c3a96a378553..41898da4aecf 100644
> > --- a/configs/imx8mn_venice_defconfig
> > +++ b/configs/imx8mn_venice_defconfig
> > @@ -108,6 +108,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y
> > CONFIG_DM_REGULATOR=y
> > CONFIG_DM_REGULATOR_FIXED=y
> > CONFIG_DM_REGULATOR_GPIO=y
> > +CONFIG_DM_SERIAL=y
> > +# CONFIG_SPL_DM_SERIAL is not set
> > CONFIG_MXC_UART=y
> > CONFIG_SYSRESET=y
> > CONFIG_SPL_SYSRESET=y
> > --
> > 2.17.1
> >
>
> Should not select in your board kconfig?
>
Michael,
I don't think it really matters. The other conversions to DM_SERIAL
are going in defconfigs as well.
Best Regards,
Tim
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] board: gateworks: venice: enable DM_SERIAL
2022-04-13 16:08 ` Tim Harvey
@ 2022-04-13 17:20 ` Michael Nazzareno Trimarchi
2022-04-14 16:10 ` Tim Harvey
0 siblings, 1 reply; 7+ messages in thread
From: Michael Nazzareno Trimarchi @ 2022-04-13 17:20 UTC (permalink / raw)
To: Tim Harvey; +Cc: Stefano Babic, Fabio Estevam, NXP i . MX U-Boot Team, u-boot
Hi
On Wed, Apr 13, 2022 at 6:09 PM Tim Harvey <tharvey@gateworks.com> wrote:
>
> On Wed, Apr 13, 2022 at 8:56 AM Michael Nazzareno Trimarchi
> <michael@amarulasolutions.com> wrote:
> >
> > Hi Tim
> >
> > On Wed, Apr 13, 2022 at 5:47 PM Tim Harvey <tharvey@gateworks.com> wrote:
> > >
> > > Enable DM_SERIAL.
> > >
> > > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > > ---
> > > v2: rebase on imx/master
> > > ---
> > > configs/imx8mm_venice_defconfig | 2 ++
> > > configs/imx8mn_venice_defconfig | 2 ++
> > > 2 files changed, 4 insertions(+)
> > >
> > > diff --git a/configs/imx8mm_venice_defconfig b/configs/imx8mm_venice_defconfig
> > > index dd61ec9b70fb..09f7d8a58ca7 100644
> > > --- a/configs/imx8mm_venice_defconfig
> > > +++ b/configs/imx8mm_venice_defconfig
> > > @@ -110,6 +110,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y
> > > CONFIG_DM_REGULATOR=y
> > > CONFIG_DM_REGULATOR_FIXED=y
> > > CONFIG_DM_REGULATOR_GPIO=y
> > > +CONFIG_DM_SERIAL=y
> > > +# CONFIG_SPL_DM_SERIAL is not set
> > > CONFIG_MXC_UART=y
> > > CONFIG_SYSRESET=y
> > > CONFIG_SPL_SYSRESET=y
> > > diff --git a/configs/imx8mn_venice_defconfig b/configs/imx8mn_venice_defconfig
> > > index c3a96a378553..41898da4aecf 100644
> > > --- a/configs/imx8mn_venice_defconfig
> > > +++ b/configs/imx8mn_venice_defconfig
> > > @@ -108,6 +108,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y
> > > CONFIG_DM_REGULATOR=y
> > > CONFIG_DM_REGULATOR_FIXED=y
> > > CONFIG_DM_REGULATOR_GPIO=y
> > > +CONFIG_DM_SERIAL=y
> > > +# CONFIG_SPL_DM_SERIAL is not set
> > > CONFIG_MXC_UART=y
> > > CONFIG_SYSRESET=y
> > > CONFIG_SPL_SYSRESET=y
> > > --
> > > 2.17.1
> > >
> >
> > Should not select in your board kconfig?
> >
>
> Michael,
>
> I don't think it really matters. The other conversions to DM_SERIAL
> are going in defconfigs as well.
Do we know why without # CONFIG_SPL_DM_SERIAL is not set
board hang?
Michael
>
> Best Regards,
>
> Tim
--
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@amarulasolutions.com
__________________________________
Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@amarulasolutions.com
www.amarulasolutions.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] board: gateworks: venice: enable DM_SERIAL
2022-04-13 17:20 ` Michael Nazzareno Trimarchi
@ 2022-04-14 16:10 ` Tim Harvey
2022-04-14 17:42 ` Tim Harvey
0 siblings, 1 reply; 7+ messages in thread
From: Tim Harvey @ 2022-04-14 16:10 UTC (permalink / raw)
To: Michael Nazzareno Trimarchi
Cc: Stefano Babic, Fabio Estevam, NXP i . MX U-Boot Team, u-boot
On Wed, Apr 13, 2022 at 10:21 AM Michael Nazzareno Trimarchi
<michael@amarulasolutions.com> wrote:
>
> Hi
>
> On Wed, Apr 13, 2022 at 6:09 PM Tim Harvey <tharvey@gateworks.com> wrote:
> >
> > On Wed, Apr 13, 2022 at 8:56 AM Michael Nazzareno Trimarchi
> > <michael@amarulasolutions.com> wrote:
> > >
> > > Hi Tim
> > >
> > > On Wed, Apr 13, 2022 at 5:47 PM Tim Harvey <tharvey@gateworks.com> wrote:
> > > >
> > > > Enable DM_SERIAL.
> > > >
> > > > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > > > ---
> > > > v2: rebase on imx/master
> > > > ---
> > > > configs/imx8mm_venice_defconfig | 2 ++
> > > > configs/imx8mn_venice_defconfig | 2 ++
> > > > 2 files changed, 4 insertions(+)
> > > >
> > > > diff --git a/configs/imx8mm_venice_defconfig b/configs/imx8mm_venice_defconfig
> > > > index dd61ec9b70fb..09f7d8a58ca7 100644
> > > > --- a/configs/imx8mm_venice_defconfig
> > > > +++ b/configs/imx8mm_venice_defconfig
> > > > @@ -110,6 +110,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y
> > > > CONFIG_DM_REGULATOR=y
> > > > CONFIG_DM_REGULATOR_FIXED=y
> > > > CONFIG_DM_REGULATOR_GPIO=y
> > > > +CONFIG_DM_SERIAL=y
> > > > +# CONFIG_SPL_DM_SERIAL is not set
> > > > CONFIG_MXC_UART=y
> > > > CONFIG_SYSRESET=y
> > > > CONFIG_SPL_SYSRESET=y
> > > > diff --git a/configs/imx8mn_venice_defconfig b/configs/imx8mn_venice_defconfig
> > > > index c3a96a378553..41898da4aecf 100644
> > > > --- a/configs/imx8mn_venice_defconfig
> > > > +++ b/configs/imx8mn_venice_defconfig
> > > > @@ -108,6 +108,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y
> > > > CONFIG_DM_REGULATOR=y
> > > > CONFIG_DM_REGULATOR_FIXED=y
> > > > CONFIG_DM_REGULATOR_GPIO=y
> > > > +CONFIG_DM_SERIAL=y
> > > > +# CONFIG_SPL_DM_SERIAL is not set
> > > > CONFIG_MXC_UART=y
> > > > CONFIG_SYSRESET=y
> > > > CONFIG_SPL_SYSRESET=y
> > > > --
> > > > 2.17.1
> > > >
> > >
> > > Should not select in your board kconfig?
> > >
> >
> > Michael,
> >
> > I don't think it really matters. The other conversions to DM_SERIAL
> > are going in defconfigs as well.
>
> Do we know why without # CONFIG_SPL_DM_SERIAL is not set
>
> board hang?
>
Michael,
yes, if I also enable CONFIG_SPL_DM_SERIAL I get no serial output and
the board hangs even if I add 'u-boot,dm-pre-proper' to
uart2/pinctrl_uart2 nodes.
The requirement is to use DM_SERIAL in U-Boot, not in the SPL. I'm
doing the same as was done for imx8mn-evk in ff1c7961d813 ("ARM: imx:
imx8mn-evk: enable DM_SERIAL").
Thus far, no ARCH_IMX8M boards have enabled CONFIG_SPL_DM_SERIAL so I
suppose others have run into this as well but again the requirement is
to enable CONFIG_DM_SERIAL not necessarily the SPL.
Best Regards,
Tim
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] board: gateworks: venice: enable DM_SERIAL
2022-04-14 16:10 ` Tim Harvey
@ 2022-04-14 17:42 ` Tim Harvey
0 siblings, 0 replies; 7+ messages in thread
From: Tim Harvey @ 2022-04-14 17:42 UTC (permalink / raw)
To: Michael Nazzareno Trimarchi
Cc: Stefano Babic, Fabio Estevam, NXP i . MX U-Boot Team, u-boot
On Thu, Apr 14, 2022 at 9:10 AM Tim Harvey <tharvey@gateworks.com> wrote:
>
> On Wed, Apr 13, 2022 at 10:21 AM Michael Nazzareno Trimarchi
> <michael@amarulasolutions.com> wrote:
> >
> > Hi
> >
> > On Wed, Apr 13, 2022 at 6:09 PM Tim Harvey <tharvey@gateworks.com> wrote:
> > >
> > > On Wed, Apr 13, 2022 at 8:56 AM Michael Nazzareno Trimarchi
> > > <michael@amarulasolutions.com> wrote:
> > > >
> > > > Hi Tim
> > > >
> > > > On Wed, Apr 13, 2022 at 5:47 PM Tim Harvey <tharvey@gateworks.com> wrote:
> > > > >
> > > > > Enable DM_SERIAL.
> > > > >
> > > > > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > > > > ---
> > > > > v2: rebase on imx/master
> > > > > ---
> > > > > configs/imx8mm_venice_defconfig | 2 ++
> > > > > configs/imx8mn_venice_defconfig | 2 ++
> > > > > 2 files changed, 4 insertions(+)
> > > > >
> > > > > diff --git a/configs/imx8mm_venice_defconfig b/configs/imx8mm_venice_defconfig
> > > > > index dd61ec9b70fb..09f7d8a58ca7 100644
> > > > > --- a/configs/imx8mm_venice_defconfig
> > > > > +++ b/configs/imx8mm_venice_defconfig
> > > > > @@ -110,6 +110,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y
> > > > > CONFIG_DM_REGULATOR=y
> > > > > CONFIG_DM_REGULATOR_FIXED=y
> > > > > CONFIG_DM_REGULATOR_GPIO=y
> > > > > +CONFIG_DM_SERIAL=y
> > > > > +# CONFIG_SPL_DM_SERIAL is not set
> > > > > CONFIG_MXC_UART=y
> > > > > CONFIG_SYSRESET=y
> > > > > CONFIG_SPL_SYSRESET=y
> > > > > diff --git a/configs/imx8mn_venice_defconfig b/configs/imx8mn_venice_defconfig
> > > > > index c3a96a378553..41898da4aecf 100644
> > > > > --- a/configs/imx8mn_venice_defconfig
> > > > > +++ b/configs/imx8mn_venice_defconfig
> > > > > @@ -108,6 +108,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y
> > > > > CONFIG_DM_REGULATOR=y
> > > > > CONFIG_DM_REGULATOR_FIXED=y
> > > > > CONFIG_DM_REGULATOR_GPIO=y
> > > > > +CONFIG_DM_SERIAL=y
> > > > > +# CONFIG_SPL_DM_SERIAL is not set
> > > > > CONFIG_MXC_UART=y
> > > > > CONFIG_SYSRESET=y
> > > > > CONFIG_SPL_SYSRESET=y
> > > > > --
> > > > > 2.17.1
> > > > >
> > > >
> > > > Should not select in your board kconfig?
> > > >
> > >
> > > Michael,
> > >
> > > I don't think it really matters. The other conversions to DM_SERIAL
> > > are going in defconfigs as well.
> >
> > Do we know why without # CONFIG_SPL_DM_SERIAL is not set
> >
> > board hang?
> >
>
> Michael,
>
> yes, if I also enable CONFIG_SPL_DM_SERIAL I get no serial output and
> the board hangs even if I add 'u-boot,dm-pre-proper' to
> uart2/pinctrl_uart2 nodes.
I see that Peng has a series [1] that moves imx8mn_evk, imx8mm_evk,
imx8mp_evk to DM_SERIAL and has figured out the hang.
I will re-submit the patch also enabling DM_SERIAL for SPL.
Best Regards,
Tim
[1] https://patchwork.ozlabs.org/project/uboot/list/?series=294869
>
> The requirement is to use DM_SERIAL in U-Boot, not in the SPL. I'm
> doing the same as was done for imx8mn-evk in ff1c7961d813 ("ARM: imx:
> imx8mn-evk: enable DM_SERIAL").
>
> Thus far, no ARCH_IMX8M boards have enabled CONFIG_SPL_DM_SERIAL so I
> suppose others have run into this as well but again the requirement is
> to enable CONFIG_DM_SERIAL not necessarily the SPL.
>
> Best Regards,
>
> Tim
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] board: gateworks: venice: enable DM_SERIAL
2022-04-13 15:47 [PATCH v2] board: gateworks: venice: enable DM_SERIAL Tim Harvey
2022-04-13 15:56 ` Michael Nazzareno Trimarchi
@ 2022-04-21 12:27 ` sbabic
1 sibling, 0 replies; 7+ messages in thread
From: sbabic @ 2022-04-21 12:27 UTC (permalink / raw)
To: Tim Harvey, u-boot
> Enable DM_SERIAL.
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-04-21 12:29 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-13 15:47 [PATCH v2] board: gateworks: venice: enable DM_SERIAL Tim Harvey
2022-04-13 15:56 ` Michael Nazzareno Trimarchi
2022-04-13 16:08 ` Tim Harvey
2022-04-13 17:20 ` Michael Nazzareno Trimarchi
2022-04-14 16:10 ` Tim Harvey
2022-04-14 17:42 ` Tim Harvey
2022-04-21 12:27 ` sbabic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.