[PATCH v2 1/2] printk: Add dummy routine for when CONFIG_PRINTK=n

[PATCH v2 1/2] printk: Add dummy routine for when CONFIG_PRINTK=n

[Pranith Kumar]

There are missing dummy routines for log_buf_addr_get() and log_buf_len_get()
for when CONFIG_PRINTK is not set causing build failures.

This patch adds these dummy routines at the appropriate location.

Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
CC: Michael Ellerman <mpe@ellerman.id.au>
---
 include/linux/printk.h | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/include/linux/printk.h b/include/linux/printk.h
index aeb9d7f..baa3f97 100644
--- a/include/linux/printk.h
+++ b/include/linux/printk.h
@@ -10,9 +10,6 @@
 extern const char linux_banner[];
 extern const char linux_proc_banner[];
 
-extern char *log_buf_addr_get(void);
-extern u32 log_buf_len_get(void);
-
 static inline int printk_get_level(const char *buffer)
 {
 	if (buffer[0] == KERN_SOH_ASCII && buffer[1]) {
@@ -163,6 +160,8 @@ extern int kptr_restrict;
 
 extern void wake_up_klogd(void);
 
+char *log_buf_addr_get(void);
+u32 log_buf_len_get(void);
 void log_buf_kexec_setup(void);
 void __init setup_log_buf(int early);
 void dump_stack_set_arch_desc(const char *fmt, ...);
@@ -198,6 +197,16 @@ static inline void wake_up_klogd(void)
 {
 }
 
+static inline char *log_buf_addr_get(void)
+{
+	return NULL;
+}
+
+static inline u32 log_buf_len_get(void)
+{
+	return 0;
+}
+
 static inline void log_buf_kexec_setup(void)
 {
 }
-- 
1.9.1

[PATCH v2 2/2] powerpc/powernv: Skip registering log region when CONFIG_PRINTK=n

[Pranith Kumar]

When CONFIG_PRINTK=n, log_buf_addr_get() returns NULL and log_buf_len_get()
return 0. Check for these return values and skip registering the dump buffer.

Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
CC: Michael Ellerman <mpe@ellerman.id.au>
---
 arch/powerpc/platforms/powernv/opal.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c
index f10b9ec..1db119f0 100644
--- a/arch/powerpc/platforms/powernv/opal.c
+++ b/arch/powerpc/platforms/powernv/opal.c
@@ -667,7 +667,13 @@ static void __init opal_dump_region_init(void)
 
 	/* Register kernel log buffer */
 	addr = log_buf_addr_get();
+	if (addr == NULL)
+		return;
+
 	size = log_buf_len_get();
+	if (size == 0)
+		return;
+
 	rc = opal_register_dump_region(OPAL_DUMP_REGION_LOG_BUF,
 				       __pa(addr), size);
 	/* Don't warn if this is just an older OPAL that doesn't
-- 
1.9.1

Re: [PATCH v2 2/2] powerpc/powernv: Skip registering log region when CONFIG_PRINTK=n

[Michael Ellerman]

On Wed, 2015-01-21 at 21:26 -0500, Pranith Kumar wrote:
> When CONFIG_PRINTK=n, log_buf_addr_get() returns NULL and log_buf_len_get()
> return 0. Check for these return values and skip registering the dump buffer.
> 
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> CC: Michael Ellerman <mpe@ellerman.id.au>
> ---
>  arch/powerpc/platforms/powernv/opal.c | 6 ++++++
>  1 file changed, 6 insertions(+)

What changed since v1? I don't see anything?

cheers

Re: [PATCH v2 2/2] powerpc/powernv: Skip registering log region when CONFIG_PRINTK=n

[Michael Ellerman]

On Wed, 2015-01-21 at 21:26 -0500, Pranith Kumar wrote:
> When CONFIG_PRINTK=n, log_buf_addr_get() returns NULL and log_buf_len_get()
> return 0. Check for these return values and skip registering the dump buffer.
> 
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> CC: Michael Ellerman <mpe@ellerman.id.au>
> ---
>  arch/powerpc/platforms/powernv/opal.c | 6 ++++++
>  1 file changed, 6 insertions(+)

What changed since v1? I don't see anything?

cheers

Re: [PATCH v2 1/2] printk: Add dummy routine for when CONFIG_PRINTK=n

[Petr Mladek]

On Wed 2015-01-21 21:26:08, Pranith Kumar wrote:
> There are missing dummy routines for log_buf_addr_get() and log_buf_len_get()
> for when CONFIG_PRINTK is not set causing build failures.
> 
> This patch adds these dummy routines at the appropriate location.
> 
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>

Reviewed-by: Petr Mladek <pmladek@suse.cz>

Makes perfect sense and builds now :-)

Best Regards,
Petr

> CC: Michael Ellerman <mpe@ellerman.id.au>
> ---
>  include/linux/printk.h | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/printk.h b/include/linux/printk.h
> index aeb9d7f..baa3f97 100644
> --- a/include/linux/printk.h
> +++ b/include/linux/printk.h
> @@ -10,9 +10,6 @@
>  extern const char linux_banner[];
>  extern const char linux_proc_banner[];
>  
> -extern char *log_buf_addr_get(void);
> -extern u32 log_buf_len_get(void);
> -
>  static inline int printk_get_level(const char *buffer)
>  {
>  	if (buffer[0] == KERN_SOH_ASCII && buffer[1]) {
> @@ -163,6 +160,8 @@ extern int kptr_restrict;
>  
>  extern void wake_up_klogd(void);
>  
> +char *log_buf_addr_get(void);
> +u32 log_buf_len_get(void);
>  void log_buf_kexec_setup(void);
>  void __init setup_log_buf(int early);
>  void dump_stack_set_arch_desc(const char *fmt, ...);
> @@ -198,6 +197,16 @@ static inline void wake_up_klogd(void)
>  {
>  }
>  
> +static inline char *log_buf_addr_get(void)
> +{
> +	return NULL;
> +}
> +
> +static inline u32 log_buf_len_get(void)
> +{
> +	return 0;
> +}
> +
>  static inline void log_buf_kexec_setup(void)
>  {
>  }
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 1/2] printk: Add dummy routine for when CONFIG_PRINTK=n

[Steven Rostedt]

On Wed, 21 Jan 2015 21:26:08 -0500
Pranith Kumar <bobby.prani@gmail.com> wrote:

> There are missing dummy routines for log_buf_addr_get() and log_buf_len_get()
> for when CONFIG_PRINTK is not set causing build failures.
> 
> This patch adds these dummy routines at the appropriate location.
> 
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> CC: Michael Ellerman <mpe@ellerman.id.au>

Acked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

Re: [PATCH v2 2/2] powerpc/powernv: Skip registering log region when CONFIG_PRINTK=n

[Pranith Kumar]

On Thu, Jan 22, 2015 at 12:19 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> On Wed, 2015-01-21 at 21:26 -0500, Pranith Kumar wrote:
>> When CONFIG_PRINTK=n, log_buf_addr_get() returns NULL and log_buf_len_get()
>> return 0. Check for these return values and skip registering the dump buffer.
>>
>> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
>> CC: Michael Ellerman <mpe@ellerman.id.au>
>> ---
>>  arch/powerpc/platforms/powernv/opal.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
>
> What changed since v1? I don't see anything?
>

Nothing in this patch but there is a v2 of the first patch in this
series, so had to resend this patch with a v2.

Thanks!
-- 
Pranith

Re: [PATCH v2 2/2] powerpc/powernv: Skip registering log region when CONFIG_PRINTK=n

[Pranith Kumar]

On Thu, Jan 22, 2015 at 12:19 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> On Wed, 2015-01-21 at 21:26 -0500, Pranith Kumar wrote:
>> When CONFIG_PRINTK=n, log_buf_addr_get() returns NULL and log_buf_len_get()
>> return 0. Check for these return values and skip registering the dump buffer.
>>
>> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
>> CC: Michael Ellerman <mpe@ellerman.id.au>
>> ---
>>  arch/powerpc/platforms/powernv/opal.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
>
> What changed since v1? I don't see anything?
>

Nothing in this patch but there is a v2 of the first patch in this
series, so had to resend this patch with a v2.

Thanks!
-- 
Pranith

Re: [PATCH v2 2/2] powerpc/powernv: Skip registering log region when CONFIG_PRINTK=n

[Stewart Smith]

Pranith Kumar <bobby.prani@gmail.com> writes:
> On Thu, Jan 22, 2015 at 12:19 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
>> On Wed, 2015-01-21 at 21:26 -0500, Pranith Kumar wrote:
>>> When CONFIG_PRINTK=n, log_buf_addr_get() returns NULL and log_buf_len_get()
>>> return 0. Check for these return values and skip registering the dump buffer.
>>>
>>> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
>>> CC: Michael Ellerman <mpe@ellerman.id.au>
>>> ---
>>>  arch/powerpc/platforms/powernv/opal.c | 6 ++++++
>>>  1 file changed, 6 insertions(+)
>>
>> What changed since v1? I don't see anything?
>>
>
> Nothing in this patch but there is a v2 of the first patch in this
> series, so had to resend this patch with a v2.

You also missed my Reviewed-by :)

Re: [PATCH v2 2/2] powerpc/powernv: Skip registering log region when CONFIG_PRINTK=n

[Stewart Smith]

Pranith Kumar <bobby.prani@gmail.com> writes:
> On Thu, Jan 22, 2015 at 12:19 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
>> On Wed, 2015-01-21 at 21:26 -0500, Pranith Kumar wrote:
>>> When CONFIG_PRINTK=n, log_buf_addr_get() returns NULL and log_buf_len_get()
>>> return 0. Check for these return values and skip registering the dump buffer.
>>>
>>> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
>>> CC: Michael Ellerman <mpe@ellerman.id.au>
>>> ---
>>>  arch/powerpc/platforms/powernv/opal.c | 6 ++++++
>>>  1 file changed, 6 insertions(+)
>>
>> What changed since v1? I don't see anything?
>>
>
> Nothing in this patch but there is a v2 of the first patch in this
> series, so had to resend this patch with a v2.

You also missed my Reviewed-by :)

Re: [PATCH v2 2/2] powerpc/powernv: Skip registering log region when CONFIG_PRINTK=n

[Pranith Kumar]

On Thu, Jan 22, 2015 at 5:35 PM, Stewart Smith
<stewart@linux.vnet.ibm.com> wrote:
> Pranith Kumar <bobby.prani@gmail.com> writes:
>> On Thu, Jan 22, 2015 at 12:19 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
>>> On Wed, 2015-01-21 at 21:26 -0500, Pranith Kumar wrote:
>>>> When CONFIG_PRINTK=n, log_buf_addr_get() returns NULL and log_buf_len_get()
>>>> return 0. Check for these return values and skip registering the dump buffer.
>>>>
>>>> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
>>>> CC: Michael Ellerman <mpe@ellerman.id.au>
>>>> ---
>>>>  arch/powerpc/platforms/powernv/opal.c | 6 ++++++
>>>>  1 file changed, 6 insertions(+)
>>>
>>> What changed since v1? I don't see anything?
>>>
>>
>> Nothing in this patch but there is a v2 of the first patch in this
>> series, so had to resend this patch with a v2.
>
> You also missed my Reviewed-by :)
>

Sincere apologies for the oversight. Maintainers, could you please add
this Reviewed-by tag when picking this up?

Reviewed-by: Stewart Smith <stewart@linux.vnet.ibm.com>

Thanks!

-- 
Pranith

Re: [PATCH v2 2/2] powerpc/powernv: Skip registering log region when CONFIG_PRINTK=n

[Pranith Kumar]

On Thu, Jan 22, 2015 at 5:35 PM, Stewart Smith
<stewart@linux.vnet.ibm.com> wrote:
> Pranith Kumar <bobby.prani@gmail.com> writes:
>> On Thu, Jan 22, 2015 at 12:19 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
>>> On Wed, 2015-01-21 at 21:26 -0500, Pranith Kumar wrote:
>>>> When CONFIG_PRINTK=n, log_buf_addr_get() returns NULL and log_buf_len_get()
>>>> return 0. Check for these return values and skip registering the dump buffer.
>>>>
>>>> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
>>>> CC: Michael Ellerman <mpe@ellerman.id.au>
>>>> ---
>>>>  arch/powerpc/platforms/powernv/opal.c | 6 ++++++
>>>>  1 file changed, 6 insertions(+)
>>>
>>> What changed since v1? I don't see anything?
>>>
>>
>> Nothing in this patch but there is a v2 of the first patch in this
>> series, so had to resend this patch with a v2.
>
> You also missed my Reviewed-by :)
>

Sincere apologies for the oversight. Maintainers, could you please add
this Reviewed-by tag when picking this up?

Reviewed-by: Stewart Smith <stewart@linux.vnet.ibm.com>

Thanks!

-- 
Pranith

Re: [PATCH v2 2/2] powerpc/powernv: Skip registering log region when CONFIG_PRINTK=n

[Michael Ellerman]

On Thu, 2015-01-22 at 23:03 -0500, Pranith Kumar wrote:
> On Thu, Jan 22, 2015 at 5:35 PM, Stewart Smith
> <stewart@linux.vnet.ibm.com> wrote:
> > Pranith Kumar <bobby.prani@gmail.com> writes:
> >> On Thu, Jan 22, 2015 at 12:19 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> >>> On Wed, 2015-01-21 at 21:26 -0500, Pranith Kumar wrote:
> >>>> When CONFIG_PRINTK=n, log_buf_addr_get() returns NULL and log_buf_len_get()
> >>>> return 0. Check for these return values and skip registering the dump buffer.
> >>>>
> >>>> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> >>>> CC: Michael Ellerman <mpe@ellerman.id.au>
> >>>> ---
> >>>>  arch/powerpc/platforms/powernv/opal.c | 6 ++++++
> >>>>  1 file changed, 6 insertions(+)
> >>>
> >>> What changed since v1? I don't see anything?
> >>
> >> Nothing in this patch but there is a v2 of the first patch in this
> >> series, so had to resend this patch with a v2.

OK. You didn't send patch 1 to the this list though, so I only saw it on lkml.
Please don't do that in future.

> > You also missed my Reviewed-by :)
> 
> Sincere apologies for the oversight. Maintainers, could you please add
> this Reviewed-by tag when picking this up?
> 
> Reviewed-by: Stewart Smith <stewart@linux.vnet.ibm.com>

For future reference patchwork will catch these tags automatically. So if you
have forgotten to add them you can always reply to your own patch like you have
here and patchwork will detect them.

eg:

http://patchwork.ozlabs.org/patch/431648/mbox/

cheers

Re: [PATCH v2 2/2] powerpc/powernv: Skip registering log region when CONFIG_PRINTK=n

[Michael Ellerman]

On Thu, 2015-01-22 at 23:03 -0500, Pranith Kumar wrote:
> On Thu, Jan 22, 2015 at 5:35 PM, Stewart Smith
> <stewart@linux.vnet.ibm.com> wrote:
> > Pranith Kumar <bobby.prani@gmail.com> writes:
> >> On Thu, Jan 22, 2015 at 12:19 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> >>> On Wed, 2015-01-21 at 21:26 -0500, Pranith Kumar wrote:
> >>>> When CONFIG_PRINTK=n, log_buf_addr_get() returns NULL and log_buf_len_get()
> >>>> return 0. Check for these return values and skip registering the dump buffer.
> >>>>
> >>>> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> >>>> CC: Michael Ellerman <mpe@ellerman.id.au>
> >>>> ---
> >>>>  arch/powerpc/platforms/powernv/opal.c | 6 ++++++
> >>>>  1 file changed, 6 insertions(+)
> >>>
> >>> What changed since v1? I don't see anything?
> >>
> >> Nothing in this patch but there is a v2 of the first patch in this
> >> series, so had to resend this patch with a v2.

OK. You didn't send patch 1 to the this list though, so I only saw it on lkml.
Please don't do that in future.

> > You also missed my Reviewed-by :)
> 
> Sincere apologies for the oversight. Maintainers, could you please add
> this Reviewed-by tag when picking this up?
> 
> Reviewed-by: Stewart Smith <stewart@linux.vnet.ibm.com>

For future reference patchwork will catch these tags automatically. So if you
have forgotten to add them you can always reply to your own patch like you have
here and patchwork will detect them.

eg:

http://patchwork.ozlabs.org/patch/431648/mbox/

cheers