From: Alexander Duyck <alexander.h.duyck@linux.intel.com> To: jane.chu@oracle.com, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Cc: len.brown@intel.com, bvanassche@acm.org, linux-nvdimm@lists.01.org, linux-pm@vger.kernel.org, rafael@kernel.org, jiangshanlai@gmail.com, pavel@ucw.cz, zwisler@kernel.org, tj@kernel.org, akpm@linux-foundation.org Subject: Re: [driver-core PATCH v6 3/9] device core: Consolidate locking and unlocking of parent and device Date: Thu, 08 Nov 2018 14:48:59 -0800 [thread overview] Message-ID: <b92d7ea58dafefc30128dacebc6de6fb9c7fa8e8.camel@linux.intel.com> (raw) In-Reply-To: <791408d3-bf97-0f54-adc5-9b06540015c6@oracle.com> On Thu, 2018-11-08 at 14:43 -0800, jane.chu@oracle.com wrote: > Hi, Alex, > > > On 11/08/2018 10:06 AM, Alexander Duyck wrote: > > +/* > > + * __device_driver_lock - release locks needed to manipulate dev->drv > > You meant to say __device_driver_unlock, right? Yes, you are correct. > > + * @dev: Device we will update driver info for > > + * @parent: Parent device. Needed if the bus requires parent lock > > + * > > + * This function will release the required locks for manipulating dev->drv. > > + * Normally this will just be the the @dev lock, but when called for a > > + * USB interface, @parent lock will be released as well. > > + */ > > +static void __device_driver_unlock(struct device *dev, struct device *parent) > > +{ > > + device_unlock(dev); > > + if (parent && dev->bus->need_parent_lock) > > + device_unlock(parent); > > +} > > -jane Thanks. - Alex _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Duyck <alexander.h.duyck@linux.intel.com> To: jane.chu@oracle.com, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Cc: len.brown@intel.com, bvanassche@acm.org, linux-pm@vger.kernel.org, rafael@kernel.org, jiangshanlai@gmail.com, linux-nvdimm@lists.01.org, pavel@ucw.cz, zwisler@kernel.org, tj@kernel.org, akpm@linux-foundation.org Subject: Re: [driver-core PATCH v6 3/9] device core: Consolidate locking and unlocking of parent and device Date: Thu, 08 Nov 2018 14:48:59 -0800 [thread overview] Message-ID: <b92d7ea58dafefc30128dacebc6de6fb9c7fa8e8.camel@linux.intel.com> (raw) In-Reply-To: <791408d3-bf97-0f54-adc5-9b06540015c6@oracle.com> On Thu, 2018-11-08 at 14:43 -0800, jane.chu@oracle.com wrote: > Hi, Alex, > > > On 11/08/2018 10:06 AM, Alexander Duyck wrote: > > +/* > > + * __device_driver_lock - release locks needed to manipulate dev->drv > > You meant to say __device_driver_unlock, right? Yes, you are correct. > > + * @dev: Device we will update driver info for > > + * @parent: Parent device. Needed if the bus requires parent lock > > + * > > + * This function will release the required locks for manipulating dev->drv. > > + * Normally this will just be the the @dev lock, but when called for a > > + * USB interface, @parent lock will be released as well. > > + */ > > +static void __device_driver_unlock(struct device *dev, struct device *parent) > > +{ > > + device_unlock(dev); > > + if (parent && dev->bus->need_parent_lock) > > + device_unlock(parent); > > +} > > -jane Thanks. - Alex
next prev parent reply other threads:[~2018-11-08 22:48 UTC|newest] Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-08 18:06 [driver-core PATCH v6 0/9] Add NUMA aware async_schedule calls Alexander Duyck 2018-11-08 18:06 ` Alexander Duyck 2018-11-08 18:06 ` [driver-core PATCH v6 1/9] workqueue: Provide queue_work_node to queue work near a given NUMA node Alexander Duyck 2018-11-08 18:06 ` Alexander Duyck 2018-11-27 1:01 ` Dan Williams 2018-11-27 1:01 ` Dan Williams 2018-11-08 18:06 ` [driver-core PATCH v6 2/9] async: Add support for queueing on specific " Alexander Duyck 2018-11-08 18:06 ` Alexander Duyck 2018-11-08 23:36 ` Bart Van Assche 2018-11-08 23:36 ` Bart Van Assche 2018-11-08 23:36 ` Bart Van Assche 2018-11-11 19:32 ` Greg KH 2018-11-11 19:32 ` Greg KH 2018-11-11 19:32 ` Greg KH 2018-11-11 19:53 ` Dan Williams 2018-11-11 19:53 ` Dan Williams 2018-11-11 19:53 ` Dan Williams 2018-11-11 20:35 ` Greg KH 2018-11-11 20:35 ` Greg KH 2018-11-11 20:35 ` Greg KH 2018-11-11 22:17 ` Dan Williams 2018-11-11 22:17 ` Dan Williams 2018-11-11 22:17 ` Dan Williams 2018-11-11 23:27 ` Alexander Duyck 2018-11-11 23:27 ` Alexander Duyck 2018-11-11 23:27 ` Alexander Duyck 2018-11-11 19:59 ` Pavel Machek 2018-11-11 20:33 ` Greg KH 2018-11-11 20:33 ` Greg KH 2018-11-11 21:24 ` Bart Van Assche 2018-11-11 21:24 ` Bart Van Assche 2018-11-13 22:10 ` Pavel Machek 2018-11-27 1:10 ` Dan Williams 2018-11-27 1:10 ` Dan Williams 2018-11-27 1:10 ` Dan Williams 2018-11-08 18:06 ` [driver-core PATCH v6 3/9] device core: Consolidate locking and unlocking of parent and device Alexander Duyck 2018-11-08 18:06 ` Alexander Duyck 2018-11-08 18:06 ` Alexander Duyck 2018-11-08 22:43 ` jane.chu 2018-11-08 22:43 ` jane.chu-QHcLZuEGTsvQT0dZR+AlfA 2018-11-08 22:43 ` jane.chu 2018-11-08 22:48 ` Alexander Duyck [this message] 2018-11-08 22:48 ` Alexander Duyck 2018-11-27 1:44 ` Dan Williams 2018-11-27 1:44 ` Dan Williams 2018-11-08 18:07 ` [driver-core PATCH v6 4/9] driver core: Move async_synchronize_full call Alexander Duyck 2018-11-08 18:07 ` Alexander Duyck 2018-11-27 2:11 ` Dan Williams 2018-11-27 2:11 ` Dan Williams 2018-11-27 17:38 ` Alexander Duyck 2018-11-27 17:38 ` Alexander Duyck 2018-11-27 20:35 ` Dan Williams 2018-11-27 20:35 ` Dan Williams 2018-11-27 21:36 ` Alexander Duyck 2018-11-27 21:36 ` Alexander Duyck 2018-11-27 22:26 ` Dan Williams 2018-11-27 22:26 ` Dan Williams 2018-11-27 22:26 ` Dan Williams 2018-11-08 18:07 ` [driver-core PATCH v6 5/9] driver core: Establish clear order of operations for deferred probe and remove Alexander Duyck 2018-11-08 18:07 ` Alexander Duyck 2018-11-08 18:07 ` Alexander Duyck 2018-11-08 23:47 ` Bart Van Assche 2018-11-08 23:47 ` Bart Van Assche 2018-11-08 23:47 ` Bart Van Assche 2018-11-08 18:07 ` [driver-core PATCH v6 6/9] driver core: Probe devices asynchronously instead of the driver Alexander Duyck 2018-11-08 18:07 ` Alexander Duyck 2018-11-08 18:07 ` Alexander Duyck 2018-11-08 23:59 ` Bart Van Assche 2018-11-08 23:59 ` Bart Van Assche 2018-11-27 2:48 ` Dan Williams 2018-11-27 2:48 ` Dan Williams 2018-11-27 2:48 ` Dan Williams 2018-11-27 17:57 ` Alexander Duyck 2018-11-27 17:57 ` Alexander Duyck 2018-11-27 18:32 ` Dan Williams 2018-11-27 18:32 ` Dan Williams 2018-11-08 18:07 ` [driver-core PATCH v6 7/9] driver core: Attach devices on CPU local to device node Alexander Duyck 2018-11-08 18:07 ` Alexander Duyck 2018-11-27 4:50 ` Dan Williams 2018-11-27 4:50 ` Dan Williams 2018-11-27 4:50 ` Dan Williams 2018-11-08 18:07 ` [driver-core PATCH v6 8/9] PM core: Use new async_schedule_dev command Alexander Duyck 2018-11-08 18:07 ` Alexander Duyck 2018-11-08 18:07 ` Alexander Duyck 2018-11-27 4:52 ` Dan Williams 2018-11-27 4:52 ` Dan Williams 2018-11-27 4:52 ` Dan Williams 2018-11-08 18:07 ` [driver-core PATCH v6 9/9] libnvdimm: Schedule device registration on node local to the device Alexander Duyck 2018-11-08 18:07 ` Alexander Duyck 2018-11-27 2:21 ` Dan Williams 2018-11-27 2:21 ` Dan Williams 2018-11-27 2:21 ` Dan Williams 2018-11-27 18:04 ` Alexander Duyck 2018-11-27 19:34 ` Dan Williams 2018-11-27 19:34 ` Dan Williams 2018-11-27 20:33 ` Bart Van Assche 2018-11-27 20:33 ` Bart Van Assche 2018-11-27 20:33 ` Bart Van Assche 2018-11-27 20:50 ` Dan Williams 2018-11-27 20:50 ` Dan Williams 2018-11-27 20:50 ` Dan Williams 2018-11-27 21:22 ` Bart Van Assche 2018-11-27 21:22 ` Bart Van Assche 2018-11-27 21:22 ` Bart Van Assche 2018-11-27 22:34 ` Dan Williams 2018-11-27 22:34 ` Dan Williams 2018-11-27 22:34 ` Dan Williams
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b92d7ea58dafefc30128dacebc6de6fb9c7fa8e8.camel@linux.intel.com \ --to=alexander.h.duyck@linux.intel.com \ --cc=akpm@linux-foundation.org \ --cc=bvanassche@acm.org \ --cc=gregkh@linuxfoundation.org \ --cc=jane.chu@oracle.com \ --cc=jiangshanlai@gmail.com \ --cc=len.brown@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ --cc=linux-pm@vger.kernel.org \ --cc=pavel@ucw.cz \ --cc=rafael@kernel.org \ --cc=tj@kernel.org \ --cc=zwisler@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.