From: Borislav Petkov <bp@alien8.de>
To: Yu-cheng Yu <yu-cheng.yu@intel.com>
Cc: x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-mm@kvack.org, linux-arch@vger.kernel.org,
linux-api@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Andy Lutomirski <luto@amacapital.net>,
Balbir Singh <bsingharora@gmail.com>,
Cyrill Gorcunov <gorcunov@gmail.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Eugene Syromiatnikov <esyr@redhat.com>,
Florian Weimer <fweimer@redhat.com>,
"H.J. Lu" <hjl.tools@gmail.com>, Jann Horn <jannh@google.com>,
Jonathan Corbet <corbet@lwn.net>,
Kees Cook <keescook@chromium.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
Nadav Amit <nadav.amit@gmail.com>,
Oleg Nesterov <oleg@redhat.com>, Pavel Machek <pavel@ucw.cz>,
Peter Zijlstra <peterz@infradead.org>,
Randy Dunlap <rdunlap@infradead.org>,
"Ravi V. Shankar" <ravi.v.shankar@intel.com>,
Vedvyas Shanbhogue <vedvyas.shanbhogue@intel.com>
Subject: Re: [PATCH v5 06/27] x86/cet: Control protection exception handler
Date: Wed, 14 Nov 2018 19:44:36 +0100 [thread overview]
Message-ID: <20181114184436.GK13926@zn.tnic> (raw)
Message-ID: <20181114184436.T7wRZDFYOq9xMbZtEt4inm06uSAkSyneFs5JK-QAJQY@z> (raw)
In-Reply-To: <20181011151523.27101-7-yu-cheng.yu@intel.com>
That subject needs a verb:
Subject: [PATCH v5 06/27] x86/cet: Add control protection exception handler
On Thu, Oct 11, 2018 at 08:15:02AM -0700, Yu-cheng Yu wrote:
> A control protection exception is triggered when a control flow transfer
> attempt violated shadow stack or indirect branch tracking constraints.
> For example, the return address for a RET instruction differs from the
> safe copy on the shadow stack; or a JMP instruction arrives at a non-
> ENDBR instruction.
>
> The control protection exception handler works in a similar way as the
> general protection fault handler.
>
> Signed-off-by: Yu-cheng Yu <yu-cheng.yu@intel.com>
> ---
> arch/x86/entry/entry_64.S | 2 +-
> arch/x86/include/asm/traps.h | 3 ++
> arch/x86/kernel/idt.c | 4 ++
> arch/x86/kernel/signal_compat.c | 2 +-
> arch/x86/kernel/traps.c | 64 ++++++++++++++++++++++++++++++
> include/uapi/asm-generic/siginfo.h | 3 +-
> 6 files changed, 75 insertions(+), 3 deletions(-)
A *lot* of style problems here. Please use checkpatch and then common
sense to check your patches before sending. All those below are valid,
AFAICT:
WARNING: function definition argument 'struct pt_regs *' should also have an identifier name
#76: FILE: arch/x86/include/asm/traps.h:81:
+dotraplinkage void do_control_protection(struct pt_regs *, long);
WARNING: function definition argument 'long' should also have an identifier name
#76: FILE: arch/x86/include/asm/traps.h:81:
+dotraplinkage void do_control_protection(struct pt_regs *, long);
WARNING: static const char * array should probably be static const char * const
#124: FILE: arch/x86/kernel/traps.c:581:
+static const char *control_protection_err[] =
ERROR: that open brace { should be on the previous line
#125: FILE: arch/x86/kernel/traps.c:582:
+static const char *control_protection_err[] =
+{
WARNING: quoted string split across lines
#158: FILE: arch/x86/kernel/traps.c:615:
+ WARN_ONCE(1, "CET is disabled but got control "
+ "protection fault\n");
WARNING: Prefer printk_ratelimited or pr_<level>_ratelimited to printk_ratelimit
#165: FILE: arch/x86/kernel/traps.c:622:
+ printk_ratelimit()) {
WARNING: Avoid logging continuation uses where feasible
#176: FILE: arch/x86/kernel/traps.c:633:
+ pr_cont("\n");
ERROR: "(foo*)" should be "(foo *)"
#183: FILE: arch/x86/kernel/traps.c:640:
+ info.si_addr = (void __user*)uprobe_get_trap_addr(regs);
And now that patch doesn't even build anymore because of the siginfo
changes which came in during the merge window. I guess I'll wait for
your v6 patchset.
---
arch/x86/kernel/traps.c: In function ‘do_control_protection’:
arch/x86/kernel/traps.c:627:16: error: passing argument 1 of ‘clear_siginfo’ from incompatible pointer type [-Werror=incompatible-pointer-types]
clear_siginfo(&info);
^~~~~
In file included from ./include/linux/sched/signal.h:6,
from ./include/linux/ptrace.h:7,
from ./include/linux/ftrace.h:14,
from ./include/linux/kprobes.h:42,
from arch/x86/kernel/traps.c:19:
./include/linux/signal.h:20:52: note: expected ‘kernel_siginfo_t *’ {aka ‘struct kernel_siginfo *’} but argument is of type ‘siginfo_t *’ {aka ‘struct siginfo *’}
static inline void clear_siginfo(kernel_siginfo_t *info)
~~~~~~~~~~~~~~~~~~^~~~
arch/x86/kernel/traps.c:632:26: error: passing argument 2 of ‘force_sig_info’ from incompatible pointer type [-Werror=incompatible-pointer-types]
force_sig_info(SIGSEGV, &info, tsk);
^~~~~
In file included from ./include/linux/ptrace.h:7,
from ./include/linux/ftrace.h:14,
from ./include/linux/kprobes.h:42,
from arch/x86/kernel/traps.c:19:
./include/linux/sched/signal.h:327:32: note: expected ‘struct kernel_siginfo *’ but argument is of type ‘siginfo_t *’ {aka ‘struct siginfo *’}
extern int force_sig_info(int, struct kernel_siginfo *, struct task_struct *);
^~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:291: arch/x86/kernel/traps.o] Error 1
make[1]: *** [scripts/Makefile.build:516: arch/x86/kernel] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1060: arch/x86] Error 2
make: *** Waiting for unfinished jobs....
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2018-11-15 4:49 UTC|newest]
Thread overview: 160+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 15:14 [PATCH v5 00/27] Control Flow Enforcement: Shadow Stack Yu-cheng Yu
2018-10-11 15:14 ` Yu-cheng Yu
2018-10-11 15:14 ` [PATCH v5 01/27] x86/cpufeatures: Add CPUIDs for Control Flow Enforcement Technology (CET) Yu-cheng Yu
2018-10-11 15:14 ` Yu-cheng Yu
2018-10-11 16:43 ` Borislav Petkov
2018-10-11 16:43 ` Borislav Petkov
2018-10-11 16:45 ` Yu-cheng Yu
2018-10-11 16:45 ` Yu-cheng Yu
2018-10-11 15:14 ` [PATCH v5 02/27] x86/fpu/xstate: Change names to separate XSAVES system and user states Yu-cheng Yu
2018-10-11 15:14 ` Yu-cheng Yu
2018-10-15 17:03 ` Borislav Petkov
2018-10-15 17:03 ` Borislav Petkov
2018-10-11 15:14 ` [PATCH v5 03/27] x86/fpu/xstate: Introduce XSAVES system states Yu-cheng Yu
2018-10-11 15:14 ` Yu-cheng Yu
2018-10-17 10:41 ` Borislav Petkov
2018-10-17 10:41 ` Borislav Petkov
2018-10-17 22:39 ` Randy Dunlap
2018-10-17 22:39 ` Randy Dunlap
2018-10-17 22:58 ` Borislav Petkov
2018-10-17 22:58 ` Borislav Petkov
2018-10-17 23:17 ` Randy Dunlap
2018-10-17 23:17 ` Randy Dunlap
2018-10-18 9:26 ` Borislav Petkov
2018-10-18 9:26 ` Borislav Petkov
2018-10-18 9:31 ` Pavel Machek
2018-10-18 9:31 ` Pavel Machek
2018-10-18 12:10 ` Borislav Petkov
2018-10-18 12:10 ` Borislav Petkov
2018-10-18 18:33 ` Randy Dunlap
2018-10-18 18:33 ` Randy Dunlap
2018-10-18 9:24 ` Pavel Machek
2018-10-18 9:24 ` Pavel Machek
2018-10-11 15:15 ` [PATCH v5 04/27] x86/fpu/xstate: Add XSAVES system states for shadow stack Yu-cheng Yu
2018-10-11 15:15 ` Yu-cheng Yu
2018-11-08 18:40 ` Borislav Petkov
2018-11-08 18:40 ` Borislav Petkov
2018-11-08 20:40 ` Yu-cheng Yu
2018-11-08 20:40 ` Yu-cheng Yu
2018-11-08 23:52 ` Borislav Petkov
2018-11-08 23:52 ` Borislav Petkov
2018-11-11 11:31 ` Pavel Machek
2018-11-11 11:31 ` Pavel Machek
2018-11-11 11:31 ` Pavel Machek
2018-11-11 11:31 ` Pavel Machek
2018-11-11 14:59 ` Andy Lutomirski
2018-11-11 14:59 ` Andy Lutomirski
2018-11-11 19:02 ` Pavel Machek
2018-11-11 19:02 ` Pavel Machek
2018-11-08 20:46 ` Andy Lutomirski
2018-11-08 20:46 ` Andy Lutomirski
2018-11-08 21:01 ` Yu-cheng Yu
2018-11-08 21:01 ` Yu-cheng Yu
2018-11-08 21:22 ` Andy Lutomirski
2018-11-08 21:22 ` Andy Lutomirski
2018-11-08 21:31 ` Cyrill Gorcunov
2018-11-08 21:31 ` Cyrill Gorcunov
2018-11-08 22:01 ` Andy Lutomirski
2018-11-08 22:01 ` Andy Lutomirski
2018-11-08 22:18 ` Cyrill Gorcunov
2018-11-08 22:18 ` Cyrill Gorcunov
2018-11-08 21:48 ` Dave Hansen
2018-11-08 21:48 ` Dave Hansen
2018-11-08 22:00 ` Matthew Wilcox
2018-11-08 22:00 ` Matthew Wilcox
2018-11-08 23:35 ` Dave Hansen
2018-11-08 23:35 ` Dave Hansen
2018-11-09 0:32 ` Matthew Wilcox
2018-11-09 0:32 ` Matthew Wilcox
2018-11-09 0:45 ` Andy Lutomirski
2018-11-09 0:45 ` Andy Lutomirski
2018-11-09 17:13 ` Dave Hansen
2018-11-09 17:13 ` Dave Hansen
2018-11-09 17:17 ` Matthew Wilcox
2018-11-09 17:17 ` Matthew Wilcox
2018-11-09 17:20 ` Dave Hansen
2018-11-09 17:20 ` Dave Hansen
2018-11-09 17:28 ` Dave Hansen
2018-11-09 17:28 ` Dave Hansen
2018-11-11 11:31 ` Pavel Machek
2018-11-11 11:31 ` Pavel Machek
2018-10-11 15:15 ` [PATCH v5 05/27] Documentation/x86: Add CET description Yu-cheng Yu
2018-10-11 15:15 ` Yu-cheng Yu
2018-11-13 18:43 ` Borislav Petkov
2018-11-13 18:43 ` Borislav Petkov
2018-11-13 21:02 ` Yu-cheng Yu
2018-11-13 21:02 ` Yu-cheng Yu
2018-10-11 15:15 ` [PATCH v5 06/27] x86/cet: Control protection exception handler Yu-cheng Yu
2018-10-11 15:15 ` Yu-cheng Yu
2018-11-14 18:44 ` Borislav Petkov [this message]
2018-11-14 18:44 ` Borislav Petkov
2018-11-14 20:19 ` Yu-cheng Yu
2018-11-14 20:19 ` Yu-cheng Yu
2018-11-14 20:28 ` Borislav Petkov
2018-11-14 20:28 ` Borislav Petkov
2018-10-11 15:15 ` [PATCH v5 07/27] mm/mmap: Create a guard area between VMAs Yu-cheng Yu
2018-10-11 15:15 ` Yu-cheng Yu
2018-10-11 20:39 ` Jann Horn
2018-10-11 20:39 ` Jann Horn
2018-10-11 20:49 ` Yu-cheng Yu
2018-10-11 20:49 ` Yu-cheng Yu
2018-10-11 20:55 ` Andy Lutomirski
2018-10-11 20:55 ` Andy Lutomirski
2018-10-12 21:49 ` Yu-cheng Yu
2018-10-12 21:49 ` Yu-cheng Yu
2018-10-12 13:17 ` Matthew Wilcox
2018-10-12 13:17 ` Matthew Wilcox
2018-10-11 20:49 ` Dave Hansen
2018-10-11 20:49 ` Dave Hansen
2018-10-12 10:24 ` Florian Weimer
2018-10-12 10:24 ` Florian Weimer
2018-10-11 15:15 ` [PATCH v5 08/27] x86/cet/shstk: Add Kconfig option for user-mode shadow stack Yu-cheng Yu
2018-10-11 15:15 ` Yu-cheng Yu
2018-10-11 15:15 ` [PATCH v5 09/27] mm: Introduce VM_SHSTK for shadow stack memory Yu-cheng Yu
2018-10-11 15:15 ` Yu-cheng Yu
2018-10-11 15:15 ` [PATCH v5 10/27] mm/mmap: Prevent Shadow Stack VMA merges Yu-cheng Yu
2018-10-11 15:15 ` Yu-cheng Yu
2018-10-11 15:15 ` [PATCH v5 11/27] x86/mm: Change _PAGE_DIRTY to _PAGE_DIRTY_HW Yu-cheng Yu
2018-10-11 15:15 ` Yu-cheng Yu
2018-10-11 15:15 ` [PATCH v5 12/27] x86/mm: Introduce _PAGE_DIRTY_SW Yu-cheng Yu
2018-10-11 15:15 ` Yu-cheng Yu
2018-10-11 15:15 ` [PATCH v5 13/27] drm/i915/gvt: Update _PAGE_DIRTY to _PAGE_DIRTY_BITS Yu-cheng Yu
2018-10-11 15:15 ` Yu-cheng Yu
2018-10-11 15:15 ` [PATCH v5 14/27] x86/mm: Modify ptep_set_wrprotect and pmdp_set_wrprotect for _PAGE_DIRTY_SW Yu-cheng Yu
2018-10-11 15:15 ` Yu-cheng Yu
2018-10-11 15:15 ` [PATCH v5 15/27] x86/mm: Shadow stack page fault error checking Yu-cheng Yu
2018-10-11 15:15 ` Yu-cheng Yu
2018-10-11 15:15 ` [PATCH v5 16/27] mm: Handle shadow stack page fault Yu-cheng Yu
2018-10-11 15:15 ` Yu-cheng Yu
2018-10-11 15:15 ` [PATCH v5 17/27] mm: Handle THP/HugeTLB " Yu-cheng Yu
2018-10-11 15:15 ` Yu-cheng Yu
2018-10-11 15:15 ` [PATCH v5 18/27] mm: Update can_follow_write_pte/pmd for shadow stack Yu-cheng Yu
2018-10-11 15:15 ` Yu-cheng Yu
2018-10-11 15:15 ` [PATCH v5 19/27] mm: Introduce do_mmap_locked() Yu-cheng Yu
2018-10-11 15:15 ` Yu-cheng Yu
2018-10-11 15:15 ` [PATCH v5 20/27] x86/cet/shstk: User-mode shadow stack support Yu-cheng Yu
2018-10-11 15:15 ` Yu-cheng Yu
2018-10-11 15:15 ` [PATCH v5 21/27] x86/cet/shstk: Introduce WRUSS instruction Yu-cheng Yu
2018-10-11 15:15 ` Yu-cheng Yu
2018-11-06 18:43 ` Dave Hansen
2018-11-06 18:43 ` Dave Hansen
2018-11-06 18:55 ` Andy Lutomirski
2018-11-06 18:55 ` Andy Lutomirski
2018-11-06 20:21 ` Yu-cheng Yu
2018-11-06 20:21 ` Yu-cheng Yu
2018-10-11 15:15 ` [PATCH v5 22/27] x86/cet/shstk: Signal handling for shadow stack Yu-cheng Yu
2018-10-11 15:15 ` Yu-cheng Yu
2018-10-11 15:15 ` [PATCH v5 23/27] x86/cet/shstk: ELF header parsing of Shadow Stack Yu-cheng Yu
2018-10-11 15:15 ` Yu-cheng Yu
2018-10-11 15:15 ` [PATCH v5 24/27] x86/cet/shstk: Handle thread shadow stack Yu-cheng Yu
2018-10-11 15:15 ` Yu-cheng Yu
2018-10-11 15:15 ` [PATCH v5 25/27] mm/mmap: Add Shadow stack pages to memory accounting Yu-cheng Yu
2018-10-11 15:15 ` Yu-cheng Yu
2018-10-11 15:15 ` [PATCH v5 26/27] x86/cet/shstk: Add arch_prctl functions for Shadow Stack Yu-cheng Yu
2018-10-11 15:15 ` Yu-cheng Yu
2018-10-11 15:15 ` [PATCH v5 27/27] x86/cet/shstk: Add Shadow Stack instructions to opcode map Yu-cheng Yu
2018-10-11 15:15 ` Yu-cheng Yu
2018-10-11 19:21 ` [PATCH v5 00/27] Control Flow Enforcement: Shadow Stack Dave Hansen
2018-10-11 19:21 ` Dave Hansen
2018-10-11 19:29 ` Yu-cheng Yu
2018-10-11 19:29 ` Yu-cheng Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181114184436.GK13926@zn.tnic \
--to=bp@alien8.de \
--cc=arnd@arndb.de \
--cc=bsingharora@gmail.com \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=esyr@redhat.com \
--cc=fweimer@redhat.com \
--cc=gorcunov@gmail.com \
--cc=hjl.tools@gmail.com \
--cc=hpa@zytor.com \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=mike.kravetz@oracle.com \
--cc=mingo@redhat.com \
--cc=nadav.amit@gmail.com \
--cc=oleg@redhat.com \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=ravi.v.shankar@intel.com \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
--cc=vedvyas.shanbhogue@intel.com \
--cc=x86@kernel.org \
--cc=yu-cheng.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).