Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: build failure in Linus' tree
@ 2020-02-09 21:08 Stephen Rothwell
  2020-02-09 21:24 ` Linus Torvalds
  0 siblings, 1 reply; 64+ messages in thread
From: Stephen Rothwell @ 2020-02-09 21:08 UTC (permalink / raw)
  To: Zenghui Yu, Marc Zyngier
  Cc: Linus Torvalds, Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 566 bytes --]

Hi all,

Just building Linus' tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

arm-linux-gnueabi-ld: drivers/irqchip/irq-gic-v3-its.o: in function `its_vpe_irq_domain_alloc':
irq-gic-v3-its.c:(.text+0x3d50): undefined reference to `__aeabi_uldivmod'

Caused by commit

  4e6437f12d6e ("irqchip/gic-v4.1: Ensure L2 vPE table is allocated at RD level")

I have reverted that commit (and the following 3 commits) for today.

Those commits were not in linux-next before being merged by Linus. :-(
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2020-02-09 21:08 linux-next: build failure in Linus' tree Stephen Rothwell
@ 2020-02-09 21:24 ` Linus Torvalds
  2020-02-09 22:57   ` Marc Zyngier
  0 siblings, 1 reply; 64+ messages in thread
From: Linus Torvalds @ 2020-02-09 21:24 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Zenghui Yu, Marc Zyngier, Linux Next Mailing List,
	Linux Kernel Mailing List

On Sun, Feb 9, 2020 at 1:08 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Just building Linus' tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> arm-linux-gnueabi-ld: drivers/irqchip/irq-gic-v3-its.o: in function `its_vpe_irq_domain_alloc':
> irq-gic-v3-its.c:(.text+0x3d50): undefined reference to `__aeabi_uldivmod'
>
> Caused by commit
>
>   4e6437f12d6e ("irqchip/gic-v4.1: Ensure L2 vPE table is allocated at RD level")

Ahh. 64-bit divides without using do_div() and friends.

Is GICv4 even relevant for 32-bit ARM?

            Linus

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2020-02-09 21:24 ` Linus Torvalds
@ 2020-02-09 22:57   ` Marc Zyngier
  2020-02-09 23:48     ` Linus Torvalds
  2020-02-10  2:00     ` Zenghui Yu
  0 siblings, 2 replies; 64+ messages in thread
From: Marc Zyngier @ 2020-02-09 22:57 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Stephen Rothwell, Zenghui Yu, Linux Next Mailing List,
	Linux Kernel Mailing List

On Sun, 9 Feb 2020 13:24:18 -0800
Linus Torvalds <torvalds@linux-foundation.org> wrote:

Stephen, Linus,

> On Sun, Feb 9, 2020 at 1:08 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Just building Linus' tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> >
> > arm-linux-gnueabi-ld: drivers/irqchip/irq-gic-v3-its.o: in function `its_vpe_irq_domain_alloc':
> > irq-gic-v3-its.c:(.text+0x3d50): undefined reference to `__aeabi_uldivmod'
> >
> > Caused by commit
> >
> >   4e6437f12d6e ("irqchip/gic-v4.1: Ensure L2 vPE table is allocated at RD level")  

Gniii... Sorry for the breakage.

> 
> Ahh. 64-bit divides without using do_div() and friends.
> 
> Is GICv4 even relevant for 32-bit ARM?

Only should someone boot a large 64bit server in 32bit mode and run VMs
with direct injection of interrupts. And definitely not once we get rid
of 32bit KVM.

Do you mind applying the following patch on top? It fixes the breakage
here.

Thanks,

	M.

From d06ab34c3491d3cd191e024bf2da1eb9b8caccdd Mon Sep 17 00:00:00 2001
From: Marc Zyngier <maz@kernel.org>
Date: Sun, 9 Feb 2020 22:48:50 +0000
Subject: [PATCH] irqchip/gic-v4.1: Avoid 64bit division for the sake of 32bit
 ARM

In order to allow the GICv4 code to link properly on 32bit ARM,
make sure we don't use 64bit divisions when it isn't strictly
necessary.

Fixes: 4e6437f12d6e ("irqchip/gic-v4.1: Ensure L2 vPE table is allocated at RD level")
Signed-off-by: Marc Zyngier <maz@kernel.org>
---
 drivers/irqchip/irq-gic-v3-its.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
index 1ee95f546cb0..83b1186ffcad 100644
--- a/drivers/irqchip/irq-gic-v3-its.c
+++ b/drivers/irqchip/irq-gic-v3-its.c
@@ -2444,8 +2444,8 @@ static u64 inherit_vpe_l1_table_from_rd(cpumask_t **mask)
 static bool allocate_vpe_l2_table(int cpu, u32 id)
 {
 	void __iomem *base = gic_data_rdist_cpu(cpu)->rd_base;
-	u64 val, gpsz, npg;
-	unsigned int psz, esz, idx;
+	unsigned int psz, esz, idx, npg, gpsz;
+	u64 val;
 	struct page *page;
 	__le64 *table;
 
-- 
2.20.1


-- 
Jazz is not dead. It just smells funny...

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2020-02-09 22:57   ` Marc Zyngier
@ 2020-02-09 23:48     ` Linus Torvalds
  2020-02-10  2:00     ` Zenghui Yu
  1 sibling, 0 replies; 64+ messages in thread
From: Linus Torvalds @ 2020-02-09 23:48 UTC (permalink / raw)
  To: Marc Zyngier
  Cc: Stephen Rothwell, Zenghui Yu, Linux Next Mailing List,
	Linux Kernel Mailing List

On Sun, Feb 9, 2020 at 2:57 PM Marc Zyngier <maz@kernel.org> wrote:
>
> Do you mind applying the following patch on top? It fixes the breakage
> here.

Done. Added proper reported-by (and cc).

              Linus

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2020-02-09 22:57   ` Marc Zyngier
  2020-02-09 23:48     ` Linus Torvalds
@ 2020-02-10  2:00     ` Zenghui Yu
  1 sibling, 0 replies; 64+ messages in thread
From: Zenghui Yu @ 2020-02-10  2:00 UTC (permalink / raw)
  To: Marc Zyngier, Linus Torvalds
  Cc: Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List

On 2020/2/10 6:57, Marc Zyngier wrote:
> On Sun, 9 Feb 2020 13:24:18 -0800
> Linus Torvalds <torvalds@linux-foundation.org> wrote:
> 
> Stephen, Linus,
> 
>> On Sun, Feb 9, 2020 at 1:08 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>>
>>> Just building Linus' tree, today's linux-next build (arm
>>> multi_v7_defconfig) failed like this:
>>>
>>> arm-linux-gnueabi-ld: drivers/irqchip/irq-gic-v3-its.o: in function `its_vpe_irq_domain_alloc':
>>> irq-gic-v3-its.c:(.text+0x3d50): undefined reference to `__aeabi_uldivmod'
>>>
>>> Caused by commit
>>>
>>>    4e6437f12d6e ("irqchip/gic-v4.1: Ensure L2 vPE table is allocated at RD level")
> 
> Gniii... Sorry for the breakage.

Sorry, my bad. I'm going to set up my 32bit ARM for tests (before
sending something out in the future).

> 
>>
>> Ahh. 64-bit divides without using do_div() and friends.
>>
>> Is GICv4 even relevant for 32-bit ARM?
> 
> Only should someone boot a large 64bit server in 32bit mode and run VMs
> with direct injection of interrupts. And definitely not once we get rid
> of 32bit KVM.
> 
> Do you mind applying the following patch on top? It fixes the breakage
> here.
> 
> Thanks,
> 
> 	M.
> 
>>From d06ab34c3491d3cd191e024bf2da1eb9b8caccdd Mon Sep 17 00:00:00 2001
> From: Marc Zyngier <maz@kernel.org>
> Date: Sun, 9 Feb 2020 22:48:50 +0000
> Subject: [PATCH] irqchip/gic-v4.1: Avoid 64bit division for the sake of 32bit
>   ARM
> 
> In order to allow the GICv4 code to link properly on 32bit ARM,
> make sure we don't use 64bit divisions when it isn't strictly
> necessary.
> 
> Fixes: 4e6437f12d6e ("irqchip/gic-v4.1: Ensure L2 vPE table is allocated at RD level")
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---
>   drivers/irqchip/irq-gic-v3-its.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
> index 1ee95f546cb0..83b1186ffcad 100644
> --- a/drivers/irqchip/irq-gic-v3-its.c
> +++ b/drivers/irqchip/irq-gic-v3-its.c
> @@ -2444,8 +2444,8 @@ static u64 inherit_vpe_l1_table_from_rd(cpumask_t **mask)
>   static bool allocate_vpe_l2_table(int cpu, u32 id)
>   {
>   	void __iomem *base = gic_data_rdist_cpu(cpu)->rd_base;
> -	u64 val, gpsz, npg;
> -	unsigned int psz, esz, idx;
> +	unsigned int psz, esz, idx, npg, gpsz;
> +	u64 val;
>   	struct page *page;
>   	__le64 *table;
>   
> 

And thanks a lot for your help, Marc!


Zenghui


^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2018-10-28 22:45 ` Linus Torvalds
  2018-10-29  1:38   ` Hangbin Liu
@ 2018-10-29  2:17   ` David Miller
  1 sibling, 0 replies; 64+ messages in thread
From: David Miller @ 2018-10-29  2:17 UTC (permalink / raw)
  To: torvalds; +Cc: sfr, linux-next, linux-kernel, liuhangbin

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Sun, 28 Oct 2018 15:45:16 -0700

> On Sun, Oct 28, 2018 at 3:35 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> After merging the origin tree, today's linux-next build (powerpc
>> ppc64_defconfig) failed like this:
> 
> linux-next is back! Wheee..
> 
>>   5a2de63fd1a5 ("bridge: do not add port to router list when receives query with source 0.0.0.0")
> 
> David?

I'm on it and have a fix coming.

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2018-10-28 22:45 ` Linus Torvalds
@ 2018-10-29  1:38   ` Hangbin Liu
  2018-10-29  2:17   ` David Miller
  1 sibling, 0 replies; 64+ messages in thread
From: Hangbin Liu @ 2018-10-29  1:38 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: sfr, linux-next, Linux Kernel Mailing List, David Miller,
	Nikolay Aleksandrov

On Sun, Oct 28, 2018 at 03:45:16PM -0700, Linus Torvalds wrote:
> On Sun, Oct 28, 2018 at 3:35 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the origin tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> 
> linux-next is back! Wheee..
> 
> >   5a2de63fd1a5 ("bridge: do not add port to router list when receives query with source 0.0.0.0")
> 
> David?
> 
>                  Linus

Sorry, I forgot to check if IPv6 is configured. Nikolay has helped post
a fix for this issue.

Regards
Hangbin

^ permalink raw reply	[flat|nested] 64+ messages in thread

* linux-next: build failure in Linus' tree
@ 2018-10-28 22:45 Stephen Rothwell
  0 siblings, 0 replies; 64+ messages in thread
From: Stephen Rothwell @ 2018-10-28 22:45 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Eric Dumazet,
	David S. Miller

[-- Attachment #1: Type: text/plain, Size: 1636 bytes --]

Hi Linus,

After merging the origin tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/net/ethernet/mellanox/mlx4/en_rx.c:582:18: warning: 'struct iphdr' declared inside parameter list will not be visible outside of this definition or declaration
           struct iphdr *iph)
                  ^~~~~
drivers/net/ethernet/mellanox/mlx4/en_rx.c: In function 'get_fixed_ipv4_csum':
drivers/net/ethernet/mellanox/mlx4/en_rx.c:586:20: error: dereferencing pointer to incomplete type 'struct iphdr'
  __u8 ipproto = iph->protocol;
                    ^~

Caused by commit

  55469bc6b577 ("drivers: net: remove <net/busy_poll.h> inclusion when not needed")

I added the following patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 29 Oct 2018 09:40:39 +1100
Subject: [PATCH] drivers: net: include linux/ip.h for iphdr

Fixes: 55469bc6b577 ("drivers: net: remove <net/busy_poll.h> inclusion when not needed")
Cc: Eric Dumazet <edumazet@google.com>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/ethernet/mellanox/mlx4/en_rx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/mellanox/mlx4/en_rx.c b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
index 5a6d0919533d..ffa54767dfe5 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
@@ -31,6 +31,7 @@
  *
  */
 
+#include <linux/ip.h>
 #include <linux/bpf.h>
 #include <linux/bpf_trace.h>
 #include <linux/mlx4/cq.h>
-- 
2.18.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2018-10-28 22:35 Stephen Rothwell
@ 2018-10-28 22:45 ` Linus Torvalds
  2018-10-29  1:38   ` Hangbin Liu
  2018-10-29  2:17   ` David Miller
  0 siblings, 2 replies; 64+ messages in thread
From: Linus Torvalds @ 2018-10-28 22:45 UTC (permalink / raw)
  To: sfr; +Cc: linux-next, Linux Kernel Mailing List, liuhangbin, David Miller

On Sun, Oct 28, 2018 at 3:35 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the origin tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:

linux-next is back! Wheee..

>   5a2de63fd1a5 ("bridge: do not add port to router list when receives query with source 0.0.0.0")

David?

                 Linus

^ permalink raw reply	[flat|nested] 64+ messages in thread

* linux-next: build failure in Linus' tree
@ 2018-10-28 22:35 Stephen Rothwell
  2018-10-28 22:45 ` Linus Torvalds
  0 siblings, 1 reply; 64+ messages in thread
From: Stephen Rothwell @ 2018-10-28 22:35 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Hangbin Liu,
	David S. Miller

[-- Attachment #1: Type: text/plain, Size: 642 bytes --]

Hi Linus,

After merging the origin tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

net/bridge/br_multicast.c: In function 'br_multicast_query_received':
net/bridge/br_multicast.c:1432:32: error: 'union <anonymous>' has no member named 'ip6'; did you mean 'ip4'?
       !ipv6_addr_any(&saddr->u.ip6)))
                                ^~~
                                ip4

Caused by commit

  5a2de63fd1a5 ("bridge: do not add port to router list when receives query with source 0.0.0.0")

# CONFIG_IPV6 is not set

I have just reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2018-06-12  2:26 Stephen Rothwell
@ 2018-06-18  3:50 ` Stephen Rothwell
  0 siblings, 0 replies; 64+ messages in thread
From: Stephen Rothwell @ 2018-06-18  3:50 UTC (permalink / raw)
  To: Alexei Starovoitov, Daniel Borkmann
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, David Miller,
	Networking, Michael Ellerman, Benjamin Herrenschmidt, PowerPC

[-- Attachment #1: Type: text/plain, Size: 659 bytes --]

Hi all,

On Tue, 12 Jun 2018 12:26:40 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Building Linus' tree, today's linux-next build (powerpc allyesconfig)
> failed like this:
> 
> ld: net/bpfilter/bpfilter_umh.o: compiled for a little endian system and target is big endian
> ld: failed to merge target specific data of file net/bpfilter/bpfilter_umh.o
> 
> This has come to light since I started using a native compiler (i.e. one
> that can build executables, not just the kernel) for my PowerPC builds
> on a powerpcle host.
> 
> I have switched back to my limited compiler.

Any progress on this?
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 64+ messages in thread

* linux-next: build failure in Linus' tree
@ 2018-06-12  2:26 Stephen Rothwell
  2018-06-18  3:50 ` Stephen Rothwell
  0 siblings, 1 reply; 64+ messages in thread
From: Stephen Rothwell @ 2018-06-12  2:26 UTC (permalink / raw)
  To: Alexei Starovoitov, Daniel Borkmann
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, David Miller,
	Networking, Michael Ellerman, Benjamin Herrenschmidt, PowerPC

[-- Attachment #1: Type: text/plain, Size: 528 bytes --]

Hi all,

Building Linus' tree, today's linux-next build (powerpc allyesconfig)
failed like this:

ld: net/bpfilter/bpfilter_umh.o: compiled for a little endian system and target is big endian
ld: failed to merge target specific data of file net/bpfilter/bpfilter_umh.o

This has come to light since I started using a native compiler (i.e. one
that can build executables, not just the kernel) for my PowerPC builds
on a powerpcle host.

I have switched back to my limited compiler.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 64+ messages in thread

* linux-next: build failure in Linus' tree
@ 2018-02-04 22:28 Stephen Rothwell
  0 siblings, 0 replies; 64+ messages in thread
From: Stephen Rothwell @ 2018-02-04 22:28 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Linus Walleij

Hi Linus,

Just building you tree, today's linux-next build (arm multi_v7_defconfig)
failed like this:

drivers/usb/host/ehci-st.c: In function 'st_ehci_suspend':
drivers/usb/host/ehci-st.c:300:2: error: implicit declaration of function 'pinctrl_pm_select_sleep_state' [-Werror=implicit-function-declaration]
  pinctrl_pm_select_sleep_state(dev);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/usb/host/ehci-st.c: In function 'st_ehci_resume':
drivers/usb/host/ehci-st.c:312:2: error: implicit declaration of function 'pinctrl_pm_select_default_state' [-Werror=implicit-function-declaration]
  pinctrl_pm_select_default_state(dev);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  23c35f48f5fb ("pinctrl: remove include file from <linux/device.h>")

I have added teh following fix patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 5 Feb 2018 09:24:30 +1100
Subject: [PATCH] pinctrl: files should directly include apis they use

Fixes: 23c35f48f5fb ("pinctrl: remove include file from <linux/device.h>")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/usb/host/ehci-st.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/host/ehci-st.c b/drivers/usb/host/ehci-st.c
index 3c1362ab70be..dc42981047c9 100644
--- a/drivers/usb/host/ehci-st.c
+++ b/drivers/usb/host/ehci-st.c
@@ -23,6 +23,7 @@
 #include <linux/usb.h>
 #include <linux/usb/hcd.h>
 #include <linux/usb/ehci_pdriver.h>
+#include <linux/pinctrl/consumer.h>
 
 #include "ehci.h"
 
-- 
2.15.1

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 64+ messages in thread

* linux-next: build failure in Linus' tree
@ 2017-09-17 23:34 Stephen Rothwell
  0 siblings, 0 replies; 64+ messages in thread
From: Stephen Rothwell @ 2017-09-17 23:34 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Jan H. Schönherr, Paolo Bonzini

Hi Linus,

With just your tree, today's linux-next build (powerpc ppc64_defconfig)
failed like this:

arch/powerpc/kvm/../../../virt/kvm/eventfd.c: In function 'kvm_irqfd':
arch/powerpc/kvm/../../../virt/kvm/eventfd.c:568:19: error: 'KVM_MAX_IRQ_ROUTES' undeclared (first use in this function)
  if (args->gsi >= KVM_MAX_IRQ_ROUTES)
                   ^

Caused by commit

  36ae3c0a36b7 ("KVM: Don't accept obviously wrong gsi values via KVM_IRQFD")

KVM_MAX_IRQ_ROUTES is only defined when CONFIG_HAVE_KVM_IRQ_ROUTING is
defined (which for PowerPC is only when CONFIG_KVM_MPIC is defined which
depends on CONFIG_E500).

I have just reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2016-03-27  6:06 Stephen Rothwell
@ 2016-03-28 20:44 ` Arnaldo Carvalho de Melo
  0 siblings, 0 replies; 64+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-03-28 20:44 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linus Torvalds, Thomas Gleixner, Ingo Molnar, H. Peter Anvin,
	Peter Zijlstra, linux-next, linux-kernel

Em Sun, Mar 27, 2016 at 05:06:18PM +1100, Stephen Rothwell escreveu:
> Hi all,
> 
> After merging the fixes tree, today's linux-next build (perf powerpcle)
> failed like this:
> 
> arch/powerpc/util/header.c:17:1: error: no previous prototype for 'get_cpuid' [-Werror=missing-prototypes]
>  get_cpuid(char *buffer, size_t sz)
>  ^
> arch/powerpc/util/header.c: In function 'get_cpuid':
> arch/powerpc/util/header.c:24:7: error: implicit declaration of function 'scnprintf' [-Werror=implicit-function-declaration]
>   nb = scnprintf(buffer, sz, "%lu,%lu$", PVR_VER(pvr), PVR_REV(pvr));
>        ^
> arch/powerpc/util/header.c:24:2: error: nested extern declaration of 'scnprintf' [-Werror=nested-externs]
>   nb = scnprintf(buffer, sz, "%lu,%lu$", PVR_VER(pvr), PVR_REV(pvr));
>   ^
> 
> Caused by commit
> 
>   531d2410635c ("perf tools: Do not include stringify.h from the kernel sources")
> 
> I added the following fix patch for for today:

I have the fix and got a docker image with ubuntu cross-compiling to
ppc64 and ppc64le, will submit the patch now.

- Arnaldo
 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Sun, 27 Mar 2016 14:44:26 +1100
> Subject: [PATCH] perf tools: we stil need header.h for various things
> 
> Fixes:  531d2410635c ("perf tools: Do not include stringify.h from the kernel sources")
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  tools/perf/arch/powerpc/util/header.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/perf/arch/powerpc/util/header.c b/tools/perf/arch/powerpc/util/header.c
> index 6138bdef6e63..8a0191a11f87 100644
> --- a/tools/perf/arch/powerpc/util/header.c
> +++ b/tools/perf/arch/powerpc/util/header.c
> @@ -5,6 +5,8 @@
>  #include <string.h>
>  #include <linux/stringify.h>
>  
> +#include "../../util/header.h"
> +
>  #define mfspr(rn)       ({unsigned long rval; \
>  			 asm volatile("mfspr %0," __stringify(rn) \
>  				      : "=r" (rval)); rval; })
> -- 
> 2.7.0
> 
> -- 
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 64+ messages in thread

* linux-next: build failure in Linus' tree
@ 2016-03-27  6:06 Stephen Rothwell
  2016-03-28 20:44 ` Arnaldo Carvalho de Melo
  0 siblings, 1 reply; 64+ messages in thread
From: Stephen Rothwell @ 2016-03-27  6:06 UTC (permalink / raw)
  To: Linus Torvalds, Thomas Gleixner, Ingo Molnar, H. Peter Anvin,
	Peter Zijlstra
  Cc: linux-next, linux-kernel, Arnaldo Carvalho de Melo

Hi all,

After merging the fixes tree, today's linux-next build (perf powerpcle)
failed like this:

arch/powerpc/util/header.c:17:1: error: no previous prototype for 'get_cpuid' [-Werror=missing-prototypes]
 get_cpuid(char *buffer, size_t sz)
 ^
arch/powerpc/util/header.c: In function 'get_cpuid':
arch/powerpc/util/header.c:24:7: error: implicit declaration of function 'scnprintf' [-Werror=implicit-function-declaration]
  nb = scnprintf(buffer, sz, "%lu,%lu$", PVR_VER(pvr), PVR_REV(pvr));
       ^
arch/powerpc/util/header.c:24:2: error: nested extern declaration of 'scnprintf' [-Werror=nested-externs]
  nb = scnprintf(buffer, sz, "%lu,%lu$", PVR_VER(pvr), PVR_REV(pvr));
  ^

Caused by commit

  531d2410635c ("perf tools: Do not include stringify.h from the kernel sources")

I added the following fix patch for for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Sun, 27 Mar 2016 14:44:26 +1100
Subject: [PATCH] perf tools: we stil need header.h for various things

Fixes:  531d2410635c ("perf tools: Do not include stringify.h from the kernel sources")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 tools/perf/arch/powerpc/util/header.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/perf/arch/powerpc/util/header.c b/tools/perf/arch/powerpc/util/header.c
index 6138bdef6e63..8a0191a11f87 100644
--- a/tools/perf/arch/powerpc/util/header.c
+++ b/tools/perf/arch/powerpc/util/header.c
@@ -5,6 +5,8 @@
 #include <string.h>
 #include <linux/stringify.h>
 
+#include "../../util/header.h"
+
 #define mfspr(rn)       ({unsigned long rval; \
 			 asm volatile("mfspr %0," __stringify(rn) \
 				      : "=r" (rval)); rval; })
-- 
2.7.0

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2014-11-03  4:09 Stephen Rothwell
@ 2014-11-03  4:16 ` David Miller
  0 siblings, 0 replies; 64+ messages in thread
From: David Miller @ 2014-11-03  4:16 UTC (permalink / raw)
  To: sfr; +Cc: torvalds, netdev, linux-next, linux-kernel, pablo

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 3 Nov 2014 15:09:30 +1100

> Hi Linus,
> 
> With Linus' tree, today's linux-next build (powerpc allyesconfig)
> failed like this:
> 
> net/bridge/netfilter/nft_reject_bridge.c: In function 'nft_reject_br_send_v6_unreach':
> net/bridge/netfilter/nft_reject_bridge.c:240:3: error: implicit declaration of function 'csum_ipv6_magic' [-Werror=implicit-function-declaration]
>    csum_ipv6_magic(&nip6h->saddr, &nip6h->daddr,
>    ^
> 
> Caused by commit 523b929d5446 ("netfilter: nft_reject_bridge: don't use
> IP stack to reject traffic") from Linus' tree.
> 
> I applied the following patch for today:

Yep, another person hit this today and submitted a patch too:

http://patchwork.ozlabs.org/patch/406003/

I'll get this into the net tree ASAP.

^ permalink raw reply	[flat|nested] 64+ messages in thread

* linux-next: build failure in Linus' tree
@ 2014-11-03  4:09 Stephen Rothwell
  2014-11-03  4:16 ` David Miller
  0 siblings, 1 reply; 64+ messages in thread
From: Stephen Rothwell @ 2014-11-03  4:09 UTC (permalink / raw)
  To: Linus Torvalds, David Miller, netdev
  Cc: linux-next, linux-kernel, Pablo Neira Ayuso

[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]

Hi Linus,

With Linus' tree, today's linux-next build (powerpc allyesconfig)
failed like this:

net/bridge/netfilter/nft_reject_bridge.c: In function 'nft_reject_br_send_v6_unreach':
net/bridge/netfilter/nft_reject_bridge.c:240:3: error: implicit declaration of function 'csum_ipv6_magic' [-Werror=implicit-function-declaration]
   csum_ipv6_magic(&nip6h->saddr, &nip6h->daddr,
   ^

Caused by commit 523b929d5446 ("netfilter: nft_reject_bridge: don't use
IP stack to reject traffic") from Linus' tree.

I applied the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 3 Nov 2014 15:01:16 +1100
Subject: [PATCH] netfilter: nft_reject_bridge: include ip6_checksum.h for csum_ipv6_magic

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/bridge/netfilter/nft_reject_bridge.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/bridge/netfilter/nft_reject_bridge.c b/net/bridge/netfilter/nft_reject_bridge.c
index 654c9018e3e7..1123f2b4a1b1 100644
--- a/net/bridge/netfilter/nft_reject_bridge.c
+++ b/net/bridge/netfilter/nft_reject_bridge.c
@@ -16,6 +16,7 @@
 #include <net/netfilter/nft_reject.h>
 #include <net/netfilter/ipv4/nf_reject.h>
 #include <net/netfilter/ipv6/nf_reject.h>
+#include <net/ip6_checksum.h>
 #include <linux/ip.h>
 #include <net/ip.h>
 #include <linux/netfilter_bridge.h>
-- 
2.1.1

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2012-07-27  0:15 Stephen Rothwell
  2012-07-27  0:23 ` Stephen Rothwell
@ 2012-07-27  1:04 ` Linus Torvalds
  1 sibling, 0 replies; 64+ messages in thread
From: Linus Torvalds @ 2012-07-27  1:04 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: linux-next, linux-kernel, Alexander Block, David Sterba,
	Arne Jansen, Jan Schmidt, Alex Lyakas, Chris Mason

On Thu, Jul 26, 2012 at 5:15 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the origin tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:

Oh well. I did an x86-64 build after that pull (because of the need
for that semantic merge thing), but apparently x86-64 gets the
vmalloc.h indirectly through some other header.

          Linus

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2012-07-27  0:15 Stephen Rothwell
@ 2012-07-27  0:23 ` Stephen Rothwell
  2012-07-27  1:04 ` Linus Torvalds
  1 sibling, 0 replies; 64+ messages in thread
From: Stephen Rothwell @ 2012-07-27  0:23 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: linux-next, linux-kernel, Alexander Block, David Sterba,
	Arne Jansen, Jan Schmidt, Alex Lyakas, Chris Mason

[-- Attachment #1: Type: text/plain, Size: 362 bytes --]

On Fri, 27 Jul 2012 10:15:35 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 27 Jul 2012 10:11:13 +1000
> Subject: [PATCH] Btrfs: using vrmzalloc and friends needs vmalloc.h

That should say "vmalloc". of course.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 64+ messages in thread

* linux-next: build failure in Linus' tree
@ 2012-07-27  0:15 Stephen Rothwell
  2012-07-27  0:23 ` Stephen Rothwell
  2012-07-27  1:04 ` Linus Torvalds
  0 siblings, 2 replies; 64+ messages in thread
From: Stephen Rothwell @ 2012-07-27  0:15 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: linux-next, linux-kernel, Alexander Block, David Sterba,
	Arne Jansen, Jan Schmidt, Alex Lyakas, Chris Mason

[-- Attachment #1: Type: text/plain, Size: 4065 bytes --]

Hi Linus,

After merging the origin tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

fs/btrfs/send.c: In function 'fs_path_free':
fs/btrfs/send.c:185:4: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
fs/btrfs/send.c: In function 'fs_path_ensure_buf':
fs/btrfs/send.c:215:4: error: implicit declaration of function 'vmalloc' [-Werror=implicit-function-declaration]
fs/btrfs/send.c:215:12: warning: assignment makes pointer from integer without a cast [enabled by default]
fs/btrfs/send.c:225:12: warning: assignment makes pointer from integer without a cast [enabled by default]
fs/btrfs/send.c:233:13: warning: assignment makes pointer from integer without a cast [enabled by default]
fs/btrfs/send.c: In function 'iterate_dir_item':
fs/btrfs/send.c:900:10: warning: assignment makes pointer from integer without a cast [enabled by default]
fs/btrfs/send.c:909:11: warning: assignment makes pointer from integer without a cast [enabled by default]
fs/btrfs/send.c: In function 'btrfs_ioctl_send':
fs/btrfs/send.c:4463:17: warning: assignment makes pointer from integer without a cast [enabled by default]
fs/btrfs/send.c:4469:17: warning: assignment makes pointer from integer without a cast [enabled by default]
fs/btrfs/send.c:4475:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
fs/btrfs/send.c:4475:20: warning: assignment makes pointer from integer without a cast [enabled by default]
fs/btrfs/send.c:4483:21: warning: assignment makes pointer from integer without a cast [enabled by default]

Caused by commit 31db9f7c23fb ("Btrfs: introduce BTRFS_IOC_SEND for btrfs
send/receive").

P.S. Chris, can we please get the btrfs tree into linux-next?

I added this patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 27 Jul 2012 10:11:13 +1000
Subject: [PATCH] Btrfs: using vrmzalloc and friends needs vmalloc.h

Fixes these build errors:

fs/btrfs/send.c: In function 'fs_path_free':
fs/btrfs/send.c:185:4: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
fs/btrfs/send.c: In function 'fs_path_ensure_buf':
fs/btrfs/send.c:215:4: error: implicit declaration of function 'vmalloc' [-Werror=implicit-function-declaration]
fs/btrfs/send.c:215:12: warning: assignment makes pointer from integer without a cast [enabled by default]
fs/btrfs/send.c:225:12: warning: assignment makes pointer from integer without a cast [enabled by default]
fs/btrfs/send.c:233:13: warning: assignment makes pointer from integer without a cast [enabled by default]
fs/btrfs/send.c: In function 'iterate_dir_item':
fs/btrfs/send.c:900:10: warning: assignment makes pointer from integer without a cast [enabled by default]
fs/btrfs/send.c:909:11: warning: assignment makes pointer from integer without a cast [enabled by default]
fs/btrfs/send.c: In function 'btrfs_ioctl_send':
fs/btrfs/send.c:4463:17: warning: assignment makes pointer from integer without a cast [enabled by default]
fs/btrfs/send.c:4469:17: warning: assignment makes pointer from integer without a cast [enabled by default]
fs/btrfs/send.c:4475:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
fs/btrfs/send.c:4475:20: warning: assignment makes pointer from integer without a cast [enabled by default]
fs/btrfs/send.c:4483:21: warning: assignment makes pointer from integer without a cast [enabled by default]

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 fs/btrfs/send.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
index c8ca49b..fb5ffe9 100644
--- a/fs/btrfs/send.c
+++ b/fs/btrfs/send.c
@@ -25,6 +25,7 @@
 #include <linux/posix_acl_xattr.h>
 #include <linux/radix-tree.h>
 #include <linux/crc32c.h>
+#include <linux/vmalloc.h>
 
 #include "send.h"
 #include "backref.h"
-- 
1.7.10.280.gaa39

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2012-06-17 23:38         ` Benjamin Herrenschmidt
@ 2012-06-18  4:58           ` Paul Mundt
  0 siblings, 0 replies; 64+ messages in thread
From: Paul Mundt @ 2012-06-18  4:58 UTC (permalink / raw)
  To: Benjamin Herrenschmidt
  Cc: Stephen Rothwell, Linus Torvalds, linux-next, linux-kernel,
	Al Viro, Arnd Bergmann

On Mon, Jun 18, 2012 at 09:38:58AM +1000, Benjamin Herrenschmidt wrote:
> On Fri, 2012-06-15 at 09:56 +0900, Paul Mundt wrote:
> > Will do, thanks for testing.
> 
> Ping ? :-)
> 
> All the powerpc builds are still broken...
> 
Sent now, sorry about the delay! As I was about to send it earlier,
someone else reported an x86 build failure that looked related, so I held
off until I could properly test it (I didn't want to just trade one
platform breakage for another). In the end it was unrelated to the patch
in question.

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2012-06-15  0:56       ` Paul Mundt
@ 2012-06-17 23:38         ` Benjamin Herrenschmidt
  2012-06-18  4:58           ` Paul Mundt
  0 siblings, 1 reply; 64+ messages in thread
From: Benjamin Herrenschmidt @ 2012-06-17 23:38 UTC (permalink / raw)
  To: Paul Mundt
  Cc: Stephen Rothwell, Linus Torvalds, linux-next, linux-kernel,
	Al Viro, Arnd Bergmann

On Fri, 2012-06-15 at 09:56 +0900, Paul Mundt wrote:
> Will do, thanks for testing.

Ping ? :-)

All the powerpc builds are still broken...

Cheers,
Ben.

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2012-06-14  3:40   ` Paul Mundt
  2012-06-15  0:14     ` Stephen Rothwell
  2012-06-15  8:46     ` Richard W.M. Jones
@ 2012-06-15 11:38     ` Arnd Bergmann
  2 siblings, 0 replies; 64+ messages in thread
From: Arnd Bergmann @ 2012-06-15 11:38 UTC (permalink / raw)
  To: Paul Mundt
  Cc: Stephen Rothwell, Linus Torvalds, linux-next, linux-kernel, Al Viro

On Thursday 14 June 2012, Paul Mundt wrote:
> Ok, it's because the asm-generic/bug.h __ASSEMBLY__ guarding is
> completely bogus. This should hopefully fix it once and for all.
> Sorry for the trouble.
> 
> Signed-off-by: Paul Mundt <lethal@linux-sh.org>

Acked-by: Arnd Bergmann <arnd@arndb.de>

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2012-06-15  9:23       ` Sedat Dilek
@ 2012-06-15 10:15         ` Sedat Dilek
  0 siblings, 0 replies; 64+ messages in thread
From: Sedat Dilek @ 2012-06-15 10:15 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Paul Mundt, Linus Torvalds, linux-next, linux-kernel, Al Viro,
	Arnd Bergmann

On Fri, Jun 15, 2012 at 11:23 AM, Sedat Dilek
<sedat.dilek@googlemail.com> wrote:
> On Fri, Jun 15, 2012 at 2:14 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> Hi Paul,
>>
>> On Thu, 14 Jun 2012 12:40:36 +0900 Paul Mundt <lethal@linux-sh.org> wrote:
>>>
>>> (adding Arnd to Cc, who I forgot to include previously)
>>>
>>> On Thu, Jun 14, 2012 at 12:06:06PM +0900, Paul Mundt wrote:
>>> > On Thu, Jun 14, 2012 at 11:47:22AM +1000, Stephen Rothwell wrote:
>>> > > While building Linus' tree, today's linux-next build (powerpc
>>> > > ppc64_defconfig) failed like this:
>>> > >
>>> > > In file included from include/asm-generic/bug.h:5:0,
>>> > >                  from arch/powerpc/include/asm/bug.h:127,
>>> > >                  from arch/powerpc/kernel/head_64.S:31:
>>> > > include/linux/kernel.h:44:0: warning: "ALIGN" redefined [enabled by default]
>>> > > include/linux/linkage.h:57:0: note: this is the location of the previous definition
>>> > > include/linux/sysinfo.h: Assembler messages:
>>> > > include/linux/sysinfo.h:7: Error: Unrecognized opcode: `struct'
>>> > > include/linux/sysinfo.h:8: Error: Unrecognized opcode: `__kernel_long_t'
>>> > >
>>> > > And it went downhill from there :-(
>>> > >
>>> > > Caused by commit 3777808873b0 ("bug.h: need linux/kernel.h for
>>> > > TAINT_WARN") which, unfortunately never made it into linux-next.
>>> > >
>>> > > I have reverted that commit for today (which presumably means that sh
>>> > > builds will be broken again).
>>> >
>>> > I'm still unsure as to the best way to fix this, and there was no
>>> > response to the original mail I posted about it either:
>>> >
>>> > http://marc.info/?l=linux-kernel&m=133879579014853&w=2
>>> >
>>> > I'll fetch a powerpc cross compiler and see if I can figure out what went
>>> > wrong.
>>> >
>>> Ok, it's because the asm-generic/bug.h __ASSEMBLY__ guarding is
>>> completely bogus. This should hopefully fix it once and for all.
>>> Sorry for the trouble.
>>>
>>> Signed-off-by: Paul Mundt <lethal@linux-sh.org>
>>
>> Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>
>>
>> Can you create a proper commit message and send this to Linus, please?  I
>> have included it in my fixes tree in linux-next for today.
>>
>
> Reference: commit 2a6f7f6bd7a9eb3c835c7e5a7d51b43675fb3881 ("fix
> bug.h's inclusion of kernel.h")
>

Hope people don't treat this as nitpicking:
I looked through the last commits to the involved file, all commits
are labeled with "bug.h: ...", so follow the "rule"...

"bug.h: Fix inclusion of kernel.h"

> - Sedat -
>
> [1] http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=2a6f7f6bd7a9eb3c835c7e5a7d51b43675fb3881
>
>> --
>> Cheers,
>> Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2012-06-15  0:14     ` Stephen Rothwell
  2012-06-15  0:56       ` Paul Mundt
@ 2012-06-15  9:23       ` Sedat Dilek
  2012-06-15 10:15         ` Sedat Dilek
  1 sibling, 1 reply; 64+ messages in thread
From: Sedat Dilek @ 2012-06-15  9:23 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Paul Mundt, Linus Torvalds, linux-next, linux-kernel, Al Viro,
	Arnd Bergmann

On Fri, Jun 15, 2012 at 2:14 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Paul,
>
> On Thu, 14 Jun 2012 12:40:36 +0900 Paul Mundt <lethal@linux-sh.org> wrote:
>>
>> (adding Arnd to Cc, who I forgot to include previously)
>>
>> On Thu, Jun 14, 2012 at 12:06:06PM +0900, Paul Mundt wrote:
>> > On Thu, Jun 14, 2012 at 11:47:22AM +1000, Stephen Rothwell wrote:
>> > > While building Linus' tree, today's linux-next build (powerpc
>> > > ppc64_defconfig) failed like this:
>> > >
>> > > In file included from include/asm-generic/bug.h:5:0,
>> > >                  from arch/powerpc/include/asm/bug.h:127,
>> > >                  from arch/powerpc/kernel/head_64.S:31:
>> > > include/linux/kernel.h:44:0: warning: "ALIGN" redefined [enabled by default]
>> > > include/linux/linkage.h:57:0: note: this is the location of the previous definition
>> > > include/linux/sysinfo.h: Assembler messages:
>> > > include/linux/sysinfo.h:7: Error: Unrecognized opcode: `struct'
>> > > include/linux/sysinfo.h:8: Error: Unrecognized opcode: `__kernel_long_t'
>> > >
>> > > And it went downhill from there :-(
>> > >
>> > > Caused by commit 3777808873b0 ("bug.h: need linux/kernel.h for
>> > > TAINT_WARN") which, unfortunately never made it into linux-next.
>> > >
>> > > I have reverted that commit for today (which presumably means that sh
>> > > builds will be broken again).
>> >
>> > I'm still unsure as to the best way to fix this, and there was no
>> > response to the original mail I posted about it either:
>> >
>> > http://marc.info/?l=linux-kernel&m=133879579014853&w=2
>> >
>> > I'll fetch a powerpc cross compiler and see if I can figure out what went
>> > wrong.
>> >
>> Ok, it's because the asm-generic/bug.h __ASSEMBLY__ guarding is
>> completely bogus. This should hopefully fix it once and for all.
>> Sorry for the trouble.
>>
>> Signed-off-by: Paul Mundt <lethal@linux-sh.org>
>
> Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
> Can you create a proper commit message and send this to Linus, please?  I
> have included it in my fixes tree in linux-next for today.
>

Reference: commit 2a6f7f6bd7a9eb3c835c7e5a7d51b43675fb3881 ("fix
bug.h's inclusion of kernel.h")

- Sedat -

[1] http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=2a6f7f6bd7a9eb3c835c7e5a7d51b43675fb3881

> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2012-06-14  3:40   ` Paul Mundt
  2012-06-15  0:14     ` Stephen Rothwell
@ 2012-06-15  8:46     ` Richard W.M. Jones
  2012-06-15 11:38     ` Arnd Bergmann
  2 siblings, 0 replies; 64+ messages in thread
From: Richard W.M. Jones @ 2012-06-15  8:46 UTC (permalink / raw)
  To: Paul Mundt
  Cc: Stephen Rothwell, Linus Torvalds, linux-next, linux-kernel,
	Al Viro, Arnd Bergmann

On Thu, Jun 14, 2012 at 12:40:36PM +0900, Paul Mundt wrote:
> Ok, it's because the asm-generic/bug.h __ASSEMBLY__ guarding is
> completely bogus. This should hopefully fix it once and for all.
> Sorry for the trouble.

I can confirm this fixes the build on ppc64 for me too.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.
http://et.redhat.com/~rjones/virt-p2v

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2012-06-15  0:14     ` Stephen Rothwell
@ 2012-06-15  0:56       ` Paul Mundt
  2012-06-17 23:38         ` Benjamin Herrenschmidt
  2012-06-15  9:23       ` Sedat Dilek
  1 sibling, 1 reply; 64+ messages in thread
From: Paul Mundt @ 2012-06-15  0:56 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linus Torvalds, linux-next, linux-kernel, Al Viro, Arnd Bergmann

On Fri, Jun 15, 2012 at 10:14:07AM +1000, Stephen Rothwell wrote:
> On Thu, 14 Jun 2012 12:40:36 +0900 Paul Mundt <lethal@linux-sh.org> wrote:
> > Ok, it's because the asm-generic/bug.h __ASSEMBLY__ guarding is
> > completely bogus. This should hopefully fix it once and for all.
> > Sorry for the trouble.
> > 
> > Signed-off-by: Paul Mundt <lethal@linux-sh.org>
> 
> Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>
> 
> Can you create a proper commit message and send this to Linus, please?  I
> have included it in my fixes tree in linux-next for today.
> 
Will do, thanks for testing.

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2012-06-14  3:40   ` Paul Mundt
@ 2012-06-15  0:14     ` Stephen Rothwell
  2012-06-15  0:56       ` Paul Mundt
  2012-06-15  9:23       ` Sedat Dilek
  2012-06-15  8:46     ` Richard W.M. Jones
  2012-06-15 11:38     ` Arnd Bergmann
  2 siblings, 2 replies; 64+ messages in thread
From: Stephen Rothwell @ 2012-06-15  0:14 UTC (permalink / raw)
  To: Paul Mundt
  Cc: Linus Torvalds, linux-next, linux-kernel, Al Viro, Arnd Bergmann

[-- Attachment #1: Type: text/plain, Size: 2084 bytes --]

Hi Paul,

On Thu, 14 Jun 2012 12:40:36 +0900 Paul Mundt <lethal@linux-sh.org> wrote:
>
> (adding Arnd to Cc, who I forgot to include previously)
> 
> On Thu, Jun 14, 2012 at 12:06:06PM +0900, Paul Mundt wrote:
> > On Thu, Jun 14, 2012 at 11:47:22AM +1000, Stephen Rothwell wrote:
> > > While building Linus' tree, today's linux-next build (powerpc
> > > ppc64_defconfig) failed like this:
> > > 
> > > In file included from include/asm-generic/bug.h:5:0,
> > >                  from arch/powerpc/include/asm/bug.h:127,
> > >                  from arch/powerpc/kernel/head_64.S:31:
> > > include/linux/kernel.h:44:0: warning: "ALIGN" redefined [enabled by default]
> > > include/linux/linkage.h:57:0: note: this is the location of the previous definition
> > > include/linux/sysinfo.h: Assembler messages:
> > > include/linux/sysinfo.h:7: Error: Unrecognized opcode: `struct'
> > > include/linux/sysinfo.h:8: Error: Unrecognized opcode: `__kernel_long_t'
> > > 
> > > And it went downhill from there :-(
> > > 
> > > Caused by commit 3777808873b0 ("bug.h: need linux/kernel.h for
> > > TAINT_WARN") which, unfortunately never made it into linux-next.
> > > 
> > > I have reverted that commit for today (which presumably means that sh
> > > builds will be broken again).
> > 
> > I'm still unsure as to the best way to fix this, and there was no
> > response to the original mail I posted about it either:
> > 
> > http://marc.info/?l=linux-kernel&m=133879579014853&w=2
> > 
> > I'll fetch a powerpc cross compiler and see if I can figure out what went
> > wrong.
> > 
> Ok, it's because the asm-generic/bug.h __ASSEMBLY__ guarding is
> completely bogus. This should hopefully fix it once and for all.
> Sorry for the trouble.
> 
> Signed-off-by: Paul Mundt <lethal@linux-sh.org>

Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>

Can you create a proper commit message and send this to Linus, please?  I
have included it in my fixes tree in linux-next for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2012-06-14  3:06 ` Paul Mundt
@ 2012-06-14  3:40   ` Paul Mundt
  2012-06-15  0:14     ` Stephen Rothwell
                       ` (2 more replies)
  0 siblings, 3 replies; 64+ messages in thread
From: Paul Mundt @ 2012-06-14  3:40 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linus Torvalds, linux-next, linux-kernel, Al Viro, Arnd Bergmann

(adding Arnd to Cc, who I forgot to include previously)

On Thu, Jun 14, 2012 at 12:06:06PM +0900, Paul Mundt wrote:
> On Thu, Jun 14, 2012 at 11:47:22AM +1000, Stephen Rothwell wrote:
> > While building Linus' tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> > 
> > In file included from include/asm-generic/bug.h:5:0,
> >                  from arch/powerpc/include/asm/bug.h:127,
> >                  from arch/powerpc/kernel/head_64.S:31:
> > include/linux/kernel.h:44:0: warning: "ALIGN" redefined [enabled by default]
> > include/linux/linkage.h:57:0: note: this is the location of the previous definition
> > include/linux/sysinfo.h: Assembler messages:
> > include/linux/sysinfo.h:7: Error: Unrecognized opcode: `struct'
> > include/linux/sysinfo.h:8: Error: Unrecognized opcode: `__kernel_long_t'
> > 
> > And it went downhill from there :-(
> > 
> > Caused by commit 3777808873b0 ("bug.h: need linux/kernel.h for
> > TAINT_WARN") which, unfortunately never made it into linux-next.
> > 
> > I have reverted that commit for today (which presumably means that sh
> > builds will be broken again).
> 
> I'm still unsure as to the best way to fix this, and there was no
> response to the original mail I posted about it either:
> 
> http://marc.info/?l=linux-kernel&m=133879579014853&w=2
> 
> I'll fetch a powerpc cross compiler and see if I can figure out what went
> wrong.
> 
Ok, it's because the asm-generic/bug.h __ASSEMBLY__ guarding is
completely bogus. This should hopefully fix it once and for all.
Sorry for the trouble.

Signed-off-by: Paul Mundt <lethal@linux-sh.org>

---

 include/asm-generic/bug.h |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
index 9f02005..506ec19 100644
--- a/include/asm-generic/bug.h
+++ b/include/asm-generic/bug.h
@@ -2,7 +2,6 @@
 #define _ASM_GENERIC_BUG_H
 
 #include <linux/compiler.h>
-#include <linux/kernel.h>
 
 #ifdef CONFIG_BUG
 
@@ -32,6 +31,9 @@ struct bug_entry {
 
 #endif	/* CONFIG_GENERIC_BUG */
 
+#ifndef __ASSEMBLY__
+#include <linux/kernel.h>
+
 /*
  * Don't use BUG() or BUG_ON() unless there's really no way out; one
  * example might be detecting data structure corruption in the middle
@@ -61,7 +63,6 @@ struct bug_entry {
  * to provide better diagnostics.
  */
 #ifndef __WARN_TAINT
-#ifndef __ASSEMBLY__
 extern __printf(3, 4)
 void warn_slowpath_fmt(const char *file, const int line,
 		       const char *fmt, ...);
@@ -70,7 +71,6 @@ void warn_slowpath_fmt_taint(const char *file, const int line, unsigned taint,
 			     const char *fmt, ...);
 extern void warn_slowpath_null(const char *file, const int line);
 #define WANT_WARN_ON_SLOWPATH
-#endif
 #define __WARN()		warn_slowpath_null(__FILE__, __LINE__)
 #define __WARN_printf(arg...)	warn_slowpath_fmt(__FILE__, __LINE__, arg)
 #define __WARN_printf_taint(taint, arg...)				\
@@ -203,4 +203,6 @@ extern void warn_slowpath_null(const char *file, const int line);
 # define WARN_ON_SMP(x)			({0;})
 #endif
 
+#endif /* __ASSEMBLY__ */
+
 #endif

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2012-06-14  1:47 Stephen Rothwell
@ 2012-06-14  3:06 ` Paul Mundt
  2012-06-14  3:40   ` Paul Mundt
  0 siblings, 1 reply; 64+ messages in thread
From: Paul Mundt @ 2012-06-14  3:06 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Linus Torvalds, linux-next, linux-kernel, Al Viro

On Thu, Jun 14, 2012 at 11:47:22AM +1000, Stephen Rothwell wrote:
> Hi Linus,
> 
> While building Linus' tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> In file included from include/asm-generic/bug.h:5:0,
>                  from arch/powerpc/include/asm/bug.h:127,
>                  from arch/powerpc/kernel/head_64.S:31:
> include/linux/kernel.h:44:0: warning: "ALIGN" redefined [enabled by default]
> include/linux/linkage.h:57:0: note: this is the location of the previous definition
> include/linux/sysinfo.h: Assembler messages:
> include/linux/sysinfo.h:7: Error: Unrecognized opcode: `struct'
> include/linux/sysinfo.h:8: Error: Unrecognized opcode: `__kernel_long_t'
> 
> And it went downhill from there :-(
> 
> Caused by commit 3777808873b0 ("bug.h: need linux/kernel.h for
> TAINT_WARN") which, unfortunately never made it into linux-next.
> 
> I have reverted that commit for today (which presumably means that sh
> builds will be broken again).

I'm still unsure as to the best way to fix this, and there was no
response to the original mail I posted about it either:

http://marc.info/?l=linux-kernel&m=133879579014853&w=2

I'll fetch a powerpc cross compiler and see if I can figure out what went
wrong.

We can always bite the bullet and stuff it in the sh thread_info.h, but
that's papering around the issue, and any other TIF_RESTORE_SIGMASK &&
!HAVE_SET_RESTORE_SIGMASK generic bug user will have to use the same
hack.

^ permalink raw reply	[flat|nested] 64+ messages in thread

* linux-next: build failure in Linus' tree
@ 2012-06-14  1:47 Stephen Rothwell
  2012-06-14  3:06 ` Paul Mundt
  0 siblings, 1 reply; 64+ messages in thread
From: Stephen Rothwell @ 2012-06-14  1:47 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-next, linux-kernel, Paul Mundt, Al Viro

[-- Attachment #1: Type: text/plain, Size: 979 bytes --]

Hi Linus,

While building Linus' tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from include/asm-generic/bug.h:5:0,
                 from arch/powerpc/include/asm/bug.h:127,
                 from arch/powerpc/kernel/head_64.S:31:
include/linux/kernel.h:44:0: warning: "ALIGN" redefined [enabled by default]
include/linux/linkage.h:57:0: note: this is the location of the previous definition
include/linux/sysinfo.h: Assembler messages:
include/linux/sysinfo.h:7: Error: Unrecognized opcode: `struct'
include/linux/sysinfo.h:8: Error: Unrecognized opcode: `__kernel_long_t'

And it went downhill from there :-(

Caused by commit 3777808873b0 ("bug.h: need linux/kernel.h for
TAINT_WARN") which, unfortunately never made it into linux-next.

I have reverted that commit for today (which presumably means that sh
builds will be broken again).
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2012-05-14  6:57 ` Grant Likely
@ 2012-05-14  8:32   ` Thomas Gleixner
  0 siblings, 0 replies; 64+ messages in thread
From: Thomas Gleixner @ 2012-05-14  8:32 UTC (permalink / raw)
  To: Grant Likely
  Cc: Stephen Rothwell, Linus Torvalds, linux-next, linux-kernel,
	David S. Miller, Jean-Francois Dagenais

On Mon, 14 May 2012, Grant Likely wrote:
> On Mon, 14 May 2012 10:50:25 +1000, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > Hi Linus,
> > 
> > Building Linus' tree, today's linux-next build (x86_64 allmodconfig)
> > failed like this:
> > 
> > ERROR: "handle_edge_irq" [drivers/gpio/gpio-pch.ko] undefined!
> > ERROR: "irq_to_desc" [drivers/gpio/gpio-pch.ko] undefined!
> > 
> > This has been reported elsewhere by DaveM.
> > 
> > Caused by commit df9541a60af0 ("gpio: pch9: Use proper flow type handlers").
> > 
> > I have reverted that commit for today.
> 
> Gah, I tested that patch with CONFIG_GPIO_PCH=Y, but not as a module.
> I see three options here; revert the patch now and fix it up in v3.4,
> add exports for those two symbols, or disable building that code as a
> module (patch below).  Personally I prefer the third option for the
> immediate fix.

I was about to queue the exports, but this one is good as well.

Thanks,

	tglx
> g.
> 
> >From 7fd0fcff9f0d65734415fed756271c1ae2267666 Mon Sep 17 00:00:00 2001
> From: Grant Likely <grant.likely@secretlab.ca>
> Date: Mon, 14 May 2012 00:52:49 -0600
> Subject: [PATCH] gpio/pch: Fix build failure when selected as a module
> 
> x86_64 allmodconfig fails like this:
> 
> ERROR: "handle_edge_irq" [drivers/gpio/gpio-pch.ko] undefined!
> ERROR: "irq_to_desc" [drivers/gpio/gpio-pch.ko] undefined!
> 
> This patch fixes the issue by not allowing gpio-pch.c to be built as a
> module.  It can be reenabled when the core interrupt handling code
> exports the missing symbols, but that change needs some review first.
> 
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> Cc: Thomas Gleixner <tglx@linutronix.de>

Acked-by: Thomas Gleixner <tglx@linutronix.de>

> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/gpio/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index e03653d..db146d5 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -403,7 +403,7 @@ config GPIO_LANGWELL
> 	  Say Y here to support Intel Langwell/Penwell GPIO.
>  
>  config GPIO_PCH
> -	tristate "Intel EG20T PCH/LAPIS Semiconductor IOH(ML7223/ML7831) GPIO"
> +	bool "Intel EG20T PCH/LAPIS Semiconductor IOH(ML7223/ML7831) GPIO"
> 	depends on PCI && X86
> 	select GENERIC_IRQ_CHIP
> 	help
> -- 
> 1.7.9.5
> 
> 
> 
> 

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2012-05-14  0:50 Stephen Rothwell
@ 2012-05-14  6:57 ` Grant Likely
  2012-05-14  8:32   ` Thomas Gleixner
  0 siblings, 1 reply; 64+ messages in thread
From: Grant Likely @ 2012-05-14  6:57 UTC (permalink / raw)
  To: Stephen Rothwell, Linus Torvalds
  Cc: linux-next, linux-kernel, David S. Miller, Thomas Gleixner,
	Jean-Francois Dagenais

On Mon, 14 May 2012 10:50:25 +1000, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Linus,
> 
> Building Linus' tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> ERROR: "handle_edge_irq" [drivers/gpio/gpio-pch.ko] undefined!
> ERROR: "irq_to_desc" [drivers/gpio/gpio-pch.ko] undefined!
> 
> This has been reported elsewhere by DaveM.
> 
> Caused by commit df9541a60af0 ("gpio: pch9: Use proper flow type handlers").
> 
> I have reverted that commit for today.

Gah, I tested that patch with CONFIG_GPIO_PCH=Y, but not as a module.
I see three options here; revert the patch now and fix it up in v3.4,
add exports for those two symbols, or disable building that code as a
module (patch below).  Personally I prefer the third option for the
immediate fix.

g.

>From 7fd0fcff9f0d65734415fed756271c1ae2267666 Mon Sep 17 00:00:00 2001
From: Grant Likely <grant.likely@secretlab.ca>
Date: Mon, 14 May 2012 00:52:49 -0600
Subject: [PATCH] gpio/pch: Fix build failure when selected as a module

x86_64 allmodconfig fails like this:

ERROR: "handle_edge_irq" [drivers/gpio/gpio-pch.ko] undefined!
ERROR: "irq_to_desc" [drivers/gpio/gpio-pch.ko] undefined!

This patch fixes the issue by not allowing gpio-pch.c to be built as a
module.  It can be reenabled when the core interrupt handling code
exports the missing symbols, but that change needs some review first.

Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/gpio/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index e03653d..db146d5 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -403,7 +403,7 @@ config GPIO_LANGWELL
	  Say Y here to support Intel Langwell/Penwell GPIO.
 
 config GPIO_PCH
-	tristate "Intel EG20T PCH/LAPIS Semiconductor IOH(ML7223/ML7831) GPIO"
+	bool "Intel EG20T PCH/LAPIS Semiconductor IOH(ML7223/ML7831) GPIO"
	depends on PCI && X86
	select GENERIC_IRQ_CHIP
	help
-- 
1.7.9.5

^ permalink raw reply	[flat|nested] 64+ messages in thread

* linux-next: build failure in Linus' tree
@ 2012-05-14  0:50 Stephen Rothwell
  2012-05-14  6:57 ` Grant Likely
  0 siblings, 1 reply; 64+ messages in thread
From: Stephen Rothwell @ 2012-05-14  0:50 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: linux-next, linux-kernel, David S. Miller, Thomas Gleixner,
	Grant Likely, Jean-Francois Dagenais

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

Hi Linus,

Building Linus' tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: "handle_edge_irq" [drivers/gpio/gpio-pch.ko] undefined!
ERROR: "irq_to_desc" [drivers/gpio/gpio-pch.ko] undefined!

This has been reported elsewhere by DaveM.

Caused by commit df9541a60af0 ("gpio: pch9: Use proper flow type handlers").

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2012-05-07  0:08 Stephen Rothwell
@ 2012-05-07  0:10 ` Al Viro
  0 siblings, 0 replies; 64+ messages in thread
From: Al Viro @ 2012-05-07  0:10 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Linus Torvalds, linux-next, linux-kernel

On Mon, May 07, 2012 at 10:08:56AM +1000, Stephen Rothwell wrote:
> Hi Linus,
> 
> While building your tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> ERROR: "set_personality_ia32" [arch/x86/ia32/ia32_aout.ko] undefined!
> 

Grr...  My fault - forgot to export it.

^ permalink raw reply	[flat|nested] 64+ messages in thread

* linux-next: build failure in Linus' tree
@ 2012-05-07  0:08 Stephen Rothwell
  2012-05-07  0:10 ` Al Viro
  0 siblings, 1 reply; 64+ messages in thread
From: Stephen Rothwell @ 2012-05-07  0:08 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-next, linux-kernel, Al Viro

[-- Attachment #1: Type: text/plain, Size: 371 bytes --]

Hi Linus,

While building your tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: "set_personality_ia32" [arch/x86/ia32/ia32_aout.ko] undefined!

Caused by commit ce7e5d2d19bc ("x86: fix broken TASK_SIZE for ia32_aout").

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 64+ messages in thread

* linux-next: build failure in Linus' tree
@ 2012-04-19  0:41 Stephen Rothwell
  0 siblings, 0 replies; 64+ messages in thread
From: Stephen Rothwell @ 2012-04-19  0:41 UTC (permalink / raw)
  To: Linus; +Cc: linux-next, linux-kernel, Eric Paris, James Morris

[-- Attachment #1: Type: text/plain, Size: 1377 bytes --]

Hi Linus,

While building Linus' tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

security/commoncap.c: In function 'cap_bprm_set_creds':
security/commoncap.c:510:22: error: 'PER_CLEAR_ON_SETID' undeclared (first use in this function)

Caused by commit d52fc5dde171 ("fcaps: clear the same personality flags as suid when fcaps are used").

I added this patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 19 Apr 2012 10:38:26 +1000
Subject: [PATCH] security: commoncap.c needs to include personality.h

fixes this build error on PowerPC:

security/commoncap.c: In function 'cap_bprm_set_creds':
security/commoncap.c:510:22: error: 'PER_CLEAR_ON_SETID' undeclared (first use in this function)

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 security/commoncap.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/security/commoncap.c b/security/commoncap.c
index 0ecf4ba..71a166a 100644
--- a/security/commoncap.c
+++ b/security/commoncap.c
@@ -29,6 +29,7 @@
 #include <linux/securebits.h>
 #include <linux/user_namespace.h>
 #include <linux/binfmts.h>
+#include <linux/personality.h>
 
 /*
  * If a non-root user executes a setuid-root binary in
-- 
1.7.10.rc3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 64+ messages in thread

* linux-next: build failure in Linus' tree
@ 2012-01-24  0:51 Stephen Rothwell
  0 siblings, 0 replies; 64+ messages in thread
From: Stephen Rothwell @ 2012-01-24  0:51 UTC (permalink / raw)
  To: Linus Torvalds, Andrew Morton; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1348 bytes --]

Hi Linus,

After merging the origin tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

usr/include/linux/fs.h:13: included file 'linux/migrate_mode.h' is not exported

Caused by commit 6536e3123e5d ("mm: fix warnings regarding enum migrate_mode").

I have applied the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 24 Jan 2012 11:41:32 +1100
Subject: [PATCH] migrate_mode.h is not exported to user mode

so move its include into fs.h inside the __KERNEL__ protection.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/linux/fs.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/fs.h b/include/linux/fs.h
index 4b3a41f..386da09 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -10,7 +10,6 @@
 #include <linux/ioctl.h>
 #include <linux/blk_types.h>
 #include <linux/types.h>
-#include <linux/migrate_mode.h>
 
 /*
  * It's silly to have NR_OPEN bigger than NR_FILE, but you can change
@@ -397,6 +396,7 @@ struct inodes_stat_t {
 #include <linux/rculist_bl.h>
 #include <linux/atomic.h>
 #include <linux/shrinker.h>
+#include <linux/migrate_mode.h>
 
 #include <asm/byteorder.h>
 
-- 
1.7.9.rc0.23.g7e521

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2011-08-29 22:32 ` Stephen Rothwell
@ 2011-08-29 22:50   ` James Bottomley
  0 siblings, 0 replies; 64+ messages in thread
From: James Bottomley @ 2011-08-29 22:50 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linus, linux-next, linux-kernel, NeilBrown, linuxppc-dev,
	linux-parisc, J. Bruce Fields

On Tue, 2011-08-30 at 08:32 +1000, Stephen Rothwell wrote:
> Hi Linus,
> 
> On Mon, 29 Aug 2011 10:44:51 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the fixes tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> > 
> > arch/powerpc/kernel/built-in.o: In function `.sys_call_table':
> > (.text+0xbd00): undefined reference to `.sys_nfsservctl'
> > arch/powerpc/kernel/built-in.o: In function `.sys_call_table':
> > (.text+0xbd08): undefined reference to `.compat_sys_nfsservctl'
> > 
> > Caused by commit f5b940997397 ("All Arch: remove linkage for
> > sys_nfsservctl system call") which also missed parisc.
> > 
> > I will apply this patch for today:
> 
> Will you please appply this?  (repeated for ease of inclusion)
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 29 Aug 2011 10:38:57 +1000
> Subject: [PATCH] remove remaining references to nfsservctl
> 
> These were missed in commit f5b940997397 "All Arch: remove linkage
> for sys_nfsservctl system call" due to them having no sys_ prefix
> (presumably).
> 
> Cc: NeilBrown <neilb@suse.de>
> Cc: linuxppc-dev@lists.ozlabs.org
> Cc: linux-parisc@vger.kernel.org
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Thanks for finding this ... definitely acked by me if necessary.

James

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2011-08-29  0:44 Stephen Rothwell
@ 2011-08-29 22:32 ` Stephen Rothwell
  2011-08-29 22:50   ` James Bottomley
  0 siblings, 1 reply; 64+ messages in thread
From: Stephen Rothwell @ 2011-08-29 22:32 UTC (permalink / raw)
  To: Linus
  Cc: linux-next, linux-kernel, NeilBrown, linuxppc-dev, linux-parisc,
	J. Bruce Fields

Hi Linus,

On Mon, 29 Aug 2011 10:44:51 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the fixes tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> arch/powerpc/kernel/built-in.o: In function `.sys_call_table':
> (.text+0xbd00): undefined reference to `.sys_nfsservctl'
> arch/powerpc/kernel/built-in.o: In function `.sys_call_table':
> (.text+0xbd08): undefined reference to `.compat_sys_nfsservctl'
> 
> Caused by commit f5b940997397 ("All Arch: remove linkage for
> sys_nfsservctl system call") which also missed parisc.
> 
> I will apply this patch for today:

Will you please appply this?  (repeated for ease of inclusion)

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 29 Aug 2011 10:38:57 +1000
Subject: [PATCH] remove remaining references to nfsservctl

These were missed in commit f5b940997397 "All Arch: remove linkage
for sys_nfsservctl system call" due to them having no sys_ prefix
(presumably).

Cc: NeilBrown <neilb@suse.de>
Cc: linuxppc-dev@lists.ozlabs.org
Cc: linux-parisc@vger.kernel.org
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/parisc/kernel/syscall_table.S |    2 +-
 arch/powerpc/include/asm/systbl.h  |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/parisc/kernel/syscall_table.S b/arch/parisc/kernel/syscall_table.S
index e66366f..3735abd 100644
--- a/arch/parisc/kernel/syscall_table.S
+++ b/arch/parisc/kernel/syscall_table.S
@@ -259,7 +259,7 @@
 	ENTRY_SAME(ni_syscall)		/* query_module */
 	ENTRY_SAME(poll)
 	/* structs contain pointers and an in_addr... */
-	ENTRY_COMP(nfsservctl)
+	ENTRY_SAME(ni_syscall)		/* was nfsservctl */
 	ENTRY_SAME(setresgid)		/* 170 */
 	ENTRY_SAME(getresgid)
 	ENTRY_SAME(prctl)
diff --git a/arch/powerpc/include/asm/systbl.h b/arch/powerpc/include/asm/systbl.h
index f6736b7..fa0d27a 100644
--- a/arch/powerpc/include/asm/systbl.h
+++ b/arch/powerpc/include/asm/systbl.h
@@ -171,7 +171,7 @@ SYSCALL_SPU(setresuid)
 SYSCALL_SPU(getresuid)
 SYSCALL(ni_syscall)
 SYSCALL_SPU(poll)
-COMPAT_SYS(nfsservctl)
+SYSCALL(ni_syscall)
 SYSCALL_SPU(setresgid)
 SYSCALL_SPU(getresgid)
 COMPAT_SYS_SPU(prctl)
-- 
1.7.5.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

^ permalink raw reply	[flat|nested] 64+ messages in thread

* linux-next: build failure in Linus' tree
@ 2011-08-29  0:44 Stephen Rothwell
  2011-08-29 22:32 ` Stephen Rothwell
  0 siblings, 1 reply; 64+ messages in thread
From: Stephen Rothwell @ 2011-08-29  0:44 UTC (permalink / raw)
  To: Linus
  Cc: linux-next, linux-kernel, NeilBrown, linuxppc-dev, linux-parisc,
	J. Bruce Fields

Hi Linus,

After merging the fixes tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

arch/powerpc/kernel/built-in.o: In function `.sys_call_table':
(.text+0xbd00): undefined reference to `.sys_nfsservctl'
arch/powerpc/kernel/built-in.o: In function `.sys_call_table':
(.text+0xbd08): undefined reference to `.compat_sys_nfsservctl'

Caused by commit f5b940997397 ("All Arch: remove linkage for
sys_nfsservctl system call") which also missed parisc.

I will apply this patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 29 Aug 2011 10:38:57 +1000
Subject: [PATCH] remove remaining references to nfsservctl

These were missed in commit f5b940997397 "All Arch: remove linkage
for sys_nfsservctl system call" due to them having no sys_ prefix
(presumably).

Cc: NeilBrown <neilb@suse.de>
Cc: linuxppc-dev@lists.ozlabs.org
Cc: linux-parisc@vger.kernel.org
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/parisc/kernel/syscall_table.S |    2 +-
 arch/powerpc/include/asm/systbl.h  |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/parisc/kernel/syscall_table.S b/arch/parisc/kernel/syscall_table.S
index e66366f..3735abd 100644
--- a/arch/parisc/kernel/syscall_table.S
+++ b/arch/parisc/kernel/syscall_table.S
@@ -259,7 +259,7 @@
 	ENTRY_SAME(ni_syscall)		/* query_module */
 	ENTRY_SAME(poll)
 	/* structs contain pointers and an in_addr... */
-	ENTRY_COMP(nfsservctl)
+	ENTRY_SAME(ni_syscall)		/* was nfsservctl */
 	ENTRY_SAME(setresgid)		/* 170 */
 	ENTRY_SAME(getresgid)
 	ENTRY_SAME(prctl)
diff --git a/arch/powerpc/include/asm/systbl.h b/arch/powerpc/include/asm/systbl.h
index f6736b7..fa0d27a 100644
--- a/arch/powerpc/include/asm/systbl.h
+++ b/arch/powerpc/include/asm/systbl.h
@@ -171,7 +171,7 @@ SYSCALL_SPU(setresuid)
 SYSCALL_SPU(getresuid)
 SYSCALL(ni_syscall)
 SYSCALL_SPU(poll)
-COMPAT_SYS(nfsservctl)
+SYSCALL(ni_syscall)
 SYSCALL_SPU(setresgid)
 SYSCALL_SPU(getresgid)
 COMPAT_SYS_SPU(prctl)
-- 
1.7.5.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2011-08-11  1:59 Stephen Rothwell
@ 2011-08-11  6:43 ` Borislav Petkov
  0 siblings, 0 replies; 64+ messages in thread
From: Borislav Petkov @ 2011-08-11  6:43 UTC (permalink / raw)
  To: Stephen Rothwell, Linus Torvalds
  Cc: linux-next, linux-kernel, Randy Dunlap, Dave Jones

On Wed, Aug 10, 2011 at 09:59:26PM -0400, Stephen Rothwell wrote:
> Hi Linus,
> 
> With Linus' tree, today's linux-next build (x86_64 allmodconfig) failed
> like this:
> 
> drivers/edac/i7core_edac.c:259:19: error: field 'edac_mce' has incomplete type
> drivers/edac/i7core_edac.c:262:24: error: 'MCE_LOG_LEN' undeclared here (not in a function)
> drivers/edac/i7core_edac.c: In function 'i7core_mce_output_error':
> drivers/edac/i7core_edac.c:1671:25: error: dereferencing pointer to incomplete type
> drivers/edac/i7core_edac.c:1672:20: error: dereferencing pointer to incomplete type
> drivers/edac/i7core_edac.c:1673:23: error: dereferencing pointer to incomplete type
> drivers/edac/i7core_edac.c:1674:15: error: dereferencing pointer to incomplete type
> drivers/edac/i7core_edac.c:1675:18: error: dereferencing pointer to incomplete type
> drivers/edac/i7core_edac.c:1676:18: error: dereferencing pointer to incomplete type
> drivers/edac/i7core_edac.c:1680:7: error: dereferencing pointer to incomplete type
> drivers/edac/i7core_edac.c:1742:22: error: dereferencing pointer to incomplete type
> drivers/edac/i7core_edac.c:1742:31: error: dereferencing pointer to incomplete type
> drivers/edac/i7core_edac.c:1743:39: error: dereferencing pointer to incomplete type
> drivers/edac/i7core_edac.c:1744:15: error: dereferencing pointer to incomplete type
> drivers/edac/i7core_edac.c:1751:7: error: dereferencing pointer to incomplete type
> drivers/edac/i7core_edac.c: In function 'i7core_check_error':
> drivers/edac/i7core_edac.c:1787:50: error: dereferencing pointer to incomplete type
> drivers/edac/i7core_edac.c:1791:3: error: invalid use of undefined type 'struct mce'
> drivers/edac/i7core_edac.c:1793:49: error: dereferencing pointer to incomplete type
> drivers/edac/i7core_edac.c: In function 'i7core_mce_check_error':
> drivers/edac/i7core_edac.c:1838:11: error: dereferencing pointer to incomplete type
> drivers/edac/i7core_edac.c:1842:9: error: dereferencing pointer to incomplete type
> drivers/edac/i7core_edac.c:1847:6: error: dereferencing pointer to incomplete type
> drivers/edac/i7core_edac.c:1859:52: error: dereferencing pointer to incomplete type
> drivers/edac/i7core_edac.c:1864:9: error: dereferencing pointer to incomplete type
> drivers/edac/i7core_edac.c: In function 'i7core_unregister_mci':
> drivers/edac/i7core_edac.c:1910:2: error: implicit declaration of function 'edac_mce_unregister'
> drivers/edac/i7core_edac.c: In function 'i7core_register_mci':
> drivers/edac/i7core_edac.c:2008:2: error: implicit declaration of function 'edac_mce_register'
> 
> Caused by commit af9d220bac41 ("EDAC: Correct Kconfig dependencies").
> Since CONFIG_EDAC_MCE is no longer selected most of the stuff in
> linux/edac_mce.h is not available.  I have reverted that commit for today.

§$%§$&&§! (please excuse my french).

And I build-tested this patch with randconfigs a whole night and didn't
see any issues. But I think I see what happens, the above is the result
of a chain of unfortunate events :-)

* Randy mistakenly reported the original randconfig issue against
3.1-rc1. However, in reality it was against linux-next. It was caused by
the fact that i7core_edac now needs to depend on X86_MCE_INTEL (which
pulls in X86_MCE for the notifier chain).

* I sent the proper fix which was for Mauro to apply _ontop_ of

git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/edac.git linux_next

where the rest of the i7core_edac changes are. This patch depends on them.

* I wasn't clear enough with the patch though, and I see Linus has
applied it already on his tree, which is clearly too early - it has to
go in in the next merge window together with the rest of the stuff in
Mauro's branch.

So, I guess we're reverting for now, Linus?

Thanks and sorry for the trouble.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551

^ permalink raw reply	[flat|nested] 64+ messages in thread

* linux-next: build failure in Linus' tree
@ 2011-08-11  1:59 Stephen Rothwell
  2011-08-11  6:43 ` Borislav Petkov
  0 siblings, 1 reply; 64+ messages in thread
From: Stephen Rothwell @ 2011-08-11  1:59 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-next, linux-kernel, Borislav Petkov, Randy Dunlap

[-- Attachment #1: Type: text/plain, Size: 2815 bytes --]

Hi Linus,

With Linus' tree, today's linux-next build (x86_64 allmodconfig) failed
like this:

drivers/edac/i7core_edac.c:259:19: error: field 'edac_mce' has incomplete type
drivers/edac/i7core_edac.c:262:24: error: 'MCE_LOG_LEN' undeclared here (not in a function)
drivers/edac/i7core_edac.c: In function 'i7core_mce_output_error':
drivers/edac/i7core_edac.c:1671:25: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1672:20: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1673:23: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1674:15: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1675:18: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1676:18: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1680:7: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1742:22: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1742:31: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1743:39: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1744:15: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1751:7: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c: In function 'i7core_check_error':
drivers/edac/i7core_edac.c:1787:50: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1791:3: error: invalid use of undefined type 'struct mce'
drivers/edac/i7core_edac.c:1793:49: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c: In function 'i7core_mce_check_error':
drivers/edac/i7core_edac.c:1838:11: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1842:9: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1847:6: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1859:52: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c:1864:9: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c: In function 'i7core_unregister_mci':
drivers/edac/i7core_edac.c:1910:2: error: implicit declaration of function 'edac_mce_unregister'
drivers/edac/i7core_edac.c: In function 'i7core_register_mci':
drivers/edac/i7core_edac.c:2008:2: error: implicit declaration of function 'edac_mce_register'

Caused by commit af9d220bac41 ("EDAC: Correct Kconfig dependencies").
Since CONFIG_EDAC_MCE is no longer selected most of the stuff in
linux/edac_mce.h is not available.  I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 64+ messages in thread

* linux-next: build failure in Linus' tree
@ 2011-05-26  1:12 Stephen Rothwell
  0 siblings, 0 replies; 64+ messages in thread
From: Stephen Rothwell @ 2011-05-26  1:12 UTC (permalink / raw)
  To: Paul Mundt; +Cc: linux-next, linux-kernel, Linus, Anatolij Gustschin

Hi all,

With Linus' tree, today's linux-next build (x86_64 allmodconfig) failed
like this:

drivers/video/mb862xx/mb862xx-i2c.c: In function 'mb862xx_i2c_wait_event':
drivers/video/mb862xx/mb862xx-i2c.c:25: error: implicit declaration of function 'udelay'

Caused by commit f8a6b1f44833 ("video: mb862xx: add support for
controller's I2C bus adapter").

See Rule 1 in Documentation/SubmitChecklist.

I have applied the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 26 May 2011 11:09:10 +1000
Subject: [PATCH] video: mb862xx: udelay need linux/delay.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/video/mb862xx/mb862xx-i2c.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/video/mb862xx/mb862xx-i2c.c b/drivers/video/mb862xx/mb862xx-i2c.c
index cb77d3b..b953099 100644
--- a/drivers/video/mb862xx/mb862xx-i2c.c
+++ b/drivers/video/mb862xx/mb862xx-i2c.c
@@ -12,6 +12,7 @@
 #include <linux/fb.h>
 #include <linux/i2c.h>
 #include <linux/io.h>
+#include <linux/delay.h>
 
 #include "mb862xxfb.h"
 #include "mb862xx_reg.h"
-- 
1.7.5.1

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2011-05-20  1:15 Stephen Rothwell
@ 2011-05-20  1:19 ` Linus Torvalds
  0 siblings, 0 replies; 64+ messages in thread
From: Linus Torvalds @ 2011-05-20  1:19 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel

On Thu, May 19, 2011 at 6:15 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> reverting commit e66eed651fd1 ("list: remove prefetching from regular
> list iterators").  This is, of course, why we like to put stuff into
> linux-next before it goes into your tree :-)

Ahhah. Another case that magically depended on <linux/list.h> silently
including half the universe thanks to <linux/prefetch.h> (which in
turn included all manner of helper headers).

> I have applied this patch for today:

Looks good, I'll take it.

                        Linus

^ permalink raw reply	[flat|nested] 64+ messages in thread

* linux-next: build failure in Linus' tree
@ 2011-05-20  1:15 Stephen Rothwell
  2011-05-20  1:19 ` Linus Torvalds
  0 siblings, 1 reply; 64+ messages in thread
From: Stephen Rothwell @ 2011-05-20  1:15 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-next, linux-kernel

Hi Linus,

With just Linus' tree, today's linux-next build (powerpc ppc64_defconfig)
failed like this:

In file included from arch/powerpc/mm/fault.c:18:
include/linux/signal.h:239: error: 'struct task_struct' declared inside parameter list
include/linux/signal.h:239: error: its scope is only this definition or declaration, which is probably not what you want
include/linux/signal.h:240: error: 'struct task_struct' declared inside parameter list
include/linux/signal.h:241: error: 'struct task_struct' declared inside parameter list
include/linux/signal.h:250: error: 'struct task_struct' declared inside parameter list
include/linux/signal.h:254: error: 'struct task_struct' declared inside parameter list
cc1: warnings being treated as errors

and so on ...

reverting commit e66eed651fd1 ("list: remove prefetching from regular
list iterators").  This is, of course, why we like to put stuff into
linux-next before it goes into your tree :-)

I have applied this patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 20 May 2011 11:11:53 +1000
Subject: [PATCH] signal.h need a definition of struct task_struct

fixes these build errors on powerpc:

In file included from arch/powerpc/mm/fault.c:18:
include/linux/signal.h:239: error: 'struct task_struct' declared inside parameter list
include/linux/signal.h:239: error: its scope is only this definition or declaration, which is probably not what you want
include/linux/signal.h:240: error: 'struct task_struct' declared inside parameter list
include/linux/signal.h:241: error: 'struct task_struct' declared inside parameter list
include/linux/signal.h:250: error: 'struct task_struct' declared inside parameter list
include/linux/signal.h:254: error: 'struct task_struct' declared inside parameter list
cc1: warnings being treated as errors

Exposed by commit e66eed651fd1 ("list: remove prefetching from regular
list iterators").

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/linux/signal.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/linux/signal.h b/include/linux/signal.h
index fcd2b14..29a68ac 100644
--- a/include/linux/signal.h
+++ b/include/linux/signal.h
@@ -7,6 +7,8 @@
 #ifdef __KERNEL__
 #include <linux/list.h>
 
+struct task_struct;
+
 /* for sysctl */
 extern int print_fatal_signals;
 /*
-- 
1.7.5.1

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

^ permalink raw reply	[flat|nested] 64+ messages in thread

* RE: linux-next: build failure in Linus' tree
  2011-03-17 23:29 Stephen Rothwell
@ 2011-03-17 23:35 ` Luck, Tony
  0 siblings, 0 replies; 64+ messages in thread
From: Luck, Tony @ 2011-03-17 23:35 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Linus, Al Viro

>I have reverted the merge commit afe997a183ec ("Pull pstorev4 into
> release branch") for today.

Ok.  I'm working with Al on fixing the pstore code.  I have a patch
that makes it buildable - but there are many more changes needed to
cure the rest of the problems that Al pointed out.

-Tony

^ permalink raw reply	[flat|nested] 64+ messages in thread

* linux-next: build failure in Linus' tree
@ 2011-03-17 23:29 Stephen Rothwell
  2011-03-17 23:35 ` Luck, Tony
  0 siblings, 1 reply; 64+ messages in thread
From: Stephen Rothwell @ 2011-03-17 23:29 UTC (permalink / raw)
  To: Tony Luck; +Cc: linux-next, linux-kernel, Linus, Al Viro

[-- Attachment #1: Type: text/plain, Size: 735 bytes --]

Hi all,

After merging the Linus' tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

fs/pstore/inode.c:253: error: unknown field 'get_sb' specified in initializer
fs/pstore/inode.c:253: warning: initialization makes integer from pointer without a cast

Caused by commit ca01d6dd2d7a ("pstore: new filesystem interface to
platform persistent storage") interacting with commit 1a102ff92579 ("vfs:
bury ->get_sb()"). (I guess it would have been helpful if that latter
commit had hit linux-next ...)

I have reverted the merge commit afe997a183ec ("Pull pstorev4 into
release branch") for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2011-01-19  3:12 ` Konrad Rzeszutek Wilk
@ 2011-01-19  4:19   ` Stephen Rothwell
  0 siblings, 0 replies; 64+ messages in thread
From: Stephen Rothwell @ 2011-01-19  4:19 UTC (permalink / raw)
  To: Konrad Rzeszutek Wilk
  Cc: Jeremy Fitzhardinge, linux-next, linux-kernel, Linus

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

Hi Konrad,

On Tue, 18 Jan 2011 22:12:40 -0500 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
>
> Ok. Thanks for spotting that. I stuck it in my tree along with some other
> patches for rc1.

Linus has already applied my patch.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2011-01-14 23:40 Stephen Rothwell
@ 2011-01-19  3:12 ` Konrad Rzeszutek Wilk
  2011-01-19  4:19   ` Stephen Rothwell
  0 siblings, 1 reply; 64+ messages in thread
From: Konrad Rzeszutek Wilk @ 2011-01-19  3:12 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Jeremy Fitzhardinge, linux-next, linux-kernel, Linus

On Sat, Jan 15, 2011 at 10:40:04AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> While building Linus' tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> ERROR: "arbitrary_virt_to_machine" [drivers/xen/xen-gntdev.ko] undefined!
> 
> Caused by commit ba5d1012292403c8037adf4a54c4ec50dfe846c4 ("xen/gntdev:
> stop using "token" argument").
> 
> I have applied this patch for today:

Ok. Thanks for spotting that. I stuck it in my tree along with some other
patches for rc1.
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Sat, 15 Jan 2011 10:36:26 +1100
> Subject: [PATCH] xen: export arbitrary_virt_to_machine
> 
> fixes build error:
> 
> ERROR: "arbitrary_virt_to_machine" [drivers/xen/xen-gntdev.ko] undefined!
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  arch/x86/xen/mmu.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
> index 7575e55..5e92b61 100644
> --- a/arch/x86/xen/mmu.c
> +++ b/arch/x86/xen/mmu.c
> @@ -201,6 +201,7 @@ xmaddr_t arbitrary_virt_to_machine(void *vaddr)
>  	offset = address & ~PAGE_MASK;
>  	return XMADDR(((phys_addr_t)pte_mfn(*pte) << PAGE_SHIFT) + offset);
>  }
> +EXPORT_SYMBOL_GPL(arbitrary_virt_to_machine);
>  
>  void make_lowmem_page_readonly(void *vaddr)
>  {
> -- 
> 1.7.2.3
> 
> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 64+ messages in thread

* linux-next: build failure in Linus' tree
@ 2011-01-14 23:40 Stephen Rothwell
  2011-01-19  3:12 ` Konrad Rzeszutek Wilk
  0 siblings, 1 reply; 64+ messages in thread
From: Stephen Rothwell @ 2011-01-14 23:40 UTC (permalink / raw)
  To: Jeremy Fitzhardinge, Konrad Rzeszutek Wilk
  Cc: linux-next, linux-kernel, Linus

Hi all,

While building Linus' tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "arbitrary_virt_to_machine" [drivers/xen/xen-gntdev.ko] undefined!

Caused by commit ba5d1012292403c8037adf4a54c4ec50dfe846c4 ("xen/gntdev:
stop using "token" argument").

I have applied this patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Sat, 15 Jan 2011 10:36:26 +1100
Subject: [PATCH] xen: export arbitrary_virt_to_machine

fixes build error:

ERROR: "arbitrary_virt_to_machine" [drivers/xen/xen-gntdev.ko] undefined!

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/x86/xen/mmu.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
index 7575e55..5e92b61 100644
--- a/arch/x86/xen/mmu.c
+++ b/arch/x86/xen/mmu.c
@@ -201,6 +201,7 @@ xmaddr_t arbitrary_virt_to_machine(void *vaddr)
 	offset = address & ~PAGE_MASK;
 	return XMADDR(((phys_addr_t)pte_mfn(*pte) << PAGE_SHIFT) + offset);
 }
+EXPORT_SYMBOL_GPL(arbitrary_virt_to_machine);
 
 void make_lowmem_page_readonly(void *vaddr)
 {
-- 
1.7.2.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2011-01-14  1:24 ` Linus Torvalds
@ 2011-01-14  2:17   ` Al Viro
  0 siblings, 0 replies; 64+ messages in thread
From: Al Viro @ 2011-01-14  2:17 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Thu, Jan 13, 2011 at 05:24:17PM -0800, Linus Torvalds wrote:
> On Thu, Jan 13, 2011 at 3:43 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > While building Linus' tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> 
> Ok, I applied the attached, which makes it all build. I don't actually
> have a ecryptfs filesystem to test with, though.
> 
> Bad Al. Bad, bad Al.

Yeah...  Commit with summary "foldme" that got lost when reordering the
branch ;-/  My apologies.

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2011-01-13 23:43 Stephen Rothwell
@ 2011-01-14  1:24 ` Linus Torvalds
  2011-01-14  2:17   ` Al Viro
  0 siblings, 1 reply; 64+ messages in thread
From: Linus Torvalds @ 2011-01-14  1:24 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Al Viro, linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

On Thu, Jan 13, 2011 at 3:43 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> While building Linus' tree, today's linux-next build (x86_64
> allmodconfig) failed like this:

Ok, I applied the attached, which makes it all build. I don't actually
have a ecryptfs filesystem to test with, though.

Bad Al. Bad, bad Al.

                        Linus

[-- Attachment #2: patch.diff --]
[-- Type: text/x-patch, Size: 1706 bytes --]

commit 6254b32b5791e47ba1c679d023f26985fa34755a
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Thu Jan 13 17:19:38 2011 -0800

    ecryptfs: fix broken build
    
    Stephen Rothwell reports that the vfs merge broke the build of ecryptfs.
    The breakage comes from commit 66cb76666d69 ("sanitize ecryptfs
    ->mount()") which was obviously not even build tested. Tssk, tssk, Al.
    
    This is the minimal build fixup for the situation, although I don't have
    a filesystem to actually test it with.
    
    Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
    Cc: Al Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---
 fs/ecryptfs/main.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/fs/ecryptfs/main.c b/fs/ecryptfs/main.c
index 9ed4769..d3b28ab 100644
--- a/fs/ecryptfs/main.c
+++ b/fs/ecryptfs/main.c
@@ -141,13 +141,12 @@ int ecryptfs_init_persistent_file(struct dentry *ecryptfs_dentry)
 	return rc;
 }
 
-static inode *ecryptfs_get_inode(struct inode *lower_inode,
+static struct inode *ecryptfs_get_inode(struct inode *lower_inode,
 		       struct super_block *sb)
 {
 	struct inode *inode;
 	int rc = 0;
 
-	lower_inode = lower_dentry->d_inode;
 	if (lower_inode->i_sb != ecryptfs_superblock_to_lower(sb)) {
 		rc = -EXDEV;
 		goto out;
@@ -202,7 +201,7 @@ int ecryptfs_interpose(struct dentry *lower_dentry, struct dentry *dentry,
 {
 	struct inode *lower_inode = lower_dentry->d_inode;
 	struct inode *inode = ecryptfs_get_inode(lower_inode, sb);
-	if (IS_ERR(inode)
+	if (IS_ERR(inode))
 		return PTR_ERR(inode);
 	if (flags & ECRYPTFS_INTERPOSE_FLAG_D_ADD)
 		d_add(dentry, inode);

^ permalink raw reply	[flat|nested] 64+ messages in thread

* linux-next: build failure in Linus' tree
@ 2011-01-13 23:43 Stephen Rothwell
  2011-01-14  1:24 ` Linus Torvalds
  0 siblings, 1 reply; 64+ messages in thread
From: Stephen Rothwell @ 2011-01-13 23:43 UTC (permalink / raw)
  To: Al Viro, Linus; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1002 bytes --]

Hi all,

While building Linus' tree, today's linux-next build (x86_64
allmodconfig) failed like this:

fs/ecryptfs/main.c:144: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token
fs/ecryptfs/main.c: In function 'ecryptfs_interpose':
fs/ecryptfs/main.c:204: error: implicit declaration of function 'ecryptfs_get_inode'
fs/ecryptfs/main.c:204: warning: initialization makes pointer from integer without a cast
fs/ecryptfs/main.c:206: error: expected ')' before 'return'
fs/ecryptfs/main.c:212: error: expected expression before '}' token
fs/ecryptfs/main.c: In function 'ecryptfs_mount':
fs/ecryptfs/main.c:569: warning: assignment makes pointer from integer without a cast

Caused by commit 66cb76666d69502fe982990b2cff5b6d607fd3b1 ("sanitize
ecryptfs ->mount()") which was obviously not even build tested.  :-(

I have just reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2010-12-21  1:01 Stephen Rothwell
@ 2010-12-21  4:47 ` Sedat Dilek
  0 siblings, 0 replies; 64+ messages in thread
From: Sedat Dilek @ 2010-12-21  4:47 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linus, Jens Axboe, linux-next, linux-kernel, Stephen M. Cameron,
	stable, Thiago Farina

On Tue, Dec 21, 2010 at 2:01 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> While building Linus' tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> drivers/block/cciss.c: In function 'cciss_revalidate':
> drivers/block/cciss.c:2839: error: expected ';' before 'if'
>
> Caused by commit 0fc13c8995cd96f4123de400c71c223d80400ed9 ("cciss: fix
> cciss_revalidate panic").  Was this even build tested?  More care
> required.
>
> I have reverted that commit for today.
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
>

[ CC Thiago Farina ]

Did you see the patch "[PATCH] drivers/block/cciss.c: Fix compiling
error by adding ';' at the end of continue statement." from [1] from
Thiago?

- Sedat -

[1] http://lkml.org/lkml/2010/12/20/465

^ permalink raw reply	[flat|nested] 64+ messages in thread

* linux-next: build failure in Linus' tree
@ 2010-12-21  1:01 Stephen Rothwell
  2010-12-21  4:47 ` Sedat Dilek
  0 siblings, 1 reply; 64+ messages in thread
From: Stephen Rothwell @ 2010-12-21  1:01 UTC (permalink / raw)
  To: Linus, Jens Axboe; +Cc: linux-next, linux-kernel, Stephen M. Cameron, stable

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

Hi all,

While building Linus' tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/block/cciss.c: In function 'cciss_revalidate':
drivers/block/cciss.c:2839: error: expected ';' before 'if'

Caused by commit 0fc13c8995cd96f4123de400c71c223d80400ed9 ("cciss: fix
cciss_revalidate panic").  Was this even build tested?  More care
required.

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 64+ messages in thread

* linux-next: build failure in Linus' tree
@ 2010-10-06  0:09 Stephen Rothwell
  0 siblings, 0 replies; 64+ messages in thread
From: Stephen Rothwell @ 2010-10-06  0:09 UTC (permalink / raw)
  To: Linus; +Cc: linux-next, linux-kernel, ppc-dev

Hi Linus,

Today's linux-next initial build (powerpc ppc64_defconfig) failed like
this:

cc1: warnings being treated as errors
arch/powerpc/kernel/module.c: In function 'module_finalize':
arch/powerpc/kernel/module.c:66: error: unused variable 'err'

Caused by commit 5336377d6225959624146629ce3fc88ee8ecda3d ("modules: Fix
module_bug_list list corruption race").

I added the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 6 Oct 2010 11:06:44 +1100
Subject: [PATCH] powerpc: remove unused variable

Since powerpc uses -Werror on arch powerpc, the build was broken like
this:

cc1: warnings being treated as errors
arch/powerpc/kernel/module.c: In function 'module_finalize':
arch/powerpc/kernel/module.c:66: error: unused variable 'err'

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/powerpc/kernel/module.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/kernel/module.c b/arch/powerpc/kernel/module.c
index 4ef93ae..49cee9d 100644
--- a/arch/powerpc/kernel/module.c
+++ b/arch/powerpc/kernel/module.c
@@ -63,7 +63,6 @@ int module_finalize(const Elf_Ehdr *hdr,
 		const Elf_Shdr *sechdrs, struct module *me)
 {
 	const Elf_Shdr *sect;
-	int err;
 
 	/* Apply feature fixups */
 	sect = find_section(hdr, sechdrs, "__ftr_fixup");
-- 
1.7.1


-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2010-06-01 17:04     ` Tony Luck
@ 2010-06-01 17:07       ` Linus Torvalds
  0 siblings, 0 replies; 64+ messages in thread
From: Linus Torvalds @ 2010-06-01 17:07 UTC (permalink / raw)
  To: Tony Luck
  Cc: Stephen Rothwell, Andrew Morton, linux-next, linux-kernel,
	Jack Steiner, Lee Schermerhorn



On Tue, 1 Jun 2010, Tony Luck wrote:

> On Sat, May 29, 2010 at 5:43 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > So, is it reasonable for me to ask you to revert commit
> > 0ac0c0d0f837c499afd02a802f9cf52d3027fa3b ("cpusets: randomize node rotor
> > used in cpuset_mem_spread_node()")?  Reverting it won't break ia64 (since
> > their fix was to just add code that would then be unreferenced).
> 
> If that's the way you go - then just revert commit
> 4ec37de89d8c758ee8115e0e64b3f994910789ee
> too. I only put that in to get the ia64 build working
> when 0ac0c0d went upstream.

I did. See commit b3f2f6cd1ff935ecac9a5346904b899d7af689fe.

Although I left the non-__node_random parts, which seemed to be an 
independent compile fix. 

		Linus

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2010-05-30  0:43   ` Stephen Rothwell
@ 2010-06-01 17:04     ` Tony Luck
  2010-06-01 17:07       ` Linus Torvalds
  0 siblings, 1 reply; 64+ messages in thread
From: Tony Luck @ 2010-06-01 17:04 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linus Torvalds, Andrew Morton, linux-next, linux-kernel,
	Jack Steiner, Lee Schermerhorn

On Sat, May 29, 2010 at 5:43 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> So, is it reasonable for me to ask you to revert commit
> 0ac0c0d0f837c499afd02a802f9cf52d3027fa3b ("cpusets: randomize node rotor
> used in cpuset_mem_spread_node()")?  Reverting it won't break ia64 (since
> their fix was to just add code that would then be unreferenced).

If that's the way you go - then just revert commit
4ec37de89d8c758ee8115e0e64b3f994910789ee
too. I only put that in to get the ia64 build working
when 0ac0c0d went upstream.

-Tony

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2010-05-28  1:09 ` Linus Torvalds
@ 2010-05-30  0:43   ` Stephen Rothwell
  2010-06-01 17:04     ` Tony Luck
  0 siblings, 1 reply; 64+ messages in thread
From: Stephen Rothwell @ 2010-05-30  0:43 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Andrew Morton, linux-next, linux-kernel, Jack Steiner, Lee Schermerhorn

[-- Attachment #1: Type: text/plain, Size: 1173 bytes --]

Hi Linus,

On Thu, 27 May 2010 18:09:17 -0700 (PDT) Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> On Fri, 28 May 2010, Stephen Rothwell wrote:
> > 
> > Caused by commit 0ac0c0d0f837c499afd02a802f9cf52d3027fa3b ("cpusets:
> > randomize node rotor used in cpuset_mem_spread_node()").
> > 
> > This commit assumes that __node_random() exists if (MAX_NUMNODES > 1) and
> > uses it if CONFIG_CPUSETS is set, but only creates it for x86 ...  there
> > is at least one other architecture where those conditions are true.
> 
> Yeah, looking at that, it seems totally idiotic.
> 
> Why is that "__node_random()" in x86 code at all? There is absolutely 
> nothing x86 about it that I can tell. And now I have an ia64 merge that 
> just duplicates that moronic function.

So, is it reasonable for me to ask you to revert commit
0ac0c0d0f837c499afd02a802f9cf52d3027fa3b ("cpusets: randomize node rotor
used in cpuset_mem_spread_node()")?  Reverting it won't break ia64 (since
their fix was to just add code that would then be unreferenced).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 64+ messages in thread

* Re: linux-next: build failure in Linus' tree
  2010-05-28  0:57 Stephen Rothwell
@ 2010-05-28  1:09 ` Linus Torvalds
  2010-05-30  0:43   ` Stephen Rothwell
  0 siblings, 1 reply; 64+ messages in thread
From: Linus Torvalds @ 2010-05-28  1:09 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Andrew Morton, linux-next, linux-kernel, Jack Steiner, Lee Schermerhorn



On Fri, 28 May 2010, Stephen Rothwell wrote:
> 
> Caused by commit 0ac0c0d0f837c499afd02a802f9cf52d3027fa3b ("cpusets:
> randomize node rotor used in cpuset_mem_spread_node()").
> 
> This commit assumes that __node_random() exists if (MAX_NUMNODES > 1) and
> uses it if CONFIG_CPUSETS is set, but only creates it for x86 ...  there
> is at least one other architecture where those conditions are true.

Yeah, looking at that, it seems totally idiotic.

Why is that "__node_random()" in x86 code at all? There is absolutely 
nothing x86 about it that I can tell. And now I have an ia64 merge that 
just duplicates that moronic function.

		Linus

^ permalink raw reply	[flat|nested] 64+ messages in thread

* linux-next: build failure in Linus' tree
@ 2010-05-28  0:57 Stephen Rothwell
  2010-05-28  1:09 ` Linus Torvalds
  0 siblings, 1 reply; 64+ messages in thread
From: Stephen Rothwell @ 2010-05-28  0:57 UTC (permalink / raw)
  To: Linus, Andrew Morton
  Cc: linux-next, linux-kernel, Jack Steiner, Lee Schermerhorn

[-- Attachment #1: Type: text/plain, Size: 760 bytes --]

Hi Linus,

After merging the gcl-current tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

kernel/built-in.o: In function `.copy_process':
fork.c:(.text+0x14c34): undefined reference to `.__node_random'
fork.c:(.text+0x14c44): undefined reference to `.__node_random'

Caused by commit 0ac0c0d0f837c499afd02a802f9cf52d3027fa3b ("cpusets:
randomize node rotor used in cpuset_mem_spread_node()").

This commit assumes that __node_random() exists if (MAX_NUMNODES > 1) and
uses it if CONFIG_CPUSETS is set, but only creates it for x86 ...  there
is at least one other architecture where those conditions are true.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 64+ messages in thread

* linux-next: build failure in Linus'  tree
@ 2010-05-24  0:40 Stephen Rothwell
  0 siblings, 0 replies; 64+ messages in thread
From: Stephen Rothwell @ 2010-05-24  0:40 UTC (permalink / raw)
  To: Linus; +Cc: linux-next, linux-kernel, Sage Weil

[-- Attachment #1: Type: text/plain, Size: 551 bytes --]

Hi Linus,

After merging the  tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

fs/ceph/msgpool.c: In function 'ceph_msgpool_put':
fs/ceph/msgpool.c:173: error: implicit declaration of function 'kref_set'

I cherry-picked the fix (commit f553069e5d7c6f53688ae4470173fcb1be97cbe7
"ceph: update for removal of kref_set") from the ceph tree.  I believe that Sage has sent you a pull request that includes this fix.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 64+ messages in thread

end of thread, back to index

Thread overview: 64+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-09 21:08 linux-next: build failure in Linus' tree Stephen Rothwell
2020-02-09 21:24 ` Linus Torvalds
2020-02-09 22:57   ` Marc Zyngier
2020-02-09 23:48     ` Linus Torvalds
2020-02-10  2:00     ` Zenghui Yu
  -- strict thread matches above, loose matches on Subject: below --
2018-10-28 22:45 Stephen Rothwell
2018-10-28 22:35 Stephen Rothwell
2018-10-28 22:45 ` Linus Torvalds
2018-10-29  1:38   ` Hangbin Liu
2018-10-29  2:17   ` David Miller
2018-06-12  2:26 Stephen Rothwell
2018-06-18  3:50 ` Stephen Rothwell
2018-02-04 22:28 Stephen Rothwell
2017-09-17 23:34 Stephen Rothwell
2016-03-27  6:06 Stephen Rothwell
2016-03-28 20:44 ` Arnaldo Carvalho de Melo
2014-11-03  4:09 Stephen Rothwell
2014-11-03  4:16 ` David Miller
2012-07-27  0:15 Stephen Rothwell
2012-07-27  0:23 ` Stephen Rothwell
2012-07-27  1:04 ` Linus Torvalds
2012-06-14  1:47 Stephen Rothwell
2012-06-14  3:06 ` Paul Mundt
2012-06-14  3:40   ` Paul Mundt
2012-06-15  0:14     ` Stephen Rothwell
2012-06-15  0:56       ` Paul Mundt
2012-06-17 23:38         ` Benjamin Herrenschmidt
2012-06-18  4:58           ` Paul Mundt
2012-06-15  9:23       ` Sedat Dilek
2012-06-15 10:15         ` Sedat Dilek
2012-06-15  8:46     ` Richard W.M. Jones
2012-06-15 11:38     ` Arnd Bergmann
2012-05-14  0:50 Stephen Rothwell
2012-05-14  6:57 ` Grant Likely
2012-05-14  8:32   ` Thomas Gleixner
2012-05-07  0:08 Stephen Rothwell
2012-05-07  0:10 ` Al Viro
2012-04-19  0:41 Stephen Rothwell
2012-01-24  0:51 Stephen Rothwell
2011-08-29  0:44 Stephen Rothwell
2011-08-29 22:32 ` Stephen Rothwell
2011-08-29 22:50   ` James Bottomley
2011-08-11  1:59 Stephen Rothwell
2011-08-11  6:43 ` Borislav Petkov
2011-05-26  1:12 Stephen Rothwell
2011-05-20  1:15 Stephen Rothwell
2011-05-20  1:19 ` Linus Torvalds
2011-03-17 23:29 Stephen Rothwell
2011-03-17 23:35 ` Luck, Tony
2011-01-14 23:40 Stephen Rothwell
2011-01-19  3:12 ` Konrad Rzeszutek Wilk
2011-01-19  4:19   ` Stephen Rothwell
2011-01-13 23:43 Stephen Rothwell
2011-01-14  1:24 ` Linus Torvalds
2011-01-14  2:17   ` Al Viro
2010-12-21  1:01 Stephen Rothwell
2010-12-21  4:47 ` Sedat Dilek
2010-10-06  0:09 Stephen Rothwell
2010-05-28  0:57 Stephen Rothwell
2010-05-28  1:09 ` Linus Torvalds
2010-05-30  0:43   ` Stephen Rothwell
2010-06-01 17:04     ` Tony Luck
2010-06-01 17:07       ` Linus Torvalds
2010-05-24  0:40 Stephen Rothwell

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git