[PATCH] arm64: dts: renesas: hihope-common: Add LEDs support

[PATCH] arm64: dts: renesas: hihope-common: Add LEDs support

[Fabrizio Castro]

This patch adds LEDs support to the HiHope RZ/G2[MN] Main Board
common device tree.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
This patch depends on:
https://patchwork.kernel.org/patch/10986913/

Thanks,
Fab

 arch/arm64/boot/dts/renesas/hihope-common.dtsi | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/hihope-common.dtsi b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
index 18763ca..b0bf510 100644
--- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
@@ -17,6 +17,30 @@
 		stdout-path = "serial0:115200n8";
 	};
 
+	leds {
+		compatible = "gpio-leds";
+
+		led0 {
+			gpios = <&gpio6 11 GPIO_ACTIVE_HIGH>;
+			label = "LED0";
+		};
+
+		led1 {
+			gpios = <&gpio6 12 GPIO_ACTIVE_HIGH>;
+			label = "LED1";
+		};
+
+		led2 {
+			gpios = <&gpio6 13 GPIO_ACTIVE_HIGH>;
+			label = "LED2";
+		};
+
+		led3 {
+			gpios = <&gpio0  0 GPIO_ACTIVE_HIGH>;
+			label = "LED3";
+		};
+	};
+
 	reg_1p8v: regulator0 {
 		compatible = "regulator-fixed";
 		regulator-name = "fixed-1.8V";
-- 
2.7.4

Re: [PATCH] arm64: dts: renesas: hihope-common: Add LEDs support

[Simon Horman]

On Fri, Jun 14, 2019 at 02:14:35PM +0100, Fabrizio Castro wrote:
> This patch adds LEDs support to the HiHope RZ/G2[MN] Main Board
> common device tree.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
> This patch depends on:
> https://patchwork.kernel.org/patch/10986913/

Thanks,

This looks fine to me but I will wait to see if there are other reviews
before applying.

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

Re: [PATCH] arm64: dts: renesas: hihope-common: Add LEDs support

[Simon Horman]

On Mon, Jun 17, 2019 at 11:33:14AM +0200, Simon Horman wrote:
> On Fri, Jun 14, 2019 at 02:14:35PM +0100, Fabrizio Castro wrote:
> > This patch adds LEDs support to the HiHope RZ/G2[MN] Main Board
> > common device tree.
> > 
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > ---
> > This patch depends on:
> > https://patchwork.kernel.org/patch/10986913/
> 
> Thanks,
> 
> This looks fine to me but I will wait to see if there are other reviews
> before applying.

I have applied this for inclusion in v5.3.

Re: [PATCH] arm64: dts: renesas: hihope-common: Add LEDs support

[Geert Uytterhoeven]

Hi Fabrizio,

On Fri, Jun 14, 2019 at 3:17 PM Fabrizio Castro
<fabrizio.castro@bp.renesas.com> wrote:
> This patch adds LEDs support to the HiHope RZ/G2[MN] Main Board
> common device tree.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> @@ -17,6 +17,30 @@
>                 stdout-path = "serial0:115200n8";
>         };
>
> +       leds {
> +               compatible = "gpio-leds";
> +
> +               led0 {
> +                       gpios = <&gpio6 11 GPIO_ACTIVE_HIGH>;
> +                       label = "LED0";

There's no need for a label property, if it matches the node name
(applies to all four LEDs).

Note that this GPIO is shared with a switch, like on Salvator-X(S) and
ULCB.  As currently Linux cannot handle both, describing the LED
precludes adding the switch later.
(applies to the first 3 LEDs).

> +               led3 {
> +                       gpios = <&gpio0  0 GPIO_ACTIVE_HIGH>;
> +                       label = "LED3";
> +               };

I cannot find LED3. According to the schematics GP0_0 == CS0n is used
as the chipselect for the LVDS switch?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

RE: [PATCH] arm64: dts: renesas: hihope-common: Add LEDs support

[Fabrizio Castro]

Hello Geert,

Thank you for your feedback!

> From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Geert Uytterhoeven
> Sent: 18 June 2019 16:10
> Subject: Re: [PATCH] arm64: dts: renesas: hihope-common: Add LEDs support
> 
> Hi Fabrizio,
> 
> On Fri, Jun 14, 2019 at 3:17 PM Fabrizio Castro
> <fabrizio.castro@bp.renesas.com> wrote:
> > This patch adds LEDs support to the HiHope RZ/G2[MN] Main Board
> > common device tree.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> 
> Thanks for your patch!
> 
> > --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > @@ -17,6 +17,30 @@
> >                 stdout-path = "serial0:115200n8";
> >         };
> >
> > +       leds {
> > +               compatible = "gpio-leds";
> > +
> > +               led0 {
> > +                       gpios = <&gpio6 11 GPIO_ACTIVE_HIGH>;
> > +                       label = "LED0";
> 
> There's no need for a label property, if it matches the node name
> (applies to all four LEDs).

I could have used the actual names on the schematic, but then I realised that
would not have been too helpful due to the corresponding switch names:
LED0 - GP6_11 - SW2202 - LED2201
LED1 - GP6_12 - SW2201 - LED2202
LED2 - GP6_13 - SW2203 - LED2203
LED3 - GP0_00 - N/A - LED2402
The first 3 LEDs are found next to the micro USB connector for the debug console,
the forth LED is found next to the WiFi and BT LEDs.

I thought that using "LEDn" as labels would put a remark on the
"desired ordering" of the LEDs (even though there is no actual
requirement for that), but as you pointed out it's probably a bit
confusing? Do you think I should take the label out?

> 
> Note that this GPIO is shared with a switch, like on Salvator-X(S) and
> ULCB.  As currently Linux cannot handle both, describing the LED
> precludes adding the switch later.
> (applies to the first 3 LEDs).

Thank you for pointing this out. That's desired behaviour in this case.

> 
> > +               led3 {
> > +                       gpios = <&gpio0  0 GPIO_ACTIVE_HIGH>;
> > +                       label = "LED3";
> > +               };
> 
> I cannot find LED3. According to the schematics GP0_0 == CS0n is used
> as the chipselect for the LVDS switch?

My understanding is that CS0n is on GP1_20, could you please double
check?
(pin name: AJ4) GP0_00 == D0 == ExD0 on the schematic I have, I thought
you may have been looking at an older version of the schematic, but after
going through the history it seems like that line has always been there.

Thanks,
Fab

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

Re: [PATCH] arm64: dts: renesas: hihope-common: Add LEDs support

[Geert Uytterhoeven]

Hi Fabrizio,

On Tue, Jun 18, 2019 at 5:56 PM Fabrizio Castro
<fabrizio.castro@bp.renesas.com> wrote:
> > From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Geert Uytterhoeven
> > Sent: 18 June 2019 16:10
> > Subject: Re: [PATCH] arm64: dts: renesas: hihope-common: Add LEDs support
> >
> > On Fri, Jun 14, 2019 at 3:17 PM Fabrizio Castro
> > <fabrizio.castro@bp.renesas.com> wrote:
> > > This patch adds LEDs support to the HiHope RZ/G2[MN] Main Board
> > > common device tree.
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> >
> > Thanks for your patch!
> >
> > > --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > > @@ -17,6 +17,30 @@
> > >                 stdout-path = "serial0:115200n8";
> > >         };
> > >
> > > +       leds {
> > > +               compatible = "gpio-leds";
> > > +
> > > +               led0 {
> > > +                       gpios = <&gpio6 11 GPIO_ACTIVE_HIGH>;
> > > +                       label = "LED0";
> >
> > There's no need for a label property, if it matches the node name
> > (applies to all four LEDs).
>
> I could have used the actual names on the schematic, but then I realised that
> would not have been too helpful due to the corresponding switch names:
> LED0 - GP6_11 - SW2202 - LED2201
> LED1 - GP6_12 - SW2201 - LED2202
> LED2 - GP6_13 - SW2203 - LED2203
> LED3 - GP0_00 - N/A - LED2402
> The first 3 LEDs are found next to the micro USB connector for the debug console,
> the forth LED is found next to the WiFi and BT LEDs.
>
> I thought that using "LEDn" as labels would put a remark on the
> "desired ordering" of the LEDs (even though there is no actual
> requirement for that), but as you pointed out it's probably a bit
> confusing? Do you think I should take the label out?

If the LEDs don't have nice labels on the PCB, I would drop the label
properties.

> > Note that this GPIO is shared with a switch, like on Salvator-X(S) and
> > ULCB.  As currently Linux cannot handle both, describing the LED
> > precludes adding the switch later.
> > (applies to the first 3 LEDs).
>
> Thank you for pointing this out. That's desired behaviour in this case.

OK.

> > > +               led3 {
> > > +                       gpios = <&gpio0  0 GPIO_ACTIVE_HIGH>;
> > > +                       label = "LED3";
> > > +               };
> >
> > I cannot find LED3. According to the schematics GP0_0 == CS0n is used
> > as the chipselect for the LVDS switch?
>
> My understanding is that CS0n is on GP1_20, could you please double
> check?
> (pin name: AJ4) GP0_00 == D0 == ExD0 on the schematic I have, I thought
> you may have been looking at an older version of the schematic, but after
> going through the history it seems like that line has always been there.

Sorry, my mistake.  As there is no GP0_0 in the schematic, I looked up
the pin number in the docs, but ended up using the R-Car M3-W SiP pin
number, instead of the RZ/G2M FCBGA SoC pin number :-(

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

RE: [PATCH] arm64: dts: renesas: hihope-common: Add LEDs support

[Fabrizio Castro]

Hello Geert,

Thank you for your feedback

> From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Geert Uytterhoeven
> Sent: 19 June 2019 08:34
> Subject: Re: [PATCH] arm64: dts: renesas: hihope-common: Add LEDs support
> 
> Hi Fabrizio,
> 
> On Tue, Jun 18, 2019 at 5:56 PM Fabrizio Castro
> <fabrizio.castro@bp.renesas.com> wrote:
> > > From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Geert Uytterhoeven
> > > Sent: 18 June 2019 16:10
> > > Subject: Re: [PATCH] arm64: dts: renesas: hihope-common: Add LEDs support
> > >
> > > On Fri, Jun 14, 2019 at 3:17 PM Fabrizio Castro
> > > <fabrizio.castro@bp.renesas.com> wrote:
> > > > This patch adds LEDs support to the HiHope RZ/G2[MN] Main Board
> > > > common device tree.
> > > >
> > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > >
> > > Thanks for your patch!
> > >
> > > > --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > > > +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > > > @@ -17,6 +17,30 @@
> > > >                 stdout-path = "serial0:115200n8";
> > > >         };
> > > >
> > > > +       leds {
> > > > +               compatible = "gpio-leds";
> > > > +
> > > > +               led0 {
> > > > +                       gpios = <&gpio6 11 GPIO_ACTIVE_HIGH>;
> > > > +                       label = "LED0";
> > >
> > > There's no need for a label property, if it matches the node name
> > > (applies to all four LEDs).
> >
> > I could have used the actual names on the schematic, but then I realised that
> > would not have been too helpful due to the corresponding switch names:
> > LED0 - GP6_11 - SW2202 - LED2201
> > LED1 - GP6_12 - SW2201 - LED2202
> > LED2 - GP6_13 - SW2203 - LED2203
> > LED3 - GP0_00 - N/A - LED2402
> > The first 3 LEDs are found next to the micro USB connector for the debug console,
> > the forth LED is found next to the WiFi and BT LEDs.
> >
> > I thought that using "LEDn" as labels would put a remark on the
> > "desired ordering" of the LEDs (even though there is no actual
> > requirement for that), but as you pointed out it's probably a bit
> > confusing? Do you think I should take the label out?
> 
> If the LEDs don't have nice labels on the PCB, I would drop the label
> properties.

Will do. Simon, do you want me to send an incremental patch for this (this patch
is on devel branch already) or would you rather I sent a v2?

Thanks,
Fab

> 
> > > Note that this GPIO is shared with a switch, like on Salvator-X(S) and
> > > ULCB.  As currently Linux cannot handle both, describing the LED
> > > precludes adding the switch later.
> > > (applies to the first 3 LEDs).
> >
> > Thank you for pointing this out. That's desired behaviour in this case.
> 
> OK.
> 
> > > > +               led3 {
> > > > +                       gpios = <&gpio0  0 GPIO_ACTIVE_HIGH>;
> > > > +                       label = "LED3";
> > > > +               };
> > >
> > > I cannot find LED3. According to the schematics GP0_0 == CS0n is used
> > > as the chipselect for the LVDS switch?
> >
> > My understanding is that CS0n is on GP1_20, could you please double
> > check?
> > (pin name: AJ4) GP0_00 == D0 == ExD0 on the schematic I have, I thought
> > you may have been looking at an older version of the schematic, but after
> > going through the history it seems like that line has always been there.
> 
> Sorry, my mistake.  As there is no GP0_0 in the schematic, I looked up
> the pin number in the docs, but ended up using the R-Car M3-W SiP pin
> number, instead of the RZ/G2M FCBGA SoC pin number :-(
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

Re: [PATCH] arm64: dts: renesas: hihope-common: Add LEDs support

[Simon Horman]

On Wed, Jun 19, 2019 at 08:16:43AM +0000, Fabrizio Castro wrote:
> Hello Geert,
> 
> Thank you for your feedback
> 
> > From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Geert Uytterhoeven
> > Sent: 19 June 2019 08:34
> > Subject: Re: [PATCH] arm64: dts: renesas: hihope-common: Add LEDs support
> > 
> > Hi Fabrizio,
> > 
> > On Tue, Jun 18, 2019 at 5:56 PM Fabrizio Castro
> > <fabrizio.castro@bp.renesas.com> wrote:
> > > > From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Geert Uytterhoeven
> > > > Sent: 18 June 2019 16:10
> > > > Subject: Re: [PATCH] arm64: dts: renesas: hihope-common: Add LEDs support
> > > >
> > > > On Fri, Jun 14, 2019 at 3:17 PM Fabrizio Castro
> > > > <fabrizio.castro@bp.renesas.com> wrote:
> > > > > This patch adds LEDs support to the HiHope RZ/G2[MN] Main Board
> > > > > common device tree.
> > > > >
> > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > >
> > > > Thanks for your patch!
> > > >
> > > > > --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > > > > +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > > > > @@ -17,6 +17,30 @@
> > > > >                 stdout-path = "serial0:115200n8";
> > > > >         };
> > > > >
> > > > > +       leds {
> > > > > +               compatible = "gpio-leds";
> > > > > +
> > > > > +               led0 {
> > > > > +                       gpios = <&gpio6 11 GPIO_ACTIVE_HIGH>;
> > > > > +                       label = "LED0";
> > > >
> > > > There's no need for a label property, if it matches the node name
> > > > (applies to all four LEDs).
> > >
> > > I could have used the actual names on the schematic, but then I realised that
> > > would not have been too helpful due to the corresponding switch names:
> > > LED0 - GP6_11 - SW2202 - LED2201
> > > LED1 - GP6_12 - SW2201 - LED2202
> > > LED2 - GP6_13 - SW2203 - LED2203
> > > LED3 - GP0_00 - N/A - LED2402
> > > The first 3 LEDs are found next to the micro USB connector for the debug console,
> > > the forth LED is found next to the WiFi and BT LEDs.
> > >
> > > I thought that using "LEDn" as labels would put a remark on the
> > > "desired ordering" of the LEDs (even though there is no actual
> > > requirement for that), but as you pointed out it's probably a bit
> > > confusing? Do you think I should take the label out?
> > 
> > If the LEDs don't have nice labels on the PCB, I would drop the label
> > properties.
> 
> Will do. Simon, do you want me to send an incremental patch for this (this patch
> is on devel branch already) or would you rather I sent a v2?

Please send an incremental patch, thanks.

RE: [PATCH] arm64: dts: renesas: hihope-common: Add LEDs support

[Fabrizio Castro]

Hello Simon,

> From: Simon Horman <horms@verge.net.au>
> Sent: 19 June 2019 13:18
> Subject: Re: [PATCH] arm64: dts: renesas: hihope-common: Add LEDs support
> 
> >
> > Will do. Simon, do you want me to send an incremental patch for this (this patch
> > is on devel branch already) or would you rather I sent a v2?
> 
> Please send an incremental patch, thanks.

Great, will send the patch in a minute.

Thanks,
Fab