linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/5] tps65910: cleanup regmap use
@ 2020-09-26 23:59 Michał Mirosław
  2020-09-26 23:59 ` [PATCH 2/5] regulator: tps65910: use regmap accessors Michał Mirosław
                   ` (4 more replies)
  0 siblings, 5 replies; 133+ messages in thread
From: Michał Mirosław @ 2020-09-26 23:59 UTC (permalink / raw)
  To: Bartosz Golaszewski, Lee Jones, Liam Girdwood, Linus Walleij,
	Mark Brown, Tony Lindgren
  Cc: linux-gpio, linux-kernel, linux-omap

tps65910 was converted a long time ago to regmap. This series cleans up
after the conversion by removing tps65910_reg_*() indirections and
other unused fields in MFD structure.

Michał Mirosław (5):
  gpio: tps65910: use regmap accessors
  regulator: tps65910: use regmap accessors
  mfd: tps65911-comparator: use regmap accessors
  mfd: tps65910: clean up after switching to regmap
  mfd: tps65910: remove unused pointers

 drivers/gpio/gpio-tps65910.c           |  12 +--
 drivers/mfd/tps65910.c                 |  16 ++--
 drivers/mfd/tps65911-comparator.c      |   4 +-
 drivers/regulator/tps65910-regulator.c | 125 +++++++++++++------------
 include/linux/mfd/tps65910.h           |  40 --------
 5 files changed, 79 insertions(+), 118 deletions(-)

-- 
2.20.1


^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2020-07-17  3:41 Stephen Rothwell
  2020-07-17  6:56 ` Lee Jones
  0 siblings, 1 reply; 133+ messages in thread
From: Stephen Rothwell @ 2020-07-17  3:41 UTC (permalink / raw)
  To: Lee Jones; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 3068 bytes --]

Hi all,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/mfd/kempld-core.c: In function 'kempld_register_cells_generic':
drivers/mfd/kempld-core.c:105:13: error: assignment of read-only location 'devs[i++]'
  105 |   devs[i++] = kempld_devs[KEMPLD_I2C];
      |             ^
drivers/mfd/kempld-core.c:108:13: error: assignment of read-only location 'devs[i++]'
  108 |   devs[i++] = kempld_devs[KEMPLD_WDT];
      |             ^
drivers/mfd/kempld-core.c:111:13: error: assignment of read-only location 'devs[i++]'
  111 |   devs[i++] = kempld_devs[KEMPLD_GPIO];
      |             ^
drivers/mfd/kempld-core.c:114:13: error: assignment of read-only location 'devs[i++]'
  114 |   devs[i++] = kempld_devs[KEMPLD_UART];
      |             ^

Caused by commit

  70d48975c152 ("mfd: core: Make a best effort attempt to match devices with the correct of_nodes")

I have added the following fix patch for today (I assume that there is
a better solution):

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 17 Jul 2020 13:36:22 +1000
Subject: [PATCH] fix up for struct mfd_cell change

Fixes: 70d48975c152 ("mfd: core: Make a best effort attempt to match devices with the correct of_nodes")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/mfd/kempld-core.c | 28 ++++++++++------------------
 1 file changed, 10 insertions(+), 18 deletions(-)

diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c
index f48e21d8b97c..ad68ee699cb5 100644
--- a/drivers/mfd/kempld-core.c
+++ b/drivers/mfd/kempld-core.c
@@ -79,39 +79,31 @@ enum kempld_cells {
 	KEMPLD_UART,
 };
 
-static const struct mfd_cell kempld_devs[] = {
-	[KEMPLD_I2C] = {
-		.name = "kempld-i2c",
-	},
-	[KEMPLD_WDT] = {
-		.name = "kempld-wdt",
-	},
-	[KEMPLD_GPIO] = {
-		.name = "kempld-gpio",
-	},
-	[KEMPLD_UART] = {
-		.name = "kempld-uart",
-	},
+static const char *kempld_devs[] = {
+	[KEMPLD_I2C] = "kempld-i2c",
+	[KEMPLD_WDT] = "kempld-wdt",
+	[KEMPLD_GPIO] = "kempld-gpio",
+	[KEMPLD_UART] = "kempld-uart",
 };
 
 #define KEMPLD_MAX_DEVS	ARRAY_SIZE(kempld_devs)
 
 static int kempld_register_cells_generic(struct kempld_device_data *pld)
 {
-	struct mfd_cell devs[KEMPLD_MAX_DEVS];
+	struct mfd_cell devs[KEMPLD_MAX_DEVS] = {};
 	int i = 0;
 
 	if (pld->feature_mask & KEMPLD_FEATURE_BIT_I2C)
-		devs[i++] = kempld_devs[KEMPLD_I2C];
+		devs[i++].name = kempld_devs[KEMPLD_I2C];
 
 	if (pld->feature_mask & KEMPLD_FEATURE_BIT_WATCHDOG)
-		devs[i++] = kempld_devs[KEMPLD_WDT];
+		devs[i++].name = kempld_devs[KEMPLD_WDT];
 
 	if (pld->feature_mask & KEMPLD_FEATURE_BIT_GPIO)
-		devs[i++] = kempld_devs[KEMPLD_GPIO];
+		devs[i++].name = kempld_devs[KEMPLD_GPIO];
 
 	if (pld->feature_mask & KEMPLD_FEATURE_MASK_UART)
-		devs[i++] = kempld_devs[KEMPLD_UART];
+		devs[i++].name = kempld_devs[KEMPLD_UART];
 
 	return mfd_add_devices(pld->dev, -1, devs, i, NULL, 0, NULL);
 }
-- 
2.27.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2020-02-04  3:03 Stephen Rothwell
  2020-02-04  7:53 ` Lee Jones
  0 siblings, 1 reply; 133+ messages in thread
From: Stephen Rothwell @ 2020-02-04  3:03 UTC (permalink / raw)
  To: Lee Jones
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Srinivas Kandagatla, Pierre-Louis Bossart

[-- Attachment #1: Type: text/plain, Size: 802 bytes --]

Hi all,

After merging the mfd tree, today's linux-next build (powerpc
allyesconfig) failed like this:

ld: sound/soc/codecs/wcd934x.o:(.toc+0x0): undefined reference to `of_clk_src_simple_get'
ld: sound/soc/codecs/wcd934x.o: in function `.wcd934x_codec_probe':
wcd934x.c:(.text.wcd934x_codec_probe+0x3d4): undefined reference to `.__clk_get_name'
ld: wcd934x.c:(.text.wcd934x_codec_probe+0x438): undefined reference to `.clk_hw_register'
ld: wcd934x.c:(.text.wcd934x_codec_probe+0x474): undefined reference to `.of_clk_add_provider'

Caused by commit

  6ac7e4d7ad70 ("mfd: wcd934x: Add support to wcd9340/wcd9341 codec")

Unfortunately that commit is now in Linus' tree (and was never in
linux-next).

I marked CONFIG_MFD_STMFX as BROKEN for now.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2019-04-03  0:40 Stephen Rothwell
  0 siblings, 0 replies; 133+ messages in thread
From: Stephen Rothwell @ 2019-04-03  0:40 UTC (permalink / raw)
  To: Lee Jones
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Vincent Palatin, Enric Balletbo i Serra, Wei-Ning Huang

[-- Attachment #1: Type: text/plain, Size: 1183 bytes --]

Hi Lee,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/mfd/cros_ec_dev.c: In function 'ec_device_probe':
drivers/mfd/cros_ec_dev.c:422:33: error: 'EC_FEATURE_FINGERPRINT' undeclared (first use in this function); did you mean 'EC_FEATURE_HANG_DETECT'?
  if (cros_ec_check_features(ec, EC_FEATURE_FINGERPRINT)) {
                                 ^~~~~~~~~~~~~~~~~~~~~~
                                 EC_FEATURE_HANG_DETECT
drivers/mfd/cros_ec_dev.c:422:33: note: each undeclared identifier is reported only once for each function it appears in
drivers/mfd/cros_ec_dev.c:445:33: error: 'EC_FEATURE_TOUCHPAD' undeclared (first use in this function); did you mean 'EC_FEATURE_USB_PD'?
  if (cros_ec_check_features(ec, EC_FEATURE_TOUCHPAD)) {
                                 ^~~~~~~~~~~~~~~~~~~
                                 EC_FEATURE_USB_PD

Caused by commits

  4483a6f22432 ("mfd: cros_ec: Instantiate properly CrOS FP MCU device")
  a03871b9e9ea ("mfd: cros_ec: Instantiate properly CrOS Touchpad MCU device")

I have used the mfd tree from next-20190402 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2018-12-17  5:38 Stephen Rothwell
  0 siblings, 0 replies; 133+ messages in thread
From: Stephen Rothwell @ 2018-12-17  5:38 UTC (permalink / raw)
  To: Lee Jones
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Keerthy,
	Sebastian Reichel

[-- Attachment #1: Type: text/plain, Size: 481 bytes --]

Hi all,

After merging the mfd tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/mfd/tps65218.c: In function 'tps65218_probe':
drivers/mfd/tps65218.c:247:3: error: label 'err_irq' used but not defined
   goto err_irq;
   ^~~~

Caused by commit

  05ba643fa2ce ("mfd: tps65218: Use devm_regmap_add_irq_chip and clean up error path in probe()")

I have used the mfd tree from next-20181214 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2017-12-04  3:19 Stephen Rothwell
  2017-12-04  9:10 ` Greg KH
  2017-12-04  9:39 ` Lee Jones
  0 siblings, 2 replies; 133+ messages in thread
From: Stephen Rothwell @ 2017-12-04  3:19 UTC (permalink / raw)
  To: Lee Jones, Greg KH
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Rui Feng,
	Daniel Bristot de Oliveira, Perry Yuan

Hi Lee,

After merging the mfd tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/staging/rts5208/sd.o: In function `.sd_power_off_card3v3':
(.text+0x5760): multiple definition of `.sd_power_off_card3v3'
drivers/misc/cardreader/rtsx_pcr.o:(.text+0x4630): first defined here
drivers/staging/rts5208/sd.o:(.opd+0x378): multiple definition of `sd_power_off_card3v3'
drivers/misc/cardreader/rtsx_pcr.o:(.opd+0x4f8): first defined here
drivers/staging/rts5208/ms.o: In function `.ms_power_off_card3v3':
(.text+0x5e70): multiple definition of `.ms_power_off_card3v3'
drivers/misc/cardreader/rtsx_pcr.o:(.text+0x46e0): first defined here
drivers/staging/rts5208/ms.o:(.opd+0x360): multiple definition of `ms_power_off_card3v3'
drivers/misc/cardreader/rtsx_pcr.o:(.opd+0x510): first defined here


Caused by commit

  5da4e04ae480 ("misc: rtsx: Add support for RTS5260")

I added the following fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 4 Dec 2017 14:10:34 +1100
Subject: [PATCH] misc: rtsx: fix symbol clashes

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/misc/cardreader/rts5260.c  | 4 ++--
 drivers/misc/cardreader/rtsx_pcr.c | 4 ++--
 drivers/misc/cardreader/rtsx_pcr.h | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/misc/cardreader/rts5260.c b/drivers/misc/cardreader/rts5260.c
index 3b308640282d..07cb93abf685 100644
--- a/drivers/misc/cardreader/rts5260.c
+++ b/drivers/misc/cardreader/rts5260.c
@@ -426,9 +426,9 @@ void rts5260_process_ocp(struct rtsx_pcr *pcr)
 	rtsx_pci_get_ocpstat(pcr, &pcr->ocp_stat);
 	rts5260_get_ocpstat2(pcr, &pcr->ocp_stat2);
 	if (pcr->card_exist & SD_EXIST)
-		sd_power_off_card3v3(pcr);
+		rtsx_sd_power_off_card3v3(pcr);
 	else if (pcr->card_exist & MS_EXIST)
-		ms_power_off_card3v3(pcr);
+		rtsx_ms_power_off_card3v3(pcr);
 
 	if (!(pcr->card_exist & MS_EXIST) && !(pcr->card_exist & SD_EXIST)) {
 		if ((pcr->ocp_stat & (SD_OC_NOW | SD_OC_EVER |
diff --git a/drivers/misc/cardreader/rtsx_pcr.c b/drivers/misc/cardreader/rtsx_pcr.c
index 99adc67bbf73..5345170fc57b 100644
--- a/drivers/misc/cardreader/rtsx_pcr.c
+++ b/drivers/misc/cardreader/rtsx_pcr.c
@@ -1208,7 +1208,7 @@ void rtsx_pci_clear_ocpstat(struct rtsx_pcr *pcr)
 	}
 }
 
-int sd_power_off_card3v3(struct rtsx_pcr *pcr)
+int rtsx_sd_power_off_card3v3(struct rtsx_pcr *pcr)
 {
 	rtsx_pci_write_register(pcr, CARD_CLK_EN, SD_CLK_EN |
 		MS_CLK_EN | SD40_CLK_EN, 0);
@@ -1223,7 +1223,7 @@ int sd_power_off_card3v3(struct rtsx_pcr *pcr)
 	return 0;
 }
 
-int ms_power_off_card3v3(struct rtsx_pcr *pcr)
+int rtsx_ms_power_off_card3v3(struct rtsx_pcr *pcr)
 {
 	rtsx_pci_write_register(pcr, CARD_CLK_EN, SD_CLK_EN |
 		MS_CLK_EN | SD40_CLK_EN, 0);
diff --git a/drivers/misc/cardreader/rtsx_pcr.h b/drivers/misc/cardreader/rtsx_pcr.h
index c544e35d0154..6ea1655db0bb 100644
--- a/drivers/misc/cardreader/rtsx_pcr.h
+++ b/drivers/misc/cardreader/rtsx_pcr.h
@@ -107,7 +107,7 @@ void rtsx_pci_disable_ocp(struct rtsx_pcr *pcr);
 void rtsx_pci_enable_ocp(struct rtsx_pcr *pcr);
 int rtsx_pci_get_ocpstat(struct rtsx_pcr *pcr, u8 *val);
 void rtsx_pci_clear_ocpstat(struct rtsx_pcr *pcr);
-int sd_power_off_card3v3(struct rtsx_pcr *pcr);
-int ms_power_off_card3v3(struct rtsx_pcr *pcr);
+int rtsx_sd_power_off_card3v3(struct rtsx_pcr *pcr);
+int rtsx_ms_power_off_card3v3(struct rtsx_pcr *pcr);
 
 #endif
-- 
2.15.0

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2017-05-31  2:23 Stephen Rothwell
  2017-05-31  3:36 ` Stephen Rothwell
  2017-06-05  3:28 ` Stephen Rothwell
  0 siblings, 2 replies; 133+ messages in thread
From: Stephen Rothwell @ 2017-05-31  2:23 UTC (permalink / raw)
  To: Lee Jones
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Heikki Krogerus, Greg Kroah-Hartman, Kuppuswamy Sathyanarayanan

Hi Lee,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/usb/typec/typec_wcove.c: In function 'wcove_typec_pr
obe':
drivers/usb/typec/typec_wcove.c:306:32: error: 'struct intel_soc_pmic' has no member named 'irq_chip_data_level2'
  ret = regmap_irq_get_virq(pmic->irq_chip_data_level2,
                                ^

Caused by commit

  aa32452e6ef9 ("mfd: intel_soc_pmic_bxtwc: Use chained irqs for second level irq chips")

interacting with commit

  d2061f9cc32d ("usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY")

from Linus' tree (v4.12-rc1).  grep is your friend. :-)

I have used the mfd tree from next-20170530 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2017-04-04  6:44 Stephen Rothwell
  2017-04-04  8:19 ` Lee Jones
  0 siblings, 1 reply; 133+ messages in thread
From: Stephen Rothwell @ 2017-04-04  6:44 UTC (permalink / raw)
  To: Lee Jones
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Andy Shevchenko

Hi Lee,

After merging the mfd tree, today's linux-next build (powerpc
allyesconfig) failed like this:

/home/sfr/next/next/drivers/mfd/intel_soc_pmic_bxtwc.c:25:31: fatal error: asm/intel_pmc_ipc.h: No such file or directory

Caused by commit

  eb2a445f7d8f ("mfd: intel_soc_pmic: Fix a mess with compilation units")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2016-02-29  3:51 Stephen Rothwell
  2016-03-01  1:19 ` Kuninori Morimoto
  0 siblings, 1 reply; 133+ messages in thread
From: Stephen Rothwell @ 2016-02-29  3:51 UTC (permalink / raw)
  To: Lee Jones, Mark Brown, Liam Girdwood
  Cc: linux-next, linux-kernel, Kuninori Morimoto

Hi Lee,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/regulator/tps65086-regulator.c:194:9: error: implicit declaration of function 'regmap_write_bits' [-Werror=implicit-function-declaration]
   ret = regmap_write_bits(config->regmap,
         ^

Caused by commit

  23b92e4cf5fd ("regmap: remove regmap_write_bits()")

from the sound-asoc & regmap trees.

I am not sure why this is suddenly exposed by the mfd tree, but grep
would have been useful when the regmap tree patch was applied.

I have reverted that regmap commit for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2015-10-15  2:26 Stephen Rothwell
  2015-10-15  3:35 ` kbuild test robot
  2015-10-15  8:59 ` Arnd Bergmann
  0 siblings, 2 replies; 133+ messages in thread
From: Stephen Rothwell @ 2015-10-15  2:26 UTC (permalink / raw)
  To: Lee Jones, Arnd Bergmann
  Cc: linux-next, linux-kernel, Andy Shevchenko, Christoph Hellwig

Hi Lee,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/mfd/intel-lpss.c:29:47: fatal error: asm-generic/io-64-nonatomic-lo-hi.h: No such file or directory
 #include <asm-generic/io-64-nonatomic-lo-hi.h>
                                               ^

Caused by commit

  6a1d82fbc8e8 ("mfd: intel-lpss: Use writeq() helper")

interacting with commit

  f626fe17485b ("move io-64-nonatomic*.h out of asm-generic")

from the asm-generic tree.

I have added the following merge fix patch and can carry it as necessary.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 15 Oct 2015 13:23:20 +1100
Subject: [PATCH] mfd: fix for "move io-64-nonatomic*.h out of asm-generic"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/mfd/intel-lpss.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c
index 001a7d7708ce..6255513f54c7 100644
--- a/drivers/mfd/intel-lpss.c
+++ b/drivers/mfd/intel-lpss.c
@@ -25,8 +25,7 @@
 #include <linux/pm_qos.h>
 #include <linux/pm_runtime.h>
 #include <linux/seq_file.h>
-
-#include <asm-generic/io-64-nonatomic-lo-hi.h>
+#include <linux/io-64-nonatomic-lo-hi.h>
 
 #include "intel-lpss.h"
 
-- 
2.5.1

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2015-03-04  0:34 Stephen Rothwell
  2015-03-04  0:37 ` Stephen Rothwell
  2015-03-04  7:26 ` Sascha Hauer
  0 siblings, 2 replies; 133+ messages in thread
From: Stephen Rothwell @ 2015-03-04  0:34 UTC (permalink / raw)
  To: Lee Jones; +Cc: linux-next, linux-kernel, Flora Fu, Sascha Hauer

[-- Attachment #1: Type: text/plain, Size: 834 bytes --]

Hi Lee,

After merging the mfd tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/mfd/mt6397-core.c: In function 'mt6397_irq_domain_map':
drivers/mfd/mt6397-core.c:124:2: error: implicit declaration of function 'set_irq_flags' [-Werror=implicit-function-declaration]
  set_irq_flags(irq, IRQF_VALID);
  ^
drivers/mfd/mt6397-core.c:124:21: error: 'IRQF_VALID' undeclared (first use in this function)
  set_irq_flags(irq, IRQF_VALID);
                     ^
drivers/mfd/mt6397-core.c:124:21: note: each undeclared identifier is reported only once for each function it appears in

Caused by commit 06d1bcedc888 ("mfd: Add support for the MediaTek
MT6397 PMIC").

I have used the mfd tree from next-20150303 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2014-11-11  2:32 Stephen Rothwell
  0 siblings, 0 replies; 133+ messages in thread
From: Stephen Rothwell @ 2014-11-11  2:32 UTC (permalink / raw)
  To: Lee Jones; +Cc: linux-next, linux-kernel, Gyungoh Yoo

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

Hi Lee,

After merging the mfd tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from drivers/mfd/sky81452.c:29:0:
include/linux/mfd/sky81452.h:24:52: fatal error: linux/platform_data/sky81452-backlight.h: No such file or directory
 #include <linux/platform_data/sky81452-backlight.h>
                                                    ^

Caused by commit f4eaf386bcf1 ("mfd: Add support for Skyworks SKY81452
driver").

I have used the mfd tree from next-20141110 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2014-11-04  5:40 Stephen Rothwell
  2014-11-04  7:54 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 133+ messages in thread
From: Stephen Rothwell @ 2014-11-04  5:40 UTC (permalink / raw)
  To: Lee Jones
  Cc: linux-next, linux-kernel, Krzysztof Kozlowski, Javier Martinez Canillas

[-- Attachment #1: Type: text/plain, Size: 2066 bytes --]

Hi all,

After merging the mfd tree, today's linux-next build (powerpc allyesconfig)
failed like this:

drivers/regulator/max77686.c:432:13: warning: 'struct max77686_platform_data' declared inside parameter list
      struct max77686_platform_data *pdata)
             ^
drivers/regulator/max77686.c:432:13: warning: its scope is only this definition or declaration, which is probably not what you want
drivers/regulator/max77686.c: In function 'max77686_pmic_dt_parse_pdata':
drivers/regulator/max77686.c:447:7: error: dereferencing pointer to incomplete type
  pdata->num_regulators = ARRAY_SIZE(regulators);
       ^
drivers/regulator/max77686.c:448:42: error: dereferencing pointer to incomplete type
  rdata = devm_kzalloc(&pdev->dev, sizeof(*rdata) *
                                          ^
drivers/regulator/max77686.c:449:14: error: dereferencing pointer to incomplete type
         pdata->num_regulators, GFP_KERNEL);
              ^
drivers/regulator/max77686.c:455:23: error: dereferencing pointer to incomplete type
  for (i = 0; i < pdata->num_regulators; i++) {
                       ^
drivers/regulator/max77686.c:460:3: error: invalid use of undefined type 'struct max77686_regulator_data'
   rdata[i].initdata = rmatch.init_data;
   ^
drivers/regulator/max77686.c:460:8: error: dereferencing pointer to incomplete type
   rdata[i].initdata = rmatch.init_data;
        ^
drivers/regulator/max77686.c:461:3: error: invalid use of undefined type 'struct max77686_regulator_data'
   rdata[i].of_node = rmatch.of_node;
   ^
drivers/regulator/max77686.c:461:8: error: dereferencing pointer to incomplete type
   rdata[i].of_node = rmatch.of_node;
        ^
drivers/regulator/max77686.c:464:7: error: dereferencing pointer to incomplete type
  pdata->regulators = rdata;
       ^

And so on ...

Caused by commit 9d5f4c2c748e ("mfd: max77686/802: Remove support for
board files") from the mfd tree.

I reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2014-08-22 16:56 Stephen Rothwell
  2014-08-22 19:09 ` Lee Jones
  0 siblings, 1 reply; 133+ messages in thread
From: Stephen Rothwell @ 2014-08-22 16:56 UTC (permalink / raw)
  To: Lee Jones; +Cc: linux-next, linux-kernel, Mark Brown, Charles Keepax

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

Hi Lee,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: "wm8994_base_regmap_config" [drivers/mfd/wm8994-core.ko] undefined!
ERROR: "wm8994_irq_init" [drivers/mfd/wm8994-core.ko] undefined!
ERROR: "wm1811_regmap_config" [drivers/mfd/wm8994-core.ko] undefined!
ERROR: "wm8958_regmap_config" [drivers/mfd/wm8994-core.ko] undefined!
ERROR: "wm8994_regmap_config" [drivers/mfd/wm8994-core.ko] undefined!

Presumably caused by commit a3ee6a4e2729 ("mfd: wm8994: Allow modular
build").

I have used the mfd tree from next-20140822 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2013-04-08  4:21 Stephen Rothwell
  2013-04-08  4:45 ` Alexander Shiyan
  0 siblings, 1 reply; 133+ messages in thread
From: Stephen Rothwell @ 2013-04-08  4:21 UTC (permalink / raw)
  To: Samuel Ortiz; +Cc: linux-next, linux-kernel, Alexander Shiyan

[-- Attachment #1: Type: text/plain, Size: 529 bytes --]

Hi Samuel,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe':
drivers/regulator/anatop-regulator.c:134:2: error: implicit declaration of function 'of_get_parent' [-Werror=implicit-function-declaration]

Caused by commit 5ab3a89a741f ("mfd: syscon: Add non-DT support").

I have used the mfd tree from next-20130405 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2012-09-25  3:47 Stephen Rothwell
  2012-09-25  6:47 ` Matthias Kaehlcke
  2012-09-25  8:43 ` Samuel Ortiz
  0 siblings, 2 replies; 133+ messages in thread
From: Stephen Rothwell @ 2012-09-25  3:47 UTC (permalink / raw)
  To: Samuel Ortiz; +Cc: linux-next, linux-kernel, Matthias Kaehlcke

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

Hi Samuel,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

FATAL: modpost: GPL-incompatible module tps65217_bl.ko uses GPL-only symbol 'platform_driver_unregister'

Caused by commit dbc14ec43af2 ("backlight: Add TPS65217 WLED driver").

I have used the mfd tree from next-20120924 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2012-07-09  3:57 Stephen Rothwell
  2012-07-09 10:52 ` Samuel Ortiz
  2012-07-10  9:20 ` Samuel Ortiz
  0 siblings, 2 replies; 133+ messages in thread
From: Stephen Rothwell @ 2012-07-09  3:57 UTC (permalink / raw)
  To: Samuel Ortiz; +Cc: linux-next, linux-kernel, Mark Brown

[-- Attachment #1: Type: text/plain, Size: 717 bytes --]

Hi Samuel,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: "arizona_dai_ops" [sound/soc/codecs/snd-soc-wm5102.ko] undefined!
ERROR: "wm5102_aod" [drivers/mfd/arizona-irq.ko] undefined!
ERROR: "wm5102_irq" [drivers/mfd/arizona-irq.ko] undefined!
ERROR: "irq_set_chip_and_handler_name" [drivers/mfd/arizona-irq.ko] undefined!
ERROR: "wm5102_patch" [drivers/mfd/arizona-core.ko] undefined!
ERROR: "arizona_irq_init" [drivers/mfd/arizona-core.ko] undefined!
ERROR: "arizona_irq_exit" [drivers/mfd/arizona-core.ko] undefined!

I have used the mfd tree from next-20120706 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2012-05-21  3:42 Stephen Rothwell
  2012-05-21  8:08 ` Lee Jones
  2012-05-21  8:30 ` Lee Jones
  0 siblings, 2 replies; 133+ messages in thread
From: Stephen Rothwell @ 2012-05-21  3:42 UTC (permalink / raw)
  To: Samuel Ortiz; +Cc: linux-next, linux-kernel, Lee Jones

[-- Attachment #1: Type: text/plain, Size: 1406 bytes --]

Hi Samuel,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

In file included from drivers/mfd/ab8500-core.c:21:0:
include/linux/mfd/dbx500-prcmu.h:614:19: error: redefinition of 'prcmu_abb_read'
include/linux/mfd/db8500-prcmu.h:673:19: note: previous definition of 'prcmu_abb_read' was here
include/linux/mfd/dbx500-prcmu.h:619:19: error: redefinition of 'prcmu_abb_write'
include/linux/mfd/db8500-prcmu.h:678:19: note: previous definition of 'prcmu_abb_write' was here
include/linux/mfd/dbx500-prcmu.h:630:19: error: redefinition of 'prcmu_config_clkout'
include/linux/mfd/db8500-prcmu.h:643:19: note: previous definition of 'prcmu_config_clkout' was here
include/linux/mfd/dbx500-prcmu.h:692:20: error: redefinition of 'prcmu_ac_wake_req'
include/linux/mfd/db8500-prcmu.h:683:20: note: previous definition of 'prcmu_ac_wake_req' was here
include/linux/mfd/dbx500-prcmu.h:694:20: error: redefinition of 'prcmu_ac_sleep_req'
include/linux/mfd/db8500-prcmu.h:685:20: note: previous definition of 'prcmu_ac_sleep_req' was here

Caused (exposed?) by commit d28f1db8187d ("mfd: Remove confusing
ab8500-i2c file and merge into ab8500-core").  I assume that this has
only had very restricted build testing :-(

I have used the mfd tree from next-20120511 again for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2012-05-16  6:09 Stephen Rothwell
  2012-05-18  8:39 ` Samuel Ortiz
  0 siblings, 1 reply; 133+ messages in thread
From: Stephen Rothwell @ 2012-05-16  6:09 UTC (permalink / raw)
  To: Samuel Ortiz; +Cc: linux-next, linux-kernel, Mark Brown

[-- Attachment #1: Type: text/plain, Size: 835 bytes --]

Hi Samuel,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/built-in.o: In function `wm8400_i2c_probe':
wm8400-core.c:(.text+0x100165): undefined reference to `devm_regmap_init_i2c'
drivers/built-in.o: In function `wm8400_module_init':
wm8400-core.c:(.init.text+0xb43c): undefined reference to `i2c_register_driver'
drivers/built-in.o: In function `wm8400_module_exit':
wm8400-core.c:(.exit.text+0x655): undefined reference to `i2c_del_driver'

Probably caused by commit 96cd102ae039 ("mfd: Don't support non-modular
wm8400 build") which was introduced to fix other problems.  In this
build, CONFIG_I2C=m and CONFIG_REGMAP_I2C=m.

I have used the mfd tree from next-20120511 again for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2012-05-14  3:37 Stephen Rothwell
  2012-05-14 20:22 ` Samuel Ortiz
  0 siblings, 1 reply; 133+ messages in thread
From: Stephen Rothwell @ 2012-05-14  3:37 UTC (permalink / raw)
  To: Samuel Ortiz; +Cc: linux-next, linux-kernel, Mark Brown

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]

Hi Samuel,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: "wm8400_block_read" [drivers/regulator/wm8400-regulator.ko] undefined!
ERROR: "regmap_reinit_cache" [drivers/mfd/wm8400-core.ko] undefined!

Caused by commit 4d240045599c ("mfd: Remove wm8400 custom cache
implementation").

I have used the mfd tree from next-20120511 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2012-03-19  2:13 Stephen Rothwell
  2012-03-19  6:19 ` Laxman Dewangan
  2012-03-20 12:40 ` Samuel Ortiz
  0 siblings, 2 replies; 133+ messages in thread
From: Stephen Rothwell @ 2012-03-19  2:13 UTC (permalink / raw)
  To: Samuel Ortiz; +Cc: linux-next, linux-kernel, Laxman Dewangan

[-- Attachment #1: Type: text/plain, Size: 762 bytes --]

Hi Samuel,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/built-in.o: In function `rc5t583_i2c_init':
rc5t583.c:(.init.text+0xb3db): undefined reference to `i2c_register_driver'
drivers/built-in.o: In function `rc5t583_i2c_probe':
rc5t583.c:(.devinit.text+0x8fa0): undefined reference to `regmap_init_i2c'
drivers/built-in.o: In function `rc5t583_i2c_exit':
rc5t583.c:(.exit.text+0x708): undefined reference to `i2c_del_driver'

Caused by commit 1b1247dd75aa ("mfd: Add support for RICOH PMIC
RC5T583"). Presumably some missing Kconfig dependency.

I have ued the version of the mfd tree from next-20120316 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2012-02-21  1:31 Stephen Rothwell
  2012-02-21 11:32 ` Samuel Ortiz
  0 siblings, 1 reply; 133+ messages in thread
From: Stephen Rothwell @ 2012-02-21  1:31 UTC (permalink / raw)
  To: Samuel Ortiz; +Cc: linux-next, linux-kernel, Peter Ujfalusi

[-- Attachment #1: Type: text/plain, Size: 754 bytes --]

Hi Samuel,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/built-in.o: In function `twl6040_driver_init':
twl6040-core.c:(.init.text+0xb147): undefined reference to `i2c_register_driver'
drivers/built-in.o: In function `twl6040_probe':
twl6040-core.c:(.devinit.text+0x7f22): undefined reference to `regmap_init_i2c'
drivers/built-in.o: In function `twl6040_driver_exit':
twl6040-core.c:(.exit.text+0x67a): undefined reference to `i2c_del_driver'


Caused by commit ded0df851077 ("mfd: Convert twl6040 to an i2c driver,
and separate it from twl core").

I have used the mfd tree from next-20120220 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2011-12-20  3:17 Stephen Rothwell
  2011-12-20 17:37 ` Samuel Ortiz
  0 siblings, 1 reply; 133+ messages in thread
From: Stephen Rothwell @ 2011-12-20  3:17 UTC (permalink / raw)
  To: Samuel Ortiz; +Cc: linux-next, linux-kernel, Viresh Kumar

[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]

Hi Samuel,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/built-in.o: In function `i2c_block_write':
stmpe-i2c.c:(.text+0xf4553): undefined reference to `i2c_smbus_write_i2c_block_data'
drivers/built-in.o: In function `i2c_block_read':
stmpe-i2c.c:(.text+0xf457f): undefined reference to `i2c_smbus_read_i2c_block_data'
drivers/built-in.o: In function `i2c_reg_write':
stmpe-i2c.c:(.text+0xf45ab): undefined reference to `i2c_smbus_write_byte_data'
drivers/built-in.o: In function `i2c_reg_read':
stmpe-i2c.c:(.text+0xf45d4): undefined reference to `i2c_smbus_read_byte_data'
drivers/built-in.o: In function `stmpe_init':
stmpe-i2c.c:(.init.text+0xaf22): undefined reference to `i2c_register_driver'
drivers/built-in.o: In function `stmpe_exit':
stmpe-i2c.c:(.exit.text+0x5e5): undefined reference to `i2c_del_driver'

Caused by commit b25a31a3b4d3 ("mfd: Separate out STMPE controller and
interface specific code").

I have used the mfd tree from next-20111219 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2011-09-19  6:19 Stephen Rothwell
  2011-09-19  9:43 ` Samuel Ortiz
  0 siblings, 1 reply; 133+ messages in thread
From: Stephen Rothwell @ 2011-09-19  6:19 UTC (permalink / raw)
  To: Samuel Ortiz; +Cc: linux-next, linux-kernel, "Uwe Kleine-König"

[-- Attachment #1: Type: text/plain, Size: 1056 bytes --]

Hi Samuel,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/regulator/mc13783-regulator.c: In function 'mc13783_regulator_probe':
drivers/regulator/mc13783-regulator.c:347:9: error: dereferencing pointer to incomplete type
drivers/regulator/mc13783-regulator.c:355:23: error: dereferencing pointer to incomplete type
drivers/regulator/mc13783-regulator.c:356:21: error: dereferencing pointer to incomplete type
drivers/regulator/mc13783-regulator.c:358:34: error: dereferencing pointer to incomplete type
drivers/regulator/mc13783-regulator.c:359:26: error: dereferencing pointer to incomplete type
drivers/regulator/mc13783-regulator.c: In function 'mc13783_regulator_remove':
drivers/regulator/mc13783-regulator.c:390:23: error: dereferencing pointer to incomplete type

Caused by commit a7e5c9a30148 ("mfd: Remove mc13783 API functions and
symbols").

I have used the mfd tree from next-20110915 again today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2011-09-16  3:55 Stephen Rothwell
  2011-09-16  7:16 ` Uwe Kleine-König
  2011-09-18 17:15 ` Samuel Ortiz
  0 siblings, 2 replies; 133+ messages in thread
From: Stephen Rothwell @ 2011-09-16  3:55 UTC (permalink / raw)
  To: Samuel Ortiz
  Cc: linux-next, linux-kernel, David Jander, Uwe Kleine-König

[-- Attachment #1: Type: text/plain, Size: 3335 bytes --]

Hi Samuel,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/leds/leds-mc13783.c: In function 'mc13783_leds_prepare':
drivers/leds/leds-mc13783.c:193:11: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:196:11: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:203:14: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:206:11: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:213:14: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:216:11: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:223:14: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:226:11: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:233:14: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:236:11: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:244:11: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:246:11: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:248:11: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:250:11: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:253:15: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:255:15: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c: In function 'mc13783_led_probe':
drivers/leds/leds-mc13783.c:278:11: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:278:34: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:279:54: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:283:36: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:295:23: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:297:19: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:299:14: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:299:47: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:300:50: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:305:31: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:307:13: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:312:27: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:313:31: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:314:42: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:317:24: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c:329:43: error: dereferencing pointer to incomplete type
drivers/leds/leds-mc13783.c: In function 'mc13783_led_remove':
drivers/leds/leds-mc13783.c:359:23: error: dereferencing pointer to incomplete type

Presumably caused by commit 747c98a3660d ("leds: Convert mc13783 driver
to mc13xxx MFD").

I have used the mfd tree from next-20110915 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2011-06-21  3:03 Stephen Rothwell
  2011-06-21 10:07 ` Mark Brown
  2011-06-21 17:58 ` Samuel Ortiz
  0 siblings, 2 replies; 133+ messages in thread
From: Stephen Rothwell @ 2011-06-21  3:03 UTC (permalink / raw)
  To: Samuel Ortiz; +Cc: linux-next, linux-kernel, Mark Brown

[-- Attachment #1: Type: text/plain, Size: 551 bytes --]

Hi Samuel,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/mfd/wm831x-core.c: In function 'wm831x_device_init':
drivers/mfd/wm831x-core.c:1507:12: error: 'WM831X_XTAL_ENA' undeclared (first use in this function)

Caused by commit e1af6eaa2160 ("mfd: Only register wm831x RTC device if
the 32.768kHz crystal is enabled").

I have used the mfd tree from next-20110620 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2011-02-22  3:20 Stephen Rothwell
  2011-02-22  9:21 ` Samuel Ortiz
  0 siblings, 1 reply; 133+ messages in thread
From: Stephen Rothwell @ 2011-02-22  3:20 UTC (permalink / raw)
  To: Samuel Ortiz; +Cc: linux-next, linux-kernel, Arun Murthy

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

Hi Samuel,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/mfd/ab8500-gpadc.c:20:36: error: linux/mfd/ab8500-gpadc.h: No such file or directory

Caused by commit 38a7f5349d3820b3603384733cd2f35913f923ea ("mfd: Add new
ab8500 GPADC driver"). Looks like an include file was forgotten.

I have used the mfd tree form next-20110221 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2010-09-16  2:54 Stephen Rothwell
  2010-09-19 22:27 ` Samuel Ortiz
  0 siblings, 1 reply; 133+ messages in thread
From: Stephen Rothwell @ 2010-09-16  2:54 UTC (permalink / raw)
  To: Samuel Ortiz; +Cc: linux-next, linux-kernel, Gary King

[-- Attachment #1: Type: text/plain, Size: 1324 bytes --]

Hi Samuel,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/built-in.o: In function `__tps6586x_read':
tps6586x.c:(.text+0xe4151): undefined reference to `i2c_smbus_read_byte_data'
drivers/built-in.o: In function `__tps6586x_write':
tps6586x.c:(.text+0xe4345): undefined reference to `i2c_smbus_write_byte_data'
drivers/built-in.o: In function `tps6586x_reads':
(.text+0xe4762): undefined reference to `i2c_smbus_read_i2c_block_data'
drivers/built-in.o: In function `tps6586x_writes':
(.text+0xe4894): undefined reference to `i2c_smbus_write_i2c_block_data'
drivers/built-in.o: In function `tps6586x_init':
tps6586x.c:(.init.text+0xc511): undefined reference to `i2c_register_driver'
drivers/built-in.o: In function `tps6586x_i2c_probe':
tps6586x.c:(.devinit.text+0x4ae6): undefined reference to `i2c_smbus_read_byte_data'
drivers/built-in.o: In function `tps6586x_exit':
tps6586x.c:(.exit.text+0x574): undefined reference to `i2c_del_driver'

Caused by commit 2d0a9a6d922712267ef62a5e8b38ed2b37cf45cc ("mfd: Add
basic tps6586x interrupt support").  Presumably a missing dependency.

I have used the mfd tree from next-20100915 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2010-08-09  1:40 Stephen Rothwell
  2010-08-09  8:51 ` Mike Rapoport
  2010-08-09  9:10 ` Samuel Ortiz
  0 siblings, 2 replies; 133+ messages in thread
From: Stephen Rothwell @ 2010-08-09  1:40 UTC (permalink / raw)
  To: Samuel Ortiz; +Cc: linux-next, linux-kernel, Mike Rapoport

[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]

Hi Samuel,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/mfd/tps6586x.c: In function 'tps6586x_add_subdevs':
drivers/mfd/tps6586x.c:272: error: dereferencing pointer to incomplete type
drivers/mfd/tps6586x.c:273: error: dereferencing pointer to incomplete type
drivers/mfd/tps6586x.c:275: error: dereferencing pointer to incomplete type
drivers/mfd/tps6586x.c:275: error: dereferencing pointer to incomplete type
drivers/mfd/tps6586x.c:278: error: dereferencing pointer to incomplete type
drivers/mfd/tps6586x.c: In function 'tps6586x_i2c_probe':
drivers/mfd/tps6586x.c:324: warning: passing argument 2 of 'tps6586x_add_subdevs' from incompatible pointer type
drivers/mfd/tps6586x.c:265: note: expected 'struct tps6586x_platform_data *' but argument is of type 'struct tps6586x_platform_data *'
drivers/mfd/tps6586x.c:330: error: dereferencing pointer to incomplete type

Caused by commit 8232c2794cf0e39b38d089eff49500461ecdbb8f ("mfd: Add
TPS6586x driver").  "struct tps6586x_platform_data" is not defined
anywhere ...

I have used the mfd tree from next-20100807 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2010-05-19  4:03 Stephen Rothwell
  2010-05-19  4:23 ` Rabin VINCENT
  0 siblings, 1 reply; 133+ messages in thread
From: Stephen Rothwell @ 2010-05-19  4:03 UTC (permalink / raw)
  To: Samuel Ortiz; +Cc: linux-next, linux-kernel, Rabin Vincent

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

Hi Samuel,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/mfd/ab8500-core.c: In function 'ab8500_irq_remove':
drivers/mfd/ab8500-core.c:302: error: implicit declaration of function 'set_irq_flags'

Caused by commit 16548223daf6b3b95b75cb961d772831a754e126 ("mfd: new
AB8500 driver").

I have used the mfd tree from next-20100518 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2010-04-08  2:57 Stephen Rothwell
  2010-04-08  9:33 ` Samuel Ortiz
  0 siblings, 1 reply; 133+ messages in thread
From: Stephen Rothwell @ 2010-04-08  2:57 UTC (permalink / raw)
  To: Samuel Ortiz; +Cc: linux-next, linux-kernel, Todd Fischer

Hi Samuel,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/mfd/tps6507x.c: In function 'tps6507x_i2c_probe':
drivers/mfd/tps6507x.c:90: error: implicit declaration of function 'kzalloc'
drivers/mfd/tps6507x.c:90: warning: assignment makes pointer from integer without a cast
drivers/mfd/tps6507x.c:92: error: implicit declaration of function 'kfree'

Caused by commit 353dd1bf937f319eb6fdf35a461bf0bea1361d23 ("mfd: Add
TPS6507x support").

I applied the following patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 8 Apr 2010 12:53:32 +1000
Subject: [PATCH] mfd: TPS6507x: using kzalloc/kfree requires including slab.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/mfd/tps6507x.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/mfd/tps6507x.c b/drivers/mfd/tps6507x.c
index dcddef0..d859dff 100644
--- a/drivers/mfd/tps6507x.c
+++ b/drivers/mfd/tps6507x.c
@@ -17,6 +17,7 @@
 #include <linux/module.h>
 #include <linux/moduleparam.h>
 #include <linux/init.h>
+#include <linux/slab.h>
 #include <linux/i2c.h>
 #include <linux/mfd/core.h>
 #include <linux/mfd/tps6507x.h>
-- 
1.7.0.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2010-04-07  5:02 Stephen Rothwell
  2010-04-07  8:53 ` Samuel Ortiz
  0 siblings, 1 reply; 133+ messages in thread
From: Stephen Rothwell @ 2010-04-07  5:02 UTC (permalink / raw)
  To: Samuel Ortiz; +Cc: linux-next, linux-kernel, Ira W. Snyder

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

Hi Samuel,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/mfd/janz-cmodio.c:270: error: 'PCI_VENDOR_ID_JANZ' undeclared here (not in a function)

Caused by commit d4a16922bc8ecece287becf3cc2c0333f77bdf9e ("mfd: Janz
CMOD-IO PCI MODULbus Carrier Board support").

I have used the version of the mfd tree from next-20100401 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 133+ messages in thread
* linux-next: build failure after merge of the mfd tree
@ 2010-04-07  4:51 Stephen Rothwell
  2010-04-07  8:52 ` Samuel Ortiz
  0 siblings, 1 reply; 133+ messages in thread
From: Stephen Rothwell @ 2010-04-07  4:51 UTC (permalink / raw)
  To: Samuel Ortiz; +Cc: linux-next, linux-kernel, Tejun Heo, Ira W. Snyder

Hi Samuel,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/gpio/janz-ttl.c: In function 'ttl_probe':
drivers/gpio/janz-ttl.c:158: error: implicit declaration of function 'kzalloc'
drivers/gpio/janz-ttl.c:158: warning: assignment makes pointer from integer without a cast
drivers/gpio/janz-ttl.c:210: error: implicit declaration of function 'kfree'

Caused by commit 989b68d7d885a45099126e32b46304afd9b3789e ("gpio: Add
support for Janz VMOD-TTL Digital IO module") interacting with commit
de380b55f92986c1a84198149cb71b7228d15fbd ("percpu: don't implicitly
include slab.h from percpu.h").

I applied the following fix patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 7 Apr 2010 14:47:52 +1000
Subject: [PATCH] gpio: janz-ttl: using kzalloc/kfree requires including slab.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/gpio/janz-ttl.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/gpio/janz-ttl.c b/drivers/gpio/janz-ttl.c
index d97eeda..813ac07 100644
--- a/drivers/gpio/janz-ttl.c
+++ b/drivers/gpio/janz-ttl.c
@@ -17,6 +17,7 @@
 #include <linux/platform_device.h>
 #include <linux/io.h>
 #include <linux/gpio.h>
+#include <linux/slab.h>
 
 #include <linux/mfd/janz.h>
 
-- 
1.7.0.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

^ permalink raw reply	[flat|nested] 133+ messages in thread

end of thread, other threads:[~2020-11-10 13:48 UTC | newest]

Thread overview: 133+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-26 23:59 [PATCH 0/5] tps65910: cleanup regmap use Michał Mirosław
2020-09-26 23:59 ` [PATCH 2/5] regulator: tps65910: use regmap accessors Michał Mirosław
2020-09-26 23:59 ` [PATCH 1/5] gpio: " Michał Mirosław
2020-09-28 10:19   ` Bartosz Golaszewski
2020-09-30  8:44   ` Linus Walleij
2020-10-01  9:01     ` Lee Jones
2020-11-04 14:43       ` Lee Jones
2020-11-05  1:47         ` Michał Mirosław
2020-11-05  1:50           ` linux-next: build failure after merge of the mfd tree Stephen Rothwell
2020-11-05  1:57             ` Michał Mirosław
2020-11-05  9:09               ` Lee Jones
2020-11-05  8:13           ` [PATCH 1/5] gpio: tps65910: use regmap accessors Lee Jones
2020-11-10 13:37             ` Linus Walleij
2020-11-05  7:56   ` Linus Walleij
2020-11-10 13:48   ` Lee Jones
2020-09-26 23:59 ` [PATCH 3/5] mfd: tps65911-comparator: " Michał Mirosław
2020-11-04 14:44   ` Lee Jones
2020-09-26 23:59 ` [PATCH 4/5] mfd: tps65910: clean up after switching to regmap Michał Mirosław
2020-11-04 14:45   ` Lee Jones
2020-09-26 23:59 ` [PATCH 5/5] mfd: tps65910: remove unused pointers Michał Mirosław
  -- strict thread matches above, loose matches on Subject: below --
2020-07-17  3:41 linux-next: build failure after merge of the mfd tree Stephen Rothwell
2020-07-17  6:56 ` Lee Jones
2020-07-17  6:59   ` Stephen Rothwell
2020-07-17  7:11     ` Lee Jones
2020-02-04  3:03 Stephen Rothwell
2020-02-04  7:53 ` Lee Jones
2020-02-04 10:04   ` Srinivas Kandagatla
2019-04-03  0:40 Stephen Rothwell
2018-12-17  5:38 Stephen Rothwell
2017-12-04  3:19 Stephen Rothwell
2017-12-04  9:10 ` Greg KH
2017-12-04  9:39 ` Lee Jones
2017-12-05 23:32   ` Stephen Rothwell
2017-12-06  8:58     ` Lee Jones
2017-12-12  2:13       ` Stephen Rothwell
2017-12-12  8:13         ` Lee Jones
2017-12-12 11:54           ` Stephen Rothwell
2017-05-31  2:23 Stephen Rothwell
2017-05-31  3:36 ` Stephen Rothwell
2017-06-05  3:28 ` Stephen Rothwell
2017-04-04  6:44 Stephen Rothwell
2017-04-04  8:19 ` Lee Jones
2017-04-04  8:21   ` Lee Jones
2017-04-04 12:31     ` Andy Shevchenko
2017-04-10  2:11       ` Stephen Rothwell
2017-04-10  6:55         ` Lee Jones
2017-04-10  7:53           ` Stephen Rothwell
2016-02-29  3:51 Stephen Rothwell
2016-03-01  1:19 ` Kuninori Morimoto
2016-03-01  1:35   ` Kuninori Morimoto
2016-03-02  4:00     ` Mark Brown
2015-10-15  2:26 Stephen Rothwell
2015-10-15  3:35 ` kbuild test robot
2015-10-15  8:59 ` Arnd Bergmann
2015-10-15  9:17   ` Lee Jones
2015-10-15  9:45   ` Andy Shevchenko
2015-10-15 12:04   ` Christoph Hellwig
2015-10-15 12:28     ` Arnd Bergmann
2015-10-16  1:27       ` Stephen Rothwell
2015-10-16 10:10         ` Arnd Bergmann
2015-03-04  0:34 Stephen Rothwell
2015-03-04  0:37 ` Stephen Rothwell
2015-03-04  7:26 ` Sascha Hauer
2014-11-11  2:32 Stephen Rothwell
2014-11-04  5:40 Stephen Rothwell
2014-11-04  7:54 ` Krzysztof Kozlowski
2014-11-04  8:09   ` Lee Jones
2014-08-22 16:56 Stephen Rothwell
2014-08-22 19:09 ` Lee Jones
2013-04-08  4:21 Stephen Rothwell
2013-04-08  4:45 ` Alexander Shiyan
2013-04-08  9:22   ` Samuel Ortiz
2013-04-08 16:27     ` Re[2]: " Alexander Shiyan
2013-04-09  7:20       ` Samuel Ortiz
2013-04-09 15:47         ` Re[2]: " Alexander Shiyan
2013-04-09 16:12           ` Samuel Ortiz
2013-04-09 16:50             ` Rob Herring
2013-04-09 20:51               ` Samuel Ortiz
2012-09-25  3:47 Stephen Rothwell
2012-09-25  6:47 ` Matthias Kaehlcke
2012-09-25  8:43 ` Samuel Ortiz
2012-07-09  3:57 Stephen Rothwell
2012-07-09 10:52 ` Samuel Ortiz
2012-07-10  9:20 ` Samuel Ortiz
2012-05-21  3:42 Stephen Rothwell
2012-05-21  8:08 ` Lee Jones
2012-05-21  8:40   ` Stephen Rothwell
2012-05-21  9:01     ` Lee Jones
2012-05-21  9:10       ` Stephen Rothwell
2012-05-21  9:19         ` Lee Jones
2012-05-21  9:54           ` Mark Brown
2012-05-21 10:28             ` Lee Jones
2012-05-22 22:42               ` Samuel Ortiz
2012-05-22 22:52                 ` Stephen Rothwell
2012-05-23 14:34                   ` Samuel Ortiz
2012-05-21  8:30 ` Lee Jones
2012-05-21  9:07   ` Stephen Rothwell
2012-05-16  6:09 Stephen Rothwell
2012-05-18  8:39 ` Samuel Ortiz
2012-05-14  3:37 Stephen Rothwell
2012-05-14 20:22 ` Samuel Ortiz
2012-03-19  2:13 Stephen Rothwell
2012-03-19  6:19 ` Laxman Dewangan
2012-03-20 12:40 ` Samuel Ortiz
2012-02-21  1:31 Stephen Rothwell
2012-02-21 11:32 ` Samuel Ortiz
2011-12-20  3:17 Stephen Rothwell
2011-12-20 17:37 ` Samuel Ortiz
2011-09-19  6:19 Stephen Rothwell
2011-09-19  9:43 ` Samuel Ortiz
2011-09-16  3:55 Stephen Rothwell
2011-09-16  7:16 ` Uwe Kleine-König
2011-09-16  8:39   ` Stephen Rothwell
2011-09-18 17:15 ` Samuel Ortiz
2011-06-21  3:03 Stephen Rothwell
2011-06-21 10:07 ` Mark Brown
2011-06-21 17:58 ` Samuel Ortiz
2011-02-22  3:20 Stephen Rothwell
2011-02-22  9:21 ` Samuel Ortiz
2010-09-16  2:54 Stephen Rothwell
2010-09-19 22:27 ` Samuel Ortiz
2010-08-09  1:40 Stephen Rothwell
2010-08-09  8:51 ` Mike Rapoport
2010-08-09  9:10 ` Samuel Ortiz
2010-05-19  4:03 Stephen Rothwell
2010-05-19  4:23 ` Rabin VINCENT
2010-05-19  9:57   ` Samuel Ortiz
2010-05-19 14:14     ` Stephen Rothwell
2010-04-08  2:57 Stephen Rothwell
2010-04-08  9:33 ` Samuel Ortiz
2010-04-07  5:02 Stephen Rothwell
2010-04-07  8:53 ` Samuel Ortiz
2010-04-07 16:24   ` Stephen Rothwell
2010-04-07  4:51 Stephen Rothwell
2010-04-07  8:52 ` Samuel Ortiz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).